GNU bug report logs - #41192
[PATCH 0/2] wireguard-tools: Fix wg-quick

Previous Next

Full log

Message #21 received at 41192 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41192 <at> debbugs.gnu.org
Subject: Re: [bug#41192] [PATCH 2/2] gnu: wireguard-tools: Fix wg-quick.
Date: Mon, 11 May 2020 15:58:34 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 11, 2020 at 08:53:10PM +0200, Brice Waegeneire wrote:
> +         (add-after 'install 'install-contrib

How about calling this phase "install-docs" or "install-contrib-docs"?.

> +               (wrap-program (string-append out "/bin/wg-quick")
> +                 `("PATH" ":" = ,(append inputs-sbin
> +                                         (list coreutils
> +                                               "/run/setuid-programs"))))
> +               #t))))))

Setuid Guix only exists on Guix System, so we should drop this wrapper.
It's okay to make users do `sudo wg-quick` or similar.

> +    (native-inputs
> +     `(("bash" ,bash)))  ; for contrib scripts using /dev/tcp
> +    (inputs
> +     `(("resolvconf" ,openresolv)
> +       ("coreutils" ,coreutils)

Is coreutils not already available in the build environment?

> +       ("bash" ,bash)                   ; for contrib scripts using /dev/tcp

IIUC, we don't need to include Bash in both 'native-inputs' and
'inputs'. If this Bash will be used at run-time (e.g. as a script
shebang), we should just use 'inputs'.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.