GNU bug report logs - #41191
[PATCH] doc: Specify the branch name in the title of a patch.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Mon, 11 May 2020 18:44:02 UTC

Severity: normal

Tags: patch

Done: Brice Waegeneire <brice <at> waegenei.re>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41191: closed ([PATCH] doc: Specify the branch name in the
 title of a patch.)
Date: Tue, 12 May 2020 20:13:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 12 May 2020 20:12:50 +0000
with message-id <f179ae68794bd69fe8e46e4576c2a7bf <at> waegenei.re>
and subject line Re: [bug#41191] [PATCH] doc: Specify the branch name in the title of a patch.
has caused the debbugs.gnu.org bug report #41191,
regarding [PATCH] doc: Specify the branch name in the title of a patch.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41191: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41191
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: Specify the branch name in the title of a patch.
Date: Mon, 11 May 2020 20:42:54 +0200
* doc/contributing.texi (Submitting Patches): Add branch name in the
title of a patch if different than master.
---
 doc/contributing.texi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 9583120742..618d9008cc 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1083,12 +1083,14 @@ guix pull --url=/path/to/your/checkout --profile=/tmp/guix.master
 @end enumerate
 
 When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as
-a subject.  You may use your email client or the @command{git
-send-email} command (@pxref{Sending a Patch Series}).  We prefer to get
-patches in plain text messages, either inline or as MIME attachments.
-You are advised to pay attention if your email client changes anything
-like line breaks or indentation which could potentially break the
-patches.
+a subject, if your patch is to be applied on a branch other than master,
+say @code{core-updates}, specify it in the subject like @samp{[PATCH
+core-updates] @dots{}}.  You may use your email client or the
+@command{git send-email} command (@pxref{Sending a Patch Series}).  We
+prefer to get patches in plain text messages, either inline or as MIME
+attachments.  You are advised to pay attention if your email client
+changes anything like line breaks or indentation which could potentially
+break the patches.
 
 When a bug is resolved, please close the thread by sending an email to
 @email{@var{NNN}-done@@debbugs.gnu.org}.
-- 
2.26.2



[Message part 3 (message/rfc822, inline)]
From: Brice Waegeneire <brice <at> waegenei.re>
To: Leo Famulari <leo <at> famulari.name>
Cc: 41191-done <at> debbugs.gnu.org
Subject: Re: [bug#41191] [PATCH] doc: Specify the branch name in the title of
 a patch.
Date: Tue, 12 May 2020 20:12:50 +0000
On 2020-05-11 19:43, Leo Famulari wrote:
> On Mon, May 11, 2020 at 08:42:54PM +0200, Brice Waegeneire wrote:
>> +a subject, if your patch is to be applied on a branch other than 
>> master,
>> +say @code{core-updates}, specify it in the subject like @samp{[PATCH
> 
> Wrap both master and core-updates in @code? Or neither?
> 
> Otherwise LGTM!

I have wrapped master in @code, pushed as 
a1891cbffb9909d4a74faf242f28f0f2e998eb2f.

Thank you for the review Leo!


This bug report was last modified 5 years and 14 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.