From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 14:05:58 2020 Received: (at submit) by debbugs.gnu.org; 11 May 2020 18:05:58 +0000 Received: from localhost ([127.0.0.1]:53214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCoQ-0002xQ-68 for submit@debbugs.gnu.org; Mon, 11 May 2020 14:05:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:56556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCoO-0002xG-1p for submit@debbugs.gnu.org; Mon, 11 May 2020 14:05:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYCoN-0007Wd-NW for guix-patches@gnu.org; Mon, 11 May 2020 14:05:55 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:51241) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYCoM-0002Mr-OK for guix-patches@gnu.org; Mon, 11 May 2020 14:05:55 -0400 Received: from localhost (unknown [46.237.174.28]) by mira.cbaines.net (Postfix) with ESMTPSA id 9A40327BBE1 for ; Mon, 11 May 2020 19:05:52 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 1ce7801c for ; Mon, 11 May 2020 18:05:50 +0000 (UTC) User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH 0/2] Fix bitcoin-core build. Date: Mon, 11 May 2020 19:05:47 +0100 Message-ID: <87h7wmpcsk.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 14:05:52 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Christopher Baines (2): gnu: finance: bitcoin-core: Reformat the package definition. gnu: finance: bitcoin-core: Disable a test that spuriously fails. gnu/packages/finance.scm | 69 +++++++++++++++++++++------------------- 1 file changed, 37 insertions(+), 32 deletions(-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl65k/tfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdQXg/9FAAGc20crCV9U46ctwQihr7qe3zu+/LJQe1PcYrVfAEtKDJEYCgEnLbN 3mS1Y1WHMkqNS4MvmdBOjtFC4262zxeMOD6stCwgtzw2p3HG8ng6kCWff1D4d4Be nY+X5y8nldw0OfT0L29/zBTONkfZsGXLTc2PTTB7JRGmvmdr8+UZwj0Bw2+KL0z5 SANtSM1o3qcFb9+5G2tX+SUNWwf9+fA0wkgXIqdHSlNgbJzLVrDX4+o16YFn2qzz KbQpddufEOwu7qNNfbwfb8wPwF9Gk8hxiR6FQO4iUI+O86AsJVgCBKbe0D5Q3vBi KM4ComaF1kH9Qv0aCgKN8CMAaJnyUPsrXkHUSeOIaWuKfvLwbL62SxanBvJDuFEl Gyc2Lj+yh37krnflv0b3AbW1FX2bKGRJwAdBBbqcB5Q59JlEWVv3KkCtrBABLjq+ p0Qq7LSsVluIWZTDf3EcApyV1/IsUFR6vwkdOoDNVsI6Ta1MPGB8x/lwx04E6gld jYZa0RRGIpk41zRntDg5nyfXbTnaMn9vZFcwRQxrhVGb9deYbHUWKOKVTeGrXQ6H GKz/E32Ey1m/YL4hUjvmAYUhHano3YWUxACD+Ulr0FkRuN7EEIpQsRDd1PBA7DoH CeI+qedxdMlCiLxZvD2x6ChYCJENBhOUSYtBKBR/U87S+wBk4lg= =QKX/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 14:17:01 2020 Received: (at 41190) by debbugs.gnu.org; 11 May 2020 18:17:01 +0000 Received: from localhost ([127.0.0.1]:53223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCz7-0003DY-8t for submit@debbugs.gnu.org; Mon, 11 May 2020 14:17:01 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCz5-0003DK-Fv for 41190@debbugs.gnu.org; Mon, 11 May 2020 14:16:59 -0400 Received: from localhost (unknown [46.237.174.28]) by mira.cbaines.net (Postfix) with ESMTPSA id C23BA27BBE3 for <41190@debbugs.gnu.org>; Mon, 11 May 2020 19:16:58 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 650676fd for <41190@debbugs.gnu.org>; Mon, 11 May 2020 18:16:56 +0000 (UTC) From: Christopher Baines To: 41190@debbugs.gnu.org Subject: [PATCH 2/2] gnu: finance: bitcoin-core: Disable a test that spuriously fails. Date: Mon, 11 May 2020 19:16:56 +0100 Message-Id: <20200511181656.25849-2-mail@cbaines.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200511181656.25849-1-mail@cbaines.net> References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/finance.scm (bitcoin-core)[arguments]: Disable a test. --- gnu/packages/finance.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 094b25c9fe..85023f556c 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -155,6 +155,10 @@ (lambda _ (invoke "python3" "./test/functional/test_runner.py" + ;; Test fails due to Python deprecation warning in the + ;; test. This is fixed upstream + ;; https://github.com/bitcoin/bitcoin/pull/17931 + "--exclude=p2p_invalid_messages" (string-append "--jobs=" (number->string (parallel-job-count)))) #t))))) (home-page "https://bitcoin.org/en/") -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 14:17:01 2020 Received: (at 41190) by debbugs.gnu.org; 11 May 2020 18:17:01 +0000 Received: from localhost ([127.0.0.1]:53225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCz7-0003Da-F7 for submit@debbugs.gnu.org; Mon, 11 May 2020 14:17:01 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYCz5-0003DL-G5 for 41190@debbugs.gnu.org; Mon, 11 May 2020 14:16:59 -0400 Received: from localhost (unknown [46.237.174.28]) by mira.cbaines.net (Postfix) with ESMTPSA id A4F0C27BBE1 for <41190@debbugs.gnu.org>; Mon, 11 May 2020 19:16:58 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 82d38ae2 for <41190@debbugs.gnu.org>; Mon, 11 May 2020 18:16:56 +0000 (UTC) From: Christopher Baines To: 41190@debbugs.gnu.org Subject: [PATCH 1/2] gnu: finance: bitcoin-core: Reformat the package definition. Date: Mon, 11 May 2020 19:16:55 +0100 Message-Id: <20200511181656.25849-1-mail@cbaines.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <87h7wmpcsk.fsf@cbaines.net> References: <87h7wmpcsk.fsf@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Change the indentation to match what Emacs does. * gnu/packages/finance.scm (bitcoin-core): Change indentation of many lines. --- gnu/packages/finance.scm | 65 ++++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index dfc89cae1e..094b25c9fe 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -104,13 +104,13 @@ (name "bitcoin-core") (version "0.19.1") (source (origin - (method url-fetch) - (uri - (string-append "https://bitcoincore.org/bin/bitcoin-core-" - version "/bitcoin-" version ".tar.gz")) - (sha256 - (base32 - "1h3w7brc18145np920vy7j5ms5hym59hvr40swdjx34fbdaisngj")))) + (method url-fetch) + (uri + (string-append "https://bitcoincore.org/bin/bitcoin-core-" + version "/bitcoin-" version ".tar.gz")) + (sha256 + (base32 + "1h3w7brc18145np920vy7j5ms5hym59hvr40swdjx34fbdaisngj")))) (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config) @@ -127,35 +127,36 @@ ("qtbase" ,qtbase))) (arguments `(#:configure-flags - (list - ;; Boost is not found unless specified manually. - (string-append "--with-boost=" - (assoc-ref %build-inputs "boost")) - ;; XXX: The configure script looks up Qt paths by - ;; `pkg-config --variable=host_bins Qt5Core`, which fails to pick - ;; up executables residing in 'qttools', so we specify them here. - (string-append "ac_cv_path_LRELEASE=" - (assoc-ref %build-inputs "qttools") - "/bin/lrelease") - (string-append "ac_cv_path_LUPDATE=" - (assoc-ref %build-inputs "qttools") - "/bin/lupdate")) + (list + ;; Boost is not found unless specified manually. + (string-append "--with-boost=" + (assoc-ref %build-inputs "boost")) + ;; XXX: The configure script looks up Qt paths by + ;; `pkg-config --variable=host_bins Qt5Core`, which fails to pick + ;; up executables residing in 'qttools', so we specify them here. + (string-append "ac_cv_path_LRELEASE=" + (assoc-ref %build-inputs "qttools") + "/bin/lrelease") + (string-append "ac_cv_path_LUPDATE=" + (assoc-ref %build-inputs "qttools") + "/bin/lupdate")) #:phases - (modify-phases %standard-phases - (add-before 'configure 'make-qt-deterministic + (modify-phases %standard-phases + (add-before 'configure 'make-qt-deterministic (lambda _ - ;; Make Qt deterministic. - (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1") - #t)) - (add-before 'check 'set-home + ;; Make Qt deterministic. + (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1") + #t)) + (add-before 'check 'set-home (lambda _ - (setenv "HOME" (getenv "TMPDIR")) ; tests write to $HOME - #t)) - (add-after 'check 'check-functional + (setenv "HOME" (getenv "TMPDIR")) ; tests write to $HOME + #t)) + (add-after 'check 'check-functional (lambda _ - (invoke "python3" "./test/functional/test_runner.py" - (string-append "--jobs=" (number->string (parallel-job-count)))) - #t))))) + (invoke + "python3" "./test/functional/test_runner.py" + (string-append "--jobs=" (number->string (parallel-job-count)))) + #t))))) (home-page "https://bitcoin.org/en/") (synopsis "Bitcoin peer-to-peer client") (description -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 16:08:20 2020 Received: (at 41190) by debbugs.gnu.org; 11 May 2020 20:08:20 +0000 Received: from localhost ([127.0.0.1]:53394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEip-0008Aq-SM for submit@debbugs.gnu.org; Mon, 11 May 2020 16:08:20 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEio-0008Ad-3g for 41190@debbugs.gnu.org; Mon, 11 May 2020 16:08:18 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 155115C00ED; Mon, 11 May 2020 16:08:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 May 2020 16:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=s8nJdkCRjSYCKgBxBdWmoHPWgt BXlcahb3W43oqm4po=; b=sZW09Day6z2QxFYMHHAm8judjueAsEbsWopRlsTtz2 3anJFlSuYXF++0YoaXhBwAd6UOupNAzjJcDpAuyesBUH2jYtju3aLEnCn6Wdv6Km /eFyQaC0W3y6RLlWGKUH9lRjn6HXBoBS10oJIa1TuxSOLALnNIXn9fUTYkWBQS6H jeV6yGC9B8Z/mERIcluYoXCIeA969LScJC54DlsFSAVPyiDXMq/3cgE3eLECLOA4 3vEQH8pfwXKCQrm1yHhTS4DghAV/RyHtQmCD73pidahzkddr0PSCjp9IoDkQZ0fx jXQcFnQCA4HDnOw1ONPh7h3ieVHlxeFqiwNhQwa7lh3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s8nJdk CRjSYCKgBxBdWmoHPWgtBXlcahb3W43oqm4po=; b=huOEKf4qDk5MJVgeOf788j IzwpuizzUiOBcfsl54UmMVNzYw7RESw0IySmbaQQES/ssmi35m5QfhfKCikPUBg1 /ojYrNdVBM71QDJIFZXbOINDTK0hXl/etnOgRGAl5fuUSdE87wJ+xb00FyvgMSs7 xxmLkDCp370C5tISVNtXMiQyClz/RiT/s1IouuMrl+5kYEPqZ+DX1xjid/wFl46S wR5uQhEZaJvVMB2g2UQd4371f5Q7nqnrJVm8wH6mKTpfYiIeJFs8urJkSsfHo4Bf 1Vx1hhmCJYxPA/L+zMluxmsc3D2Evqq69qc50hmM7bae3wbnSrfmkpzNf3Fl4P4g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecuggftrfgrthhtvghrnheptddvgfegveegiedvffeujeeitd etvdektddugffgtdegfeeitdeikeffudfgueffnecukfhppeekgedrvddtvddrieekrdej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsg grkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 98E4B30662A5; Mon, 11 May 2020 16:08:12 -0400 (EDT) From: Marius Bakke To: Christopher Baines , 41190@debbugs.gnu.org Subject: Re: [bug#41190] [PATCH 2/2] gnu: finance: bitcoin-core: Disable a test that spuriously fails. In-Reply-To: <20200511181656.25849-2-mail@cbaines.net> References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> <20200511181656.25849-2-mail@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 11 May 2020 22:08:10 +0200 Message-ID: <878shyw7yt.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > * gnu/packages/finance.scm (bitcoin-core)[arguments]: Disable a test. Uff, I pushed a fix for this in 46bbdef24701db8e61326b0645fd426a17111a11 that took the upstream patch. You are too polite, asking for reviews instead of pushing straight to master! :-P Sorry for the duplicate work. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl65sKsACgkQoqBt8qM6 VPrVOAgA0FoAMrvLYOwBk6PGKT54cnSmRVUowa4LwvTecQyDPo3GdayMEGCaXdkL Pj27bDC+SXNAfnT6sofwMOUe1C0R+HydfxBDPTKXGPbBEetwYqOZ3ZbblYul+3H3 IkNS/NOD5g1p6fQhgXe9WrZr2r0nukUQyRCw4QYlKSZd5i9L3xcHzABnE/zbOq9h C+Lar1ZBA+NhPiE+s6NcmijteUxUn0N+qG0CQx/Ob3DH9E2eCiaJ7XT/fsVfYJwu rwBmtmgPhmUgVxNovhsT/Me9IozaWuqZrt2mgmyaNqiL/sywfhuFn58qo/K25YVu j2u4p8f+DCq7mEalNQ5wYk5aNYb3rw== =m/Bc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 16:08:59 2020 Received: (at 41190) by debbugs.gnu.org; 11 May 2020 20:08:59 +0000 Received: from localhost ([127.0.0.1]:53399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEjT-0008Bh-4o for submit@debbugs.gnu.org; Mon, 11 May 2020 16:08:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:49255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEjS-0008BV-7c for 41190@debbugs.gnu.org; Mon, 11 May 2020 16:08:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 32DF45C014D; Mon, 11 May 2020 16:08:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 May 2020 16:08:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=ruWysoFkzmuA3rnA+6yB6g0e0r D29Kp3jNsFQ74UtJo=; b=yHgrA2oK2tQjYlxjIRHrxS+hKwyAoykK5qKFKg6tW9 zHGmHgrGT9mgKc0dbX+oIneJD7fk381oIDw354+HLyvylmr4lxEL3yVIn2ZYwx53 /KRoZsggw1vxXr0p2CJpYnCWYwxqnMGDVPKYtl+hGVu3FoZXCpV2+Nx49M6i+brv nivyl/nmrmd4op2DiO0dpdrquEbajKOklnq+uDxLSKGgDy58SkWpZlvVFUUrhrpK IqP6xzY/1ym46sJKloV02WVR254i06GvgjendeU9HpFM13PpeO3btdoWH1E4WVic 3Sgx6czvg/Bph5G2fnbTbnSb1z8GAurgkyQIUs+jbpFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ruWyso FkzmuA3rnA+6yB6g0e0rD29Kp3jNsFQ74UtJo=; b=DZ7/6pcDbRp7WrfLVg4yvM Gn7AGdKe+1U4bVjCn8zhgZQyTONZkP5OccTZz2j0eg3iNxfLi6pOfUc8cYNR6tMv GS84+Iv1H/tTuGGnCU6OvrRYNOy1ooKByanHEJQsSzGIU7peptLLwSM2zSkgPFfH D1hfsk19rTbHw2ARFi7tNr5qlrfWqDFaO8AlZe973U0IQoa/LVk/JksaHkaQGmSV AJ1tsgkW48a/GeQYPLVaab3k7i9HMrqU18TuE5pvBtDHG/Sb7dKtTSkhFKAjAiGg dQzS5zQUIqIazBYpF5jBuo2UAEVwV2VwwZ5o+HXEKw9OeTSUEvX6+c6UnNmo9BHw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecuggftrfgrthhtvghrnheptddvgfegveegiedvffeujeeitd etvdektddugffgtdegfeeitdeikeffudfgueffnecukfhppeekgedrvddtvddrieekrdej heenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsg grkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id BB39B30662AA; Mon, 11 May 2020 16:08:52 -0400 (EDT) From: Marius Bakke To: Christopher Baines , 41190@debbugs.gnu.org Subject: Re: [bug#41190] [PATCH 1/2] gnu: finance: bitcoin-core: Reformat the package definition. In-Reply-To: <20200511181656.25849-1-mail@cbaines.net> References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 11 May 2020 22:08:51 +0200 Message-ID: <875zd2w7xo.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > Change the indentation to match what Emacs does. > > * gnu/packages/finance.scm (bitcoin-core): Change indentation of many lines. LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl65sNMACgkQoqBt8qM6 VPoPtggAtXbXCMoWX6j7oqXm8obrbWmTKzZRwP9MxcuU8EW4fTpe9heDJDDUsM7k 3BAJyM5v0DnzqoX9fYcHL83E5ksRMqDwVuKhl0MuUsrLXoTdtlTwl3zeEk+Enul5 S/N/iuhRU1wnqhCAk9WcUemW/BY1vHp3cL5O1bZWUTI4skEPIxVHoF4ENhXnW3on lQfZ9jMjZ+GO6cETLitYtjTO2t1rELE4r2TwwovlsH08gjtoi6xwk4kp/q0/Txx+ vy/gfa6w2qm+3sOTSvA16pJn+N9DOxiGEpKnA8Uvyv71WCdDOZxWSXGeI137lymn t54MzAWrT4NheSL5dMQlcntO47IBZg== =6pgI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 16:10:54 2020 Received: (at 41190) by debbugs.gnu.org; 11 May 2020 20:10:54 +0000 Received: from localhost ([127.0.0.1]:53406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYElK-0008Ex-Fw for submit@debbugs.gnu.org; Mon, 11 May 2020 16:10:54 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYElI-0008Ek-Rb for 41190@debbugs.gnu.org; Mon, 11 May 2020 16:10:53 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BCA1E5C0139; Mon, 11 May 2020 16:10:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 May 2020 16:10:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=8nVUuBYAKpmaXcA3UHMRYMN2yL CRxWNkhcAzNcBztvc=; b=bnJ/PgJZc9ITMhhJeHiUWYaE0bhChdvuEamVO/7c/j ye6qZFXoLFZHa70e89zIBPnm/33X2l+hxNrg/aOjmi9X8mc57C5BqwB7O9KP5vRi meJcmlUtiazS83RszSd5aotBoux0mMudjUse0eVi9CWSBetzAuw4HrBHCatcbaa1 pmcmZ9WElkvEEZ52AqS5NtxndRMJwugBfPRAepYGqjDMklE9cROrvfJRP67jaeXv fRjigIp4VC+RirRNrTSEixq3e6MNzD61NDaGHWc5uxQSmq8apC59pTIi7Yt7TwX7 K2XVF/+2U8Ht8LcOdkeLszwxadXluubfKQ2d3bpOBxpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8nVUuB YAKpmaXcA3UHMRYMN2yLCRxWNkhcAzNcBztvc=; b=mTxDb6QkSJSZYlY+T18IBW SV5E0IeUBzOpH8RcS6lcjjb2hKpnjHEM+vSbAp5T8KTYpucwldlI8SD6+1wqDcVJ IXh6nhPzAQfyz87HGoh0T+8FcET6JTvaQOVWoJh0NwvsOYJ8zQ/qM9j0Dl8+T7/k VIEOH3ED0Vf294hkfGHCaY0jZSluZ+p4n//mYOol3ukUgyDUIU8+JaLPdTP7ktNU RQbLfm6AqEKXQaVGbW+twqgpaH6+emYG8Ym+zKBtIEZP/5gEKO7aRMe1RlXYOHWm JyL60vzey9A4zTbs034l8ojdCdlnUZsENpUSUfxN6IbYD6BIpwF2Zt60Vff0YS3A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgddugedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecuggftrfgrthhtvghrnheptddvgfegveegiedvffeujeeitd etvdektddugffgtdegfeeitdeikeffudfgueffnecukfhppeekgedrvddtvddrieekrdej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsg grkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F87A30662A1; Mon, 11 May 2020 16:10:47 -0400 (EDT) From: Marius Bakke To: Christopher Baines , 41190@debbugs.gnu.org Subject: Re: [bug#41190] [PATCH 1/2] gnu: finance: bitcoin-core: Reformat the package definition. In-Reply-To: <20200511181656.25849-1-mail@cbaines.net> References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 11 May 2020 22:10:45 +0200 Message-ID: <873686w7ui.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41190 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain I don't think mentioning the module in the commit header is necessary, as it is only an implementation detail. Referring to 'gnu: finance: '. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl65sUUACgkQoqBt8qM6 VPqbYgf9HgyLSEYP1GO7C0A+D/Njwrd8GVaHSGXBvamppArTjNMr/vqRlnDUVRv+ 8CIVjoPN/ieYbgQovlKX4qOlhnA7WXJ1Q2MyXOvGmpYyXq3kX0wPUMwfiOrYsnxz wBTqNGaEUyqnhr4eCRTRKgADl8JbsL6UTl/1HoMlTR51PShTQQlAoncSDW84CC2m pg8HoZfepQa6THowoFNJZpugaim1eS7hMorFmnQp60GQBNuDapcHL14wqWtgtaVD CsxrKkUOkivlQK77LBcnRdaRdZ4aKtLGI9oMekNyu4MzC6pVfgHqVHnKOt0d46Jg 5F3zmHOfD8hO2bz1suEelIO+gZEyTQ== =dzqk -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 14:00:07 2020 Received: (at 41190) by debbugs.gnu.org; 13 May 2020 18:00:07 +0000 Received: from localhost ([127.0.0.1]:59457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvfq-0001SE-Va for submit@debbugs.gnu.org; Wed, 13 May 2020 14:00:07 -0400 Received: from mira.cbaines.net ([212.71.252.8]:57638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvfp-0001PV-9f for 41190@debbugs.gnu.org; Wed, 13 May 2020 14:00:05 -0400 Received: from localhost (unknown [46.237.173.210]) by mira.cbaines.net (Postfix) with ESMTPSA id 35BA827BBE1; Wed, 13 May 2020 19:00:04 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c017e3f4; Wed, 13 May 2020 18:00:01 +0000 (UTC) References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> <20200511181656.25849-2-mail@cbaines.net> <878shyw7yt.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Marius Bakke Subject: Re: [bug#41190] [PATCH 2/2] gnu: finance: bitcoin-core: Disable a test that spuriously fails. In-reply-to: <878shyw7yt.fsf@devup.no> Date: Wed, 13 May 2020 19:00:01 +0100 Message-ID: <87o8qrogv2.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41190 Cc: 41190@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> * gnu/packages/finance.scm (bitcoin-core)[arguments]: Disable a test. > > Uff, I pushed a fix for this in 46bbdef24701db8e61326b0645fd426a17111a11 > that took the upstream patch. > > You are too polite, asking for reviews instead of pushing straight to > master! :-P > > Sorry for the duplicate work. No problem, at least both of us have looked at it, which is sort of like patch review :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl68NaFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfAIw//fjf8oVuNmU0kb4oUcbXCe9w956sqE/L87pV54GwAfryxnwc4AslOLLhb S6O+V6cM7HpQInZze7EfXyEAQNd5sayEsRnMp72TuhjEDgwloxMru/Q97xG93yTj H/iT8AWdQgEaTSKJqFb9fL7j9YAXLRIy/mFcjcKTcmzVfBU6caADeX2MQUpBaYji aOH7toAyGy5AXphuYNBFb7gJh0nRq3E1s8wSgcnd2TmS69p6N9YY1GVck3obgOt5 1tbrgIAnrY0Bk1iWG4PELdF3lNVhhflWmt76hq6ID3BTHYIULdS8dBfqRqgQ+W20 UybUI9aLMwLvB+9CYDe6DXkch4/zYLPbXlxPOp8OlcdMD7QqSFE23fQVwzB8Xtbh +62MTO5nOozshzbFI1DJpYMbWZDtGp4INm951cT2AqS3J4ITPS8gj94f0a5A6a8F eVA4XlQyJePKq7RsTvTNRXSDA0isU7LFezaCrZXfYP6a+9b5g4y1/zehM7xbfwxe VC2CvQ8tCQ1Yle2JhMGgnW+VqRlMdGooHMayDo5OOFk6WVFfDvk9xApc5Crxaq3o 4DF+5TGODA4SCdF79ShkgXyzOWoVBkkYta5as8gdmBk/Fv/fDDJ24HDZhDz9brPV WLn/pejvirpFo1zg5eHzjBmOL9N9WoGIl6sWsNfknyCZqD6ww84= =49IQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 14:03:14 2020 Received: (at 41190-done) by debbugs.gnu.org; 13 May 2020 18:03:14 +0000 Received: from localhost ([127.0.0.1]:59469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvis-0003a7-Ar for submit@debbugs.gnu.org; Wed, 13 May 2020 14:03:14 -0400 Received: from mira.cbaines.net ([212.71.252.8]:57654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYvip-0003Zx-Kc for 41190-done@debbugs.gnu.org; Wed, 13 May 2020 14:03:12 -0400 Received: from localhost (unknown [46.237.173.210]) by mira.cbaines.net (Postfix) with ESMTPSA id 2C0F227BBE1; Wed, 13 May 2020 19:03:11 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c9a49c20; Wed, 13 May 2020 18:03:08 +0000 (UTC) References: <87h7wmpcsk.fsf@cbaines.net> <20200511181656.25849-1-mail@cbaines.net> <875zd2w7xo.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Marius Bakke Subject: Re: [bug#41190] [PATCH 1/2] gnu: finance: bitcoin-core: Reformat the package definition. In-reply-to: <875zd2w7xo.fsf@devup.no> Date: Wed, 13 May 2020 19:03:08 +0100 Message-ID: <87mu6bogpv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41190-done Cc: 41190-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> Change the indentation to match what Emacs does. >> >> * gnu/packages/finance.scm (bitcoin-core): Change indentation of many lines. > > LGTM. Great, I've gone ahead and pushed this as 8ba4d8a347fbdf9fe09e8ac801b4ac0586ac382a. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl68NlxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xen/A//fuoynr7ypAAU3A3RHyLpKEWXxPZSETOCjDxCzUmK0F9uBGOyJ26gOZuY TS6uL+Hj+EKZfmVTn3A/hIODp2F7RiIGa3G6/hVbaQya5RzENtimYxsdOPJBbzzn cFdNFnIk7OuIVHzlx/dP/zwnpOCyW/l8QOHGYfpAHQ/YkvgVZznYqguqD3OHSSeP rklTp1b4Uz0ypSxRPSOVTruKZaZQFUIiwIvJiuf1lcyBd0hYL6T7By+g5hmtpuPV +hZwAxxYPN8hgGr2GdWHuT+Iw6UicSPcz/g0C4aHi15sbo4Gg+7MyC4ORTBNW1vp 6autguSWuLvzFwzs+SZVEfZpQ0Vjna8dHaRpyvhRdJHbsr3K6ZdAgovE8XqJf6jk xtuWuDVKDGFjmlwRkh0xi0uLGOKVg0++cOE0DsCVgstX7A8QicPanUD8U8axs9gj gJzlpCRZweX7shBRbpK1VDCraJQTzi4jhX3QbOna7drn5JyP88HOzFV2Amfy1Nj/ s7JNkqagq/S1XR8wZtC7hv17+j8wm9PmtGO28R9/OoGpCWcI2eE+OzTXxVLcyzAZ 29MZrHcSVDufUeNV5BFdAOZqpAyeJgu3JlmpR4s0oFltxElur1hHjaR7I3GiY2eV now7IORsY3/c1agNpD7Gj+KjXu0P3PEQg1SNJtrqKqPs4i95YVg= =u0qZ -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 18:29:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jun 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator