GNU bug report logs -
#41181
adds emacs-interleave
Previous Next
Reported by: rdes <rdes <at> protonmail.com>
Date: Sun, 10 May 2020 20:22:01 UTC
Severity: normal
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
Full log
Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello Nicolas,
Thanks for the insight. Attached is a patch with the suggestions from the previous email.
-Ryan
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, May 17, 2020 7:00 PM, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> Hello,
>
> rdes rdes <at> protonmail.com writes:
>
> > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
> > variable.
>
> Thank you for the updated patch. Some comments follow.
>
> > +(define-public emacs-interleave
> >
> > - (package
> > - (name "emacs-interleave")
> > - (version "1.4.0")
> > - (source
> > - (origin
> >
> >
> > - (method git-fetch)
> >
> >
> > - (uri
> >
> >
> > - (git-reference
> >
> >
> > - (url "https://github.com/rudolfochrist/interleave")
> >
> >
> > - (commit (string-append "interleave-" version))))
> >
> >
> > - (file-name (git-file-name name version))
> >
> >
> > - (sha256
> >
> >
> > - (base32
> >
> >
> > - "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
> >
> >
>
> Could you move the hash on the line above?
>
> > - (build-system emacs-build-system)
> > - (home-page
> > - "https://github.com/rudolfochrist/interleave")
> >
> >
>
> Could you move the URI on the line above, too?
>
> > - (synopsis
> > - "A minor mode that presents a document buffer next to an orgmode buffer")
> >
> >
>
> A synopsis does not start with "A". You may want to use "guix lint" to
> spot this.
>
> You might use the summary from the home page:
>
> (synopsis "Emacs minor mode to interleave notes and text books")
>
> > - (description
> > - "Interleave is a minor mode that presents a document viewer side
> >
> >
> >
> > +by side to an orgmode buffer with your notes relevant to the current
> > page.")
>
> "orgmode buffer" -> "an Org buffer"
>
> Could you send an updated patch and merge this with the copyright line
> you sent?
>
> Regards,
>
> ---------------------------------------------------------------------------------------------
>
> Nicolas Goaziou
</mail <at> nicolasgoaziou.fr>
[0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch (text/x-patch, attachment)]
This bug report was last modified 4 years and 363 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.