From debbugs-submit-bounces@debbugs.gnu.org Sun May 10 16:21:35 2020 Received: (at submit) by debbugs.gnu.org; 10 May 2020 20:21:35 +0000 Received: from localhost ([127.0.0.1]:50515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXsS6-0008Cp-IS for submit@debbugs.gnu.org; Sun, 10 May 2020 16:21:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:60624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXrs1-0004y2-Cw for submit@debbugs.gnu.org; Sun, 10 May 2020 15:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXrs1-0006tZ-55 for guix-patches@gnu.org; Sun, 10 May 2020 15:44:17 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:36175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXrrz-0002e6-TH for guix-patches@gnu.org; Sun, 10 May 2020 15:44:16 -0400 Date: Sun, 10 May 2020 19:35:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589139325; bh=30MMWrEn5sEO79OBYqOxIL0fDrneYxEYmsaBZU9sVrQ=; h=Date:To:From:Reply-To:Subject:From; b=uh8sqFbVEtNpmn66eEtrNUrH0a3JuapioTUCn7IIo4cgyLPxJM6L/WqxBiimFBnja KSawWiAgVZWJnTO3W6ElOI3sNDrf5fwdgiqUiNo6YvScNXxse4hRtJe1LqJyT7Rp3B k5a5TyqvEwrGHd4ExQblCJNW2b17griGKxn4k/30= To: "guix-patches@gnu.org" From: rdes Subject: adds emacs-interleave Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_81d53680c043018a7b10e45017a12081" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.137; envelope-from=rdes@protonmail.com; helo=mail-40137.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/10 15:35:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 10 May 2020 16:21:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rdes Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_81d53680c043018a7b10e45017a12081 Content-Type: multipart/alternative; boundary="b2_81d53680c043018a7b10e45017a12081" --b2_81d53680c043018a7b10e45017a12081 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 SGVsbG8sCgpUaGUgYXR0YWNoZWQgcGF0Y2ggYWRkcyB0aGUgZW1hY3MtaW50ZXJsZWF2ZSBwYWNr YWdlLgoKUnlhbiBEZXNmb3NzZXM= --b2_81d53680c043018a7b10e45017a12081 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj5IZWxsbyw8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5UaGUgYXR0YWNoZWQgcGF0 Y2ggYWRkcyB0aGUgZW1hY3MtaW50ZXJsZWF2ZSBwYWNrYWdlLjxicj48L2Rpdj48ZGl2Pjxicj48 L2Rpdj48ZGl2PlJ5YW4gRGVzZm9zc2VzPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXYgY2xh c3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrIj48ZGl2IGNsYXNzPSJwcm90b25tYWlsX3Np Z25hdHVyZV9ibG9jay11c2VyIHByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLWVtcHR5Ij48YnI+ PC9kaXY+PGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIj48YnI+ PC9kaXY+PC9kaXY+PGRpdj48YnI+PC9kaXY+ --b2_81d53680c043018a7b10e45017a12081-- --b1_81d53680c043018a7b10e45017a12081 Content-Type: text/x-patch; name="0001-gnu-Add-emacs-interleave.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-emacs-interleave.patch RnJvbSA5ZGQ5MjlmYzRlZDA2OWVlZTA4ZTE4ZWZjMDU1N2EzYmVjMjdiZDQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IFN1biwgMTAgTWF5IDIwMjAgMTU6MTM6MjcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFk ZCBlbWFjcy1pbnRlcmxlYXZlCgotLS0KIGdudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIHwgMjUg KysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI1IGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSBiL2dudS9wYWNrYWdl cy9lbWFjcy14eXouc2NtCmluZGV4IGNlMWIxYzRiMjguLmYwOWFlZGY0M2UgMTAwNjQ0Ci0tLSBh L2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXou c2NtCkBAIC0yMTg0LDYgKzIxODQsMzEgQEAgVGhpcyBidWZmZXIgaXMgdHlwaWNhbGx5IHNob3du IGFzIGEgc2lkZWJhciAoRW1hY3MgdmVydGljYWxseSBzcGxpdHMgdGhlCiB3aW5kb3cpLiIpCiAg ICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQogCisoZGVmaW5lLXB1YmxpYyBlbWFjcy1pbnRl cmxlYXZlCisocGFja2FnZQorICAobmFtZSAiZW1hY3MtaW50ZXJsZWF2ZSIpCisgICh2ZXJzaW9u ICIyMDE5MTEyOS45NTgiKQorICAoc291cmNlCisgICAgKG9yaWdpbgorICAgICAgKG1ldGhvZCB1 cmwtZmV0Y2gpCisgICAgICAodXJpIChzdHJpbmctYXBwZW5kCisgICAgICAgICAgICAgImh0dHBz Oi8vbWVscGEub3JnL3BhY2thZ2VzL2ludGVybGVhdmUtIgorICAgICAgICAgICAgIHZlcnNpb24K KyAgICAgICAgICAgICAiLmVsIikpCisgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAg ICAgICAgICAiMHkxODNnZ2Zta2pqeXdiY3FneWlubXIyMWhzZzJ2YXc0ZDUyYmcxZ3N4YnA2NzN6 YTJtOCIpKSkpCisgIChidWlsZC1zeXN0ZW0gZW1hY3MtYnVpbGQtc3lzdGVtKQorICAoaG9tZS1w YWdlCisgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9ydWRvbGZvY2hyaXN0L2ludGVybGVhdmUiKQor ICAoc3lub3BzaXMgIkludGVybGVhdmluZyB0ZXh0IGJvb2tzIHNpbmNlIDIwMTUiKQorICAoZGVz Y3JpcHRpb24KKyAgICAiSW50ZXJsZWF2ZSBwcmVzZW50cyB5b3VyIFBERiBzaWRlIGJ5IHNpZGUg dG8gYW4gW1todHRwOi8vb3JnbW9kZS5vcmddW09yZyBNb2RlXV0KK2J1ZmZlciB3aXRoIHlvdXIg bm90ZXMsIG5hcnJvd2luZyBkb3duIHRvIGp1c3QgdGhvc2UgcGFzc2FnZXMgdGhhdCBhcmUgcmVs ZXZhbnQgdG8KK3RoZSBwYXJ0aWN1bGFyIHBhZ2UgaW4gdGhlIGRvY3VtZW50IHZpZXdlci4KKyIp CisgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkKKwogKGRlZmluZS1wdWJsaWMgZW1hY3MtbW1t LW1vZGUKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZW1hY3MtbW1tLW1vZGUiKQotLSAKMi4yNi4y Cgo= --b1_81d53680c043018a7b10e45017a12081-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 03:10:33 2020 Received: (at submit) by debbugs.gnu.org; 11 May 2020 07:10:33 +0000 Received: from localhost ([127.0.0.1]:51060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY2a9-0004vZ-6p for submit@debbugs.gnu.org; Mon, 11 May 2020 03:10:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:60832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY2a7-0004vN-Ml for submit@debbugs.gnu.org; Mon, 11 May 2020 03:10:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY2a7-0003rH-Hq for guix-patches@gnu.org; Mon, 11 May 2020 03:10:31 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:42113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY2a5-0000SF-VH for guix-patches@gnu.org; Mon, 11 May 2020 03:10:31 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5D790240003; Mon, 11 May 2020 07:10:25 +0000 (UTC) From: Nicolas Goaziou To: rdes via Guix-patches via Subject: Re: [bug#41181] adds emacs-interleave References: Date: Mon, 11 May 2020 09:10:25 +0200 In-Reply-To: (rdes via Guix-patches via's message of "Sun, 10 May 2020 19:35:17 +0000") Message-ID: <875zd3x7z2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 03:10:27 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 41181@debbugs.gnu.org, rdes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, rdes via Guix-patches via writes: > The attached patch adds the emacs-interleave package. Thank you! Some comments follow. > Subject: [PATCH] gnu: Add emacs-interleave Your commit message should conform to Guix rules. Here, you need to add * gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > +(define-public emacs-interleave > +(package Indentation seems wrong. > + (name "emacs-interleave") > + (version "20191129.958") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://melpa.org/packages/interleave-" > + version > + ".el")) We do not use MELPA sources. Instead, you could use `git-fetch' and extract the latest stable release from here: https://github.com/rudolfochrist/interleave/releases > + (sha256 > + (base32 > + "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8")))) Nitpick: could you move the string on the same line as `base32'? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/rudolfochrist/interleave") Ditto. Could you move the string on the line above? > + (synopsis "Interleaving text books since 2015") I think this synopsis needs to be reworded. As it is, it may not be useful. > + (description > + "Interleave presents your PDF side by side to an [[http://orgmode.org][Org Mode]] Description uses Texinfo syntax, not Org syntax. In this case, however, I think "side by side to an Org buffer" is sufficient. > +buffer with your notes, narrowing down to just those passages that are relevant to > +the particular page in the document viewer. > +") You don't need to end the description with a final newline. It would be nice to expound it a bit. For example, it could be interesting to know this is a minor mode. Don't forget to add a copyright line with your name at the top of the file. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Fri May 15 16:58:57 2020 Received: (at submit) by debbugs.gnu.org; 15 May 2020 20:58:57 +0000 Received: from localhost ([127.0.0.1]:38937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZhPx-000105-Iv for submit@debbugs.gnu.org; Fri, 15 May 2020 16:58:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:44660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZhNU-0000w6-GY for submit@debbugs.gnu.org; Fri, 15 May 2020 16:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhNU-0001Y7-3Y for guix-patches@gnu.org; Fri, 15 May 2020 16:56:20 -0400 Received: from mail-40135.protonmail.ch ([185.70.40.135]:45001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhNS-0007zM-14 for guix-patches@gnu.org; Fri, 15 May 2020 16:56:19 -0400 Date: Fri, 15 May 2020 20:56:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589576172; bh=A6Cplhm+uq5ztqrI2sO4iQUDQB78I3OnTMIaHYuXmOE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=EnJvp45Zs/Fptlzevs54AsYwuY4R0GzJP5QbFxdD3qatc8U/3sX4miUp7q+o9P6T7 O8yQkwzxDjpQkKVit/3NolyVWeKktdsYQhLftXv60sm7Cd45lJG2wN6XQ5faJ0YoUK LJbAxFK6uF6h5MNBP9hVG41O4flp8Bym7WG+SDeo= To: Nicolas Goaziou From: rdes Subject: Re: [bug#41181] adds emacs-interleave Message-ID: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> In-Reply-To: <875zd3x7z2.fsf@nicolasgoaziou.fr> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_1b2291990679f01aceba5bfe4cdac084" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.135; envelope-from=rdes@protonmail.com; helo=mail-40135.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 16:56:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 15 May 2020 16:58:51 -0400 Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rdes Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_1b2291990679f01aceba5bfe4cdac084 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Nicolas, Thanks for the pointers. Attached is an updated patch. Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Monday, May 11, 2020 3:10 AM, Nicolas Goaziou w= rote: > Hello, > > rdes via Guix-patches via guix-patches@gnu.org writes: > > > The attached patch adds the emacs-interleave package. > > Thank you! Some comments follow. > > > Subject: [PATCH] gnu: Add emacs-interleave > > Your commit message should conform to Guix rules. Here, you need to add > > - gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > > > +(define-public emacs-interleave > > +(package > > Indentation seems wrong. > > > - (name "emacs-interleave") > > - (version "20191129.958") > > - (source > > - (origin > > - (method url-fetch) > > > > > > - (uri (string-append > > > > > > - "https://melpa.org/packages/interleave-" > > > > > > - version > > > > > > - ".el")) > > > > > > We do not use MELPA sources. Instead, you could use `git-fetch' and > extract the latest stable release from here: > > https://github.com/rudolfochrist/interleave/releases > > > - (sha256 > > > > > > - (base32 > > > > > > - "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8")))) > > > > > > Nitpick: could you move the string on the same line as `base32'? > > > - (build-system emacs-build-system) > > - (home-page > > - "https://github.com/rudolfochrist/interleave") > > Ditto. Could you move the string on the line above? > > > - (synopsis "Interleaving text books since 2015") > > I think this synopsis needs to be reworded. As it is, it may not be > useful. > > > - (description > > - "Interleave presents your PDF side by side to an [[http://orgmode.o= rg][Org Mode]] > > Description uses Texinfo syntax, not Org syntax. In this case, however, > I think "side by side to an Org buffer" is sufficient. > > > +buffer with your notes, narrowing down to just those passages that are= relevant to > > +the particular page in the document viewer. > > +") > > You don't need to end the description with a final newline. It would be > nice to expound it a bit. For example, it could be interesting to know > this is a minor mode. > > Don't forget to add a copyright line with your name at the top of the fil= e. > > Could you send an updated patch? > > Regards, > > -------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ----------------------------------------------------------------- > > Nicolas Goaziou --b1_1b2291990679f01aceba5bfe4cdac084 Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch RnJvbSAyOGQ4N2VkNWYzZDczNzJhNzU5NDc1YjI4YmM5OTkzNTYwOTUzZDJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IEZyaSwgMTUgTWF5IDIwMjAgMTY6NTM6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1pbnRlcmxlYXZlKTogTmV3CiB2YXJpYWJsZS4K Ci0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gfCAyNSArKysrKysrKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2du dS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KaW5k ZXggNDVjY2NlZDk5ZS4uYjcwYjlmZmZiOCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2VtYWNz LXh5ei5zY20KKysrIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KQEAgLTYwNTIsNiArNjA1 MiwzMSBAQCB0aGUgSHlkcmEgdmVyeSBzZWFtbGVzczsgaXQncyBsaWtlIGEgbWlub3IgbW9kZSB0 aGF0IGRpc2FibGVzIGl0c2VsZgogYXV0b21hdGljYWxseS4iKQogICAgIChsaWNlbnNlIGxpY2Vu c2U6Z3BsMyspKSkKIAorKGRlZmluZS1wdWJsaWMgZW1hY3MtaW50ZXJsZWF2ZQorICAocGFja2Fn ZQorICAgIChuYW1lICJlbWFjcy1pbnRlcmxlYXZlIikKKyAgICAodmVyc2lvbiAiMS40LjAiKQor ICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAg ICAgICh1cmkKKyAgICAgICAgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICh1cmwgImh0dHBzOi8v Z2l0aHViLmNvbS9ydWRvbGZvY2hyaXN0L2ludGVybGVhdmUiKQorICAgICAgICAgKGNvbW1pdCAo c3RyaW5nLWFwcGVuZCAiaW50ZXJsZWF2ZS0iIHZlcnNpb24pKSkpCisgICAgICAgKGZpbGUtbmFt ZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgIChzaGEyNTYKKyAgICAgICAg KGJhc2UzMgorICAgICAgICAgIjBsNWI2ODFtcnBrMTJseDVjMTZtN2tjMTNwMjl6Nnppc213ZzFs bHNqZzdjZG1ybXNyY2IiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZW1hY3MtYnVpbGQtc3lzdGVt KQorICAgIChob21lLXBhZ2UKKyAgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9ydWRvbGZvY2hyaXN0 L2ludGVybGVhdmUiKQorICAgIChzeW5vcHNpcworICAgICAiQSBtaW5vciBtb2RlIHRoYXQgcHJl c2VudHMgYSBkb2N1bWVudCBidWZmZXIgbmV4dCB0byBhbiBvcmdtb2RlIGJ1ZmZlciIpCisgICAg KGRlc2NyaXB0aW9uCisgICAgICJJbnRlcmxlYXZlIGlzIGEgbWlub3IgbW9kZSB0aGF0IHByZXNl bnRzIGEgZG9jdW1lbnQgdmlld2VyIHNpZGUKK2J5IHNpZGUgdG8gYW4gb3JnbW9kZSBidWZmZXIg d2l0aCB5b3VyIG5vdGVzIHJlbGV2YW50IHRvIHRoZSBjdXJyZW50IHBhZ2UuIikKKyAgICAobGlj ZW5zZSBsaWNlbnNlOmdwbDMrKSkpCisKIChkZWZpbmUtcHVibGljIGVtYWNzLWl2eQogICAocGFj a2FnZQogICAgIChuYW1lICJlbWFjcy1pdnkiKQotLSAKMi4yNi4yCgo= --b1_1b2291990679f01aceba5bfe4cdac084-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 17 09:18:54 2020 Received: (at submit) by debbugs.gnu.org; 17 May 2020 13:18:54 +0000 Received: from localhost ([127.0.0.1]:42612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBm-0007QY-Ph for submit@debbugs.gnu.org; Sun, 17 May 2020 09:18:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBe-0007Q3-Q6 for submit@debbugs.gnu.org; Sun, 17 May 2020 09:18:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJBe-0006Bq-Lp for guix-patches@gnu.org; Sun, 17 May 2020 09:18:38 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:45586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJBc-0000bl-Es for guix-patches@gnu.org; Sun, 17 May 2020 09:18:38 -0400 Date: Sun, 17 May 2020 13:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589721512; bh=NMiamffFGWk62jFDyeMAkSlW424OjZWgxB5y71kYAz0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=NXVZhO6beNiXlxLLJBpMvTCBnp4ooiKVn+JyhzIfU/8/n5d3q9m6H//ZcXHRZHq3L zFangAkKdppO7wxQopyrGJlnbK1XZsdEpTPoio24FQtAJw036arIi3f/jVSX+rNzIw Gr3dM8LaAbSdwel/JrSlvOvJ9ewc7+BEyyqxKHLI= To: Nicolas Goaziou From: rdes Subject: Re: [bug#41181] adds emacs-interleave Message-ID: <6rxX0vh7GxY4H7d6jXP10G8cqsh8_bs8V4e2JxatbfkiLwsC685g0wInwQSxzRpwsOfhm5aVovpD5lOd55GcNAXVlNGfXu1CYq4ym84-M5c=@protonmail.com> In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_115a3b853b6d3e04932e04c24b784c9d" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.132; envelope-from=rdes@protonmail.com; helo=mail-40132.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 09:18:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rdes Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --b1_115a3b853b6d3e04932e04c24b784c9d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, Attached is the copyright line that should have been in the previous patch. Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, May 15, 2020 4:56 PM, rdes wrote: > Hello Nicolas, > > Thanks for the pointers. Attached is an updated patch. > > Ryan > > Sent with ProtonMail Secure Email. > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Monday, May 11, 2020 3:10 AM, Nicolas Goaziou mail@nicolasgoaziou.fr w= rote: > > > Hello, > > rdes via Guix-patches via guix-patches@gnu.org writes: > > > > > The attached patch adds the emacs-interleave package. > > > > Thank you! Some comments follow. > > > > > Subject: [PATCH] gnu: Add emacs-interleave > > > > Your commit message should conform to Guix rules. Here, you need to add > > > > - gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > > > > > +(define-public emacs-interleave > > > +(package > > > > Indentation seems wrong. > > > > > - (name "emacs-interleave") > > > > > > - (version "20191129.958") > > > > > > - (source > > > > > > - (origin > > > > > > - (method url-fetch) > > > > > > > > > - (uri (string-append > > > > > > > > > - "https://melpa.org/packages/interleave-" > > > > > > > > > - version > > > > > > > > > - ".el")) > > > > > > > > > > We do not use MELPA sources. Instead, you could use `git-fetch' and > > extract the latest stable release from here: > > https://github.com/rudolfochrist/interleave/releases > > > > > - (sha256 > > > > > > > > > - (base32 > > > > > > > > > - "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8"= )))) > > > > > > > > > > Nitpick: could you move the string on the same line as `base32'? > > > > > - (build-system emacs-build-system) > > > - (home-page > > > - "https://github.com/rudolfochrist/interleave") > > > > Ditto. Could you move the string on the line above? > > > > > - (synopsis "Interleaving text books since 2015") > > > > I think this synopsis needs to be reworded. As it is, it may not be > > useful. > > > > > - (description > > > - "Interleave presents your PDF side by side to an [[http://orgmode= .org][Org Mode]] > > > > Description uses Texinfo syntax, not Org syntax. In this case, however, > > I think "side by side to an Org buffer" is sufficient. > > > > > +buffer with your notes, narrowing down to just those passages that a= re relevant to > > > +the particular page in the document viewer. > > > +") > > > > You don't need to end the description with a final newline. It would be > > nice to expound it a bit. For example, it could be interesting to know > > this is a minor mode. > > Don't forget to add a copyright line with your name at the top of the f= ile. > > Could you send an updated patch? > > Regards, > > > > Nicolas Goaziou --b1_115a3b853b6d3e04932e04c24b784c9d Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-Add-copyright.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-Add-copyright.patch RnJvbSA3Y2M4NTM1ZmI5MmU1ZDM5Mjc2ZWM1Y2RkNWJjMDc4ZDNkOGM1NWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IFN1biwgMTcgTWF5IDIwMjAgMDk6MTU6NDYgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtOiBBZGQgY29weXJpZ2h0LgoKLS0tCiBnbnUvcGFja2FnZXMv ZW1hY3MteHl6LnNjbSB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpkaWZm IC0tZ2l0IGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3Mt eHl6LnNjbQppbmRleCBiNzBiOWZmZmI4Li41ZDBiZWViMmQ5IDEwMDY0NAotLS0gYS9nbnUvcGFj a2FnZXMvZW1hY3MteHl6LnNjbQorKysgYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbQpAQCAt NzAsNiArNzAsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDIwIEFsYmVydG8gRWxldXRlcmlvIEZs b3JlcyBHdWVycmVybyA8YmFyYmFuZWdyYStndWl4QHBvc3Rlby5teD4KIDs7OyBDb3B5cmlnaHQg wqkgMjAyMCBNYXJpdXMgQmFra2UgPG1iYWtrZUBmYXN0bWFpbC5jb20+CiA7OzsgQ29weXJpZ2h0 IMKpIDIwMjAgcGlub2FmZmUgPHBpbm9hZmZlQGFpcm1haWwuY2M+Cis7OzsgQ29weXJpZ2h0IMKp IDIwMjAgUnlhbiBEZXNmb3NzZXMgPHJkZXNAcHJvdG9ubWFpbC5jb20+CiA7OzsKIDs7OyBUaGlz IGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwotLSAKMi4yNi4yCgo= --b1_115a3b853b6d3e04932e04c24b784c9d-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 17 19:00:54 2020 Received: (at submit) by debbugs.gnu.org; 17 May 2020 23:00:54 +0000 Received: from localhost ([127.0.0.1]:45086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaSH8-0000wr-1k for submit@debbugs.gnu.org; Sun, 17 May 2020 19:00:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:52824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaSH5-0000wj-Qp for submit@debbugs.gnu.org; Sun, 17 May 2020 19:00:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaSH5-0006gY-3j for guix-patches@gnu.org; Sun, 17 May 2020 19:00:51 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaSH1-0004aN-6i for guix-patches@gnu.org; Sun, 17 May 2020 19:00:49 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 2BAEFFF808; Sun, 17 May 2020 23:00:34 +0000 (UTC) From: Nicolas Goaziou To: rdes Subject: Re: [bug#41181] adds emacs-interleave References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> Date: Mon, 18 May 2020 01:00:33 +0200 In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> (rdes@protonmail.com's message of "Fri, 15 May 2020 20:56:10 +0000") Message-ID: <87367ytbe6.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 19:00:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, rdes writes: > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New > variable. Thank you for the updated patch. Some comments follow. > +(define-public emacs-interleave > + (package > + (name "emacs-interleave") > + (version "1.4.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/rudolfochrist/interleave") > + (commit (string-append "interleave-" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb")))) Could you move the hash on the line above? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/rudolfochrist/interleave") Could you move the URI on the line above, too? > + (synopsis > + "A minor mode that presents a document buffer next to an orgmode buffer") A synopsis does not start with "A". You may want to use "guix lint" to spot this. You might use the summary from the home page: (synopsis "Emacs minor mode to interleave notes and text books") > + (description > + "Interleave is a minor mode that presents a document viewer side > +by side to an orgmode buffer with your notes relevant to the current > page.") "orgmode buffer" -> "an Org buffer" Could you send an updated patch and merge this with the copyright line you sent? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu May 21 21:42:46 2020 Received: (at submit) by debbugs.gnu.org; 22 May 2020 01:42:46 +0000 Received: from localhost ([127.0.0.1]:57706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbwht-0001Gd-D3 for submit@debbugs.gnu.org; Thu, 21 May 2020 21:42:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:58994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbwhn-0001GL-Nl for submit@debbugs.gnu.org; Thu, 21 May 2020 21:42:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbwhn-00080L-Gi for guix-patches@gnu.org; Thu, 21 May 2020 21:42:35 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:64441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbwhl-0004HY-7C for guix-patches@gnu.org; Thu, 21 May 2020 21:42:34 -0400 Date: Fri, 22 May 2020 01:42:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1590111748; bh=L4j+gLg5Yg1MCXI6qJi3r41pgetcbBa6SUA4Dlwim3Q=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=aoayPz/RwD51pLrYHP/6uEzrW0T1Ahtc8HjQ8yLi7FYqNhZhpSze61QksdjTSa1pZ 1sYmRB4g8tkLEvu+gesHqVPeR6e0jxmqvJjiGfJ8ufrqXz5sfHaSKnDfDZRFObo/y8 nynKHRnxEd2YJSIHWEPcejQAvhXfcdCDWNjdvxoc= To: Nicolas Goaziou From: rdes Subject: Re: [bug#41181] adds emacs-interleave Message-ID: In-Reply-To: <87367ytbe6.fsf@nicolasgoaziou.fr> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> <87367ytbe6.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_13d938635139b6e2946ef47773939454" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Received-SPF: pass client-ip=185.70.40.137; envelope-from=rdes@protonmail.com; helo=mail-40137.protonmail.ch X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/21 21:42:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "41181\\@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rdes Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --b1_13d938635139b6e2946ef47773939454 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Nicolas, Thanks for the insight. Attached is a patch with the suggestions from the = previous email. -Ryan Sent with ProtonMail Secure Email. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Sunday, May 17, 2020 7:00 PM, Nicolas Goaziou w= rote: > Hello, > > rdes rdes@protonmail.com writes: > > > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave):= New > > variable. > > Thank you for the updated patch. Some comments follow. > > > +(define-public emacs-interleave > > > > - (package > > - (name "emacs-interleave") > > - (version "1.4.0") > > - (source > > - (origin > > > > > > - (method git-fetch) > > > > > > - (uri > > > > > > - (git-reference > > > > > > - (url "https://github.com/rudolfochrist/interleave") > > > > > > - (commit (string-append "interleave-" version)))) > > > > > > - (file-name (git-file-name name version)) > > > > > > - (sha256 > > > > > > - (base32 > > > > > > - "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb= ")))) > > > > > > Could you move the hash on the line above? > > > - (build-system emacs-build-system) > > - (home-page > > - "https://github.com/rudolfochrist/interleave") > > > > > > Could you move the URI on the line above, too? > > > - (synopsis > > - "A minor mode that presents a document buffer next to an = orgmode buffer") > > > > > > A synopsis does not start with "A". You may want to use "guix lint" to > spot this. > > You might use the summary from the home page: > > (synopsis "Emacs minor mode to interleave notes and text books") > > > - (description > > - "Interleave is a minor mode that presents a document view= er side > > > > > > > > +by side to an orgmode buffer with your notes relevant to the cur= rent > > page.") > > "orgmode buffer" -> "an Org buffer" > > Could you send an updated patch and merge this with the copyright line > you sent? > > Regards, > > ----------------------------------------------------------------------= ----------------------- > > Nicolas Goaziou --b1_13d938635139b6e2946ef47773939454 Content-Type: text/x-patch; name="0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-packages-emacs-xyz.scm-emacs-interleave-New-vari.patch RnJvbSA4OTk3Y2IyOGJjNjk0YjBhNjE0ZDY5MWRiNTkyY2NmYzFmODViNzkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIERlc2Zvc3NlcyA8cnlhbkBkZXNmby5vcmc+CkRhdGU6 IEZyaSwgMTUgTWF5IDIwMjAgMTY6NTM6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1pbnRlcmxlYXZlKTogTmV3CiB2YXJpYWJsZS4K CiogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY206IEFkZCBjb3B5cmlnaHQuCi0tLQogZ251L3Bh Y2thZ2VzL2VtYWNzLXh5ei5zY20gfCAyMyArKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxl IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1h Y3MteHl6LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IDQ1Y2NjZWQ5OWUu LjFhMjU1NDc1MDggMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBi L2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC03MCw2ICs3MCw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMjAgQWxiZXJ0byBFbGV1dGVyaW8gRmxvcmVzIEd1ZXJyZXJvIDxiYXJiYW5lZ3Jh K2d1aXhAcG9zdGVvLm14PgogOzs7IENvcHlyaWdodCDCqSAyMDIwIE1hcml1cyBCYWtrZSA8bWJh a2tlQGZhc3RtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBwaW5vYWZmZSA8cGlub2Fm ZmVAYWlybWFpbC5jYz4KKzs7OyBDb3B5cmlnaHQgwqkgMjAyMCBSeWFuIERlc2Zvc3NlcyA8cmRl c0Bwcm90b25tYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4 LgogOzs7CkBAIC02MDUyLDYgKzYwNTMsMjggQEAgdGhlIEh5ZHJhIHZlcnkgc2VhbWxlc3M7IGl0 J3MgbGlrZSBhIG1pbm9yIG1vZGUgdGhhdCBkaXNhYmxlcyBpdHNlbGYKIGF1dG9tYXRpY2FsbHku IikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCiAKKyhkZWZpbmUtcHVibGljIGVtYWNz LWludGVybGVhdmUKKyAgKHBhY2thZ2UKKyAgICAobmFtZSAiZW1hY3MtaW50ZXJsZWF2ZSIpCisg ICAgKHZlcnNpb24gIjEuNC4wIikKKyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAo bWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAodXJpCisgICAgICAgIChnaXQtcmVmZXJlbmNlCisg ICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vcnVkb2xmb2NocmlzdC9pbnRlcmxlYXZl IikKKyAgICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgImludGVybGVhdmUtIiB2ZXJzaW9u KSkpKQorICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAg ICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjBsNWI2ODFtcnBrMTJseDVjMTZtN2tjMTNw Mjl6Nnppc213ZzFsbHNqZzdjZG1ybXNyY2IiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZW1hY3Mt YnVpbGQtc3lzdGVtKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9ydWRvbGZv Y2hyaXN0L2ludGVybGVhdmUiKQorICAgIChzeW5vcHNpcyAiRW1hY3MgbWlub3IgbW9kZSB0byBp bnRlcmxlYXZlIG5vdGVzIGFuZCB0ZXh0IGJvb2tzIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAg IkludGVybGVhdmUgaXMgYSBtaW5vciBtb2RlIHRoYXQgcHJlc2VudHMgYSBkb2N1bWVudCB2aWV3 ZXIgc2lkZQorYnkgc2lkZSB0byBhbiBPcmcgYnVmZmVyIHdpdGggeW91ciBub3RlcyByZWxldmFu dCB0byB0aGUgY3VycmVudCBwYWdlLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQor CiAoZGVmaW5lLXB1YmxpYyBlbWFjcy1pdnkKICAgKHBhY2thZ2UKICAgICAobmFtZSAiZW1hY3Mt aXZ5IikKLS0gCjIuMjYuMgoK --b1_13d938635139b6e2946ef47773939454-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 25 07:43:16 2020 Received: (at submit) by debbugs.gnu.org; 25 May 2020 11:43:16 +0000 Received: from localhost ([127.0.0.1]:40056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdBVk-0005e8-C8 for submit@debbugs.gnu.org; Mon, 25 May 2020 07:43:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:59844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdBVi-0005e0-Ci for submit@debbugs.gnu.org; Mon, 25 May 2020 07:43:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdBVi-0008GA-5f for guix-patches@gnu.org; Mon, 25 May 2020 07:43:14 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:37209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdBVe-0004Ac-4R for guix-patches@gnu.org; Mon, 25 May 2020 07:43:13 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id B213324000E; Mon, 25 May 2020 11:43:05 +0000 (UTC) From: Nicolas Goaziou To: rdes Subject: Re: [bug#41181] adds emacs-interleave References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> <87367ytbe6.fsf@nicolasgoaziou.fr> Date: Mon, 25 May 2020 13:43:03 +0200 In-Reply-To: (rdes@protonmail.com's message of "Fri, 22 May 2020 01:42:22 +0000") Message-ID: <871rn89r5k.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.230; envelope-from=mail@nicolasgoaziou.fr; helo=relay10.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/25 07:43:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: "41181@debbugs.gnu.org" <41181-done@debbugs.gnu.org>, rdes via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, rdes writes: > From: Ryan Desfosses > Date: Fri, 15 May 2020 16:53:02 -0400 > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New > variable. I fixed the commit message and applied your patch. Thank you. Regards, -- Nicolas Goaziou From unknown Sun Jun 22 00:35:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Jun 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator