From eli@barzilay.org Tue Aug 11 03:48:12 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 11 Aug 2009 10:48:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7BAmBl7019997 for ; Tue, 11 Aug 2009 03:48:12 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Maotm-0005Tq-UY for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Maoth-0005RD-Cu for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:09 -0400 Received: from [199.232.76.173] (port=37170 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Maoth-0005R8-76 for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:05 -0400 Received: from mx20.gnu.org ([199.232.41.8]:61960) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Maotg-0000cW-Lj for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:04 -0400 Received: from winooski.ccs.neu.edu ([129.10.115.117] helo=barzilay.org) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Maotf-0001Nv-DL for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:03 -0400 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1Maote-0003Ga-6I for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2009 06:48:02 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19073.19554.183166.905858@winooski.ccs.neu.edu> Date: Tue, 11 Aug 2009 06:48:02 -0400 To: bug-gnu-emacs@gnu.org Subject: 23.1; isearch + isearch-allow-scroll loses shift X-Mailer: VM 7.19 under Emacs 22.1.1 X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: When `isearch-allow-scroll' is turned on, then exiting isearch with a movement command loses its "shift" status. To see this, use isearch and look for some string, then hit C-S-right a few times and you will see that the first one does not starts a selection. In GNU Emacs 23.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.14) of 2009-08-01 on winooski.ccs.neu.edu Windowing system distributor `The X.Org Foundation', version 11.0.10300000 configured using `configure '--prefix=/home/eli/bin/local/emacs-dir'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: POSIX value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t Major mode: Text Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r e p o r Recent messages: Loading ~/MyEmacs/pre...done Loading ~/EliEmacs/eliemacs...done Loading ~/MyEmacs/post...done Making completion list... From juri@jurta.org Wed Aug 12 16:09:02 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 12 Aug 2009 23:09:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7CN915E007822 for <4117@emacsbugs.donarmstrong.com>; Wed, 12 Aug 2009 16:09:02 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.68.109.cable.starman.ee [82.131.68.109]) by mx1.starman.ee (Postfix) with ESMTP id A13203F41AA; Thu, 13 Aug 2009 02:08:55 +0300 (EEST) From: Juri Linkov To: Eli Barzilay Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> Date: Wed, 12 Aug 2009 23:54:56 +0300 In-Reply-To: <19073.19554.183166.905858@winooski.ccs.neu.edu> (Eli Barzilay's message of "Tue, 11 Aug 2009 06:48:02 -0400") Message-ID: <87bpmkhcdb.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When `isearch-allow-scroll' is turned on, then exiting isearch with > a movement command loses its "shift" status. To see this, use > isearch and look for some string, then hit C-S-right a few times and > you will see that the first one does not starts a selection. When `isearch-allow-scroll' is non-nil, then `isearch-other-meta-char' calls `isearch-reread-key-sequence-naturally', but `read-key-sequence' in the latter function removes the shift modifier and sets `this-command-keys-shift-translated' to t. This is just an analysis. I currently don't know what is the right way to fix this. Maybe simply add the shift modifier back to the key when `this-command-keys-shift-translated' to t after `read-key-sequence'. -- Juri Linkov http://www.jurta.org/emacs/ From eli@barzilay.org Wed Aug 12 16:59:13 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 12 Aug 2009 23:59:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barzilay.org (winooski.ccs.neu.edu [129.10.115.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7CNxCOP015157 for <4117@emacsbugs.donarmstrong.com>; Wed, 12 Aug 2009 16:59:13 -0700 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1MbNip-0001VO-K3; Wed, 12 Aug 2009 19:59:11 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19075.22351.611859.436166@winooski.ccs.neu.edu> Date: Wed, 12 Aug 2009 19:59:11 -0400 To: Juri Linkov Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift In-Reply-To: <87bpmkhcdb.fsf@mail.jurta.org> References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> X-Mailer: VM 7.19 under Emacs 22.1.1 On Aug 12, Juri Linkov wrote: > > When `isearch-allow-scroll' is turned on, then exiting isearch with > > a movement command loses its "shift" status. To see this, use > > isearch and look for some string, then hit C-S-right a few times and > > you will see that the first one does not starts a selection. > > When `isearch-allow-scroll' is non-nil, then > `isearch-other-meta-char' calls > `isearch-reread-key-sequence-naturally', but `read-key-sequence' in > the latter function removes the shift modifier and sets > `this-command-keys-shift-translated' to t. Yes, I hacked around it with my own version of `isearch-other-meta-char'. (But I don't think that it's a good hack...) > This is just an analysis. I currently don't know what is the right > way to fix this. Maybe simply add the shift modifier back to the > key when `this-command-keys-shift-translated' to t after > `read-key-sequence'. This sounds like a good strategy, given that shift is now very useful in general. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From juri@jurta.org Sat Aug 15 16:46:55 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 15 Aug 2009 23:46:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7FNkswp010207 for <4117@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 16:46:55 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.53.206.cable.starman.ee [82.131.53.206]) by mx1.starman.ee (Postfix) with ESMTP id EF58D3F4343; Sun, 16 Aug 2009 02:46:48 +0300 (EEST) From: Juri Linkov To: Eli Barzilay Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> Date: Sun, 16 Aug 2009 02:27:14 +0300 In-Reply-To: <19075.22351.611859.436166@winooski.ccs.neu.edu> (Eli Barzilay's message of "Wed, 12 Aug 2009 19:59:11 -0400") Message-ID: <873a7sy73p.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> This is just an analysis. I currently don't know what is the right >> way to fix this. Maybe simply add the shift modifier back to the >> key when `this-command-keys-shift-translated' to t after >> `read-key-sequence'. > > This sounds like a good strategy, given that shift is now very useful > in general. It's interesting that after loading s-region.el, your reported case works correctly without fixes. So it seems the current core shift-selection is not the exact re-implementation of s-region.el. -- Juri Linkov http://www.jurta.org/emacs/ From eli@barzilay.org Sat Aug 15 17:00:21 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 16 Aug 2009 00:00:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_1,MURPHY_WRONG_WORD2,SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barzilay.org (winooski.ccs.neu.edu [129.10.115.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7G00Kcl012593 for <4117@emacsbugs.donarmstrong.com>; Sat, 15 Aug 2009 17:00:21 -0700 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1McTAZ-0006ut-5o; Sat, 15 Aug 2009 20:00:19 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19079.19475.169507.668553@winooski.ccs.neu.edu> Date: Sat, 15 Aug 2009 20:00:19 -0400 To: Juri Linkov Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift In-Reply-To: <873a7sy73p.fsf@mail.jurta.org> References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> X-Mailer: VM 7.19 under Emacs 22.1.1 On Aug 16, Juri Linkov wrote: > >> This is just an analysis. I currently don't know what is the > >> right way to fix this. Maybe simply add the shift modifier back > >> to the key when `this-command-keys-shift-translated' to t after > >> `read-key-sequence'. > > > > This sounds like a good strategy, given that shift is now very > > useful in general. > > It's interesting that after loading s-region.el, your reported case > works correctly without fixes. > > So it seems the current core shift-selection is not the exact > re-implementation of s-region.el. I still believe that the problem is somewhere in how `isearch-other-meta-char' restores the key. FWIW, here is my hack; I can't even explain how it works since I was basically guessing my way trying to get the stupid thing to work. At least in v22, this would cause the key that is used to exit isearch to be replayed twice -- for example, using `C-x 2' would happen twice. It just happens that I'm personally much more likely to shift-arrow my way out of isearch than I am to splitting the window. (progn ;; original code: ;; (setq key (isearch-reread-key-sequence-naturally keylist)) ;; (setq keylist (listify-key-sequence key)) ;; ELI: use original prefix, so S-up keeps the S (let* ((key1 (isearch-reread-key-sequence-naturally keylist)) (keylist1 (listify-key-sequence key1))) (setq keylist (listify-key-sequence key)) ; original key (setq keylist (append keylist (nthcdr (length keylist) keylist1))) (setq key key1) (setq main-event (aref key 0)) (setq scroll-command (isearch-lookup-scroll-key key)))) -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From juri@jurta.org Sun Aug 16 18:29:45 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 01:29:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H1ThWp019324 for <4117@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 18:29:45 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.54.10.cable.starman.ee [82.131.54.10]) by mx1.starman.ee (Postfix) with ESMTP id 443353F4298; Mon, 17 Aug 2009 04:29:37 +0300 (EEST) From: Juri Linkov To: Eli Barzilay Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> Date: Mon, 17 Aug 2009 03:47:57 +0300 In-Reply-To: <19079.19475.169507.668553@winooski.ccs.neu.edu> (Eli Barzilay's message of "Sat, 15 Aug 2009 20:00:19 -0400") Message-ID: <8763cn1bne.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> It's interesting that after loading s-region.el, your reported case >> works correctly without fixes. >> >> So it seems the current core shift-selection is not the exact >> re-implementation of s-region.el. > > I still believe that the problem is somewhere in how > `isearch-other-meta-char' restores the key. FWIW, here is my hack; I > can't even explain how it works since I was basically guessing my way > trying to get the stupid thing to work. > > At least in v22, this would cause the key that is used to exit isearch > to be replayed twice -- for example, using `C-x 2' would happen twice. > It just happens that I'm personally much more likely to shift-arrow my > way out of isearch than I am to splitting the window. Could you try the following hack: Index: lisp/isearch.el =================================================================== RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.345 diff -u -r1.345 isearch.el --- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345 +++ lisp/isearch.el 17 Aug 2009 00:47:38 -0000 @@ -1900,6 +1905,12 @@ ((and isearch-allow-scroll (progn (setq key (isearch-reread-key-sequence-naturally keylist)) (setq keylist (listify-key-sequence key)) + (when this-command-keys-shift-translated + (setq keylist (list + (event-convert-list + (append (cons 'shift (event-modifiers keylist)) + (list (event-basic-type keylist)))))) + (setq this-command-keys-shift-translated nil)) (setq main-event (aref key 0)) (setq scroll-command (isearch-lookup-scroll-key key)))) ;; From this point onwards, KEY, KEYLIST and MAIN-EVENT hold a -- Juri Linkov http://www.jurta.org/emacs/ From eli@barzilay.org Sun Aug 16 20:17:10 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 03:17:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barzilay.org (winooski.ccs.neu.edu [129.10.115.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H3H9Db006671 for <4117@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 20:17:10 -0700 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1Mcsib-0008Mc-8Q; Sun, 16 Aug 2009 23:17:09 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19080.52149.249327.744724@winooski.ccs.neu.edu> Date: Sun, 16 Aug 2009 23:17:09 -0400 To: Juri Linkov Cc: 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift In-Reply-To: <8763cn1bne.fsf@mail.jurta.org> References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> X-Mailer: VM 7.19 under Emacs 22.1.1 On Aug 17, Juri Linkov wrote: > >> It's interesting that after loading s-region.el, your reported case > >> works correctly without fixes. > >> > >> So it seems the current core shift-selection is not the exact > >> re-implementation of s-region.el. > > > > I still believe that the problem is somewhere in how > > `isearch-other-meta-char' restores the key. FWIW, here is my hack; I > > can't even explain how it works since I was basically guessing my way > > trying to get the stupid thing to work. > > > > At least in v22, this would cause the key that is used to exit isearch > > to be replayed twice -- for example, using `C-x 2' would happen twice. > > It just happens that I'm personally much more likely to shift-arrow my > > way out of isearch than I am to splitting the window. > > Could you try the following hack: > [...] Yes, this works. (But not on v22, of course.) (And re what I said above, the duplication that I've had on `C-x 2' is unrelated.) -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From monnier@iro.umontreal.ca Mon Aug 17 08:07:59 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 15:07:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HF7vTf032514 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 08:07:59 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhAFALcOiUpFpZNo/2dsb2JhbACBUtRghBkFh0k X-IronPort-AV: E=Sophos;i="4.43,396,1246852800"; d="scan'208";a="43660135" Received: from 69-165-147-104.dsl.teksavvy.com (HELO pastel.home) ([69.165.147.104]) by ironport2-out.teksavvy.com with ESMTP; 17 Aug 2009 11:07:20 -0400 Received: by pastel.home (Postfix, from userid 20848) id 3848982F0; Mon, 17 Aug 2009 11:07:36 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4117@debbugs.gnu.org, Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> Date: Mon, 17 Aug 2009 11:07:36 -0400 In-Reply-To: <8763cn1bne.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 17 Aug 2009 03:47:57 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Index: lisp/isearch.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/isearch.el,v > retrieving revision 1.345 > diff -u -r1.345 isearch.el > --- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345 > +++ lisp/isearch.el 17 Aug 2009 00:47:38 -0000 > @@ -1900,6 +1905,12 @@ > ((and isearch-allow-scroll > (progn (setq key (isearch-reread-key-sequence-naturally keylist)) > (setq keylist (listify-key-sequence key)) > + (when this-command-keys-shift-translated > + (setq keylist (list > + (event-convert-list > + (append (cons 'shift (event-modifiers keylist)) > + (list (event-basic-type keylist)))))) > + (setq this-command-keys-shift-translated nil)) > (setq main-event (aref key 0)) > (setq scroll-command (isearch-lookup-scroll-key key)))) > ;; From this point onwards, KEY, KEYLIST and MAIN-EVENT hold a If this works, it's good, but it shouldn't be installed as is: this has no business being in isearch.el since other packages may need to do the same. Please try to abstract some useful function that we can put in subr.el and then use here in isearch.el. Stefan From eli@barzilay.org Mon Aug 17 12:53:36 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 19:53:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barzilay.org (winooski.ccs.neu.edu [129.10.115.117]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HJrYZs020802 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 12:53:35 -0700 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1Md8Gq-0005uv-V0; Mon, 17 Aug 2009 15:53:32 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19081.46396.950562.917528@winooski.ccs.neu.edu> Date: Mon, 17 Aug 2009 15:53:32 -0400 To: Stefan Monnier Cc: Juri Linkov , 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift In-Reply-To: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> X-Mailer: VM 7.19 under Emacs 22.1.1 On Aug 17, Stefan Monnier wrote: > [...] > If this works, it's good, but it shouldn't be installed as is: this > has no business being in isearch.el since other packages may need to > do the same. Please try to abstract some useful function that we > can put in subr.el and then use here in isearch.el. Yes -- here's another case that suffers from the same problem: `comint-dynamic-list-completions' reads one key (because it wants to remove the completions window when space is used) -- so it reads one key to test if it's space and uses `unread-command-events' otherwise. So: run `shell', type one character and hit tab (needs to have several files that start with it to pop the completions), then do some shift-movements. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From juri@jurta.org Mon Aug 17 14:28:19 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 21:28:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HLSG41005569 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 14:28:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.255.cable.starman.ee [82.131.53.255]) by mx2.starman.ee (Postfix) with ESMTP id DC5E03F407E; Tue, 18 Aug 2009 00:28:09 +0300 (EEST) From: Juri Linkov To: Eli Barzilay Cc: Stefan Monnier , 4117@debbugs.gnu.org Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <19081.46396.950562.917528@winooski.ccs.neu.edu> Date: Tue, 18 Aug 2009 00:19:59 +0300 In-Reply-To: <19081.46396.950562.917528@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 15:53:32 -0400") Message-ID: <87hbw6xhm4.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Yes -- here's another case that suffers from the same problem: > `comint-dynamic-list-completions' reads one key (because it wants to > remove the completions window when space is used) -- so it reads one > key to test if it's space and uses `unread-command-events' otherwise. > So: run `shell', type one character and hit tab (needs to have several > files that start with it to pop the completions), then do some > shift-movements. This can be fixed using the argument `dont-downcase-last' of `read-key-sequence': Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.390 diff -u -r1.390 comint.el --- lisp/comint.el 23 Jun 2009 07:25:15 -0000 1.390 +++ lisp/comint.el 17 Aug 2009 21:19:29 -0000 @@ -3014,7 +3014,7 @@ (if (with-current-buffer (get-buffer "*Completions*") (set (make-local-variable 'comint-displayed-dynamic-completions) completions) - (setq key (read-key-sequence nil) + (setq key (read-key-sequence nil nil t) first (aref key 0)) (and (consp first) (consp (event-start first)) (eq (window-buffer (posn-window (event-start first))) -- Juri Linkov http://www.jurta.org/emacs/ From juri@jurta.org Mon Aug 17 14:28:20 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 21:28:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,HAS_BUG_NUMBER, PHONENUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HLSIFU005571 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 14:28:20 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.255.cable.starman.ee [82.131.53.255]) by mx2.starman.ee (Postfix) with ESMTP id 77D063F4079; Tue, 18 Aug 2009 00:28:08 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4117@debbugs.gnu.org, Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> Date: Tue, 18 Aug 2009 00:18:17 +0300 In-Reply-To: (Stefan Monnier's message of "Mon, 17 Aug 2009 11:07:36 -0400") Message-ID: <87ws52xhpi.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > If this works, it's good, but it shouldn't be installed as is: this has > no business being in isearch.el since other packages may need to do > the same. Please try to abstract some useful function that we can put > in subr.el and then use here in isearch.el. Actually the solution is much simpler. I just noticed that `read-key-sequence' already has the necessary argument `dont-downcase-last': The third (optional) arg dont-downcase-last, if non-nil, means do not convert the last event to lower case. (Normally any upper case event is converted to lower case if the original event is undefined and the lower case equivalent is defined.) A non-nil value is appropriate for reading a key sequence to be defined. So the fix is simple: Index: lisp/isearch.el =================================================================== RCS file: /sources/emacs/emacs/lisp/isearch.el,v retrieving revision 1.345 diff -u -r1.345 isearch.el --- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345 +++ lisp/isearch.el 17 Aug 2009 21:17:57 -0000 @@ -1805,7 +1810,7 @@ Return the key sequence as a string/vector." (isearch-unread-key-sequence keylist) (let (overriding-terminal-local-map) - (read-key-sequence nil))) ; This will go through function-key-map, if nec. + (read-key-sequence nil nil t))) ; This will go through function-key-map, if nec. (defun isearch-lookup-scroll-key (key-seq) "If KEY-SEQ is bound to a scrolling command, return it as a symbol. -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Mon Aug 17 19:56:52 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 18 Aug 2009 02:56:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7I2uoDx000639 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 19:56:52 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtgEAB+1iUpFpZNo/2dsb2JhbACBUtUohBkFh0k X-IronPort-AV: E=Sophos;i="4.43,399,1246852800"; d="scan'208";a="43700511" Received: from 69-165-147-104.dsl.teksavvy.com (HELO ceviche.home) ([69.165.147.104]) by ironport2-out.teksavvy.com with ESMTP; 17 Aug 2009 22:56:12 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1B597B407B; Mon, 17 Aug 2009 22:56:45 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4117@debbugs.gnu.org, Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <87ws52xhpi.fsf@mail.jurta.org> Date: Mon, 17 Aug 2009 22:56:44 -0400 In-Reply-To: <87ws52xhpi.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 18 Aug 2009 00:18:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Actually the solution is much simpler. I just noticed that > `read-key-sequence' already has the necessary argument > `dont-downcase-last': > The third (optional) arg dont-downcase-last, if non-nil, means do not > convert the last event to lower case. (Normally any upper case event > is converted to lower case if the original event is undefined and the lower > case equivalent is defined.) A non-nil value is appropriate for reading > a key sequence to be defined. Yes, I guess that's better. But at the same time, it still seems incorrect: the sequence we get has gone through input-decode-map, function-key-map, key-translation-map, keyboard-translate-table, down-mouse and drag-mouse event may have been dropped, etc... So stuffing it back into unread-command-events is incorrect. I think the right solution requires the use of something like this-single-command-raw-keys. Stefan From juri@jurta.org Tue Aug 18 19:41:49 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 19 Aug 2009 02:41:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7J2fmeE018245 for <4117@emacsbugs.donarmstrong.com>; Tue, 18 Aug 2009 19:41:49 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.55.87.cable.starman.ee [82.131.55.87]) by mx2.starman.ee (Postfix) with ESMTP id 1E9C33F409E; Wed, 19 Aug 2009 05:41:42 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4117@debbugs.gnu.org, Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: JURTA References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <87ws52xhpi.fsf@mail.jurta.org> Date: Wed, 19 Aug 2009 03:56:06 +0300 In-Reply-To: (Stefan Monnier's message of "Mon, 17 Aug 2009 22:56:44 -0400") Message-ID: <87tz04pmzd.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > So stuffing it back into unread-command-events is incorrect. I think > the right solution requires the use of something like > this-single-command-raw-keys. How this would help to reread a key sequence with Isearch keymap deactivated (i.e. to do the same that `isearch-reread-key-sequence-naturally' currently does)? -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Tue Aug 18 20:27:24 2009 Received: (at 4117) by emacsbugs.donarmstrong.com; 19 Aug 2009 03:27:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7J3RMXB026739 for <4117@emacsbugs.donarmstrong.com>; Tue, 18 Aug 2009 20:27:24 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnsFAKcNi0pFpaKZ/2dsb2JhbACBUsUGkUyEGQWHTw X-IronPort-AV: E=Sophos;i="4.43,406,1246852800"; d="scan'208";a="43768828" Received: from 69-165-162-153.dsl.teksavvy.com (HELO pastel.home) ([69.165.162.153]) by ironport2-out.teksavvy.com with ESMTP; 18 Aug 2009 23:26:42 -0400 Received: by pastel.home (Postfix, from userid 20848) id E7E9382F0; Tue, 18 Aug 2009 23:27:16 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4117@debbugs.gnu.org, Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> <87ws52xhpi.fsf@mail.jurta.org> <87tz04pmzd.fsf@mail.jurta.org> Date: Tue, 18 Aug 2009 23:27:16 -0400 In-Reply-To: <87tz04pmzd.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 19 Aug 2009 03:56:06 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> So stuffing it back into unread-command-events is incorrect. I think >> the right solution requires the use of something like >> this-single-command-raw-keys. > How this would help to reread a key sequence with Isearch > keymap deactivated (i.e. to do the same that > `isearch-reread-key-sequence-naturally' currently does)? I think it would make the funny business like (if (and (> (length keylist) 1) (symbolp (car keylist)) (listp (cadr keylist)) (not (numberp (posn-point (event-start (cadr keylist) ))))) (pop unread-command-events))) unnecessary, and it would fix various bugs such as the one discussed. `unread-command-events' should hold events that have not gone through input-decode-map, function-key-map, dwon-mouse and drag-mouse demotion, double-click -> click demotion, shift->unshift demotion, ... i.e. raw-events. So isearch-unread should be called with events that come from read-event or from this-single-command-raw-keys but not from read-key-sequence. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 23:53:35 2016 Received: (at 4117) by debbugs.gnu.org; 18 Jun 2016 03:53:35 +0000 Received: from localhost ([127.0.0.1]:44664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE7KA-0002CN-Uk for submit@debbugs.gnu.org; Fri, 17 Jun 2016 23:53:35 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE7K9-0002CA-0o for 4117@debbugs.gnu.org; Fri, 17 Jun 2016 23:53:33 -0400 Received: by mail-qk0-f177.google.com with SMTP id s186so105571913qkc.1 for <4117@debbugs.gnu.org>; Fri, 17 Jun 2016 20:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KA/U+4qTL4z9NBNS74QcwNElgS8bcHA2CeIwH+nndCY=; b=QEiN0m+QbjqG9URByvzIx6W8kWQoxTaUE0c/TSxTCWHzGVQfew1OsndT0LSJl0Qo9N yvxGBQl0v8ejhvGY70ZxHrpw36BcBAj0mavxgXfWfqTfgGKiSOF0dvDiYmYiNofU8Zfg 7z1qOX3FsjRj5ZyNlSJSt6AyImicdG/C6tcsAHrOaiSj1sooyM9H+YSz2RwHT6pZ2DvM st73oT3Lg6wCpcuFLp45oE6JTwe+1+Vaug7I8+giaPvMNgm7W+Tpqypn9zAZYpxK/rVm UHjZvBKtoY/pYuVUkVGBF7p43RSNrcTxPwdkcUSNrx4wM77jw/TlH0mxnqe5qvMaos35 NStg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KA/U+4qTL4z9NBNS74QcwNElgS8bcHA2CeIwH+nndCY=; b=QHMmfcqUrRpe9K98eK+G1v3VBmGOyJlINhCq3CXg0BY9v3fcF29LNUgc2nd+xkKseC fhc4Ut1TGFY72z63jFaaEVAh6nM0D4ePYFnEW53uoaz5gtresJrldzEObRvR3pDuqv0w VyQKcAoai4a7DJb/DCZ42VG6AJF9o9J2YfPdHz4J4n0Rsq9pzOJZzEPvzwyNXx/UsWqQ DsVgGvXEh60v2pUoqEyXSlNkDkSHoD0NiwPiWHSoe9dFtwUb8i2XlmNKC8V5Rq8sfQQh fwLuCXBTOFekixWMVcl9S9QXikT7G3xS1UNRAVZ6bv1bVfUiW1La4Z0DxdufkiojFr9j YlfQ== X-Gm-Message-State: ALyK8tK6QmuJ7g+7vddZEBpJQkIlW3ZJDi5sule8m3KgEHHHLKYGrifgheszmZV1dZkrFw== X-Received: by 10.55.209.83 with SMTP id s80mr6569673qki.87.1466222007517; Fri, 17 Jun 2016 20:53:27 -0700 (PDT) Received: from Andrews-MacBook-Pro.local (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id 18sm14736453qkd.30.2016.06.17.20.53.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jun 2016 20:53:25 -0700 (PDT) From: Andrew Hyatt To: Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift References: <19073.19554.183166.905858@winooski.ccs.neu.edu> Date: Fri, 17 Jun 2016 23:53:24 -0400 In-Reply-To: <19073.19554.183166.905858@winooski.ccs.neu.edu> (Eli Barzilay's message of "Tue, 11 Aug 2009 06:48:02 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: 4117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I've tested this out on emacs 25 as well, and it still is an issue. Eli Barzilay writes: > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: > > > When `isearch-allow-scroll' is turned on, then exiting isearch with > a movement command loses its "shift" status. To see this, use > isearch and look for some string, then hit C-S-right a few times and > you will see that the first one does not starts a selection. > > > In GNU Emacs 23.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.14) > of 2009-08-01 on winooski.ccs.neu.edu > Windowing system distributor `The X.Org Foundation', version 11.0.10300000 > configured using `configure '--prefix=/home/eli/bin/local/emacs-dir'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: POSIX > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: en_US > value of $XMODIFIERS: nil > locale-coding-system: iso-latin-1-unix > default-enable-multibyte-characters: t > > Major mode: Text > > Minor modes in effect: > tooltip-mode: t > mouse-wheel-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > global-auto-composition-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > line-number-mode: t > transient-mark-mode: t > > Recent input: > M-x r e p o r > > Recent messages: > Loading ~/MyEmacs/pre...done > Loading ~/EliEmacs/eliemacs...done > Loading ~/MyEmacs/post...done > Making completion list... From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 09:18:50 2016 Received: (at 4117) by debbugs.gnu.org; 19 Jun 2016 13:18:50 +0000 Received: from localhost ([127.0.0.1]:45634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEccj-0007bh-SI for submit@debbugs.gnu.org; Sun, 19 Jun 2016 09:18:50 -0400 Received: from mail.muc.de ([193.149.48.3]:48971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEcch-0007bZ-UT for 4117@debbugs.gnu.org; Sun, 19 Jun 2016 09:18:48 -0400 Received: (qmail 68081 invoked by uid 3782); 19 Jun 2016 13:18:46 -0000 Date: 19 Jun 2016 13:18:46 -0000 Message-ID: <20160619131846.68080.qmail@mail.muc.de> From: Alan Mackenzie To: Andrew Hyatt Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.3-RELEASE-p4 (amd64)) X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 4117 Cc: Eli Barzilay , 4117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hello, Andrew. In article you wrote: > I've tested this out on emacs 25 as well, and it still is an issue. For what it's worth, it works fine for me with the emacs-25 branch in X-Windows (more precisely, XFCE). (Shift selection doesn't work at all on my Linux virtual tty.) I have `isearch-allow-scroll' set to t, and I search for a word in Isearch, which is found. I then type C-S-right just once, and the next word after what had been the highlighted search region gets highlighted for me (in grey). The Isearch operation is now terminated. > Eli Barzilay writes: >> Please describe exactly what actions triggered the bug >> and the precise symptoms of the bug: >> >> >> When `isearch-allow-scroll' is turned on, then exiting isearch with >> a movement command loses its "shift" status. To see this, use >> isearch and look for some string, then hit C-S-right a few times and >> you will see that the first one does not starts a selection. >> >> >> In GNU Emacs 23.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.14) >> of 2009-08-01 on winooski.ccs.neu.edu >> Windowing system distributor `The X.Org Foundation', version 11.0.10300000 >> configured using `configure '--prefix=/home/eli/bin/local/emacs-dir'' [ .... ] -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 10:36:35 2016 Received: (at 4117) by debbugs.gnu.org; 19 Jun 2016 14:36:35 +0000 Received: from localhost ([127.0.0.1]:46546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEdpy-0001Fo-PB for submit@debbugs.gnu.org; Sun, 19 Jun 2016 10:36:34 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEdpw-0001Fa-J7 for 4117@debbugs.gnu.org; Sun, 19 Jun 2016 10:36:33 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u5JEaMJf003118 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jun 2016 14:36:22 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u5JEaM7D011624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jun 2016 14:36:22 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u5JEaJL9002076; Sun, 19 Jun 2016 14:36:20 GMT MIME-Version: 1.0 Message-ID: <3550cc63-9365-4d30-b494-e1809e25704c@default> Date: Sun, 19 Jun 2016 07:36:11 -0700 (PDT) From: Drew Adams To: Alan Mackenzie , Andrew Hyatt Subject: RE: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift References: <<19073.19554.183166.905858@winooski.ccs.neu.edu>> <<20160619131846.68080.qmail@mail.muc.de>> In-Reply-To: <<20160619131846.68080.qmail@mail.muc.de>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 4117 Cc: Eli Barzilay , 4117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) > > I've tested this out on emacs 25 as well, and it still is an issue. >=20 > For what it's worth, it works fine for me with the emacs-25 branch in > X-Windows (more precisely, XFCE). It works for me on MS Windows also, using an old Emacs 25 build. Following Alan's recipe gives the behavior he describes: > I have `isearch-allow-scroll' set to t, and I search for a word in > Isearch, which is found. I then type C-S-right just once, and the next > word after what had been the highlighted search region gets highlighted > for me (in grey). The Isearch operation is now terminated. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 20:58:13 2016 Received: (at 4117) by debbugs.gnu.org; 20 Jun 2016 00:58:13 +0000 Received: from localhost ([127.0.0.1]:46823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEnXY-0002KM-P6 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 20:58:12 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEnXT-0002Jy-VW for 4117@debbugs.gnu.org; Sun, 19 Jun 2016 20:58:11 -0400 Received: by mail-wm0-f51.google.com with SMTP id a66so57320440wme.0 for <4117@debbugs.gnu.org>; Sun, 19 Jun 2016 17:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BRagiyynJymUqZnfHi5GWY9R/BzXA+8YAC8oEgqRCGo=; b=kC+OaF4VJZfamPda6pfFKqc5HQX3UfHJ3YcWZncaqum+k8qlHjWamKq0Bim/GS+CRp FACuKO5tL3utXQ9yh5Z5dkU8RffVR6lXOBdKVA5UloAr8DBELi++L3+gpoFCvWM6sXc0 HW82YpbSq/ZSqjl0bAjXuWlQEPZm5fgRs7Yrls1MG3V1o1J4WEP5hZiRFrH5qoKmjfhl 8deD4U0ODD4w922q7FQi3Mg6hApiz25JRoqGUs06jtP0+jeZLILaR3JjTJEaVLHGs1fw sO19EG1JuerfTzVpNBpl6YnlIz7/UDlxXWq3Kj+Ehn5FJUAbuJSy5ABjPU+7iJ+78RnX qwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BRagiyynJymUqZnfHi5GWY9R/BzXA+8YAC8oEgqRCGo=; b=drPLNh+JsML9tp8E50OkrwHt76bwz4IOCllj/1O22Thsr7N2vQhTc/IfVcGiW8h3bw EGhYuAgurfZUuQAK0l0lftpK0xntc+j0TOn7V88Qk8xASbNfrxq482OE9LVB3Daf9IGv 2Z57gV6okkry40YW3nVkytHw/rfrF7i8ook5ur2lTiOa0lglDKp8JtAsPfsjhilR2Rj3 BHxr+TiRGaYz5ew16SFx/1bzneBO/YajBtrYmQBOUt4ow/NOlg0qX/ZSVXP3XOG09pk0 nbwkqVFVafqyLR5ClzwWBGb+8ky32cMpb/QtZFjYdhbGiPOJPDPL1e2Nv3He9RJ/p/7y PnuQ== X-Gm-Message-State: ALyK8tLSJ44lP0fyZ7BybRpYhwvs8pEDi25OztI//NjvDmcLLz8dqSz9OQLO1eil5055yDPRBST/2FBOSuHCYQ== X-Received: by 10.194.104.196 with SMTP id gg4mr13785970wjb.112.1466384282029; Sun, 19 Jun 2016 17:58:02 -0700 (PDT) MIME-Version: 1.0 References: <3550cc63-9365-4d30-b494-e1809e25704c@default> In-Reply-To: <3550cc63-9365-4d30-b494-e1809e25704c@default> From: Andrew Hyatt Date: Mon, 20 Jun 2016 00:57:51 +0000 Message-ID: Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift To: Drew Adams , Alan Mackenzie Content-Type: multipart/alternative; boundary=089e010d83fc3c16c70535ab3233 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: Eli Barzilay , 4117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e010d83fc3c16c70535ab3233 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Sun, Jun 19, 2016 at 10:36 AM Drew Adams wrote: > > > I've tested this out on emacs 25 as well, and it still is an issue. > > > > For what it's worth, it works fine for me with the emacs-25 branch in > > X-Windows (more precisely, XFCE). > > It works for me on MS Windows also, using an old Emacs 25 build. > Following Alan's recipe gives the behavior he describes: > > I have `isearch-allow-scroll' set to t, and I search for a word in > > Isearch, which is found. I then type C-S-right just once, and the next > > word after what had been the highlighted search region gets highlighted > > for me (in grey). The Isearch operation is now terminated. > Perhaps I misunderstood the original bug, but I thought the problem was that when you C-S-right, the text that was highlighted with isearch is no longer highlighted. Are you saying that that original selection that you were initially on before the C-S-right is still highlighted, or are you saying it isn't, and that's not a bug? --089e010d83fc3c16c70535ab3233 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On Sun, Jun 19, 2016 at 10:36 AM Drew Adams <drew.adams@oracle.com> wrote:
> > I've tested this out on emacs 25 as well, and it still is an issue.
>
> For what it's worth, it works fine for me with the emacs-25 branch in
> X-Windows (more precisely, XFCE).

It works for me on MS Windows also, using an old Emacs 25 build.
Following Alan's recipe gives the behavior he describes: 

> I have `isearch-allow-scroll' set to t, and I search for a word in
> Isearch, which is found.  I then type C-S-right just once, and the next
> word after what had been the highlighted search region gets highlighted
> for me (in grey).  The Isearch operation is now terminated.

Perhaps I misunderstood the original bug, but I thought the problem was that when you C-S-right, the text that was highlighted with isearch is no longer highlighted.

Are you saying that that original selection that you were initially on before the C-S-right is still highlighted, or are you saying it isn't, and that's not a bug?
 
--089e010d83fc3c16c70535ab3233-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 23:51:00 2016 Received: (at 4117) by debbugs.gnu.org; 20 Jun 2016 03:51:00 +0000 Received: from localhost ([127.0.0.1]:46903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEqEl-0006Ly-F1 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 23:51:00 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:37929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEqEg-0006Lf-CR for 4117@debbugs.gnu.org; Sun, 19 Jun 2016 23:50:58 -0400 Received: by mail-it0-f47.google.com with SMTP id h190so29874895ith.1 for <4117@debbugs.gnu.org>; Sun, 19 Jun 2016 20:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=barzilay-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bkvCs8l3eWluGYuto1KCsyfH3KqzAXe7Y/kjkZ1QMrc=; b=PTBskPuisCKgNYmu+mejfkDtqECk7LsYjnbvLHbEqtvlLJn/T94R/hWLVlsl8Xbk9v g+kBrYXS47asoH82TotTRIb0vHmQOWxTO3J930SMPqNu62PXlT+qiTFjiEWuLoyA+UNn rNsd+TatQI83FUYknw59rW6PoFbBjraSgUXKPdiBpWqph+kRsIlWW4+PsP8wSOZ/egIW Yz5kzW/IoJ4MTGraMRVY2r7uDbOlKRqj7XwDmb9UA10hu8xRRRWT3UGBVQB7Lst7Eg7I UgV24ZERHJ135zf59OobGRDinB/7wUL6mkOiKmNqPCiDrrDGw/R/7Is6EPcoCOUk9Qc3 9V4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bkvCs8l3eWluGYuto1KCsyfH3KqzAXe7Y/kjkZ1QMrc=; b=gd/hZPB9iZtVxESduUoe0GC7msyG8N2bihrwVjLukIa1b+91OJvkSmlzUzXAzmrH+W P/H1Aq89bn/LlFFWdVf8INGBd0wPGSkB1kzd1aAS1Sn+PslXSrB92LVue0Mux2EqBrgP oHjkwECDL7nuTWP6xOUTfx8HXqmFEGCHzamNq4ITgFRyYMYyWFTs4O4CbPlnzSDLKlZy becmJ7/38ZBTi8i3wSYBLW4E0keh3R69dSVFjixXOQF1ZQpKT96EF0z03NtceTDinK/v 3jXkbE/wqZeOoLr9pawjLQMFvZxsgdSsVfQ2Nh2NW+Fqxh0dP61mIhPbcvX9TxSpKwAC FP/w== X-Gm-Message-State: ALyK8tLu5ekCK8q3zZyv4kMRORUdEgfmbAlqIULlfJPCoRo4rtwfi/aqpD7DcxZj3o95LS0WY8ytC1rdMP0CzA== X-Received: by 10.36.23.131 with SMTP id 125mr13568539ith.15.1466394648585; Sun, 19 Jun 2016 20:50:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.127.193 with HTTP; Sun, 19 Jun 2016 20:50:48 -0700 (PDT) In-Reply-To: References: <3550cc63-9365-4d30-b494-e1809e25704c@default> From: Eli Barzilay Date: Sun, 19 Jun 2016 23:50:48 -0400 Message-ID: Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift To: Andrew Hyatt Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Sun, Jun 19, 2016 at 8:57 PM, Andrew Hyatt wrote: > On Sun, Jun 19, 2016 at 10:36 AM Drew Adams wrote: >> >> It works for me on MS Windows also, using an old Emacs 25 build. >> Following Alan's recipe gives the behavior he describes: >> >> > I have `isearch-allow-scroll' set to t, and I search for a word in >> > Isearch, which is found. I then type C-S-right just once, and the next >> > word after what had been the highlighted search region gets highlighted >> > for me (in grey). The Isearch operation is now terminated. Yes, that was my meaning, and it looks like it works fine even in v24.5.1. > Perhaps I misunderstood the original bug, but I thought the problem > was that when you C-S-right, the text that was highlighted with > isearch is no longer highlighted. > > Are you saying that that original selection that you were initially on > before the C-S-right is still highlighted, or are you saying it isn't, > and that's not a bug? My expectation (which is what it's doing now) is that a C-S-right would terminate isearch and select the next word. -- ((x=>x(x))(x=>x(x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 23:23:31 2016 Received: (at 4117) by debbugs.gnu.org; 23 Jun 2016 03:23:32 +0000 Received: from localhost ([127.0.0.1]:51668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFvEp-0007QT-MM for submit@debbugs.gnu.org; Wed, 22 Jun 2016 23:23:31 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:34645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFvEn-0007QE-VL for 4117@debbugs.gnu.org; Wed, 22 Jun 2016 23:23:30 -0400 Received: by mail-qk0-f172.google.com with SMTP id t127so91740147qkf.1 for <4117@debbugs.gnu.org>; Wed, 22 Jun 2016 20:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=477oGXuwMfVE8lS6TfvWRLakddWyQBEeKPPK6iO4gHU=; b=TB4/0wF/WbzZqVj/igAIeSEhAjRWkW6nLo+w8KKOD/Pn4qxyfu8LpEa583mxEM7auw 1NSr6jsUz/0YQvNaXKU+LpgZsj2boTGh5tu+MlPfdXxggTBiYUBNtKXMzQ8AeVvrR7b4 5TC2dtLZYjXbxK9SxJMOp1wL98tzPLmsWKySMhOynWJW0KX2po+DtFqD2Xg9+HSYopTy 78l3qGTNz5KAZufSf33OAx7SnYRruwFaX/+IkyxLcOQ0jIZM2FM/7y6NZHEbuM3qOIb0 32iLAXywUT2nazav64uDt1Ltsrr468krZVoBxDxGyWRbqoVzerCV5a9HRXrc+/wIAFae jiHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=477oGXuwMfVE8lS6TfvWRLakddWyQBEeKPPK6iO4gHU=; b=eVRbH4yBfOI7YeJYBR2QCydQUFPWkw3nqWwrXgpf7/l6KhB0QSv8gatB0oICvmH+j9 Re8tftlSM/KRvSHvX5+VZPTO/IdcKj7h6EPRCC5OMoJYl3R0M6H/YRq4+Vdh5PEZqAqB bsjYe7QflEKQRC2DGx5q2ixGCmpZP86UgOEWt0LlWHzXya4YYa5u0PVBSDyglEMgYq/r XXJqJq3JyKcAjymxcnbouGRuqK53x/03a8I9kpVLphdIrWGHKXbDwfhMgjeSHEO9reuj e8XkKjsJZKSVuIah32N/G2/70vCttYHv4Eu90Sy3XbBLdFfW4B6i19CrCGrCyzJjybz4 Y5RA== X-Gm-Message-State: ALyK8tL63knFJ+gw15f8Ho2JWVp8iOHZJpMWsoV6LZ3+cpPoUoFDP9ihSV4MZtuKWtGToA== X-Received: by 10.55.188.198 with SMTP id m189mr40268159qkf.205.1466652204436; Wed, 22 Jun 2016 20:23:24 -0700 (PDT) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id w1sm1394913qtd.12.2016.06.22.20.23.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2016 20:23:21 -0700 (PDT) From: Andrew Hyatt To: Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift References: <3550cc63-9365-4d30-b494-e1809e25704c@default> Date: Wed, 22 Jun 2016 23:23:20 -0400 In-Reply-To: (Eli Barzilay's message of "Sun, 19 Jun 2016 23:50:48 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Barzilay writes: > On Sun, Jun 19, 2016 at 8:57 PM, Andrew Hyatt wrote: >> On Sun, Jun 19, 2016 at 10:36 AM Drew Adams wrote: >>> >>> It works for me on MS Windows also, using an old Emacs 25 build. >>> Following Alan's recipe gives the behavior he describes: >>> >>> > I have `isearch-allow-scroll' set to t, and I search for a word in >>> > Isearch, which is found. I then type C-S-right just once, and the next >>> > word after what had been the highlighted search region gets highlighted >>> > for me (in grey). The Isearch operation is now terminated. > > Yes, that was my meaning, and it looks like it works fine even in > v24.5.1. > > >> Perhaps I misunderstood the original bug, but I thought the problem >> was that when you C-S-right, the text that was highlighted with >> isearch is no longer highlighted. >> >> Are you saying that that original selection that you were initially on >> before the C-S-right is still highlighted, or are you saying it isn't, >> and that's not a bug? > > My expectation (which is what it's doing now) is that a C-S-right would > terminate isearch and select the next word. OK, if that's the case, then it seems to me that this bug report is either unreproducible, or (if I understand the report correctly) not a bug in the first place. I'll close as not a bug for now. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 23:24:07 2016 Received: (at control) by debbugs.gnu.org; 23 Jun 2016 03:24:07 +0000 Received: from localhost ([127.0.0.1]:51672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFvFP-0007Rv-0N for submit@debbugs.gnu.org; Wed, 22 Jun 2016 23:24:07 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFvFN-0007RF-8R for control@debbugs.gnu.org; Wed, 22 Jun 2016 23:24:05 -0400 Received: by mail-qk0-f177.google.com with SMTP id a186so91699635qkf.0 for ; Wed, 22 Jun 2016 20:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:message-id:to:from:subject; bh=HuQIxEvfCWmKcCNkxqe+VxcJi+EHk2bZ206KBAP3t2M=; b=GWTbStjjm7knzSRpdV5oWTWhug+BY8Vqf7ELEYmjCP/iYCVm0ZY5mBTKwG/1nz+MRo LzUIrvIyxx+l0hGZIFZE/ld8q4x2u27hrO9b4Q9kaO6xne2CYt6PtHGVIjvB1pLiHKgn jXd5uuUUrSn21Io55k7KJlIDZmtsXsLQQ2EwvVDrHqR5f1wdEdBd3s4CVTiwd7h7o15n QzkX4N4Suwu6SqGOBf1tvvWYH8UDeLFnoXSGM0Vqdzzr10BGrlZ6OS2wiFk+vdBGOK6V jSEwy5dHl2I6Tvtmx2AKepWllZwDDLi0occVQGrWYLp8MkKOovjSwvtXRz/Hh1l6ugO4 JnGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:to:from:subject; bh=HuQIxEvfCWmKcCNkxqe+VxcJi+EHk2bZ206KBAP3t2M=; b=GCkukNrofISvLkh0VzTAgxb2st0c6RpAMAiHNgy7ySDVA/VT53ZB2uASmsGMHX0yvv ndpBRzqk9VZbUIIsI75pR9X4uFOJtULm8BQHTUwrccH/KViDmr9I/ktglB16VUknbc/3 9lttzH4PipMq+MdbvBBQGrbuJBFnL+cw2dBV26pw7Cop5yl6y3JNX8p7T0S2UW5vOunw 1Wv5jo54T/qqJ8DNcDPEJi3ESX/ozqExhPhhhULzA7bL4srCvxoa+ybWE+XcDYLEebGV jgoahhCAK+4b0grD2vJ3waMRVciq8qKfF7hW7BaPy1Ck5H2wowoFXo8zmBGDlbEJbnSo 7dMQ== X-Gm-Message-State: ALyK8tIzavFv7/h2ZS9r2hbs9r0/cL5EqvkuUDLgC0fQjFhlBLmcKpvZjbkmHBH17iPjfA== X-Received: by 10.55.217.24 with SMTP id u24mr38950012qki.93.1466652239670; Wed, 22 Jun 2016 20:23:59 -0700 (PDT) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id w67sm1429584qkd.26.2016.06.22.20.23.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2016 20:23:58 -0700 (PDT) Date: Wed, 22 Jun 2016 23:23:57 -0400 Message-Id: To: control@debbugs.gnu.org From: Andrew Hyatt Subject: control message for bug #4117 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 4117 notabug close 4117 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 00:18:24 2016 Received: (at 4117) by debbugs.gnu.org; 23 Jun 2016 04:18:24 +0000 Received: from localhost ([127.0.0.1]:51687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFw5v-0001sl-R6 for submit@debbugs.gnu.org; Thu, 23 Jun 2016 00:18:23 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:35173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFw5t-0001sY-Q6 for 4117@debbugs.gnu.org; Thu, 23 Jun 2016 00:18:22 -0400 Received: by mail-it0-f49.google.com with SMTP id g127so60866297ith.0 for <4117@debbugs.gnu.org>; Wed, 22 Jun 2016 21:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=barzilay-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uRlf2zEkDx0IppQNm6eow5XBR5JXckS4JjDQnkVyhXY=; b=cwDK8+aE+zYY8415LHreCDQ1uP8L2dXcb5CtsyYW+VljN8l+mD7vTnZHt1YYgjHLs6 h9OG3/M1yuyoO0oXCjYd366YfQGpinveDRVJJnotkSz2EUcYv1nja2Y1VS7xjMveFKsw 0Y+Axazp+1deu6ZnwJNOlcAJiKayJgHq+rmSlRqIMIhp0jQ7VmzGt0xMgEZ2bA0sk5AA D6Lt4mxXGmxMTYAMyCVNjQRclfsnfu5A1J58Shjv/0Brpc+g5f7WJxpVNesUDpzaOp93 UXJJKbblzT+Nb9YgO25zuGdt1ueY4S0T+0Id4WIGNiPYallg0A5t7icz8DkujnqkD8eT hYAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uRlf2zEkDx0IppQNm6eow5XBR5JXckS4JjDQnkVyhXY=; b=ebi6oXz3uXeW+bAJDBUXtW3Wd2AEhXXShjAnZkTGcm5Q4PcQV3HP8R9QYJVKK+aDLf v/gGDLB5N4eCZ8MuVmL2SeXkXM9Q6fVPECX4YtgFhmnYlqhGN5MyCXbNZzqyVFMT2LnJ 4L5qsypfG7rpr59Age67b/msjBXNgICFNqAspnV/ixoZNLDn1qpjwIQfGMaM4U1ALXQ2 ILFgYmYEd2AEMiSRdk5NMd6U0aaEgUxB2OaFL/QPkwNv4ZO0cHpmp6VakfC1hdSXJnXn uVGfExzahrb/YM5BXlC3mnzjZg1FCqgcqlcnEnG3I+oTn5BkdLpRK8qnB5tzAMjBtuhn 4CGw== X-Gm-Message-State: ALyK8tKGigQMi5dZQwhL/89ZpFJDJ5oo3cstyXf0w8o4iPWmktaDq2xcXp6akVgVGfwpBYptpOwz0PMrRLfmUg== X-Received: by 10.36.3.7 with SMTP id e7mr18162679ite.15.1466655496263; Wed, 22 Jun 2016 21:18:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.119.27 with HTTP; Wed, 22 Jun 2016 21:18:15 -0700 (PDT) In-Reply-To: References: <3550cc63-9365-4d30-b494-e1809e25704c@default> From: Eli Barzilay Date: Thu, 23 Jun 2016 00:18:15 -0400 Message-ID: Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift To: Andrew Hyatt Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Wed, Jun 22, 2016 at 11:23 PM, Andrew Hyatt wrote: > > OK, if that's the case, then it seems to me that this bug report is > either unreproducible, or (if I understand the report correctly) not a > bug in the first place. Um, I reported it for 23.1, seven years ago. Back this it definitely *was* a bug (read the emails: we discussed a hack I had around it, and other ways to solve it). Your conclusion that it's "not a bug a bug in the first place" is therefore very strange. -- ((x=>x(x))(x=>x(x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 14:15:25 2016 Received: (at 4117) by debbugs.gnu.org; 23 Jun 2016 18:15:25 +0000 Received: from localhost ([127.0.0.1]:52963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG99x-0002OW-Da for submit@debbugs.gnu.org; Thu, 23 Jun 2016 14:15:25 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG99v-0002OI-71 for 4117@debbugs.gnu.org; Thu, 23 Jun 2016 14:15:23 -0400 Received: by mail-wm0-f45.google.com with SMTP id f126so137061063wma.1 for <4117@debbugs.gnu.org>; Thu, 23 Jun 2016 11:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yMlfvW474yKB0Ohiz20S3y7AosA7ugaNuc+0XQX86aU=; b=erlNRj1O/LCOkl7jCHPSNt+nQbi6rpEuQLgYkH/KFKGhIzudDacBL0lAlW/bt/6KwB by1w04x6fZNUbF/9hwfqmemFOG/g6rqpVau5LrsF1zXpqls7H8ZZ11A3mIswwCH3LYLi gvHwvR5B7mKVMZ56helU0kb6vpc1yz+skmkxheAzFtvb36it/v/0z16kd60EbVEEZohl +tcHoHe7Bzvpg74G7A76gfolFsv7yz+6Ngz4Q/rgLcNdAL1Jaxemmee/+REYTSZPOdJp ApMD8oHOOKmmiJ5Ypt+N202ptchfx3lv+tpCohehqu80UbJbt5pHMzonMbLS1gbXy83P yCgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yMlfvW474yKB0Ohiz20S3y7AosA7ugaNuc+0XQX86aU=; b=T+BItJRLbbTgWMmHKZbU8j1pGKxtmj0O7/jTP67oWtyuIV3SMdwC4Om8gcH8CaYlVR t+YnDH9cfit2n8IH4neD0DERxlEoZA/3JS46lHU6QatdffeLQG8bt6glClosgfySHrjx GzkUSI5CCQDoZsZ7q9NeYyyI5a5M44ybeOt3NZX9rMzmn1wAxWj0nXDLFGBajVbhJfJC qhJMwBEkP2+drsx/49B3WKH4dPFCxgmAvGgxlN9C8vVRSAUOhoGljgvcDQHZz8CMZLnR 9revtEdnn7VwddmPhw0rGSf16ipPugCF6sryLJUtZjFquD1Fc1gXlm8Ht4X9KdeRcELu HriA== X-Gm-Message-State: ALyK8tIMzvj3fuWPzXsX0t1GvzJfJRHkV5rx3dJVOuromc0vqXa9ECHQEDqCE3iuKusdEhCxeT2Cmo043YH+oQ== X-Received: by 10.28.129.197 with SMTP id c188mr2134210wmd.46.1466705717575; Thu, 23 Jun 2016 11:15:17 -0700 (PDT) MIME-Version: 1.0 References: <3550cc63-9365-4d30-b494-e1809e25704c@default> In-Reply-To: From: Andrew Hyatt Date: Thu, 23 Jun 2016 18:15:08 +0000 Message-ID: Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift To: Eli Barzilay Content-Type: multipart/alternative; boundary=001a114243604948de0535f609bd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114243604948de0535f609bd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, Jun 23, 2016 at 12:18 AM Eli Barzilay wrote: > On Wed, Jun 22, 2016 at 11:23 PM, Andrew Hyatt wrote: > > > > OK, if that's the case, then it seems to me that this bug report is > > either unreproducible, or (if I understand the report correctly) not a > > bug in the first place. > > Um, I reported it for 23.1, seven years ago. Back this it definitely > *was* a bug (read the emails: we discussed a hack I had around it, and > other ways to solve it). Your conclusion that it's "not a bug a bug in > the first place" is therefore very strange. > Perhaps I've misunderstood your original bug report or reply. To be as clear as possible, here's what I think is true, so tell me what part I'm misunderstanding: The original bug report was that if you do an isearch, then C-S-right, the word that was selected as part of isearch is no longer selected, and the selection starts out to the right of the word. So, if you searched for "foo" and the buffer text was "foo bar", and isearch is selecting "foo", then C-S-right will leave you with only "bar" selected, instead of "foo bar" selected. This is something I can reproduce right now on Emacs 25. You said you could no longer reproduce this, and that your expectation is that "C-s-right would terminate isearch and select the next word". I understood this to mean that C-s-right would, in our example, only select "bar", and that's the expected behavior. Is it? > > -- > ((x=>x(x))(x=>x(x))) Eli Barzilay: > http://barzilay.org/ Maze is Life! > --001a114243604948de0535f609bd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On Thu, Jun 23, 2016 at 12:18 AM Eli Barzilay <eli@barzilay.org> wrote:
On Wed, Jun 22, 2016 at 11:23 PM, Andrew Hyatt <ahyatt@gmail.com> wrote:
>
> OK, if that's the case, then it seems to me that this bug report is
> either unreproducible, or (if I understand the report correctly) not a
> bug in the first place.

Um, I reported it for 23.1, seven years ago.  Back this it definitely
*was* a bug (read the emails: we discussed a hack I had around it, and
other ways to solve it).  Your conclusion that it's "not a bug a bug in
the first place" is therefore very strange.

Perhaps I've misunderstood your original bug report or reply.  To be as clear as possible, here's what I think is true, so tell me what part I'm misunderstanding:

The original bug report was that if you do an isearch, then C-S-right, the word that was selected as part of isearch is no longer selected, and the selection starts out to the right of the word.  So, if you searched for "foo" and the buffer text was "foo bar", and isearch is selecting "foo", then C-S-right will leave you with only "bar" selected, instead of "foo bar" selected.

This is something I can reproduce right now on Emacs 25.

You said you could no longer reproduce this, and that your expectation is that "C-s-right would terminate isearch and select the next word".  I understood this to mean that C-s-right would, in our example, only select "bar", and that's the expected behavior.  Is it?
 

--
                   ((x=>x(x))(x=>x(x)))                  Eli Barzilay:
                   http://barzilay.org/                  Maze is Life!
--001a114243604948de0535f609bd-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 13:23:33 2016 Received: (at 4117) by debbugs.gnu.org; 7 Jul 2016 17:23:33 +0000 Received: from localhost ([127.0.0.1]:41485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLD1R-0003mO-34 for submit@debbugs.gnu.org; Thu, 07 Jul 2016 13:23:33 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:35489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLD1P-0003mC-If for 4117@debbugs.gnu.org; Thu, 07 Jul 2016 13:23:32 -0400 Received: by mail-io0-f180.google.com with SMTP id f30so27906009ioj.2 for <4117@debbugs.gnu.org>; Thu, 07 Jul 2016 10:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=barzilay-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UOyWyNvxED1QB41nQrhF5NfFXai4u9YbGpkOnd+HJHc=; b=YzmB2/aBmRDS9I6eY9tP692PVzDJpB6Nsj7yqznE7qfSDwAru62T5BSMwhk+iYz7uO F/1wjBg0kSKiCQbvxlG4xtDXpTaKwAdf2baZ2OriSE0Zxk1ezbKpxmYBfxNGJa9Kj/1w ApJumrpEn/q6jXx4nGmiEp9Gf8CcEvMqM/KgKzwyh3SSn/ViJyN0HCQUE6cW/+KC4yhB A2FXwMhFArfqT6nJY9AXWk3BSFdJ8qP0syZlud+EClimvcJpzhC5493DdHpuE6GyZ+c9 XoPeSsO8BUpoEfeHX4aa0DDGb04fSkyfwnz6N/spaJbg0+S8nc8YZOFXzNy1DbnWuZTz R+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UOyWyNvxED1QB41nQrhF5NfFXai4u9YbGpkOnd+HJHc=; b=imoSVx/PPef6z1OOhaRrwSni094KPVNLClThqVA8mqjEYtn9pmelXUVzLa3btw2clU mnieUlC20TFVO39cgf36sTuWFxJkdiG7SvI0jj9cjsBQSZW3meYgx/huzniAK882o50i ZNfliBPnaCimOj1l6+ENBLx5w4xLQleEO6mMSFOeqcadB2Rzu2QYDkSdcrBR8opfeEr3 rlk4z8CI2lwykYlm6i/DTSCLCOwjXXkrX3FzKm5NqekL3iJwvzG0wnwJtH3B+wUU4cON SpFcFRkmmCKykn2Uv4OeryiPh0Wei8bJgXamnKCQ/fOAMaMsooRAf4u6CvjqpaJVp1XJ hkaw== X-Gm-Message-State: ALyK8tJ1ifgDa8kHjHDXIyrnaFPCMXNc9nmv7+cKrCCVCYrkh2A6gYazaLZ9bZR5AKyZnbX1GZrYYcPM6Naglg== X-Received: by 10.107.156.211 with SMTP id f202mr3999304ioe.112.1467912205908; Thu, 07 Jul 2016 10:23:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.32.81 with HTTP; Thu, 7 Jul 2016 10:23:25 -0700 (PDT) In-Reply-To: References: <3550cc63-9365-4d30-b494-e1809e25704c@default> From: Eli Barzilay Date: Thu, 7 Jul 2016 13:23:25 -0400 Message-ID: Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift To: Andrew Hyatt Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On Thu, Jun 23, 2016 at 2:15 PM, Andrew Hyatt wrote: > On Thu, Jun 23, 2016 at 12:18 AM Eli Barzilay wrote: >> >> On Wed, Jun 22, 2016 at 11:23 PM, Andrew Hyatt wrote: >> > >> > OK, if that's the case, then it seems to me that this bug report is >> > either unreproducible, or (if I understand the report correctly) not a >> > bug in the first place. >> >> Um, I reported it for 23.1, seven years ago. Back this it definitely >> *was* a bug (read the emails: we discussed a hack I had around it, and >> other ways to solve it). Your conclusion that it's "not a bug a bug in >> the first place" is therefore very strange. > > > Perhaps I've misunderstood your original bug report or reply. To be > as clear as possible, here's what I think is true, so tell me what > part I'm misunderstanding: > > The original bug report was that if you do an isearch, then C-S-right, > the word that was selected as part of isearch is no longer selected, > and the selection starts out to the right of the word. So, if you > searched for "foo" and the buffer text was "foo bar", and isearch is > selecting "foo", then C-S-right will leave you with only "bar" > selected, instead of "foo bar" selected. No: what you're describing was the behavior I *expected*. The bug was that the key that was used to exit isearch -- C-S-right in my reported case -- would "lose" the shift bit, making it be treated as just C-right, and leaving the buffer with the cursor after the "foo bar" and with no selection. If you look at the past emails for this bug, you'll see that the reason for that was discussed, including a solution that was most likely implemented. > This is something I can reproduce right now on Emacs 25. ... And the result of the above is that it is indeed working as you describe on v25 which means that it was probably fine for a while now but the bug was just not closed. > You said you could no longer reproduce this, and that your expectation > is that "C-s-right would terminate isearch and select the next word". > I understood this to mean that C-s-right would, in our example, only > select "bar", and that's the expected behavior. Is it? To summarize it: all is fine and this bug should be closed -- I just objected to your reasoning that it was "not a bug in the first place". It *was* a bug, and it got resolved -- a long time ago. -- ((x=>x(x))(x=>x(x))) Eli Barzilay: http://barzilay.org/ Maze is Life! From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 09 08:39:02 2016 Received: (at 4117) by debbugs.gnu.org; 9 Jul 2016 12:39:02 +0000 Received: from localhost ([127.0.0.1]:43315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLrXC-0008Ur-50 for submit@debbugs.gnu.org; Sat, 09 Jul 2016 08:39:02 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:34860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLrX8-0008UL-Qw for 4117@debbugs.gnu.org; Sat, 09 Jul 2016 08:39:01 -0400 Received: by mail-qt0-f174.google.com with SMTP id f89so33717978qtd.2 for <4117@debbugs.gnu.org>; Sat, 09 Jul 2016 05:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UNeFzRy/8tizHoig6gkxfzqni2+yXTr5lIRu3WzfQiU=; b=FBpMMKDsjDAQpUS7J+xcmttXM0KwJdQ0QSNPfQbkA8F/DjJslmUd8ZSiLvaqv/K9Kq yE9UZ5OJw8sU/pA54Eosdj16zF9vnPzw8rRt1OFrP/7j5P1NwFyc9zCS+k1mG4svhwe1 TrwXY0rR9jcTioPv97lIQVRrXamMw5V2v8XVksFk56kru39XLdsBpHV3Fimi+argobY4 Li7PesCNpcZ9lgdWUfHDHZJuM5HNlnOZnvjhRQV5KqbQ6yVeUdCZIGyEUv3VeoI58/8s wBpMmUbYVJr1ktdGSImy/MES/G+0Ko5WERiC/du3+P8WVVQzmr01/1hVvvlKoziyzmZq 1R7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UNeFzRy/8tizHoig6gkxfzqni2+yXTr5lIRu3WzfQiU=; b=Em/S/yL5NeX1NStIh8j2PcQ5A8gFTBEDWx4ybLk9vWIpWo9ZM2jVLcKrhIYkIy1m0p iIbjeFie6dGhkCR+Bn5wa6XIjjCA6Ccl9ml1bpmhJ2XTugAzrWJA94P0GImmiVfj3nna velfROzMiOxc5sroYE/Oq2p/gcNNQAZ31YqnNQdqqjoc7ol1elMIU6IknA942D/MFHpc MpY3atwSqEkCs0LGe/pWSLjYKTi9lzwgX1Djl9HqonkmX6pD2tUGwwfRYVIR1tEytVIt zyeJJ0dBg9P00TS4PZSR6ixvRAOeowYBIrrsmolQYCSX0bbzOo+1/2672DIEiWiVWcAB JIaA== X-Gm-Message-State: ALyK8tLf9TwJsiGP/I91wQ0XQVDtiOYj1gitfGw1wiuD0FFKZyHas3zPOa9NYsOB7C2+Yg== X-Received: by 10.200.46.54 with SMTP id r51mr15939476qta.42.1468067933315; Sat, 09 Jul 2016 05:38:53 -0700 (PDT) Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id c15sm1087048qkg.46.2016.07.09.05.38.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Jul 2016 05:38:50 -0700 (PDT) From: Andrew Hyatt To: Eli Barzilay Subject: Re: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift References: <3550cc63-9365-4d30-b494-e1809e25704c@default> Date: Sat, 09 Jul 2016 08:38:49 -0400 In-Reply-To: (Eli Barzilay's message of "Thu, 7 Jul 2016 13:23:25 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 4117 Cc: Alan Mackenzie , 4117@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Barzilay writes: > On Thu, Jun 23, 2016 at 2:15 PM, Andrew Hyatt wrote: >> On Thu, Jun 23, 2016 at 12:18 AM Eli Barzilay wrote: >>> >>> On Wed, Jun 22, 2016 at 11:23 PM, Andrew Hyatt wrote: >>> > >>> > OK, if that's the case, then it seems to me that this bug report is >>> > either unreproducible, or (if I understand the report correctly) not a >>> > bug in the first place. >>> >>> Um, I reported it for 23.1, seven years ago. Back this it definitely >>> *was* a bug (read the emails: we discussed a hack I had around it, and >>> other ways to solve it). Your conclusion that it's "not a bug a bug in >>> the first place" is therefore very strange. >> >> >> Perhaps I've misunderstood your original bug report or reply. To be >> as clear as possible, here's what I think is true, so tell me what >> part I'm misunderstanding: >> >> The original bug report was that if you do an isearch, then C-S-right, >> the word that was selected as part of isearch is no longer selected, >> and the selection starts out to the right of the word. So, if you >> searched for "foo" and the buffer text was "foo bar", and isearch is >> selecting "foo", then C-S-right will leave you with only "bar" >> selected, instead of "foo bar" selected. > > No: what you're describing was the behavior I *expected*. The bug was > that the key that was used to exit isearch -- C-S-right in my reported > case -- would "lose" the shift bit, making it be treated as just > C-right, and leaving the buffer with the cursor after the "foo bar" and > with no selection. If you look at the past emails for this bug, you'll > see that the reason for that was discussed, including a solution that > was most likely implemented. > > >> This is something I can reproduce right now on Emacs 25. > > ... And the result of the above is that it is indeed working as you > describe on v25 which means that it was probably fine for a while now > but the bug was just not closed. > > >> You said you could no longer reproduce this, and that your expectation >> is that "C-s-right would terminate isearch and select the next word". >> I understood this to mean that C-s-right would, in our example, only >> select "bar", and that's the expected behavior. Is it? > > To summarize it: all is fine and this bug should be closed -- I just > objected to your reasoning that it was "not a bug in the first place". > It *was* a bug, and it got resolved -- a long time ago. Got it, thanks for the explanation. I'll make sure this is closed. From unknown Tue Aug 19 05:09:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator