GNU bug report logs - #41145
27.0.91; small issues with `display-fill-column-indicator' Customization group

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Sat, 9 May 2020 08:31:01 UTC

Severity: normal

Found in version 27.0.91

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 41145 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Mauro Aranda
 <maurooaranda <at> gmail.com>
Cc: 41145 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>
Subject: RE: bug#41145: 27.0.91; small issues with
 `display-fill-column-indicator' Customization group
Date: Sun, 30 Aug 2020 08:09:21 -0700 (PDT)
FWIW, I've said it before, and reiterate now: I
think :group should always be explicitly present.

We've gone to the other extreme, of not only
encouraging its removal (apart from an initial
occurrence), but even removing it from patches
that contained it.

Why do I feel this way?  Repeating what I've
said before:

1. Nothing is really gained.  The amount of
   additional text eliminated is trivial - tiny.

2. A defcustom that's not near a previous one
   has its :group unclear (for humans).

3. It's problematic and error prone wrt moving
   defcustoms around.

It doesn't hurt, and it can help human readers
to just include explicit :group.

Whether that should just be conventional (i.e.,
recommended/encouraged) or actually enforced is
a different question.  I'm not sure it needs to
be enforced (e.g. warning or error msg), but I
don't think that would hurt, and it might help.

Just one opinion.  I repeat it here only because
I haven't mentioned it in a long time - probably
not since the crusade to remove "unnecessary"
:groups was initiated.

(And no, this is not very important.  Just sayin.)




This bug report was last modified 4 years and 248 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.