From unknown Tue Jun 17 20:12:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41145 <41145@debbugs.gnu.org> To: bug#41145 <41145@debbugs.gnu.org> Subject: Status: 27.0.91; small issues with `display-fill-column-indicator' Customization group Reply-To: bug#41145 <41145@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:12:31 +0000 retitle 41145 27.0.91; small issues with `display-fill-column-indicator' Cu= stomization group reassign 41145 emacs submitter 41145 Philipp Stephani severity 41145 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 04:30:21 2020 Received: (at submit) by debbugs.gnu.org; 9 May 2020 08:30:21 +0000 Received: from localhost ([127.0.0.1]:46764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXKsH-0001gB-AH for submit@debbugs.gnu.org; Sat, 09 May 2020 04:30:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:37274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXKsE-0001g1-PX for submit@debbugs.gnu.org; Sat, 09 May 2020 04:30:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXKsE-0003Y7-KD for bug-gnu-emacs@gnu.org; Sat, 09 May 2020 04:30:18 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:53112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXKsD-0004Ny-E0 for bug-gnu-emacs@gnu.org; Sat, 09 May 2020 04:30:18 -0400 Received: by mail-wm1-x32c.google.com with SMTP id m24so2937661wml.2 for ; Sat, 09 May 2020 01:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=bS5S/ozy0dDu1VkyF2Jpbzr1f4cm/YXoEtzLa+97oYY=; b=ccivZ3lMefvMdSqiJRayqlne37ugWsTtCoK0JlqF/PqISJ+9ohOle5g30Acl5WOVwF pGT3T0/L9wMgC46GDdEoxHHgRmm4ERP1JQ+v7kkFLdQAE6vFGl9u8meFK2sMjOLn19Lh GF6aft0er63NP5UX9UofpY3XvUNC+xpHq0Cqaz2XcRNgw8r7ohKYEj+XfTHjGyoo+hFO veFpzAChIKirQeYiiB3y2vYqpmtXfHWxqTe4HVNRF9jbGvcmqBm7hCA+/XVN+E7HYFvr ImNxO1DwpFS0PZ2mzXDMNZAAPulXFLA1Qilc4l4sy5SOwH4rC1jlY6s5IGOp0DA4VLME YJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=bS5S/ozy0dDu1VkyF2Jpbzr1f4cm/YXoEtzLa+97oYY=; b=oGei/8anz7R9OkoO0RjSt1khD+E8t0wlGyKEiBmIUlPpg7DRd0xVEu9PMAxhQAUe1D kFBtfspDax8NgiRKFSXUJAbqgEhjIKPl3bTYC/uungC+LqXzV3Er9ABoGl+8lu9jvf26 7iXNwfcm6tzr2m4xGWHSCTKXmloZdbbJgytENrjD4CHBmFejGP6CxLhFmxOwU72cAMz8 6mMNwR4mTIoUQ3rDbiSFi8+cDs3QgTRrUez5gjyGAB6IOcWZwBkzB+ZMeFVgUMeoH3XC uxXx5Q1TPSfK797neV1kGE4FcRANMtdVqpNRFqoH0vF99/WmVjAX4FjSodtQvZMdctOJ c0+Q== X-Gm-Message-State: AGi0PubaW6ET9G5OHOTo9+EL18h4wOnZnKMmCAqsCdJUwy8s615BdMCN YI7TXcKdtPjGrAcWSw8ESbdMojHjhXM= X-Google-Smtp-Source: APiQypIpVCiQNpYQiyV61XhIuIDxPtxwTqxsNzj4od0SEmdGJwZTSlNZth4safm7oOQ5Ua0TplzJwg== X-Received: by 2002:a1c:1dc7:: with SMTP id d190mr13209524wmd.97.1589013014595; Sat, 09 May 2020 01:30:14 -0700 (PDT) Received: from phst1 ([2a02:2455:2a2:100:c351:ffcc:5d8e:4288]) by smtp.gmail.com with ESMTPSA id x7sm16266917wmi.17.2020.05.09.01.30.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2020 01:30:14 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Sat, 09 May 2020 10:30:13 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x32c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) M-x customize-group RET display-fill-column-indicator RET, then expand the section for `display-fill-column-indicator-character'. The customization buffer then contains: Display Fill Column Indicator group: Group definition missing.=20 State : visible group members are all at standard values. =20=20=20 [...] Hide display-fill-column-indicator-character: nil State : STANDARD. (mismatch) Character to draw the indicator when =E2=80=98display-fill-column-indica= tor=E2=80=99 is non-nil. More The two issues here are: 1. "Group definition missing." It looks like customizing this group should load `display-fill-column-indicator-mode', which defines this group, or the group definition should be in cus-start.el. 2. "(mismatch)." The default value for `display-fill-column-indicator-character' is nil, but its type is `character', so nil isn't allowed. In GNU Emacs 27.0.91 (build 9, x86_64-pc-linux-gnu, GTK+ Version 3.24.13) of 2020-05-09 Repository revision: d5c184aa3e2a183144efa5f269e2c70d2681aa0a Repository branch: emacs-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux rodete Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --enable-checking=3Dall --enable-gtk-deprecation-warnings --enable-gcc-warnings=3Dwarn-only --enable-check-lisp-object-type --with-mailutils --without-pop 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-g3' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 63403 5547) (symbols 48 8443 1) (strings 32 22409 1678) (string-bytes 1 711978) (vectors 16 12504) (vector-slots 8 174118 5994) (floats 8 25 34) (intervals 56 201 0) (buffers 1000 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 05:37:30 2020 Received: (at 41145) by debbugs.gnu.org; 9 May 2020 09:37:31 +0000 Received: from localhost ([127.0.0.1]:46785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXLvG-0003QV-O8 for submit@debbugs.gnu.org; Sat, 09 May 2020 05:37:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXLvE-0003QI-P4 for 41145@debbugs.gnu.org; Sat, 09 May 2020 05:37:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48701) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXLv9-0002fS-GL; Sat, 09 May 2020 05:37:23 -0400 Received: from [176.228.60.248] (port=4192 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jXLv8-0003hW-VY; Sat, 09 May 2020 05:37:23 -0400 Date: Sat, 09 May 2020 12:37:13 +0300 Message-Id: <833689h2k6.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-Reply-To: (message from Philipp Stephani on Sat, 09 May 2020 10:30:13 +0200) Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Sat, 09 May 2020 10:30:13 +0200 > > The two issues here are: > > 1. "Group definition missing." It looks like customizing this group > should load `display-fill-column-indicator-mode', which defines this > group, or the group definition should be in cus-start.el. The same seems to work for display-line-numbers, and I don't think I see the crucial difference. > 2. "(mismatch)." The default value for > `display-fill-column-indicator-character' is nil, but its type is > `character', so nil isn't allowed. I fixed this, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 08:31:53 2020 Received: (at 41145) by debbugs.gnu.org; 9 May 2020 12:31:53 +0000 Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXOe1-00063Q-2C for submit@debbugs.gnu.org; Sat, 09 May 2020 08:31:53 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:45172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXOe0-00063C-Gc for 41145@debbugs.gnu.org; Sat, 09 May 2020 08:31:52 -0400 Received: by mail-ot1-f53.google.com with SMTP id e20so3713798otk.12 for <41145@debbugs.gnu.org>; Sat, 09 May 2020 05:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=++duligZEE3swOiPRH1JqIn68MgwHgdahLBe/cFzBsw=; b=jNxarkRdQZq8lewKUDqlwOZffrKienKkh5MfxoMhjFBKXlPhjEmBuSeDig0cnfl83P a6ecwHzBOKl3/Lgj/P+odxqsIQTaRzT38HdcexUiOMdMWaXGxm9RtZCnEkqL7JIQM+aq Wu/8BsNHPJgviAuapyrJfFWIOIYapVR16uWig3rTHasSWlMOrmBY6uLu3eCZ2jRxYLGb bHi+2q7hNnDYe46zW25GR5Q4Pa4UqpSeK4s/K9HmHo99/3Z1bHvyjvxYHT0hgOfVGcLy A6P6rtsxGKMjsDZtm6DPlHosNHZsirXpb+wAG16wSjckL/DHAxik4jdP3bagogdcVb+r 5KOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=++duligZEE3swOiPRH1JqIn68MgwHgdahLBe/cFzBsw=; b=n9Vtnp9LIzMOY4HapdTxgrz/wZLrgK6eIY0somRXA3sRAuc6sMBJQn+5G2AAWQ8Pz5 yXDBIv1OwxcI8ZBOYsjJ3BSBPtJ32/CPPJibv0ebhws3WIcSqEi6CXU9DUQLdkcHjbgz coEj7MlqLPIQECxqX1FJuEt6ODAbTqzAojjnV5uLvqE6K76YjDoY5fxjKTX6CSHBF1qT S/KnZN0JcK+0SahrGBLab9qUo5vWwDtVy+FBe+Xc0yi2/jckC+EU3q3rLw4hY71z+Od7 O0QgqWwddNqc9seArluS+PQza05PRI+FcDC4Wscpd2Y8SO5ijarN+8nkS/BmSBkkLwWV aXRQ== X-Gm-Message-State: AGi0PuadIjZcTqSlLUo3Yh2cKpq44QyMHAib0SNjens87D0mFmvHCOy9 yVfxpCx/kRl2AVy8+mFQSJALZWQ3yEI2VrB4/QOB050M X-Google-Smtp-Source: APiQypL5ixlEtlVvz8ok6roAuLaHnaAOSZVv7NczxDgWzbIXhNYhPz5sByaw4HjK7ArkHyZ2ZKpCCNxFVyGYPKHZyxw= X-Received: by 2002:a9d:22c9:: with SMTP id y67mr5819168ota.36.1589027506536; Sat, 09 May 2020 05:31:46 -0700 (PDT) MIME-Version: 1.0 References: <833689h2k6.fsf@gnu.org> In-Reply-To: <833689h2k6.fsf@gnu.org> From: Philipp Stephani Date: Sat, 9 May 2020 14:31:35 +0200 Message-ID: Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Sa., 9. Mai 2020 um 11:37 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Sat, 09 May 2020 10:30:13 +0200 > > > > The two issues here are: > > > > 1. "Group definition missing." It looks like customizing this group > > should load `display-fill-column-indicator-mode', which defines this > > group, or the group definition should be in cus-start.el. > The same seems to work for display-line-numbers, and I don't think I > see the crucial difference. My guess is that something is wrong with cus-dep.el, because the f-c-i group doesn't appear in cus-load.el. > > > 2. "(mismatch)." The default value for > > `display-fill-column-indicator-character' is nil, but its type is > > `character', so nil isn't allowed. > > I fixed this, thanks. Thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 10:49:18 2020 Received: (at 41145) by debbugs.gnu.org; 28 Aug 2020 14:49:18 +0000 Received: from localhost ([127.0.0.1]:47114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfgr-00062k-OU for submit@debbugs.gnu.org; Fri, 28 Aug 2020 10:49:18 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:43402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBfgp-00062X-T7 for 41145@debbugs.gnu.org; Fri, 28 Aug 2020 10:49:16 -0400 Received: by mail-wr1-f50.google.com with SMTP id k15so1542371wrn.10 for <41145@debbugs.gnu.org>; Fri, 28 Aug 2020 07:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=5Tfe/dNQNMoZcRo7XCZ004U6L2JlnEBhXNlDvJdZxB8=; b=pCrL4Cvx7QvS+GbRMpnnwdeFwWRZKiDw8IzGGw9vgaIsZZJvcQqMZVmx/Wvh9uWEPU 7lWithVjb552YyrJDt7CRA4oe+wOVC8Sf0MMLECas/bWWpVwycPFUFyUVHS/AgDV6rh5 RRyBK+T72oe+9FCmKMbeN7NT0/zPIy9JwGNMHeBesLe/IsUxTw1UbArDT8d9VBP49eoH fASYi1H41Ft0sxx3kLMd1Lf0WDOzH7jEIXr/bdBtkkwwvnUVdH7RVV3tEv8zeh1LE9Zc KNkC/KFHnxfUa/ZgQOr6DUnXPEyez7hU6fI23I13Yg7ijaQtfGIWeUVwLMWD6Ts59/Cn T4gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=5Tfe/dNQNMoZcRo7XCZ004U6L2JlnEBhXNlDvJdZxB8=; b=G2B4RSmpcXGBvHihrQXe9ONf9/QV613oEqVOtOVdWRiURvqS+1hCpr3mYZYy+bgRGG 45nAwf9gRqSrMJ6C4W3bZCQFAzOJYy/YbGfDIZnfn1vW4O3kqIPI6O45cMyPywMH7+8N FzzSfYNUOhFQ0BbBgwIGFbcIYsdmeCxXvsP4BomwTy6Q4YcWqCZoM0JNt6NRlbi/VudY 3S+abV7q2CBqEYWECFwR1tqZWTraikEvKD1Wd+YYIbHtmr/sZdVEPdI2QOIFI8Vyg7Gq aOGx7xJnwWblcXL5rr7u1W5YIeOzwHrEh2AzsSkwuB2K6oyq55IDSDtdkf/LSmgB3H/E NcIQ== X-Gm-Message-State: AOAM530uKpWKn1/s21xSvgXIM2L/eO/BLDkgaGglcnvoD90nGx1ya7wR q0iDnlUqlAIcFWZPUz+OTgwL8m+wU5WtvlkddtI= X-Google-Smtp-Source: ABdhPJzqeeFwUKlnHG9d3d/P2ikjesTF3NOSvoWu4KSiUlU8YPPi2OFmxqwfrZcoeDYPbM3hdyf8O8s+dqtDLRDRRtM= X-Received: by 2002:adf:edca:: with SMTP id v10mr2001306wro.124.1598626149909; Fri, 28 Aug 2020 07:49:09 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 28 Aug 2020 11:48:57 -0300 Message-ID: Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000cb499305adf12745" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000cb499305adf12745 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Philipp Stephani >> Date: Sat, 09 May 2020 10:30:13 +0200 >> >> The two issues here are: >> >> 1. "Group definition missing." It looks like customizing this group >> should load `display-fill-column-indicator-mode', which defines this >> group, or the group definition should be in cus-start.el. > The same seems to work for display-line-numbers, and I don't think I > see the crucial difference. I did some debugging and found that the difference is that there are no custom options or faces defined in display-fill-column-indicator.el: fill-column-indicator is in faces.el and display-fill-column-indicator, display-fill-column-indicator-character and display-fill-column-indicator-column are in xdisp.c custom-make-dependencies doesn't go through faces.el, since it's preloaded, so it doesn't record the custom-where property into fill-column-indicator. And since cus-dep.el doesn't require cus-start, fill-column-indicator is the only member of the custom-group property of display-fill-column-indicator, so there is no way custom-make-dependencies will record the custom-where property into any of the options defined in xdisp.c. So later on, when looking for a custom-where property in the members of the display-fill-column-indicator group, we find nothing, resulting in no custom-loads thingy for display-fill-column-indicator. The problem goes away if we require cus-start in cus-dep, or if we record into the custom-loads the file where to find the custom-group. That is, add in the first mapatoms call something like this: (when (get symbol 'custom-where) (push (get symbol 'custom-where) found)) Or if eventually a defface or a defcustom makes its way into display-fill-column-indicator.el, of course. Note that adding the above form will result in adding cus-edit to the custom-loads property of the groups defined in cus-edit (like editing, convenience, etc.). I don't know if that is harmless. --000000000000cb499305adf12745 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Philipp Stephani <p.stephani2@gmail.com>
>> Dat= e: Sat, 09 May 2020 10:30:13 +0200
>>
>> The two issues = here are:
>>
>> 1. "Group definition missing."= =C2=A0It looks like customizing this group
>> =C2=A0 =C2=A0should= load `display-fill-column-indicator-mode', which defines this
>&= gt; =C2=A0 =C2=A0group, or the group definition should be in cus-start.el.<= br>> The same seems to work for display-line-numbers, and I don't th= ink I
> see the crucial difference.

I did some debugging and f= ound that the difference is that there are no
custom options or faces de= fined in display-fill-column-indicator.el:
fill-column-indicator is in f= aces.el and
display-fill-column-indicator, display-fill-column-indicator= -character
and display-fill-column-indicator-column are in xdisp.c
custom-make-dependencies doesn't go through faces.el, since it's<= br>preloaded, so it doesn't record the custom-where property into
fi= ll-column-indicator.
And since cus-dep.el doesn't require cus-start,= fill-column-indicator is
the only member of the custom-group property o= f
display-fill-column-indicator, so there is no way
custom-make-depen= dencies will record the custom-where property into any
of the options de= fined in xdisp.c.

So later on, when looking for a custom-where prope= rty in the members of
the display-fill-column-indicator group, we find n= othing, resulting in
no custom-loads thingy for display-fill-column-indi= cator.

The problem goes away if we require cus-start in cus-dep, or = if we
record into the custom-loads the file where to find the custom-gro= up.
That is, add in the first mapatoms call something like this:
(whe= n (get symbol 'custom-where)
=C2=A0 (push (get symbol 'custom-wh= ere) found))

Or if eventually a defface or a defcustom makes its way= into
display-fill-column-indicator.el, of course.

Note that addi= ng the above form will result in adding cus-edit to the
custom-loads pro= perty of the groups defined in cus-edit (like editing,
convenience, etc.= ).=C2=A0 I don't know if that is harmless.
--000000000000cb499305adf12745-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 02:54:29 2020 Received: (at 41145) by debbugs.gnu.org; 29 Aug 2020 06:54:29 +0000 Received: from localhost ([127.0.0.1]:47860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBukv-0008PL-55 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 02:54:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBukt-0008P3-3o for 41145@debbugs.gnu.org; Sat, 29 Aug 2020 02:54:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49864) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBukn-0001Tg-P1; Sat, 29 Aug 2020 02:54:21 -0400 Received: from [176.228.60.248] (port=1952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBukm-0007kW-KS; Sat, 29 Aug 2020 02:54:20 -0400 Date: Sat, 29 Aug 2020 09:54:13 +0300 Message-Id: <837dtiymay.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda , Stefan Monnier In-Reply-To: (message from Mauro Aranda on Fri, 28 Aug 2020 11:48:57 -0300) Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Fri, 28 Aug 2020 11:48:57 -0300 > Cc: Philipp Stephani , 41145@debbugs.gnu.org > > Eli Zaretskii writes: > > >> From: Philipp Stephani > >> Date: Sat, 09 May 2020 10:30:13 +0200 > >> > >> The two issues here are: > >> > >> 1. "Group definition missing." It looks like customizing this group > >> should load `display-fill-column-indicator-mode', which defines this > >> group, or the group definition should be in cus-start.el. > > The same seems to work for display-line-numbers, and I don't think I > > see the crucial difference. > > I did some debugging and found that the difference is that there are no > custom options or faces defined in display-fill-column-indicator.el: > fill-column-indicator is in faces.el and > display-fill-column-indicator, display-fill-column-indicator-character > and display-fill-column-indicator-column are in xdisp.c > > custom-make-dependencies doesn't go through faces.el, since it's > preloaded, so it doesn't record the custom-where property into > fill-column-indicator. > And since cus-dep.el doesn't require cus-start, fill-column-indicator is > the only member of the custom-group property of > display-fill-column-indicator, so there is no way > custom-make-dependencies will record the custom-where property into any > of the options defined in xdisp.c. > > So later on, when looking for a custom-where property in the members of > the display-fill-column-indicator group, we find nothing, resulting in > no custom-loads thingy for display-fill-column-indicator. > > The problem goes away if we require cus-start in cus-dep, or if we > record into the custom-loads the file where to find the custom-group. > That is, add in the first mapatoms call something like this: > (when (get symbol 'custom-where) > (push (get symbol 'custom-where) found)) > > Or if eventually a defface or a defcustom makes its way into > display-fill-column-indicator.el, of course. > > Note that adding the above form will result in adding cus-edit to the > custom-loads property of the groups defined in cus-edit (like editing, > convenience, etc.). I don't know if that is harmless. Stefan, any suggestions regarding which solution route is preferable? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 11:36:24 2020 Received: (at 41145) by debbugs.gnu.org; 29 Aug 2020 15:36:24 +0000 Received: from localhost ([127.0.0.1]:48883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2tz-0002hp-Q4 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 11:36:24 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC2tw-0002hb-TD for 41145@debbugs.gnu.org; Sat, 29 Aug 2020 11:36:22 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8E81F10023C; Sat, 29 Aug 2020 11:36:15 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E148A10022C; Sat, 29 Aug 2020 11:36:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598715373; bh=deXq5EIiIReQB49y0ATtrDB5uV1Sc+pAYWZhUCjIVnw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mUdgyJ/PNyuCcv/AGJVOJsy3+oWUwW3AKaMfK3nilWUgs7G9tJ0pxYhMX9Lr4+Y2Q vYB95JI8mV7YuP1Zl9qedmG8wAJKXD8JT6hmwVQb5IJD/m4QNa+/Vvn+DLdbYOier2 kBjiV8Ms+lfcOpiQn73uwkvlF94WmAkP1Yvibqy93q3JtWtSdCl6VltuLRqC7i103N 91oi3R9r0YJgOKco/Qe9uocoWUoPdCiLN06cvxzmACbX5AKWsvP0N7d5xVIym5Qy+K gkAaBMJSzEAJsK1JbuYn3AL6OSLdmCxXWxiWhuyIsfqLCquyiRV6sh1o4Qh2eOeaQo Z867J17NxaH1Q== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A969E1207B5; Sat, 29 Aug 2020 11:36:13 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> Date: Sat, 29 Aug 2020 11:36:12 -0400 In-Reply-To: <837dtiymay.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Aug 2020 09:54:13 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I did some debugging and found that the difference is that there are no >> custom options or faces defined in display-fill-column-indicator.el: >> fill-column-indicator is in faces.el and >> display-fill-column-indicator, display-fill-column-indicator-character >> and display-fill-column-indicator-column are in xdisp.c Which begs the question: why define the group there? >> Or if eventually a defface or a defcustom makes its way into >> display-fill-column-indicator.el, of course. Actually, there is a defcustom there (in the expansion of `define-globalized-minor-mode`). >> Note that adding the above form will result in adding cus-edit to the >> custom-loads property of the groups defined in cus-edit (like editing, >> convenience, etc.). I don't know if that is harmless. > > Stefan, any suggestions regarding which solution route is preferable? I'd get rid of the file and move its content to one of the preloaded files (simple.el? faces.el? fill.el? ...) Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 12:23:29 2020 Received: (at 41145) by debbugs.gnu.org; 29 Aug 2020 16:23:29 +0000 Received: from localhost ([127.0.0.1]:48952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3dZ-0003qE-62 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 12:23:29 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC3dX-0003q2-D1 for 41145@debbugs.gnu.org; Sat, 29 Aug 2020 12:23:27 -0400 Received: by mail-wm1-f67.google.com with SMTP id e17so1676448wme.0 for <41145@debbugs.gnu.org>; Sat, 29 Aug 2020 09:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jZ49qkyfFuqDRJXju9L0TCfEcOzNLXkRUqj4K9LUFQ4=; b=sniqBFTb9QFGo6g3/mOwZijSqi8lcw2PfOz1ohhYuHrreAcNWUbw4IFVzLYBlvzSGA NVKSjAXnstyY7dZEgax1y2DlxCW0Qc8wgImOXyAYlEf33EW+NgxOZnLXML9ackNmB4Yy Pi81V/io7SaF2aPVzovkwZSfPctxXET7RVGsaLyC215mXtU0L6z3Eayjg0r+Delo9vO1 PwlVXLiQ+Sbc7mo54zzdv69E7lIeQnk9/mwSjGPzkan3FUXHLKdTawRe+OhG1/COY9o+ SCqLq1t4ZluUlt5In+dXsgKe2TQzyKsxT6cLnkjeIr2hiQ/Rd308M5dn/MDrCoaI5vwn jd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jZ49qkyfFuqDRJXju9L0TCfEcOzNLXkRUqj4K9LUFQ4=; b=jVZ74fGGsonrubiO8rDcZ1CG1NzAyOU3VmtU0JZ2N6QdkqLJpqIrdPvYtcn+NWy8Dz 5xSy4hRdkN2iQX+jloKjh0ZKNSjqG1EwdbWCAf+9RWfHev1JjsodYNvQJbs/sb5OpLte caNKXlcYiBQQ0CwTwbIDRcYjm4YXSWQr/2KRVIdaRzlriH5KRI5Ne/J9Xtcc+Sg08SyT hjeJmQLH7A49/pb3Gd9hv84fM/hEXRrcFI6x1tVElnMaltn0aIHkpkAt9K0PRh793DVx r+6oh6qJ9+qMBW/Gg47PdirDKAjSQK9hKu7S0EeDY4ZAGgX35/sTyL6gdDHuY5I+G1HH BvkQ== X-Gm-Message-State: AOAM531qa/SMxAQxju2RknTa8EK2ztahfOXuizAQQ8bSyZUvyi0L7kio Lgvvo8mWolvrlBv+ui6pRQ+1e2lb0CbKsvD1QQg= X-Google-Smtp-Source: ABdhPJy4gA8TPPm4qrGGni0tMpUCo/T9iNadRuGNwz1D2AaPRKDVFJ9vnJDXylfhrouNkfbtXSCuq5rWRzpG5mR2I/I= X-Received: by 2002:a7b:c925:: with SMTP id h5mr3678638wml.28.1598718201627; Sat, 29 Aug 2020 09:23:21 -0700 (PDT) MIME-Version: 1.0 References: <837dtiymay.fsf@gnu.org> In-Reply-To: From: Mauro Aranda Date: Sat, 29 Aug 2020 13:23:09 -0300 Message-ID: Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group To: Stefan Monnier Content-Type: multipart/alternative; boundary="000000000000810a2c05ae069698" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000810a2c05ae069698 Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >>> Or if eventually a defface or a defcustom makes its way into >>> display-fill-column-indicator.el, of course. > > Actually, there is a defcustom there (in the expansion of > `define-globalized-minor-mode`). Sorry, I wasn't clear enough. There is no defcustom or defface whose :group is display-fill-column-indicator. --000000000000810a2c05ae069698 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Monnier <monnier@iro.umontreal.ca> writes:

>&= gt;> Or if eventually a defface or a defcustom makes its way into
>= ;>> display-fill-column-indicator.el, of course.
>
> Actu= ally, there is a defcustom there (in the expansion of
> `define-globa= lized-minor-mode`).

Sorry, I wasn't clear enough.=C2=A0 There is= no defcustom or defface whose
:group is display-fill-column-indicator.<= /div>
--000000000000810a2c05ae069698-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 23:58:14 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 03:58:14 +0000 Received: from localhost ([127.0.0.1]:49358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCETu-0007em-Bw for submit@debbugs.gnu.org; Sat, 29 Aug 2020 23:58:14 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCETt-0007eb-C7 for 41145@debbugs.gnu.org; Sat, 29 Aug 2020 23:58:13 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DBE8E44094B; Sat, 29 Aug 2020 23:58:07 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3EAF8440942; Sat, 29 Aug 2020 23:58:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598759886; bh=6gpIP/S210GFxLblkumlHnf8jFetNGkPwbkX5kE/RQo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FtxBTASdrYZyYZIyyYMMejrZtNVl6y2Hy0VL9g/BZX+i1JuwWSaM0C14FTCoMGQQ2 RKSTHAAsxxMPxAd0ptMoREt6Pv8Ps0WsYvSpLCxb9x5dUGOWEELAsKULiksemcZdyQ +GoX6fulsv5fC2ImQlCoivAmVI7o9sALHqskqzpVkb1ywwYlouoCs4hR7JRbetbuNO /Vnk3aQeDy3DjP0wZeIESL/NJXpyVWDo/vNnaqNdSALksY0yHH+zCXbCLGmuDrXwHQ TNITBRoAVZfB8aPqy/mtOXgE92rFm0mjPNKLsoQMxD6nQWBUIsqYtqDmZ+y05wFPVg OK0QvHGF+lWBw== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF9871202CE; Sat, 29 Aug 2020 23:58:05 -0400 (EDT) From: Stefan Monnier To: Mauro Aranda Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> Date: Sat, 29 Aug 2020 23:58:04 -0400 In-Reply-To: (Mauro Aranda's message of "Sat, 29 Aug 2020 13:23:09 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>> Or if eventually a defface or a defcustom makes its way into >>>> display-fill-column-indicator.el, of course. >> >> Actually, there is a defcustom there (in the expansion of >> `define-globalized-minor-mode`). > > Sorry, I wasn't clear enough. There is no defcustom or defface whose > :group is display-fill-column-indicator. `global-display-fill-column-indicator-mode` should definitely belong to the `display-fill-column-indicator` group (because the `defcustom` doesn't have an explicit `:group` so it should fallback to using the last-defined group). BTW, another quick-fix might be to move the defface definition to display-fill-column-indicator.el. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 07:53:04 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 11:53:04 +0000 Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCLtQ-0004Te-Ht for submit@debbugs.gnu.org; Sun, 30 Aug 2020 07:53:04 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:37402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCLtL-0004T5-Li for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 07:53:03 -0400 Received: by mail-wm1-f48.google.com with SMTP id x9so2901668wmi.2 for <41145@debbugs.gnu.org>; Sun, 30 Aug 2020 04:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W20iFA2i+MTUSUMCGZzeIt/uZnfJrSzRjiNK7AUWm2A=; b=AmFxIejYNbOgDyXmdkWKsgmCy3kTgMZw1YtIZ0GlNEE16mCa3fmnoOsCTas6B85xPD Sk0C/faBnJwtyXmGRc6Wz9l2oNuDy1/XZsoKg3YcMyOYnasvPrJ0RbGfgiDeLte9fx71 vzLAzL3oBCvdVzPYDRGBslXwzg1BOoQ2h3XiCRqdllOT77K88lWww4a5CPr5+MPpgSuh hgrBMhkD803VMubxNbCBveC+6E9cMaDo9xlVFzLpd9pY7flK1jQ7qsfbrqk9FMS+80Zd BUe/fbF30V0Kk2E+KjQYK/gGlJvBk8sbGTH0ug4XoAx5AY0gVvxPynKIn2vR3tD6UIAI NS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W20iFA2i+MTUSUMCGZzeIt/uZnfJrSzRjiNK7AUWm2A=; b=d5VEmVTwi2guzb9l7/VMwb8lckXnslE1UISoxM3Pd9jo98DE5H24PmVgOviJyVlxeG NH5MX7P5+1k7aFIRJ7bwal90HpRdnY2+wRSa/3nLAv0Xej4HmuR6uJeUU3a7a/ECo7to Z0jUDn6COOQ/QSc+N1k9rhcdehnI5O1FrnMi62rzeyiITWBpPFqd0rtiZQoY5cSB2P2Y gdySmchPSj8mPwTDK6dTsFiBryQ6H9QI+UgYIeWbIGWBYmYhjaUFckN9mOZHsStXLZRT Xfk9GFSr+swVYOgl89Tl0VV/U9S4H5xk9PDLD5me57NO5zQx5twCWFH+hWJlQic6/Ov7 STyg== X-Gm-Message-State: AOAM533TUHykpjfvB+kKu+M/Faqj1iU4hEKmVa5uzjub9CspMbou9O+f mYNOwkSQVkbthA0oUv9F31zFCQ1BuV+Sc/a9qds= X-Google-Smtp-Source: ABdhPJxiHn2Pl6ZuQAvboJl0shcDwPHtq9yvN4TP1d2tKg2XO61rFyZ+JCTkmrgznX1oDlax3SXAsYJIsSOzGdNBXJA= X-Received: by 2002:a1c:2b04:: with SMTP id r4mr6427365wmr.76.1598788373728; Sun, 30 Aug 2020 04:52:53 -0700 (PDT) MIME-Version: 1.0 References: <837dtiymay.fsf@gnu.org> In-Reply-To: From: Mauro Aranda Date: Sun, 30 Aug 2020 08:52:41 -0300 Message-ID: Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group To: Stefan Monnier Content-Type: multipart/alternative; boundary="00000000000016502005ae16edfa" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000016502005ae16edfa Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >>>>> Or if eventually a defface or a defcustom makes its way into >>>>> display-fill-column-indicator.el, of course. >>> >>> Actually, there is a defcustom there (in the expansion of >>> `define-globalized-minor-mode`). >> >> Sorry, I wasn't clear enough. There is no defcustom or defface whose >> :group is display-fill-column-indicator. > > `global-display-fill-column-indicator-mode` should definitely belong to > the `display-fill-column-indicator` group (because the `defcustom` > doesn't have an explicit `:group` so it should fallback to using the > last-defined group). Is it, though? emacs -Q M-x customize-option RET global-display-fill-column-indicator-mode And near the end of buffer I read: Groups: Global Display Fill Column Indicator Furthermore, the list (global-display-fill-column-indicator-mode custom-variable) is not a member of the custom-group property of display-fill-column-indicator. > BTW, another quick-fix might be to move the defface definition to > display-fill-column-indicator.el. Right. --00000000000016502005ae16edfa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>>> O= r if eventually a defface or a defcustom makes its way into
>>>= >> display-fill-column-indicator.el, of course.
>>>
&g= t;>> Actually, there is a defcustom there (in the expansion of
>= ;>> `define-globalized-minor-mode`).
>>
>> Sorry, I= wasn't clear enough.=C2=A0 There is no defcustom or defface whose
&= gt;> :group is display-fill-column-indicator.
>
> `global-di= splay-fill-column-indicator-mode` should definitely belong to
> the `= display-fill-column-indicator` group (because the `defcustom`
> doesn= 't have an explicit `:group` so it should fallback to using the
>= last-defined group).

Is it, though?
emacs -Q
M-x customize-op= tion RET global-display-fill-column-indicator-mode
And near the end of b= uffer I read:
Groups: Global Display Fill Column Indicator

Furthe= rmore, the list
(global-display-fill-column-indicator-mode custom-variab= le) is not a
member of the custom-group property of display-fill-column-= indicator.

> BTW, another quick-fix might be to move the defface = definition to
> display-fill-column-indicator.el.

Right.
--00000000000016502005ae16edfa-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:50:17 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 13:50:17 +0000 Received: from localhost ([127.0.0.1]:49668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNir-0000yj-8i for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:50:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNip-0000yV-LB for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 09:50:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNik-0003Mb-AJ; Sun, 30 Aug 2020 09:50:10 -0400 Received: from [176.228.60.248] (port=4489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCNij-0003MG-I8; Sun, 30 Aug 2020 09:50:10 -0400 Date: Sun, 30 Aug 2020 16:50:04 +0300 Message-Id: <83ft84xmyb.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 29 Aug 2020 23:58:04 -0400) Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , Philipp Stephani , > 41145@debbugs.gnu.org > Date: Sat, 29 Aug 2020 23:58:04 -0400 > > >>>> Or if eventually a defface or a defcustom makes its way into > >>>> display-fill-column-indicator.el, of course. > >> > >> Actually, there is a defcustom there (in the expansion of > >> `define-globalized-minor-mode`). > > > > Sorry, I wasn't clear enough. There is no defcustom or defface whose > > :group is display-fill-column-indicator. > > `global-display-fill-column-indicator-mode` should definitely belong to > the `display-fill-column-indicator` group (because the `defcustom` > doesn't have an explicit `:group` so it should fallback to using the > last-defined group). So you are saying this should have worked as it is? > BTW, another quick-fix might be to move the defface definition to > display-fill-column-indicator.el. The idea was not to require display-fill-column-indicator.el be loaded to activate the feature. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 10:51:37 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 14:51:37 +0000 Received: from localhost ([127.0.0.1]:50509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOg9-0004sf-Cq for submit@debbugs.gnu.org; Sun, 30 Aug 2020 10:51:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOg7-0004sQ-CX for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 10:51:31 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8A9448095B; Sun, 30 Aug 2020 10:51:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2B24D8066B; Sun, 30 Aug 2020 10:51:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598799084; bh=Gz0uhNY4PXzzzkDkwhJZEstRCbnvh4jdFvPFreB0Kmw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=akDxLQ0MDmEGsCWNba0+j6xyZuW4snzZcRSjKgSnLr1aEtpj2+784pBpC+5MHQXJQ iF7I25zn6096RCSMdqezVarOChitH+86pyZfgrhDbA6W8aaD9Tfug14gDIoloXBXHh goxdf4aKEhF93723djD9hzFWwOPhpbOkNL5CBq5lROmxOiTT0taEBQYrIuMeLWNLKN zZ3tx7wGU3QShtqraC8AU5bD/81ozA8TbyMA1zJsKqEMrDfDWc1fBe6OJ9xbkocYlu gkxBAR379M8ob3i/4Zvb4oi8UDUgf5fXjBVHdooDTGHIFacX3jF0SM6WIEnUJ4ToIX e9B27F+swEm/w== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E190B12062C; Sun, 30 Aug 2020 10:51:23 -0400 (EDT) From: Stefan Monnier To: Mauro Aranda Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> Date: Sun, 30 Aug 2020 10:51:23 -0400 In-Reply-To: (Mauro Aranda's message of "Sun, 30 Aug 2020 08:52:41 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Eli Zaretskii , Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> `global-display-fill-column-indicator-mode` should definitely belong to >> the `display-fill-column-indicator` group (because the `defcustom` >> doesn't have an explicit `:group` so it should fallback to using the >> last-defined group). > > Is it, though? > emacs -Q > M-x customize-option RET global-display-fill-column-indicator-mode > And near the end of buffer I read: > Groups: Global Display Fill Column Indicator Oh, indeed, it's an old misfeature that was introduced by our idiot-in-chief (tho to my defense, I think it made some sense back then because `defcustom` did not have a useful default for `:group`). We can fix it either by adding `:group 'display-fill-column-indicator` to the `define-globalized-minor-mode` or by getting rid of the misfeature, as in the patch below (this patch will likely fix a few other similar cases). Eli? Stefan diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el index 24c9e79f2c..e3eb9294ed 100644 --- a/lisp/emacs-lisp/easy-mmode.el +++ b/lisp/emacs-lisp/easy-mmode.el @@ -157,9 +157,6 @@ define-minor-mode the minor mode is global): :group GROUP Custom group name to use in all generated `defcustom' forms. - Defaults to MODE without the possible trailing \"-mode\". - Don't use this default group name unless you have written a - `defgroup' to define that group properly. :global GLOBAL If non-nil specifies that the minor mode is not meant to be buffer-local, so don't make the variable MODE buffer-local. By default, the mode is buffer-local. @@ -262,12 +259,6 @@ define-minor-mode (unless initialize (setq initialize '(:initialize 'custom-initialize-default))) - (unless group - ;; We might as well provide a best-guess default group. - (setq group - `(:group ',(intern (replace-regexp-in-string - "-mode\\'" "" mode-name))))) - ;; TODO? Mark booleans as safe if booleanp? Eg abbrev-mode. (unless type (setq type '(:type 'boolean))) From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 11:09:28 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 15:09:28 +0000 Received: from localhost ([127.0.0.1]:50534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOxU-0005KL-2w for submit@debbugs.gnu.org; Sun, 30 Aug 2020 11:09:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOxS-0005K9-9K for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 11:09:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40656) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCOxM-0003e1-GI; Sun, 30 Aug 2020 11:09:20 -0400 Received: from [176.228.60.248] (port=1380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCOxL-0001hU-SJ; Sun, 30 Aug 2020 11:09:20 -0400 Date: Sun, 30 Aug 2020 18:09:15 +0300 Message-Id: <838sdwxjac.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 30 Aug 2020 10:51:23 -0400) Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , Philipp Stephani , > 41145@debbugs.gnu.org > Date: Sun, 30 Aug 2020 10:51:23 -0400 > > > emacs -Q > > M-x customize-option RET global-display-fill-column-indicator-mode > > And near the end of buffer I read: > > Groups: Global Display Fill Column Indicator > > Oh, indeed, it's an old misfeature that was introduced by our > idiot-in-chief (tho to my defense, I think it made some sense back then > because `defcustom` did not have a useful default for `:group`). > > We can fix it either by adding `:group 'display-fill-column-indicator` > to the `define-globalized-minor-mode` or by getting rid of the > misfeature, as in the patch below (this patch will likely fix a few > other similar cases). > > Eli? How about doing the former on emacs-27, and the latter on master? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 11:11:34 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 15:11:35 +0000 Received: from localhost ([127.0.0.1]:50542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOzW-0005Nq-Nb for submit@debbugs.gnu.org; Sun, 30 Aug 2020 11:11:34 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:52386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCOzV-0005Nd-CZ for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 11:11:33 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07UFAmud080390; Sun, 30 Aug 2020 15:11:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jUnjMMMyZ8CFMUmaloIrLWlm6ZzQ3a0AARI/sPlbo3c=; b=NCdLIC45Ti+Jtzu/v7Q7mw5wjnLQ8E7FJ5rN9GHXklrtDJB8F+Ov/OCy7AZAAwfrcuZl g96yKqtQiBKFqnpSNJczY+Cs6oemqn7tGFFINt5ZjauOppEzi/ImdfrOsIwdXOI4UYA5 t5KdJUQBP2+WPEGYcephZQUujKh5NYlizad7+Kg+4I8xMry+Wd3WiTRSx5P1jyrJAh5p gTbswXW7j5JeqX1E9lzRGAq5eTMt7elDoIhcVO555yGpoyiyrKEYVWPb1oq3mU7n5DEi YxdgGAwjXMTCejCkfkxeB4VVDAi19TiMjDyD0HwFI70aHY7jFACLMHy8vhf02Y8XsoDv /w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 337eeqk2qs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 30 Aug 2020 15:11:27 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07UF4qjC008643; Sun, 30 Aug 2020 15:09:27 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 3380sp1esh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 30 Aug 2020 15:09:27 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07UF9M0n014492; Sun, 30 Aug 2020 15:09:26 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 30 Aug 2020 08:09:21 -0700 (PDT) From: Drew Adams To: Stefan Monnier , Mauro Aranda Subject: RE: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9728 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008300122 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9729 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008300123 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) FWIW, I've said it before, and reiterate now: I think :group should always be explicitly present. We've gone to the other extreme, of not only encouraging its removal (apart from an initial occurrence), but even removing it from patches that contained it. Why do I feel this way? Repeating what I've said before: 1. Nothing is really gained. The amount of additional text eliminated is trivial - tiny. 2. A defcustom that's not near a previous one has its :group unclear (for humans). 3. It's problematic and error prone wrt moving defcustoms around. It doesn't hurt, and it can help human readers to just include explicit :group. Whether that should just be conventional (i.e., recommended/encouraged) or actually enforced is a different question. I'm not sure it needs to be enforced (e.g. warning or error msg), but I don't think that would hurt, and it might help. Just one opinion. I repeat it here only because I haven't mentioned it in a long time - probably not since the crusade to remove "unnecessary" :groups was initiated. (And no, this is not very important. Just sayin.) From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 13:04:04 2020 Received: (at 41145) by debbugs.gnu.org; 30 Aug 2020 17:04:04 +0000 Received: from localhost ([127.0.0.1]:50674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCQkO-00081K-Db for submit@debbugs.gnu.org; Sun, 30 Aug 2020 13:04:04 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCQkM-00080q-F3 for 41145@debbugs.gnu.org; Sun, 30 Aug 2020 13:04:02 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1E66C4407B0; Sun, 30 Aug 2020 13:03:57 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9B3F44400EA; Sun, 30 Aug 2020 13:03:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1598807035; bh=TnqozoHtdFgT/bYhuhHnAwWaEFenGyYPEfZwV+89sCw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pYdH4v57jNR4H2uzVl0Mk6hqjMFsocNSxoSerDVFUk6UMlfjoM9eX+AAWYsH3K4IU ZCXbzov+cm5DG4JFEvvqVXyi1lJYWifJQ0xxVgBzZIHLmf3P88ymLA8FgOlQc205Np qi0atnNn3A389EGJwSbMdICxB0Ch/mGM/7icNcHrThg2pqiZPq2JPAn2N8PlH8c6n5 G8NUjoHidXZMUFCIX7mMt4XGnmYvbSU/zUKoU6h/SAOMh3JGuOxTSa1oyagfW+qm9G LrYqePlDrdaJrPjxOsfceRSjsJ/vFnp25ViuHqf8Vt42UI3qEEjpwFE3EdgdpQhg84 yj4056KulQmew== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 43946120623; Sun, 30 Aug 2020 13:03:55 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> <838sdwxjac.fsf@gnu.org> Date: Sun, 30 Aug 2020 13:03:54 -0400 In-Reply-To: <838sdwxjac.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Aug 2020 18:09:15 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > emacs -Q >> > M-x customize-option RET global-display-fill-column-indicator-mode >> > And near the end of buffer I read: >> > Groups: Global Display Fill Column Indicator >> >> Oh, indeed, it's an old misfeature that was introduced by our >> idiot-in-chief (tho to my defense, I think it made some sense back then >> because `defcustom` did not have a useful default for `:group`). >> >> We can fix it either by adding `:group 'display-fill-column-indicator` >> to the `define-globalized-minor-mode` or by getting rid of the >> misfeature, as in the patch below (this patch will likely fix a few >> other similar cases). >> >> Eli? > > How about doing the former on emacs-27, and the latter on master? Oh, indeed, I did not intend to change define-minor-mode on the emacs-27 branch. So, we have a deal! Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 03 22:24:25 2020 Received: (at 41145) by debbugs.gnu.org; 4 Sep 2020 02:24:25 +0000 Received: from localhost ([127.0.0.1]:36688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1Oq-00043U-UW for submit@debbugs.gnu.org; Thu, 03 Sep 2020 22:24:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE1Op-00043G-1a for 41145@debbugs.gnu.org; Thu, 03 Sep 2020 22:24:23 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9B49E100240; Thu, 3 Sep 2020 22:24:17 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BAAC1100216; Thu, 3 Sep 2020 22:24:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599186255; bh=u+p1kituR8cOFMTN3ilxT0ayFOuh41YYDT0VG4eC3zQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h0zxkPcBd7ajrrO/qSk5tuC5GOCXB/VZYoj1hPugXWc3PUcMTwLv+5GU6gdtXuXel 0zI2TO6XlM08dWsy39f0/kY2fHfXGIXWxGKCrrB6aue7b6BoKGmyPYyK2jD4NcwjFv kWp7yd01TelJ86YWSEcR/IKDhzN3jvdALI4r3jOsVpSh1bvHYtFe+Ija1RZu41iLz8 nfb9JxDIQJUhYrXZ806hbszPIUn0dOdPE/ZhXgFQaLIsdEU6/x4AcuWuHt64inumkV p2antDIcTQJywht9/4XQ4gzOx6pRnhErafbt+VpB7K2nsYRv6bZLZ+SBedzA9ptXyr eEmdlphfbvT/g== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F72812038D; Thu, 3 Sep 2020 22:24:15 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> <838sdwxjac.fsf@gnu.org> Date: Thu, 03 Sep 2020 22:24:14 -0400 In-Reply-To: (Stefan Monnier's message of "Sun, 30 Aug 2020 13:03:54 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> How about doing the former on emacs-27, and the latter on master? > Oh, indeed, I did not intend to change define-minor-mode on the > emacs-27 branch. > So, we have a deal! O, so I looked into fixing it on `emacs-27` and it's not quite as straightforward as I thought. Here's the patch that I have currently, because without that `cus-dep.el` patch, the `define-globalized-minor-mode` is just completely ignored by cus-dep anyway. I think it's quite safe, but I'd like to make sure you agree this is acceptable for `emacs-27`. Stefan diff --git a/lisp/cus-dep.el b/lisp/cus-dep.el index fd307a5c04..e2fd7febd2 100644 --- a/lisp/cus-dep.el +++ b/lisp/cus-dep.el @@ -99,7 +99,7 @@ custom-make-dependencies (setq name (intern name))) (condition-case nil (while (re-search-forward - "^(def\\(custom\\|face\\|group\\)" nil t) + "^(def\\(custom\\|face\\|group\\|ine\\(?:-globalized\\)?-minor-mode\\)" nil t) (beginning-of-line) (let ((type (match-string 1)) (expr (read (current-buffer)))) diff --git a/lisp/display-fill-column-indicator.el b/lisp/display-fill-column-indicator.el index 3f947bdc1c..3391aa371b 100644 --- a/lisp/display-fill-column-indicator.el +++ b/lisp/display-fill-column-indicator.el @@ -73,7 +73,9 @@ display-fill-column-indicator--turn-on ;;;###autoload (define-globalized-minor-mode global-display-fill-column-indicator-mode - display-fill-column-indicator-mode display-fill-column-indicator--turn-on) + display-fill-column-indicator-mode display-fill-column-indicator--turn-on + ;; See bug#41145 + :group 'display-fill-column-indicator) (provide 'display-fill-column-indicator) From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 03:10:00 2020 Received: (at 41145) by debbugs.gnu.org; 4 Sep 2020 07:10:00 +0000 Received: from localhost ([127.0.0.1]:37110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5rE-0005l4-AM for submit@debbugs.gnu.org; Fri, 04 Sep 2020 03:10:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5rC-0005kp-TQ for 41145@debbugs.gnu.org; Fri, 04 Sep 2020 03:09:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53991) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE5r6-00031m-Ro; Fri, 04 Sep 2020 03:09:52 -0400 Received: from [176.228.60.248] (port=3252 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE5r5-00041b-O4; Fri, 04 Sep 2020 03:09:52 -0400 Date: Fri, 04 Sep 2020 10:09:40 +0300 Message-Id: <83363yuiff.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 03 Sep 2020 22:24:14 -0400) Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> <838sdwxjac.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com > Date: Thu, 03 Sep 2020 22:24:14 -0400 > > >> How about doing the former on emacs-27, and the latter on master? > > Oh, indeed, I did not intend to change define-minor-mode on the > > emacs-27 branch. > > So, we have a deal! > > O, so I looked into fixing it on `emacs-27` and it's not quite as > straightforward as I thought. Here's the patch that I have currently, > because without that `cus-dep.el` patch, the > `define-globalized-minor-mode` is just completely ignored by > cus-dep anyway. > > I think it's quite safe, but I'd like to make sure you agree this is > acceptable for `emacs-27`. Yes, LGTM. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 04 08:47:49 2020 Received: (at 41145-done) by debbugs.gnu.org; 4 Sep 2020 12:47:49 +0000 Received: from localhost ([127.0.0.1]:37906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEB88-00005y-VU for submit@debbugs.gnu.org; Fri, 04 Sep 2020 08:47:49 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEB88-00005l-3Z for 41145-done@debbugs.gnu.org; Fri, 04 Sep 2020 08:47:48 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 904CC440B36; Fri, 4 Sep 2020 08:47:42 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 22E1744006B; Fri, 4 Sep 2020 08:47:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599223654; bh=YMEeR2MF0QXJHojznaLoG41TIMKxo7WqvTfWA469ya4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jKdxVo7IJQ81SZR6/e/7AexJP9a9gJBosw4Cvs19LPLQNncKrH7gRlZJ+i85sH+NU fWhlLaNgpOwZPpNMOTE3+NvNi+0tyQTw/AI2ryW/0QWYTd6wR03uPMEoptMI0OVxtR MRe8mHGpUVXkfkdlIaczKbVRI1GaW3jtputJpQsQ51xZv4j4t7OeU18GnqqXVrJ7Gu Y0EQ2UxUwc49GkBZrJTNaGKV2TI5+6qKmJ8GQPljMjg2AlPPFISLQFC14+342FiznM YorWfKAGjUGq2WCaA6s8+UQmvFgIhFaVAMQS4pJEsHnLefZgd5YwtjQbxfsLggqNdf a97XHvXtsQK1Q== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B1DFE1202E7; Fri, 4 Sep 2020 08:47:33 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> <838sdwxjac.fsf@gnu.org> <83363yuiff.fsf@gnu.org> Date: Fri, 04 Sep 2020 08:47:31 -0400 In-Reply-To: <83363yuiff.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Sep 2020 10:09:40 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145-done Cc: 41145-done@debbugs.gnu.org, p.stephani2@gmail.com, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I think it's quite safe, but I'd like to make sure you agree this is >> acceptable for `emacs-27`. > Yes, LGTM. Thanks. OK, pushed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 11 19:27:01 2020 Received: (at 41145) by debbugs.gnu.org; 11 Sep 2020 23:27:01 +0000 Received: from localhost ([127.0.0.1]:45792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGsRZ-0004WU-F1 for submit@debbugs.gnu.org; Fri, 11 Sep 2020 19:27:01 -0400 Received: from mout.web.de ([212.227.17.12]:45679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGsRU-0004W6-OH for 41145@debbugs.gnu.org; Fri, 11 Sep 2020 19:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1599866806; bh=cK7mmEi1Io0Bir3c+GbyQdA70I52wE53Hz6fA9JJ59E=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Awu1j5szHCDr/djPLBg7064gupfl+4tPoIo4VdyZaNfXjvyF7C+8eimGQjoiCRQU+ b6cUmIDUMQJN4lqsrofe+vryq0v9Mtx2iDCHDDq4t8785D2YexM5S0DBeM0ugOyy/u LK5PaHLgCGkcNYLl0qkSJFTNYwEX4sPeWh6S4r7k= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.220.78]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LnjFb-1kjM663A2J-00htTg; Sat, 12 Sep 2020 01:26:45 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> Date: Sat, 12 Sep 2020 01:26:44 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 30 Aug 2020 10:51:23 -0400") Message-ID: <87k0wzgaiz.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kay9x4wQIfmRTALswOd2qQOr18EqcfOaFFwQkwHrNq+dwXycYhJ a3uHWavxz+ZkOtYk5D3EC8JLFq19jvBXwuZoTs+eD6D5089oMYngqznPyI370tpDbF8cRs8 qoOToTQeKbA0Bt6o+33npozczIyXEI+lup+z0miq8BHnRUwW849ejrkcay9VpxMp4z/sQvh KMn1pUOi6UwxvOO+B/mbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:qrhqKPdKsx8=:SRXB8LuXHR/4Zh92dJ+4B7 X173n1jVp1P/J/Em0tf48IO3H1KdPYVFtIss86h2JZsLoTqEposWPJezLEHz6rjlD3tKVPl/S vm2K2QQ1aKU6oHIDrTgjJQExMrAMTjCFJ4uQU4X0d7OtSDVB1SjpRqkku7zVKfzslg+GztWU3 nmgIBbj7c7l1Q5xClxwa+Giv53Az5toA/LCjOPUeGRZBzyo0Ad8Zfb/K1r3cXE9vGf9NNtmWw 8V3pek/7MZ6yQRriT3RUjNaJt/xfgJAzfpJWs4XOlyMA9y8oEebnVLpg/we0d6eGIOViZHfSe MGsRNdSILizZgSi5Vbok8FgpS1AZYx6x211YRYLZL5ul/uCk+VJAU6S9HXE12qn7/YA1U7X9/ GrSA+8b9sZdK2CZh7HyEeFlSAynAju+sV1uEsC+P0i8RAaMwBb2ambzlD05nAf9vw+uHHacdS XTfsFMHXxlEWfnwmC+0RdSoBJi7TtppxXzTlOIXkIKqFcUbNbEIJ9a28/USEclYL1/OvcaWlM gVnXBgpd4ZtBxQhS5BQCMStvwMzUgzBESpiCJ3ngm2PZrZMjauxE4E73biq35uIJ+dY0uFiaF YHRlF7o//HlEQAVuPswpzhufXclhTYq/rJKha+eNJLDLobpZUKT7BTwbAXxtCA4++ermmaQoo BaK77LwUXkwCK4yWTfWFIg/3h724Lc24Rkrv0rgNLLPd8tvpfpsiKmuFBzO/ydA3vnoO2hpYR O9ZiMCiGnSpJogGGTEHv/LdAYLb+rK4rLbTnXQW7ap6XseRBsCRNT/ZQu+T2SyFRdTPqZe1LP EiNynFbnXOR3TXGhNB2JqbSGgrKD+uZMwlM2yRgKY7urxJl1PIhkzzaCx7L+R3VNoqFpqMEeL BGjpdgkIdojXxYKqAwQh/1cBtrFZ9VWGmpkd0x+f+RewMSF5uXHRNHNRUyYNcyU1co+W3AMwM 8rPIQgSqDB4ifIJN2hDozCBI07l/EgJt0V361X7ZAPlAWrROJRqP4DJRE3jANSdzthKSiiaet D0AZscj9kaXE03f0lwU3zQAP2gqZ5BDqfbNXmRq/JOHbgnU/EcfWpM2oQshn9JCxikiwoK0/r zvokzh43GuaZeFm/1YBrc/TADZfEFMFcL25obUuQsvuV+pwgQFNLx3XBmdmtyqf1H7O7QWl92 kvA+Sw9u2EfvKMjLhAgPJ0GNiPkahEYb+RiZxutaODQX90dPH7ebLdXeD/TH/kR/mbhDl8hXL at9NBo7hlZ2CaYkNOJRW8ePhsqaPpF4STiVkQIw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii , Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > - (unless group > - ;; We might as well provide a best-guess default group. > - (setq group > - `(:group ',(intern (replace-regexp-in-string > - "-mode\\'" "" mode-name))))) > - After this change I have to specify a group for every define-minor-mode in my init file, otherwise I'm flooded with warnings. It's a bit annoying. I don't care about groups there since I don't use customize myself at all. What's the suggestion to handle this use case? Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 11:44:07 2020 Received: (at 41145) by debbugs.gnu.org; 12 Sep 2020 15:44:08 +0000 Received: from localhost ([127.0.0.1]:48846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7h9-0005yZ-Jt for submit@debbugs.gnu.org; Sat, 12 Sep 2020 11:44:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH7h7-0005xw-6x for 41145@debbugs.gnu.org; Sat, 12 Sep 2020 11:44:06 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D6CD280C98; Sat, 12 Sep 2020 11:43:59 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2264080662; Sat, 12 Sep 2020 11:43:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599925438; bh=ulasyI7CB4iWHjTtiKhMOjEUxuRHcKsKQBFCish06SY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pRViLgWuWfy6beJ7jlnjQj6hJuQkCV04XWUJQL8rjVaxhi0VqtbVZyekxKakVLHsf fsGcmE5WJyReJR3RO3p7mMvQ7DIp8VF4Dm9xMjtHEgo3Wn3wgiaS7xfofa1VQ47+90 6xa5A9duZ8qHKpjpzx0DrnWIorCKA9YwnG3x2XTc1QN2Otlk76ixp+B72PphcpoEVs b7v1ZFK45OG9d9BFS1Q21H/yknAtpKQae8jJYjjG7Bdal6c6ANXRiKaNB3D9SHGT+V xkCst1lNdOzyASMcG95bh0aWHGJNnsvBAg3kO0GBak5be+ii7HCKZrku3rJuXrxwgM ocYKMSBKHaQqg== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9DB9812076C; Sat, 12 Sep 2020 11:43:57 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Message-ID: References: <837dtiymay.fsf@gnu.org> <87k0wzgaiz.fsf@web.de> Date: Sat, 12 Sep 2020 11:43:56 -0400 In-Reply-To: <87k0wzgaiz.fsf@web.de> (Michael Heerdegen's message of "Sat, 12 Sep 2020 01:26:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii , Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - (unless group >> - ;; We might as well provide a best-guess default group. >> - (setq group >> - `(:group ',(intern (replace-regexp-in-string >> - "-mode\\'" "" mode-name))))) > > After this change I have to specify a group for every define-minor-mode > in my init file, otherwise I'm flooded with warnings. Hmm... so you have `define-minor-mode`s in your init file? That sounds rather unusual [ And "flooded" suggests you have very many. ] > It's a bit annoying. I don't care about groups there since I don't > use customize myself at all. What's the suggestion to handle this > use case? Add a dummy `defgroup` at the beginning of the file? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 12 14:51:34 2020 Received: (at 41145) by debbugs.gnu.org; 12 Sep 2020 18:51:34 +0000 Received: from localhost ([127.0.0.1]:49030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHAcY-0002FJ-7m for submit@debbugs.gnu.org; Sat, 12 Sep 2020 14:51:34 -0400 Received: from mout.web.de ([212.227.17.11]:37573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHAcV-0002Em-BC for 41145@debbugs.gnu.org; Sat, 12 Sep 2020 14:51:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1599936680; bh=m6f/rdqiu6e34HePHGLHbaVO9bz777n4l00AENUT1M4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GhzLNOJ+U8AJh8C89+onG2E3IskFEVRF4lUB4HtPN3YEUf/Bqf1NRlw+9xh/JncVr 3drgGfcQ6jCv8iv1EGaiwtfTrJaAau5mc0YAGieIwKtjjYYhkOZAk6yqoXf1nyJPy2 Hg845aKfJY2Ol7wkhbbJ9Gg+BzdAPAvo83/QbYDE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.220.78]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LaTaN-1kwJS30qit-00mL1c; Sat, 12 Sep 2020 20:51:20 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group References: <837dtiymay.fsf@gnu.org> <87k0wzgaiz.fsf@web.de> Date: Sat, 12 Sep 2020 20:51:18 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 12 Sep 2020 11:43:56 -0400") Message-ID: <87o8maltg9.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:QZdWEumvpzMnyeGFvzWSRdc+kYul+9a9UtFF9qvv3rH9XhcvpS+ rJjTUeOeql/SzQ9V67cuHBWOKuAxVhdgeHZ5GAzgBDwfkx9x/MMiXLFmWNn6sY+ZX6eR9Ti BoHYv3ogJWVlWTPgrWoPxsbAmVIzS7aMBw0gVxNuYPu4JtAcbnhgtkSEkdH8aDRf3vSj0oD G7xQunMqWt5bVor9JBokw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EnfTw9Q2H+Q=:3MbhWMKoRm7NT/KhOXdRD+ 3gv5+ExskuoU0yIeVwuzxL1svJSqzY+A8z6ksE8HvqoRBasSGTrU9BKVdft/APtcjzToUgtB1 gQGprkehGBH6drdJS1/Z6j8bPm4ru8BAZg2oRzxxp65+ARXxUlpHSYXkFXeHIUZyfSolm/+Qs kxoboRuGji6nDeAJRNxH+Kq+rChxXPn3hZTobzPdpKCrb/o1yJmNtao36fN6tZ3+bWAho10h4 hRO6b2ukhUn3s9aXYJaOs3AlLMAYn6VuzhU/kHbRW/bl7C/ov/AaPrTjAU7KbfbaT3yEg9RrR 5PKl5h0xwa/IztQspfKnpb5Idg3NaNh6CuPODa2dO8X8tZoT7Q18KUu3bkGlEDK1j5tr2z6UL /2cKdNnp1BSrWU/McRlmAzLvucytiXw/CHVWIIJPtR0IxcC8Qci76SZ6yja0MDeQy2Q1t2/0+ zqbFrvWPk5lVrFnjysi981egCIa7N0xRMF9uJAx9mpW8p5MIstTQEGjuWRTJzydKcZq3PZ14U FP5avWkEPDSE9ArCHpZWV4we28yeYjZJzceUNFCwi0vFDpC8A/goDiGEFDKeSrN4KGXg4DbyA FwI5PXXms0fs+6kSWEYw14k2j/XBJacvEyoA8zOEuwwcbrBSnhGzB1fXsrXLcPhVGyMcVipgL IQMsPnDLx9hQtdIlL54CcsREmQABs+zwR6U21rkB7xJg8x2mk7Kj89QWSE4bJOocXW7PPikwn oDOyxe/UcHYu/UD8Czxey20ObB327sKT/XNIm5k5AkD/MmjGk/K1nQGTWoVP4scnWiHA5vHvm 1U8wX0/cZFYen/C40I7GI9BYs0SSJJEtvdcW9RbqQs3l1GpaE09VtOUXmSeD9YxH1rA5dZ3bD NoBfswCo0JI9E1U1HYtmltsWsAj4bUaNLXtlsk80nCIKu6TxYD1WRiWlmnLdB5dOPl/AjpfK2 J1ir2UK4Z+UxbbVkDty9jMslWPzmdaa6pIDQuxmHPJicgtu1HQV/7r5kiQ+RxuXphCjJeXztb hfFeKcQoELfXK0NlfhMCwAMK/A8S1Ts7scbZXZOca8JPysJX0J75HxL6x11CUL0GQDHTlbOhp 3eWjN+ynsvIpg5FfwTEm/xPVuJBjUJ27d1cFuETKa+gtfl8P39hwexJWFsLu0z33zNMzhw1/u MiCtt/bbbFimu15AlgoXjxHDoXN3W+9tTNFjL9Pzhe1kLs/QmpIBoHYU6d1dX+IHeSAaGqkcS dKftcqZD2SKHdes4GQ6PPXIJv+4dBcfIZdnLlYg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41145 Cc: 41145@debbugs.gnu.org, Philipp Stephani , Eli Zaretskii , Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > Hmm... so you have `define-minor-mode`s in your init file? That > sounds rather unusual [ And "flooded" suggests you have very many. ] Yes, 20. Part of my private config, for my own usage. I'm a bit surprised that you think that's unusual. > Add a dummy `defgroup` at the beginning of the file? Ok, will give it a try. Thanks, Michael. From unknown Tue Jun 17 20:12:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 11 Oct 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator