GNU bug report logs - #41142
[PATCH] GUILE_PKG bails out when 'pkg-config' is missing

Previous Next

Package: guile;

Reported by: Mathieu Lirzin <mthl <at> gnu.org>

Date: Fri, 8 May 2020 23:04:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41142 in the body.
You can then email your comments to 41142 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#41142; Package guile. (Fri, 08 May 2020 23:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mathieu Lirzin <mthl <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Fri, 08 May 2020 23:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: bug-guile <at> gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>
Subject: [PATCH] GUILE_PKG bails out when 'pkg-config' is missing
Date: Sat,  9 May 2020 01:02:01 +0200

* meta/guile.m4 (GUILE_PKG): Ensure that 'pkg-config' is available. Use
AC_REQUIRE for PKG_PROG_PKG_CONFIG to avoid unnecessary invocations.
---
 meta/guile.m4 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/guile.m4 b/meta/guile.m4
index bc0daaf46..508f8b9d4 100644
--- a/meta/guile.m4
+++ b/meta/guile.m4
@@ -60,7 +60,10 @@
 # @code{AC_SUBST}.
 #
 AC_DEFUN([GUILE_PKG],
- [PKG_PROG_PKG_CONFIG
+ [AC_REQUIRE([PKG_PROG_PKG_CONFIG])
+  if test "x$PKG_CONFIG" = x; then
+    AC_MSG_ERROR(["Missing pkg-config"])
+  fi
   _guile_versions_to_search="m4_default([$1], [3.0 2.2 2.0])"
   if test -n "$GUILE_EFFECTIVE_VERSION"; then
     _guile_tmp=""
-- 
2.20.1
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Wed, 27 May 2020 20:23:02 GMT) Full text and rfc822 format available.
Notification sent to Mathieu Lirzin <mthl <at> gnu.org>:
bug acknowledged by developer. (Wed, 27 May 2020 20:23:02 GMT) Full text and rfc822 format available.

Message #10 received at 41142-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Lirzin <mthl <at> gnu.org>
Cc: 41142-done <at> debbugs.gnu.org
Subject: Re: bug#41142: [PATCH] GUILE_PKG bails out when 'pkg-config' is
 missing
Date: Wed, 27 May 2020 22:22:30 +0200

Hi Mathieu,

Mathieu Lirzin <mthl <at> gnu.org> skribis:

> * meta/guile.m4 (GUILE_PKG): Ensure that 'pkg-config' is available. Use
> AC_REQUIRE for PKG_PROG_PKG_CONFIG to avoid unnecessary invocations.

Applied, thanks!

Ludo’.
Information forwarded to bug-guile <at> gnu.org:
bug#41142; Package guile. (Wed, 27 May 2020 21:43:01 GMT) Full text and rfc822 format available.

Message #13 received at 41142 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41142 <at> debbugs.gnu.org
Subject: Re: bug#41142: [PATCH] GUILE_PKG bails out when 'pkg-config' is
 missing
Date: Wed, 27 May 2020 23:42:35 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Mathieu Lirzin <mthl <at> gnu.org> skribis:
>
>> * meta/guile.m4 (GUILE_PKG): Ensure that 'pkg-config' is available. Use
>> AC_REQUIRE for PKG_PROG_PKG_CONFIG to avoid unnecessary invocations.
>

Thanks Ludovic.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 25 Jun 2020 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 358 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.