GNU bug report logs - #41131
[PATCH] hash-table-merge! ignores other-ht

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41131: closed ([PATCH] hash-table-merge! ignores other-ht)
Date: Fri, 12 Mar 2021 21:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 12 Mar 2021 22:32:38 +0100
with message-id <87o8foxdl5.fsf <at> pobox.com>
and subject line Re: bug#41131: Bug in hash-table-merge! (and patch)
has caused the debbugs.gnu.org bug report #41131,
regarding [PATCH] hash-table-merge! ignores other-ht
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41131: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41131
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Ricardo G. Herdt" <r.herdt <at> posteo.de>
To: bug-guile <at> gnu.org
Subject: Bug in hash-table-merge! (and patch)
Date: Fri, 08 May 2020 01:50:01 +0200

[Message part 3 (text/plain, inline)]

Hi,

I just found this bug in the hash-table-merge! function 
(modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was 
ignoring one of them (other-ht). Attached is the fix, where it now folds 
over other-ht and store its data in ht.

Cheers,

Ricardo G. Herdt

[0001-Fix-hash-table-merge-bug.patch (text/x-diff, attachment)]

[Changelog (text/plain, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: "Ricardo G. Herdt" <r.herdt <at> posteo.de>
Cc: 41131-done <at> debbugs.gnu.org
Subject: Re: bug#41131: Bug in hash-table-merge! (and patch)
Date: Fri, 12 Mar 2021 22:32:38 +0100

Applied, thanks!

On Fri 08 May 2020 01:50, "Ricardo G. Herdt" <r.herdt <at> posteo.de> writes:

> Hi,
>
> I just found this bug in the hash-table-merge! function
> (modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was 
> ignoring one of them (other-ht). Attached is the fix, where it now folds
> over other-ht and store its data in ht.
>
> Cheers,
>
> Ricardo G. Herdt
>
> From 180a9e14b807295aa31966a52bfd732647458ef9 Mon Sep 17 00:00:00 2001
> From: "Ricardo G. Herdt" <r.herdt <at> posteo.de>
> Date: Fri, 8 May 2020 01:37:24 +0200
> Subject: [PATCH] Fix hash-table-merge! bug.
>
> * module/srfi/srfi-69.scm : fold over second hash table.
> ---
>  module/srfi/srfi-69.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/srfi/srfi-69.scm b/module/srfi/srfi-69.scm
> index b9486c465..91bcc77db 100644
> --- a/module/srfi/srfi-69.scm
> +++ b/module/srfi/srfi-69.scm
> @@ -330,7 +330,7 @@ Answer the final F result."
>    "Add all key/value pairs from OTHER-HT to HT, overriding HT's
>  mappings where present.  Return HT."
>    (hash-table-fold
> -   ht (lambda (k v ign) (hash-table-set! ht k v)) #f)
> +   other-ht (lambda (k v ign) (hash-table-set! ht k v)) #f)
>    ht)
>  
>  ;;; srfi-69.scm ends here

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.