From debbugs-submit-bounces@debbugs.gnu.org Thu May 07 20:19:35 2020 Received: (at submit) by debbugs.gnu.org; 8 May 2020 00:19:35 +0000 Received: from localhost ([127.0.0.1]:44165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWqjm-0004Ui-VP for submit@debbugs.gnu.org; Thu, 07 May 2020 20:19:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:38766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWqHI-0003j1-77 for submit@debbugs.gnu.org; Thu, 07 May 2020 19:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWqHH-0003Kq-Ux for bug-guile@gnu.org; Thu, 07 May 2020 19:50:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWqHG-0002yy-MJ for bug-guile@gnu.org; Thu, 07 May 2020 19:50:07 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 093C416005C for ; Fri, 8 May 2020 01:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1588895402; bh=m6YwxVT+yhH4/+0OI2gqsQPdD9B7ByWUM0gV2z4OeWI=; h=Date:From:To:Subject:From; b=ECjmaT3c3W4x0oeex8rla3oVT1LOmyRJG2yuAU5M+8AGp+wDgfBGDQyV5obZIeNd/ ultA1iDLnnP2ocrZpGvHXuHcHVoR9+GKN/4F/zsqsd0HM1jjDaGsC65ewMKboL759e dxLuhdo5gg4tu0GU/cHkrporY36d7X7Pa05A+2bPXX9KnS5sn6oN08X9kAGZRH/6GE 9HppCCO0B6JHX2pUIUP156FCw3Jp/7gYPZy5GASPHX2C7AZ2MLE7CAk6VpJqMAoe+A b1B2IPc/9buPCz0A8LniR6fSphjdUxjpn6KGdhkNKy7J6v16wopgoumNZi1OgJnO/4 dVvEqi/9ZIUsw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49J9Dn2WmKz9rxX for ; Fri, 8 May 2020 01:50:01 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_5212ecabfe80dbc72e77809617dd3d50" Date: Fri, 08 May 2020 01:50:01 +0200 From: "Ricardo G. Herdt" To: bug-guile@gnu.org Subject: Bug in hash-table-merge! (and patch) Message-ID: X-Sender: r.herdt@posteo.de User-Agent: Posteo Webmail Received-SPF: pass client-ip=185.67.36.65; envelope-from=r.herdt@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 19:50:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 07 May 2020 20:19:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, I just found this bug in the hash-table-merge! function (modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was ignoring one of them (other-ht). Attached is the fix, where it now folds over other-ht and store its data in ht. Cheers, Ricardo G. Herdt --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-hash-table-merge-bug.patch Content-Disposition: attachment; filename=0001-Fix-hash-table-merge-bug.patch; size=831 RnJvbSAxODBhOWUxNGI4MDcyOTVhYTMxOTY2YTUyYmZkNzMyNjQ3NDU4ZWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUmljYXJkbyBHLiBIZXJkdCIgPHIuaGVyZHRAcG9zdGVvLmRl PgpEYXRlOiBGcmksIDggTWF5IDIwMjAgMDE6Mzc6MjQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggaGFzaC10YWJsZS1tZXJnZSEgYnVnLgoKKiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSA6IGZv bGQgb3ZlciBzZWNvbmQgaGFzaCB0YWJsZS4KLS0tCiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSB8 IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtIGIvbW9kdWxlL3NyZmkvc3JmaS02OS5z Y20KaW5kZXggYjk0ODZjNDY1Li45MWJjYzc3ZGIgMTAwNjQ0Ci0tLSBhL21vZHVsZS9zcmZpL3Ny ZmktNjkuc2NtCisrKyBiL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtCkBAIC0zMzAsNyArMzMwLDcg QEAgQW5zd2VyIHRoZSBmaW5hbCBGIHJlc3VsdC4iCiAgICJBZGQgYWxsIGtleS92YWx1ZSBwYWly cyBmcm9tIE9USEVSLUhUIHRvIEhULCBvdmVycmlkaW5nIEhUJ3MKIG1hcHBpbmdzIHdoZXJlIHBy ZXNlbnQuICBSZXR1cm4gSFQuIgogICAoaGFzaC10YWJsZS1mb2xkCi0gICBodCAobGFtYmRhIChr IHYgaWduKSAoaGFzaC10YWJsZS1zZXQhIGh0IGsgdikpICNmKQorICAgb3RoZXItaHQgKGxhbWJk YSAoayB2IGlnbikgKGhhc2gtdGFibGUtc2V0ISBodCBrIHYpKSAjZikKICAgaHQpCiAKIDs7OyBz cmZpLTY5LnNjbSBlbmRzIGhlcmUKLS0gCjIuMjAuMQoK --=_5212ecabfe80dbc72e77809617dd3d50 Content-Transfer-Encoding: base64 Content-Type: text/plain; name=Changelog Content-Disposition: attachment; filename=Changelog; size=170 MjAyMC0wNS0wOCBSaWNhcmRvIEcuIEhlcmR0IDxyLmhlcmR0QHBvc3Rlby5kZT4KCiogc3JmaS02 OS5zY206IGhhc2gtdGFibGUtbWVyZ2UhIHdhcyBpZ25vcmluZyB0aGUgc2Vjb25kIGhhc2ggdGFi bGUuCkZvbGQgb3ZlciBvdGhlci1odCwgYW5kIHN0b3JlIGl0cyBrZXktdmFsdWVzIGluIGh0Lgo= --=_5212ecabfe80dbc72e77809617dd3d50-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 01 03:40:41 2020 Received: (at control) by debbugs.gnu.org; 1 Jun 2020 07:40:41 +0000 Received: from localhost ([127.0.0.1]:34391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jff3p-0006RD-Kx for submit@debbugs.gnu.org; Mon, 01 Jun 2020 03:40:41 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jff3n-0006Qz-0m for control@debbugs.gnu.org; Mon, 01 Jun 2020 03:40:39 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 6324F2400FC for ; Mon, 1 Jun 2020 09:40:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1590997232; bh=TQL61JKhkoKOJzYEfDPgyTIgZoT8+CPszcnD8/lhXrY=; h=Date:From:To:Subject:From; b=OBCwdbRL3vnpxTxxqNJbUC8XzAp5kQbP5Z6WI925G2nw9guEIqmGvtJXPyrJyazwL Q0aBmi/paX2IewlgkioPYGtd0g0oJN5Y6kkSULwkOzCRd24t9wUcrOkcAAHuSNJbsW EzL3RgAUvBycRrnV9/OUK42oI7fn08tQQVLvOW4vsYsR7LzdlZvIdn77XBwzlKhJOy zi/UQsikAQooGq6rQKgn/+H9YM9/d67jxkYc36cOiIhxgh1wUrSCWIePfab2cOxblg G4zjcwR5Ut+Ule1JClQLGs4d3jxyRypb7sv9PzKNXhRyCt8PjWCD7Ktu+RMzOEZb+X KwXy4JPp/R6ng== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49b6Xb5xl0z9rxL for ; Mon, 1 Jun 2020 09:40:31 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 01 Jun 2020 09:40:31 +0200 From: "Ricardo G. Herdt" To: control@debbugs.gnu.org Subject: Retitle bug report 41131 Message-ID: X-Sender: r.herdt@posteo.de User-Agent: Posteo Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) retitle 41131 [PATCH] hash-table-merge! ignores other-ht From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 01 03:44:52 2020 Received: (at control) by debbugs.gnu.org; 1 Jun 2020 07:44:52 +0000 Received: from localhost ([127.0.0.1]:34408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jff7s-0006Xr-JP for submit@debbugs.gnu.org; Mon, 01 Jun 2020 03:44:52 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jff7r-0006XV-5i for control@debbugs.gnu.org; Mon, 01 Jun 2020 03:44:52 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id CC990160062 for ; Mon, 1 Jun 2020 09:44:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1590997484; bh=3Z79z/zWzM64QgUu256ggc2spQBsEhPGa7a+BavFB3o=; h=Date:From:To:Subject:From; b=IVxgEsw8EPWd4F/YzpdI5J+RR/aTxS1+7MnAr3Od/+1Ha7deUiX02R95zVteBcOaw dVWrKTi2Ls9eNxiVv4xDVEHZRMr5Doo1EPo2/TuKiDKPEX5ZhvQ1dyQWT8kiL65Iq3 +diPWdlJJLNfXmTX+3urlaRtkey071ux6KxsrEplFs3+V8fnCNA/k3MYsQk6pFbynD 44QzLLum6rQCLJfm5vMhAF0MB+SfCZT5Yu1RFv3eF/aonM35FMergI5IUPmR8HnscT pti6F8dTlveSb7bUCKHCE1Gqy/Go92jGjSSuFhiAYxJQSpxtB1LCcK3nj6xQDdGzfG C3Aq0lEqG84sQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49b6dS2nL2z9rxQ for ; Mon, 1 Jun 2020 09:44:44 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 01 Jun 2020 09:44:44 +0200 From: "Ricardo G. Herdt" To: Control Subject: Add patch tag to 41131 Message-ID: X-Sender: r.herdt@posteo.de User-Agent: Posteo Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 41131 patch From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 12 16:33:01 2021 Received: (at 41131-done) by debbugs.gnu.org; 12 Mar 2021 21:33:01 +0000 Received: from localhost ([127.0.0.1]:58566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKpP3-0005JN-Cb for submit@debbugs.gnu.org; Fri, 12 Mar 2021 16:33:01 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:42499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKpOy-0005J2-F9 for 41131-done@debbugs.gnu.org; Fri, 12 Mar 2021 16:32:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=XxnjmRz1crsmkAlDa4euT6jQRXXiqJEL4L65rTt6hMw=; b=jBNXO4/v0arRvzMlIhdKjRjVWnTZMcREk2gCzDyHqkw0g5KThDPUv/1dmKUU+P7uB5fXYi6IlSZTedcGT1aL7sLC4NrK8rLFt9ptsCIqu8EP/kRwYPUNkLUKDX0Q7PfT+iftY0pAX0TaC6CObqaYRxtgDIxQT9sfESBuo5Zxrv5WRvdPIXr5J423YNEGuhUdyIHntG4hf/EPKFZiguVxtBpJFssQgOKznoCqcn+9ZnjeDDqIjO/UnPft4I0tb3G2Uo8j1zUQ5c2GCr1tk5Xs1L2n4nk6YfEpDfGdLz0izrp/zkX4K1ajj3n43tRm0IoHZURiG9N5OFZdE/7iDkY8GQ==; Received: from 82-65-63-215.subs.proxad.net ([82.65.63.215] helo=sparrow) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1lKpOr-0007Aq-3I; Fri, 12 Mar 2021 22:32:49 +0100 From: Andy Wingo To: "Ricardo G. Herdt" Subject: Re: bug#41131: Bug in hash-table-merge! (and patch) References: Date: Fri, 12 Mar 2021 22:32:38 +0100 In-Reply-To: (Ricardo G. Herdt's message of "Fri, 08 May 2020 01:50:01 +0200") Message-ID: <87o8foxdl5.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 41131-done Cc: 41131-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Applied, thanks! On Fri 08 May 2020 01:50, "Ricardo G. Herdt" writes: > Hi, > > I just found this bug in the hash-table-merge! function > (modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was > ignoring one of them (other-ht). Attached is the fix, where it now folds > over other-ht and store its data in ht. > > Cheers, > > Ricardo G. Herdt > > From 180a9e14b807295aa31966a52bfd732647458ef9 Mon Sep 17 00:00:00 2001 > From: "Ricardo G. Herdt" > Date: Fri, 8 May 2020 01:37:24 +0200 > Subject: [PATCH] Fix hash-table-merge! bug. > > * module/srfi/srfi-69.scm : fold over second hash table. > --- > module/srfi/srfi-69.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/module/srfi/srfi-69.scm b/module/srfi/srfi-69.scm > index b9486c465..91bcc77db 100644 > --- a/module/srfi/srfi-69.scm > +++ b/module/srfi/srfi-69.scm > @@ -330,7 +330,7 @@ Answer the final F result." > "Add all key/value pairs from OTHER-HT to HT, overriding HT's > mappings where present. Return HT." > (hash-table-fold > - ht (lambda (k v ign) (hash-table-set! ht k v)) #f) > + other-ht (lambda (k v ign) (hash-table-set! ht k v)) #f) > ht) > > ;;; srfi-69.scm ends here From unknown Tue Jun 17 01:34:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 10 Apr 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator