GNU bug report logs - #41119
[PATCH] fix some issues with (guix nar)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41119: closed ([PATCH] fix some issues with (guix nar))
Date: Mon, 11 May 2020 21:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 11 May 2020 23:39:03 +0200
with message-id <877dxidudk.fsf <at> gnu.org>
and subject line Re: [bug#41119] [PATCH] fix some issues with (guix nar)
has caused the debbugs.gnu.org bug report #41119,
regarding [PATCH] fix some issues with (guix nar)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41119: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41119
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] fix some issues with (guix nar)
Date: Wed, 06 May 2020 22:52:11 -0500

[Message part 3 (text/plain, inline)]

I noticed two issues while looking at (guix nar):

1. The proper store-lock-handling protocol isn't used in
   FINALIZE-STORE-FILE. Lock acquisition needs to check for a deletion
   token, retrying if it exists, and lock release needs to delete the
   lock file and write the deletion token.

2. WITH-TEMPORARY-STORE-FILE opens a new daemon connection every time it
   retries with a new filename, and only closes any of them after the
   body has completed. So if we retry 20 times, we get 20 concurrent
   daemon connections. This also prevents the call to LOOP from being a
   tail call.

The attached patches resolve these issues. There are of course going to
be more places we need to (properly) acquire and release store locks as
guile-daemon code gets merged, but for now this should work as a bandaid
fix.

- reepca

[0001-nar-finalize-store-file-follows-proper-store-lock-pr.patch (text/x-patch, attachment)]

[0002-nar-with-temporary-store-file-uses-a-single-connecti.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Caleb Ristvedt <caleb.ristvedt <at> cune.org>
Cc: 41119-done <at> debbugs.gnu.org
Subject: Re: [bug#41119] [PATCH] fix some issues with (guix nar)
Date: Mon, 11 May 2020 23:39:03 +0200

This was pushed a couple of days ago:

  b338c41c82 nar: 'with-temporary-store-file' uses a single connection
  37edbc91e3 nar: 'finalize-store-file' follows proper store lock protocol.

Closing, and thanks again!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.