GNU bug report logs - #41111
gnu: claws-mail: Fix fhs directories.

Previous Next

To reply to this bug, email your comments to 41111 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: claws-mail: Fix fhs directories.
Date: Wed, 6 May 2020 09:06:38 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-claws-mail-Fix-fhs-directories.patch (application/octet-stream, attachment)]

Message #8 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 41111 <at> debbugs.gnu.org
Subject: claws-mail
Date: Fri, 8 May 2020 19:29:29 +0200

[Message part 1 (text/plain, inline)]

Hi,

I think that this patch does a lot more than "Fix fhs directories".

Could you split it into multiple patches, each with a high-level subject that
allows the reviewer to find out the reason for it?

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] claws-mail
Date: Wed, 02 Sep 2020 16:50:40 +0200

Hi!

Raghav, could you take a look at Danny’s suggestions below?

  https://issues.guix.gnu.org/41111

Ludo’.

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> Hi,
>
> I think that this patch does a lot more than "Fix fhs directories".
>
> Could you split it into multiple patches, each with a high-level subject that
> allows the reviewer to find out the reason for it?

Message #14 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: 41111 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Claws-Mail
Date: Wed, 30 Sep 2020 06:17:59 -0400

[Message part 1 (text/plain, inline)]

Hi Danny!

Based on your feedback, I have split the changes. Please find the 
attached patches.

Regards,
RG.

[0001-gnu-claws-mail-Make-some-cosmetic-changes.patch (text/x-patch, attachment)]

[0002-gnu-claws-mail-Change-build-system.patch (text/x-patch, attachment)]

[0003-gnu-claws-mail-Update-to-3.17.7.patch (text/x-patch, attachment)]

[0004-gnu-claws-mail-Update-license.patch (text/x-patch, attachment)]

[0005-gnu-claws-mail-Update-synopsis-and-description.patch (text/x-patch, attachment)]

Message #17 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Wed, 30 Sep 2020 12:52:04 +0200

[Message part 1 (text/plain, inline)]

Raghav,

Raghav Gururajan 写道：
> Based on your feedback, I have split the changes. Please find 
> the 
> attached patches.

I haven't been following this thread, but have updated claws-mail 
to .7 on master in the meantime.

Your 0003-gnu-claws-mail-Update-to-3.17.7.patch does unrelated 
things and deserves a different commit message.

> [source]<origin>[sha256]: Modify base32.

This isn't needed; <version> and <origin> changes are implicitly 
covered by ‘Update to x.y’ to reduce noise in the common case.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: 41111 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, Tobias
 Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 03:05:30 +0000

[Message part 1 (text/plain, inline)]

@Danny

Please find the revised patches.

@Tobias

I have fixed the commit message.

Regards,
RG.

[0001-gnu-claws-mail-Make-some-cosmetic-changes.patch (application/octet-stream, attachment)]

[0002-gnu-claws-mail-Change-build-system.patch (application/octet-stream, attachment)]

[0003-gnu-claws-mail-Revise-package-arguments.patch (application/octet-stream, attachment)]

[0004-gnu-claws-mail-Revise-package-inputs.patch (application/octet-stream, attachment)]

[0005-gnu-claws-mail-Update-license.patch (application/octet-stream, attachment)]

[0006-gnu-claws-mail-Update-synopsis-and-description.patch (application/octet-stream, attachment)]

Message #25 received at 41111-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: 41111-done <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 11:14:02 +0200

[Message part 1 (text/plain, inline)]

Hi RG,

pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and 7269a591361138ac6fc122d465e45e2b8c4944be.

Thanks!

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 41111-done <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 41111-done <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 16:40:09 +0000

Hi Danny!

> pushed to master as commits b168f2ba53b938e1b322c79e5bfa47fcc506b803 and
> 7269a591361138ac6fc122d465e45e2b8c4944be.

Thanks!

The patch-set had 6 patches, but only 2 were pushed?

Regards,
RG.

Message #33 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 22:07:17 +0200

[Message part 1 (text/plain, inline)]

> The patch-set had 6 patches, but only 2 were pushed?

Whoops, yes.  I only saw and pushed the first two.

Reopened the bug report.

[Message part 2 (application/pgp-signature, inline)]

Message #36 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 20:08:44 +0000

Hi Danny!

> Whoops, yes. I only saw and pushed the first two.
> 
> Reopened the bug report.

Cool!

Regards,
RG.

Message #39 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Fri, 16 Oct 2020 00:42:43 +0200

[Message part 1 (text/plain, inline)]

This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.

That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.

I'm not necessarily opposed--but for example does it really need webkitgtk ?
What does it do with it ?

(There were really bad security problems in Microsoft Outlook because they
were using a more-capable-than-necessary web browser to render HTML mail,
back in the day?)

[Message part 2 (application/pgp-signature, inline)]

Message #42 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 22:48:21 +0000

Hi Danny!

> This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.
> 
> That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.

I know :/

> I'm not necessarily opposed--but for example does it really need webkitgtk ?
> What does it do with it ?

Yeah, it enables a feature called "Fancy" (HTML stuff).

> (There were really bad security problems in Microsoft Outlook because they
> were using a more-capable-than-necessary web browser to render HTML mail,
> back in the day?)

The fancy is disabled my default. So, user should enable it only if required.

Regards,
RG.

Message #45 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Thu, 15 Oct 2020 22:52:13 +0000

Hi Danny!

>> This patchset (mostly patch 4) increases claws-mail's closure size from 563 MiB to 1128 MiB.
>> 
>> That's a definition of "lightweight" (see revised synopsis and description) I was not aware of.
> 
> I know :/
> 
>> I'm not necessarily opposed--but for example does it really need webkitgtk ?
>> What does it do with it ?
> 
> Yeah, it enables a feature called "Fancy" (HTML stuff).
> 
>> (There were really bad security problems in Microsoft Outlook because they
>> were using a more-capable-than-necessary web browser to render HTML mail,
>> back in the day?)
> 
> The fancy is disabled my default. So, user should enable it only if required.

Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it.

Regards,
RG.

Message #48 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Fri, 16 Oct 2020 11:48:28 +0200

[Message part 1 (text/plain, inline)]

Hi RG,

On Thu, 15 Oct 2020 22:52:13 +0000
"Raghav Gururajan" <raghavgururajan <at> disroot.org> wrote:

> Hmm. Would you be able to comment-out the webkitgtk input while pushing? In future, if someone really needs it, then we can include it.

With your patchset I get:

$ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i webkit
$

So it's not using webkitgtk in the first place.

Still huge...

[Message part 2 (application/pgp-signature, inline)]

Message #51 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Fri, 16 Oct 2020 19:54:53 +0000

[Message part 1 (text/plain, inline)]

Hi Danny!

> With your patchset I get:
> 
> $ guix gc --references /gnu/store/1lz5ax9j3wysl83qfzyh2c8212mh2dch-claws-mail-3.17.7 |grep -i
> webkit
> $
> 
> So it's not using webkitgtk in the first place.
> 
> Still huge...

Thanks for catching that. The claws-mail wants WebKit-1.0 (older version of webkitgtk).

So I removed it.

Please find the revised patch attached.

Regards,
RG.

[0001-gnu-claws-mail-Make-some-cosmetic-changes.patch (application/octet-stream, attachment)]

[0002-gnu-claws-mail-Change-build-system.patch (application/octet-stream, attachment)]

[0003-gnu-claws-mail-Revise-package-arguments.patch (application/octet-stream, attachment)]

[0004-gnu-claws-mail-Revise-package-inputs.patch (application/octet-stream, attachment)]

[0005-gnu-claws-mail-Update-license.patch (application/octet-stream, attachment)]

[0006-gnu-claws-mail-Update-synopsis-and-description.patch (application/octet-stream, attachment)]

Message #54 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Sat, 17 Oct 2020 12:08:05 +0200

[Message part 1 (text/plain, inline)]

How come gobject-introspection is in the regular inputs, not in native-inputs?

[Message part 2 (application/pgp-signature, inline)]

Message #57 received at 41111 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 41111 <at> debbugs.gnu.org
Subject: Re: [bug#41111] Claws-Mail
Date: Sat, 17 Oct 2020 11:26:11 +0000

[Message part 1 (text/plain, inline)]

Hi Danny!

> How come gobject-introspection is in the regular inputs, not in native-inputs?

Oops! Performed lint on wrong branch. Fixed now.

Regards,
RG.

[0001-gnu-claws-mail-Make-some-cosmetic-changes.patch (application/octet-stream, attachment)]

[0002-gnu-claws-mail-Change-build-system.patch (application/octet-stream, attachment)]

[0003-gnu-claws-mail-Revise-package-arguments.patch (application/octet-stream, attachment)]

[0004-gnu-claws-mail-Revise-package-inputs.patch (application/octet-stream, attachment)]

[0005-gnu-claws-mail-Update-synopsis-and-description.patch (application/octet-stream, attachment)]

[0006-gnu-claws-mail-Update-license.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.