GNU bug report logs - #41104
28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41104: closed (28.0.50; nadvice: `find-function-library'
 infloops for adviced autoload fun)
Date: Tue, 07 Jun 2022 14:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 07 Jun 2022 10:31:56 -0400
with message-id <jwvczfkk0ja.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun
has caused the debbugs.gnu.org bug report #41104,
regarding 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41104: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41104
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; nadvice: `find-function-library' infloops for adviced
 autoload fun
Date: Wed, 06 May 2020 05:05:07 +0200

Hello,

in *scratch* eval this:

#+begin_src emacs-lisp
(require 'find-func)

;; we don't require 'dired so it is an autoload fun.  Then:

(advice-add 'dired
            :override
            (defun my-dired (&rest args) t))

;; And

(find-function-library 'dired)

;; infloops.
#+end_src

The problem seems be that `find-function-advised-original' unexpectedly
returns the original symbol because `advice--cd*r' returns nil in this
case.

TIA,

Michael.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 41104-done <at> debbugs.gnu.org
Subject: Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops
 for adviced autoload fun
Date: Tue, 07 Jun 2022 10:31:56 -0400

> The problem seems be that `find-function-advised-original' unexpectedly
> returns the original symbol because `advice--cd*r' returns nil in this
> case.

I believe the problem is now fixed in `master`.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.