From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 23:05:16 2020 Received: (at submit) by debbugs.gnu.org; 6 May 2020 03:05:16 +0000 Received: from localhost ([127.0.0.1]:38034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWAN1-0003Z0-1k for submit@debbugs.gnu.org; Tue, 05 May 2020 23:05:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:56122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWAMz-0003Ys-Ja for submit@debbugs.gnu.org; Tue, 05 May 2020 23:05:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWAMz-0002So-E1 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 23:05:13 -0400 Received: from mout.web.de ([212.227.15.4]:38613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWAMy-0006mG-2B for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 23:05:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588734308; bh=Y0fyugzOGI6JXgr3ER7y9MFKMj/Ecvv4PBsXtGwkAak=; h=X-UI-Sender-Class:From:To:Subject:Date; b=ldu6oOJg+rX854S/aSYQHZfJdH51ZsSvg8YN6Lev7QOLTFabfrrc84QuorS15Lr1e RnyOMsNA7GQqh7MeH85cB6AIN1X001Pr7NBq0UQyh4rpFI9HGY/bNOr7m7L4aB85FU KJzsuvMHFM9740u7ePd42SLI4mulemlwZu+g6iAY= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.215.41]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MVcfH-1jddfP29pH-00Yz0u for ; Wed, 06 May 2020 05:05:08 +0200 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun Date: Wed, 06 May 2020 05:05:07 +0200 Message-ID: <874kstzrto.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cM5rgYQuFuj3tjLJFDcyWlkeawlELfAL/osvFFgerx2xZ5r9I3D s7j2Me29nEyeupjuKBM4kR+kyF4lArsnTA6h4f48x+KPiS4FbQwzIWkd5QdYXwVJ9XhxCd+ 8G8nAM9+wcvY9QoBZFQCDkvfeXmKAyFzVMCYp7IQLiAX4BOAys4oEajoO2iWoGcafuQGmLX IwHjRRAnILIpLqyCiQQXg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FyQfdAzqjuQ=:ccxDD7HvGgi4B9gzvnsiAw bN371Ngh19L98hUNHDSolykkXR2lA2RTtKbDi59sxGNe+SGiMp4zMC87cSphg+cXgsIAm1icY S9emhfG9O8tlwno5Urii1nq5+9kCZb9CjsKF2wo/wlnmYTiaQIFOeOsoizuKsS4O4e4742ZJU 1Ol72wvyENUFF3vA7Lq/9UR/ZaUijw0xoAC45/SDJs6KUsMcO8ESpnz98PQ04KxmrEWpKyceO EaAXVA5u54YtdsMnH/drTqjzyqWdeSq/io4hPUTVLWYfXGKwFzk+lRW8/0CehM33zCIH5D0LG ACRj3P8cFMbDXDBpOlG7Q3tFel4KAsAR26AKZTU7rPPcwsdqqlo8rSiH+koxnN6PTf1Zjo8QL uT6bn90t6Y8rOPtTXu4NxfAtPzkRqCykZU7Swst8ZCUVNnR5sAAhRCD7VtMm4dLGAV/VHigQ6 UJeC9TfogUe5RO8BfXa4gtOFXfwEr32QwxfzxHeIbBabjRoynMpnHpZaGcNDpfB+JEu6W+0h1 vNQijRyszdDXb5uomJ9FvKSoeyipArMdEYhZR3vuY5zS/P8ItDvw9399DgqZmM6XctztdEvo9 gsSzaRrKFTN8WnQ1qXYb+XjWDfZy1I2fQqNgtg4Jw3yNPcC+RF0HmAi8IEq0Je8X8UZHQoqiO F62+2oBUZesXbcqjY5/YZvCrgC3sxBgyrhbIAq3XVFF5fGObjJrp+lQzva9Qf9NRUPD1P+WLt Rmb0TlzNvOz1tIGyKhCKEbvtKfGHHLvTI5zBIMBQhCjjVjOgAgBxj+RtC+UpPvbF9r+LRPr/K RERFV5ZFgF+9XFRr4kDguj6KJU9SPS1R8aXGY+tWxhzrqw+70kMcAcu/WmVrZsZT/EmgfXsvE qXcy+GVifuHhQxCfURUFS2d0k5GS7H8w4S/fPaC/ROwigVxBnlDFWx9Jd8l3k/glkohwQZ7jK iYVKS5sFdbIavbQGiiOqKKHRZUkMzt7KgbShdG58OplEMsysl2el7aZBjGu6F4IyIlkd5YffA XugvD/AYPs1ioy3H6mVXA3UEp+ZkSXPiwaHAKkiTuYSNZBXwree4GdyygIEeBHHTzzujybWDV MSHg+UsX6wG5wbLFfEaPpHlkVr9z7I+HAQY/wYvQvRr0jNrLAl3y6CV6CZAdJOyC3aQzKHhij fNi8irkX5pZCxSo8Lt2NCA2hIGIAM7DJjwUvDxHGfaT3K+QR4UgUwGWZJ8FXcPM3929D3TbwN 45BK9Us1UKs4oZWfU Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 23:05:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, in *scratch* eval this: #+begin_src emacs-lisp (require 'find-func) ;; we don't require 'dired so it is an autoload fun. Then: (advice-add 'dired :override (defun my-dired (&rest args) t)) ;; And (find-function-library 'dired) ;; infloops. #+end_src The problem seems be that `find-function-advised-original' unexpectedly returns the original symbol because `advice--cd*r' returns nil in this case. TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 09:34:00 2022 Received: (at 41104) by debbugs.gnu.org; 6 Jun 2022 13:34:00 +0000 Received: from localhost ([127.0.0.1]:34749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyCro-0005WR-1D for submit@debbugs.gnu.org; Mon, 06 Jun 2022 09:34:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyCrm-0005W6-3E for 41104@debbugs.gnu.org; Mon, 06 Jun 2022 09:33:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zto4FlLikedDHYde0IeS+e4W/wOLq0H63lJD3/IvC74=; b=hmpvlQ2BVTOnPWRQC5GSFFf2oK +O5omlOJqxzHBQhjGMZnrCJe5nFuq1mFWNkCr5Fvtn+tz/gTvmJz4F3PBl2Gp3ifB8/uSwAZziN5v SX4EHBLyIMeUPxcaYOSNGYmZiLM0gQHopl7WWGzTcLjQBUCd01WBu5fqigmFkTTa6KGE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyCrc-0003CO-LU; Mon, 06 Jun 2022 15:33:51 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun References: <874kstzrto.fsf@web.de> X-Now-Playing: Matmos's _The Consuming Flame: Open Exercises in Group Form (2): On the Team_: "Verminiatures" Date: Mon, 06 Jun 2022 15:33:48 +0200 In-Reply-To: <874kstzrto.fsf@web.de> (Michael Heerdegen's message of "Wed, 06 May 2020 05:05:07 +0200") Message-ID: <87pmjlvrur.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > #+begin_src emacs-lisp > (require 'find-func) > > ;; we don't require 'dired so it is an autoload fun. Then: > > (advice-add 'dired > :override > (defun my-dired (&rest args) t)) > > ;; And > > (fin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41104 Cc: 41104@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: > #+begin_src emacs-lisp > (require 'find-func) > > ;; we don't require 'dired so it is an autoload fun. Then: > > (advice-add 'dired > :override > (defun my-dired (&rest args) t)) > > ;; And > > (find-function-library 'dired) > > ;; infloops. > #+end_src > > The problem seems be that `find-function-advised-original' unexpectedly > returns the original symbol because `advice--cd*r' returns nil in this > case. This issue is still present on the trunk. Perhaps Stefan has some comments; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 10:32:06 2022 Received: (at 41104-done) by debbugs.gnu.org; 7 Jun 2022 14:32:06 +0000 Received: from localhost ([127.0.0.1]:41088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaFa-0007Ps-Bc for submit@debbugs.gnu.org; Tue, 07 Jun 2022 10:32:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaFZ-0007JU-0K for 41104-done@debbugs.gnu.org; Tue, 07 Jun 2022 10:32:05 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 57A288134C; Tue, 7 Jun 2022 10:31:59 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 185BE808D4; Tue, 7 Jun 2022 10:31:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654612318; bh=+e6/OqErtV+5cIRa31HRYJlioAJ07fThwymPe05tmQs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Rw5mV7C5e0NoIRME9pJgUVKUjWcaVOwX+vOO/f1+LWtRybjcLppwPa6Q2rZPnIg+a jsdA6gT1Zl94HCVz5vVDWs1P0Ng3zNp3w8veyhpLy0xEdPSvFhr//Eo8qQ49qa1is2 Neyg2h8D/supoF3PekWF87oUqYwNzGultFJGvRPeU92KSc/5rTOxu4kbwtd3czYoRq Qg6Uw6NeixLvQKK3HSwaoQ14Fr8qPFjEVX8+vO3iic62p+c95Ofixn4I8uhE4rsbHT /g2LPhIqw6IBCqvLBOoFNIev9tta1psXq0hAIe8eunHNAagIYj8tSmRwQmAKcHZ7Zt J/rEWEONHoH6A== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E1D941204BC; Tue, 7 Jun 2022 10:31:57 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun Message-ID: References: <874kstzrto.fsf@web.de> Date: Tue, 07 Jun 2022 10:31:56 -0400 In-Reply-To: <874kstzrto.fsf@web.de> (Michael Heerdegen's message of "Wed, 06 May 2020 05:05:07 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41104-done Cc: 41104-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The problem seems be that `find-function-advised-original' unexpectedly > returns the original symbol because `advice--cd*r' returns nil in this > case. I believe the problem is now fixed in `master`. Stefan From unknown Thu Sep 11 07:36:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 06 Jul 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator