GNU bug report logs - #41099
28.0.50; TRAMP process-file ignores exit status of remote process

Previous Next

Full log

Message #19 received at 41099 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 41099 <at> debbugs.gnu.org
Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of
 remote process
Date: Wed, 6 May 2020 12:38:43 +0200

Am Mi., 6. Mai 2020 um 10:38 Uhr schrieb Michael Albinus
<michael.albinus <at> gmx.de>:
>
> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
> Hi Philipp,
>
> >> It looks like `tramp-send-command-and-check' should not just search
> >> for the exit code, but also return it.
> >
> > No, most use cases a simple nil or t is appropriate. Otherwise, you would
> > need to check always (zerop (tramp-send-command-and-check ...)). But in
> > tramp-sh-handle-process-file, it shall return the exit code (indicated
> > by an optional argument).
> >
> > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file.
>
> I've fixed this in master, could you pls check?

Looks like it's working fine, thanks for the quick fix!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.