From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 14:49:17 2020 Received: (at submit) by debbugs.gnu.org; 5 May 2020 18:49:17 +0000 Received: from localhost ([127.0.0.1]:37444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW2d2-0007wF-QS for submit@debbugs.gnu.org; Tue, 05 May 2020 14:49:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:41980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW2cx-0007w2-Kc for submit@debbugs.gnu.org; Tue, 05 May 2020 14:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW2cx-0001ih-An for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 14:49:11 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:40729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW2cw-0006c8-8A for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 14:49:10 -0400 Received: by mail-wr1-x432.google.com with SMTP id e16so3996486wra.7 for ; Tue, 05 May 2020 11:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ewAh9Pj8zUZlQUhJ4ToIRti3qw06H7YFkMy6VdZiHk=; b=sEWvmEZPBux1JRnn8rwq+SnNrAbxgLb56eMPGiO+GcFPV6QzGUnyNCG4DTyL+KJJO+ nzlVBEiZMS+RY6tn64rTZyZQUgRaw5bo75P7ZD1IujSD6lGwPcWvTaOxDMH8QZk0/lCe CvdLT/li1ghq9od17gTI4tQBLLkgMCIuilJvc8JvLzKzu887Tmta8xOO0avkMha6i0Bk KDthRgcc0PfzFBFhglgK/N8tAt6QwQuM5M7RY798ihRfiEGsgtgONosiDEVCv657359Y OWear6cMkieufi6NRVwJ98M79DQFbgqLMPZyYZ8MarS5H+1j0EefCEjkgOUaAjZyRjHN ou6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ewAh9Pj8zUZlQUhJ4ToIRti3qw06H7YFkMy6VdZiHk=; b=EyVmKC/TE9vVK22MCwi0qVjJfT0sgnIRsycTECvG9Vv6ABXwbTWpkV0QcgnsKuswaA 996cOgSRHFHxnUugrP1bQGNuHvKqpo2qlBBrOaRJAej5YfW8Y5Wqs9av2dBbtgrzsvsI HiDgXmqxMYyV0NyqgDaRVwzq9wBK2QQtDmlFd9ogbkxw0/vFjxLa0gst3nUnQhTalOxN 2CFMoleg35KxdyvFjTkDlr4MyVP7esU7jcaf0gf+cHWk6E2qRuhMrsUHV+KSQ9Wg5Hfp YG4B0L/JUFyBefJuRlQTV0rm/vbT8FgfTvlJnCwuWnKX0NH27gPHzN3C+eHAkUY987pX Xtvg== X-Gm-Message-State: AGi0PuboStMcQbdq8Oo9iDluc+YDmShtUev5ZQe/70Lj9pDlhMiQIgmx pio/Qza+RL3ATtU2x7TNWcmucbcVLJY= X-Google-Smtp-Source: APiQypIwCIS2GwsEO7NIGWw4jZzxDcrvkTcT+ABnD+i+TAbVGObNFHGe5IDbsQgh3u6uhOMULA+d9w== X-Received: by 2002:adf:f091:: with SMTP id n17mr5145660wro.200.1588704548304; Tue, 05 May 2020 11:49:08 -0700 (PDT) Received: from phst1 ([2a02:2455:2a2:100:c351:ffcc:5d8e:4288]) by smtp.gmail.com with ESMTPSA id n21sm5120193wra.15.2020.05.05.11.49.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 11:49:07 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 28.0.50; TRAMP process-file ignores exit status of remote process Date: Tue, 05 May 2020 20:49:07 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x432.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) emacs -Q -batch -eval '(let ((default-directory "/ssh:HOST:/")) (print (pro= cess-file "bash" nil nil nil "-c" "exit 42")))' Tramp: Sending command =E2=80=98exec ssh -o ControlMaster=3Dauto -o Contr= olPath=3D'tramp.%C' -o ControlPersist=3Dno -e none HOST=E2=80=99 Tramp: Found remote shell prompt on =E2=80=98HOST=E2=80=99 1 Note that the return value of `process-file' is 1 instead of 42. The relevant debug output is 20:46:42.302070 tramp-send-command (6) # ( cd / && bash -c exit\ 42 ) id 1jW2qI-0001yN-RN for submit@debbugs.gnu.org; Tue, 05 May 2020 15:02:58 -0400 Received: from mail-oo1-f54.google.com ([209.85.161.54]:46161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW2qH-0001yA-A1 for 41099@debbugs.gnu.org; Tue, 05 May 2020 15:02:57 -0400 Received: by mail-oo1-f54.google.com with SMTP id x16so799327oop.13 for <41099@debbugs.gnu.org>; Tue, 05 May 2020 12:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=5tpbDwH+nsD2895FgeyEkiIej4eqAIQ5hsALwlwmlqw=; b=UFwIbU5mT+4Nt2YUg4Cdd0ZS4glSjbbByndQmcUqA+g+bX+KvJ0S7/2uJmSV2/Ixr0 rUvGquMI2huuBFx9FngsGm9aKIYo3Ryzq18QfpF3OeAELc/1y9whOfHtXobCKh251phZ z6I9a+NT/F2DbzWhED7pw0N/8lOABbs7MdyQCURXt//zRRpLXAzqCok1BNSgSvFFJTlp S8oaG7ZmtIvJBLDhr2ufENAYld8YoXCJ1uMWwpDHWZsOu93L8KUkoNry7p3ufWXllO4c zf/jkRS4y482mpIR2c3Lax8kNfNbjAcMfRT/KV/LDTx/20WnzFbkTSP+ZPlPjL/acUyY UQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=5tpbDwH+nsD2895FgeyEkiIej4eqAIQ5hsALwlwmlqw=; b=o8RyR3FjT/INQ1qsEkc3IlesI8BodiaBjw+HMMOU4v62c6M4twoAeMrxza9Peznvmf 8Plob4y5qCT6affI9n4tb+6xehzpIt+OyHcv6qtgamaNfTN2igP4E28T0uTetS1Kcrkn sIZyJG3FmMtk0uOdLLUZuRpx21J4hdrA02qwWVkNvJnKRHU36SUfj973/Lwz0pWbgxKo apxpfLFufKUsixXQe3MxbVDIcGlVc/D6hXqZvq/W8wpR/836aM7ZVHyb0lEF+IqUXTBv knC4cRBm8wggAcn76Nn0VbiVZk3V7Kn/T8vob+lHSxKWZoAeUag6KrTIEzCiX9WIeK8T kULg== X-Gm-Message-State: AGi0Pua6cOtlkZCzgrB4mOKl+rk68GHiCaYd8ELYZEl2kvhvGnHXSK/W m9TCqJ2T4rK5MgbmdMtTqhAu9MTAn7IH8V9y+dUzSo8mTC8= X-Google-Smtp-Source: APiQypJIjr3IlSqsKe0jh+WwdfjE/i2ep459KV6lQsC+RbbY110vl9EZGrTkT0jkq0P8ZmVM2zqEobTWa/6nB8SvKJ4= X-Received: by 2002:a4a:3b4a:: with SMTP id s71mr4200321oos.81.1588705371228; Tue, 05 May 2020 12:02:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Tue, 5 May 2020 21:02:40 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: 41099@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Di., 5. Mai 2020 um 20:50 Uhr schrieb Philipp Stephani : > > > emacs -Q -batch -eval '(let ((default-directory "/ssh:HOST:/")) (print (p= rocess-file "bash" nil nil nil "-c" "exit 42")))' > Tramp: Sending command =E2=80=98exec ssh -o ControlMaster=3Dauto -o Con= trolPath=3D'tramp.%C' -o ControlPersist=3Dno -e none HOST=E2=80=99 > Tramp: Found remote shell prompt on =E2=80=98HOST=E2=80=99 > > 1 > > Note that the return value of `process-file' is 1 instead of 42. > > The relevant debug output is > > 20:46:42.302070 tramp-send-command (6) # ( cd / && bash -c exit\ 42 20:46:42.331851 tramp-wait-for-regexp (6) # > tramp_exit_status 42 > > i.e. TRAMP should have access to the correct exit status. It looks like `tramp-send-command-and-check' should not just search for the exit code, but also return it. From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 15:26:01 2020 Received: (at 41099) by debbugs.gnu.org; 5 May 2020 19:26:01 +0000 Received: from localhost ([127.0.0.1]:37568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3Cb-0004fd-E7 for submit@debbugs.gnu.org; Tue, 05 May 2020 15:26:01 -0400 Received: from mout.gmx.net ([212.227.17.20]:43367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW3CZ-0004fP-Lg for 41099@debbugs.gnu.org; Tue, 05 May 2020 15:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588706753; bh=kV97ZkVesVVBY1vGeFEjfdFpKFCTCXGOZgbEdaG1yv4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=GjOlhARhq0wmmRlVsr0GS+8/6Clu0WokMmF5pxxxInQCfoVvP8zzgI3V+bdkMCtp5 +RZMhNOVb3LDO4S4dvndYugQCvm3ti7vlJbK97h2UpZ8MydfhLfPoFsrsPG6N0kW0R bNEN0rg+gXZNIQOCRkLh82lmUgRwcLC1iW83K36k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.145.136]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mzyuc-1jBc4k3gww-00x3Ai; Tue, 05 May 2020 21:25:52 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: Date: Tue, 05 May 2020 21:25:51 +0200 In-Reply-To: (Philipp Stephani's message of "Tue, 5 May 2020 21:02:40 +0200") Message-ID: <871rnyyyio.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:aV5o7/I0PgAdoCbM3xzJn23ve3v6ru3GEkZUC6t2ZAxGM6PTPzO OGHRYlWIoto3z4iC7gSsQkDGd1qC0TIi5EB4RxIDtz5lSXD2Rg6dvJDjl1IkmGZh3B7S4JD 299rPhmIQRWKordQp84rezRVHzmJ6Q/LbIFD1Iwsp7IkBj6iH1TAONDBr8oRB0hPukyb81Q kPGVw+Vzsr3FVCsXThT/A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xFXDyiZjMj4=:gcU/5JgGF1oMVIIPhIAHNK dBdjFBPIa4S8eHz9602WbahIy4n3qqQCWTvzZB/ISht65XgN/m5XYBGIaoWcmHnFLkGEh9x+J zSG6frmB7Yg474vlCDqE+SQxYs944baHzuzoNS+l5HY4CzvBOK4bYi8amndeBukWQZ5LWdGv7 5SltGiR2s/6ANCh6Z/3C1bC3JTVouXGoARDnZE+q/KI+M99kuiiZhVAqbqhIylTIfJrsvFN6q +O2WIngXt1dukfKaXC+5flppwI4BnTDKKTHSBobESrZltacYrUJlIKX+520YGU1KGNgOci/lJ OQzQ8dDKD6n/k6DH+z7vg0R9RYDSXiV1EeXwYnCP4OxSDCMqrj1ShIyecQ/wdHMMTH9cYyNO1 GF3Az068wya8ejD6VFS+5WusAXzOiik8Kb6RQapLH5c3cfOXuOR24ul49VNPsX8KZobi+mror xlg7inNr3OMR23FxryFkoXAriHtclMbOnETC+0x7j56B93CS+w9pYdRV3LAfR6U+dLEoJWjKp mGHXM4g954Pf4vqzTDUPN9YtyGK3pWxCIPvTN+F13NefeI2jCh8zhvqFJrinBnIewzrV6N7VC KK/0Ts2CKtBpu5u7S0iy38eCJBlfOdwUwFeNJL9/jzzvpX0nFgg3ciq/BhTa4yFGJ1FkRuJZV fD+5BSArjPO/RsNGrWiZsBsImzzTE1QrDlQKSuTfjQCWhk5MnNEBfinTGGffjArjv4nqVTCrW XqWJzU2f+oyoi5BAI+cavuYg7JE0tFiA+L0y6oyI5zMkyi7xXB8E9ohAUCTq3meP6w2KtxTD/ KtgnrRQH6dqRYyZbzTrRUiSj6A+dsszgncspHXuKZG+u8Nh2EBXl/sjOuSPpyxVOk1TzjfCLZ MTrm9ASRbC/X/WH879cZTC12N9FxyMetWB3TyoC8u/gJJGdLPJht/ZmZ5glXkIIzfXPABdzV/ cusiEA4dfnbvpHgSd3koAjBN+3uXhA6hwcUXXIKOiE7fBtNreqMvYb1MnM+/vx80laiWEpvLH YFQT5fErDX266EzALyZVu45aYEnY+kejBU/4mJvsfR/sYI2pWKxIMkdCJoUwzJw3vqLTqwnew czRaZdEoZVZh3ee4J3GKR8wcuH2X+nunBz/fKYrAtsRifnThGjjlHtmjHkYF4Zvyy0rh1K09V afApMQVFJ/XW/1l6JTljgqigHMVTpxgB7vbhCBcjzZiqGSR692JwIjQlwrxfN1OejHmu0QjpB kySgTh+9kta6uIeOk X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: > It looks like `tramp-send-command-and-check' should not just search > for the exit code, but also return it. No, most use cases a simple nil or t is appropriate. Otherwise, you would need to check always (zerop (tramp-send-command-and-check ...)). But in tramp-sh-handle-process-file, it shall return the exit code (indicated by an optional argument). Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 04:38:50 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 08:38:50 +0000 Received: from localhost ([127.0.0.1]:38463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFZq-0003jW-0b for submit@debbugs.gnu.org; Wed, 06 May 2020 04:38:50 -0400 Received: from mout.gmx.net ([212.227.17.21]:35655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFZn-0003jI-R7 for 41099@debbugs.gnu.org; Wed, 06 May 2020 04:38:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588754321; bh=Swlq+FVyXA4iW2bfqpiT7BvMVU7Jap+wz82MNH6s9WU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=AtlBgPcw8RBxhnTWzFyEdqWIJ3j6HZVOKFDjBzLVEvT6jXakVChOlYlORu04sRTUi zb+WNOG2QdFi0j4cXZ0E9PMfI0zH6AZV1mnqq+MQQtlBmZJBNI3Hf0nXlZ46p010HP M711TtQNm1FxU3e3oYj8axYpZqu6W0iSGlA+bphU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mj8qj-1iu8rl4BZF-00fEMZ; Wed, 06 May 2020 10:38:41 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> Date: Wed, 06 May 2020 10:38:39 +0200 In-Reply-To: <871rnyyyio.fsf@gmx.de> (Michael Albinus's message of "Tue, 05 May 2020 21:25:51 +0200") Message-ID: <87sggdmp9s.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:4r60VoC66pyVICmkD4rJ/pLYz2LYfepI/RiZnmeMpQ5gpIzwI7P NCOP5dloyGSOG9GFrCc8TmBb5lSLslzdR2y6lllREzau6VSHL2vwajiYDddTp4ZORjDnOqc wHqJJc6o83n5NjFJeD1wmz5O9AluUW2uASLGeXFK4QS4ZB0EuZGuT/43/dzo1O7QlvvVMZg XY9nRPSVjJRNvS6ouplLw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TX7ae8kvY9o=:TF4lRoIxK8a8BytmmbwIKt f6qtpeRjw4Cd2OnCG2NRcxq8MqDQymZW9s7P9J+YMp+QojPAcpPsW1/yxif7BkBLvo799kDbH YSl44/OKWeb9+yMykUMhDbgOTuY+oPM2nXEJ0KBY+P+UU3Gfc25ZaCHQt03WlD2N99OXla2Cv YnmBsb70wRA/r+YCVCMKRBkzcdzyL88jC1vbMIK5cNE8jDVbBlhNPO7eLq4AGesd8ZVJIdIya hbOHvlxYS18KqymQ26olLsEw3yf0yK1sfxR10IdHNxMyR26/Arxay0sw7cqaqxT5K+Wh1INI/ 5RlkU9dE/+0QwZYy75RW5xxaFMMLYDrGJdu8kpGst4v2cU3eT1FouBD68HW42IlYoOrlVeXn3 TUDxz/z/TV3cicexxu1TEBYNzbYSjjtpxOs6wFLmap+wEgPbnJZYc9IvuqrwxbIfmlkMxPfOE 935mULwSYwK2SNs0U/WPZKO05zZEA843229AazcAfl1qD6uk7S3u42bl1zlhrF/IKY7tLnnFs qeo30rPrA9UO4AUClG+t8ISA5LEccJ3WQ5nHRSyz58LOrHQ+Sd21wJuX087oAg2fmiOP12xPN 4nK7ytJ80EqbYZvkYvhXgbVXFDQIuzm0/c2izpo/7Ms7hLP5xiJDJKg0cSO8yPbM1nzhLYkrH 2KnUVUZvqKVD0+zrqKke5sDqs6Ofr1h1Dajk3oRVHaGaxb33ZwErzfppzg2VzUJ9225wnbvnD 9qdO8PoXTu/KmPlLW+t+nEjkUCDxhBsr7FTkZYtUn/eDoJhUm2mCbSlJHHoKACb1wKmjUimDZ T5n4Wwj6evz6JokNnwlSAm4PxRwiyHbm9wH+g65QEzUMcTWl5i0xxTEQOCub4qJJFvsOuMrfL 6G/HELoH0DmmGTX7zIWW7zWIQT7zCOXlelrysvdqZSZwqjSKjaLYC7VvyuadymYYf+DPgnrwP 0wm06BbqLBDQ3g8lGmCEZpG1q5tFGSDXd24Ohj3QlWc1/GZg9xJtGyI8Vn3G8xLqYYMXembzg tEzjC6lhXVxIyfK5RPQWdWmc/MibRSGSTaHFjUuxFV8+XVUKqkdrhLU6hGkbZv/p9Q9F9AmMX FiTYBhZz6KYt0EZu5nDDd/KeDReVd3zJvbPg1/eAhF9jGKpR7iKpnc2rYPl6ExpAUmjMzCctQ LemVwgFeEqIe7SNVa3flsNOdpPOuMFUzU4K6yPl1R0NxUhNhWwhMKiguBCBrKS08OhQJj4wRz yEfhl0HnQa+73pOJC X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi Philipp, >> It looks like `tramp-send-command-and-check' should not just search >> for the exit code, but also return it. > > No, most use cases a simple nil or t is appropriate. Otherwise, you would > need to check always (zerop (tramp-send-command-and-check ...)). But in > tramp-sh-handle-process-file, it shall return the exit code (indicated > by an optional argument). > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. I've fixed this in master, could you pls check? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 04:39:24 2020 Received: (at control) by debbugs.gnu.org; 6 May 2020 08:39:24 +0000 Received: from localhost ([127.0.0.1]:38467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFaO-0003kr-8D for submit@debbugs.gnu.org; Wed, 06 May 2020 04:39:24 -0400 Received: from mout.gmx.net ([212.227.17.21]:37621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFaM-0003kc-N4 for control@debbugs.gnu.org; Wed, 06 May 2020 04:39:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588754357; bh=5vvzOphxvK7kTGkMIgjhUfYMOu+so40bQsHwbvxm0y4=; h=X-UI-Sender-Class:Date:To:From:Subject; b=Z7tlbMDIJeX7Lk9X7lfKe+2R9Jq2IW8CGR1zsTIaYjzVWhdHE9Kwqb/3CHjxBcnfn JdHwbTC6Y9O4/4CEU6bznzDYWoXO0YeSvjI2n0jXd1qnWBFB8B77iXPohjtQ3BuqZW ZORaClnfGRhQJZ0YD8NEbCTLNyM6aPO+zTiYJt0A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1My32F-1jDKSB45ap-00zT7y for ; Wed, 06 May 2020 10:39:17 +0200 Date: Wed, 06 May 2020 10:39:16 +0200 Message-Id: <87r1vxmp8r.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #41099 X-Provags-ID: V03:K1:Sr6bcIBr5re2XCtyT1elyToN/uR9Z+TsIJt11xcXCMg81uyLsAL VTHAbptDiedZXyYeeFwmqaSjEGZNjT7/bCRH8zBPajAOGxoRPvUsMvGGIW8lEXpmjj4eHg3 lsu6L8YI34sl9RvwsXZJT4A83tuSaPviAN5ihykASs7TQYjP4fuObiK+7/3t//sJeGWLPCK XxM94wtg0SJjXbm0K3n4w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:CcJq7aG7xm0=:KIGHudZdD3Xr+MJMQbYdPp QBcx3uG0B5zhBdLXjKrcELl4lsANPOyklyucuR5ckljdd7HwebWyb2+DHRMRgbZ+0sm+zUIUi rkRIFa3S6wBCJmz9Yx5DwwXt4rs9Niqlh4qfbAEGGW1xItF9WgNEm02s6giCmnFQiincP+cdB ivEfbmBXI/9ydzjTefXcqSqYqfROYYDOmzMkKiUa+5twl1jSDC81TTooYmoWwNx+jpBuYdk2s 7/OrhhQq5lTEG9n8CEv2Jfs5mohTX1rAlsWo+ExiXm6W0O0hvpODqLiK42IYYsu2TPAMFdAdt 8hMQcGxHIN/PJZWBM+vYmDE5yAimBoo9iIGWsvx98bosMUpKJpzcFEO1QaDk0adlknQ+CiCK3 /mDViDIK8dHasxg9Yo2DFZAQepkl6vIAQk3MN3//Y8D+1Ms4TawYdqs05tuXJqUZtGdvBTZAU 9DkhR7ys0vBs4IkLTlsHe6i/b1CYFtN8NKx95HhnkEiOOD7wHRRD0EojrR3hVKw04+NNKBqc6 RSr9roufFNAqhtcvMkHy0DBsdrkz2m/R5RvZQ5V9IPMPgymMxgtEOdoJl0bYGgE8Ev7lCQgT7 c/bg8b2UOZFvYNW3IglnBZpmiLGq3eDwsLE8H+r8Ymu0zQBkShESC7usSEBTmvLi+NkD0P97c cE6q/oubryx/kSr0wricZMws0+B2HHig2pxObMIsIPo/fdnz1mMjTms+tWwEXxFvqW8Mg++tk glSaJDQrfB7Crrf2D3ngSY+YJKWiJ2RwRohQ6N5pPpqHD8vJlLuYhFLddUo9nuW3z8c99PHcr QJNhI+7z8JsDJxfmUTPMoSYMh7cHmSvbnuGXUe7rlOnnmMn1rBHOlLVU1AW+2hiWFaa0RnWN2 dYfsS22wEG3CzJoV9R4mcQtS8uc5XwlnrSv+rohP87BL3R6vk+K0fGVqvAJZ/UYJ/2F5A7vsK ZOlBivuMJRCyw4E6ravTHIaegIEPmiz7fiDTePlJPIM0F9HehnlJJrEnizlJ2gqDWC1uSKIrQ sV0l64j+105wSOL9cO9JvrWcYjuEOL0HP2YxE3YfDruEAeSO49ic9YhQnVFRSFBhefIcgu8cQ e4d+MHVjBC5dRGIpUpl7tZXVDUnvhd4b069VujPn9zMx9GIXsh41uulVyP4U90sM5I8QImViQ O+73uixgyf7c1cPczrK88WsopdJ4dXJe7KTsuPor2EHQqSIbPbz+ab4FgnA9fAypMZvLpc0tc iookLPjRLGlw+NHe1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) fixed 41099 27.2 quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 06:39:02 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 10:39:02 +0000 Received: from localhost ([127.0.0.1]:38603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHSA-0000Tz-CW for submit@debbugs.gnu.org; Wed, 06 May 2020 06:39:02 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:37595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHS7-0000TU-Sf for 41099@debbugs.gnu.org; Wed, 06 May 2020 06:39:00 -0400 Received: by mail-oi1-f172.google.com with SMTP id r25so1290860oij.4 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 03:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vp+T2Z4rsfp4mPxRLIHBKC64qGa0WhvwGwXVbFEuPSY=; b=s5CUUFGdojsbWQig7C0p8fFAwrjIB4u9b8wNDYcIQ7gAEdrxUq3FRjjl9+DBPvwZ3k IMqmSrL4p+33swkM2Ri/QLhZ/IHgtm8f7xyUmM3IVN1/KMwlGMBG9yMouY2wkeMrA2J2 ZF/gMCpsd9bVApFPQAMDFJ6QHyFez3pje+unRgJSwEwuSVIfACiIEIgyjwQN7KgZY/4s ceeDkwsPazfLht7qAIp++g9sUdxR/BrblDSkgg3emUroGWvjIHsDv2/Lfk8mxxRt7Aa6 rxIQBnucsf6qU69ew8cgzzKGywXFcq0QUnZV0wTfYHPLvu8QMd2JVHW24BOwrSbXp5ln sAWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vp+T2Z4rsfp4mPxRLIHBKC64qGa0WhvwGwXVbFEuPSY=; b=LY8XvgkNyPwBf9/KpXvLFvcBFNktwLgU7VqCmWeRC09LePD82tU6gQC+kNt6War7fP gqOxnb/yM+rQJBXf+0YyvhbT07B0+8hz/ocs4SE2i2bzfuUKiIEDMxMlfFNFHxmHa/Vu ylA0tYgqwI+5K8+mqySnkdTqGIMtGYyPud15LJwRq1Qf5dQ1l6kND7DaA4i2f8uhFw+B GLwQQrHPqSAQ+nKRrijcLZninNu0GCUzrdEFCXHGhq/3jzyKOBVjTRhwR3k0WRv2Zydi kZR+JcEpGt8/7iliqpFIuPyapHnVJVXwjsHgIgnHDD2t5kopEQ0VSQXAdbg4SS86Q7wz urAw== X-Gm-Message-State: AGi0PuaZN7AE+lzVP6YM40QpzST1EUQS1wplGqfkAYryRV0yzx26uK0w QaklWG3bZeRnziinks1a625RsRLYATLqR2oKO+4= X-Google-Smtp-Source: APiQypK5b6t20O8Ngk5OYFDm7hFWG6jJIMS7sySEs7jMZ9CQMFblTz8fjlGAChimDU0Atxudl0MQ79N/4eeMkaEltGA= X-Received: by 2002:aca:f182:: with SMTP id p124mr2260677oih.170.1588761534111; Wed, 06 May 2020 03:38:54 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> In-Reply-To: <87sggdmp9s.fsf@gmx.de> From: Philipp Stephani Date: Wed, 6 May 2020 12:38:43 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 10:38 Uhr schrieb Michael Albinus : > > Michael Albinus writes: > > Hi Philipp, > > >> It looks like `tramp-send-command-and-check' should not just search > >> for the exit code, but also return it. > > > > No, most use cases a simple nil or t is appropriate. Otherwise, you would > > need to check always (zerop (tramp-send-command-and-check ...)). But in > > tramp-sh-handle-process-file, it shall return the exit code (indicated > > by an optional argument). > > > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. > > I've fixed this in master, could you pls check? Looks like it's working fine, thanks for the quick fix! From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 06:50:36 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 10:50:36 +0000 Received: from localhost ([127.0.0.1]:38655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHdM-0000mk-0B for submit@debbugs.gnu.org; Wed, 06 May 2020 06:50:36 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:32954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHdK-0000mO-RU for 41099@debbugs.gnu.org; Wed, 06 May 2020 06:50:35 -0400 Received: by mail-oi1-f169.google.com with SMTP id o24so1330784oic.0 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 03:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/tUuVolbCP6TD8rRUpQYHh6lvZXI81m6VOoB9da1D0g=; b=R4Tkmr7mhN8yTCSKRC7Mrw6+BGkUqsH++IP0/eiqLVg75XDBO08308dcB6nYPp7ISL jSsBOUERECf0Zlm35IlREY5XnmxAZm9EO2v3KvXvQrYdEM/0ZxtAMUeN7vQ3q52EmM74 pKmq0C74HB3SDtPF52S5w+SyX2J4aZ28BqDqRk7ouzZZCuBH2q4BxzNYZHF6Tz7P7+b7 caMaYkG1JImZH4X5rK/gkrK5tVxhEkXw3mYPhVX4nW7DuXXDDVU/j5STIGzn1ZsMYLWE AWQn5oGsiU0OLuoOjGGnMpzy8ZGWOi8FgJb/EU1werAq7nk1POhE0s5AKb706O1xkbCh duCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/tUuVolbCP6TD8rRUpQYHh6lvZXI81m6VOoB9da1D0g=; b=OFwDDP80DLp1m0OQoY41NLdEfulbtQoqG1wCRlX+t5MIAjpYtqwzF/LyUsHiQtDAJS 06oJIpMFx1MKnZJPFeAlcLQ6gbKE9stzopC726q2MUrbBZv2Dpxkf5zNNRAp4RYBHWYZ l6ZT8Wx5rQ6Zt7UPlq3+RcF3vcnoiwL6+ACkfYxx67yq4IaHdrRDz0f6aSiS21jj2lhM tqaB8Flq08XnjWzv/AY/sMaP2Kho9QgDZVXgD6gqdbIHHid0WU4v0pKm94AlX/+fYSnV RShdN8rh8zhBVxh+FJaCII0huKDwt5uwtYhZQwfBe2h1S/28FQGGIUoSGxV8MCqzVzO/ xBDQ== X-Gm-Message-State: AGi0Pua9k/n9S5cV5NODnxBINnWGI2eEB3xIe5iL2KWTb3+XWpwsuTwu vEKaPafobDgNcHc8p78Qj/GKEdfLk51BXdNnUtc= X-Google-Smtp-Source: APiQypK5izOri6PRkKt13ARQkrkdgvJ3yuFOQ36ydPHdYHWBIbV5HqW6nxb5VQZGWYk8XJcHjR/pgtSZzapzWUYx+gw= X-Received: by 2002:aca:d441:: with SMTP id l62mr2265697oig.9.1588762229098; Wed, 06 May 2020 03:50:29 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> In-Reply-To: From: Philipp Stephani Date: Wed, 6 May 2020 12:50:18 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 12:38 Uhr schrieb Philipp Stephani : > > Am Mi., 6. Mai 2020 um 10:38 Uhr schrieb Michael Albinus > : > > > > Michael Albinus writes: > > > > Hi Philipp, > > > > >> It looks like `tramp-send-command-and-check' should not just search > > >> for the exit code, but also return it. > > > > > > No, most use cases a simple nil or t is appropriate. Otherwise, you would > > > need to check always (zerop (tramp-send-command-and-check ...)). But in > > > tramp-sh-handle-process-file, it shall return the exit code (indicated > > > by an optional argument). > > > > > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. > > > > I've fixed this in master, could you pls check? > > Looks like it's working fine, thanks for the quick fix! As a second step, consider also translating signals: if the exit code is > 128, subtract 128 and return an appropriate string, like call-process does. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 07:25:08 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 11:25:08 +0000 Received: from localhost ([127.0.0.1]:38746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWIAm-0001l8-At for submit@debbugs.gnu.org; Wed, 06 May 2020 07:25:08 -0400 Received: from mout.gmx.net ([212.227.15.18]:56725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWIAk-0001kL-QC for 41099@debbugs.gnu.org; Wed, 06 May 2020 07:25:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588764300; bh=VIxqpGYV10AeGERvxWPAxxeTDdqFO/JOAABsfuumXBc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=j7+wVNCom1bzHEboec1tduSOYezSlH3JMLrXs7JlJ1nA/n9QavFWyHTaA41kji/7O gLFgV3r1IVQHGL6+h/Si3XiD31VstP0nmPfh0JuCDzhyXGhm/juqaLO/9Ostqd9QSk zdSas5bSYZYn/rO397DhnuATw9WDb6NH9yAa3sSs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3bSj-1j5aDn0KEl-010aHn; Wed, 06 May 2020 13:25:00 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> Date: Wed, 06 May 2020 13:24:59 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 12:50:18 +0200") Message-ID: <87eerxwbjo.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DlmvYJyTMDJMI4s7LARLf6KdmbEbEqJebWM8ZzRnbz3rXSh9yg5 +Z/R24U5XuYShdGGcsjc/BjTFPU4wbi33V6IEO5ox0WsodwFuw4WKyaAUpi1nRZXsVmVKIO zKNoo/cFLu9/UMsgZ0nP3cuarRjyovBCapqvvcjHmNS6zT/ak5n96TNB5HhZJoHK/7c0Wds L9s1xLi+Gn2/d+MhJE3HA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:N/a+lr6b0iQ=:eVNJOW/tzVZtbXEBjRoP6y 8Cv5QEnaxAhZiW2vzH41QljHf7tLgMeFNOepLH+eLRO3IJPMJa7jtFt9nnxe6Cidwg/kJh+HM Ffq2LvK5A+Jhw2jxfrnBNx9b0Vy8fjzxHI/zHJsiz73rgZLReOOZ8OlgVIeVEaZtS0Q11XOWo 4vULqbj+ZSdpgVpA2ZloRQtFCVyfVDx1wBggDIHN91/hbRmt5Aa0XBbjsR9+FAKlMbROe3p0B EQYL35AFxFyrRmIlF/1LYnIfuv7m86Fi6zRL433yhjtXU/Wbo0+T6StmVifjm9CY5ycqXxXod /cRWtLoFu0RhTNe5wnapnRDvlByyKReKQ1bxm4WS45uAVNnIwD2gK03u2yL6KadTK5XnjwQj0 yXHWrA8wN4rH+c08ay8GrgB4RXWR2hQqxb7jxOfjNf055Y3QZPCl8vO4Zb8XuRukgMWzCvjsW O/YH1SfuYVj8KYmLRNGBHthDLRM96N+YdpOjmN6qzqpDzG1YWnqxV/3lnGGNrzAW0iClNs9qM dKxv8TNsTkYVYtM+3HSkp3q5h5ZZAnfuPYy9Cx3JgQkFvfCRE6tgvIJrxR4QNkJzMS7jNzxYr zeJn9vwpAYF16+oWkqEZ3qGrDu5/Kzha9s2K3DULxZ/LDrjiFkEEtrhXfbkOQe7sDA5MTThCW jvLVGyIvqdLwf6s3s2y84r+N1dakrTG+MsU5hQz6xLX6/DjXk6YCMafScVWBHRHNnAW23NnVS PPuY2dvvpjZg98tq67RYidiNy5Xwe2SH6A8sJ5NrFXgzYu3Lld5fKfVQttQPoP+48Xbg0Hmjz EwzBMCkBBT43aNKHsgkorPCFrDkM6QkGFM7hX9x2AgUKyM5qvDqEuPwOc3m39n+X64CWaRTuL 0hTyqQhXhxbH6c83tWkCCpn5KeMDU7ThIRP0cy6jr5+s8Oyn+2r10/HJupkUarvClWpnnMJBQ gSAaM4XCg1Or2snMPMW9pftA9S/zbcKeB6/g9fpf7Z3uw/VeSWutC5z3fq4wzosWuBHyCnds5 uOaNrEQcfyRhfiee5yoAjxdCyqN0IgMvUvzZG+GasJiLUPa+z00cugHWmwNkV7PLrrIbTv8cB q9u2k/GmfnGyk3oAnRMvgB8ajKs5RIs6y41boh1azqRwr8SzauRzaHgRVvwFS+gsam0PJyj1I dla924DmLhaKEP8ZVZUrKXMtPEfwG5eew9ZbzS0Ydgx0rTLqsgTXUbeOuNlYU40fT+OEXlchT x83JiFSHG4uczldoV X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: >> Looks like it's working fine, thanks for the quick fix! > > As a second step, consider also translating signals: if the exit code > is > 128, subtract 128 and return an appropriate string, like > call-process does. Thanks for the hint, will check. Best reghards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 09:32:20 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 13:32:21 +0000 Received: from localhost ([127.0.0.1]:38979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWK9s-0000jO-LP for submit@debbugs.gnu.org; Wed, 06 May 2020 09:32:20 -0400 Received: from mout.gmx.net ([212.227.15.18]:38307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWK9p-0000j6-Bs for 41099@debbugs.gnu.org; Wed, 06 May 2020 09:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588771930; bh=3TzjzUoCQrjwGemIs+xR4hgboh4JoIGbL1LZFDI4cHs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ib18YXvl/5DhfTzB4QJSQk4mFbWZWfRetL9SpM43D8FPK2a3Je+/dY3YXr5mWSWRp tS/c/juaasLaBzpidnE4lpgj1HI44mTKDA81FjD/4A7xikZxut7ogpAdlNRiCUr3kJ 1n2Ht0kH6Tp3Ctu/BCe23fiKIq6Jn/+KnXU/CPaE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNswE-1jllXG1nEu-00OExc; Wed, 06 May 2020 15:32:10 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> Date: Wed, 06 May 2020 15:32:08 +0200 In-Reply-To: <87eerxwbjo.fsf@gmx.de> (Michael Albinus's message of "Wed, 06 May 2020 13:24:59 +0200") Message-ID: <87zhalrxyf.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:W/zZVIBGzchu9N4Ngpa8QeqUyoKxBkw+214fa1Cwsy4G74uxndM 0997SOqdaefqCnjlbgr90II8oqxXNW7pIqzcJ31y/n7lmTZan66KfT+6uDM75UEau/HFVU5 YXm9GuGAgQ+TL1fKJ0FTC2C1q6aWEVAwsm6bRB5sDfzsxacV7sUZnqnSLhvks/gCcgOODj+ 9tC+LHO7ZAWUdw3xjX/4Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uupbPlMeBYM=:b7pTQ/8+LdbrDn2qk2SOBv ShP9503xs4PksdCOl6FkCp/XLnbh3J+tDIJL5CpLGm2sy9muBCRcpAmqP9kosuF8HZlBlDrUi GRvCn59GnxX84zbf2l1gVMvQrjOBpgmYfd0rTucl6sTfSs16/PPOqkc9NnEc4sOtCM/sad4h0 pceKo/Muh4kLgyMnaH7T24WnWuA3dcyZq//F8/rlaU0ap2a1ycQVu7iYwJ5XJUqvzWvQ3K4R2 rYBDtsHbo4hICKHbU2P0Uu7RjvSXbni/LzTSEFMKfmhuMTtHfYODYJlTkVvKcOBbanXnJS42S FXxCXhXS1bxas9eEmMeEwQv5BylPfnyz/jU/C2EyLd4wQV9B2aUHC47OUVabUdu9j/lTstEcI YZDDvZhDVvZLhBe7P+XqpLBHrkabzp//kIumBvHRqNhnD6TYxZyjPCfXslwD7yP0paRUmVPKf F9SW4Gw46RIgXaZYSwP9i8X21MYIfidg1VVmSfxT8smr7o7tAFlJ5MCyHYqrgL4mJ4t9L6040 bplDwcSdzq4MDR9iqLeNcp7SJHVC82Fv9nBehe648i33ht3Mnk5WFnNRaWFStbPOZKZ8E4pdj xivDX0JirDSU5PJ9FJ4qiQT43B2IL7vwkTRPPafzU2AGXeAzvSAkq9Kc1+bIQK/eKukOOOIjW MIUr8xVhjUW3oQeWSFtXod+QDj7N3aaRXktbu/C4ZwGegUCFoX3A6N2rN34xFV7BWumtuSx5p AKX3SCBLb33oCRceywAHGP9fLPzXyAkrYMlsb2ZLKWS+MANGab78zvxVAjmfE3u8kYqfFz2SX 0ffAok8KqQk6pvBehT4FsDY9bzYF3fZqELtZheygNtPnZ5CndaurjjrPreXWqVhU2/znOGhe6 bSHghiFGQ5GWQ6/11B9yNAi/74fK9vXPvKwC8OTbbW/Uer4CnLT/EfpIYy01zJEj57k506kVc bXdZYTw5GWEOZ5zW/gkTzU4D6qj1/CUGn+V6getHzsRK5SSzjU4XEiCfQx4qZwTTc9hu1H/ke bDwboQol2DR2aCKZSA47+ZyxuI+TIUPCR17gckaGUGStlyAXrB/UAA/DdFGop5K2c5H1B0Jdz Er8TabUBPQ9495fWPj5MXON6E8pRFvMHblFUHPjuZCLn9A6a1GJg+SxujLgPTu4dGi8KasH3W YOndFZqHBu0y4RTznn6H9bw84vog+u0wo3N4iqGNRrSlK3DRPQuFQSkNdCIGWqPo469Myvg1Y nyPNDg7PHxUqSQ3qK X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: > Philipp Stephani writes: >> >> As a second step, consider also translating signals: if the exit code >> is > 128, subtract 128 and return an appropriate string, like >> call-process does. > > Thanks for the hint, will check. Well, I can't see what "call-process does": --8<---------------cut here---------------start------------->8--- (call-process "bash" nil nil nil "-c" "exit 142") => 142 --8<---------------cut here---------------end--------------->8--- Best reghards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 11:36:56 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 15:36:56 +0000 Received: from localhost ([127.0.0.1]:40888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWM6S-0004HW-K7 for submit@debbugs.gnu.org; Wed, 06 May 2020 11:36:56 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:38109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWM6R-0004HK-BX for 41099@debbugs.gnu.org; Wed, 06 May 2020 11:36:55 -0400 Received: by mail-oi1-f179.google.com with SMTP id r66so2112222oie.5 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 08:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HJ/Mw8hX8enJwOGa06X18K0Jgrxygp6E78NBwgCbQzM=; b=LQ6keaW2gK3VCiM/jCQVjFd7Airdd4zq7fx1hQDXCWyXJ5F3HJ9naNsL2785VFst7F 65JLNLSjfX2Sf9DhSRJBFjFvxzdrcUEyYDgHt8GkblkulbQJDFPVJGGkLyVNVDTB3nnX SwGQ1d9xTM/DNh5IZJcnhKJtoa6A4ZjvAg/QxynoQKu19YFq1XHtDQSRgYBB8LO0jwdq npyr47KwDV3AWv9E3kgNmojWNIOp7vO3j72qB/aozQLSLVNzfVoKNjcxmuY27guHy59O wsLdpzLdV6uGQ9ym2s3c7ftO8QuQMcQBIbecjsP9DkD/Web13oK7GSlQUsuLuox+uoal 9UQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HJ/Mw8hX8enJwOGa06X18K0Jgrxygp6E78NBwgCbQzM=; b=s7JyNzwJP4lcA7+41sXzgGDoxwU/Fp7MWq4my0+BxtrOdPAgUhHGfJQffoR1a/P5+q EA1szqxRVmC0/5MaFSkLv2IhntWXWdm429dyFHFP0tba6elkmipQuyXylQaWflAPfVM9 uMDgWoionQwTFtptyW8+mHwz840NjqtauZ/D0GwdV+d+hLGiqfcZ84OAbjUdyLBKiE8m hgVeztdRpo246QU9WzXiDYtwA29MoxVsqYccDN6A6irXwTkhU3rlFYHiNZnkDhDdzgGt A5Js+BjBVca4EzKcq6g+5kFG8kVtFhLtyFqTxksYlM7ovszUnaF5sGpYWEHmqLGDdj8L v/2g== X-Gm-Message-State: AGi0PuY32V+ux05avnZt6V6pWz/CU73BZeOzpRvU4TWn2i6n3y0u8fyi BrZlx6xiMCoeOlrGoAJS7hP/9K5uSFyw8tTOBYg= X-Google-Smtp-Source: APiQypKVqvGmfhLJPqU4R97XvASckP9bnPNMM+U+6mr8udXrh7kg1kzdWeugcKniAWpgwUT3veHB4mOcM+7HsvFUcRw= X-Received: by 2002:aca:f182:: with SMTP id p124mr3238043oih.170.1588779409374; Wed, 06 May 2020 08:36:49 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> In-Reply-To: <87zhalrxyf.fsf@gmx.de> From: Philipp Stephani Date: Wed, 6 May 2020 17:36:38 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 15:32 Uhr schrieb Michael Albinus : > > Michael Albinus writes: > > > Philipp Stephani writes: > >> > >> As a second step, consider also translating signals: if the exit code > >> is > 128, subtract 128 and return an appropriate string, like > >> call-process does. > > > > Thanks for the hint, will check. > > Well, I can't see what "call-process does": > > --8<---------------cut here---------------start------------->8--- > (call-process "bash" nil nil nil "-c" "exit 142") > => 142 > --8<---------------cut here---------------end--------------->8--- Try (call-process "bash" nil nil nil "-c" "kill -SYS $$") "Bad system call" From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 13:30:51 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 17:30:51 +0000 Received: from localhost ([127.0.0.1]:41104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWNsh-0007D0-FC for submit@debbugs.gnu.org; Wed, 06 May 2020 13:30:51 -0400 Received: from mout.gmx.net ([212.227.15.18]:47095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWNsg-0007Cn-ES for 41099@debbugs.gnu.org; Wed, 06 May 2020 13:30:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588786243; bh=zybgZi4o2RR4Yq4zG5fN4SkfnRcpyrPTEjz1kZ8Wgio=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Hg4Ep0zTqXMD/IeM6a0FFuiywQ/OpLoWQmFLNkLAqOpILFFIGnxP6ayBFw5eqbrJN HUUa6QQQ352EyNAlsDXy9TSq90lAWGnajpS5Wbkfw/nuZAaf08/WBQQxmhgldKmrVd MmYYY7/fBRZ3ZQYid1yv1iV9k4KR5Ws25LjNL+oE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFsUv-1jMAM235Lj-00HOOt; Wed, 06 May 2020 19:30:41 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> Date: Wed, 06 May 2020 19:30:40 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 17:36:38 +0200") Message-ID: <87o8r1rmwv.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wae622QdEZKu8Vr7R7y2fhQLBc3jp8ZnIrFpxewBLm4WnSjFQHG ZCI2M3sYuCZlmKaVxuY5CS3u+B473Ru07c9HbvTN/YhOZcxmbGLuuXkrAcv1rFUT/YFwECc hpx4JNb/KdHHvIVqzEWltVnysUG1h5uyH3VZZ5b8rDIAlgTvwPoZQU+5A0WNS7h1TTbsyAL rEW17XiryU4HkuK52QJCQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2Vi+nlDeM8w=:hXTm8BzKSPgq9eZBQkPOf3 /Flyq9ZPEspLgN+ssOEZzpiZP+bTXnGgq4/xE6RjY7mNoHQ/Oh7355xuxyYL/FFWwWiL9b095 AT5FHTEkWyqkfhshcYy2REEXXU9B3Vgm5159Av+cKStGuNEhwKqX2C8n3T6Y/d+lPNhuQBzfS VEyg3CG4nzDqQKH/ojSkLRVsUsdq6XbZNUJOEq8BuabNvZzVxndOp7rgmNJsspuoRyp1MuCLB VLyRO6SEePYhJGrO2djwzeNxn5irXIG26nUkhRfQFYwweEKr/H6w5cyX4IhzluLDzy6TC1RnK FFc7zx7Fj9N788zvNUFfMckM7DxwqfKt69ef3w8ttGVm37/wa0zTQ2Z5n3I/hY62wjppEhJVO sQlqOVlF2cNa0GJaMNJoZGCBXVMXrkm5ZqXsvfe69+D6UjOF6fbOrA/DTlTCDodQmmKADJeUX SfyLsM3drKKoZJUGXBTDmP+7lSD/XdZX/EQTFThnDIklGx96fn15uRfawTcacfHy5gr9pnYh4 yjasW2zmfZwDiGpRdO5BgTSfKxTcU9Rl/6gstEYv/BFp2PQKhWPHGM4p2SHExCTjvJrfb+vuS RzeKoHq5Zqs1NPk+2r5mAs5rhBXBxZH8TygqqWJSZoJURezCnz0oFCXWLqYO39PlSvcryD23F ptcafPdDgM/OXjf5mWunteH3bP6raTh90J0Q/XPqh69xMJNwo7ucPYcMKKnswL0BD/Y2ezEp2 Pn/PyoKBzn3T4vLEPgRHqnFKszLGl4I674n6zmRtWi/f/3xEcYn9gXX5bXK16x2Wz5rwlH7n1 6f9ZArIHC+8xlNV5jN1AFVjDFTE3xpato73zaalBCl1Ey7+muG0P11RhzUyVp7JNmgKEKNQ6c S6LYy/ODi4BSNmSgBUk6PxcwBOLXA+kZSz4MkXiOEI2cykdceDkLn1ekpYQ3KBMF4c6zMo4SG k0G6Rz0P/sWNsxt/oi5ZRrxAfnhmmTdp8hPViNeJwsfGT55O+WuvdOKhXpF+XNXQUA5OKTIoa zrDKfY9gH9EkvcU1TWZCAPQa4TouHqvwS6vso+J71jC3Dox3e4qN5SDka978F+GFSp31bfR0G QeLZ7LW/Q8P/vDERPwBnn6x6Zl+l+uV/xYjkTF1ran7Lmd5IM+K0baILzSM0+oahm7n5Bz6Zh EQFmj060KkMumAHGV27ida+ydi35C7/+wdUBAlBDrb6PLoBq8gnT9cGhJY5APvNdmO5/D5bWq Y5772axGnrThyiT7q X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Philipp, >> As a second step, consider also translating signals: if the exit code >> is > 128, subtract 128 and return an appropriate string, like >> call-process does. > > Try > (call-process "bash" nil nil nil "-c" "kill -SYS $$") > "Bad system call" I see. Hmm, this would require to install a trap handler in the remote shell, and to add a mechanism transferring its result back to Tramp. Don't know whether this is worth the effort. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 13:41:47 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 17:41:47 +0000 Received: from localhost ([127.0.0.1]:41119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWO3H-0007Uv-Ai for submit@debbugs.gnu.org; Wed, 06 May 2020 13:41:47 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:45049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWO3F-0007Um-70 for 41099@debbugs.gnu.org; Wed, 06 May 2020 13:41:45 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49HP6H5jSbz1rrKZ; Wed, 6 May 2020 19:41:43 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49HP6H2X5Gz1qv85; Wed, 6 May 2020 19:41:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0olVYRjuK_HY; Wed, 6 May 2020 19:41:42 +0200 (CEST) X-Auth-Info: tMIIMsoh6taJMFMdzGPVPdTYkOHp2VkfYE3AUnyvUgdTUPieIs9Pl34GVWqErFQX Received: from igel.home (ppp-46-244-183-249.dynamic.mnet-online.de [46.244.183.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 6 May 2020 19:41:42 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 09BA22C1DF5; Wed, 6 May 2020 19:41:42 +0200 (CEST) From: Andreas Schwab To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> X-Yow: Am I in GRADUATE SCHOOL yet? Date: Wed, 06 May 2020 19:41:41 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 17:36:38 +0200") Message-ID: <87k11p6jvu.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 06 2020, Philipp Stephani wrote: > Try > (call-process "bash" nil nil nil "-c" "kill -SYS $$") > "Bad system call" That doesn't translate any exit code, it just handles the signal that the process dies from. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 13:53:43 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 17:53:43 +0000 Received: from localhost ([127.0.0.1]:41132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOEo-0007nI-WE for submit@debbugs.gnu.org; Wed, 06 May 2020 13:53:43 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:33146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOEm-0007n2-KR for 41099@debbugs.gnu.org; Wed, 06 May 2020 13:53:41 -0400 Received: by mail-oi1-f180.google.com with SMTP id o24so2555791oic.0 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 10:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/K6fNliX8gZvBq03PYD12YUChuAx5gLnFFjg+5cQrio=; b=jsKeP1pZQhJTU/N6S4AIyL3YUWFRPNRur8J1H9dFY+9zyWt5HbtjMGDDsk3zFVCZ0u 65t2pjsMnDk4/OViQpZPQOWBPuaIBUl8twhRHfa4l1EjAqLb4wYc+stXt78PUpdrVBH0 bt3sHQogN+fWYijzvzWF7QOm0ZXlM4zRGu78OruSBr5Et0MG8fWP1E8R48rvYzVCFyjy Kl5zalW7clRwnHxyAkLLhtZZeQGzIb+V4TY/rRzmuYdgnPB/a7gzJo8ssFIY9yTy8ZSO QF53vAe7eMfzUhQY44YHrpAx06SizJPI549geiZeujG3/EU2ttZCN4uAmAJW4WtK9Nor Q7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/K6fNliX8gZvBq03PYD12YUChuAx5gLnFFjg+5cQrio=; b=UQcNMnFGV6fke+W971SmX0WwBmd+REtklyUOZo0acRKSRevxUV96x419HfgwH+dfgJ Nce6oxlpbuc/mC9783NdiiB+B4Tag5ZQHbdjeFuW+nhkpcmq8Uev+YscHoCmsagFq0Hp oPcLW9IoaS+DIvDsegecnFbUReIdbZyQV7JmgRQMiyMcyDyyJKbVzvakHYs7XIx7AMch I8hnU44yQ+BqwDmhwgqB1FOJYq42WZwuCDypKgC9RzsR5kje8hyYw0jAgWK1IYMxrXw/ 7gz8MS38kDPQUyToYCbqJ9I1IatipJJLgleWYULc7IdgCFa00lXk1RnDvtwjNGCCEaZR 7vXw== X-Gm-Message-State: AGi0PuaiIXmPPhcjaYZwVzbjHm7QjYvX056QGizaCEdCxsZzrgIlPJn7 gePALHxBd9CaKivl9daaxZhGJ9/XFUxxW4aZEK4= X-Google-Smtp-Source: APiQypJkH7BIDYq25USP0X7hTYvGu2lOt7Re8PxhstKm8o0k5KfjBD7OpZRRgKBs4JBP86Iobhh+vQ2zVDEzW9lfwxI= X-Received: by 2002:a05:6808:98f:: with SMTP id a15mr3614531oic.65.1588787614700; Wed, 06 May 2020 10:53:34 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87k11p6jvu.fsf@igel.home> In-Reply-To: <87k11p6jvu.fsf@igel.home> From: Philipp Stephani Date: Wed, 6 May 2020 19:53:23 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Andreas Schwab Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 19:41 Uhr schrieb Andreas Schwab : > > On Mai 06 2020, Philipp Stephani wrote: > > > Try > > (call-process "bash" nil nil nil "-c" "kill -SYS $$") > > "Bad system call" > > That doesn't translate any exit code, it just handles the signal that > the process dies from. Yes, I know. But Bash catches such signals and then exits with 128 + signal number. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 13:56:24 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 17:56:25 +0000 Received: from localhost ([127.0.0.1]:41141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOHQ-0007ry-Pt for submit@debbugs.gnu.org; Wed, 06 May 2020 13:56:24 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:33437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOHP-0007rk-HP for 41099@debbugs.gnu.org; Wed, 06 May 2020 13:56:23 -0400 Received: by mail-oi1-f179.google.com with SMTP id o24so2563982oic.0 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 10:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5B7w6Z7ELazipSWlToYoOHppPe2+KZ+Cy/9Q/kUqD8M=; b=GcrcC3LO0xNkin78q2Irf9kaLeYdCDjSPw2OkCdI4OHuMaLDFq93DkhU98t49Vl65O dMinzMVhmeoMFDS0O7R9cUXU6O/6FAB3wJD7hs8YXY7qVQH2HVVLmJa1IzpwgsdfdHYt nUqLqavK4+gK3uVEXRyuiGCWLOr5jZ2gRSdQ/vcdPvX14j9nJbB800vRXDRWHOJQxvuu nIRM/9od8i3cjxx/m1UV/EB2uTVH6QY5rImqlSSRiJOBVcgCYF0+ND3ddj89z3fhnk2E +8Wlx4SqJfDy7E/CiwTrIdnHEmCjAdcJ93InOTd3thi+aM6KxRfIY/JK5DO5HEC2Gh5X 7igg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5B7w6Z7ELazipSWlToYoOHppPe2+KZ+Cy/9Q/kUqD8M=; b=RGZ5WI86KTDgk9a89XDQGOZ9fI5lAO1WAA7kuXDVtA745Emh058dqTunw5ltDrRXJI nLTnf7/NSXLNf06ia848LFpYkHWBIhlnIN3nANjdrhS00O+TSMNndUBVSWS6MsJ91F7I 5GyETsapGJcdKE0aF34C3qUIqaN6OnH3Wpl6vugTy1gJLUJk4bkPiQTO/Qfk5DH7osxo TP8x5L/pr8t6H0n/ZYclRiFVWSkQJtXRzr/IPig5UPJxlDpy/vNO/XiMusK9ImHCtT3k m1P36y2nxG4FYZJp5OEIq3mZliKAbMLgjofHZYBW8LbNufxc5HVQOK9SXDf+1QhbnBm1 0/WA== X-Gm-Message-State: AGi0PuaFgHkxvgBtaIG8KUhEIwie6omn7Uk3fsGBWHt6M87Mbqqapasn NVN3gcW0ZK+Isswv2kCHgOO2XxRonyj7zPw38T7Ys2nslNw= X-Google-Smtp-Source: APiQypLvcoO5JWeDhitdzECWOVpMZJYEBGy4QLMA5M3l25uYg8IkQeY6qGaCXOsBMlxKltQTB3zBCu/jO1d3csihqTo= X-Received: by 2002:aca:d441:: with SMTP id l62mr3731281oig.9.1588787777926; Wed, 06 May 2020 10:56:17 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> In-Reply-To: <87o8r1rmwv.fsf@gmx.de> From: Philipp Stephani Date: Wed, 6 May 2020 19:56:06 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 19:30 Uhr schrieb Michael Albinus : > > Philipp Stephani writes: > > Hi Philipp, > > >> As a second step, consider also translating signals: if the exit code > >> is > 128, subtract 128 and return an appropriate string, like > >> call-process does. > > > > Try > > (call-process "bash" nil nil nil "-c" "kill -SYS $$") > > "Bad system call" > > I see. Hmm, this would require to install a trap handler in the remote > shell, and to add a mechanism transferring its result back to > Tramp. Don't know whether this is worth the effort. That wouldn't work because Bash translates signals from subprocesses: $ bash -c 'kill -SYS $$'; echo $? Bad system call (core dumped) 159 The 159 here is 128 + the signal number. From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 13:58:12 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 17:58:12 +0000 Received: from localhost ([127.0.0.1]:41145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOJA-0007un-3c for submit@debbugs.gnu.org; Wed, 06 May 2020 13:58:12 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:42211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWOJ8-0007uY-Mc for 41099@debbugs.gnu.org; Wed, 06 May 2020 13:58:11 -0400 Received: by mail-oi1-f178.google.com with SMTP id i13so2537412oie.9 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 10:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eAIOWT6MZA8nb6zmEfvx/UVxNVeKmVrPZyA0dZ5/pP4=; b=jkOyNnsmbipoaRLNFcU8kn3bI8qvq5BwyEyrce2SUoBVbqAcW+8uOlDty95JgoVVRh 5ypgcVaFPHQQ/VEPUfylfNtAIuv13wTP2aPHoDs+geFzud9E6Mgvi7sxHwt/s7mayEJD K/HEmug1uxln/Y81pIB+yN8H+4JlrXKBUTDtqXBxU52t+UkJycb7PZbcIbTBWMEphyr3 iBArSRcxQUSpkns9PtdsiBgw3dCk+DaJGi0jE44jDNad7iOB+qUhQtdSvlxgnJbZ8T4u mqvozISo5MbcDJ9rsDjmRukTL1Q+b+j3GV6uRK8kBzOuOcHDHKNivdj1mvWdCr7Dl4K0 wShA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eAIOWT6MZA8nb6zmEfvx/UVxNVeKmVrPZyA0dZ5/pP4=; b=ac24e790ESeq4xciyStyXvjCumGO6ZeFw7lD1PGOKSJcu8XfUtbkBRqnxwUW5LU+08 dXI2byIU3jZrrX9vASR6ppRmsg4gZh55C9d600/I8+vL8jHMd2Hdrnnp2RMRz68EbBSs UgYYwuWZqpcRcQMNwZkPLpGFgz2tQJ1NYh7H9gJP9+SP7EKpXOoZO5E8UkIDkjBmeDcu gzn6b6WLIp6enQVtJX6dodY3KAIuTdPVlXNmhPs7wHHoCLsFZPU5yUDaBn5BuhpmcmKW rPi5E8pEOK2NZs4f026585RVgY03H5xmjvX6qGibvweHN+ywYQbWeMEiB+DkxEr/7iVs iKJA== X-Gm-Message-State: AGi0PuaMWUKHpfheJw8qM6VrgeLTXW99hJarl0bQ34hYxJF9k3CNPA3M 9fEfGdYw6uTXGy4C/6wXDqBV9iyQ44Dj91xM82X12hzj X-Google-Smtp-Source: APiQypIYt+aZZAHBViFTFixvHk7Xn1JnFWh4Nxrv9NwWLgi54IgAi2FfTAhhWzw/Z+Szazol2TkfunVLgpvKdj5LSPo= X-Received: by 2002:aca:d441:: with SMTP id l62mr3736590oig.9.1588787885081; Wed, 06 May 2020 10:58:05 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> In-Reply-To: From: Philipp Stephani Date: Wed, 6 May 2020 19:57:53 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 6. Mai 2020 um 19:56 Uhr schrieb Philipp Stephani : > > Am Mi., 6. Mai 2020 um 19:30 Uhr schrieb Michael Albinus > : > > > > Philipp Stephani writes: > > > > Hi Philipp, > > > > >> As a second step, consider also translating signals: if the exit code > > >> is > 128, subtract 128 and return an appropriate string, like > > >> call-process does. > > > > > > Try > > > (call-process "bash" nil nil nil "-c" "kill -SYS $$") > > > "Bad system call" > > > > I see. Hmm, this would require to install a trap handler in the remote > > shell, and to add a mechanism transferring its result back to > > Tramp. Don't know whether this is worth the effort. > > That wouldn't work because Bash translates signals from subprocesses: > > $ bash -c 'kill -SYS $$'; echo $? > Bad system call (core dumped) > 159 > > The 159 here is 128 + the signal number. What I suggest here would be something like the following: (defun tramp-process-file (...) (let ((code (...original code...))) (if (> code 128) ;; Probably a signal (format "Signal %d" (- code 128)) code)) From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 14:58:35 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 18:58:35 +0000 Received: from localhost ([127.0.0.1]:41182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWPFb-00010F-6p for submit@debbugs.gnu.org; Wed, 06 May 2020 14:58:35 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:55328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWPFZ-000105-2Z for 41099@debbugs.gnu.org; Wed, 06 May 2020 14:58:34 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49HQpv5pKQz1rsX5; Wed, 6 May 2020 20:58:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49HQpv5VnRz1r5Qt; Wed, 6 May 2020 20:58:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id EBPUd6vRD5uh; Wed, 6 May 2020 20:58:27 +0200 (CEST) X-Auth-Info: Wf+4ezX73fKkFokW20nkSD0sftzqGZvDW8nT7+BFeX4Bx2yYBOOldoZ2b4nGU3lb Received: from igel.home (ppp-46-244-183-249.dynamic.mnet-online.de [46.244.183.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 6 May 2020 20:58:27 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id E8F8D2C1DF5; Wed, 6 May 2020 20:58:21 +0200 (CEST) From: Andreas Schwab To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87k11p6jvu.fsf@igel.home> X-Yow: Yes, Private DOBERMAN!! Date: Wed, 06 May 2020 20:58:21 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 19:53:23 +0200") Message-ID: <87ftcc7uwi.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 06 2020, Philipp Stephani wrote: > Am Mi., 6. Mai 2020 um 19:41 Uhr schrieb Andreas Schwab : >> >> On Mai 06 2020, Philipp Stephani wrote: >> >> > Try >> > (call-process "bash" nil nil nil "-c" "kill -SYS $$") >> > "Bad system call" >> >> That doesn't translate any exit code, it just handles the signal that >> the process dies from. > > Yes, I know. But Bash catches such signals and then exits with 128 + > signal number. No, it doesn't. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 15:33:17 2020 Received: (at 41099) by debbugs.gnu.org; 6 May 2020 19:33:17 +0000 Received: from localhost ([127.0.0.1]:41232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWPnB-0001tK-Ct for submit@debbugs.gnu.org; Wed, 06 May 2020 15:33:17 -0400 Received: from mout.gmx.net ([212.227.15.18]:53283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWPn8-0001t5-Sj for 41099@debbugs.gnu.org; Wed, 06 May 2020 15:33:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588793588; bh=2ABHjcLTrjwpzevLx2Ls0IS6qysaiC9zXHijn0IrYss=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LA9U0vr3oUbB3bWVqoT1PNb4U93E0S/jF4KcJn3J+wAyBbKVF1ulFbkcB+j9PCZbl bvXjXNmVgb0PewIT3vW9IalbsOZu+Yctpw8lTH3qBuPFP4mfJ1B2zlNqNzWAJ326ud RT/bfzc0NKyDkJTflxkXamfZgU8iRlfcww6wFRzo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxUnz-1jCXUL0nP7-00xuDB; Wed, 06 May 2020 21:33:08 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> Date: Wed, 06 May 2020 21:33:07 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 19:57:53 +0200") Message-ID: <87h7wssvt8.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:7obB+ZFRcaYA43S3vfwDUoQBM6hfhINGqYBXlNhwlCmxIAlmJ+N tVowRp+dZ802NPprY7lpmoAzPnEdW1OjC+k4UMLl8My0lXTjFS7/pIbpqRC5hI6qojOWR9Y 01VPNHapvMWf2h0lRzbhKwEr1sFGe58S/Mn6cms9P31lsqd9iPC82y7YjXmDAgXRhacGkRf 0Pb/IUX4Np+MuCC/b970w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fnORD3ipVaE=:FuddksULvxdRPI0qzA63K+ 3fDpIW/qy81zeFOVJDZjtodsNfKRuoH/mI5ImiQWMLl05WjD5h9SnCcFruYWELQnvN5I1qgyb kfWpO7qYV6R29tGnGpFY/ZrTUhTS6pS1hVMrx18RO5O0YSLwYyW/zZBE1I/S7GQ8p9JF6+DO7 rsbZ2FN7Q3CAbOlLDg8COsPPFBrWoW2LALJftEPsEiROYcPGM6dGcJ0QyRTIuilSe9ognjxuf XTW2RRBEOYDk1CkQzo3iBuPEdlA0iI5fyl9blsNQAlh9BlB+M1oOX1rAySTyzJQjEV+Oqly4+ AgcFJT1ESC8k1Lyk49En2dJOY6oqICAUG7Y67i8FcZseO6n1Q0fTHdGtmIJllPBu0H5KMO6QR mTcOwZAprBBV8dIEqvpBf9zbQqFE+YVbXLX1KaWHsXB3BpOSTCd4RIOKqt+mwminSZyEaMHzM 2hkXETyxnRh7W9Q/kbBAhmAz7F/OLsm2nPHE+QDpEAYq6FEKoGrLpQ09wDYX94RX7msy0/y0H vB1evS+GdYLYfSOa9a/MbGux059H1SKFGk/UWmAMylIGihKG84mRGJG7upLuYdrjR1zzbfTlZ M/UHNL4A9Si8eq6mJrCJdiMOvy3WGIDXu788tm0N/VPfe5+FZyPdo5YzB1ZEo1IzUAiAn4L0Q lfluy7ZbUsxVA9kRSXCVpDJhK5UK/Ulr3v8DYd8UU80WVAYBAZs4pGwBpJOlFYSotHQjMOpXo 8fApiWv8+6akgftshGF6zQJQ10fW0JSnx3Y4TcVJ5xvp6LPbjWbTu/SWM17H+PmjADbisSPKW ls2EVJZe6IsWm/9gx187fk4ngilXhgPyta2QMzkM+mFSx7abOzSkGZHJMnGdl2+F72nqpHITg TqwBbwbfO8uA63n5VchL7yYr+VD4kg8ClWXOXQeMDNancZ0Aid2YllE3eA8qEww3mTyJe7BsN VN++KzH5/7BazgtDR1ocERkvM3D4CriQipOrWeHM2+REGvNtkQBvWrDjU03+pziFeMoVIPcUp HOKuXJXDJzeW6d0szKu9I2sGVebVdslSfMyvy1FkSl45rM8c+m9b9ndm5Ql5dcuLiZqCietjN h1W9uwatBZS+b5dH5MBXjHTKcGodFe4Wal+Rk9/TiL37nqefpievijRQscHCMRqbiKxp8vB7Q AbtHuy66Uhr1mx1da+/Da2UTQUy54gqyOu8YsqvL+qfDT8Rtb+KpCS7SflWo4KAwW9By9YlHa j7j5CDL68iYnheFEC X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: > What I suggest here would be something like the following: > > (defun tramp-process-file (...) > (let ((code (...original code...))) > (if (> code 128) > ;; Probably a signal > (format "Signal %d" (- code 128)) > code)) Yes. Or maybe there's a chance to access sys_siglist from sysdep.c via Lisp. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu May 07 04:29:26 2020 Received: (at 41099) by debbugs.gnu.org; 7 May 2020 08:29:26 +0000 Received: from localhost ([127.0.0.1]:42023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWbuI-0002Ur-4l for submit@debbugs.gnu.org; Thu, 07 May 2020 04:29:26 -0400 Received: from mout.gmx.net ([212.227.15.18]:36501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWbuF-0002US-PX for 41099@debbugs.gnu.org; Thu, 07 May 2020 04:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588840157; bh=QQ5ivh93Pnlawk1ho5y0QtjAm6MX+JZSKQabR9zt068=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RKcMcOW1R7kWOS91BjFggQ5h/tzeNy3mgg09LkOAUYy0dGECJDmruCu5yEEI3Ww2C nyTXVVrF8FbnW7e//k5UNb78EQ3WzvjmdmmmEk1c2ECnKqxhUZWmdg04t3Fq6AGYC0 J2tEgO1zV7JExNRDB1e36+gfbu4gdXdd4GiDQzcs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.53.62]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmlT2-1ip3MJ0bKw-00jsVz; Thu, 07 May 2020 10:29:17 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> Date: Thu, 07 May 2020 10:29:16 +0200 In-Reply-To: (Philipp Stephani's message of "Wed, 6 May 2020 19:57:53 +0200") Message-ID: <871rnwrvvn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:rMJZhcDcqjCiApD/UL2+BnVHiftaC7ytXT7iiMoZommYTqu+vVK LkE2b/4zB9H7HC/WPj/tLaJh96qWYjmk1+vJ/cHP5cbkMAMsnS9zbiRlaiXdwa86r/AH8im nmLfzZfMLH7LnJSNWX5mQJNC4LNQ3l6frGCP7PjIa8afITQ8aKnlCa1IHEehhcY6AzUJh8H IqI6Cx/cChzvulPzk+4Hw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:CR2z8IAHXIM=:W/FcXd0CGPp/x2gg6H84vf H35MAeZgaoAglj4zQb2xbrUy3tr32r85lrHBlOJtBEW9JkwZ+ae8MhkDgVaobyRzvhozyEqO1 IVqUx/ehL3LJpbg0jJSqxsK64NQms8o6tKpQ1CJYMRE1haEh3oPVieilNkcZIcgQZTqS7Yp6Y /jshAp7+78Stw4wB9ytj0aKFhNTlMSYbI6alpd75JlcPzmmIpkEzAt/UJ2N1OzF8BIBAiZwZH qjo4ZG3wOZ27QpZfr4IscJIrtzQQlBjTZv3b77xgByQwbAFvFvtvA+fjhvezBgvA3GxUQZ86L cN4Exg9UydGAspd/seSwSCIja/fuISOi/w51fnpYYlrmFd+S+WqA4s3xWmjUgMnlFVgkziEvw ioGykmwA7sr7lReSitJSMZiJwoRQDITG7G8yFrzW/Rc82tQxz+iMqDxNAXNQbn6E6cBFPEQSV if2F/WStjEy6vJjnAh0NbgHlFs2m7RxEdhS5F5ZfBHBoAdSzM2y7cmglLBvHNM2roHxxp9/J8 el9DuGrHixXynbanOMGgbyXv4Uf7nTP9TgSahu6P4CclG80WJRP05YMxrDf8uLn0gayuY3Bzh YfxbXkPB6w74buV4YRKzVH/7IM2dYfMFzl3RSQ6JJ+El9/PeL+WDPzGw6IF7hH2QvaRN7/yNH cZA1A1JvOqCKvsmcXu1zKyyBvHgcFaPt1D4rhFO2/CHWLUqPQO0FZrgFCDm352nMdCLcYe78Q JkmshxuN65PRVMd9Z/7f/DbnybESIZQLHbTtcOg5Eae+vrcP2LpXsaIjlBRpaMrHhT0nxDy1+ 760ojtvx1Yyp2md78JJa6MjzB+9J4qn11p9ojClg9c6Mz1plyvSEA3LFvULmj0LZhVdrbn+9R cr/AJDIacZWYCplj/oL734uh2vlgY2VnoG5m4ZLHwMAJJxLW9ylET2oY3498EGFlrBIQd6oAr UcBfTL6FVEMVAEg1b8fvxFzuNzLnFs/0WAy0lhCwfU838RYJ+GFtxypngaM+RjPu1BwvKGMim Lqrk9pi0SvPvelXm3ioYc5EpLI2YZWTZz29MthDvjyJVVeWqPMkgLMMnHSqSlZdRYGqexOfZF DZLzBnLh5QFc0vW6z9nuGu9CREvE1CUfamx5CsgqVnGkoCoqE9LSdgb11XhqowbLhNd4ctZ9u e4Y02boj5sXYy7cTkmfr+2yX08ESHwrrWDXs6hk/2bkiOQ8rOj4Y5MJe4IeDfwYIM9pKGSsmd EENAXpCACatGZu7c7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Philipp, > (defun tramp-process-file (...) > (let ((code (...original code...))) > (if (> code 128) > ;; Probably a signal > (format "Signal %d" (- code 128)) > code)) I've pushed a patch to master along these lines. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 15:53:28 2020 Received: (at 41099-done) by debbugs.gnu.org; 9 May 2020 19:53:29 +0000 Received: from localhost ([127.0.0.1]:48415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXVXM-0006k8-NZ for submit@debbugs.gnu.org; Sat, 09 May 2020 15:53:28 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:33816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXVXK-0006jm-CO for 41099-done@debbugs.gnu.org; Sat, 09 May 2020 15:53:26 -0400 Received: by mail-ot1-f41.google.com with SMTP id 72so4383463otu.1 for <41099-done@debbugs.gnu.org>; Sat, 09 May 2020 12:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zvnrs81opJwXQEVe+2uJo9X0vuBn00kScJ5sfsRB1sg=; b=iWDlOijKPRSLXsTpCZSnb4PCw6MVeXw+tlh/BvXKe/4ZS6fO7RrQRqXa2GSL3OVbhG +kEVR+xxJFUrCr7sVwYUFLwwGvpRMFd2EPz1GVdyH7jdeoXA7Qxqk09GGOnDHPeH9trI qlZaqYndAcvMJ7ETCh0h53eaTgIpprpA/Uc889n5QaxpKT4LEzSV2rU0/kN4GbQPU7QH wZLMnxeJY9KZjjoj5oCW0vVpaxY8kkoslyduXW+tPo9+wrOUqEjyUt/rMhFX9cJgEU5c QsdWHZ/kaoR+cRUt+dpH9HtGxU5pZKY5x7xebylW9aa3Ci0Tnbi0NGOA5GL8Dh/BLPBR fsGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zvnrs81opJwXQEVe+2uJo9X0vuBn00kScJ5sfsRB1sg=; b=CJ4LB+0bE+LJSZMeEOPmdQRSldNV9zNcfBcSjtCtM/No+qYreGiNF7qTusjJYNHzsL 3eSBX4YJ4pMhoQmBvmOqP6o4HfVgYUR62Pkv8ynCSFI/jNj+sH9a/wUOoO9h2ivtNBwG 8BsSjqg3c60VHHdwi7rPmDFuYf5xC5teCjJ4lRoVnGrP+IstwBtCqNXtnXsVvGRjpVmV pJ93C/R2aJZrJ8wALVIfLmDN/R1ammYgKGKDYq/ZPVRKME4qPYYYIccCXv49QDoS22Nk sm4z5YqNd3CtKJYZWCnycFihULEPCTfy+7ywNvxlDIQCOO/bhAG83UJO/huyaaeBThBp LgFw== X-Gm-Message-State: AGi0PuYMvIAuoIxYoCWIYIZaByAn3axrfaZGCvX3oiwWU16QE7aifK15 BCYC+L1uENTmMR3b5Z4oVdPWfVWH/qNXRWknyng= X-Google-Smtp-Source: APiQypLhDEhms2fQmAjBmg6f4bY+M2vJ5pYwRgeBn3sZSAJQkgb6lJFPGF5nrV3tcnZrlCV788TDa2sjKNokaS5AGI4= X-Received: by 2002:a9d:4c88:: with SMTP id m8mr6480750otf.149.1589054000282; Sat, 09 May 2020 12:53:20 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> In-Reply-To: <871rnwrvvn.fsf@gmx.de> From: Philipp Stephani Date: Sat, 9 May 2020 21:53:09 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099-done Cc: 41099-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 7. Mai 2020 um 10:29 Uhr schrieb Michael Albinus : > > Philipp Stephani writes: > > Hi Philipp, > > > (defun tramp-process-file (...) > > (let ((code (...original code...))) > > (if (> code 128) > > ;; Probably a signal > > (format "Signal %d" (- code 128)) > > code)) > > I've pushed a patch to master along these lines. Thanks again. From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 21:39:42 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 01:39:42 +0000 Received: from localhost ([127.0.0.1]:59922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZ2qc-0008LB-Is for submit@debbugs.gnu.org; Wed, 13 May 2020 21:39:42 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZ2qb-0008Kv-82 for 41099@debbugs.gnu.org; Wed, 13 May 2020 21:39:41 -0400 Received: by mail-qk1-f173.google.com with SMTP id i5so1471925qkl.12 for <41099@debbugs.gnu.org>; Wed, 13 May 2020 18:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T2VRXu6FVgNupV0y1V0rgt+0Qa7X8DUUe5Q0pOKsI6Y=; b=u4REEAhsCMJhTv0OR7IN86p2FYxfv35WSQnZkatIpS3Kv5XRGVKPdNoGH1xAd4jXCf RjbDY7UstQBf5wZZsPd3/rQo1gmLUQdmzepHBy776X15win3O3M+3/8wDjCDIC7yIqNg s1Z58LPbaBNXjVALHMdE9ynQ7Sn4Xc0vu5ckbyYWKpkVN6JW4MQuIezgTbc5NBuK7JeK cjpAYTJgk1yoW08olILJJ7LjMfpV+nim9ug8BUqe9ga2XDQGMQpCk80QbR2wef2cvMoB f2jw4E5wzfu/LvxikiJF2F/wUyp7K8iF47uT167T5/eJ0iNPl87ukiUkAtX5jSxkYQ/V c9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T2VRXu6FVgNupV0y1V0rgt+0Qa7X8DUUe5Q0pOKsI6Y=; b=oKnFiN+MQ6N6HiyC3wAiPXhDKIqpSDAVLDmTz9QzYjq5Z7S06py4qk2ehQglq8hjoq eX4MNlfUfAr41ytx1WqkqkU++Qi9UO/hnMY2eXlMLh1PjLDnbsY0s3N0VcYnautWNm4j w6auJ+LDCoURRE1yF7oNBMRgeFopRFnf1nSZo52lKep1sqIM2x9ufbDSxjg/0ITslbby ZlD6d62psjqp1fOnezJIZXmLMmzhdMx+XgoVNUcBmXIBrrqlIc1cA2N4Q0Xxb4zpMQ9s RJZxUD8SQThRyoHHkKd3SBdGGNROgBit3DNJLnYmr+0prRahvPv1phlhtOruf1jDan/M iU2Q== X-Gm-Message-State: AOAM531W5IIrbqhKLP3NAKAbN1GG62HfHd81xU1lUJzxSGR74P4RopTM KNKV+uvfVx11gYSb54caeJ8hE9L8 X-Google-Smtp-Source: ABdhPJwFmfB7rzozpFh+e4Uj5hAvrBEtPbA4q2faKMyiXXrZMrolIC/C+WHzQb8fbBfIBCW72ghjNA== X-Received: by 2002:ae9:ebcb:: with SMTP id b194mr2601028qkg.391.1589420375524; Wed, 13 May 2020 18:39:35 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id e28sm1438267qka.125.2020.05.13.18.39.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 May 2020 18:39:34 -0700 (PDT) From: Noam Postavsky To: Michael Albinus Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> Date: Wed, 13 May 2020 21:39:33 -0400 In-Reply-To: <871rnwrvvn.fsf@gmx.de> (Michael Albinus's message of "Thu, 07 May 2020 10:29:16 +0200") Message-ID: <87v9kzl2ga.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41099 Cc: Philipp Stephani , 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > Philipp Stephani writes: > >> (defun tramp-process-file (...) >> (let ((code (...original code...))) >> (if (> code 128) >> ;; Probably a signal >> (format "Signal %d" (- code 128)) >> code)) > > I've pushed a patch to master along these lines. I don't think this is sufficiently reliable. With current master: (let ((default-directory "/sudo::/home/npostavs/.emacs.d/")) (process-file "git" nil nil nil "merge-base")) ;=> "Signal 1" (let ((default-directory "/home/npostavs/.emacs.d/")) (process-file "git" nil nil nil "merge-base")) ;=> 129 From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 07:00:55 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 11:00:55 +0000 Received: from localhost ([127.0.0.1]:60442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZBbj-0002qB-CS for submit@debbugs.gnu.org; Thu, 14 May 2020 07:00:55 -0400 Received: from mout.gmx.net ([212.227.15.15]:52863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZBbg-0002pw-OB for 41099@debbugs.gnu.org; Thu, 14 May 2020 07:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589454046; bh=0EfmV7RHLoubh0fGpG1qXJUKlVN4i9W5b2KTFXoczug=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IyPuF8g2Iz5WZtcAAvodWeqxXWL8v76+qJRz9lfdnnYR66DEFiEuy554T0pmInmkC l7ewyXLFi+3LU7mquAzN/BTDJNZJuXsjf+MmmFp4SSHG+9DjwBRHjefm0+tXPCxQj/ 9GIiQWoW3Etf1Ew4/m6PnaucdLxdZyEtXqAvIYeE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.119.151]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXGrE-1jatTn3tRm-00YmTN; Thu, 14 May 2020 13:00:46 +0200 From: Michael Albinus To: Noam Postavsky Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> Date: Thu, 14 May 2020 13:00:44 +0200 In-Reply-To: <87v9kzl2ga.fsf@gmail.com> (Noam Postavsky's message of "Wed, 13 May 2020 21:39:33 -0400") Message-ID: <87a72akcgz.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:/AUzhbXAfxSrDTZhEDxxRK9qxSPrbHreKTqj+j7+8yDSOhFzmOh vXkApwcWe4jtgNCK6b03P7H6rC2cVsu135cuSd83yIJc3amSI3Kv5ik+M5dh8XD46oAwNq4 LzsgjfrgnbxrfQS/GJWWwrGofmrv1Rh7YTlfM6kIoY0ejOdXYGHwfzTFBMoSUSM49iQupnG eLt958EndDBlQagOq7r/w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0OR4evQW/L8=:roLE5iozWm7R0eAi5pECvf ZjcZgFjbSvOJvJsxrX2RAJBGHTAMYjTDIZMd+xMh/Uf7flZSc8vlRYt+pwlWV+G1QRl324H4z 1NZB5JgMLrs5/NPyBWn1p7OdmN9swxjKREa3kYCbRQBZifq3QRfb5M7RaS6R4MmvB5oSX3vGR TXOd8RK60HICWyaPdVkP8mNEN0c879eVU4IgvsPUsk95htjWKsY1/2vsV1LOJWFlYesmZQV/0 qG0rL0+TyAcB6ciNXeJUQerEEGrwpJRbd0agE7+LVcAhdoigrvk59sbLpt51a3vdq1SdDPm1K onP8Tyo8FUbUmuT/TQTiH+DG/9QM9+kAx71PBZv78Mf1YlVh8fQuzLAWCoMN+s/2ZpDUNJCbX KQ6LTPjUOnMBeLBcHmTzhgcDDUfGszvO+FJ2eDFrWImdo4dT5AR/PDb4Mzyhz72S1rPnxV+1H LRcFmcxBUykKTHRBfr6WRzFWBVXKl6wnRI4G+YOz4gEwGGhvNNBjRZrCmkCUSUjFSrEmkMpyM qgBqMRWsaQ3feZy9UQu9Z9uSmuTEgfSdrS6qcD/Z23R2bmuzuoOxuecE84rMNeGO0fO4xwIXi 9lFXgQ2nT3kKqxGBlg9NN0fDp159hj1Q9Q2R9spGLRgmYcsWZdJ/09j+b3AoEDNcTabSVaA+J 2YRNR3u5sZwTK3No87I9j/UcOuNuACodMiHB507IxpHIxcbEE+p8ZJb4Y/91HianKdhzHIL0t uqtbCFlhHrLMuTlqD1eJGl7Tb1n9dpnEWAUUl6HbpRnzZnCH0WITWZk0SAcRxQojn24XwnuIo mxqOG03yrW0uPEQasLixwICU/uafuTj2MqoR5BIDlmdVhq9dnpgCdUiLEV0HNtpPAAkM43JMP X048cQ/hVXZ7KwgfpCdRvbcHD3Ez9IB1J2q2+0kmlM4OHisyzo3aJLRLmS7DNTWgzzDgcXvDK 9Sseb2yERTIpvbKZM54gChote4EjfLoCS9l3l2lcy/PF39eZRElmgr/72vL3YSO1Jud0wY2G/ +b70kcirCyU39eP6uwz/HHOUtc2h3w2F8KgL6GA2xu53b53wnsOhtrtAk76cG891lR0b+kRpZ 0Mx5/msi23mrNwkKhNBB9cxRa7yd1jvSdb9LDdUqKzbEEql5QO7eiZs2voYdgawqvTNPwFm64 pV9tOINwl9+RnkJCymGU2fpjADUvUt0yX1LBN/qKXnbJbjdwg10+ii2flTvQtEkhLiXt0w3oY P2JZcP921JwNh7ehs Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: Philipp Stephani , 41099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: Hi Noam, >>> (defun tramp-process-file (...) >>> (let ((code (...original code...))) >>> (if (> code 128) >>> ;; Probably a signal >>> (format "Signal %d" (- code 128)) >>> code)) >> >> I've pushed a patch to master along these lines. > > I don't think this is sufficiently reliable. With current master: > > (let ((default-directory "/sudo::/home/npostavs/.emacs.d/")) > (process-file "git" nil nil nil "merge-base")) > ;=3D> "Signal 1" > > (let ((default-directory "/home/npostavs/.emacs.d/")) > (process-file "git" nil nil nil "merge-base")) > ;=3D> 129 I see. A short test shows, that git is using exit code 129 in case of error in invocation, although it isn't documented in the man pages. Hmm, this seems to be a contradiction to the specification of reserved exit codes, as described in = . We cannot change git, so either - we keep Tramp's process-file implementation as it is, - we don't return a string in case a signal has interrupted the process, - we install trap handlers in the remote shell in order to let Tramp detect signals reliably. The last alternative might be the best approach to keep the process-file spec. But it sounds expensive to me, and people already complain about Tramp performance. Do we want to go this way? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 08:39:19 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 12:39:19 +0000 Received: from localhost ([127.0.0.1]:60581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZD8x-0001jx-Cf for submit@debbugs.gnu.org; Thu, 14 May 2020 08:39:19 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:33569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZD8u-0001ji-T9 for 41099@debbugs.gnu.org; Thu, 14 May 2020 08:39:18 -0400 Received: by mail-oi1-f193.google.com with SMTP id o24so24394662oic.0 for <41099@debbugs.gnu.org>; Thu, 14 May 2020 05:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ftnPvIZduXGLLEjBn+rXBPtVmRSuiXfLCyjm/nSSUrM=; b=X3tnFnYzIjpX+lyh8l4dCn/Gpi6Oy2Fmk7kUt2nq8jqaV0wq1jd4108jpaUeaAOyqY GFm51y6aRFgBMfD5LUMITMuWJfnnCFEWqH1woI2TNCHZJ2cgHV3O3OhXfvO0zJBVhM1w es7zQ2agCeQovvJXX0CE7kzknkNeScFzuxUdWDL5nOUI7dLIlDR5ElJYx+jUKyocBd1a e1Q01eLn851z05gVmf6WIMZEs9mHodvuMMuDOJaSEfqzIVvOAdKdT7Wj7nxrkJ73FmH2 N+ATgXZ8mw3knGuznJOe6NvymR323RDAMP+jvF80bKdKKLak/+X6JmCPRu/FFs5ijts+ D/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ftnPvIZduXGLLEjBn+rXBPtVmRSuiXfLCyjm/nSSUrM=; b=FaknHjdHOcF/rY4qLp7MPLr6A+S5XacF/TI0e847t1OQII2BHBztVH+s6g22znw+iN 1CSs0LnQsxSTGcSx2iOHUMcuIFnkEXhJETrqixZrC9yWdoGegxlKx8G+cjwJziIezcBa opAyfxl5mUMWWJfVASP6KenY/OdjX94fD+8XqKZgpPz/2EUpo2Amad7229GzCgsQlhvz RGvXVl7lOfzLDsOYRiDeK7P+vIQts7S81McrtcDnMJhrpv6sT5cCvuzLloTKP8cHgWXR EczK+yb8qmPIRH8t+j+mBE+Cfmt9FhaZA8kC0aWU7WGAl8ZsdK67UIBlEd5jKCbOzxSA q8nQ== X-Gm-Message-State: AGi0PuYWPAoX5uhzHdvPzFxFVWxIBkTfq0VaTvQvg2g46VihjLcs9OL0 UEhAlR9kHLw0YG6HtdxTmMpiPF+msSfgViZaqDM= X-Google-Smtp-Source: APiQypLdJa1WE57nXef8xOpVXMJnZyexEC6qUvG3s4/cfQvzXYhnsq1tkc0NaJMhSWcoYumM83xs/I8Jsq9W3iuv0Ag= X-Received: by 2002:aca:ef44:: with SMTP id n65mr8467252oih.9.1589459950937; Thu, 14 May 2020 05:39:10 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> In-Reply-To: <87a72akcgz.fsf@gmx.de> From: Philipp Stephani Date: Thu, 14 May 2020 14:38:59 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 14. Mai 2020 um 13:00 Uhr schrieb Michael Albinus : > > Noam Postavsky writes: > > Hi Noam, > > >>> (defun tramp-process-file (...) > >>> (let ((code (...original code...))) > >>> (if (> code 128) > >>> ;; Probably a signal > >>> (format "Signal %d" (- code 128)) > >>> code)) > >> > >> I've pushed a patch to master along these lines. > > > > I don't think this is sufficiently reliable. With current master: > > > > (let ((default-directory "/sudo::/home/npostavs/.emacs.d/")) > > (process-file "git" nil nil nil "merge-base")) > > ;=> "Signal 1" > > > > (let ((default-directory "/home/npostavs/.emacs.d/")) > > (process-file "git" nil nil nil "merge-base")) > > ;=> 129 > > I see. A short test shows, that git is using exit code 129 in case of > error in invocation, although it isn't documented in the man pages. > > Hmm, this seems to be a contradiction to the specification of reserved > exit codes, as described in . > We cannot change git We can at least file a bug against Git. > so either > > - we keep Tramp's process-file implementation as it is, I'd (naturally) prefer that way. Exit codes > 128 are nonportable, as they don't allow shells to detect signals. > - we don't return a string in case a signal has interrupted the process, > - we install trap handlers in the remote shell in order to let Tramp > detect signals reliably. > Maybe I'm missing something, but I don't understand how this could work. Bash trap handlers only catch signals sent to the current process, not to subprocesses: $ trap 'echo SIGSYS caught' SYS $ bash -c 'kill -SYS $$' Bad system call: 12 Note that the trap handler isn't executed. From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 08:50:28 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 12:50:28 +0000 Received: from localhost ([127.0.0.1]:60601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZDJk-000235-BK for submit@debbugs.gnu.org; Thu, 14 May 2020 08:50:28 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:48748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZDJi-00022t-6p for 41099@debbugs.gnu.org; Thu, 14 May 2020 08:50:26 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49NBGS6PsMz1qs41; Thu, 14 May 2020 14:50:24 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49NBGS4f5kz1qr57; Thu, 14 May 2020 14:50:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id fxwuPMRlESnQ; Thu, 14 May 2020 14:50:23 +0200 (CEST) X-Auth-Info: eqfDM6Nup47tCMznTBENgIlVr+WTvRFkgPp14z73aQSClAsTycKaygCdjn9Ei5kE Received: from igel.home (ppp-46-244-180-168.dynamic.mnet-online.de [46.244.180.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 14 May 2020 14:50:23 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 507FD2C1E36; Thu, 14 May 2020 14:50:23 +0200 (CEST) From: Andreas Schwab To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> X-Yow: I'm having a BIG BANG THEORY!! Date: Thu, 14 May 2020 14:50:23 +0200 In-Reply-To: (Philipp Stephani's message of "Thu, 14 May 2020 14:38:59 +0200") Message-ID: <873682y92o.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 14 2020, Philipp Stephani wrote: > I'd (naturally) prefer that way. Exit codes > 128 are nonportable, as > they don't allow shells to detect signals. This is not true. An exit code can be up to 255. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 10:07:36 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 14:07:36 +0000 Received: from localhost ([127.0.0.1]:34278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZEWO-0004kx-9q for submit@debbugs.gnu.org; Thu, 14 May 2020 10:07:36 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZEWL-0004ka-66 for 41099@debbugs.gnu.org; Thu, 14 May 2020 10:07:34 -0400 Received: by mail-qt1-f194.google.com with SMTP id d7so844382qtn.11 for <41099@debbugs.gnu.org>; Thu, 14 May 2020 07:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EbO1SZLMvDZSU30R+ksCorDKnuMkLb47jca0tzWn/N0=; b=BvuNS2/l6viC+v8dAVdFWeeoh3RECkYNe2TUkrjDcoFA2oCWPL3qhfCBMn3OeDN/n7 CFUQSxOd0YL5niquYJUxkMmJUXOkWUgaJxjjktM1LNr9LkB0ilqV7i3G9MLbyEAvINv1 eABGxQxzXNloOteTHaSsivfXUxZppjdWNurQjWmprkepult1s7XPJStlVTOCSmf6KbGr UdJLwyfIIY6OcqMk9R7QrLNX/W4iynfLpFhrsyLfwYyJT8Kt1x0Tjbs/8OlErLjN/SBv KlDvrbBjQnQOF6rs4SX39GeD0hnoTqBVWoxdL92sUwMUBnSklx67vNJgFgZ9r8EoQPjk 0seA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EbO1SZLMvDZSU30R+ksCorDKnuMkLb47jca0tzWn/N0=; b=d3xQCmXS78y0h2V54UWabO63tQ6QRdkbUcXiAknbZR8dmriBKCO9RD7UHl1FXBbKlP tPgnF+kSCXyv03xd78NJmzpULMZ0Vk1B5gyBK63MSaQrCWpB9c6VXilVSo+qfV5T4g18 N2nQBNf6hUsi98BQaHTrCJ3+f3u0p+JCAhCaCmpJI4CGKffr/tvqfTrfi7a1IEN3ugwU EKK1OuhNb66tGzN0u16a0alcTOjEr04erQrskLScJmKY+nEDkc5/aa16hf6lw9aVeXH+ bBtqH+WiyJm2gal6qxhrkS4saReQLdY3d04INCkHb5hhFtdOPJ4D20kETJARE3ami6FI WjEw== X-Gm-Message-State: AOAM532xmB2uNaSVfaGOM1oW8PZ8QRqvn0Lmb2bI9zLUqP0Ouwjz8mSQ G4L3ZX24Ki2sBB9vjBOmbcj9AwZt X-Google-Smtp-Source: ABdhPJzpDhR2msDYhAG2qz7Gi/hAe6vgOQqfk2epUrw0O+LOteABBy7hjbfSoIT4Risvq7Sqbgu+cQ== X-Received: by 2002:ac8:668b:: with SMTP id d11mr4506379qtp.285.1589465247064; Thu, 14 May 2020 07:07:27 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id g20sm2577573qki.75.2020.05.14.07.07.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 May 2020 07:07:25 -0700 (PDT) From: Noam Postavsky To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> Date: Thu, 14 May 2020 10:07:23 -0400 In-Reply-To: (Philipp Stephani's message of "Thu, 14 May 2020 14:38:59 +0200") Message-ID: <85zhaafw4k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > Am Do., 14. Mai 2020 um 13:00 Uhr schrieb Michael Albinus > : >> I see. A short test shows, that git is using exit code 129 in case of >> error in invocation, although it isn't documented in the man pages. >> >> Hmm, this seems to be a contradiction to the specification of reserved >> exit codes, as described in . >> We cannot change git > > We can at least file a bug against Git. > >> so either >> >> - we keep Tramp's process-file implementation as it is, > > I'd (naturally) prefer that way. Exit codes > 128 are nonportable, as > they don't allow shells to detect signals. I don't think this is a correct description. Bash has the convention that it uses codes > 128 to indicate commands terminated by signals. But processes other than bash (like git) don't necessarily follow this convention. The shell can still detect the signals, it's shell *scripts* that will have the problem (when running commands that use exit codes > 128). >> - we don't return a string in case a signal has interrupted the process, Since we don't have a reliable way to detect signals, I think this is the only viable option. From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 10:48:41 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 14:48:42 +0000 Received: from localhost ([127.0.0.1]:34401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZFA9-0008Ac-M3 for submit@debbugs.gnu.org; Thu, 14 May 2020 10:48:41 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:45341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZFA7-0008AM-Eh for 41099@debbugs.gnu.org; Thu, 14 May 2020 10:48:40 -0400 Received: by mail-ot1-f53.google.com with SMTP id c3so2502359otr.12 for <41099@debbugs.gnu.org>; Thu, 14 May 2020 07:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WS9SsGM2APEGhKLrwYWYU5RFWJwIWj67v9qhbcf5RVE=; b=vZ0U/GEBEGF4DBPrwhl8oWu036VQCFpaIrzaWDvLmNhmRM3IlNKwAqEDE5ZQmHZYcb ITkrN7vbMQZWFKU1nFopW9TA1NFXn0uBZmK2xTrdGx1wD3oaN0WX/4eIj8kxxl/VzOP6 l8KROLUjnoalRvemNQCve+9wDV3N6rDWBEvN6vmjwK+UefKOCvm32Lgrb6JSMjy3Arx4 xqHu5bZ47HTceQNXd6V47llBjX4UY3OowtD/cgRfypQfVLMm7qPAWb9mph+8bry1U0qy XiLnK9qkuligbokuISDsoq9QLqbEttOZOOni8b4YXSzogHreX1FCqPPstjQTszOrhzor qncA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WS9SsGM2APEGhKLrwYWYU5RFWJwIWj67v9qhbcf5RVE=; b=H7RqPS1y7fEw1Q3CUily8V6hvsxAZBeDrx2GlIRqgiljTayYgiHiZ61LX+oCAJ29ku eIpGvW/XNZk1cupN6bfPBzz3mWCMqnJyX1BoZIu7b+O/1dJU9DgbbLDZc7QMZdmbU5sg A6biyJYfRGbdYRzR0IlG+OFng+KBv1GC5TCR2WsgayeWGBhve8HV4R1ONcs7bfSMPGYv 6j1JC7+Tphs0EX+49RlBUiVRJ5A55g3LIg5i2aLit8bGqKno1JlgumylZ7h528Kwq9Fn etLiAKK6kyBD/xKqoSE9s9Ho+4UicBbpCtnSOnJf71QYUcoCoRxg5O0KI3whXj9hS7BJ bhhw== X-Gm-Message-State: AOAM533yX2yqUmtOfyWTarL6EAGq/tTLsNC5Zs8QzVbqFUKg6TM35TB+ FlNnNdhwV1+CqfkAtti1rLI/FawQwqednzHNLdM= X-Google-Smtp-Source: ABdhPJzJ3507V6WbTOctQmWKXYyFAWjGRpzVmDcN0YwlQnCKxKbD4b8CMDQHk300+rD1+laEN32y882UhD/zJRHVBCs= X-Received: by 2002:a9d:4c88:: with SMTP id m8mr3470439otf.149.1589467713476; Thu, 14 May 2020 07:48:33 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> In-Reply-To: <85zhaafw4k.fsf@gmail.com> From: Philipp Stephani Date: Thu, 14 May 2020 16:48:22 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 14. Mai 2020 um 16:07 Uhr schrieb Noam Postavsky : > > Philipp Stephani writes: > > > Am Do., 14. Mai 2020 um 13:00 Uhr schrieb Michael Albinus > > : > > >> I see. A short test shows, that git is using exit code 129 in case of > >> error in invocation, although it isn't documented in the man pages. > >> > >> Hmm, this seems to be a contradiction to the specification of reserved > >> exit codes, as described in . > >> We cannot change git > > > > We can at least file a bug against Git. > > > >> so either > >> > >> - we keep Tramp's process-file implementation as it is, > > > > I'd (naturally) prefer that way. Exit codes > 128 are nonportable, as > > they don't allow shells to detect signals. > > I don't think this is a correct description. Bash has the convention > that it uses codes > 128 to indicate commands terminated by signals. > But processes other than bash (like git) don't necessarily follow this > convention. The shell can still detect the signals, it's shell > *scripts* that will have the problem (when running commands that use > exit codes > 128). Yes, I mean scripts here. (TRAMP essentially runs a bunch of shell scripts.) Since Unix binaries get invoked from shell scripts regularly, they better behave in a predictable way. Bash scripts will regularly assume that an exit code > 128 means termination by signal, so these binaries are not portable in that sense. > > >> - we don't return a string in case a signal has interrupted the process, > > Since we don't have a reliable way to detect signals, I think this is > the only viable option. I'd expect the vast majority of programs to avoid such exit codes, precisely because they would want to allow portable usage in shell scripts. So I expect that the current behavior in master provides the "correct" result in the majority of cases. From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 11:49:50 2020 Received: (at 41099) by debbugs.gnu.org; 14 May 2020 15:49:50 +0000 Received: from localhost ([127.0.0.1]:34531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZG7J-0007uL-So for submit@debbugs.gnu.org; Thu, 14 May 2020 11:49:50 -0400 Received: from mout.gmx.net ([212.227.15.18]:40639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZG7H-0007u3-RV for 41099@debbugs.gnu.org; Thu, 14 May 2020 11:49:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589471381; bh=IYt6q01CdZT94BvTSGPCOTK0/i3S2XszuKg/691FdGE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=gf+CulKKewkR9TXUm5lCH2AMTcPyOIG8FkEd5MTcEofcap6xRlFoxmk60d+DE2Qwn bvcxLBTNZCrRNlOz471EE5cMYMSFL7vTJHiup5JWQia5wphMa+pHft0DUAkMYrQDNK 1i9ufUupFV4ATZ6smU8q+eGSKfAJ1Pf5eFlmUdxA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.119.151]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mf0BM-1iu9vz0EDy-00gaYd; Thu, 14 May 2020 17:49:41 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> Date: Thu, 14 May 2020 17:49:40 +0200 In-Reply-To: (Philipp Stephani's message of "Thu, 14 May 2020 16:48:22 +0200") Message-ID: <871rnmjz3f.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DUfugTiDA1m7/vYC2lMtjzDX46ee5o9469hM5RKomYMZbo+pv6z 0yus8OQbDHJZi1bxSgDY3mUd+NNvI+WaBtGct9jMYf3mMW0rWO4IaEGoP5KOJu2NpVYie6P k1zRIT10W1CyWSqGOHNeN+oTt5AZ3cx32JtuRHC85cojlHRJ3nMIpj1+XDBzdAzWdmL8fFL lluy49MuE3gZywpI7db2w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3/Q8I0xZ2lU=:qop0fOm1aj5VhuJlXymTNx zFjw+Nv2/JrRo9meTKSx7hcumYUqgtNsZzBwDSx4pyR4DDLGDUMfHIyzhtdI0apn5NG4HoyDr JdWSUxCvu13BeaoGIua0b04WljtmAPwFSAjGlsLBN5EQwUSr+3nvjbWsZ8PSxxXXLwB3yZG4y xKiHko5xlbxx0GJc0Usaq/1ZNCjIguaOtnk3pH/cSeSzkJRE9CRNRJ//y0Q3+BXV2VB7r+EGd BRq0h7YNtbAu0qkhPMItciWLzWN+BDINkkAFt7oefGkDcu2HXzVPyxy+3o6rm4al2nF8/+VDW MzPR85Y8nZm55Y2sA1CCMGjEW/WQZIirq++HzIrryVH0mr+vLtf9PgDVKR5E3/sJu3A4GDKNk gv9YFGLRN/dD0EZsXL/PiNCEHtgu6vIRxzkzzGV+CgtiFInM1zC2Jkru2j198ymPri1x3HQYw 8k1SsMyGsKjVqRqtZwve+1uocj6oc5/6B5h9xtFYr/t4h49U40080cJlDwYHXxjYGwaaXSGAf xhJjuKDXK8skiUDzhruZ45AnQc2VJ8C/zxcQabCGwy3/C5KaYRlXrDUVVpIJUB8m/FqEAMqmc zM+DiETmtZpMTV3fQLkHIXo8mtNwbLqeadxy3sQlEcO4zz3WHp30OCUh0DtmCsee52iB1WhPA XWwHNcSGQSVS+0DMkCZoN1dEZiMoq6sZPVXyYleIaAp/WxUFiHBL/w2taxY/V6lxHSP+aK25i UCOR/LhZd8gWH2oGDSH7V86Y1x4ehweum5W2mpWqOYZwq5Bs50sAwAs+yO/19askn+zsQ67Xd klhNpFZ4KhLr2WFpBeUDjMmiHbF/3covzZCqYE5uI3gbznRRGg1MYtEgSnxggTpPU46kaTv6H eQwvI9zZ7eKyJIaiUMu1rXxQmvWzaPSnArxH5hN4i6LWCMt7uTk18cI2zkSOP/Llh9m4B1kBJ 0S3z1OiNbSOs7EE3T84oMmgWK9uToT+im5iAmNeikBMKGG+fcGwHIPyhp080eyebtTT3ZhvOs B2vZchIsZQhn25yIRo8GMBmA86IPzfpYRDfqJ1iGlAZ/WMb/+ZL5xNgS2vXcb6LyC7nll/Q+R YUC1DcnOcPNDEQUmxc81bTwkoA2OW5EyIBFyCy+yUbMSd6MHqvEJjrqjmuo8wlOwl1tSYE1Ew jCK1xz8Gm0ZJDYaZb4QkFxF4YfXkmpzbIeAAyfC38sBp+VfU+qhnWwDGiDAAVI9uRF/6aHTnP CZ82k58/SeceinqiP X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Philipp & Noam, >> >> - we don't return a string in case a signal has interrupted the process, >> >> Since we don't have a reliable way to detect signals, I think this is >> the only viable option. > > I'd expect the vast majority of programs to avoid such exit codes, > precisely because they would want to allow portable usage in shell > scripts. So I expect that the current behavior in master provides the > "correct" result in the majority of cases. I understand (and sympathize) both positions. However, Tramp has returned for decades no strings for process-file, so I don't expect any code in the wild which expects this. What about a user option, tramp-process-file-return-signal-string? If non-nil, it returns a string when a signal is assumed for exit codes > 128. If nil (the default), the exit code is always returned as natnum. This would also fit the principle of least surprise, because Tramp hasn't returned strings since ever. A better variable name would also be appreciated :-) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 08:06:37 2020 Received: (at 41099) by debbugs.gnu.org; 16 May 2020 12:06:37 +0000 Received: from localhost ([127.0.0.1]:39948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvaP-0002gq-3i for submit@debbugs.gnu.org; Sat, 16 May 2020 08:06:37 -0400 Received: from mout.gmx.net ([212.227.17.21]:55473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvaN-0002gc-8Q for 41099@debbugs.gnu.org; Sat, 16 May 2020 08:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589630788; bh=kNY9jAvKy4Etuo+/JVktYfnp4TMX23mZoGWxiFnKZjo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=QIHCt64NfQTMAPxD+ZvAmcUcv797megErnaK+9MEH7Bbb6D+S92N37XtpLlCWVAhl 3wahfn5R64e4FZ/5rdt57QN81PlFAM9SYymRHSFf7ATRnmwYpoCdqL6xMnybv6pnif p8SMJm4jDpWDtVsUAk13ySr9bfJl36AL4zJ7DaUM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.117.104]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MoO6C-1ilDhs2EdU-00oqfS; Sat, 16 May 2020 14:06:28 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> Date: Sat, 16 May 2020 14:06:27 +0200 In-Reply-To: <871rnmjz3f.fsf@gmx.de> (Michael Albinus's message of "Thu, 14 May 2020 17:49:40 +0200") Message-ID: <87lflsgk3g.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:5k55yBfg7cPQQEUN+KqKxv00EC2df9Z2mEU3tLJYygV6zyQBRYH cgYnAWGjcYa3Y3KY/5NyLjLvo4C7JWZtXpV/5qi4uZo12F5WVY7EfCaiBAdWJ9vwxU1VOnd TfUlb/bStb4Dq6owGFHhCs5eV07IQ/IpWd5+hDwi9eFFEL/1J5MFxtVth6TZEOX0L+i32Gf EE8uhgqyDogcV7nPgBOnA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BqTN2R575Yk=:OQLNspm3NvJ7GsH94YGCZg /5dJLB6sTi8PcX+3kMVmH+49Te12wIRXomKEkGiokMus+tbPRvT3hI8tFgMg4pSwnN5EZPj0L 7dC555gIAu+GRPP2AzqvMqu5RGPlNdmDbxb8xP4yvda8ho9sION01k7NlNeiBFoCR9ektkWPK jJjdRvVkJ13q6DPtXmBa7Y6sOXM3CuqJDOMrmpEllipoTBWg7nE6OFGWgOpi+89QSVFgHkkmA 7GgHTmN7bRDYwNgLvwypBUNkUfMWg00jgAcH27oE/Kk+EXDBwyyvJ45Soc0NE6O510dHFcYQT Rz5PGnWiFEVDgjTwNRgbt+PG8MT41Eway+swd2ytW1rpSVPYeh94Je0WBGyqrSN3qMotf2HCt X9E8ZWxjMsLbx5f5Z5xTietlrjLM8nOf2/7mLmmrCVg+BV54v9MRfvy7eU9XwEjKZeTsroYcp uvqxkb2SUZG0iJlnvPujr9ieJweF2X0zJ0P5nUFllmKq7ijVgtq7iiOGt8w2dYuOLLXMwd48S ucMZikGVoWcGNhhYwXL/DjzZv3AaD79IlS/tOFruZG/8FPRosQUqfSkbYShAeee3Ot2kWe4Ae 3fPTb5c/Yt8iKA0ApDqXAY26uMGNQUauVhZmqXmdwz6JG8yT6YEXpfx9zCU7Jk9OB/ZmmwixJ fTRmrRjG9cVRPFMnesvu3s4I1ngPqsNsCQTaJzEwZLMZGGgdFYW56pHbfXVCoqeK5emI3+jgs iumunTLSTpL10kPe21dgoVjJ+mPDIa/Eea0vfEbPA0f+QPHnFplAzuXVxIVRVT9kvEjdDuZzQ SnjwE1KpkctKmG5qYNqUkYlbhDoHfLmNR1M1w0E5AetZU3POXf5YC0VV2BHVmRPfBSYWTLzKP eLofBsebL8hqYi7STpW2wu5uF2xqGlUxWYLWrrZQgj3QYXSfbjHm6o9eZV96nY6v6FVG93mim 5jPb4OpqsfCJfso+dmL6s8Wjgi211uGMdJObF+vbDmiX/MVTVKG5TV6+wjgS3OFK9cpw0zM4k R2YbVBWRoFHoVutK06rCXTiWVKwa545Li1WB0XNSd6Ee0rc0uUDeXc/8jOzOcRP/QBUumQ13M YPFCCP5/dTH7HH0FVisZcXnGCQUHnUM+R67eyn5Cc61HR6JgZDtyMUxR2roW0qYV6aIWALUjX oYa8VDyuebkJfhn8heU51HS7ZfydBK/1I/Spy7+kCppEgVDS5RoPVsZ+UgvfNcPP0A9Z4LWt0 hs3WQJYQsfk701J2q X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi, > What about a user option, tramp-process-file-return-signal-string? If > non-nil, it returns a string when a signal is assumed for exit codes > > 128. If nil (the default), the exit code is always returned as > natnum. This would also fit the principle of least surprise, because > Tramp hasn't returned strings since ever. > > A better variable name would also be appreciated :-) Finally, its name is process-file-return-signal-string. Pushed to master. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 08:11:40 2020 Received: (at 41099) by debbugs.gnu.org; 16 May 2020 12:11:40 +0000 Received: from localhost ([127.0.0.1]:39952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvfH-0002oK-Pe for submit@debbugs.gnu.org; Sat, 16 May 2020 08:11:40 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:39830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvfE-0002nq-PO for 41099@debbugs.gnu.org; Sat, 16 May 2020 08:11:37 -0400 Received: by mail-wr1-f41.google.com with SMTP id l18so6450336wrn.6 for <41099@debbugs.gnu.org>; Sat, 16 May 2020 05:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+NNSbYdzog3Rh69NwC+JFg9m6pBd0jqobHE6R0SZtM4=; b=tM4ZuMTujYQ9glxfZP24aPT8hdo57N0WlQNjOa+iLcZH4lEQwqx+OyiCaSXVPgVa8E vvRvYpciInFOzVVxQ2gx2JAnNG699qeXn9uucCdCMT0xIT8aiVNGPwdZCGQCTbprn5Tf qVFYOiIXzwbRHkj0gJBMJ+zqVtjNofe3skuTcE+KPsJJPFHzfn1hUM65JE2E1qszEz43 V/ggjF+jcbFKSLi+QDtPv6gWqe353W1KerkTaZrg2NnoiSWuacDZGGv61X8CelOOYGTC 9wzFRNIlwiOTHw+Fs+bsxfaWiweTpos6AtX6tV4RgLLnH1SwqE+IVJLsIlVVgICJxVV1 8fDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+NNSbYdzog3Rh69NwC+JFg9m6pBd0jqobHE6R0SZtM4=; b=PuJoDJ0i9lrVSlR82WdQww0+gCidj4LTllqzeDFGhIyE0zWOyUqWoLCiurMSB6vv/d KpIkaAmk+5d6giT+C70ppt6ifr/m67qsPBM7efV/w/M5ef6M3BAiler66pHzp14nnjq7 7Xw4k5EPPSyycWalXDAg0+kihpZvMg5JaibEIYp0Td7uFONlSeUPHcTCtkzwk5+Xoi9V 6R6LNL7d+Q/WlEqiP38AZr9MGQlkULQ+wCwsr13wvDiwpMGYtTmzvBEvtcx1Asmpb3W7 vmfkfahhoG10bjYxDdJqcWbrR4F3rckoiH4jhYdD1fng72uFNTgDxEGY9iGJ3l0XqKr6 +9NQ== X-Gm-Message-State: AOAM5330uvfqOC9IaQqWmexwccBw2fl9W45eXX08p6rJ4JcPPfdYwVa1 VktWCexybH56bGm9blOeo74= X-Google-Smtp-Source: ABdhPJyIBZlPErxYGkRpf4wu/qD93Kagb7qrNslRGIJoXLpiP6iopDLUwBQoSTyIWyzAy5Y4hFKLsA== X-Received: by 2002:adf:f3c5:: with SMTP id g5mr9343550wrp.163.1589631090875; Sat, 16 May 2020 05:11:30 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id f5sm7873464wrp.70.2020.05.16.05.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2020 05:11:30 -0700 (PDT) Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus , Philipp Stephani References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> From: Dmitry Gutov Message-ID: <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> Date: Sat, 16 May 2020 15:11:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <871rnmjz3f.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Michael, On 14.05.2020 18:49, Michael Albinus wrote: > I understand (and sympathize) both positions. However, Tramp has > returned for decades no strings for process-file, so I don't expect any > code in the wild which expects this. But is there code in the wild that expects the _current_ behavior? It sounds rather odd to me, given that such code would only be intended to run on remote systems, but never on the local one. Is that about right? From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 08:19:36 2020 Received: (at 41099) by debbugs.gnu.org; 16 May 2020 12:19:36 +0000 Received: from localhost ([127.0.0.1]:39962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvmy-00030e-IQ for submit@debbugs.gnu.org; Sat, 16 May 2020 08:19:36 -0400 Received: from mout.gmx.net ([212.227.17.20]:39155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZvmv-00030P-O7 for 41099@debbugs.gnu.org; Sat, 16 May 2020 08:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589631567; bh=wwqhh8TluFb4uDkPHP0BL/PZN9G6QdFKcSdRawAQMeI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=S2x8IZE5E75jtoVyMR4wlvOjryvllhLNs7H4dvUzDE0onQbnuKB07s/camFCNAtbv EBax3uSUy/PVp4aRqMOCwS7G1B7bUSb1aWGekZZhhZFmmI5I8l3LJVrjnKLLgFmm5J 43CuFji9APPAexBJYGe76GI/dRztJIadHwOb66JM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.117.104]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNKhm-1jkHdU48Hy-00OoCJ; Sat, 16 May 2020 14:19:27 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> Date: Sat, 16 May 2020 14:19:26 +0200 In-Reply-To: <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> (Dmitry Gutov's message of "Sat, 16 May 2020 15:11:28 +0300") Message-ID: <87h7wggjht.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:unbKgsawtAh76wNTSUiQTGu5jpqkX9EPxaBY6+0QQJeG4T1iQZd K4dLd7M6T2UJ+aTh3LD+8/d4RI87l9kEZRaEVm47+cAyDppUvD+5sIOoIaRDRwUTdeoub+e sLuxz+SSDnux9KeODBe4ukK0ZYMq20AdAMjN+NJtrw/dhfRUwur685YjhmHxPpHn2s4I8Nf jEXAmzgXZeZxulqsBUDbg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BHGATX58XTI=:KepTWO22IMlgoX5kfb2R9r 2fgP06aw7Y2KGe4EJQ6S04ln4OhqDaoWCG6HZCm2P2GDlfMM9y7fuhL0tjWjvCWjxIbFscvOz KTZVdMht5g2f/Lla9cTASDf8zwu7Mi0VPovTclYcZXxLDsrRmIQy920ddt0Sc1c4geZ2nvTDW RGOnOuTY7Arqs4y6LEzmPD21lGKAxYtg8U+uZZ4a1A6qMx9bTowUm8syZQu+SUVB5S2kmttJB xvBJbdpYgBksZ1un5/B2HhIBJCrS0YOlyaWKsDNoEt0fogOJr8Jq4lRKj8IFX8w2VVKGWT32l SaU/Ix44Yg0aI0u/SyQKf5kERF5jXetGdz/aZ8/QdpUDlZ2uTt/nyqz3mL4qBjYo9IJ/mH7FF /NWnqHD6OHEtjPLuQDh1+fvjUyZ2hWAEsgDI62T4CmfE2yKhIIKG4CJNMpsJ3DsaYgPdJe6N9 +1l/dKjB1HGilfsU8J+iVZM8WVSqiF2oPf6vTiFyGdkP79Y0E2NSjILcb1EePx3c7XYvJNto/ Y7oXJaVtrq4rcjJcHjrbwlCa+sHrDkv/W0oO8wUr22qvlmKcWUJFHlHDbLWjxb17MY1orooQS 8UKCKgliKxfS2EedYFNuZXCh/HWSEOBdPjzITFWnjoQJ0TvyWICMSa8C2bcw9KIB6WVm0pBFk wZtxp46PXM9MykQWN8gbQCqPoHahyWoPNRMguFa1P717/o2F4RZqh28v1hN8gzipggKxViPBI EGZQk98TQfyT2VPE5sgGU3mxCY0R7Fibd8kJXvrkBzbMYThQazoe/WYovpDMSqlekaZCvxCqs tnH9Gi3uWFcc9d/bfULn/ZiNnW5ocDWzPf0NTWf/tfMxfQ5ZTa2HeFlPfxNNw5vW+imNvTIUi dOsz61YtyS47SFWov5RwnaugFOOrhsY3q65iyQNKYhc61pvvATCryR49ZylldG0/4sGH+bRc6 N/0G7GkGPORi48gAvFNhIz2oDHEhdYQ43GvfWivf9qJ2Q/zUWC9AQCFDQFvTp9owXozER6ylr CocrEeWVzbtj4Plk9Dj0hMqX/Y5iskGf22AKfrpNfMcNHD+pOWiOtL6UHQcocg8+9HB+FipYu r3Bfdkg3LTq84KhzQsEWhIQpu0YdDhHitPOO3NulNNCDJA5J+A/ln/dIzwiTkd3FwAICy4sO/ 4L3uKI6wWJcirArVFMId/5msACrHf5bbtnVlU28MLEW0IlHL0nFMCfjXcrTQNHHkEme183zu8 nshqbWTBKT9yEq9HG X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: Philipp Stephani , 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: > Hi Michael, Hi Dmitry, > On 14.05.2020 18:49, Michael Albinus wrote: >> I understand (and sympathize) both positions. However, Tramp has >> returned for decades no strings for process-file, so I don't expect any >> code in the wild which expects this. > > But is there code in the wild that expects the _current_ behavior? Don't know. But at least Philipp has reported this inconsistency, so there are prople who care. > It sounds rather odd to me, given that such code would only be > intended to run on remote systems, but never on the local one. Is that > about right? Emacs has no problem to detect, whether a local process has been interrupted by a signal. It does it on C level. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 16 18:03:53 2020 Received: (at 41099) by debbugs.gnu.org; 16 May 2020 22:03:53 +0000 Received: from localhost ([127.0.0.1]:41875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja4uP-0007Xb-0n for submit@debbugs.gnu.org; Sat, 16 May 2020 18:03:53 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:34646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja4uN-0007XO-F3 for 41099@debbugs.gnu.org; Sat, 16 May 2020 18:03:51 -0400 Received: by mail-wr1-f48.google.com with SMTP id y3so7514403wrt.1 for <41099@debbugs.gnu.org>; Sat, 16 May 2020 15:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aBkpOGuQimtv/JXG2HVF19ImZiOC5ZGiSMcOZWTEz38=; b=ALASQ9SjuqA7O2We4pOulhrSZOfwOsZNfFRRAJEXDMl1WxWgsR/U28EohHuB7gTS9w rOq2UbN8Or0lHkr5ZDAeAzZ/YaJQPuQydaO3ZNgJzDv5z+gU168UiFtGJnXx76HRqtiC l1B9J+9i0MdM/yMfqcXQDqyLXQb05fz0fgNxjfH9sRKBOyK9gXTUKwdkQYhEci6p0KCO P8G/f2zJa9hRbE+IgSol83ZLp8eysIz4lrcBibh2IogSbPoKYrqVqZ21U9+lbOvki818 sesEcgf1hNvfaB0PsD05KccZNvPQ/fW5dgHjP9Hh8FYqFH9TAlc5SKWqWUWolMPT0ZRi +uww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aBkpOGuQimtv/JXG2HVF19ImZiOC5ZGiSMcOZWTEz38=; b=eeiULPvspabjdUyaGLifCHxzkcVweGLB2aySKAzU5FShLuMUAUzF/OyTXaK9b6KJgh 4Atr0xHIOL6HrCxXshOwyv9UxhM4lEt7gUP6xR+cUq8frODNfn2arRbSN1/d9Q9bvKkK TfGvNE9bh/wsXDy2soQY+dT/RKXyAG5DU0pJ6eCAQvYtxPC19um9BPMRcq4JjKNz8pAr 0amwzEjOV1XmKQJU/n4SrUB9fes34uJyUnRQWTu2jEirHtSL1qo+/8g/8hlaQu31UJLm 9YVM3wzWq+LABn0qKHES7eKR29yKQ1XOTqOoTtz0fXCgiKq417LEDp1hX5a/uhNb+tK3 PRng== X-Gm-Message-State: AOAM532prOY5AXP8l/vj2hqAqJrZwWuLCKGegHciXmC1Kr1Eg4o8rAgc 184jVhVrDWURbLDBFNjLQ08= X-Google-Smtp-Source: ABdhPJwqOGLrCcz4SZgR+GmKnYUALy/mbyddzm9xXwAoFgmQLWMBNuFYq1lheTeo19MevPYKxQSBiw== X-Received: by 2002:a05:6000:1241:: with SMTP id j1mr11419328wrx.42.1589666625599; Sat, 16 May 2020 15:03:45 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o205sm9534209wmo.32.2020.05.16.15.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2020 15:03:44 -0700 (PDT) Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> <87h7wggjht.fsf@gmx.de> From: Dmitry Gutov Message-ID: <68ad702e-e0c4-b8d5-a694-f3b762fb7cd5@yandex.ru> Date: Sun, 17 May 2020 01:03:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87h7wggjht.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41099 Cc: Philipp Stephani , 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 16.05.2020 15:19, Michael Albinus wrote: >> On 14.05.2020 18:49, Michael Albinus wrote: >>> I understand (and sympathize) both positions. However, Tramp has >>> returned for decades no strings for process-file, so I don't expect any >>> code in the wild which expects this. >> >> But is there code in the wild that expects the _current_ behavior? > > Don't know. But at least Philipp has reported this inconsistency, so > there are prople who care. Care for the remote case to behave like the local one, right? Not the reverse? >> It sounds rather odd to me, given that such code would only be >> intended to run on remote systems, but never on the local one. Is that >> about right? > > Emacs has no problem to detect, whether a local process has been > interrupted by a signal. It does it on C level. OK, so if I understand you right, Tramp ends up doing some extra computations to get that info, and that makes it slower. I suppose this could be a reason to make the "correct" behavior disabled by default. From debbugs-submit-bounces@debbugs.gnu.org Sun May 17 04:19:37 2020 Received: (at 41099) by debbugs.gnu.org; 17 May 2020 08:19:37 +0000 Received: from localhost ([127.0.0.1]:42246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaEWH-0006JI-DQ for submit@debbugs.gnu.org; Sun, 17 May 2020 04:19:37 -0400 Received: from mout.gmx.net ([212.227.15.15]:45405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaEWE-0006J2-UC for 41099@debbugs.gnu.org; Sun, 17 May 2020 04:19:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589703567; bh=EBYpMjKxno8Y5ZY7x5OaQ5g7DV0hCnDMZUzKybRLdmY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=kLHer1pwdNxbr4OuwVFjP8r5Yi0b3jq0vJfF+HUEwnydV9e9vRo5+uSaEP354/RrM q51pUxc9WjWAPz7JecFPHWJPj8pjgBpaHt3KHq1NZUy+UfxwNEKhRMc/Fb7aUHy8Kn uF7+VcYI4Ur2IMuSe+e3Hgjw8BqFDzccVrxDQ75c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.112.236]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MirjS-1j6Nsh0Wfc-00ewhr; Sun, 17 May 2020 10:19:27 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> <87h7wggjht.fsf@gmx.de> <68ad702e-e0c4-b8d5-a694-f3b762fb7cd5@yandex.ru> Date: Sun, 17 May 2020 10:19:26 +0200 In-Reply-To: <68ad702e-e0c4-b8d5-a694-f3b762fb7cd5@yandex.ru> (Dmitry Gutov's message of "Sun, 17 May 2020 01:03:42 +0300") Message-ID: <87d073gei9.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:QvehFisymHtylQvNPla1IHJ4BGuqxf87eoRv7LOV/W/Y0Ef4hJ/ kh8y7OUE0J0DIReO6MGk7E6fe1N9l8pc5Eda5fB9KULi4M6id/X+vaVlJBkm0mEA1fJKu48 X/XHa2M6nAXfD39aUijjSDRJ1nqrrk1yZQfERWDRh3W1BYEcqsqwTcyyNzfg7ppjEemiDel xfe3Ly/sDGG06gCm2I/nw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rQrPlqkfmm0=:h+qqn9eVdIPKgYyOcMFKdK pcq+5p8I7NDFaZBPHkdFrm1JEPAPVOF2Rk1H5b5JZY1ho7G2Any4iSP+pNv2YIAGWQ0RkgFVI gBkSr1Eyki1eezvSe+02CsycOzEmtYQtOiD6JOvStOclNWGqYqQa5TsE/LYDRY1ncuZdHaS8v /7bGiR+aBKyQKe/4zQi0VGM+CCeVyZxASNCFnULJfgnFiQMvr5HZuCBO4/Kwbd2X76G+7kQHx VbQrnMGR9aKN29UPzr6Fli1jJtGkTKB3MUT9xqwFnEqxrgeuCZBvMOrqtPGj2LUO8YMgE3kD0 dngBOnV4CddzxnGfjmMbWfzUXiJ9VCxACWxVZ/qpMc4DEeHw9wFOJNRV0/pT/kZaBR0HR68vB mGEnWYb8pe9Am966PKQrUAiU/5BCHs4gLz711P31LGN+mdQ1j3kNEWB7FQvOTpMX6piVzLPaK FRK5cBq7QLHEIQS98vK2qz3XmmMreq1c5H5Kxvt1BtE8jotuoSRmL1cnvz+2K4qAd6DYIaSrM qcTlvLz++tY8uxxDAlSq41pCtNtvZ/d81UcJuamO3lndloGucbUEMM94C64S44lnW2Lmg9kOy zdbrIuODdYMutN+fvriPkI9ix1UPLc5rm9Hm2xI3POWsOK/g63qRkN5reHTM8tgU2ODxIRGnO 9Zy6aAOJ53HNAIDFpYwRn9plnjRl5y7RaDJefnPNoHKjyy/560j+IpWerq/WUJfgSEBxf4ZyN 4x9HHXFbDNLFla2jJcAyIuFI+D+hy1AsQ/WlzyvWKBX6L8hyDkPne3dV1DxReLmoW9PBhmHM9 p9wEKvaDUWY91sZBHzmuswZxj6PodObK3RxAZ7DpT2QKA912L1GMzG30QcTirPTBR9dpsHnaS OkSSjk2D5Z8p1VmpdiDberfaJB8K2cmcYvCFCs3x/fNYmTlaWjmMrad22Pc2wsVwi+CHVJAau xnUfBLQBt43umj5c3tpao30VW/ahVRt+X0REaPTHYESpjUj1XPy/5kUlsnS2qkMTWJ2eTB9wT uoP5npb+/ygpBBKn5zPIcM/44hZbtngeHtgkL9QUJFc+7EVzDqlNEOw6gD5YJ7jW8mTmDtUUn jcJ8J2svQ6AjM005biwcHhhaKPKHNz4tLox/RySqXgQz6o66mbYN2AbIRkIYFRf0vLqJDDxbr N3oQgAZaANFqXMbFK3bbmgAbqqGlHFD+/7rgKbnk+dtA+RZpJPy0GGDpbXe8eV+zUtivJJu7+ OepbOY+1beF//mQeW X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: Philipp Stephani , 41099@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dmitry Gutov writes: Hi Dmitry, > OK, so if I understand you right, Tramp ends up doing some extra > computations to get that info, and that makes it slower. I suppose > this could be a reason to make the "correct" behavior disabled by > default. That's not the problem. Tramp cannot determine reliably, whether a remote process has been interrupted by a signal. It uses a heuristic (all exit codes greater than 128), but Noam has shown that this is not bullet-proof. See the discussion in this bug. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 15:18:02 2020 Received: (at 41099) by debbugs.gnu.org; 23 May 2020 19:18:03 +0000 Received: from localhost ([127.0.0.1]:35717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZek-0000lK-Gn for submit@debbugs.gnu.org; Sat, 23 May 2020 15:18:02 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:41516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZei-0000kw-Tg for 41099@debbugs.gnu.org; Sat, 23 May 2020 15:18:01 -0400 Received: by mail-oi1-f181.google.com with SMTP id 23so11166622oiq.8 for <41099@debbugs.gnu.org>; Sat, 23 May 2020 12:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ZANf5P+j0+LpHbRwybfezIHA71CG1+ti19H0uSB4gk=; b=IPGy1Jnx5Ajfm5L27fDFGyUmVw42LGFfeiitEHqgsBk3bKaD2W+D/31sXGpVjuncqT DKulRd3BjQRrZjDnkAxrN1HUYQXhqe9iYD1h45bb6w2lzxgh0OVCE2K6b7bcijg0wAIG DSLtkkCBpdyzjVocAhLSzbRp17+Jg7tdcHjgmbLisEbCfqLvxhpAz+wg38d72pDhlmhJ oVqPsLAwwFtKjZYAwCmpVm+nOCg63/yk04i2+VRDTY+xu4ZNfaeBK0IPcUxnzJOPBE6H x2WBIVjaAruVy44HRYa3Tgjh176p7tSG91THOTj+G1GmFfT/V4XPDPPsvJKyp1t2+if1 NZgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ZANf5P+j0+LpHbRwybfezIHA71CG1+ti19H0uSB4gk=; b=bs+sRFDxQBpSpgH0eltCyqEBimDyYKQLiNYlA19otTVaDsTvzhVnNMaPihQ5OSR4Jl ko4QE+SkspbjhCTJLDhVWcNwpfIbi7KMhSr39t35rh5Jtu5WGAyW7pQkgLcycbjHet2L yHk8JiLe/2N8Ew5tW7AzYVIf4isQFmBFRhGfmpDdBcUkVY+eySzytx0uzLWEuivrt8e3 cPwt1uC9nM00wPWj7/Zn0d1vfehhbTgN7U2oHwGPKxCYFJyqoPkg+nJ7geHZVvGul+xn fgjJla849+w4DUQZ4GnBGVD+sY/KRCEcQ6zkZFbvZ9xVsCCJ4WS3dGCYk6QJT0qaD2gK 0pJA== X-Gm-Message-State: AOAM5308q1pqiuUBptLyqHgpdVMi44GVDMGRF/qeIJy9GIRoER85jCfK V+Wpkht1fKwrXvJuGKwp+1fguQ4Qfn+KqJHB1Uc= X-Google-Smtp-Source: ABdhPJzc/wJiCMswaLR8R89iaHhDTys0sB2vCUIYqK3jY0csyri812v+MCA6mp4bYeRok0aBht5hZqIiBqFmb+Ky1K0= X-Received: by 2002:aca:ac0e:: with SMTP id v14mr6708201oie.65.1590261475185; Sat, 23 May 2020 12:17:55 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> <87h7wggjht.fsf@gmx.de> In-Reply-To: <87h7wggjht.fsf@gmx.de> From: Philipp Stephani Date: Sat, 23 May 2020 21:17:44 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Sa., 16. Mai 2020 um 14:19 Uhr schrieb Michael Albinus : > > Dmitry Gutov writes: > > > Hi Michael, > > Hi Dmitry, > > > On 14.05.2020 18:49, Michael Albinus wrote: > >> I understand (and sympathize) both positions. However, Tramp has > >> returned for decades no strings for process-file, so I don't expect any > >> code in the wild which expects this. > > > > But is there code in the wild that expects the _current_ behavior? > > Don't know. But at least Philipp has reported this inconsistency, so > there are prople who care. To be fair, I care far more about the initial bug report (correct treatment of exit codes below 128). Many programs follow the convention to treat small nonzero exit codes as "expected" errors (e.g. grep: 1 means no match found) and higher exit codes as "unexpected" errors. In that light a distinction between small exit codes is more important than trying to achieve 100% correctness when it comes to signals. So I'm definitely fine with adding a customization option: anything better would likely be more complex than is warranted. From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 15:35:51 2020 Received: (at 41099) by debbugs.gnu.org; 23 May 2020 19:35:51 +0000 Received: from localhost ([127.0.0.1]:35736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZvz-0001Bq-FV for submit@debbugs.gnu.org; Sat, 23 May 2020 15:35:51 -0400 Received: from mout.gmx.net ([212.227.17.21]:38369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZvy-0001Ba-83 for 41099@debbugs.gnu.org; Sat, 23 May 2020 15:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590262543; bh=L5L+GU65jAmNLWBfwCUb8PUIm3Hk18DaLtZgp+lgmKI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Jdu32ND2XUH2VuNQ1TSA+9JXlKRDtoHSkBGSmnqUCpuKCAEWkq0cmVN93tXzkjuoJ Cg65in8ipxSBS+eCMvYG8hXDSbCAXvVQLMz24Q2cMWu3kGunizYVR93QZP84ZdTBxT Nb1O3KI0+/fT80h48cxb7jUXSOUt1mlcoHGJPyfw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.117.74]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBlxM-1jkEuR2COy-00CBLL; Sat, 23 May 2020 21:35:43 +0200 From: Michael Albinus To: Philipp Stephani Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> <87h7wggjht.fsf@gmx.de> Date: Sat, 23 May 2020 21:35:42 +0200 In-Reply-To: (Philipp Stephani's message of "Sat, 23 May 2020 21:17:44 +0200") Message-ID: <87tv06phpt.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:EwEZ8u03dAzhgVGExf7YneNBnOW00wCgj5hTooCXnHQKl+icPiD BUVMjMkC3oqbbq4g81R1L1sFZD1IjMVXN43kWtqt9a92NKBFtDi4HhdISGy/wHUpBPC3gjA 8emwutb2nqqFSjP+Wci1XNWWdvJlzL3tYeeunPGNs7D2qro1j3d/94MuS9PbIixo8LSzm4D 67a7fbKkZ2Bl1PcGlD2Nw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/PnIyPWBECw=:bW3/QFAHmkf7PlZ2NmrjrS RlTCrJ1886XvPev8beHCWhXRd9X0xeSxCU7CBUwPR4RD09SLInEA5ddQbXW3AV1mbUO2sxZ4s Kavsk2yykXRMkCADXwv5kuqqLuXXiWxMJ77qI+cdb8Fnz+GsIt7DbjNkbrPymcHMk3Lko12lS sOlUpULVV/Q0GZ4a5aXe15xVcGNI9ABchjJjykVmoAB2mJufo1EFM3HBGgvFq+PiFf78RKoPO hkCq+6dkYxLGkKge+wrF0c+Pg0pCi1++aXz7wie3mfKn59BanNla8GKiOcyGIpILe3LcrNSwY 6QxUyQbmw+dY5zw6Xdjx4/RT08uB10zinfOK+HEYwZbgkYxyl8/EUgwPz4hdwTrHj4sq7JjA/ AXYcLmpo/jKjApJIixfpfDMfEJqtzEHlDK7YzWiv6HPDRca25kbsBF4ZNkS32ExtHQlDbwegk wNbbUUlcQBl9+/onRTTGOB2ivgGEVzqbSPdefw3gzagBtlnnU7jXtB6rkZ/o0lb5OYOHDlS56 SA+Ymy7QKMyR/wntT0f+U9aXp7VO5xyoJP7dS1OZF5UrBUhGQykUIytJf8xeVBMjJaLFM1Fjd lqQjujw5q+emoL0XPzssMJWcJPxBXoOGVq79Y15VPv8gaZf21VOg6mi/QUD+Bd/MoULNFrjj1 ryZWQxHdzW/NYIwK0f2Vzu6Qgu/UbSCI2Jp0mtNPe8tY2NMqFnYVED/O/QVtOfAcWjWCqgs4w fT2D7miqQN/jrLFFBdCX2w55OU5pALcPPSlZWdNR2krzkEN6m+D4EWPTLt4CGhITZD5D73oxC Ma9od0LM81lIROg5/MtSsH5BFFwa8FYe6QmMY0gnONoj/L0fvMdGDJUisudoWbPspw91P7E+g svWYrxenw5Ffs2b6CdFciGehIYIIcPPysBO8fc3jkkiQrEux95iIUTXckMGIMCodVcDrGh3SE CGkMiPRPHSo/aXn25K2ate0xWZPvisr2tUGzo5m8wuOl1dzLJHgkrKKHkES9HJfzlY/leOdZh GQrLa61AqRoUR0NMBIJwVw1Yb4O+xw1cLRuHU8YrJT2a6d99kGb6DUh6EcrLPbtS+IaIpCkt2 L/9dfBJcLRZreGwI62dEIDAx13s7FLQ8HVuxy+jNP3XNV3d5/F9ZE3vsObMVA0bEproc4/weZ Or0aqqQbzvTQFQbpteJt4LbmLFmqC2USWmGB/2l9uuZeJHC54p4lSBzS5WQOQ8BDC+TmmquKK nmDQOGy9YbWdjyjrp X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41099 Cc: 41099@debbugs.gnu.org, Noam Postavsky , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp Stephani writes: Hi Philipp, > To be fair, I care far more about the initial bug report (correct > treatment of exit codes below 128). Many programs follow the > convention to treat small nonzero exit codes as "expected" errors > (e.g. grep: 1 means no match found) and higher exit codes as > "unexpected" errors. In that light a distinction between small exit > codes is more important than trying to achieve 100% correctness when > it comes to signals. So I'm definitely fine with adding a > customization option: anything better would likely be more complex > than is warranted. Thanks for the feedback. Since the user option has been added already, I believe we could regard this bug as solved entirely. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 15:42:22 2020 Received: (at 41099-done) by debbugs.gnu.org; 23 May 2020 19:42:22 +0000 Received: from localhost ([127.0.0.1]:35745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jca2I-0001LI-D3 for submit@debbugs.gnu.org; Sat, 23 May 2020 15:42:22 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:33349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jca2G-0001L4-QE for 41099-done@debbugs.gnu.org; Sat, 23 May 2020 15:42:21 -0400 Received: by mail-ot1-f54.google.com with SMTP id v17so11031390ote.0 for <41099-done@debbugs.gnu.org>; Sat, 23 May 2020 12:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qx7qWp8+RfyFMuwTL0waRgKKgJpR6fBFeBFQx9I3100=; b=FuOwshKw9irPpb2e1n5jlS7d6xY06brgRC9BqRedpg9E5jDWCt79HocNXVJ6B7RYL0 7P27f9ucA+07Xl923mBobvenx1i+dIlhRfQd7l1+diPYIKYi3zjr9HYcdi6Y5wEMskkv UxNz+Fxy5id2WA6JXcZzaRd+AE27jDdA/2f77WXJuv3+E/l/rpC2W9oU0zXEfxCxdYP8 fKPpmLGU/h2GoNllliuxmVxbKHMQgiPOu8Gu3gkhIRJb8+SkaibO42DI2+XGujqjinhU jeLpV9x7v7AniZlx3lmRVJUSdl2cJ7ho3X0OoJngaxbQMg/DHfukvASzh+v0MGlyKe2V ZoOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qx7qWp8+RfyFMuwTL0waRgKKgJpR6fBFeBFQx9I3100=; b=OuIlTh/4RG6Z6idmQRQ6COb+s7P4MgQOdZTp9ucQBIP06gma2tdXCFmY+HBKZGoF3C Kgm+CKiPnVR0f1advmiwAB5L+F+67l3Y669GgmRCu3GrzcfckngpbHnGhuW0NljWv7LL 3vLAYW3nPmUT22JTM15upZnRfeAdkLruSowNL9HcLDdK2+QVD/QQoUTOqghQM7tFfQYF P8weRyDn/MDo8L+k9A8ecm2rAncyh9If4tg0VSAjuGIKZRsarprpGtXbS36MfoWBIN4Z QvPPCTHQ7hN0cHKxI7smERHxeHbr/Rro5tRxb49WYyXwzcnSK2VLawzpWpAI2AmcRVQ5 9btw== X-Gm-Message-State: AOAM531bRCqdI5LgODRIRTKDsGhMsOFi0VclfHnTAfb8Mr8ZQmAMXcvW 4W44H9eKrcriMsw7Mf+jM8IVP4dcesndG9Y3pVY= X-Google-Smtp-Source: ABdhPJzndr+pxUQIjDCry/y7ATP6x/ZWZb88mI8O9RNbHjSa1WWWoC66w/tpI6eLiB33m1kfL9bbLeq2NVHTu37HaGk= X-Received: by 2002:a05:6830:1457:: with SMTP id w23mr14770411otp.174.1590262935047; Sat, 23 May 2020 12:42:15 -0700 (PDT) MIME-Version: 1.0 References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> <87eerxwbjo.fsf@gmx.de> <87zhalrxyf.fsf@gmx.de> <87o8r1rmwv.fsf@gmx.de> <871rnwrvvn.fsf@gmx.de> <87v9kzl2ga.fsf@gmail.com> <87a72akcgz.fsf@gmx.de> <85zhaafw4k.fsf@gmail.com> <871rnmjz3f.fsf@gmx.de> <63dfd032-6384-1ed0-5f47-7295cce4f910@yandex.ru> <87h7wggjht.fsf@gmx.de> <87tv06phpt.fsf@gmx.de> In-Reply-To: <87tv06phpt.fsf@gmx.de> From: Philipp Stephani Date: Sat, 23 May 2020 21:42:03 +0200 Message-ID: Subject: Re: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 41099-done Cc: 41099-done@debbugs.gnu.org, Noam Postavsky , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Sa., 23. Mai 2020 um 21:35 Uhr schrieb Michael Albinus : > > Philipp Stephani writes: > > Hi Philipp, > > > To be fair, I care far more about the initial bug report (correct > > treatment of exit codes below 128). Many programs follow the > > convention to treat small nonzero exit codes as "expected" errors > > (e.g. grep: 1 means no match found) and higher exit codes as > > "unexpected" errors. In that light a distinction between small exit > > codes is more important than trying to achieve 100% correctness when > > it comes to signals. So I'm definitely fine with adding a > > customization option: anything better would likely be more complex > > than is warranted. > > Thanks for the feedback. Since the user option has been added already, I > believe we could regard this bug as solved entirely. Agreed. From unknown Thu Sep 11 18:58:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 Jun 2020 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator