From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 08:46:58 2020 Received: (at submit) by debbugs.gnu.org; 5 May 2020 12:46:58 +0000 Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVwyQ-0005Y8-Gi for submit@debbugs.gnu.org; Tue, 05 May 2020 08:46:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:43976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVwyO-0005Y0-Pn for submit@debbugs.gnu.org; Tue, 05 May 2020 08:46:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVwyO-0001gK-GI for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:46:56 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:44129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVwyM-0007M1-9N for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:46:56 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id ABD42751 for ; Tue, 5 May 2020 08:46:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 05 May 2020 08:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=98RrR9+LNl7HeH2lGnJUwfyRrMk/ZYDd/9zA8aLpEck=; b=NR3iKNMY xkeAqlH4J1x+a2SkkMYuGQr2ZKYazcr2Ls0MzYg2j6xnlJwgkKFGr8gq07oM9Mzs onuLgESloUUPSxuegnRIgkeMVgX56w6vnAEvGaB6O9cfORjxRd4CcjljuoPbynnc O7zkbgEB9it0o1ARhlHR4bOONmsajUncbbjwwFQRhfMOowlNzuImZHSxhbf0RKG9 +PLokASrnSTwu7aHCZ1Fgv0k/JJiKdY5oe7JMTPyKHtrPWhBplXdNIwD626Wlz42 XNIqk0V0EZu84ldB4rNsbYf4bxmNdINX/ddM7wLvMu5CIgmcP08fIjoBue217A/P AuMlnj7Fr+ZdOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=98RrR9+LNl7HeH2lGnJUwfyRrMk/Z YDd/9zA8aLpEck=; b=QUm3H9OECfmVAhroYexVzeSS/140Db7WxVpFWPNihPWXm wpVVwtqHlqMN1/avJ1G89efGrotQlse8HpbHZD7W0d64TER6zwlt1i526ngH0hhJ VT4Hceu8HW6x61LcDgVSjS4+MzTx3t62Vlzsjvd5FkpMz90IbQL5L9UDGQu6Y9c2 GRmKu5KC65zEa47Flr8dttlEohghDX3k2BJfRRRqm03eOrnoFK1jlhmGrZdhjNW4 ZUcgHrmGtcpHJHuUrX/HuOpbkZVOM6HyJ2jM+BZfesSQ98ZoWi8Drfeoehcy/taj zp4tqUs6v6yzfvFgKyaKTKvSjE8DqnrQl8ENpThCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertddttd enucfhrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvthculdfrhhhilhhiphcu mfdrmdenucggtffrrghtthgvrhhnpefhfefhuedvleejiedttdevveejvdfgkefgtdffke fhjefgfeelieehgffffeevkeenucfkphepkeejrddugeehrdelrdejnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrph hmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p57910907.dip0.t-ipconnect.de [87.145.9.7]) by mail.messagingengine.com (Postfix) with ESMTPA id D1D863066012 for ; Tue, 5 May 2020 08:46:49 -0400 (EDT) From: philip@warpmail.net (Philip K.) To: bug-gnu-emacs@gnu.org Subject: ERC header line Date: Tue, 05 May 2020 14:46:47 +0200 Message-ID: <87wo5q1rd4.fsf@bulbul> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.147.123.20; envelope-from=philip@warpmail.net; helo=wout4-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 08:46:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hi, when trying out a dark theme I noticed that the ERC header line was out of place. It turns out that this is because it's fore- and background color are hard-coded to gray20 and gray90. Since these are fairly similar to the default colours of header-line using a light colour-scheme, I suggest inheriting it's values by default.c -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-erc-header-line-inherit-from-header-line.patch >From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001 From: Philip K Date: Tue, 5 May 2020 14:41:06 +0200 Subject: [PATCH] Make erc-header-line inherit from header-line --- lisp/erc/erc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index cfde84e19a..a237ca7ce9 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1212,7 +1212,7 @@ erc-direct-msg-face :group 'erc-faces) (defface erc-header-line - '((t :foreground "grey20" :background "grey90")) + '((t :inherit header-line)) "ERC face used for the header line. This will only be used if `erc-header-line-face-method' is non-nil." -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 29 00:55:15 2020 Received: (at 41095) by debbugs.gnu.org; 29 Jul 2020 04:55:15 +0000 Received: from localhost ([127.0.0.1]:59668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7W-0006PF-TV for submit@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7U-0006Oy-BQ for 41095@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F4TOxXjtYxMmLo+wSq7dbVe+goPR7MBacztrHK8bAIk=; b=arJ+CqScyRvwUrZ+LI/lsOef1Q ZVtep0CQDr284OTVX/nGogt0hNGo2wpFRjlNEUUxrZzTZW62YLxnB9a7cjx3wzexfZwYdsuYk640f xBnfpo08tZg95xjOAn9umBk+lK+W7zDyN/60G2fi6MszxxdFdK1AJh79BQjgQdrdS/HA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0e7B-00029Q-0w; Wed, 29 Jul 2020 06:55:05 +0200 From: Lars Ingebrigtsen To: philip@warpmail.net (Philip K.) Subject: Re: bug#41095: ERC header line References: <87wo5q1rd4.fsf@bulbul> Date: Wed, 29 Jul 2020 06:54:51 +0200 In-Reply-To: <87wo5q1rd4.fsf@bulbul> (Philip K.'s message of "Tue, 05 May 2020 14:46:47 +0200") Message-ID: <87k0ym3opw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: philip@warpmail.net (Philip K.) writes: > when trying out a dark theme I noticed that the ERC header line was out > of place. It turns out that this is because it's fore- and background > color are hard-coded to gray20 and gray90. Since the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41095 Cc: 41095@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) philip@warpmail.net (Philip K.) writes: > when trying out a dark theme I noticed that the ERC header line was out > of place. It turns out that this is because it's fore- and background > color are hard-coded to gray20 and gray90. Since these are fairly > similar to the default colours of header-line using a light > colour-scheme, I suggest inheriting it's values by default.c [...] > (defface erc-header-line > - '((t :foreground "grey20" :background "grey90")) > + '((t :inherit header-line)) > "ERC face used for the header line. This also makes the header line look less awkward in dark mode, so it makes sense to me. Applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 29 00:55:21 2020 Received: (at control) by debbugs.gnu.org; 29 Jul 2020 04:55:21 +0000 Received: from localhost ([127.0.0.1]:59671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7d-0006Pa-4c for submit@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0e7b-0006PD-Bq for control@debbugs.gnu.org; Wed, 29 Jul 2020 00:55:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RzAn+Vor2IgHuuhI0d5f3YoJJQ/sK5q2SMrku4YRxgA=; b=UIcL/R8TH/ZIZffGtM+HjLHj51 4L1120e0Ttp+2jZ1sdsSgNDNm5iYXBuAb7fKf93ONOD4TJR+3PnifzBYj5HqIUYjWDf9iR7t+n+HM 0pFjSz88E2w9wHizFDMpxRdafvPjJXXQGX/f1aE+gaANjcTs6deNL6Su2IOB66QlCHB8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0e7T-00029d-8H for control@debbugs.gnu.org; Wed, 29 Jul 2020 06:55:13 +0200 Date: Wed, 29 Jul 2020 06:55:10 +0200 Message-Id: <87ime63opd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41095 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41095 fixed close 41095 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41095 fixed close 41095 28.1 quit From unknown Fri Sep 12 04:45:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Aug 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator