GNU bug report logs - #41088
[PATCH] gnu: Add gnome-shell-extension-clipboard-indicator.

Previous Next

Full log

View this message in rfc822 format

From: Jack Hill <jackhill <at> jackhill.us>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41088 <at> debbugs.gnu.org
Subject: [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.
Date: Tue, 5 May 2020 16:11:03 -0400 (EDT)

On Tue, 5 May 2020, Marius Bakke wrote:

> Jack Hill <jackhill <at> jackhill.us> writes:
>
>> +              (snippet
>> +               '(begin (delete-file "schemas/gschemas.compiled")
>> +                       (for-each delete-file (find-files "locale" "\\.mo$"))
>> +                       #t))))
>
> Can you add a comment about why this is necessary?

I've added a commend and will send the updated patch shortly. However, I 
may have been wrong to remove these files as part of the snippet. I did it 
because the removed files are not source form, but instead can be 
generated from source during the package build. I believe that upstream 
includes them in the code repository because it is common for people to 
install GNOME Shell extensions by directly cloning the repo in their home 
directories.

> Otherwise LGTM.

Thanks for the review.

Best,
Jack

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.