GNU bug report logs - #41083
gnu: xfe: Fix hard-coded fhs directories.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41083: closed (gnu: xfe: Fix hard-coded fhs directories.)
Date: Wed, 06 May 2020 15:41:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 06 May 2020 17:39:16 +0200
with message-id <87y2q59ior.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#41083] gnu: xfe: Fix hard-coded fhs directories.
has caused the debbugs.gnu.org bug report #41083,
regarding gnu: xfe: Fix hard-coded fhs directories.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41083: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41083
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: xfe: Fix hard-coded fhs directories.
Date: Mon, 4 May 2020 13:16:24 -0400

[Message part 3 (text/plain, inline)]

[0001-gnu-xfe-Fix-hard-coded-fhs-directories.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 41083-done <at> debbugs.gnu.org
Subject: Re: [bug#41083] gnu: xfe: Fix hard-coded fhs directories.
Date: Wed, 06 May 2020 17:39:16 +0200

Hello,

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

> Please find the updated patch attached with this email.

Thank you. I applied it, with the following few cosmetics changes.

> Subject: [PATCH] gnu: xfe: Fix hard-coded fhs directories.
>
> * gnu/packages/disk.scm (xfe):
> [arguments]: Remove phase 'patch-xfe-paths.
> [arguments]: Add phases 'patch-bin-dirs and 'patch-share-dirs.

I merged these two lines.

> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let*
> +                 ((bash (assoc-ref inputs "bash"))

I moved the bash binding onto the same line as let*.

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let*
> +                 ((out (assoc-ref outputs "out"))

Ditto.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.