GNU bug report logs - #41073
[PATCH] Adjust outline-minor-mode-map when prefix is changed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41073 in the body.
You can then email your comments to 41073 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip K <philip <at> warpmail.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Adjust outline-minor-mode-map when prefix is changed
Date: Mon,  4 May 2020 11:48:03 +0200

---
 lisp/outline.el | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lisp/outline.el b/lisp/outline.el
index 15fd6ea02e..aa8ed58ad9 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -289,12 +289,18 @@ outline-mode
 	(list (list nil (concat "^\\(?:" outline-regexp "\\).*$") 0)))
   (add-hook 'change-major-mode-hook 'outline-show-all nil t))
 
+(defvar outline-minor-mode-map)
+
 (defcustom outline-minor-mode-prefix "\C-c@"
   "Prefix key to use for Outline commands in Outline minor mode.
 The value of this variable is checked as part of loading Outline mode.
 After that, changing the prefix key requires manipulating keymaps."
   :type 'key-sequence
-  :group 'outlines)
+  :group 'outlines
+  :set (lambda (sym val)
+         (define-key outline-minor-mode-map outline-minor-mode-prefix nil)
+         (define-key outline-minor-mode-map val outline-mode-prefix-map)
+         (set-default sym val)))
 
 ;;;###autoload
 (define-minor-mode outline-minor-mode
-- 
2.20.1

Message #8 received at 41073 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip K <philip <at> warpmail.net>
Cc: 41073 <at> debbugs.gnu.org
Subject: Re: bug#41073: [PATCH] Adjust outline-minor-mode-map when prefix is
 changed
Date: Sat, 08 Aug 2020 13:53:36 +0200

Philip K <philip <at> warpmail.net> writes:

> +(defvar outline-minor-mode-map)
> +
>  (defcustom outline-minor-mode-prefix "\C-c@"
>    "Prefix key to use for Outline commands in Outline minor mode.
>  The value of this variable is checked as part of loading Outline mode.
>  After that, changing the prefix key requires manipulating keymaps."
>    :type 'key-sequence
> -  :group 'outlines)
> +  :group 'outlines
> +  :set (lambda (sym val)
> +         (define-key outline-minor-mode-map outline-minor-mode-prefix nil)
> +         (define-key outline-minor-mode-map val outline-mode-prefix-map)
> +         (set-default sym val)))

I don't use outline mode, but this makes sense to me (if I understand
what it's doing correctly), so I've applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.