GNU bug report logs - #41071
make-frame with internal-border face not working

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Third <alan <at> idiocy.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37832: closed (internal-border face ignored in Emacs 26.3 for
 macOS)
Date: Fri, 25 Sep 2020 16:24:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 25 Sep 2020 17:23:05 +0100
with message-id <20200925162305.GG28875 <at> breton.holly.idiocy.org>
and subject line Re: bug#41071: make-frame with internal-border face not working
has caused the debbugs.gnu.org bug report #41071,
regarding internal-border face ignored in Emacs 26.3 for macOS
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41071: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41071
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrea Cardaci <cyrus.and <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: internal-border face ignored in Emacs 26.3 for macOS
Date: Sun, 20 Oct 2019 15:25:54 +0200

The `internal-border` face is ignored and the `default` face
background is used instead. I'm experiencing this with Emacs 26.3
installed with `brew cask install emacs`.

Reproduce with the following `.emacs`:

(custom-set-variables
 '(default-frame-alist '((internal-border-width . 100))))

(custom-set-faces
 '(default ((t (:background "black" :foreground "white"))))
 '(internal-border ((t (:background "red")))))

Works fine on Linux version 26.1.


Andrea

[Message part 3 (message/rfc822, inline)]

From: Alan Third <alan <at> idiocy.org>
To: 王凯 <wangkai.kaiwk <at> bytedance.com>,
 41071-done <at> debbugs.gnu.org
Subject: Re: bug#41071: make-frame with internal-border face not working
Date: Fri, 25 Sep 2020 17:23:05 +0100

On Wed, Sep 23, 2020 at 02:03:27PM +0100, Alan Third wrote:
> On Mon, May 04, 2020 at 03:30:09PM +0800, 王凯 wrote:
> > 
> > (defface test
> >   '((t (:inherit default :background "green")))
> >   "Face used by the ivy-posframe."
> >   :group 'ivy-posframe)
> > 
> > (set-face-background
> > 'internal-border
> > (face-attribute 'test :background)
> > (make-frame `((internal-border-width . 100)
> >                (parent-frame . ,(window-frame)))))
> > 
> > (set-face-background
> > 'internal-border
> > (face-attribute 'test :background)
> > (make-frame `((internal-border-width . 100))))
> > 
> > Eval code above in emacs, internal-border-width works but the
> > :background not.
> 
> Patch against master attached. It appears to work correctly here, but
> I'm slightly concerned it may not work so well on older versions of
> macOS, but we'll probably just have to wait and see if anyone
> complains.

I've pushed the change to master and therefore am closing this bug
report.
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.