GNU bug report logs - #41071
make-frame with internal-border face not working

Previous Next

Full log

Message #18 received at 41071-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: 王凯 <wangkai.kaiwk <at> bytedance.com>,
 41071-done <at> debbugs.gnu.org
Subject: Re: bug#41071: make-frame with internal-border face not working
Date: Fri, 25 Sep 2020 17:23:05 +0100

On Wed, Sep 23, 2020 at 02:03:27PM +0100, Alan Third wrote:
> On Mon, May 04, 2020 at 03:30:09PM +0800, 王凯 wrote:
> > 
> > (defface test
> >   '((t (:inherit default :background "green")))
> >   "Face used by the ivy-posframe."
> >   :group 'ivy-posframe)
> > 
> > (set-face-background
> > 'internal-border
> > (face-attribute 'test :background)
> > (make-frame `((internal-border-width . 100)
> >                (parent-frame . ,(window-frame)))))
> > 
> > (set-face-background
> > 'internal-border
> > (face-attribute 'test :background)
> > (make-frame `((internal-border-width . 100))))
> > 
> > Eval code above in emacs, internal-border-width works but the
> > :background not.
> 
> Patch against master attached. It appears to work correctly here, but
> I'm slightly concerned it may not work so well on older versions of
> macOS, but we'll probably just have to wait and see if anyone
> complains.

I've pushed the change to master and therefore am closing this bug
report.
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.