GNU bug report logs - #41064
26.3; fill-paragraph not working in comments in asm-mode

Previous Next

Package: emacs;

Reported by: Alexis Roda <alexis.roda.villalonga <at> gmail.com>

Date: Sun, 3 May 2020 21:36:02 UTC

Severity: normal

Tags: fixed

Found in version 26.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mattias Märka <mattias <at> marka.ee>
To: "41064 <at> debbugs.gnu.org" <41064 <at> debbugs.gnu.org>
Subject: bug#41064: (No Subject)
Date: Mon, 24 Aug 2020 01:43:25 +0000

[Message part 1 (text/plain, inline)]
Hi,

> In asm-mode calling fill-paragraph on a comment produces weird results. Tested with emacs 24.5, 25.3, 26.1, 26.2, 26.3 and  27.0.90.

I'm also experiencing this issue with 27.1.

> asm-mode defines fill-prefix as a tab. Setting fill-prefix to nil seems to fix the issue.

I looked into this and came to the same conclusion. In fact, I don't
think fill-prefix needs to be set at all since it's already set in
simple.el. So I would remove it altogether.

The line in question

    (setq fill-prefix "\t")

seems to be added in 1991. I suspect that it worked then, but doesn't
anymore because fill-paragraph has been changed somehow.

At any rate, I've included a patch with the fix and an ert test.

Best regards,
Mattias Märka

[0001-Fix-fill-paragraph-in-asm-mode-bug-41064.patch (application/octet-stream, attachment)]
This bug report was last modified 4 years and 116 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.