Subject: Re: [bug#41056] [PATCH 1/2] gnu: Add editline.

From: Marius Bakke <[email-masked]>
Date: Tue, 05 May 2020 19:44:31 +0200

Giacomo Leidi <[email-masked]> writes:

> * gnu/packages/libedit.scm (editline): New variable.

[...]

> +(define-public editline
> +  (package
> +    (name "editline")
> +    (version "1.17.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/troglobit/editline.git")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0y7vis52kfq2km9isrlzakpf7bn1k7v9vf3xg3q1cslla18q6myh"))))

Upstream appears to provide bootstrapped tarballs, can you change to use
those instead?

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("automake" ,automake)
> +       ("autoconf" ,autoconf)
> +       ("libtool" ,libtool)))

Then you can also remove these inputs.

> +    (home-page "https://troglobit.com/projects/editline/")
> +    (synopsis "Small replacement for GNU readline() for UNIX")

Just "Line editing library".  The description has the juicy details.

> +    (description
> +     "@{editline} is a small line editing library.  It can be linked into almost
        ^^^
This should be @code{editline}.

> +any program to provide command line editing and history functions.  It is call
> +compatible with the FSF @code{readline} library, but at a fraction of the size,

s/FSF @code{readline}/GNU Readline/

> +and as a result fewer features.")
> +    (license bsd-4)))

Otherwise LGTM, thanks!