Subject: bug#41033: closed (Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 03 May 2020 20:58:02 +0000

Your bug report

#41033: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41033: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41033
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
From: Jakub Kądziołka <[email-masked]>
To: Christopher Howard <[email-masked]>
Cc: [email-masked]
Date: Sun, 3 May 2020 22:56:59 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sun, May 03, 2020 at 08:13:32AM -0800, Christopher Howard wrote:
> Sounds good to me. Can you make the edit to the patch?

Sure! I pushed the modified patch:

commit 96e399ee30251a0767a45b2bde3f052b25c62714 (HEAD -> master, upstream/master)
Author: Christopher Howard <[email-masked]>
Date:   Sat May 2 14:41:00 2020 -0800

    gnu: libusb-0.1: fix build failure on newer gcc

    * gnu/packages/libusb.scm (libusb-0.1): Disable -Werror.

    Signed-off-by: Jakub Kądziołka <[email-masked]>

Cheers!

Subject: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc
From: Christopher Howard <[email-masked]>
To: [email-masked]
Date: Sat, 02 May 2020 14:47:56 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

I need libusb-0.1 to build some older software, but libusb-0.1 build
fails due to a warning from the current GCC version. (Evidently libusb-
0.1 is set to die on any warning.) The attached patch silences the
warning.

-- 
Christopher Howard
p: +1 (907) 374-0257
w: https://librehacker.com
social: https://gnusocial.club/librehacker
gpg: ADDEAADE5D607C8D (keys.gnupg.net)
From 351bb7004f9bbe8d50bbc7a2e2a1cb3900551e27 Mon Sep 17 00:00:00 2001
From: Christopher Howard <[email-masked]>
Date: Sat, 2 May 2020 14:41:00 -0800
Subject: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc

Package build fails on truncation warning from current gcc. Silences
this warning.
---
 gnu/packages/libusb.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
index 01c138cb4e..3bb2dcd186 100644
--- a/gnu/packages/libusb.scm
+++ b/gnu/packages/libusb.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2017 Jonathan Brielmaier <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2018 Vagrant Cascadian <[email-masked]>
+;;; Copyright © 2020 Christopher Howard <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -113,7 +114,8 @@ version of libusb to run with newer libusb.")
       (sha256
        (base32
         "0i4bacxkyr7xyqxbmb00ypkrv4swkgm0mghbzjsnw6blvvczgxip"))
-      (patches (search-patches "libusb-0.1-disable-tests.patch"))))))
+      (patches (search-patches "libusb-0.1-disable-tests.patch"))))
+    (arguments `(#:configure-flags (list "CFLAGS=-Wno-format-truncation")))))
 
 (define-public libusb4java
   ;; There is no public release so we take the latest version from git.
-- 
2.26.2