Subject: Re: [PATCH] gnu: libusb-0.1: fix build failure on newer gcc

From: Christopher Howard <[email-masked]>
Date: Sun, 03 May 2020 08:13:32 -0800

Sounds good to me. Can you make the edit to the patch?

-- 
Christopher Howard
p: +1 (907) 374-0257
w: https://librehacker.com
social: https://gnusocial.club/librehacker
gpg: ADDEAADE5D607C8D (keys.gnupg.net)

On Sun, 2020-05-03 at 12:58 +0200, Jakub Kądziołka wrote:
> On Sat, May 02, 2020 at 02:47:56PM -0800, Christopher Howard wrote:
> > I need libusb-0.1 to build some older software, but libusb-0.1
> > build
> > fails due to a warning from the current GCC version. (Evidently
> > libusb-
> > 0.1 is set to die on any warning.) The attached patch silences the
> > warning.
> 
> Thanks for your patch! I'm wondering though, whether it wouldn't be
> more
> resilient to add a -Wno-error flag instead. After all, the compiler
> is
> going to get upgraded sooner or later, which will introduce new
> warnings, and libusb 0.1 isn't getting any upgrades...
> 
> A quick grep suggests that this wouldn't be the first package to
> disable
> Werror. Makes sense, since this mode is mostly useful to developers,
> and
> not packagers.
> 
> What do you think?
> 
> Kind regards,
> Jakub Kądziołka