From unknown Thu Sep 11 10:42:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41030 <41030@debbugs.gnu.org> To: bug#41030 <41030@debbugs.gnu.org> Subject: Status: [PATCH] Make EWW respect XDG download directory by default Reply-To: bug#41030 <41030@debbugs.gnu.org> Date: Thu, 11 Sep 2025 17:42:24 +0000 retitle 41030 [PATCH] Make EWW respect XDG download directory by default reassign 41030 emacs submitter 41030 Philip K severity 41030 wishlist tag 41030 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 12:59:05 2020 Received: (at submit) by debbugs.gnu.org; 2 May 2020 16:59:05 +0000 Received: from localhost ([127.0.0.1]:53789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUvTX-0006Q1-1I for submit@debbugs.gnu.org; Sat, 02 May 2020 12:59:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:47430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUvTV-0006Pt-Bo for submit@debbugs.gnu.org; Sat, 02 May 2020 12:58:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUvTU-0006az-PC for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 12:58:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUvTT-0006Tg-Vs for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 12:58:48 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUvTT-0006R7-Ch for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 12:58:47 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7E1E55C00FE for ; Sat, 2 May 2020 12:58:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 02 May 2020 12:58:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=8c3R4jZpr5unP0v1uIKe9nTsDL XEaZxzYpHmqHB8ghk=; b=cusm5wJOob/oZ/vOKtlwLt8w92d5oStzksA1mHRCtp 3rutukFdy1jcLA6XJyZysCFigXG7Xra5Pa6k269HMlcwYf1/uKaBnbrXfg6xRfI+ mv/67x7wBLZfoN8Qy218NgqWRVLKeCyyljbUoGvbJnuX8WSxNGTCxGUyu80ZDVh2 TviQDdR1gvs+IOSxlCsHGxAJ63FzsWCGOy0CL92QCcg8ViQQCc7lM0reSdv1NpV2 UZiRQBSA7z+8i2Zs3OXBwVOf9je9CLgCqRJkehTLUvpxBSfKaegnR+rDCb+5yqNk /91C46GbJL7SylSpMXjdSu+SndvUQoFzysFxPCe4dU8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8c3R4jZpr5unP0v1u IKe9nTsDLXEaZxzYpHmqHB8ghk=; b=um5W44p8IODtmJgI18JeYs+72rLGP4fZY Kh8hfbNyRmz+E0lz65Bo5CNzO4htvBSPETYxFSrnNeocucZni048AqVCjFLt38L+ pZOwO6Edcntp9at2y658NxsU4lxr70mTqrNjDuPUoPPcFATbqrKik5lN6+2FV0sJ wc3g1MtrlCf886AwXQjJtt52zJofiQ20ySwdEyHhgTe4H4819fRHK6iuVWaDTJHb IDg2JdAyHKSy082CVLFEWkfKKuV6n8dqjVNzVwOemuJUn641ly408amfC1VQAk/L FjXu2BR8BIc2fBy9SbaIztatqmicMvTBlJwKar5cBuJNlDLXzuZ2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgogfeguddtqddvjeculdegtddmnecujfgurhephf fvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefrhhhilhhiphcumfcuoehphhhi lhhiphesfigrrhhpmhgrihhlrdhnvghtqeenucggtffrrghtthgvrhhnpeduhefgffekle eltddtleehjeekffduheeggeeigeduudehfedukeelgfefvedtjeenucfkphepjeelrddv udelrdduledvrddvgeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p4fdbc0f4.dip0.t-ipconnect.de [79.219.192.244]) by mail.messagingengine.com (Postfix) with ESMTPA id 14BF33065FA6 for ; Sat, 2 May 2020 12:58:44 -0400 (EDT) From: Philip K To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make EWW respect XDG download directory by default Date: Sat, 2 May 2020 18:58:42 +0200 Message-Id: <20200502165842.8564-1-philip@warpmail.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.25; envelope-from=philip@warpmail.net; helo=out1-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/02 12:58:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --- lisp/net/eww.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index c83884fd25..0d0aa9f3bc 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -32,6 +32,7 @@ (require 'thingatpt) (require 'mm-url) (require 'puny) +(require 'xdg) (eval-when-compile (require 'subr-x)) ;; for string-trim (defgroup eww nil @@ -55,7 +56,8 @@ eww-search-prefix :group 'eww :type 'string) -(defcustom eww-download-directory "~/Downloads/" +(defcustom eww-download-directory (or (xdg-user-dir "DOWNLOAD") + "~/Downloads/") "Directory where files will downloaded." :version "24.4" :group 'eww -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 18:52:17 2020 Received: (at 41030) by debbugs.gnu.org; 3 May 2020 22:52:17 +0000 Received: from localhost ([127.0.0.1]:58379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVNT6-0004WZ-Rn for submit@debbugs.gnu.org; Sun, 03 May 2020 18:52:16 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:33044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVNT4-0004WL-Ub for 41030@debbugs.gnu.org; Sun, 03 May 2020 18:52:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4JGFw4kQAd4CAbSXts6L3UzYnYl0dWC1xIfjQ2pTj4k=; b=jY8qGEifDONZhwWuGHdWHI5+NX OpSE2dLiMFz30DICMpMgSHRcC8W2stj8N2RMVAOyhVXfKHmg7a7POBWINx2gsDn3NMUAeZ7lAoX7y yTV2QLdiCzZdMISGeVR9jhZm+HVylIkA5poPnOUQmbIjGJ9CWWmfgkITWlaG4rTc/Zg4UPew9rsPU uvOXDSRRIj1phRVGzdXcvIAWJzGqrwcEW7eQANp7EiHNH9FZ4CKjT6UrXPvyvRf1QW75zn6R5CZE2 FJEsFOmomp5y0KjBIbmGRiUxkRVA/jZMtkdBWakyHY5kFBFca6+7gtIGe05kermvz2w+jgZWluHkv tBqrLI/w==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:40492 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jVNSy-001DLG-CU; Sun, 03 May 2020 18:52:08 -0400 From: Stefan Kangas To: Philip K Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default In-Reply-To: <20200502165842.8564-1-philip@warpmail.net> (Philip K.'s message of "Sat, 2 May 2020 18:58:42 +0200") References: <20200502165842.8564-1-philip@warpmail.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 04 May 2020 00:52:06 +0200 Message-ID: <874ksw1vjd.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: Lars Ingebrigtsen , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip K writes: > -(defcustom eww-download-directory "~/Downloads/" > +(defcustom eww-download-directory (or (xdg-user-dir "DOWNLOAD") > + "~/Downloads/") This makes sense conceptually. However, on my machine, evaluating (xdg-user-dir "DOWNLOAD") just returns $HOME. That's a worse default than "~/Downloads/", no? But I don't know enough about the XDG standard to propose a solution. Nor do I know if this is because my setup is particularly unusual. Lars, what do you think? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 19:28:24 2020 Received: (at 41030) by debbugs.gnu.org; 3 May 2020 23:28:24 +0000 Received: from localhost ([127.0.0.1]:58448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVO23-0007Uj-OI for submit@debbugs.gnu.org; Sun, 03 May 2020 19:28:24 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:39846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVO21-0007UO-2A for 41030@debbugs.gnu.org; Sun, 03 May 2020 19:28:22 -0400 Received: by mail-wm1-f42.google.com with SMTP id y24so6852640wma.4 for <41030@debbugs.gnu.org>; Sun, 03 May 2020 16:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5fItSMdsDGjB7MuWP0Ntgjch9lp8xrDrfe0tWWVTK1M=; b=ozl6332avTQQVMBrB/52vvhimcOs1I+VUQgNyC+OPBeSBv/epm8vwtoWTJFV+8rqOD LurbhvCEWNuxHW1F0TNG4cAg1Dtt7BenTE7A6eK1Ki6md8mcM6SH+dAV18gXYcGROrmg 3xumWXgKWgqOecyk6WgKlO//QQLAW6hfBGCkjEDLzStmVVCO65L1dM6k3CnfwsueE/fD BuEZPnfOnkkIn1B5e+fxH4BiqMHyks+c8dbs+LlJbYIOh9+FZx/og0h35ljoijAST5h9 YVV3c+nWdFjmpaqze530BrO8yqVUqevBMvDDwSGGn5oJGWsIJ3U5lD8ZYnyA2nf8ROO4 cQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5fItSMdsDGjB7MuWP0Ntgjch9lp8xrDrfe0tWWVTK1M=; b=RH5kcgufxV1eyycl2vx3g3ld3DQMXm3X2VOTPt3O5QAZpZdV2DA5qJtJ8b7/y0JEfQ yiSyLgDBbkAOShJDymsyYAkHK0FFjmN/E8Bl3uAClQbD0BOB+rKOzwSe6H7WrW199Pzy Bu02JnpTlmUXB+jeciA/jtxJDYLvxwuHv4k4WZV1uEZZwiXlNYgm88fWFRwoD+ddxP2I eNGXOvg56OizqtKhYZ0yJI7Q/Zcl9l+H9WRfU9bo1zjY/mh82SrSBfYEIk4Rm1HgEjgn e785zIHU4RANaiSlgW6fzQKA9IgMV+avIRj7CPk/TrAwlgyL/IgkfqbKOxDIiPd435ft TDHA== X-Gm-Message-State: AGi0PuauQsg4sDMPFM/y4sbiXKxTZuiTjWLbTHhst54RibRo+kbfR+uy cw6JHiQIIvYY3MQa/4HiT9kHnw== X-Google-Smtp-Source: APiQypJCdeBwltXmIJ8KN2Ehd4iWGsAjt91WAp4gSUJBTlDxkMNTeqFrFFuif4bCU01ahPxY4ZQTbA== X-Received: by 2002:a1c:1fcf:: with SMTP id f198mr11621890wmf.16.1588548495261; Sun, 03 May 2020 16:28:15 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id v16sm10673232wml.30.2020.05.03.16.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2020 16:28:14 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> Date: Mon, 04 May 2020 00:28:13 +0100 In-Reply-To: <874ksw1vjd.fsf@stefankangas.se> (Stefan Kangas's message of "Mon, 04 May 2020 00:52:06 +0200") Message-ID: <87o8r4ha42.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: Lars Ingebrigtsen , Philip K , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 41030 wishlist quit Stefan Kangas writes: > Philip K writes: > >> -(defcustom eww-download-directory "~/Downloads/" >> +(defcustom eww-download-directory (or (xdg-user-dir "DOWNLOAD") >> + "~/Downloads/") > > This makes sense conceptually. However, on my machine, evaluating > (xdg-user-dir "DOWNLOAD") just returns $HOME. That's a worse default > than "~/Downloads/", no? > > But I don't know enough about the XDG standard to propose a solution. > Nor do I know if this is because my setup is particularly unusual. It sounds like it could be specific to your environment; have a look at 'man 1 xdg-user-dirs-update'. > Lars, what do you think? I'm not Lars, but there's some precedent for this feature. In the following thread that prompted the creation of xdg.el, Lars talked about a general facility for determining the default download directory: https://lists.gnu.org/archive/html/emacs-devel/2017-01/msg00607.html In the following thread(s), using the external executable xdg-user-dirs for eww-download-directory was discussed: https://lists.gnu.org/archive/html/emacs-devel/2018-10/msg00599.html https://lists.gnu.org/archive/html/emacs-devel/2018-11/msg00014.html Some executive questions: - Does it make sense and is it safe to eagerly load xdg.el on all platforms and call xdg-user-dir while eww.el is being loaded? One alternative being to define a symbolic constant such as 'xdg for eww-download-directory that is translated to a call to xdg-user-dir on demand rather than up front. This idea can be expanded to cover non-XDG systems. - Should we wait until there's a general utility for this? - What do we do when xdg-user-dir returns ~/ but ~/Downloads/ also exists, as in Stefan's case? Consider it a user misconfiguration? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 04:02:31 2020 Received: (at 41030) by debbugs.gnu.org; 5 May 2020 08:02:31 +0000 Received: from localhost ([127.0.0.1]:34683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVsX9-0004Op-CV for submit@debbugs.gnu.org; Tue, 05 May 2020 04:02:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVsX5-0004Oa-UA for 41030@debbugs.gnu.org; Tue, 05 May 2020 04:02:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RhsDuMLv8X51KUECKnzfTLJnl2YIYmGY69VCKT/VOQ0=; b=LaZgO+0XDMOOJ9HzzUJE21rmqD 7nMFxabIEVDg/7U+opbfhvQm6QekVxCmjGl2mbtf8ianqiS4CAY9KKvxxIxzS7+eMo0fHDCx4Itb6 OMysbICP9WxBIH6rwd2XF4IOCnf+8yw2uOb9msxPcw71N4MUyJmbvgKg9JvCoyxxwpq0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVsWs-0003T8-Lh; Tue, 05 May 2020 10:02:20 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> <87o8r4ha42.fsf@tcd.ie> Date: Tue, 05 May 2020 10:02:13 +0200 In-Reply-To: <87o8r4ha42.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 04 May 2020 00:28:13 +0100") Message-ID: <87wo5qvmgq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > - What do we do when xdg-user-dir returns ~/ but ~/Downloads/ also > exists, as in Stefan's case? Consider it a user misconfiguration? I think that is ~/Downloads/ exists, it's a good hint that the user wants to use ~/Downloads/, no matter what xdg-user-dir says. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: Philip K , Stefan Kangas , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > - What do we do when xdg-user-dir returns ~/ but ~/Downloads/ also > exists, as in Stefan's case? Consider it a user misconfiguration? I think that is ~/Downloads/ exists, it's a good hint that the user wants to use ~/Downloads/, no matter what xdg-user-dir says. Probably? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 04:20:42 2020 Received: (at 41030) by debbugs.gnu.org; 5 May 2020 08:20:42 +0000 Received: from localhost ([127.0.0.1]:34690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVsoj-0004ob-TC for submit@debbugs.gnu.org; Tue, 05 May 2020 04:20:42 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVsoh-0004oN-7f for 41030@debbugs.gnu.org; Tue, 05 May 2020 04:20:40 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E5C225C00BB; Tue, 5 May 2020 04:20:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 05 May 2020 04:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=aJun1B2Lc18APpi/1OV/obDs34w7u311U5Zz8Fd Z4Yw=; b=UF5JZqBPqk21PWKMJ/rDeKKcJtqsJpflVeDVihazu/YhDVsVPGan6oH fRyNZ63kO3PowmM5ZVjyyvPy/eru9GxfQUocAi7oR+HF/5+QHct4Vl+o7Pqrzakp P+ic4jw16ztW2/Ot6K6NCgH+KE80TNhfnuQYEP5LSJGhyajlKoxjmm6nPgGkG4k7 CczjasL1CdSLxXnF9FinOnUcjIdNNH1Pb1jx1t8p9DOTzj8VRvr/Ng7KWOj2Iyc9 bieev1MxCHmENrrC7uF2nTz2JpnAsevFA0Qg62yylyfjpYeERkBgitlIMLpvglbW 4FxtBzlffbBK0wL5KbYspysbHOtIbZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aJun1B2Lc18APpi/1 OV/obDs34w7u311U5Zz8FdZ4Yw=; b=2Fnxg/V6vXK1bjgsBnBtmcoo/NRN58xMf tEHjMP1oKpHIJ6Ejes86oGnmRwkSnoZgFW4k+kXaeoHRPBOG96rLTIhB11RD65qv unO4MLRovFB8t8vaETOYBBZDfx7tbdP0jGq80PJ2adj6HuL1HrKN/JU3lEfFE2W4 kPnJ+Izest2D1Tz4XU7OYcDH7wIKls2IJ1+eMnQx7CNfqHUsojxrpNeWmjs3u0EL v7QXSK1SUOkmZC7zNdWVDQjoaoqAwa2Jj/X8vHbVDwzbOtsK+WnQLxmqiNZM0BbY B8kZ20PhvM0pPV+Th+ct1GPgjTZmP6m37MAjZ41k7jFHhNBRo8Oiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeigddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujgffkfggtgesthdtredttddttdenucfhrhhomhepphhhihhlihhpseif rghrphhmrghilhdrnhgvthculdfrhhhilhhiphcumfdrmdenucggtffrrghtthgvrhhnpe ffhedvfefhtdettdevleeikeeggfejuedvvddtuddvfeekvddvveekleefhedvueenucfk phepkeejrddugeehrdelrdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p57910907.dip0.t-ipconnect.de [87.145.9.7]) by mail.messagingengine.com (Postfix) with ESMTPA id 2B2F23280060; Tue, 5 May 2020 04:20:33 -0400 (EDT) From: philip@warpmail.net (Philip K.) To: Lars Ingebrigtsen Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default In-Reply-To: <87wo5qvmgq.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 05 May 2020 10:02:13 +0200) Date: Tue, 05 May 2020 10:20:29 +0200 Message-ID: <874ksu3i9e.fsf@bulbul> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41030 Cc: contovob@tcd.ie, stefan@marxist.se, 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> - What do we do when xdg-user-dir returns ~/ but ~/Downloads/ also >> exists, as in Stefan's case? Consider it a user misconfiguration? > > I think that is ~/Downloads/ exists, it's a good hint that the user > wants to use ~/Downloads/, no matter what xdg-user-dir says. So should it check for "~/Downloads/" first (and maybe perhaps a few other popular directory names in other languages), and unless that hasn't been found load xdg.el and call xdg-user-dir? In the worst case, the user doesn't have a download directory and $HOME is actually where they want their files to land. -- Philip K. From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 17:32:35 2020 Received: (at 41030) by debbugs.gnu.org; 5 May 2020 21:32:35 +0000 Received: from localhost ([127.0.0.1]:37768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW5B4-0001pF-Rn for submit@debbugs.gnu.org; Tue, 05 May 2020 17:32:35 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:43900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW5B3-0001ov-NC for 41030@debbugs.gnu.org; Tue, 05 May 2020 17:32:34 -0400 Received: by mail-yb1-f172.google.com with SMTP id o198so2043176ybg.10 for <41030@debbugs.gnu.org>; Tue, 05 May 2020 14:32:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=b16vIQOP0htbo0F5CbK7uNgCuWM1tBCTyJA44onyaJc=; b=em1iwzypbtYTmvpk0FS+KyVRR+fZxvKcBeegAvonfnFSn5+OxJhNOzviYFI2IiBD9a LwmBzK8QzJEUBvnWCfE3akzryNn+cbkYls0XjmZXWPC6x+etGKvOKCUFDFEfdmsDF7JB 51V+4Vk8LDDX+e3BkegDkEhmlYn3tHypoSyOYwH1yF/j/LHiS4NrU+r8AazX+JAnT6h9 xa1X4+BYD4PJOfTh8IsJYLgiEM2PdhFRwJ9G8ePE0pe6bYIozGrJuEYY0Dm0XEruOg3v sC5c+IVenF9/glRBn9mD9tLaDVMf40BwDDsOPBy6aReTHzO6JkbEzgfCqd4D14SNYLmp SeKw== X-Gm-Message-State: AGi0PuYOSMkS0BhqZYZ0gKqYkR0IEgxt9lcL/cogGZLmfTn0dMtEj5ew aUZTbM2MBwXBjJBBjy1AzUbbyjxuZBExCcNHmnc= X-Google-Smtp-Source: APiQypJ26IjdqwKuL97xWiPuq1lpc8wnI3jFAz4DLHhRS+S7mMqc0fyCEc+Nir0mLw1WPz8A3jgG6RtS/rMIBHy0Rk0= X-Received: by 2002:a25:fc08:: with SMTP id v8mr8387910ybd.389.1588714348100; Tue, 05 May 2020 14:32:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 May 2020 17:32:27 -0400 From: Stefan Kangas In-Reply-To: <87o8r4ha42.fsf@tcd.ie> References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> <87o8r4ha42.fsf@tcd.ie> MIME-Version: 1.0 Date: Tue, 5 May 2020 17:32:27 -0400 Message-ID: Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41030 Cc: Lars Ingebrigtsen , Philip K , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) "Basil L. Contovounesios" writes: >>> -(defcustom eww-download-directory "~/Downloads/" >>> +(defcustom eww-download-directory (or (xdg-user-dir "DOWNLOAD") >>> + "~/Downloads/") >> >> This makes sense conceptually. However, on my machine, evaluating >> (xdg-user-dir "DOWNLOAD") just returns $HOME. That's a worse default >> than "~/Downloads/", no? >> >> But I don't know enough about the XDG standard to propose a solution. >> Nor do I know if this is because my setup is particularly unusual. > > It sounds like it could be specific to your environment; have a look at > 'man 1 xdg-user-dirs-update'. In my use-case, I don't think I have ever touched any of this stuff. Not AFAIR, anyways. So I wonder if the suggested code would mean to never use "~/Downloads", since xdg-user-dir will always return something else? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 20:04:52 2020 Received: (at 41030) by debbugs.gnu.org; 6 May 2020 00:04:52 +0000 Received: from localhost ([127.0.0.1]:37885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW7YS-0007Zo-0p for submit@debbugs.gnu.org; Tue, 05 May 2020 20:04:52 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:34368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW7YQ-0007Za-3j for 41030@debbugs.gnu.org; Tue, 05 May 2020 20:04:50 -0400 Received: by mail-qk1-f178.google.com with SMTP id t3so253527qkg.1 for <41030@debbugs.gnu.org>; Tue, 05 May 2020 17:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+FG4I69Kprtq8YPtEXwLpUQ4piXwDuDpfERWHQyQYMc=; b=s0ef/7CZ3nj+NjicCWCQtsuX3/ZaQMSjnp8ZPszN7OB6DSsw/CGFJNQjCNRMt7jftQ dz/1OZ1OTdbugbZjM/6QLE7KaXa+YAQhnf91eOcSEJakiVjmDt6i5NS58S608+OA6bTd BRsMfO4oqEN0WRaGhJOqeosgu7lMjUwoyo6zC31lpFd+6iDZ1hmHYzZuZPze2T2h5ipW UKOWdmKYoL9PnJA8wfEic0NM44VEA6oKA1+oMgLC7tNH8KKBMaF+v9+wuyvMsFGbRcU2 LHzAiBy668TZkQkEJako98FWOHALX4zW/9jkJWRmid1dvcMxk9q81y0mNv/6TVVHaxIu jaUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+FG4I69Kprtq8YPtEXwLpUQ4piXwDuDpfERWHQyQYMc=; b=Qb+IdkMT6FkXEGQdR7lvDQs8O/Hq2nhQYYrhWZU03wM4TO2yA6bjISeVRBRm1iDgPU HeQlX6fU/73EomQ5GPNepMW1oaaCsfDTrW5Jn1o8o5kibM7OqJU+wET5a5jJuiFVXQsL TN2MhVI22lODwTuC+CO84dw2rb7rZQZMLghwi1IOQWFUq2Zkn8DRCoSiogP4mDbAGXCk rbZQ9FUmzPrNyf3IL0TFbXR7LCJdA+crmttvk+1ttJZ3JlTP0bHYIEovsk5G/CDjg33j yl+tKigOy+sYo27DV7gdOfCjX50glLd5qacVI1+ROwkORSDQpXAVS3PnD0c1B4IsxWzI AXWQ== X-Gm-Message-State: AGi0PubbStgdG5jItJN90g20PHBYR3LOyqoYk0ZLjqS2m6KvjQQ+sf14 zU/wa+WGhQtKYaswwYADpbHJbz3m X-Google-Smtp-Source: APiQypIQwiguNqM7pC4Rzx+qKsaM8q/VgmrZPgNcVkeKYNAZF14j34+mEa82XLv3drB+y1Vf05dFRg== X-Received: by 2002:a37:2c45:: with SMTP id s66mr6474067qkh.305.1588723483998; Tue, 05 May 2020 17:04:43 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id p31sm47391qtf.11.2020.05.05.17.04.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 May 2020 17:04:43 -0700 (PDT) From: Noam Postavsky To: Stefan Kangas Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> <87o8r4ha42.fsf@tcd.ie> Date: Tue, 05 May 2020 20:04:30 -0400 In-Reply-To: (Stefan Kangas's message of "Tue, 5 May 2020 17:32:27 -0400") Message-ID: <87mu6mlyi9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: "Basil L. Contovounesios" , Lars Ingebrigtsen , Philip K , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >> It sounds like it could be specific to your environment; have a look at >> 'man 1 xdg-user-dirs-update'. > > In my use-case, I don't think I have ever touched any of this stuff. > Not AFAIR, anyways. > > So I wonder if the suggested code would mean to never use > "~/Downloads", since xdg-user-dir will always return something else? I get nil from (xdg-user-dir "DOWNLOAD"). Looking at the code, I guess you have something in ~/.config/user-dirs.dirs which causes this. From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 20:18:06 2020 Received: (at 41030) by debbugs.gnu.org; 6 May 2020 00:18:06 +0000 Received: from localhost ([127.0.0.1]:37890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW7lG-0007uE-4w for submit@debbugs.gnu.org; Tue, 05 May 2020 20:18:06 -0400 Received: from mail-yb1-f180.google.com ([209.85.219.180]:39763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW7lE-0007tg-Ve for 41030@debbugs.gnu.org; Tue, 05 May 2020 20:18:05 -0400 Received: by mail-yb1-f180.google.com with SMTP id d197so60723ybh.6 for <41030@debbugs.gnu.org>; Tue, 05 May 2020 17:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=RjQUKMKMYqUBgaOxKwqZm5j90FELpqA+zJSzic0cUFo=; b=YvgCvjvLyHCv1UsGyWQBpyHCxCJfhdRXSZVbLzz8/q5n5V+Km0209meD7hD3wiTVrZ v58Rwa8YvcLr6LjprtMzWb5sB4208qw23/khO8OyA30pDAlymtXRrDR+56Ep3oinO5pj RaUM0L1865VcRtiAz0Z61p7LIZ4KuU+RfBZ9reI5PbYt4cvMgrQi7MlZ8xzSYRGnuC2V b05kVwtkvTwokKUMmdEBrZ322FdGa67O+KJ+KbLerUgRLmbJk1tmCBFFRqwknoid8Isj F+jCOvXx78LSxZ65FKIZfPYB+a/l3G8j8lIZkG6Ubk0p+k7IJHS/lZpiwrVDbSdQRn7n QZQQ== X-Gm-Message-State: AGi0PuZ1sV8UT1/BMr9VR4+qIEQbWzKxN3ov2z1ynNyYU0yGwsVLlI6j XQSc34ylxjYuI4Odu+11IMCwuSPE0NR24Lh1VhQ= X-Google-Smtp-Source: APiQypLbpZTC64ADt3E3oqdgeBjcB0jn29LyERMF36d8nmWufSpoaXnPj7V3+8VyuSu+u35uLEn3g1tcrVnlpN5KCdg= X-Received: by 2002:a25:c402:: with SMTP id u2mr8795219ybf.231.1588724279432; Tue, 05 May 2020 17:17:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 May 2020 20:17:58 -0400 From: Stefan Kangas In-Reply-To: <87mu6mlyi9.fsf@gmail.com> References: <20200502165842.8564-1-philip@warpmail.net> <874ksw1vjd.fsf@stefankangas.se> <87o8r4ha42.fsf@tcd.ie> <87mu6mlyi9.fsf@gmail.com> MIME-Version: 1.0 Date: Tue, 5 May 2020 20:17:58 -0400 Message-ID: Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 41030 Cc: "Basil L. Contovounesios" , Lars Ingebrigtsen , Philip K , 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Noam Postavsky writes: > I get nil from (xdg-user-dir "DOWNLOAD"). Looking at the code, I guess > you have something in ~/.config/user-dirs.dirs which causes this. Yup, that seems to be it. I deleted the file, and now (xdg-user-dir "DOWNLOAD") returns nil as it should. Sorry about the noise. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 17 09:09:35 2020 Received: (at 41030) by debbugs.gnu.org; 17 Jul 2020 13:09:35 +0000 Received: from localhost ([127.0.0.1]:56869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwQ7L-0000Mg-MS for submit@debbugs.gnu.org; Fri, 17 Jul 2020 09:09:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwQ7I-0000MP-Ev for 41030@debbugs.gnu.org; Fri, 17 Jul 2020 09:09:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9UUvKWr271CayM5Ce38VsdvXep/DqjlU+NhXjSCd74s=; b=EvM5a9pS9t+t7290tkk4fIlRo+ 9bDMXQ9zfNtpXl927Iuh135mVNwRZjE9XNaLenGtvggy/HGTeTv3pT9LHe/SPx9mz4bmdN3dJnICz zlpX+nT3WfC+ueO34ZTumbbQV+H3idl608YkvIqsJ4rlAeuNNxGb/NkhtsftRyJssRtE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwQ78-0004Ae-Nl; Fri, 17 Jul 2020 15:09:25 +0200 From: Lars Ingebrigtsen To: philip@warpmail.net (Philip K.) Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default References: <20200502165842.8564-1-philip@warpmail.net> <874ksu3i9e.fsf@bulbul> Date: Fri, 17 Jul 2020 15:09:21 +0200 In-Reply-To: <874ksu3i9e.fsf@bulbul> (Philip K.'s message of "Tue, 05 May 2020 10:20:29 +0200") Message-ID: <87lfjinv9a.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: philip@warpmail.net (Philip K.) writes: >> I think that is ~/Downloads/ exists, it's a good hint that the user >> wants to use ~/Downloads/, no matter what xdg-user-dir says. > > So should it check for "~/Downloads/" first (and maybe perhap [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: contovob@tcd.ie, stefan@marxist.se, 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) philip@warpmail.net (Philip K.) writes: >> I think that is ~/Downloads/ exists, it's a good hint that the user >> wants to use ~/Downloads/, no matter what xdg-user-dir says. > > So should it check for "~/Downloads/" first (and maybe perhaps a few > other popular directory names in other languages), and unless that > hasn't been found load xdg.el and call xdg-user-dir? Yes, perhaps something like that. But we don't want to do that checking at load time, I think? And the same goes for the call to xdg-user-dir -- that doesn't be done at load time, either. (And the patch isn't correct as is, either, because xdg-user-dir returns the directory without a trailing slash.) So perhaps eww-download-directory should default to a function that does all this checking and calling? Any opinions? And... as far as I can see, xdg-user-dir isn't used anywhere else in Emacs? What's up with that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 29 01:14:39 2020 Received: (at 41030) by debbugs.gnu.org; 29 Jul 2020 05:14:39 +0000 Received: from localhost ([127.0.0.1]:59724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0eQI-0000kq-Vn for submit@debbugs.gnu.org; Wed, 29 Jul 2020 01:14:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0eQH-0000kb-H5 for 41030@debbugs.gnu.org; Wed, 29 Jul 2020 01:14:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XG2izfI2qeLScaJ6FoHlKhL4XCRqybODhWSdd/J0qw4=; b=B3I1c2y6Z0IJPLE0CVPrmNbWa0 rFUI05txE8Y6UwlniAJ9BwqoeuKQup3HkdRRTnhvb8s0RDP2j3CETPr8qagyJKbiYcBN5ag3ys495 P9Uj6ldb6AfQj8muhFyQ/BZFomROnXnYb50csc/4R4sR7DkCNex/laFyITuIQyVaa42I=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0eQ7-0002LF-M6; Wed, 29 Jul 2020 07:14:30 +0200 From: Lars Ingebrigtsen To: philip@warpmail.net (Philip K.) Subject: Re: bug#41030: [PATCH] Make EWW respect XDG download directory by default References: <20200502165842.8564-1-philip@warpmail.net> <874ksu3i9e.fsf@bulbul> <87lfjinv9a.fsf@gnus.org> Date: Wed, 29 Jul 2020 07:14:25 +0200 In-Reply-To: <87lfjinv9a.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 17 Jul 2020 15:09:21 +0200") Message-ID: <87eeou3nta.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > So perhaps eww-download-directory should default to a function that does > all this checking and calling? I've now done this in Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41030 Cc: contovob@tcd.ie, stefan@marxist.se, 41030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > So perhaps eww-download-directory should default to a function that does > all this checking and calling? I've now done this in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 29 01:14:44 2020 Received: (at control) by debbugs.gnu.org; 29 Jul 2020 05:14:44 +0000 Received: from localhost ([127.0.0.1]:59727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0eQO-0000lA-5Y for submit@debbugs.gnu.org; Wed, 29 Jul 2020 01:14:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0eQM-0000kj-Lr for control@debbugs.gnu.org; Wed, 29 Jul 2020 01:14:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4cifGsRnjzhWTsXdkH63mKSj+QjIsNO7bWzfWFPAixo=; b=Z0+lcG+BPcB522sHA7FXuXR5sB VFhvRM2elTrD2omJzEvg1baGaKjKnwYWKIUjjVcHohUf8wnqdE3WD75jcFWHndgV9JP2HUAQVKKjn xgrfJEvDK7qWul0H8kUwevJNqTvvlwoUBjpN6Jye5MGb7eJFg9auUGrc5csdMZxr59HI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0eQF-0002LN-17 for control@debbugs.gnu.org; Wed, 29 Jul 2020 07:14:37 +0200 Date: Wed, 29 Jul 2020 07:14:33 +0200 Message-Id: <87d04e3nt2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41030 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41030 fixed close 41030 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41030 fixed close 41030 28.1 quit From unknown Thu Sep 11 10:42:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Aug 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator