GNU bug report logs - #41027
[PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#41027: closed (Re: [bug#41027] [PATCH core-updates] gnu:
 python-s3transfer: Fix build with Python 3.8.)
Date: Wed, 13 May 2020 18:11:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41027: [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41027 <at> debbugs.gnu.org.

-- 
41027: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41027
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: 41027-done <at> debbugs.gnu.org
Subject: Re: [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix
 build with Python 3.8.
Date: Wed, 13 May 2020 19:10:21 +0100

[Message part 3 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
> phase to fix a test to work under Python 3.8.
> ---
>  gnu/packages/python-web.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 27749246d8..56887ef9d4 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2204,6 +2204,15 @@ Betamax.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda _
> +             ;; There's a small issue with one test with Python 3.8, this
> +             ;; change has been suggested upstream:
> +             ;; https://github.com/boto/s3transfer/pull/164
> +             (substitute* "tests/unit/test_s3transfer.py"
> +               (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
> +                "futures.Future()"))
> +             #t))
>           (replace 'check
>             (lambda _
>               ;; Some of the 'integration' tests require network access or

I pushed this as c63bd847816061e76389e93dc094df98800f081b back on the
4th of May, but forgot to close the bug.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] gnu: python-s3transfer: Fix build with Python
 3.8.
Date: Sat,  2 May 2020 15:44:41 +0100

* gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
phase to fix a test to work under Python 3.8.
---
 gnu/packages/python-web.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 27749246d8..56887ef9d4 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2204,6 +2204,15 @@ Betamax.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'patch
+           (lambda _
+             ;; There's a small issue with one test with Python 3.8, this
+             ;; change has been suggested upstream:
+             ;; https://github.com/boto/s3transfer/pull/164
+             (substitute* "tests/unit/test_s3transfer.py"
+               (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
+                "futures.Future()"))
+             #t))
          (replace 'check
            (lambda _
              ;; Some of the 'integration' tests require network access or
-- 
2.26.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.