GNU bug report logs - #41024
[PATCH] gnu: tmux: Update to 3.1.b.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41024 in the body.
You can then email your comments to 41024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: tmux: Update to 3.1.b.
Date: Sat,  2 May 2020 14:51:43 +0200

* gnu/packages/tmux.scm (tmux)[version]: Update to 3.1.b.
[source]: Fetch from git instead of a tarball.
[native-inputs]: Add 'autoconf', 'automake', 'bison' and 'pkg-config'.
---
 gnu/packages/tmux.scm | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 6d536131a7..6ac2fc53f0 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019 Oleg Pykhalov <go.wigust <at> gmail.com>
+;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -30,27 +31,35 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages libevent)
-  #:use-module (gnu packages ncurses))
+  #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages pkg-config))
 
 
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.0a")
+    (version "3.1b")
     (source (origin
-             (method url-fetch)
-             (uri (string-append
-                    "https://github.com/tmux/tmux/releases/download/"
-                    version "/tmux-" version ".tar.gz"))
-             (sha256
-              (base32
-               "1fcdbw77nz918f7gqc1ga7zlkp1g112in1h8kkjnkadgnhldzlaa"))))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/tmux/tmux.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "0d8c7f1v75khgq06hlmhsxlxl7jf0mf767aw0makhqg8mxana8by"))))
     (build-system gnu-build-system)
     (inputs
      `(("libevent" ,libevent)
        ("ncurses" ,ncurses)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("bison" ,bison)
+       ("pkg-config" ,pkg-config)))
     (home-page "https://tmux.github.io/")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.26.0

Message #8 received at 41024 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 41024 <at> debbugs.gnu.org
Subject: Re: [bug#41024] [PATCH] gnu: tmux: Update to 3.1.b.
Date: Sat, 02 May 2020 15:32:51 +0200

[Message part 1 (text/plain, inline)]

Brice,

Brice Waegeneire 写道：
> * gnu/packages/tmux.scm (tmux)[version]: Update to 3.1.b.

You can drop [version] here.

We treat the version + hash bump as a package-level operation to 
avoid noise like ‘[source]: Update SHA256.’ every time. 
Explicitly listing non-routine changes is correct:

> [source]: Fetch from git instead of a tarball.
> [native-inputs]: Add 'autoconf', 'automake', 'bison' and 
> 'pkg-config'.

> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/tmux/tmux.git")
> +                    (commit version)))
> +              (sha256
> +               (base32
> + 
> "0d8c7f1v75khgq06hlmhsxlxl7jf0mf767aw0makhqg8mxana8by"))))

I'd add a comment to revert to the (hopefully…) bootstrapped 3.2 
tarball when it lands so these new native-inputs and module 
imports can be removed.

When migrating to GIT-FETCH, add a

 (file-name (git-file-name name version))

to the end to turn

 $ guix build --source tmux
 /gnu/store/xndh3x1qj0b59bxg6za0bcllnxvk2wpl-git-checkout

into

 $ guix build --source tmux
 /gnu/store/ns97s45k3qv6vjw3p5xh9bz0bqg1dhia-tmux-3.1b-checkout

purely for humans' sake.

OK with these changes.  Thanks!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 41024-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 41024-done <at> debbugs.gnu.org
Subject: Done #41024 gnu: tmux: Update to 3.1.b.
Date: Wed, 06 May 2020 09:56:37 +0000

Pushed as 80e0e112aca8591045d91605271a3e0a8686f18a without changing to 
git-fetch since a bootstrapped binary is now available.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.