GNU bug report logs - #41022
[PATCH core-updates] gnu: python-gst: Fix build with Python 3.8.

Previous Next

Full log

Message #19 received at 41022-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 41022-done <at> debbugs.gnu.org
Subject: Re: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with
 Python 3.8.
Date: Sat, 02 May 2020 15:50:49 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>>> Instead of the git patch format, can you add a short comment at the top
>>> along with links to the upstream commit and issue like we usually do?
>>
>> I usually avoid messing with patches, they're often uncooperative. Would
>> something I this do?
>
> Anything before the "diff ..." line is treated as comments/noop by the
> patch utility (actually you can add comments between the @@ lines too).
>
>> Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since
>> Python 3.8 the normal checks don't include the Python libraries anymore and
>> linking of the gst-python module would fail.
>>
>> See also https://github.com/mesonbuild/meson/issues/5629
>> Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
>>
>> Patch based on upstream commit:
>>
>> https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362
>
> Perfect, thanks!

Great, I've pushed this as 20d7dbc77a2b0ed379c0a595daf8d7f852ef3a4c.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.