From unknown Wed Sep 10 09:37:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41022 <41022@debbugs.gnu.org> To: bug#41022 <41022@debbugs.gnu.org> Subject: Status: [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. Reply-To: bug#41022 <41022@debbugs.gnu.org> Date: Wed, 10 Sep 2025 16:37:44 +0000 retitle 41022 [PATCH core-updates] gnu: python-gst: Fix build with Python 3= .8. reassign 41022 guix-patches submitter 41022 Christopher Baines severity 41022 normal tag 41022 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 07:03:24 2020 Received: (at submit) by debbugs.gnu.org; 2 May 2020 11:03:24 +0000 Received: from localhost ([127.0.0.1]:51369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUpvY-0005NB-3s for submit@debbugs.gnu.org; Sat, 02 May 2020 07:03:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:56184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUpvW-0005N4-Uq for submit@debbugs.gnu.org; Sat, 02 May 2020 07:03:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUpvW-0005NO-9V for guix-patches@gnu.org; Sat, 02 May 2020 07:03:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUpvS-0003HR-PL for guix-patches@gnu.org; Sat, 02 May 2020 07:03:22 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:46615) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUpvS-0003H5-9d for guix-patches@gnu.org; Sat, 02 May 2020 07:03:18 -0400 Received: from localhost (unknown [46.237.174.129]) by mira.cbaines.net (Postfix) with ESMTPSA id 7C16027BBE1 for ; Sat, 2 May 2020 12:03:16 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 9c2e7950 for ; Sat, 2 May 2020 11:03:14 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. Date: Sat, 2 May 2020 12:03:14 +0100 Message-Id: <20200502110314.30403-1-mail@cbaines.net> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/02 07:03:16 X-ACL-Warn: Detected OS = ??? X-Received-From: 2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Add a patch based on an upstream commit [1]. 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. --- gnu/local.mk | 1 + gnu/packages/gstreamer.scm | 4 +- ...python-gst-fix-build-with-python-3.8.patch | 41 +++++++++++++++++++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch diff --git a/gnu/local.mk b/gnu/local.mk index 0111ae2161..acfc5cec4d 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1394,6 +1394,7 @@ dist_patch_DATA = \ %D%/packages/patches/python2-larch-coverage-4.0a6-compatibility.patch \ %D%/packages/patches/python-configobj-setuptools.patch \ %D%/packages/patches/python-flask-restful-werkzeug-compat.patch \ + %D%/packages/patches/python-gst-fix-build-with-python-3.8.patch \ %D%/packages/patches/python-keras-integration-test.patch \ %D%/packages/patches/python-pep8-stdlib-tokenize-compat.patch \ %D%/packages/patches/python-pyfakefs-remove-bad-test.patch \ diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 93149e370e..7596796d68 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -521,7 +521,9 @@ non-linear editors.") "gst-python-" version ".tar.xz")) (sha256 (base32 - "1a48ca66izmm8hnp608jv5isg3jxb0vlfmhns0bg9nbkilag7390")))) + "1a48ca66izmm8hnp608jv5isg3jxb0vlfmhns0bg9nbkilag7390")) + (patches + (search-patches "python-gst-fix-build-with-python-3.8.patch")))) (build-system meson-build-system) (arguments `(#:modules ((guix build meson-build-system) diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch new file mode 100644 index 0000000000..49f41e0c03 --- /dev/null +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch @@ -0,0 +1,41 @@ +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= +Date: Fri, 13 Dec 2019 10:46:20 +0200 +Subject: [PATCH] Fix build with Python 3.8 by also checking for + python-3.X-embed.pc + +Since Python 3.8 the normal checks don't include the Python libraries +anymore and linking of the gst-python module would fail. + +See also https://github.com/mesonbuild/meson/issues/5629 + +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 +--- + meson.build | 11 +++++++++-- + 1 file changed, 9 insertions(+), 2 deletions(-) + +diff --git a/meson.build b/meson.build +index 5f13b48..d7c7e66 100644 +--- a/meson.build ++++ b/meson.build +@@ -23,7 +23,17 @@ pygobject_dep = dependency('pygobject-3.0', fallback: ['pygobject', 'pygobject_d + + pymod = import('python') + python = pymod.find_installation(get_option('python')) +-python_dep = python.dependency(required : true) ++pythonver = python.language_version() ++if pythonver.version_compare('<3.0') ++ error('Python2 is not supported anymore, please port your code to python3 (@0@ specified)'.format(python.language_version())) ++endif ++ ++# Workaround for https://github.com/mesonbuild/meson/issues/5629 ++# https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 ++python_dep = dependency('python-@0@-embed'.format(pythonver), version: '>=3', required: false) ++if not python_dep.found() ++ python_dep = python.dependency(required : true) ++endif + + python_abi_flags = python.get_variable('ABIFLAGS', '') + pylib_loc = get_option('libpython-dir') +-- +2.26.2 -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 07:26:24 2020 Received: (at 41022) by debbugs.gnu.org; 2 May 2020 11:26:24 +0000 Received: from localhost ([127.0.0.1]:51414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUqHi-0005wG-Nb for submit@debbugs.gnu.org; Sat, 02 May 2020 07:26:24 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUqHd-0005vu-A3 for 41022@debbugs.gnu.org; Sat, 02 May 2020 07:26:16 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3B43749C; Sat, 2 May 2020 07:26:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 02 May 2020 07:26:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=fOaOV8xLBEEKhovgOsMbi5pgdg INFgwXRXPLnYmP3AU=; b=U0UiC8mdj+9JxakM7vQQ7nzorseHWGQ8wQBQ/LTpin 8MrI2I8qvUdDprDN1eKOytWtnNGH/zVBTNzMV8t04dOAvPnk7hqYkS7Cj5Wfv+Fq J1SDgsGv7ITz8AVC0mwoSdzNJdcDJKboGNSjmELA2eZ1ZNTk63dfEHkbOK0XF9PB oRvkK6CKma1eARR8yDzWGMx3Ltv/cE7TWN21Jc1ywr8OvY4bN7T6+qQ0NstE26S8 2JGYTdyAgHv9yICF9a20dq0h1FtZCvgMojHxryNZh/quB6n1X2T8hrZpvI24mhMJ IJjkO+f/vLu+Vw3IGVYWeQe58bxZo/Dlajy2duGIPcxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fOaOV8 xLBEEKhovgOsMbi5pgdgINFgwXRXPLnYmP3AU=; b=QIMzLEWqGL9o502syVAAxl FGo68IRJvBWWO1nf956Av81ZbrVdKoPtl5+4ALSbZpQiZW62zLcbeAYMiwoZSO6E PG42wmuKMD6fNapUjZdNpTVlqdMlvajiYat8BjcENueVnpVqPg16ix3XnQFUrjRq TpxdcjU8/wtqwoR+OVwxliyBuLS9+luJAAnTm+yC40LJ2LmmyHQwujk+kcA0Tprt gJ3qYmNfGLeH02F/OmuhbNUOy0qkOYSdRgSJbElWrNqdtGOvE2/UmM+zkmH9QjnQ OxsrUle9VkNDvB9FGn2EB3OTe7+O4LSZdC8rBHMP5dnvBHWi4/gFgsvlZXeb+0jg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeduudegudfgheethfeukefffeetle efgfffgeduveeljefgtdfhudefleffffegieenucffohhmrghinhepghhithhhuhgsrdgt ohhmpdhfrhgvvgguvghskhhtohhprdhorhhgnecukfhppeekgedrvddtvddrieekrdejhe enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggr khhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B1893280063; Sat, 2 May 2020 07:26:06 -0400 (EDT) From: Marius Bakke To: Christopher Baines , 41022@debbugs.gnu.org Subject: Re: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. In-Reply-To: <20200502110314.30403-1-mail@cbaines.net> References: <20200502110314.30403-1-mail@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 13:26:04 +0200 Message-ID: <87ees24lyr.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41022 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > Add a patch based on an upstream commit [1]. > > 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 > > * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. [...] > diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch > new file mode 100644 > index 0000000000..49f41e0c03 > --- /dev/null > +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch > @@ -0,0 +1,41 @@ > +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 > +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= > +Date: Fri, 13 Dec 2019 10:46:20 +0200 > +Subject: [PATCH] Fix build with Python 3.8 by also checking for > + python-3.X-embed.pc > + > +Since Python 3.8 the normal checks don't include the Python libraries > +anymore and linking of the gst-python module would fail. > + > +See also https://github.com/mesonbuild/meson/issues/5629 > + > +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 > +--- > + meson.build | 11 +++++++++-- > + 1 file changed, 9 insertions(+), 2 deletions(-) Instead of the git patch format, can you add a short comment at the top along with links to the upstream commit and issue like we usually do? Otherwise LGTM, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tWMwACgkQoqBt8qM6 VPqgqAf/cZ8lgasNc1l63sm5KRYoJ/K0MFkvOEiDx/hodBI5kvnCpzo7V4s62MwD LGBWwJGkXiOPSrOewGKIBBGTEBKeEAqFD4lihN15VHUustIsO9HARl4tI/C+y58J DvluOyGdNnu9M0Dox6X/czJ3xzpxYLe0m5zBDBzAwn8yFrYpsAoDI2SVviNF1cXb nljK8Xy+GNyi5GTLHF1UMufgxP8+zNzOZITKFwZQBIL5lmCco3BC2LjcUGw7SPzT P96wH9+v6eaWBuxf273hBO1vd58559x7uoMaF0ICl83U+fMKEOQk8DJtCIBkJVw/ Nt+0KX+fbYqB75az/1Z82Rjr38Bm4Q== =8Iis -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 09:17:43 2020 Received: (at 41022) by debbugs.gnu.org; 2 May 2020 13:17:43 +0000 Received: from localhost ([127.0.0.1]:51544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUs1S-0002LJ-Fs for submit@debbugs.gnu.org; Sat, 02 May 2020 09:17:43 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUs1M-0002L6-Tr for 41022@debbugs.gnu.org; Sat, 02 May 2020 09:17:37 -0400 Received: from localhost (unknown [46.237.174.129]) by mira.cbaines.net (Postfix) with ESMTPSA id 172A127BBE1; Sat, 2 May 2020 14:17:32 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 52cdf5e4; Sat, 2 May 2020 13:17:28 +0000 (UTC) References: <20200502110314.30403-1-mail@cbaines.net> <87ees24lyr.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Marius Bakke Subject: Re: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. In-reply-to: <87ees24lyr.fsf@devup.no> Date: Sat, 02 May 2020 14:17:28 +0100 Message-ID: <87lfmamq6v.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41022 Cc: 41022@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> Add a patch based on an upstream commit [1]. >> >> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 >> >> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. > > [...] > >> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >> new file mode 100644 >> index 0000000000..49f41e0c03 >> --- /dev/null >> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >> @@ -0,0 +1,41 @@ >> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 >> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= >> +Date: Fri, 13 Dec 2019 10:46:20 +0200 >> +Subject: [PATCH] Fix build with Python 3.8 by also checking for >> + python-3.X-embed.pc >> + >> +Since Python 3.8 the normal checks don't include the Python libraries >> +anymore and linking of the gst-python module would fail. >> + >> +See also https://github.com/mesonbuild/meson/issues/5629 >> + >> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >> +--- >> + meson.build | 11 +++++++++-- >> + 1 file changed, 9 insertions(+), 2 deletions(-) > > Instead of the git patch format, can you add a short comment at the top > along with links to the upstream commit and issue like we usually do? I usually avoid messing with patches, they're often uncooperative. Would something I this do? Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since Python 3.8 the normal checks don't include the Python libraries anymore and linking of the gst-python module would fail. See also https://github.com/mesonbuild/meson/issues/5629 Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 Patch based on upstream commit: https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6tcuhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcHTw//bCIAyOGWEtdqTuhTXSAOFKExl5A130qc0sk0I5bZa8YOztn1qzA0SNL7 mYtiZuWWnmixTvvPRwBRlOAIQfsAHDwjr7XYYUqon9POusYO6yANKo7ja3XpcuVz 7q+7cOHjYjaFG6hOJCpxXqgjd9VuQsKj0UzQO/rUCws9I0KkE9HPU7OWhcxN0nGp BIvU56v3s8MbArGwwf/FpAIA64mS16yerp2N7ZpRXTLL4Qd5G0O/nw9GZZJN0eQo xvKY2Q/EfkWhQqhkF+RAG601lVt8xhVeIdRuwiI02ilhY54UL1Dc/6+lYiBbiu4p ixoyE1koEKY9aXnZBJxIwE/uQ6+LbJsICnFrunXOZd5MtF+s5cClpY2sE+iE+fSs igDo6RIq1K19yxPkBlJjRO4gWCbpB/MN7ZGLCj3SbgEVa0SZ7ZePyIrxHL5eT9oP /bDrsnpac3TzQCMMlUEdSxSZbnm+Ty1q6CF7Bw0RdnM6FygEBJ6egx+LGbNqnFM4 ezn2UZt79eus6xKGb/iBeoZUQz++ckTaYnJ6QKXqwOhoVTDDmzr/xFcVHiXMgXgw uzrexQQ9TXACLnJFfUh0b6ELI472qX/wtFgWESS5L22X5aaA8h/KuxalMuP+6PZL zex8g6fgQeB+Q1Nq+F2O0u7x8MFV9Oso/EqKU+U1Hz5aDVcpBJc= =LSeh -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 09:41:30 2020 Received: (at 41022) by debbugs.gnu.org; 2 May 2020 13:41:30 +0000 Received: from localhost ([127.0.0.1]:51600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsOT-00054L-QJ for submit@debbugs.gnu.org; Sat, 02 May 2020 09:41:30 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsOO-000543-PX for 41022@debbugs.gnu.org; Sat, 02 May 2020 09:41:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F0DEA2EE; Sat, 2 May 2020 09:41:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 02 May 2020 09:41:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=VNLKrrB82g5Ejry50OyZo0nZU9 3tEX4Dp5BOHES2j2k=; b=NRV05eoIilL6YEZaGKOU7R8hx8/Gm3EKPGfH7MzZEI UouglZS9sK51+up/yPTEsW+CAmROGDKjpi52ywjjLxEFyuHJotPk4NTg/PHk2V3z kRNRYhBnruVLfafCEnBsfM0tpCWNW+iq811ewrhr34y8JvJo1I/BdazTD6kBvju3 0Ju/0YNvdfeWivLru8Bxf2X8W+UNMrnLGaBZ7TxToY9+h7AELLGhLZeDbSjJON/j XYdTXDGmTVto1FlmTpMLulzBQcy3NfxpLRJWiKiQrAhOthf4neEfLfAZTmjv1cAi /bZGemafb3R+RQltnFa20GpTJ5H7TnO+ofh0hEuH6scw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VNLKrr B82g5Ejry50OyZo0nZU93tEX4Dp5BOHES2j2k=; b=Q+kD2dAsKPh3JmsY7HYWzK IyYimeXcNz6dvfn5jcWgze4OC1OjmMGn+HEhddF0epPdyO3QcgAcMT9Ry6rllZRO cZSWftBamwrabx+IlH5iLrlqT6YVqh1GHZohtTr2xT6VAEJZKogvjO6foug9Gziy RNmPYtQkkwqzLCzmiJuc2WoyUQxebgUBAqUFp5fWHFHCZ06jTUw16oPV0Q5i9z9H 7iCO0h17tI8WNsWMgjD9NuQ/y6OPFHmI1R+2HVqGQ0PfSizOlweXj5X1YKq+ZPVq mUaqNjNgThCUHX4KFApZ/K5SBGXf355gRc7R/ENxCI3ETwHaikWPfpWySiUmbl2Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeduudegudfgheethfeukefffeetle efgfffgeduveeljefgtdfhudefleffffegieenucffohhmrghinhepghhithhhuhgsrdgt ohhmpdhfrhgvvgguvghskhhtohhprdhorhhgnecukfhppeekgedrvddtvddrieekrdejhe enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggr khhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A10E328005A; Sat, 2 May 2020 09:41:13 -0400 (EDT) From: Marius Bakke To: Christopher Baines Subject: Re: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. In-Reply-To: <87lfmamq6v.fsf@cbaines.net> References: <20200502110314.30403-1-mail@cbaines.net> <87ees24lyr.fsf@devup.no> <87lfmamq6v.fsf@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 15:41:10 +0200 Message-ID: <875zde4fpl.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41022 Cc: 41022@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > Marius Bakke writes: > >> Christopher Baines writes: >> >>> Add a patch based on an upstream commit [1]. >>> >>> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 >>> >>> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add it. >>> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. >> >> [...] >> >>> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> new file mode 100644 >>> index 0000000000..49f41e0c03 >>> --- /dev/null >>> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> @@ -0,0 +1,41 @@ >>> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 >>> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= >>> +Date: Fri, 13 Dec 2019 10:46:20 +0200 >>> +Subject: [PATCH] Fix build with Python 3.8 by also checking for >>> + python-3.X-embed.pc >>> + >>> +Since Python 3.8 the normal checks don't include the Python libraries >>> +anymore and linking of the gst-python module would fail. >>> + >>> +See also https://github.com/mesonbuild/meson/issues/5629 >>> + >>> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >>> +--- >>> + meson.build | 11 +++++++++-- >>> + 1 file changed, 9 insertions(+), 2 deletions(-) >> >> Instead of the git patch format, can you add a short comment at the top >> along with links to the upstream commit and issue like we usually do? > > I usually avoid messing with patches, they're often uncooperative. Would > something I this do? Anything before the "diff ..." line is treated as comments/noop by the patch utility (actually you can add comments between the @@ lines too). > Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since > Python 3.8 the normal checks don't include the Python libraries anymore and > linking of the gst-python module would fail. > > See also https://github.com/mesonbuild/meson/issues/5629 > Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 > > Patch based on upstream commit: > > https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 Perfect, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6teHYACgkQoqBt8qM6 VPq9qAgAkCHyNOOQdTzhjyApcc8hjM9mMRiQv/P/P5Dl/2eoKTNem6C2yiGFUxnA NdoG2MxpOB+qOxBGyS67pgPwcireEkdZO9niL5hCYErg/UnNjf5kdNNbkqXzLgzR +4Gvk0ZvBkz/4ts7txb7lygtisarSG8w2hlazesYEop1p34/jjRU86lQrdhQHE79 VDfv5rSdRC26Gt7FpJx3SOR+tPeHoF0tOYVGdHRRt6HExcHB0GBzGbcyDW4Du1nO pPCDGc4022men6iOIyeAs0g2AfNd9XTeQdZf+7HSKDx6FlF1q1DWFfHnE4750ZO+ gmc4IlpnFvlwCbgYhREy9T2d7vWeDw== =GP5y -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 10:51:09 2020 Received: (at 41022-done) by debbugs.gnu.org; 2 May 2020 14:51:09 +0000 Received: from localhost ([127.0.0.1]:53657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUtTw-00037U-PJ for submit@debbugs.gnu.org; Sat, 02 May 2020 10:51:09 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUtTg-00036p-Ov for 41022-done@debbugs.gnu.org; Sat, 02 May 2020 10:51:07 -0400 Received: from localhost (unknown [46.237.174.129]) by mira.cbaines.net (Postfix) with ESMTPSA id E09D727BBE1; Sat, 2 May 2020 15:50:51 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id af3ad1d1; Sat, 2 May 2020 14:50:49 +0000 (UTC) References: <20200502110314.30403-1-mail@cbaines.net> <87ees24lyr.fsf@devup.no> <87lfmamq6v.fsf@cbaines.net> <875zde4fpl.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Marius Bakke Subject: Re: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. In-reply-to: <875zde4fpl.fsf@devup.no> Date: Sat, 02 May 2020 15:50:49 +0100 Message-ID: <87k11umlva.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41022-done Cc: 41022-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> Marius Bakke writes: >> >>> Instead of the git patch format, can you add a short comment at the top >>> along with links to the upstream commit and issue like we usually do? >> >> I usually avoid messing with patches, they're often uncooperative. Would >> something I this do? > > Anything before the "diff ..." line is treated as comments/noop by the > patch utility (actually you can add comments between the @@ lines too). > >> Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since >> Python 3.8 the normal checks don't include the Python libraries anymore and >> linking of the gst-python module would fail. >> >> See also https://github.com/mesonbuild/meson/issues/5629 >> Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >> >> Patch based on upstream commit: >> >> https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 > > Perfect, thanks! Great, I've pushed this as 20d7dbc77a2b0ed379c0a595daf8d7f852ef3a4c. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6tiMlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdUfxAAgbVoMbunwNkqDfxFoLiJNIIU6HrZU7ryrmpETO+8OUjHyL2y2dBEwSRj 6vTjfdkRXnrPluerEyUxteCdZVrsL4VTiwqxwSZIcTmAGmLg6mI6F/Ja+KgdsFM2 dPxkwei1UTVR+jbZo8Y764zSVSL9vyiOAYZ+5ySJaP+KprzgT12pEFj0KQwjv8BM N6SQG/Ejb6yzrBrOQ3fa83H5vnQWqzD4idlDTsty/4jjdjKbXTG/DahGBHdllHHD r15iw8b/o/UK2ExHkND4fl3v42HWfVEPLfRB5fT6Itn1vEQyI7D7oKacQkEufyMt wjZKtKN784jj8uC7HSXhoYhPZouLr9CA6YnlvOY5ArOwfyMC/YkqzoEPBtoCZ3BQ O7E6aniNbE4Fqv5mAf6LTRYpxk3NIqHRnIImOHiybKeB3/9a9Oa0bQ5PnbRwZ3xA 4cut7EXLGxGwoaaXKOh6tdJcEYKqxJ9OL3jf6j2RiMRMU483ZbxZ/SdT5QKEiVab GoEWS86N207bjjWVSxDb4pV7P9cVnSZyixv18D2dugxRE7BzY6mBYdg0YuqkQfqC WwaBiGTLRfGbIxJA3Or0CO5UAZdSc6DDSJO0fc1mzRNceOjhjL5ep82Zr3LptX1k hNbfagVEsMQrffbjMa1yNmc6bW7J0SP9KycbOhNYk/tSChzGQ0w= =+0Bd -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Sep 10 09:37:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 May 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator