GNU bug report logs - #41015
[PATCH] (incomplete) F2FS support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41015 in the body.
You can then email your comments to 41015 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 02:48:00 +0200

[Message part 1 (text/plain, inline)]

I've been working on this on and off for a while, but can't finish the
last steps, so I'm sending it as is.

What works:
installing to and booting from a partition specified by UUID

What seemed to work but then didn't:
installing to a partition specified by its label. i tried to do the
math, but for some reason it still can't find it. I'm pretty sure it
worked at some point.

What definitely doesn't work:
file system check on boot. I tried and tried to create a statically
linked fsck and I've concluded that it's impossible and that I hate
linkers. Someone else can figure it out, because I've given up.
This means that the init will look for it but won't find it. You will
be thrown into a rescue shell, but if you exit it with `,q`, the init
process continues without any issue.


I used this to set Guix up on my desktop machine on an SSD and
other than the issues I've mentioned, it seems to be working fine.


I'm hoping someone will pick up the work where I left it. If not, I may
revisit it once I've learned enough about how f2fs-tools is built. But I
can't say that I'm eager to devote more of my life to that.


About the patches:
0001-0005 are what you need for a working system, I included the rest
to help anyone who wishes to continue the work.

[0001-file-system-Add-support-for-F2FS.patch (text/x-patch, attachment)]

[0002-gnu-Add-f2fs-tools-static.patch (text/x-patch, attachment)]

[0003-gnu-Add-f2fs-fsck-static.patch (text/x-patch, attachment)]

[0004-linux-initrd-Add-support-for-F2FS.patch (text/x-patch, attachment)]

[0005-disable-fsck.f2fs.patch (text/x-patch, attachment)]

[0006-gnu-f2fs-tools-static-try-only-using-static-util-lin.patch (text/x-patch, attachment)]

[0007-add-temporary-debugger-breakpoint-in-f2fs-tools-stat.patch (text/x-patch, attachment)]

[0008-trying-the-original-approach-glibc-static-adding-a-b.patch (text/x-patch, attachment)]

Message #8 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 11:02:45 +0200

[Message part 1 (text/plain, inline)]

Hi,

thanks!

I know exactly what you mean--I've had some "fun" preparing initrds too.

Pushed the first patch to guix master as commit 23b37c3d40d497cc6f07437ab26ab10e60fb6e09
and a variant of your fourth patch to guix master as commit 27efeef3068bfa21011ea509e21efcbe8c353b5f
so you should be able to at least boot.

Note:

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/tree/include/linux/f2fs_fs.h says volume name can have up to 512 chars.

Your comment says 16, but your code uses 512.  I've fixed comment to say 512.

fsck progress so far: fsck.f2fs links to libuuid dynamically...

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 11:40:32 +0200

[Message part 1 (text/plain, inline)]

fsck progress so far:

Everything except mkfs.f2fs links statically.

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 11:56:54 +0200

[Message part 1 (text/plain, inline)]

Pushed that version of f2fs-tools-static to guix master as commit
807986a55fc2849d6986efb79f9a015cf4132e09 anyway since it is a problem
in our util-linux package.

See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41019

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 11:59:22 +0200

[Message part 1 (text/plain, inline)]

Pushed patch 3 to guix master as commit 2dd2210bf9065c9dcc3ec5412776a88b4df0201b.

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sat, 2 May 2020 12:04:29 +0200

[Message part 1 (text/plain, inline)]

On Sat, 2 May 2020 02:48:00 +0200
raingloom <raingloom <at> riseup.net> wrote:

> What seemed to work but then didn't:
> installing to a partition specified by its label. i tried to do the
> math, but for some reason it still can't find it. I'm pretty sure it
> worked at some point.

Please try:

$ guile --no-auto-compile -L .
((@@ (gnu build file-systems) f2fs-superblock-volume-name)
 ((@@ (gnu build file-systems) read-f2fs-superblock) "your-device"))

[Message part 2 (application/pgp-signature, inline)]

Message #23 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sun, 3 May 2020 12:41:46 +0200

[Message part 1 (text/plain, inline)]

Correction:

Pushed patch 3 to guix master as commit a5cf52d3aa31717a8ae0c2cbbc4b848266ed7818.

[Message part 2 (application/pgp-signature, inline)]

Message #26 received at 41015 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015 <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sun, 3 May 2020 20:47:07 +0200

[Message part 1 (text/plain, inline)]

I've tried it now--it wasn't honoring the UTF-16 NUL termination.
I've fixed it now in guix master commit f73f4b3a2d7a313a6cb1667bd69205ea4b09f57c.

[Message part 2 (application/pgp-signature, inline)]

Message #31 received at 41015-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 41015-done <at> debbugs.gnu.org
Subject: Re: [bug#41015] [PATCH] (incomplete) F2FS support
Date: Sun, 3 May 2020 23:05:49 +0200

[Message part 1 (text/plain, inline)]

On Sat, 2 May 2020 11:56:54 +0200
Danny Milosavljevic <dannym <at> scratchpost.org> wrote:

> See also https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41019

Pushed a workaround for that bug to guix master in commit
da09c63e78ebebeabb347f483d7284b87ff51c2f
and enabled f2fs fsck in commit 33eab4a10dcd2a6580f168f18455df1d4653d14b.

Added system installation test in commit af7a8e718dddd12c3dddf92bfce2f79471fa4a0d.

Added workaround for mising support for UTF-16 in the initrd's guile in
commit bb357c509e1c017e1fef5aa5f4d05beea0c25157.

That concludes this patch series.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.