From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Phillip Lord Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 May 2020 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 40992@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158832175222156 (code B ref -1); Fri, 01 May 2020 08:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 May 2020 08:29:12 +0000 Received: from localhost ([127.0.0.1]:48192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUR2m-0005lI-Gs for submit@debbugs.gnu.org; Fri, 01 May 2020 04:29:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:35800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUR2j-0005l8-0X for submit@debbugs.gnu.org; Fri, 01 May 2020 04:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38368) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUR2K-0008Tb-Aj for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:29:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUR1E-0008LA-70 for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:28:44 -0400 Received: from cloud103.planethippo.com ([78.129.138.110]:43228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUR1D-0006cb-BJ for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:27:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CZj8xBigE2iYqaq1NTaRwrQNU5lMN9a3zk3Tb9W8xpo=; b=Pz+vG3FCmECDK5WRYCmJGenI4v be21r+FcRRDhJtaoGHvMdc1HrAsZt0OlDPQQruy1s4CkD/T5ALOHM/loeuDLq7mLA9PZSSQPj+BVO OzBwZUmvPDHBk8YtXpNqV3lQpEUJcu5D11DWTb4m3BJafQDXXGheu/UTAID++qj4LYvslJotoavJo NBDsCZv+eUazUM1GlZHeCEQODCPsTw2mI/TFXZOrxBUXlHowQATm0gp5GSRJ0KHsvc5aJKa38TLG5 4dwi2jhpQNe9hrxHTL0gwFUZSm789phOfTESWJ4pJFDafp+xabBTwMPnaYRP0bV4w50jsbcMSMTaD rj2cJYtQ==; Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:41022 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUR0U-00063r-VC for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 09:26:51 +0100 From: Phillip Lord Date: Fri, 01 May 2020 09:26:44 +0100 Message-ID: <87sggkawmz.fsf@russet.org.uk> MIME-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: Received-SPF: none client-ip=78.129.138.110; envelope-from=phillip.lord@russet.org.uk; helo=cloud103.planethippo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 04:26:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 78.129.138.110 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Edebug fails while tracing a function, if that function is evaluated during the edebug session. The error reported is: Wrong type argument: listp, # edebug--display-1: Wrong type argument: listp, # This is a regression as it works in Emacs-26, but fails in Emacs-27. Reproduction: In clean emacs -q M-x hanoi jump to hanoi function C-u C-M-x M-x hanoi After stepping through into hanoi with point still in C-M-x and step once more. I use this workflow quite a lot when debugging. I may start to debug a function, decided I have seen enough, to un-instrument so I don't see it debugged again. From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 May 2020 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phillip Lord , Lars Ingebrigtsen Cc: 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158834859612910 (code B ref 40992); Fri, 01 May 2020 15:57:02 +0000 Received: (at 40992) by debbugs.gnu.org; 1 May 2020 15:56:36 +0000 Received: from localhost ([127.0.0.1]:50495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUY1k-0003MA-HL for submit@debbugs.gnu.org; Fri, 01 May 2020 11:56:36 -0400 Received: from colin.muc.de ([193.149.48.1]:33608 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jUY1h-0003Ly-OA for 40992@debbugs.gnu.org; Fri, 01 May 2020 11:56:34 -0400 Received: (qmail 67847 invoked by uid 3782); 1 May 2020 15:56:31 -0000 Received: from acm.muc.de (p4FE15DBE.dip0.t-ipconnect.de [79.225.93.190]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 May 2020 17:56:30 +0200 Received: (qmail 22717 invoked by uid 1000); 1 May 2020 15:56:30 -0000 Date: Fri, 1 May 2020 15:56:30 +0000 Message-ID: <20200501155630.GA22689@ACM> References: <87sggkawmz.fsf@russet.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sggkawmz.fsf@russet.org.uk> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Phillip and Lars. On Fri, May 01, 2020 at 09:26:44 +0100, Phillip Lord wrote: > Edebug fails while tracing a function, if that function is evaluated > during the edebug session. The error reported is: > Wrong type argument: listp, # > edebug--display-1: Wrong type argument: listp, # > This is a regression as it works in Emacs-26, but fails in Emacs-27. Yes. A bit of bisection shows that the commit which introduced this bug is: commit e8b3a15cb6ff187ce08afcb43bd9a0b7907268ca Author: Lars Ingebrigtsen Date: Sun Oct 20 12:07:42 2019 +0200 Mark breakpoints in edebug with highlights * lisp/emacs-lisp/edebug.el (edebug--overlay-breakpoints) (edebug--overlay-breakpoints-remove): New functions (bug#23468). (edebug-modify-breakpoint): Use them to highlight breakpoints. (edebug--display-1): Restore breakpoint highlights. (edebug--recursive-edit): Remove highlights on exit. Lars, have you got any comment on this? > Reproduction: > In clean emacs -q > M-x hanoi > jump to hanoi function > C-u C-M-x > M-x hanoi > After stepping through into hanoi with point still in > C-M-x > and step once more. > I use this workflow quite a lot when debugging. I may start to debug a > function, decided I have seen enough, to un-instrument so I don't see it > debugged again. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 May 2020 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phillip Lord , Lars Ingebrigtsen Cc: 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158835439130255 (code B ref 40992); Fri, 01 May 2020 17:34:01 +0000 Received: (at 40992) by debbugs.gnu.org; 1 May 2020 17:33:11 +0000 Received: from localhost ([127.0.0.1]:50596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZXD-0007rv-J7 for submit@debbugs.gnu.org; Fri, 01 May 2020 13:33:11 -0400 Received: from colin.muc.de ([193.149.48.1]:38665 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jUZXB-0007rm-AL for 40992@debbugs.gnu.org; Fri, 01 May 2020 13:33:10 -0400 Received: (qmail 42287 invoked by uid 3782); 1 May 2020 17:33:07 -0000 Received: from acm.muc.de (p4FE15DBE.dip0.t-ipconnect.de [79.225.93.190]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Fri, 01 May 2020 19:33:06 +0200 Received: (qmail 23067 invoked by uid 1000); 1 May 2020 17:33:06 -0000 Date: Fri, 1 May 2020 17:33:06 +0000 Message-ID: <20200501173306.GB22689@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501155630.GA22689@ACM> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Phillip and Lars. On Fri, May 01, 2020 at 15:56:30 +0000, Alan Mackenzie wrote: > On Fri, May 01, 2020 at 09:26:44 +0100, Phillip Lord wrote: > > Edebug fails while tracing a function, if that function is evaluated > > during the edebug session. The error reported is: > > Wrong type argument: listp, # > > edebug--display-1: Wrong type argument: listp, # > > This is a regression as it works in Emacs-26, but fails in Emacs-27. > Yes. A bit of bisection shows that the commit which introduced this bug > is: > commit e8b3a15cb6ff187ce08afcb43bd9a0b7907268ca > Author: Lars Ingebrigtsen > Date: Sun Oct 20 12:07:42 2019 +0200 > Mark breakpoints in edebug with highlights > * lisp/emacs-lisp/edebug.el (edebug--overlay-breakpoints) > (edebug--overlay-breakpoints-remove): New functions (bug#23468). > (edebug-modify-breakpoint): Use them to highlight breakpoints. > (edebug--display-1): Restore breakpoint highlights. > (edebug--recursive-edit): Remove highlights on exit. > Lars, have you got any comment on this? > > Reproduction: > > In clean emacs -q > > M-x hanoi > > jump to hanoi function > > C-u C-M-x > > M-x hanoi > > After stepping through into hanoi with point still in > > C-M-x > > and step once more. The cause is now clear. When you instrument a function, the symbol is given a property 'edebug, whose value is a list of edebug information. It is this list which edebug--overlay-breakpoints is trying to access when it throws the error. When you recompile the function without instrumentation, edebug sets the 'edebug property to the marker #. This non-list value of the property acts elsewhere as a signal that the function isn't instrumented. This is a fundamental problem, that the edebug information is attached to the symbol `hanoi' rather than to the (instrumented) function which is no longer the symbol-function of `hanoi'. Sadly, there is no way of attaching a property to a function, only to a symbol (or a buffer position). There doesn't appear to be a good way of solving this bug. A workable workaround would be to check that the 'edebug property value is a list in edebug--overlay-breakpoints, and just to remove the breakpoint highlights when it's not a list. When it's not a list, it's a marker pointing to the start of the function, from which the end of the function can be found, to serve as the END argument to edebug--overlay-breakpoints-remove. Or something like that. :-( > > I use this workflow quite a lot when debugging. I may start to debug a > > function, decided I have seen enough, to un-instrument so I don't see it > > debugged again. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 May 2020 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: larsi@gnus.org, 40992@debbugs.gnu.org, phillip.lord@russet.org.uk Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.1588356171785 (code B ref 40992); Fri, 01 May 2020 18:03:02 +0000 Received: (at 40992) by debbugs.gnu.org; 1 May 2020 18:02:51 +0000 Received: from localhost ([127.0.0.1]:50615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZzv-0000Cb-9Y for submit@debbugs.gnu.org; Fri, 01 May 2020 14:02:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZzs-0000CN-Sm for 40992@debbugs.gnu.org; Fri, 01 May 2020 14:02:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32783) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUZzn-0006hU-3Q; Fri, 01 May 2020 14:02:43 -0400 Received: from [176.228.60.248] (port=2009 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUZzj-00018N-DA; Fri, 01 May 2020 14:02:40 -0400 Date: Fri, 01 May 2020 21:02:28 +0300 Message-Id: <83mu6rv8i3.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20200501173306.GB22689@ACM> (message from Alan Mackenzie on Fri, 1 May 2020 17:33:06 +0000) References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 1 May 2020 17:33:06 +0000 > From: Alan Mackenzie > Cc: 40992@debbugs.gnu.org > > There doesn't appear to be a good way of solving this bug. A workable > workaround would be to check that the 'edebug property value is a list > in edebug--overlay-breakpoints, and just to remove the breakpoint > highlights when it's not a list. When it's not a list, it's a marker > pointing to the start of the function, from which the end of the > function can be found, to serve as the END argument to > edebug--overlay-breakpoints-remove. > > Or something like that. :-( How about if we revert the offending commit on emacs-27? The feature it adds doesn't sound important enough when compared to the breakage it causes. From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: 40992@debbugs.gnu.org, Phillip Lord Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158838380121812 (code B ref 40992); Sat, 02 May 2020 01:44:01 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 01:43:21 +0000 Received: from localhost ([127.0.0.1]:51020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUhBY-0005fj-Om for submit@debbugs.gnu.org; Fri, 01 May 2020 21:43:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUhBV-0005fW-SJ for 40992@debbugs.gnu.org; Fri, 01 May 2020 21:43:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T7fhy8iqSAI5R2ghBVV6zcIY2QjYS2a9o/oVQSUzct8=; b=ap4IzLPK1dlHpo/jCdzj8GgHo0 ObNNKLp/Q4fKLrbNayNPOMH8xIfUc/Tt60ecKjOkFoirNinY+0B+u2phwtCCnPm2tKJez5u7q7bYj sRRKtSpsDWckLE5A77PLuiVgpYdo6oWLJDi0QAALNDd6Ob+a7k1jXRNIyzjJOFaPEdD8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUhBM-0004Gn-Cq; Sat, 02 May 2020 03:43:11 +0200 From: Lars Ingebrigtsen References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> Date: Sat, 02 May 2020 03:43:07 +0200 In-Reply-To: <20200501173306.GB22689@ACM> (Alan Mackenzie's message of "Fri, 1 May 2020 17:33:06 +0000") Message-ID: <87o8r7xgb8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alan Mackenzie writes: > There doesn't appear to be a good way of solving this bug. A workable > workaround would be to check that the 'edebug property value is a list > in edebug--overlay-breakpoints, and just to remove th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Mackenzie writes: > There doesn't appear to be a good way of solving this bug. A workable > workaround would be to check that the 'edebug property value is a list > in edebug--overlay-breakpoints, and just to remove the breakpoint > highlights when it's not a list. When it's not a list, it's a marker > pointing to the start of the function, from which the end of the > function can be found, to serve as the END argument to > edebug--overlay-breakpoints-remove. > > Or something like that. :-( I think that sounds like a good solution on master, but the patch that introduced this should probably be reverted on emacs-27 -- it wasn't a bug fix, but a new feature, so reverting it should be safe, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 03:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Alan Mackenzie , Phillip Lord , 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158838875529532 (code B ref 40992); Sat, 02 May 2020 03:06:02 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 03:05:55 +0000 Received: from localhost ([127.0.0.1]:51046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUiTT-0007gF-7s for submit@debbugs.gnu.org; Fri, 01 May 2020 23:05:55 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:37317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUiTM-0007fw-Vh for 40992@debbugs.gnu.org; Fri, 01 May 2020 23:05:53 -0400 Received: by mail-qk1-f178.google.com with SMTP id c10so158145qka.4 for <40992@debbugs.gnu.org>; Fri, 01 May 2020 20:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1Lx0KketHIUEzktUweZlPh8234FIDLXXsRsPyUHY3zM=; b=c/pj5Iop5HX55tEDTz9C4HhLpGQFz0omn7tOIdjYtotNFY5Dq6L7E26TyN3EW+v1pj F1LaBOXHud3RPRES1mxc0Lr1g9zTyhi+ihn5vW0H8h0ydn9kKERVVW5cx5htyfD1A3sq kXT8dfqRu9fQXCoFbGMbHmvva62jurKslitxnReUqOOlQKx2PMfGsIAOHTX//BqcONs4 6DUT72lmdDT+y+rJtLYZDBbaVmQ0wXZDcNn5ayXA6eGzDD2EB/EAe26h/ZFb0O1MtRAC z7RA68nZqkvRBWQg/bh9IULH1frCV9ZgL0FolNsUl4lQha0LcC6Ktphvxfb/Nb9p8teE 04Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1Lx0KketHIUEzktUweZlPh8234FIDLXXsRsPyUHY3zM=; b=pY1VizBOrTuNatcEje7hd8QJcv+JniTdkum3HoO2UH2vOFg006hH+G28WEoFhWLVMB U00PvpP9LervIxYOr4hRApsAXIWf+brj0eFkOGYjYi8HDI3MZ5FF3cZ+75bpEUTyY1Ap D5BkKff3fbELXStLRRaw/mqF2fLe6bWo4A8oS25BSNfwBltStYZ0xnaEIQjNkcnbQzsX UYjm10TgP8eNAQKj/rL0WBtxcgFtUkNFSwstqWbOc/phUlmc8d6kieh337UzC5QouPbX ivIouiIkUHMsJ0UIByn6BCPLvrJcRKDTEUzz7eLInGSide75bImOuhHpWHkzNwrAUyvL Csig== X-Gm-Message-State: AGi0PuZMzSy1FFoDfXCImYn8TupMVYgNLj/QGxWiAWu8OG4hot2WH4Nx uC8QX5UdglcT8Wv8sLjqSqDonnGr X-Google-Smtp-Source: APiQypLWFypRjUREsRltCJjHnD93DceRAgXsTJgmSUlM5a77LuChWJdVHRHjU41z8tLtfcxJtX/Ipg== X-Received: by 2002:a37:7ec3:: with SMTP id z186mr6825602qkc.108.1588388743412; Fri, 01 May 2020 20:05:43 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id m83sm4201846qke.117.2020.05.01.20.05.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 May 2020 20:05:42 -0700 (PDT) From: Noam Postavsky References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> Date: Fri, 01 May 2020 23:05:32 -0400 In-Reply-To: <87o8r7xgb8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 02 May 2020 03:43:07 +0200") Message-ID: <87sggjm3yb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alan Mackenzie writes: > >> There doesn't appear to be a good way of solving this bug. A workable >> workaround would be to check that the 'edebug property value is a list >> in edebug--overlay-breakpoints, and just to remove the breakpoint >> highlights when it's not a list. When it's not a list, it's a marker >> pointing to the start of the function, from which the end of the >> function can be found, to serve as the END argument to >> edebug--overlay-breakpoints-remove. >> >> Or something like that. :-( > > I think that sounds like a good solution on master, but the patch that > introduced this should probably be reverted on emacs-27 -- it wasn't a > bug fix, but a new feature, so reverting it should be safe, I think. I don't understand; the fix looks trivial to me (leaving out indentation), and only touches a new function. Surely this is okay for emacs-27? --- i/lisp/emacs-lisp/edebug.el +++ w/lisp/emacs-lisp/edebug.el @@ -3236,8 +3236,9 @@ 'edebug-breakpoint "\x3c\x7e\xff\xff\xff\xff\x7e\x3c") (defun edebug--overlay-breakpoints (function) - (let* ((data (get function 'edebug)) - (start (nth 0 data)) + (let ((data (get function 'edebug))) + (when (listp data) + (let* ((start (nth 0 data)) (breakpoints (nth 1 data)) (offsets (nth 2 data))) ;; First remove all old breakpoint overlays. @@ -3264,6 +3265,7 @@ edebug--overlay-breakpoints (propertize "x" 'display `(left-fringe edebug-breakpoint ,face))))))))) + )) (defun edebug--overlay-breakpoints-remove (start end) (dolist (overlay (overlays-in start end)) From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: acm@muc.de, larsi@gnus.org, phillip.lord@russet.org.uk, 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158840342230253 (code B ref 40992); Sat, 02 May 2020 07:11:02 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 07:10:22 +0000 Received: from localhost ([127.0.0.1]:51123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUmI2-0007rt-El for submit@debbugs.gnu.org; Sat, 02 May 2020 03:10:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUmI0-0007rd-QY for 40992@debbugs.gnu.org; Sat, 02 May 2020 03:10:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51958) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUmHu-0004Us-4b; Sat, 02 May 2020 03:10:14 -0400 Received: from [176.228.60.248] (port=2019 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUmHt-0002Be-HY; Sat, 02 May 2020 03:10:13 -0400 Date: Sat, 02 May 2020 10:10:04 +0300 Message-Id: <83wo5uu81f.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sggjm3yb.fsf@gmail.com> (message from Noam Postavsky on Fri, 01 May 2020 23:05:32 -0400) References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Date: Fri, 01 May 2020 23:05:32 -0400 > Cc: Alan Mackenzie , 40992@debbugs.gnu.org, > Phillip Lord > > > I think that sounds like a good solution on master, but the patch that > > introduced this should probably be reverted on emacs-27 -- it wasn't a > > bug fix, but a new feature, so reverting it should be safe, I think. > > I don't understand; the fix looks trivial to me (leaving out > indentation), and only touches a new function. Surely this is okay for > emacs-27? If this fixes the problem, it's okay for emacs-27. But then why did Alan say there was no easy solution? From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: Lars Ingebrigtsen , Phillip Lord , 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.15884252898614 (code B ref 40992); Sat, 02 May 2020 13:15:02 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 13:14:49 +0000 Received: from localhost ([127.0.0.1]:51527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUryj-0002Es-Gq for submit@debbugs.gnu.org; Sat, 02 May 2020 09:14:49 -0400 Received: from colin.muc.de ([193.149.48.1]:14356 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jUryh-0002Ei-Dt for 40992@debbugs.gnu.org; Sat, 02 May 2020 09:14:48 -0400 Received: (qmail 98779 invoked by uid 3782); 2 May 2020 13:14:45 -0000 Received: from acm.muc.de (p2E5D51F4.dip0.t-ipconnect.de [46.93.81.244]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sat, 02 May 2020 15:14:42 +0200 Received: (qmail 6858 invoked by uid 1000); 2 May 2020 13:14:42 -0000 Date: Sat, 2 May 2020 13:14:42 +0000 Message-ID: <20200502131442.GB6832@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sggjm3yb.fsf@gmail.com> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Noam, Eli, Lars, and Phillip. On Fri, May 01, 2020 at 23:05:32 -0400, Noam Postavsky wrote: > Lars Ingebrigtsen writes: > > Alan Mackenzie writes: > >> There doesn't appear to be a good way of solving this bug. A workable > >> workaround would be to check that the 'edebug property value is a list > >> in edebug--overlay-breakpoints, and just to remove the breakpoint > >> highlights when it's not a list. When it's not a list, it's a marker > >> pointing to the start of the function, from which the end of the > >> function can be found, to serve as the END argument to > >> edebug--overlay-breakpoints-remove. > >> Or something like that. :-( > > I think that sounds like a good solution on master, but the patch that > > introduced this should probably be reverted on emacs-27 -- it wasn't a > > bug fix, but a new feature, so reverting it should be safe, I think. > I don't understand; the fix looks trivial to me (leaving out > indentation), and only touches a new function. Surely this is okay for > emacs-27? > --- i/lisp/emacs-lisp/edebug.el > +++ w/lisp/emacs-lisp/edebug.el > @@ -3236,8 +3236,9 @@ 'edebug-breakpoint > "\x3c\x7e\xff\xff\xff\xff\x7e\x3c") > (defun edebug--overlay-breakpoints (function) > - (let* ((data (get function 'edebug)) > - (start (nth 0 data)) > + (let ((data (get function 'edebug))) > + (when (listp data) > + (let* ((start (nth 0 data)) > (breakpoints (nth 1 data)) > (offsets (nth 2 data))) > ;; First remove all old breakpoint overlays. > @@ -3264,6 +3265,7 @@ edebug--overlay-breakpoints > (propertize > "x" 'display > `(left-fringe edebug-breakpoint ,face))))))))) > + )) > (defun edebug--overlay-breakpoints-remove (start end) > (dolist (overlay (overlays-in start end)) That function might not remove any existing breakpoint highlights (which normally would get removed by the call to edebug--overlay-breakpoints-remove, which takes the value of the 'edebug property (indirectly) as an argument. I've tried vaguely to create a situation where the highlights get left in place, but haven't managed it yet. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: larsi@gnus.org, phillip.lord@russet.org.uk, Noam Postavsky , 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158842650818865 (code B ref 40992); Sat, 02 May 2020 13:36:02 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 13:35:08 +0000 Received: from localhost ([127.0.0.1]:51580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsI9-0004ta-Nr for submit@debbugs.gnu.org; Sat, 02 May 2020 09:35:08 -0400 Received: from colin.muc.de ([193.149.48.1]:15411 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jUsI7-0004tR-K8 for 40992@debbugs.gnu.org; Sat, 02 May 2020 09:34:52 -0400 Received: (qmail 13978 invoked by uid 3782); 2 May 2020 13:34:50 -0000 Received: from acm.muc.de (p2E5D51F4.dip0.t-ipconnect.de [46.93.81.244]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sat, 02 May 2020 15:34:47 +0200 Received: (qmail 6871 invoked by uid 1000); 2 May 2020 13:34:47 -0000 Date: Sat, 2 May 2020 13:34:47 +0000 Message-ID: <20200502133447.GC6832@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83wo5uu81f.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Sat, May 02, 2020 at 10:10:04 +0300, Eli Zaretskii wrote: > > From: Noam Postavsky > > Date: Fri, 01 May 2020 23:05:32 -0400 > > Cc: Alan Mackenzie , 40992@debbugs.gnu.org, > > Phillip Lord > > > I think that sounds like a good solution on master, but the patch that > > > introduced this should probably be reverted on emacs-27 -- it wasn't a > > > bug fix, but a new feature, so reverting it should be safe, I think. > > I don't understand; the fix looks trivial to me (leaving out > > indentation), and only touches a new function. Surely this is okay for > > emacs-27? > If this fixes the problem, it's okay for emacs-27. But then why did > Alan say there was no easy solution? I think I said "good" rather than "easy". This 'edebug property is essentially associated with a function, but is in a symbol's property list. Noam's fix, I think, will either leave stale highlights on what used to be breakpoints, or won't leave the highlights active whilst the debugging is still in progress. It might be the least bad fix, though. At the time of debugging, there are _two_ functions associated with `hanoi', the one just compiled with C-M-x, and the instrumented one still being debugged (which will soon find its way to the garbage collector). There is no way to attach a property list to a function (and it's too late to add one for Emacs 27 ;-), so prop 'edebug gets on the symbol's plist, and confusion results. Hence this bug. A good solution would fix this confusion. I can't think of a way to do this which doesn't involve deep surgery on Emacs's internals. I think the same mechanism is behind the annoying bug (not yet reported by me) where you do M-x compile-defun on a previously instrumented function, then try to instrument it again by typing I (`edebug-instrument-callee') whilst in Edebug. You get the spurious error message "Already instrumented". -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: larsi@gnus.org, phillip.lord@russet.org.uk, npostavs@gmail.com, 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158842786622992 (code B ref 40992); Sat, 02 May 2020 13:58:02 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 13:57:46 +0000 Received: from localhost ([127.0.0.1]:53524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUseE-0005yi-K4 for submit@debbugs.gnu.org; Sat, 02 May 2020 09:57:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUseD-0005yW-8k for 40992@debbugs.gnu.org; Sat, 02 May 2020 09:57:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57848) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUse7-0005cW-Sq; Sat, 02 May 2020 09:57:35 -0400 Received: from [176.228.60.248] (port=3015 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUse6-0002Cg-Gy; Sat, 02 May 2020 09:57:35 -0400 Date: Sat, 02 May 2020 16:57:26 +0300 Message-Id: <83tv0ysam1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20200502133447.GC6832@ACM> (message from Alan Mackenzie on Sat, 2 May 2020 13:34:47 +0000) References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> <20200502133447.GC6832@ACM> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 2 May 2020 13:34:47 +0000 > Cc: Noam Postavsky , larsi@gnus.org, > 40992@debbugs.gnu.org, phillip.lord@russet.org.uk > From: Alan Mackenzie > > Noam's fix, I think, will either leave stale highlights on what used to > be breakpoints, or won't leave the highlights active whilst the > debugging is still in progress. It might be the least bad fix, though. If Noam's fix is incomplete, I still think reverting the feature on emacs-27 is a better solution. We should continue working on this on master until we find a better solution. From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Phillip Lord Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: acm@muc.de, larsi@gnus.org, Noam Postavsky , 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158845650630546 (code B ref 40992); Sat, 02 May 2020 21:56:01 +0000 Received: (at 40992) by debbugs.gnu.org; 2 May 2020 21:55:06 +0000 Received: from localhost ([127.0.0.1]:54063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jV06E-0007wb-4l for submit@debbugs.gnu.org; Sat, 02 May 2020 17:55:06 -0400 Received: from cloud103.planethippo.com ([78.129.138.110]:60258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jV06B-0007vx-Hi for 40992@debbugs.gnu.org; Sat, 02 May 2020 17:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yYBnj3Y8F73sz8zijDTmPssDlPDM3xAS6HDztecPwqY=; b=lPgRANc992OPkFEG0YE0mgQBK 0wHytWC7wfLu+F3IniFXrlfjtNDYRFDkhdtX4GpmLHdmppH6f26m7Yzmv1YDn+NFN0Fbjyr6KhpoM RSG0qKZEXOyhBN6qr2zWW4wkhEqS2LSs2ndedT1GVyk+GG2tdVJCZkHCwOql41YDnvYi5cf/xrUMl SW8QfiESYZfyLb6OQCBZZd+Ifm4RhkDzKLBMXfHP71Ps6eyLsf8wghreY50iK3J788Wh3BM3ln5dP 0FiZEuDKBZ01z/5vSEieOGnev1qGSDy4fWM6ANYK+drhY8ey03kD829wtlC5uNQwas0GKBFIxVUqr J4W/ZlSyA==; Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:43656 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jV065-00010f-1V; Sat, 02 May 2020 22:54:57 +0100 From: Phillip Lord References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> Date: Sat, 02 May 2020 22:54:52 +0100 In-Reply-To: <83wo5uu81f.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 May 2020 10:10:04 +0300") Message-ID: <875zde3sur.fsf@russet.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Fri, 01 May 2020 23:05:32 -0400 >> Cc: Alan Mackenzie , 40992@debbugs.gnu.org, >> Phillip Lord >> >> > I think that sounds like a good solution on master, but the patch that >> > introduced this should probably be reverted on emacs-27 -- it wasn't a >> > bug fix, but a new feature, so reverting it should be safe, I think. >> >> I don't understand; the fix looks trivial to me (leaving out >> indentation), and only touches a new function. Surely this is okay for >> emacs-27? > > If this fixes the problem, it's okay for emacs-27. But then why did > Alan say there was no easy solution? I guess it's because the edebug should really still be using the overlay information for the function it is still stepping through. When I do this, it's because I do not want the function instrumented any more; I'd probably be just as happy if edebug dropped out at this point (i.e. stopped stepping through and continued). That I can step through a function definition that is no longer instrumented is not really a feature for me. Not having it error, clearly, is a feature! Thanks all for looking at this. Phil From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2020 11:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: larsi@gnus.org, phillip.lord@russet.org.uk, npostavs@gmail.com, 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158850690915142 (code B ref 40992); Sun, 03 May 2020 11:56:01 +0000 Received: (at 40992) by debbugs.gnu.org; 3 May 2020 11:55:09 +0000 Received: from localhost ([127.0.0.1]:54817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVDDB-0003wA-3M for submit@debbugs.gnu.org; Sun, 03 May 2020 07:55:09 -0400 Received: from colin.muc.de ([193.149.48.1]:51524 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jVDD9-0003vy-58 for 40992@debbugs.gnu.org; Sun, 03 May 2020 07:55:07 -0400 Received: (qmail 50856 invoked by uid 3782); 3 May 2020 11:55:05 -0000 Received: from acm.muc.de (p2E5D57CC.dip0.t-ipconnect.de [46.93.87.204]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 03 May 2020 13:55:04 +0200 Received: (qmail 5972 invoked by uid 1000); 3 May 2020 11:55:04 -0000 Date: Sun, 3 May 2020 11:55:04 +0000 Message-ID: <20200503115504.GC5721@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> <20200502133447.GC6832@ACM> <83tv0ysam1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83tv0ysam1.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, everybody. On Sat, May 02, 2020 at 16:57:26 +0300, Eli Zaretskii wrote: > > Date: Sat, 2 May 2020 13:34:47 +0000 > > Cc: Noam Postavsky , larsi@gnus.org, > > 40992@debbugs.gnu.org, phillip.lord@russet.org.uk > > From: Alan Mackenzie > > Noam's fix, I think, will either leave stale highlights on what used to > > be breakpoints, or won't leave the highlights active whilst the > > debugging is still in progress. It might be the least bad fix, though. > If Noam's fix is incomplete, I still think reverting the feature on > emacs-27 is a better solution. We should continue working on this on > master until we find a better solution. OK. I've reverted the feature in the emacs-27 branch (with a directive not to merge to master). This should fix the bug in emacs-27. I've had two ideas about fixing this bug in master whilst leaving the breakpoint highlight feature in place: (i): (Please bear in mind it was ~04:30 when I thought this up. ;-) To each type of function (subr, byte-compile, lambda form, closure form) we add an extra field for a @dfn{function property list}, possibly optional. For dumped functions, the contents will be the index into a vector holding lots of function property lists. For functions in r/w storage, we have a property list directly. We will have functions like put-function-property, get-function-property, remove-function-properties. Having got this infrastructure, edebug will now store the 'edebug property on this function-property-list, and the problems we've had with the symbol-plist just evaporate. (ii) We devise a new (symbol-) property called something like 'ghost-edebug. When an instrumented function gets recompiled by C-M-x, etc., the previous contents of 'edebug get moved to 'ghost-edebug, and 'edebug gets a marker, as it currently does. Whilst manipulating the breakpoint highlights, edebug will use 'ghost-edebug when 'edebug holds a marker. The 'ghost-edebug property will be removed when the `hanoi' function is next instrumented. Maybe this will work. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Phillip Lord Subject: bug#40992: closed (Re: bug#40992: 27.0.90; Evaluating a function while using edebug breaks) Message-ID: References: <20200503121331.GD5721@ACM> <87sggkawmz.fsf@russet.org.uk> X-Gnu-PR-Message: they-closed 40992 X-Gnu-PR-Package: emacs Reply-To: 40992@debbugs.gnu.org Date: Sun, 03 May 2020 12:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1588508042-16953-1" This is a multi-part message in MIME format... ------------=_1588508042-16953-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #40992: 27.0.90; Evaluating a function while using edebug breaks which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40992@debbugs.gnu.org. --=20 40992: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40992 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1588508042-16953-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 40992-done) by debbugs.gnu.org; 3 May 2020 12:13:35 +0000 Received: from localhost ([127.0.0.1]:54827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVDV0-0004OB-V0 for submit@debbugs.gnu.org; Sun, 03 May 2020 08:13:35 -0400 Received: from colin.muc.de ([193.149.48.1]:52440 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jVDV0-0004O1-06 for 40992-done@debbugs.gnu.org; Sun, 03 May 2020 08:13:34 -0400 Received: (qmail 66099 invoked by uid 3782); 3 May 2020 12:13:32 -0000 Received: from acm.muc.de (p2E5D57CC.dip0.t-ipconnect.de [46.93.87.204]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 03 May 2020 14:13:31 +0200 Received: (qmail 5992 invoked by uid 1000); 3 May 2020 12:13:31 -0000 Date: Sun, 3 May 2020 12:13:31 +0000 To: 40992-done@debbugs.gnu.org Subject: Re: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Message-ID: <20200503121331.GD5721@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> <20200502133447.GC6832@ACM> <83tv0ysam1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83tv0ysam1.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40992-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Bug fixed in the emacs-27 branch by reverting commit commit e8b3a15cb6ff187ce08afcb43bd9a0b7907268ca Author: Lars Ingebrigtsen Date: Sun Oct 20 12:07:42 2019 +0200 Mark breakpoints in edebug with highlights * lisp/emacs-lisp/edebug.el (edebug--overlay-breakpoints) (edebug--overlay-breakpoints-remove): New functions (bug#23468). (edebug-modify-breakpoint): Use them to highlight breakpoints. (edebug--display-1): Restore breakpoint highlights. (edebug--recursive-edit): Remove highlights on exit. -- Alan Mackenzie (Nuremberg, Germany). ------------=_1588508042-16953-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 May 2020 08:29:12 +0000 Received: from localhost ([127.0.0.1]:48192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUR2m-0005lI-Gs for submit@debbugs.gnu.org; Fri, 01 May 2020 04:29:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:35800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUR2j-0005l8-0X for submit@debbugs.gnu.org; Fri, 01 May 2020 04:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38368) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUR2K-0008Tb-Aj for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:29:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUR1E-0008LA-70 for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:28:44 -0400 Received: from cloud103.planethippo.com ([78.129.138.110]:43228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUR1D-0006cb-BJ for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 04:27:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CZj8xBigE2iYqaq1NTaRwrQNU5lMN9a3zk3Tb9W8xpo=; b=Pz+vG3FCmECDK5WRYCmJGenI4v be21r+FcRRDhJtaoGHvMdc1HrAsZt0OlDPQQruy1s4CkD/T5ALOHM/loeuDLq7mLA9PZSSQPj+BVO OzBwZUmvPDHBk8YtXpNqV3lQpEUJcu5D11DWTb4m3BJafQDXXGheu/UTAID++qj4LYvslJotoavJo NBDsCZv+eUazUM1GlZHeCEQODCPsTw2mI/TFXZOrxBUXlHowQATm0gp5GSRJ0KHsvc5aJKa38TLG5 4dwi2jhpQNe9hrxHTL0gwFUZSm789phOfTESWJ4pJFDafp+xabBTwMPnaYRP0bV4w50jsbcMSMTaD rj2cJYtQ==; Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:41022 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUR0U-00063r-VC for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 09:26:51 +0100 From: Phillip Lord To: bug-gnu-emacs@gnu.org Subject: 27.0.90; Evaluating a function while using edebug breaks Date: Fri, 01 May 2020 09:26:44 +0100 Message-ID: <87sggkawmz.fsf@russet.org.uk> MIME-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: Received-SPF: none client-ip=78.129.138.110; envelope-from=phillip.lord@russet.org.uk; helo=cloud103.planethippo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 04:26:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 78.129.138.110 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Edebug fails while tracing a function, if that function is evaluated during the edebug session. The error reported is: Wrong type argument: listp, # edebug--display-1: Wrong type argument: listp, # This is a regression as it works in Emacs-26, but fails in Emacs-27. Reproduction: In clean emacs -q M-x hanoi jump to hanoi function C-u C-M-x M-x hanoi After stepping through into hanoi with point still in C-M-x and step once more. I use this workflow quite a lot when debugging. I may start to debug a function, decided I have seen enough, to un-instrument so I don't see it debugged again. ------------=_1588508042-16953-1-- From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks References: <87sggkawmz.fsf@russet.org.uk> In-Reply-To: <87sggkawmz.fsf@russet.org.uk> Resent-From: Pouar Dragon Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 May 2020 02:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.15885587894641 (code B ref 40992); Mon, 04 May 2020 02:20:02 +0000 Received: (at 40992) by debbugs.gnu.org; 4 May 2020 02:19:49 +0000 Received: from localhost ([127.0.0.1]:58693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVQhx-0001Cm-E1 for submit@debbugs.gnu.org; Sun, 03 May 2020 22:19:49 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:38667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVPvl-0008RU-BX for 40992@debbugs.gnu.org; Sun, 03 May 2020 21:30:01 -0400 Received: by mail-ot1-f49.google.com with SMTP id g19so7634184otk.5 for <40992@debbugs.gnu.org>; Sun, 03 May 2020 18:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=RmsKJsLMO0TUTs38Zk8d+hAMCk2wHcIKP0sCE31sgZU=; b=Qy0AF/KlrFDdwsqAMhLdWaKntaHcNx+hFcFrdr0ovQkZPa9dH1b1g8i/3bFnRGk+LM rDn9Zih2wGFZEcR34SXpevswZYCSS3vnYvwaDZPXNXVloB6uX3dzlC9MYTV0lqH6IjIw HAUNq7qQcqCfPjtyn2U91qNgCCjWu1B/988WudGBhNBDpmuijU/PwOgK8/kF8c+54E3Z 5Yu9aHWLA0NlAalW8Zhpm9VxoSij4Ugs0eM7+3spwVleFIxgAyHWpkeOBzvCQjS7xvCI mzbNKscMFAncG7rCGTpoueg1/doDSUi+A9JqWPEKn8dkz1y7v1Wy3iwOQNiurC1svVdk 6FWA== X-Gm-Message-State: AGi0PubSKIjvczZ+3R3oH5EEm0x4hrw+pzwqvONRYPDz+Gg6oX8ftMQx ivIsEmKWy3/yv25PaBhUjrfoBpb5 X-Google-Smtp-Source: APiQypJLA98Yl71Zscz3Bt8rMtJmJaRwAtzbJJuWZEEgS2H8MfHIDSBcPj1jtdaaucgMKtmKRGyDwQ== X-Received: by 2002:a05:6830:2421:: with SMTP id k1mr11710615ots.279.1588555795463; Sun, 03 May 2020 18:29:55 -0700 (PDT) Received: from ArchServer ([2600:1700:f720:fee8:21d:92ff:fe33:9efc]) by smtp.gmail.com with ESMTPSA id p24sm2829298otp.73.2020.05.03.18.29.54 for <40992@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 03 May 2020 18:29:54 -0700 (PDT) Received: from PouarArch (PouarArch [192.168.2.64]) by ArchServer (OpenSMTPD) with ESMTPS id eb70d420 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <40992@debbugs.gnu.org>; Mon, 4 May 2020 01:29:32 +0000 (UTC) Received: from localhost (PouarArch [local]) by PouarArch (OpenSMTPD) with ESMTPA id 1773596e for <40992@debbugs.gnu.org>; Mon, 4 May 2020 01:27:16 +0000 (UTC) User-agent: mu4e 1.4.1; emacs 27.0.91 From: Pouar Dragon Date: Sun, 03 May 2020 20:27:16 -0500 Message-ID: <87y2q87amj.fsf@pouar.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Mailman-Approved-At: Sun, 03 May 2020 22:19:48 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) There's still some code in edebug.el that calls edebug--overlay-breakpoints-remove and edebug--overlay-breakpoints -- Pouar Dragon My GPG Keys: https://keybase.io/pouar From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 May 2020 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pouar Dragon Cc: 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158861726813210 (code B ref 40992); Mon, 04 May 2020 18:35:02 +0000 Received: (at 40992) by debbugs.gnu.org; 4 May 2020 18:34:28 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVfv9-0003R0-Sd for submit@debbugs.gnu.org; Mon, 04 May 2020 14:34:28 -0400 Received: from colin.muc.de ([193.149.48.1]:20300 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jVfv8-0003Qq-CY for 40992@debbugs.gnu.org; Mon, 04 May 2020 14:34:26 -0400 Received: (qmail 17438 invoked by uid 3782); 4 May 2020 18:34:24 -0000 Received: from acm.muc.de (p4FE15D33.dip0.t-ipconnect.de [79.225.93.51]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Mon, 04 May 2020 20:34:23 +0200 Received: (qmail 26236 invoked by uid 1000); 4 May 2020 18:34:22 -0000 Date: Mon, 4 May 2020 18:34:22 +0000 Message-ID: <20200504183422.GA26211@ACM> References: <87sggkawmz.fsf@russet.org.uk> <87y2q87amj.fsf@pouar.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2q87amj.fsf@pouar.net> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Pouar. On Sun, May 03, 2020 at 20:27:16 -0500, Pouar Dragon wrote: > There's still some code in edebug.el that calls > edebug--overlay-breakpoints-remove and edebug--overlay-breakpoints > -- > Pouar Dragon > My GPG Keys: https://keybase.io/pouar Yes, you're right. I'd neglected to compile the file under emacs -Q, so didn't spot the errors. It should be fixed, now. Sorry about the annoyance this must have caused, and thanks for reporting it. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:36:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40992: 27.0.90; Evaluating a function while using edebug breaks Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 May 2020 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phillip Lord Cc: larsi@gnus.org, Eli Zaretskii , Noam Postavsky , 40992@debbugs.gnu.org Received: via spool by 40992-submit@debbugs.gnu.org id=B40992.158922819432262 (code B ref 40992); Mon, 11 May 2020 20:17:01 +0000 Received: (at 40992) by debbugs.gnu.org; 11 May 2020 20:16:34 +0000 Received: from localhost ([127.0.0.1]:53415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEqo-0008OH-9f for submit@debbugs.gnu.org; Mon, 11 May 2020 16:16:34 -0400 Received: from colin.muc.de ([193.149.48.1]:61097 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jYEqm-0008O8-8j for 40992@debbugs.gnu.org; Mon, 11 May 2020 16:16:32 -0400 Received: (qmail 16489 invoked by uid 3782); 11 May 2020 20:16:30 -0000 Received: from acm.muc.de (p4FE15C1A.dip0.t-ipconnect.de [79.225.92.26]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Mon, 11 May 2020 22:16:29 +0200 Received: (qmail 4602 invoked by uid 1000); 11 May 2020 20:16:30 -0000 Date: Mon, 11 May 2020 20:16:30 +0000 Message-ID: <20200511201630.GA4577@ACM> References: <87sggkawmz.fsf@russet.org.uk> <20200501155630.GA22689@ACM> <20200501173306.GB22689@ACM> <87o8r7xgb8.fsf@gnus.org> <87sggjm3yb.fsf@gmail.com> <83wo5uu81f.fsf@gnu.org> <875zde3sur.fsf@russet.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875zde3sur.fsf@russet.org.uk> X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Phillip. On Sat, May 02, 2020 at 22:54:52 +0100, Phillip Lord wrote: > Eli Zaretskii writes: > >> From: Noam Postavsky > >> Date: Fri, 01 May 2020 23:05:32 -0400 > >> Cc: Alan Mackenzie , 40992@debbugs.gnu.org, > >> Phillip Lord > > If this fixes the problem, it's okay for emacs-27. But then why did > > Alan say there was no easy solution? > I guess it's because the edebug should really still be using the overlay > information for the function it is still stepping through. > When I do this, it's because I do not want the function instrumented any > more; I'd probably be just as happy if edebug dropped out at this point > (i.e. stopped stepping through and continued). That I can step through a > function definition that is no longer instrumented is not really a > feature for me. > Not having it error, clearly, is a feature! > Thanks all for looking at this. I've just committed a fix to master, whereby the information in property `edebug' is saved in property `ghost-edebug' when the function is re-evaluated. `ghost-edebug' is used by most of edebug in place of `edebug' when the latter contains a bare marker. Modulo any bugs in this patch, I think it fixes bug #40992 completely. > Phil -- Alan Mackenzie (Nuremberg, Germany).