GNU bug report logs - #40970
[PATCH] gnu: add emacs-boon

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Elais Player <elais <at> fastmail.com>
Cc: 40970 <at> debbugs.gnu.org
Subject: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Fri, 01 May 2020 22:49:09 +0200

Hello,

Elais Player <elais <at> fastmail.com> writes:

> This patch adds the emacs-boon package with changes recommended by
> Nicolas Goaziou.

Thank you.

> +    (description
> +     "Boon is a complete package for modal editing, which is not Evil.
> +Strong points:

Nitpick: I suggest to use a complete sentence here.

> +@itemize
> +@item Ergonomic: common commands are easy to type.
> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
> +with design goals. This means that Boon integrates well with existing Emacs
> +infrastructure, and leverages it. Existing user configuration can often be
> +re-used.
> +@item Modular: No need to buy into the whole system: mix-and-match the parts

"No need" -> "no need"

Also, you need to put two spaces at the end of sentences in description.

Otherwise, LGTM.

You generated a new patch on top of the previous one. Could you merge
both, fix the above, and send one last patch?

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.