GNU bug report logs - #40970
[PATCH] gnu: add emacs-boon

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40970: closed ([PATCH] gnu: add emacs-boon)
Date: Mon, 16 Nov 2020 19:23:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 Nov 2020 20:22:38 +0100
with message-id <877dqlm7i9.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#40970] [PATCH] gnu: add emacs-boon
has caused the debbugs.gnu.org bug report #40970,
regarding [PATCH] gnu: add emacs-boon
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40970: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40970
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Elais Player <elais <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add emacs-boon
Date: Wed, 29 Apr 2020 12:54:58 -0600

[Message part 3 (text/plain, inline)]

Hi,

This patch adds the emacs-boon package with changes recommended by 
Nicolas Goaziou.

Best,

--
Elais Player

[0001-gnu-Add-emacs-boon.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Elais Player <elais <at> fastmail.com>
Cc: 40970-done <at> debbugs.gnu.org
Subject: Re: [bug#40970] [PATCH] gnu: add emacs-boon
Date: Mon, 16 Nov 2020 20:22:38 +0100

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Elais Player <elais <at> fastmail.com> writes:
>
>> This patch adds the emacs-boon package with changes recommended by
>> Nicolas Goaziou.
>
> Thank you.
>
>> +    (description
>> +     "Boon is a complete package for modal editing, which is not Evil.
>> +Strong points:
>
> Nitpick: I suggest to use a complete sentence here.
>
>> +@itemize
>> +@item Ergonomic: common commands are easy to type.
>> +@item Emacs-friendly: Emacs conventions are respected as much as compatible
>> +with design goals. This means that Boon integrates well with existing Emacs
>> +infrastructure, and leverages it. Existing user configuration can often be
>> +re-used.
>> +@item Modular: No need to buy into the whole system: mix-and-match the parts
>
> "No need" -> "no need"
>
> Also, you need to put two spaces at the end of sentences in description.
>
> Otherwise, LGTM.
>
> You generated a new patch on top of the previous one. Could you merge
> both, fix the above, and send one last patch?

I pushed a new iteration of this patch. I'm closing this one.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.