From unknown Sat Aug 09 15:19:25 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4097: issues with js2-mode faces Reply-To: Dan Nicolaescu , 4097@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 09 Aug 2009 18:10:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4097 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124984094229339 (code B ref -1); Sun, 09 Aug 2009 18:10:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Aug 2009 18:02:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n79I2KlP029332 for ; Sun, 9 Aug 2009 11:02:21 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaCip-0003RC-Va for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2009 14:02:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaCik-0003Hf-Ur for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2009 14:02:19 -0400 Received: from [199.232.76.173] (port=47978 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaCik-0003HR-Pj for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2009 14:02:14 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:50765) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MaCij-00055E-TK for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2009 14:02:14 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n79I0KQb028203; Sun, 9 Aug 2009 11:00:20 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n79I0KLn016605; Sun, 9 Aug 2009 11:00:20 -0700 (PDT) Date: Sun, 9 Aug 2009 11:00:20 -0700 (PDT) Message-Id: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Cc: Steve Yegge Lines: 9 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n79I0KQb028203 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) js2-mode uses -face suffix for faces. We are not using this suffix anymore and the tree has been cleaned up of such with backward compatibility code added. This is new code, so there's little point in having the suffix... Also, instead of defining a new js2-error-face why not just use font-lock-warning-face? From unknown Sat Aug 09 15:19:25 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4097: issues with js2-mode faces Reply-To: Dan Nicolaescu , 4097@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 12 Aug 2009 07:10:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4097 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4097-submit@emacsbugs.donarmstrong.com id=B4097.12500604256102 (code B ref 4097); Wed, 12 Aug 2009 07:10:05 +0000 Received: (at 4097) by emacsbugs.donarmstrong.com; 12 Aug 2009 07:00:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,GMAIL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7C70OV3006095 for <4097@emacsbugs.donarmstrong.com>; Wed, 12 Aug 2009 00:00:25 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7C70C33014884; Wed, 12 Aug 2009 00:00:12 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7C70Cdx015071; Wed, 12 Aug 2009 00:00:12 -0700 (PDT) Date: Wed, 12 Aug 2009 00:00:12 -0700 (PDT) Message-Id: <200908120700.n7C70Cdx015071@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Steve Yegge Cc: 4097@debbugs.gnu.org References: <200908091800.n79I0KLn016605@godzilla.ics.uci.edu> In-Reply-To: (Steve Yegge's message of "Tue, 11 Aug 2009 22:50:59 -0700") Lines: 42 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7C70C33014884 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Steve Yegge writes: > On Sun, Aug 9, 2009 at 11:00 AM, Dan Nicolaescu wrot= e: >=20 >=20 > js2-mode uses -face suffix for faces. >=20 > We are not using this suffix anymore and the tree has been cleaned = up of > such with backward compatibility code added. =C2=A0This is new code= , so > there's little point in having the suffix... >=20 >=20 > Agree; I'll fix it. =C2=A0The docs (info pages) are incorrect on a rele= vant point, > incidentally; they claim that defining variables whose value is set to = the > face of the same name is popular but obsolete; the reality is that > font-lock-add-keywords requires the variable definitions. It shouldn't require, if you have a situation where it does, please report it to bug-gnu-emacs@gnu.org >=20 > Also, instead of defining a new js2-error-face why not just use > font-lock-warning-face? >=20 >=20 > Why not just define a font-lock-error-face instead? That's a separate issue. You want a face with a red foreground, right? Currently that is font-lock-warning-face. > Other=C2=A0modes > (such=C2=A0as=C2=A0compilation)=C2=A0define=C2=A0their=C2=A0own=C2=A0er= ror=C2=A0faces.=C2=A0=C2=A0Fix=C2=A0it=C2=A0in=C2=A0Emacs > and=C2=A0the=C2=A0modes=C2=A0will=C2=A0follow. The issue with compilation is that it uses yellow for compilation-warning and red for compilation-error (good choices), but font-lock-warning-face is red. So we'd need to define a new font-lock-error-face that is red, replace all the existing uses of font-lock-warning-face with font-lock-error-face and change font-lock-warning-face to be yellow. I'll propose that. But meanwhile, there's not reason for js2-mode to define a new face instead of using font-lock-warning-face. From cyd@stupidchicken.com Fri Aug 14 18:18:03 2009 Received: (at control) by emacsbugs.donarmstrong.com; 15 Aug 2009 01:18:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7F1I2Xv001514 for ; Fri, 14 Aug 2009 18:18:03 -0700 Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n7F1HuXY008811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 14 Aug 2009 21:17:56 -0400 Received: by furry (Postfix, from userid 1000) id 2CBA3C070; Fri, 14 Aug 2009 21:17:57 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 4097 Date: Fri, 14 Aug 2009 21:17:57 -0400 Message-ID: <87fxbtnad6.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) close 4097 close 4130 thanks (js2-mode is no longer in CVS.) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 26 20:52:15 2010 Received: (at control) by debbugs.gnu.org; 27 Jan 2010 01:52:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZx4p-0001L8-3A for submit@debbugs.gnu.org; Tue, 26 Jan 2010 20:52:15 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZx4n-0001Kz-Cy for control@debbugs.gnu.org; Tue, 26 Jan 2010 20:52:13 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZx4j-0008Do-Q1; Tue, 26 Jan 2010 20:52:09 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19295.40009.742711.907136@fencepost.gnu.org> Date: Tue, 26 Jan 2010 20:52:09 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: .,Id9;5qiQf&2n,<1Q)pSe~'s"9B`l,&Ounxr+7\iedM93C_oK>"#$=D?*3Jqnu(&EvTR4 X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) tags 4053 moreinfo reassign 4066 emacs,org-mode reassign 4068 emacs,org-mode severity 4068 minor unarchive 4087 reassign 4087 notemacs tags 4094 moreinfo merge 4094 4096 merge 1611 3978 4108 unarchive 4097 unarchive 4130 merge 4097 4130 tags 4140 moreinfo close 4146 reassign 4151 emacs,ns tags 4192 patch