GNU bug report logs - #40953
[PATCH] services: rottlog: Append '.gz' to rotated file.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Wed, 29 Apr 2020 07:40:02 UTC

Severity: normal

Tags: patch

Done: Brice Waegeneire <brice <at> waegenei.re>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40953 in the body.
You can then email your comments to 40953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#40953; Package guix-patches. (Wed, 29 Apr 2020 07:40:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Brice Waegeneire <brice <at> waegenei.re>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 29 Apr 2020 07:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: rottlog: Append '.gz' to rotated file.
Date: Wed, 29 Apr 2020 09:37:50 +0200

* gnu/services/admin.scm (%default-rotations): Add option 'storefile'.
---
 gnu/services/admin.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm
index df3cb01646..89fa73920d 100644
--- a/gnu/services/admin.scm
+++ b/gnu/services/admin.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2016, 2017, 2018, 2019 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,8 +72,11 @@
   (list (log-rotation                             ;syslog files
          (files %rotated-files)
 
+         (options '(;; Run post-rotate once per rotation
+                    "sharedscripts"
+                    ;; Append .gz to rotated files
+                    "storefile @FILENAME.@COMP_EXT"))
          ;; Restart syslogd after rotation.
-         (options '("sharedscripts"))
          (post-rotate #~(let ((pid (call-with-input-file "/var/run/syslog.pid"
                                      read)))
                           (kill pid SIGHUP))))
-- 
2.26.0
Information forwarded to guix-patches <at> gnu.org:
bug#40953; Package guix-patches. (Wed, 29 Apr 2020 07:51:02 GMT) Full text and rfc822 format available.

Message #8 received at 40953 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 40953 <at> debbugs.gnu.org
Subject: #40953 fixes #40945
Date: Wed, 29 Apr 2020 07:50:50 +0000

This patch should fix https://issues.guix.info/issue/40945
Information forwarded to guix-patches <at> gnu.org:
bug#40953; Package guix-patches. (Fri, 01 May 2020 22:02:01 GMT) Full text and rfc822 format available.

Message #11 received at 40953 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 40953 <at> debbugs.gnu.org
Subject: Re: [bug#40953] [PATCH] services: rottlog: Append '.gz' to rotated
 file.
Date: Sat, 02 May 2020 00:01:34 +0200

Hi,

Brice Waegeneire <brice <at> waegenei.re> skribis:

> * gnu/services/admin.scm (%default-rotations): Add option 'storefile'.

Please add “Fixes <https://bugs.gnu.org/...>.”

LGTM!  That problem had always annoyed me.

Ludo’.
Reply sent to Brice Waegeneire <brice <at> waegenei.re>:
You have taken responsibility. (Wed, 06 May 2020 09:19:01 GMT) Full text and rfc822 format available.
Notification sent to Brice Waegeneire <brice <at> waegenei.re>:
bug acknowledged by developer. (Wed, 06 May 2020 09:19:01 GMT) Full text and rfc822 format available.

Message #16 received at 40953-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 40953-done <at> debbugs.gnu.org
Date: Wed, 06 May 2020 09:17:53 +0000

Pushed as ab034adfe86333fccd6afe476806f169e2074d69.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 03 Jun 2020 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 11 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.