From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 17:00:42 2020 Received: (at submit) by debbugs.gnu.org; 28 Apr 2020 21:00:42 +0000 Received: from localhost ([127.0.0.1]:41759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTXLO-0004Kn-9v for submit@debbugs.gnu.org; Tue, 28 Apr 2020 17:00:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:39344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTWkv-0003Cq-PY for submit@debbugs.gnu.org; Tue, 28 Apr 2020 16:23:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38948) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTWkt-0007pB-O0 for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 16:23:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTWks-0008EV-5a for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 16:22:59 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTWkq-0008E0-Cu for bug-gnu-emacs@gnu.org; Tue, 28 Apr 2020 16:22:56 -0400 Received: from [192.168.158.20] ([87.122.82.146]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MqatE-1ipoDt1lb6-00mc6l for ; Tue, 28 Apr 2020 22:22:53 +0200 To: bug-gnu-emacs@gnu.org Subject: 26.3; Docstring of substitute-env-vars From: Marcus Harnisch Message-ID: Date: Tue, 28 Apr 2020 22:22:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K1:8dD+E+taco5bGz4RURBIqWX/cyeVREpqihZAWYQ7nB7bPc1nlJ0 nsHqbHeSujWHDy4uTpUF+RUh7JglG7GgtpJ7ixa8qNkkhwOGmkyWQYFlGZqdmTsVsTsTL3i S8Nz39h1SSGh9gwBmOJ/DdQ+lfK1QEEheq1/+giGQFMOwkuSxLKUo/dvdAvjI8Hb++8rE4n 1DZBp3Pusyx7Vtze2RonA== X-UI-Out-Filterresults: notjunk:1;V03:K0:M1B82nQA50w=:SkSt8eTgDpvLF7TYqFExdM 6sOEnmtIYwggLeKCYJ0QoutR0PGoq98qCfKZz3HhmOVeX4aU02kXR7cJbn3LNFRVWtt9yCsgL EKjp/oT84iqGywNKOq1CSvlfGVuvY6TOKBgzhsi5Ov/PYNj0e9HCQPPHi4yd1ilkVyMEjrlzG WZHVocGTnvHedPXxiPdAmmwCe2+asE1ZK4u66HfAVcS3ByRnokdrw9YsWqFglrnubQhaa9mVz 8ydrAPam335QGYoSdT3NdqJTFRYipJ7DXnKQNgpYttdfVH2/OEgKE6fJdUptVIoHYqpFa4QN5 czN9QtS3loMmomWTcLrH/sTvoaiQXR2pNPdUl2SuMRVYGVZ14gFyRznj1UIBLSORgfFrhztvf ux9NlVWD2Y2OItwONz6kBAZH9cQiXEBKH0CRYaia1AKSUEjDjViP8YoBP6uP/9/ZOCqpoQ60w JlyPDo0gifBVs67bQa0gF5HVZsPrIP+H2Ow5KCNmbksgP5xByFedzlg4kukfvfQhdLE/NTHpn KeAIO4NIYm8DX+GqtI4v2SLM/XUunlmsBCNMAG+6uL1q2Id9nPNib1tda0m07PVjEdSM76Qb+ srwXd34wts6kiq0TfNON7W0CfhBlmbZByBEeyhBIuM+e2T9v42Te76mXY7OC9KQzkw8rm+zBk FnfdmKE5HVzZAnDcOecBEzPFg4l5jO/7/UYCsKDOLqweMGyxw/M3Ys3eeA7tPD0N9zxW0NBec iDZ6opaUCyWHvBqXjUpnQ/QKPZj7CjitWxHMiquZzl0qm+OG4kW8URcvermi16Y/UrvZORZtT zw6mHtC8sKRUyIpbrnxStbGEqYflDe5pWoHB3HVaUwJH+sKvZzMZRxwrweyiXnkk2+jUWZv Received-SPF: pass client-ip=212.227.126.135; envelope-from=marcus.harnisch@gmx.net; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/28 16:22:53 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Received-From: 212.227.126.135 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 28 Apr 2020 17:00:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) With commit ee041f2d07b6ed485dc34c115588f973f046c9d4, changes to the parameters of `substitute-env-vars' were introduced and its docstring changed. While the optional parameter is named WHEN-UNDEFINED, the docstring says WHEN-DEFINED. It would appear that the dosctring is right, but I'll leave that decision to the experts. Thanks, Marcus From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 07:14:40 2020 Received: (at 40948) by debbugs.gnu.org; 29 Apr 2020 11:14:40 +0000 Received: from localhost ([127.0.0.1]:42572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTkfo-0000dh-Gj for submit@debbugs.gnu.org; Wed, 29 Apr 2020 07:14:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTkfm-0000dV-Qm for 40948@debbugs.gnu.org; Wed, 29 Apr 2020 07:14:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52751) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTkfh-0004WB-7x; Wed, 29 Apr 2020 07:14:33 -0400 Received: from [176.228.60.248] (port=3304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTkfd-0001Fr-VR; Wed, 29 Apr 2020 07:14:32 -0400 Date: Wed, 29 Apr 2020 14:14:11 +0300 Message-Id: <83lfmezgqk.fsf@gnu.org> From: Eli Zaretskii To: Marcus Harnisch , Stefan Monnier In-Reply-To: (message from Marcus Harnisch on Tue, 28 Apr 2020 22:22:52 +0200) Subject: Re: bug#40948: 26.3; Docstring of substitute-env-vars References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40948 Cc: 40948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Marcus Harnisch > Date: Tue, 28 Apr 2020 22:22:52 +0200 > > With commit ee041f2d07b6ed485dc34c115588f973f046c9d4, changes to the > parameters of `substitute-env-vars' were introduced and its docstring > changed. While the optional parameter is named WHEN-UNDEFINED, the > docstring says WHEN-DEFINED. It would appear that the dosctring is > right, but I'll leave that decision to the experts. I modified the doc string to match the argument name. (I'm not sure how to judge which one is correct, because IMO neither WHEN-DEFINED nor WHEN-UNDEFINED is correct. I would call that argument HANDLE-UNDEFINED or something to that effect.) Also note that there's an inconsistency in how the value of this variable is used: if it's a function, then the return value of nil means leave the variable reference unchanged, but if it is not a function, the value of nil means to replace the reference with an empty string, and a non-nil value means leave it unchanged. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 01:39:18 2021 Received: (at 40948) by debbugs.gnu.org; 28 Jan 2021 06:39:18 +0000 Received: from localhost ([127.0.0.1]:46887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xa-0002pQ-3V for submit@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:18 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xY-0002p9-8s for 40948@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rb1CoQ/7xhiKkVL7m7KnDqxyVZA7fLlNslGXDw/jvfE=; b=m3EXOaDYjxfC9ascY3YFUN+fFg S8umvZxzXefeJahn7Ss4d/kHSCI6oVTGjGLb8G6njkoGy4xit1zJMlShzov6okUGXtjeRtJSP4r8p 241m77AG5f/bcOri7GvF8VWUAc12YhtLbfsZK9NsBLMBbNzxhZ07xFeYBBU6bf6OG42g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l50xP-0005CB-9C; Thu, 28 Jan 2021 07:39:09 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#40948: 26.3; Docstring of substitute-env-vars References: <83lfmezgqk.fsf@gnu.org> X-Now-Playing: A Certain Ratio's _acr:box (1)_: "Kether Hot Knives (Mix in Special)" Date: Thu, 28 Jan 2021 07:39:06 +0100 In-Reply-To: <83lfmezgqk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Apr 2020 14:14:11 +0300") Message-ID: <878s8d36r9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I modified the doc string to match the argument name. (I'm not sure > how to judge which one is correct, because IMO neither WHEN-DEFINED > nor WHEN-UNDEFINED is correct. I would call that argument [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40948 Cc: Stefan Monnier , 40948@debbugs.gnu.org, Marcus Harnisch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I modified the doc string to match the argument name. (I'm not sure > how to judge which one is correct, because IMO neither WHEN-DEFINED > nor WHEN-UNDEFINED is correct. I would call that argument > HANDLE-UNDEFINED or something to that effect.) > > Also note that there's an inconsistency in how the value of this > variable is used: if it's a function, then the return value of nil > means leave the variable reference unchanged, but if it is not a > function, the value of nil means to replace the reference with an > empty string, and a non-nil value means leave it unchanged. The interface seems odd indeed, but your changes to the doc string has now made it match what it's doing (I think), so there doesn't seem to be anything more to be done in this bug report, and I'm closing it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 28 01:39:23 2021 Received: (at control) by debbugs.gnu.org; 28 Jan 2021 06:39:23 +0000 Received: from localhost ([127.0.0.1]:46890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xf-0002pi-Cg for submit@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:23 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l50xe-0002pO-C5 for control@debbugs.gnu.org; Thu, 28 Jan 2021 01:39:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1RINQE2I8L6jQmLE9WDt0tpa/7/U0uvTZOynM6sMuXU=; b=D7jAmxVVjM2YX2aLXrhlriz1EN fuf4FhalklfeUtdKm233GsN60VatZNfVv2wB1Y7/2HcmHPSz24NwuZOl00HdefmG7eRsRuGygmKGH RyPWOVCb5NwUiQy3nfUKu4cPOCvPuxJ8L4GWLXjDuMFmBSQClylk7C1RMqwQqk6ADcoM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l50xW-0005CK-Rm for control@debbugs.gnu.org; Thu, 28 Jan 2021 07:39:16 +0100 Date: Thu, 28 Jan 2021 07:39:13 +0100 Message-Id: <877dnx36r2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40948 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 40948 fixed close 40948 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40948 fixed close 40948 28.1 quit From unknown Fri Jun 20 07:17:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Feb 2021 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator