From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 28 09:03:42 2020 Received: (at submit) by debbugs.gnu.org; 28 Apr 2020 13:03:42 +0000 Received: from localhost ([127.0.0.1]:39278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTPtl-0008Tm-Vz for submit@debbugs.gnu.org; Tue, 28 Apr 2020 09:03:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:40988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTNhh-0002yu-JK for submit@debbugs.gnu.org; Tue, 28 Apr 2020 06:43:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45420) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTNg9-0007SR-QF for guix-patches@gnu.org; Tue, 28 Apr 2020 06:43:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTNcb-0003gq-4T for guix-patches@gnu.org; Tue, 28 Apr 2020 06:41:29 -0400 Received: from aibo.runbox.com ([91.220.196.211]:48286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTNca-0003WZ-9m for guix-patches@gnu.org; Tue, 28 Apr 2020 06:37:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amk.ie; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id :Date:Subject:Cc:To:From; bh=9csPF6HdyGJkTXYBPy8wVUWqAJHQnOyZzCpwIGJIo9k=; b= NOk+GG2PREndgxbupXE9MZyddk54B0MMWi1dO8GlAbpIuuECUH3wxFZwnIfulaowLGGxDV7E9ubWg /ftK8QevVHamFKbPbMPaiyROph6nol9khQDvJ8yBgHVOODqRzpgf04yNdstYENntyEnWdrpiYYm0X tYOi6V72RDUwIjXhJw7/O9/jJeX3ng8z4Sd9QjM6c1wc5PPFQohUkUpWm0wL0ymErE7otPPog5nmU BkLqtHJyUzabtQwR3QQ3bL+x1pDhc71yAe7riMTjYlw3OMHOYdyNk4BGdmDhlV8qv9czVHmJKUM34 PVE+QdS/BsArfld997Ji7EVDa7WhnroAxQ==; Received: from [10.9.9.202] (helo=mailfront20.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jTNcU-0002xX-W5 for guix-patches@gnu.org; Tue, 28 Apr 2020 12:37:43 +0200 Received: by mailfront20.runbox with esmtpsa [Authenticated alias (942369)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jTNcM-0004ho-1S; Tue, 28 Apr 2020 12:37:34 +0200 From: Alex McGrath To: guix-patches@gnu.org Subject: [PATCH] gnu: add j4-dmenu-desktop Date: Tue, 28 Apr 2020 11:37:05 +0100 Message-Id: <20200428103705.22597-1-amk@amk.ie> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=91.220.196.211; envelope-from=amk@amk.ie; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/28 06:37:43 X-ACL-Warn: Detected OS = ??? X-Received-From: 91.220.196.211 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 28 Apr 2020 09:03:41 -0400 Cc: Alex McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --- gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm index bc2c9c4622..02997dcbf1 100644 --- a/gnu/packages/xdisorg.scm +++ b/gnu/packages/xdisorg.scm @@ -35,6 +35,7 @@ ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2020 Damien Cassou ;;; Copyright © 2020 John Soo +;;; Copyright © 2020 Alex McGrath ;;; ;;; This file is part of GNU Guix. ;;; @@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu} (or @command{rofi}, depending on the value of @code{CM_LAUNCHER}) to let the user select a clip. After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.") (license license:public-domain)))) + +(define-public j4-dmenu-desktop + (package + (name "j4-dmenu-desktop") + (version "2.17") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/enkore/j4-dmenu-desktop.git") + (commit (string-append "r" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off") + #:tests? #f)) ;; tests fetch an external git repo + (synopsis "A fast desktop menu") + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.") + (home-page "https://github.com/enkore/j4-dmenu-desktop") + (license license:gpl3+))) -- 2.26.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 03:59:58 2020 Received: (at 40931) by debbugs.gnu.org; 29 Apr 2020 07:59:58 +0000 Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jThd9-0003x6-Qn for submit@debbugs.gnu.org; Wed, 29 Apr 2020 03:59:58 -0400 Received: from aibo.runbox.com ([91.220.196.211]:53400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jThYH-0003pM-V7 for 40931@debbugs.gnu.org; Wed, 29 Apr 2020 03:54:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amk.ie; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id :Date:Subject:Cc:To:From; bh=BHrgCHuS5F50lidECpIpBTRx4aNpEb+m6GwROerlVGs=; b= ZIfkWsPdc5+3ceOrcnT2AKyx+n1im3F7aVH6WUpC9vc+ytkSN8/16taONZmWjRsOTZ/TSNn0gJebV b5gXVUbDayPVxjgwtz6itvDhf9o1THXgvDbumCW3zk5Si3oZVTQoiKxmsVwwZ93u5by5xfYZJPAMH ZTUQ3rueLkUn0Og6IptbM4HdkYLTman+P4M43J1m2Xm33/QClb+K/Jf8WTB00fmOArMa5PJVt3Y40 yIx7x8POE8nF2YsE1V/3fSHDPE7UODJcAiUBU+e8lO7rbAdETmHliLkg15MlEVQrOq0KQwxxk2cYe ji/UDh1wZP6sYZZ7z586YM+1UCbZaBzD8g==; Received: from [10.9.9.203] (helo=mailfront21.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jThYG-00043e-DA for 40931@debbugs.gnu.org; Wed, 29 Apr 2020 09:54:40 +0200 Received: by mailfront21.runbox with esmtpsa [Authenticated alias (942369)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jThY3-0007a7-55; Wed, 29 Apr 2020 09:54:27 +0200 From: Alex McGrath To: 40931@debbugs.gnu.org Subject: [PATCH v2] gnu: add j4-dmenu-desktop Date: Wed, 29 Apr 2020 08:52:33 +0100 Message-Id: <20200429075231.6699-1-amk@amk.ie> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40931 X-Mailman-Approved-At: Wed, 29 Apr 2020 03:59:42 -0400 Cc: Alex McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable. gnu/packages/xdisorg.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm index bc2c9c4622..02997dcbf1 100644 --- a/gnu/packages/xdisorg.scm +++ b/gnu/packages/xdisorg.scm @@ -35,6 +35,7 @@ ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2020 Damien Cassou ;;; Copyright © 2020 John Soo +;;; Copyright © 2020 Alex McGrath ;;; ;;; This file is part of GNU Guix. ;;; @@ -2286,3 +2287,25 @@ to find all available clips and launches @command{dmenu} (or @command{rofi}, depending on the value of @code{CM_LAUNCHER}) to let the user select a clip. After selection, the clip is put onto the PRIMARY and CLIPBOARD X selections.") (license license:public-domain)))) + +(define-public j4-dmenu-desktop + (package + (name "j4-dmenu-desktop") + (version "2.17") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/enkore/j4-dmenu-desktop.git") + (commit (string-append "r" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off") + #:tests? #f)) ;; tests fetch an external git repo + (synopsis "A fast desktop menu") + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.") + (home-page "https://github.com/enkore/j4-dmenu-desktop") + (license license:gpl3+))) -- 2.26.1 From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 10:18:28 2020 Received: (at 40931) by debbugs.gnu.org; 2 May 2020 14:18:28 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyK-00009O-CM for submit@debbugs.gnu.org; Sat, 02 May 2020 10:18:28 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:55529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyI-00009B-2B for 40931@debbugs.gnu.org; Sat, 02 May 2020 10:18:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2E7AD2BA; Sat, 2 May 2020 10:18:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 02 May 2020 10:18:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=QPxaukRvVQjrOtOh3dQT3129JX H4FCkk2CwT5BziZ58=; b=kkMYDhN936zXXMaMzMazpst4ObyT701hS1h0njoZPq 4+e3djnrNKAqZFfNFLqXhA8Z7ZOzZo7KY1GcqVy4PWB2kQE+Uinc73LurI1eypg8 /+eGBGGOjbK+HywJ+9DOZHFEc3xb8U6OhMPmAeQVM7L0MFCC3byng0gew38G90LI fsfqBZNzq8UDGog6XhETwtK6seaa/s1Q8ijebnoRXTNRBy6xz8t1Ag1YqXhbPJKE /EcFg/NrRXerum2YbciBzRgr8cag0i0ITpBsku5gJt2wqioeWc4QADh2TRKQYyMz Hcy9ixkevlOKJocLKUCOtqSiMm++mWPbp8sQN8A83sgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QPxauk RvVQjrOtOh3dQT3129JXH4FCkk2CwT5BziZ58=; b=dVMkofEYIOPYjCoM2CORqY Ra7GgrzEjofT19FnUdxVbKLxaEHyiznuNfcQT84pgSTFBCBwL9Ghn3W9oguaQ5Sd HIhE3JnxyphOhG9hhD/ICge2o0Mo7PWJfDhmxg/oPzl1rAqwWPVl/FHIO6kZYUEb jdU1GU6WgemJpMjtbcwj5ZDfZeFJEBqVH3/0pTcP8RQSSneQ7rYETPOdlrpLJGws 9A7avtla7PjW976sICBP3pCmB+7h/007ffZApHQF0K5hPgjBvwrNP0HZtLXBHPxH ufio+0/VTejFvnd27kZnwNy2RxHUfUSS1YfV2oVLeJ9F6u8ypLGQE8+dhum1qqDQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeejkeefkeelgeevjeetheeljeeute duueelvdffvedufeevtddvfeevieefheevtdenucffohhmrghinhepghhithhhuhgsrdgt ohhmnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 26C193065F95; Sat, 2 May 2020 10:18:19 -0400 (EDT) From: Marius Bakke To: Alex McGrath , 40931@debbugs.gnu.org Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop In-Reply-To: <20200429075231.6699-1-amk@amk.ie> References: <20200428103705.22597-1-amk@amk.ie> <20200429075231.6699-1-amk@amk.ie> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 16:18:17 +0200 Message-ID: <87sggi2zfa.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40931 Cc: Alex McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Alex McGrath writes: > * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable. Thanks! Unfortunately the patch no longer applies, can you rebase it on the current master branch? [...] > +(define-public j4-dmenu-desktop > + (package > + (name "j4-dmenu-desktop") > + (version "2.17") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/enkore/j4-dmenu-desktop.git") > + (commit (string-append "r" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off") Note that cmake-build-system exposes #:build-type, so you don't have to pass "-DCMAKE_BUILD_TYPE". By default it uses RelWithDebugInfo which is better because it adds debug information. There are cases where we want "Release" instead (size or performance concerns), but it probably is fine for this package? > + #:tests? #f)) ;; tests fetch an external git repo Is it possible to provide this repo as a native-input? See e.g. 'ghc'. Don't stress it if it's not possible, though. > + (synopsis "A fast desktop menu") Just "Fast desktop menu" ('./pre-inst-env guix lint j4-dmenu-desktop' should warn about this). > + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.") Use two spaces between sentences, and try to wrap lines at ~78 characters. 'guix lint' will warn about this, too. :-) Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tgSkACgkQoqBt8qM6 VPpBgggAp7f7NzWe1/tIFRiLeFIVJ+VwCcRrLmG0SznWxM9JeoZhou7XmrN6kyC4 5A8vIgPMDugHH2tuBUW+qLkhC8XCUpE0B519LYCg3t7cZpFWvN7daA5Kngt/7+2+ l8eg7H1ILi9ssqpgk/v9xEUpu4zBVhXg7g81stBnN/rNMB97f9SVeYn/uszPt8Bx cCHUQ/qRKIeow/kjB+AcshyXA0n8cEGh+bsamWxujjyem6QhdVuoMNB1P4oyGYlM +WwEsGh+bScJF+q8MoV+DfmDEU4L+NBsXRi1qRlvqFbuRtL6hDqXS/g3I/joGAPG YAvDQ3r1YN42qXsswUenPORkvwlnpQ== =MOIQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 14:50:36 2020 Received: (at 40931) by debbugs.gnu.org; 2 May 2020 18:50:36 +0000 Received: from localhost ([127.0.0.1]:53920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUxDf-0000ww-CS for submit@debbugs.gnu.org; Sat, 02 May 2020 14:50:35 -0400 Received: from aibo.runbox.com ([91.220.196.211]:54590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUwKd-0007uv-1z for 40931@debbugs.gnu.org; Sat, 02 May 2020 13:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amk.ie; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id :Date:Subject:Cc:To:From; bh=4rzJILg7/mpZ1IW4dEiGDTTGPB6CrMwzSym1o8Pb0g8=; b= H57LVojt0Fi8OLVF+89OAhx5Rtq8AjF1yVa0iIZFebPv+9Po7cmY6sBOKPXsEZS1Sdtd2/WGXsvfi 53KK/BTS5NtI2GxHlIxPjHRfqOM5+TtEBuVe2pJ+KQp2VEHq8I8gfHxhyc5kbqkpGThU3KK7R3xcX W0iNUXVil2Fksdwq0GbgjScWShUVrlDQqsGpHLulb3QibqCCFQZ20F7v68kDNA7RVnBgs60NVxTE/ sQ8YAlVFP6ViPArHoVnm8ZKwmpQADS1jeaZs7bCEER7I9mYWqqQd9QiMSAH8kfBtKlhBkk/B9fMou hUjoVWxK7TGJYjtxX7BMer0hBlAf1yF/lA==; Received: from [10.9.9.204] (helo=mailfront22.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jUwKb-0006Aa-9v for 40931@debbugs.gnu.org; Sat, 02 May 2020 19:53:41 +0200 Received: by mailfront22.runbox with esmtpsa [Authenticated alias (942369)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jUwKX-0003Fk-59; Sat, 02 May 2020 19:53:37 +0200 From: Alex McGrath To: 40931@debbugs.gnu.org Subject: [PATCH v3] gnu: add j4-dmenu-desktop Date: Sat, 2 May 2020 18:51:56 +0100 Message-Id: <20200502175155.21507-1-amk@amk.ie> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40931 X-Mailman-Approved-At: Sat, 02 May 2020 14:50:33 -0400 Cc: Alex McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable. --- gnu/packages/xdisorg.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm index df61a95cbb..99b3f765d2 100644 --- a/gnu/packages/xdisorg.scm +++ b/gnu/packages/xdisorg.scm @@ -36,6 +36,7 @@ ;;; Copyright © 2020 Damien Cassou ;;; Copyright © 2020 John Soo ;;; Copyright © 2020 Boris A. Dekshteyn +;;; Copyright © 2020 Alex McGrath ;;; ;;; This file is part of GNU Guix. ;;; @@ -2324,3 +2325,34 @@ some kind of chat (in native language). @command{kbdd} also supports D-Bus signals, which makes it possible to create layout indicator widgets.") (license license:bsd-2))) + +(define-public j4-dmenu-desktop + (package + (name "j4-dmenu-desktop") + (version "2.17") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/enkore/j4-dmenu-desktop.git") + (commit (string-append "r" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) + (build-system cmake-build-system) + (native-inputs + `(("catch2" ,catch-framework2))) + (arguments + `(#:configure-flags '("-DWITH_GIT_CATCH=off") + #:phases + (modify-phases %standard-phases + (replace 'check + (lambda _ + (invoke "./j4-dmenu-tests" "exclude:SearchPath/XDG_DATA_HOME")))) + #:tests? #t)) + (synopsis "Fast desktop menu") + (description "j4-dmenu-desktop is a replacement for +i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu +to start an application using dmenu.") + (home-page "https://github.com/enkore/j4-dmenu-desktop") + (license license:gpl3+))) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 14:50:36 2020 Received: (at 40931) by debbugs.gnu.org; 2 May 2020 18:50:36 +0000 Received: from localhost ([127.0.0.1]:53922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUxDg-0000wy-0D for submit@debbugs.gnu.org; Sat, 02 May 2020 14:50:36 -0400 Received: from aibo.runbox.com ([91.220.196.211]:50564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUwOe-00081N-Ku for 40931@debbugs.gnu.org; Sat, 02 May 2020 13:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amk.ie; s=selector2; h=Message-Id:In-Reply-To:Date:Subject:To:From:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=C//yKHQGxUVeIrdb+uBev365zYcCZOwxPTUICwX7Mck=; b=k3RNp7vpjm3M6SaFNgBEI44/QE nupiEWYgBQf7YWATBbra7o5OFUurU/uU71un4FsGao/fZsyf/XwmlY2dpymfF2eG30iTggzAYEJxU ZdDWnMT1TUhe8c2Z4PK0Cf67Yc4hICdAhBcc/cFdccu3zmP/Pa8/wlpM23YrT+QBW3AmEExUtDNuW plV9jZYlISTT8QvNa8XYhjMwd6EWhhEObjwzz0daEPgfhDWWkoEnX9+av3Dplk+oUWO7ETUlHXrhE huuucTGmIaEyW58CnL+mMBB/XuR5mQ/nG1wBHfQf0wPHU2CAU+3tF8vCFg5FKY7dGteVnocYiUdaG gyJm8qrg==; Received: from [10.9.9.128] (helo=rmmprod06.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jUwOd-0006HV-Ut for 40931@debbugs.gnu.org; Sat, 02 May 2020 19:57:52 +0200 Received: from mail by rmmprod06.runbox with local (Exim 4.86_2) (envelope-from ) id 1jUwOd-0001nl-PQ for 40931@debbugs.gnu.org; Sat, 02 May 2020 19:57:51 +0200 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received: from [Authenticated alias (942369)] by runbox.com with http (RMM6); for <40931@debbugs.gnu.org>; Sat, 02 May 2020 17:57:51 GMT From: "Alex McGrath" To: "40931" <40931@debbugs.gnu.org> Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop Date: Sat, 02 May 2020 18:57:51 +0100 (IST) X-RMM-Aliasid: 942369 X-Mailer: RMM6 In-Reply-To: <87sggi2zfa.fsf@devup.no> Message-Id: X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Howdy, I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result Thanks for the review! Alex Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: amk.ie] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [91.220.196.211 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [91.220.196.211 listed in wl.mailspike.net] 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 40931 X-Mailman-Approved-At: Sat, 02 May 2020 14:50:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Howdy, I think I've addressed the comments (ran guix lint etc) and I enabled all t= he tests except for one, as it checks for a directory that doesnt exist on = guix and fails as a result Thanks for the review! Alex= From debbugs-submit-bounces@debbugs.gnu.org Mon May 04 10:33:17 2020 Received: (at 40931-done) by debbugs.gnu.org; 4 May 2020 14:33:17 +0000 Received: from localhost ([127.0.0.1]:33611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVc9l-0001MP-D4 for submit@debbugs.gnu.org; Mon, 04 May 2020 10:33:17 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:33725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVc9i-0001MB-Va for 40931-done@debbugs.gnu.org; Mon, 04 May 2020 10:33:15 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 557C1399; Mon, 4 May 2020 10:33:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 May 2020 10:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=oocB6BihPqwq40RC2vrNcHS1yH zCPBBPrm1DzxMG9h4=; b=dz1wcn8vhzNoi5MC9563juRyZBIQF+nfn4t8igbZZn eTpyq7rw8hrrd7OAIb79ny/SBmAW+tWrzPBrW2Pzs7kKaBYs1RL0OUI/ov0qsKU5 IniwIQwcg5kvnICjupirlloov8HCZj8zwQZTE4ZjlSIgGIpG4yH4lD2Lab2ocnQI xLsi+cOvEyAS1z0O0NGE9Tw50a7WCJ32F2UCVB5dW5zMjIwRAYp5PdANaGy5SfjB WQiL5zvsVYNR0g6jUsr4iSDHnfAqJHjCMWMuJWD5p1DPIMFHnvkIF/jSF9vxPJSS UrNqHld1lchXyejy5Pej1VCCFpN42BTzJ9F/ZjOmnu3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oocB6B ihPqwq40RC2vrNcHS1yHzCPBBPrm1DzxMG9h4=; b=n7OB92MHsCNiZMqcFNCAYd iSo4dIBw1W4HpNaEzya9UhLuWVPWqMF/gRu012VHBSh25vkTqmdIrFuKcRm9ydr0 pDKc8/v4aUz3ZdqLUtO6LfQHMTNqNpjDp/AKG1JNgEzmhndbdIODyZN1IACvsF+o hnMLF0i9pSbKyzVXD9wMCM1Y+iufOW1C27fmqjPClD5S0dLu2yEopZaV0fJNF+m+ 2DfhEGoiMnSw316Wn8/rw9zpQq4+odmiI91tVqn8eWrb5aXmgNqmoYJpfoC63Lcs IJ/9xOFK3fQeZcpohVsgTywWXng3T7lQWQrOXrOd165x4oK9iVBEuMObtcNUCpuA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeggdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpedtvdfggeevgeeivdffueejiedtte dvkedtudfggfdtgeefiedtieekffdugfeuffenucfkphepkeegrddvtddvrdeikedrjeeh necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrg hkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 604963280059; Mon, 4 May 2020 10:33:07 -0400 (EDT) From: Marius Bakke To: Alex McGrath , 40931 <40931-done@debbugs.gnu.org> Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop In-Reply-To: References: <20200428103705.22597-1-amk@amk.ie> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 04 May 2020 16:33:05 +0200 Message-ID: <87pnbj22ji.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40931-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain "Alex McGrath" writes: > Howdy, > > I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result Excellent, LGTM! I've applied the patch with minor adjustments (removed redundant #:tests? #t, and formatted description with @file and @command markup where appropriate). Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6wJ6EACgkQoqBt8qM6 VPoIwwgA0j0Ug8yYiykViRUs40lhhsa57/CJLAIe9PdbiLgVX1Gz5LISAjqnlhWC QuKQW+dbGIr2aTDX6yP4sjX/Wo2T8RisRjClaBT2XHCOplyDLJ+fZyozpCzTRzN/ i1ojjVqZ9E+etoWLwvniMCRj3lmRmDZorNWrwMxIKEWq5IqHTgk+ghtsT7ulEQB0 zoP4y8rqqia0C2wHE5kKwi40jUbjETNPJ1+SxZ+Bpj5IvUTET7xO0sWN+pWo0H21 gfkN825XE2zL39FKE3IY73rajsEtnIA0HKlV4wUiN6/kAMgOioVywZSCLypdjWPh lqRhgc1EFweJEmN6Md0CwVX9twxeMw== =gApD -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 12:44:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jun 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator