GNU bug report logs - #40925
[PATCH] Add collectd

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40925 in the body.
You can then email your comments to 40925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add collectd
Date: Tue, 28 Apr 2020 10:57:19 +0200

[Message part 1 (text/plain, inline)]

Hi,

the attached patch adds the monitoring software “collectd”. Its configuration
is quite minimal right now. A lot of plugins are not enabled, because they
introduce many external dependencies. I’m sure that can be fixed easily if
there’s demand though.

I’ve been running the package in production for a week now without any problems
(via systemd on a foreign distribution, thus no herd service).

Cheers,
Lars

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 40925 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: 40925 <at> debbugs.gnu.org
Subject: Re: [PATCH] Add collectd
Date: Tue, 28 Apr 2020 11:29:38 +0200

[Message part 1 (text/plain, inline)]

Hi,

totally forgot to attach the patch. Here it is.

Lars

[0001-gnu-Add-collectd.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40925 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40925 <at> debbugs.gnu.org
Subject: Re: [bug#40925] [PATCH] Add collectd
Date: Fri, 01 May 2020 01:08:54 +0200

Hi,

Lars-Dominik Braun <ldb <at> leibniz-psychology.org> skribis:

> From 05110cd7f0af5f870daa48a1e32bff56efb2676a Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
> Date: Tue, 28 Apr 2020 10:50:10 +0200
> Subject: [PATCH] gnu: Add collectd
>
> * gnu/packages/monitoring.scm (collectd): New variable
> * gnu/local.mk (dist_patch_DATA): Add new patch
> * gnu/packages/patches/collectd-5.11.0-noinstallvar.patch: New file

[...]

> +    (arguments
> +     `(#:configure-flags (list "--localstatedir=/var" "--sysconfdir=/etc")
> +                         #:phases
> +                         (modify-phases %standard-phases
> +                           ;; Required because of patched sources.
> +                           (add-before 'configure 'autoreconf
> +                             (lambda _ (invoke "autoreconf" "-vfi") #t)))))

Another option is to patch Makefile.in to avoid the dependency on
Autoconf/Automake/Libool + this phase.

> +    (license '(licenses:expat licenses:gpl2))))

This is incorrect (see patch below, which also includes indentation
fixes and minor changes to the description to placate ‘guix lint’.)

Also, could you add a comment stating whether it’s dual-licensing or
just that there’s code in both licenses?

> diff --git a/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch b/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch
> new file mode 100644
> index 0000000000..a8ca142147
> --- /dev/null
> +++ b/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch

A one-line comment at the top explaining what it does would be great.

Otherwise LGTM.  Could you send an updated patch?

Thanks in advance!

Ludo’.

Message #14 received at 40925 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40925 <at> debbugs.gnu.org
Subject: Re: [bug#40925] [PATCH] Add collectd
Date: Fri, 01 May 2020 01:10:05 +0200

[Message part 1 (text/plain, inline)]

I too forgot the patch.  :-)

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 5a37b14328..7ee58f0d0c 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -467,11 +467,11 @@ written in Go with pluggable metric collectors.")
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags (list "--localstatedir=/var" "--sysconfdir=/etc")
-                         #:phases
-                         (modify-phases %standard-phases
-                           ;; Required because of patched sources.
-                           (add-before 'configure 'autoreconf
-                             (lambda _ (invoke "autoreconf" "-vfi") #t)))))
+       #:phases (modify-phases %standard-phases
+                  (add-before 'configure 'autoreconf
+                    (lambda _
+                      ;; Required because of patched sources.
+                      (invoke "autoreconf" "-vfi"))))))
     (inputs
      `(("rrdtool" ,rrdtool)
        ("curl" ,curl)))
@@ -483,10 +483,10 @@ written in Go with pluggable metric collectors.")
     (home-page "https://collectd.org/")
     (synopsis "Collect system and application performance metrics periodically")
     (description
-     "collectd gathers metrics from various sources, e.g. the operating system,
-applications, logfiles and external devices, and stores this information or
-makes it available over the network. Those statistics can be used to monitor
-systems, find performance bottlenecks (i.e. performance analysis) and predict
-future system load (i.e. capacity planning).")
-    (license '(licenses:expat licenses:gpl2))))
+     "collectd gathers metrics from various sources such as the operating system,
+applications, log files and external devices, and stores this information or
+makes it available over the network.  Those statistics can be used to monitor
+systems, find performance bottlenecks (i.e., performance analysis) and predict
+future system load (i.e., capacity planning).")
+    (license (list license:expat license:gpl2))))
 

Message #17 received at 40925 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40925 <at> debbugs.gnu.org
Subject: Re: [bug#40925] [PATCH] Add collectd
Date: Mon, 4 May 2020 08:06:29 +0200

[Message part 1 (text/plain, inline)]

Hi Ludo,

> Another option is to patch Makefile.in to avoid the dependency on
> Autoconf/Automake/Libool + this phase.
it’s only a native-input, so should be fine?

> This is incorrect (see patch below, which also includes indentation
> fixes and minor changes to the description to placate ‘guix lint’.)
My bad, forgot to run it :(

> Also, could you add a comment stating whether it’s dual-licensing or
> just that there’s code in both licenses?
Done.

> A one-line comment at the top explaining what it does would be great.
Done.

> Otherwise LGTM.  Could you send an updated patch?
See attachment. I’ve also enabled the plugin curl_json, which depends on
libyajl.

Cheers,
Lars

[0001-gnu-Add-collectd.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 40925-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
Cc: 40925-done <at> debbugs.gnu.org
Subject: Re: [bug#40925] [PATCH] Add collectd
Date: Mon, 04 May 2020 11:52:57 +0200

Hi,

Lars-Dominik Braun <ldb <at> leibniz-psychology.org> skribis:

> From 4f7f52ff168ba63692cf0f73e344847ef1637566 Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>
> Date: Tue, 28 Apr 2020 10:50:10 +0200
> Subject: [PATCH] gnu: Add collectd
>
> * gnu/packages/monitoring.scm (collectd): New variable
> * gnu/local.mk (dist_patch_DATA): Add new patch
> * gnu/packages/patches/collectd-5.11.0-noinstallvar.patch: New file

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.