GNU bug report logs - #40918
[PATCH] openjdk 14 package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40918 in the body.
You can then email your comments to 40918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Zucchi <notzed <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] openjdk 14 package
Date: Tue, 28 Apr 2020 10:56:55 +0930

[Message part 1 (text/plain, inline)]

This mostly is just a simple copy of openjdk12 with changed links.  
openjdk13 is also included as it must be used to bootstrap openjdk14.

openjdk14 uses "help" as a rather poor choice of autoconf test for the 
availability of a shell builtin and this isn't available in 
bash-minimal, so a small patch is needed to make configure complete.  
I've contacted the openjdk developers with a suggested change but so far 
have had no response after a couple of business days.

[Message part 2 (text/html, inline)]

[0001-gnu-packages-java.scm-openjdk13-opnejdk14.patch (text/x-patch, attachment)]

Message #8 received at 40918 <at> debbugs.gnu.org (full text, mbox):

From: Michael Zucchi <notzed <at> gmail.com>
To: 40918 <at> debbugs.gnu.org
Subject: update
Date: Tue, 28 Apr 2020 11:04:05 +0930

[Message part 1 (text/plain, inline)]

Sorry I missed a response from openjdk about the requested config change 
so I will follow that up and create another patch once it has filtered 
through their system since that shouldn't need a config patch to work.

[Message part 2 (text/html, inline)]

Message #11 received at 40918 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Michael Zucchi <notzed <at> gmail.com>
Cc: 40918 <at> debbugs.gnu.org
Subject: Re: [bug#40918] [PATCH] openjdk 14 package
Date: Wed, 29 Apr 2020 00:38:59 +0200

[Message part 1 (text/plain, inline)]

On Tue, 28 Apr 2020 10:56:55 +0930
Michael Zucchi <notzed <at> gmail.com> wrote:

> 
> This mostly is just a simple copy of openjdk12 with changed links.  
> openjdk13 is also included as it must be used to bootstrap openjdk14.
> 
> openjdk14 uses "help" as a rather poor choice of autoconf test for
> the availability of a shell builtin and this isn't available in 
> bash-minimal, so a small patch is needed to make configure complete.  
> I've contacted the openjdk developers with a suggested change but so
> far have had no response after a couple of business days.
> 
> 

Hi Michael,

thank you for your patch.

When sending in the second version of your
patch, could you please split up the commits, having one distinct
commit per added/changed package.

Please update your commit message according to the Changelog-style. You
will find examples in the old commit logs, for example for how to add
the patch-file.

Excited to see your second version,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 40918 <at> debbugs.gnu.org (full text, mbox):

From: Michael Zucchi <notzed <at> gmail.com>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 40918 <at> debbugs.gnu.org
Subject: Re: [bug#40918] [PATCH] openjdk 14 package
Date: Wed, 29 Apr 2020 09:17:22 +0930

On 29/4/20 8:08 am, Björn Höfling wrote:
> On Tue, 28 Apr 2020 10:56:55 +0930
> Michael Zucchi <notzed <at> gmail.com> wrote:
>
>> This mostly is just a simple copy of openjdk12 with changed links.
>> openjdk13 is also included as it must be used to bootstrap openjdk14.
>>
>> openjdk14 uses "help" as a rather poor choice of autoconf test for
>> the availability of a shell builtin and this isn't available in
>> bash-minimal, so a small patch is needed to make configure complete.
>> I've contacted the openjdk developers with a suggested change but so
>> far have had no response after a couple of business days.
>>
>>
> Hi Michael,
>
> thank you for your patch.
>
> When sending in the second version of your
> patch, could you please split up the commits, having one distinct
> commit per added/changed package.
>
> Please update your commit message according to the Changelog-style. You
> will find examples in the old commit logs, for example for how to add
> the patch-file.
>
> Excited to see your second version,
>
> Björn
>



I'm sorry i don't understand your second point, i used emacs changelog 
mode to create the commit message.

Message #17 received at 40918 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Michael Zucchi <notzed <at> gmail.com>
Cc: 40918 <at> debbugs.gnu.org
Subject: Re: [bug#40918] [PATCH] openjdk 14 package
Date: Wed, 29 Apr 2020 23:01:55 +0200

[Message part 1 (text/plain, inline)]

Hi Michael,

On Wed, 29 Apr 2020 09:17:22 +0930
Michael Zucchi <notzed <at> gmail.com> wrote:

> > Please update your commit message according to the Changelog-style.
> > You will find examples in the old commit logs, for example for how
> > to add the patch-file.

> I'm sorry i don't understand your second point, i used emacs
> changelog mode to create the commit message.

Let me try to explain that in more details. Guix is the pickiest
project I came along when it comes to commit messages. It took me a
while to get used to it. So please this shouldn't be a show-stopper for
you :-) In the end, a commiter can/will correct it.

Your git log consists of only one line:

* gnu/packages/java.scm (openjdk13, opnejdk14) * gnu/packages/patches/openjdk-14-builtins.patch: Added openjdk 13 and 14.

I would have expected something like:

----BEGIN EXAMPLE---
gnu: Add openjdk14.

* gnu/packages/java.scm (openjdk14): New variable.
* gnu/packages/patches/openjdk...patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
----END EXAMPLE---

So you really document every file you add, every variable/location
where you change something.

It is somewhat explained here, but at best look through older commits:

https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting-Patches
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs

Hope this explains it better,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 40918-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Michael Zucchi <notzed <at> gmail.com>, 40918-done <at> debbugs.gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Subject: Re: [bug#40918] [PATCH] openjdk 14 package
Date: Sat, 16 May 2020 11:54:01 +0200

Hi Michael,

thank you for your contribution!

I’ve split the commit into two (one for each package addition), replaced
the patch with a substitution, simplified the snippet, removed unused
inputs, used libjpeg-turbo instead of libjpeg, and corrected the commit
message.

I’ve pushed the two commits to the master branch:

--8<---------------cut here---------------start------------->8---
commit 65a11a59de86fa759f2ffbb7db53430a6727c2ea
Author: Not Zed <notzed <at> gmail.com>

    gnu: Add openjdk14.
    
    * gnu/packages/java.scm (openjdk14): New variable.
    
    Signed-off-by: Ricardo Wurmus <rekado <at> elephly.net>

commit c4618174ecb6375849529f1d1026585817bb139e
Author: Not Zed <notzed <at> gmail.com>

    gnu: Add openjdk13.
    
    * gnu/packages/java.scm (openjdk13): New variable.
    
    Signed-off-by: Ricardo Wurmus <rekado <at> elephly.net>
--8<---------------cut here---------------end--------------->8---

Thanks again!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.