Subject: Re: [bug#40902] [PATCH] gnu: Add edid-decode.

From: Mathieu Othacehe <[email-masked]>
Date: Tue, 28 Apr 2020 09:46:38 +0200

Hello Brice,

You can add your copyright.

> +(define-public edid-decode
> +  (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 2020-04-22
> +        (revision "1"))
> +   (package
> +     (name "edid-decode")
> +     (version (git-version "0.0.0" revision commit))

The indentation of the block seems wrong.

> +     (source
> +      (origin
> +        (method git-fetch)
> +        (file-name (git-file-name name version))
> +        (uri (git-reference
> +              (url "git://linuxtv.org/edid-decode.git")
> +              (commit commit)))
> +        (sha256
> +         (base32 "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah"))))
> +     (build-system gnu-build-system)
> +     (arguments
> +      `(#:tests? #f                     ; No test suite
> +        #:make-flags
> +        (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +              "bindir=/bin" "mandir=/share/man")
> +        #:phases
> +        (modify-phases %standard-phases
> +          (delete 'configure))))

When cross-compiling, a native binary is produced. This is because CXX
is set to 'g++' I guess. You need to do something similar to what is
done in the 'maradns' package.

Thanks,

Mathieu