GNU bug report logs - #40890
Add missing word "the" to file "custom.texi".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40890 in the body.
You can then email your comments to 40890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ej32u <at> protonmail.com
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 00:12:22 +0000

[Message part 1 (text/plain, inline)]

Hello,

The word "the" was missing. Attached is a patch file.

Thank you.

[Message part 2 (text/html, inline)]

[0001-Insert-missing-word-the.patch (text/x-patch, attachment)]

Message #8 received at 40890 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: ej32u <at> protonmail.com
Cc: 40890 <at> debbugs.gnu.org
Subject: Re: bug#40890: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 08:39:44 +0200

ej32u <at> protonmail.com writes:

> The word "the" was missing. Attached is a patch file.

Thanks for pointing this out.

>  values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see the kind of value it
>  expects (@pxref{Examining}).

Would that be better if written like this?

 values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
-check the variable's documentation string to see kind of value it
+check the variable's documentation string to see the kind of value it
 expects (@pxref{Examining}).

Best regards,
Stefan Kangas

Message #11 received at 40890 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Nordin <tomasn <at> posteo.net>
To: Stefan Kangas <stefan <at> marxist.se>, ej32u <at> protonmail.com
Cc: 40890 <at> debbugs.gnu.org
Subject: Re: bug#40890: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 10:43:00 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> ej32u <at> protonmail.com writes:
>
>> The word "the" was missing. Attached is a patch file.
>
> Thanks for pointing this out.
>
>>  values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
>> -check the variable's documentation string to see kind of value it
>> +check the variable's documentation string to see the kind of value it
>>  expects (@pxref{Examining}).
>
> Would that be better if written like this?
>
>  values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see the kind of value it
>  expects (@pxref{Examining}).

Isn't that what the patch suggest? But maybe ..*what* kind of value it..

Message #14 received at 40890 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Tomas Nordin <tomasn <at> posteo.net>
Cc: 40890 <at> debbugs.gnu.org, ej32u <at> protonmail.com
Subject: Re: bug#40890: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 12:16:50 +0200

Tomas Nordin <tomasn <at> posteo.net> writes:

> Isn't that what the patch suggest? But maybe ..*what* kind of value it..

Sorry, I forgot to save the file before copying the diff.  We have the
same idea, adding "what" instead of "the" here, fixed below:

 values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
-check the variable's documentation string to see kind of value it
+check the variable's documentation string to see what kind of value it
 expects (@pxref{Examining}).

But English is not my native language, so I wanted to check here first
before pushing a fix.

Best regards,
Stefan Kangas

Message #19 received at 40890 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 40890 <at> debbugs.gnu.org, tomasn <at> posteo.net, ej32u <at> protonmail.com
Subject: Re: bug#40890: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 17:46:14 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Mon, 27 Apr 2020 12:16:50 +0200
> Cc: 40890 <at> debbugs.gnu.org, ej32u <at> protonmail.com
> 
>  values.  When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see what kind of value it
>  expects (@pxref{Examining}).
> 
> But English is not my native language, so I wanted to check here first
> before pushing a fix.

This change is fine, thanks.

Message #22 received at 40890 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40890 <at> debbugs.gnu.org, tomasn <at> posteo.net, ej32u <at> protonmail.com
Subject: Re: bug#40890: Add missing word "the" to file "custom.texi".
Date: Mon, 27 Apr 2020 17:11:04 +0200

close 40890 27.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

> This change is fine, thanks.

Pushed to emacs-27 as commit 0278741676.  Closing this bug.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.