GNU bug report logs - #40876
[PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40876 in the body.
You can then email your comments to 40876 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.
Date: Sun, 26 Apr 2020 19:58:23 +0100

* gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
---
 gnu/packages/bdw-gc.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index 112a161f94..50e4951dc1 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
    libgc
    (arguments (substitute-keyword-arguments (package-arguments libgc)
                 ((#:configure-flags flags ''())
-                 `(cons "--enable-static" ,flags))))))
+                 `(cons "--enable-static" ,flags))))
+   (properties '((hidden? . #t)))))
 
 (define-public libgc-7
   (package
-- 
2.26.0

Message #8 received at 40876 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 40876 <at> debbugs.gnu.org, mbakke <at> fastmail.com
Subject: Re: [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it
 as hidden.
Date: Sun, 26 Apr 2020 20:14:59 +0100

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
>  gnu/packages/bdw-gc.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>     libgc
>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>                  ((#:configure-flags flags ''())
> -                 `(cons "--enable-static" ,flags))))))
> +                 `(cons "--enable-static" ,flags))))
> +   (properties '((hidden? . #t)))))
>
>  (define-public libgc-7
>    (package

Forgot to include you Marius when I sent this patch. Does this seem
sensible?

Otherwise you get this libgc variant when you use Guix on the command
line, and commands like guix lint complain.

./pre-inst-env guix lint libgc
guix lint: warning: ambiguous package specification `libgc'
guix lint: warning: choosing libgc <at> 8.0.4 from gnu/packages/bdw-gc.scm:90:2


I hope that setting the properties doesn't involve rebuilding anything.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 40876 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 40876 <at> debbugs.gnu.org
Subject: Re: [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it
 as hidden.
Date: Tue, 28 Apr 2020 16:39:33 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
>  gnu/packages/bdw-gc.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>     libgc
>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>                  ((#:configure-flags flags ''())
> -                 `(cons "--enable-static" ,flags))))))
> +                 `(cons "--enable-static" ,flags))))
> +   (properties '((hidden? . #t)))))

LGTM, thanks!  Properties are only used by the Guix 'front-end' and not
part of the derivation.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 40876-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 40876-done <at> debbugs.gnu.org
Subject: Re: [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it
 as hidden.
Date: Tue, 28 Apr 2020 22:56:53 +0100

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
>> ---
>>  gnu/packages/bdw-gc.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
>> index 112a161f94..50e4951dc1 100644
>> --- a/gnu/packages/bdw-gc.scm
>> +++ b/gnu/packages/bdw-gc.scm
>> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>>     libgc
>>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>>                  ((#:configure-flags flags ''())
>> -                 `(cons "--enable-static" ,flags))))))
>> +                 `(cons "--enable-static" ,flags))))
>> +   (properties '((hidden? . #t)))))
>
> LGTM, thanks!  Properties are only used by the Guix 'front-end' and not
> part of the derivation.

Great, I've pushed this as 709ca6c9824e4bbb0d81959b885248294fb062ae now.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.