From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 04:56:24 2020 Received: (at submit) by debbugs.gnu.org; 26 Apr 2020 08:56:24 +0000 Received: from localhost ([127.0.0.1]:60832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSd5L-0002Er-JL for submit@debbugs.gnu.org; Sun, 26 Apr 2020 04:56:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:49828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSd5J-0002Ej-7d for submit@debbugs.gnu.org; Sun, 26 Apr 2020 04:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36898) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSd5I-0002PB-Gg for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 04:56:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSd5H-0004Pq-Nu for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 04:56:20 -0400 Received: from mail-yb1-f172.google.com ([209.85.219.172]:34039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSd5G-0004Lb-F2 for bug-gnu-emacs@gnu.org; Sun, 26 Apr 2020 04:56:19 -0400 Received: by mail-yb1-f172.google.com with SMTP id l84so7714084ybb.1 for ; Sun, 26 Apr 2020 01:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KM9WokPN7sTj4uU23ArAanFSOPTXFcuNdFyv2HBpvLk=; b=nqYhDopc5ksqO7nZHmGfB96kT/PlSiZ84GM1ci+nFc8LaaBYSLu9KUEE1Hu0o/Nqgl ZAgoNAiqZYsta1p6oLr7iifcWaiJCdj7YvRn5mzfQEiaGzoj6ZgFNre7CDVKM19VRHEf 6BhPDcHj6iMorM5+oH+K+dDcdR8tLn8YIGOKOiuMSRTehWT6d3XWhgwRcLqTafSJjevt JSd1wROkFg0/3AAGmGZGMUiAowAehoGXKHFyM/z10cGCzsb7HnC1ebNw3OlbY+w+rzwO cDJ0c9AWDgMCi7YByjG5RUfg1vlxno6oYPt+aMFGw/h+ODAHIeqcY4MMBJCQl3KXW2wO BfKQ== X-Gm-Message-State: AGi0Pub7RpTubaBtLcSwYaQ/b9rfLU28HBIgthw3y8NR8a88RPp60IoS X7knQVHWHRuXCCaFSOGrcAUVTip6JccrcHi4vOsNWZxHWjY= X-Google-Smtp-Source: APiQypLCBw5mD9pSr0/c1KKeCVmdq4s9XChXKs8SJc8xkxghHlbK0tSU8xBjJrHC73EVNC1gyEiPtdFEgWVFo8kHJoY= X-Received: by 2002:a25:bec2:: with SMTP id k2mr28407935ybm.129.1587891377081; Sun, 26 Apr 2020 01:56:17 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 26 Apr 2020 10:56:03 +0200 Message-ID: Subject: [PATCH] Improve the display-time-world UI To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000792c9805a42dc57a" Received-SPF: pass client-ip=209.85.219.172; envelope-from=stefankangas@gmail.com; helo=mail-yb1-f172.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/26 04:56:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.219.172 X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I have made some improvements to the display-time-world UI. I divided them up into four patches to ease review and merging of the individual features. Please let me know what you think. (Of course I can squash the patches before pushing if that is preferable.) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000792c9805a42dc57a Content-Type: text/plain; charset="UTF-8" I have made some improvements to the display-time-world UI. I divided them up into four patches to ease review and merging of the individual features. Please let me know what you think. (Of course I can squash the patches before pushing if that is preferable.) Patch 4 adds an alias 'world-clock'. Ideally, I would like to rename the somewhat obscurely named 'display-world-time' to 'world-clock' and make the old names into obsolete aliases. It would be good to hear any opinions on that too. I'm also not sure if any of this should go into NEWS, so I didn't do that work for now. Let me know if that's desirable. Best regards, Stefan Kangas --000000000000792c9805a42dc57a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Kill-display-time-world-buffer-on-exit.patch" Content-Disposition: attachment; filename="0001-Kill-display-time-world-buffer-on-exit.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9gtemt60 RnJvbSAzZDhjMDkxYTAzYzI1ODI2NzU1YjM3MzVlY2E5ZGE0YjM0MjgyNmJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDA5OjM4OjAzICswMjAwClN1YmplY3Q6IFtQQVRDSCAx LzRdIEtpbGwgZGlzcGxheS10aW1lLXdvcmxkIGJ1ZmZlciBvbiBleGl0CgoqIGxpc3AvdGltZS5l bCAoZGlzcGxheS10aW1lLXdvcmxkLW1vZGUtbWFwKTogTmV3IGRlZnZhci4KKGRpc3BsYXktdGlt ZS13b3JsZC1leGl0KTogTmV3IGRlZnVuIHRvIGtpbGwgYnVmZmVyIG9uIGV4aXQuCihkaXNwbGF5 LXRpbWUtd29ybGQpOiBEb2MgZml4LgotLS0KIGxpc3AvdGltZS5lbCB8IDE1ICsrKysrKysrKysr KysrLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9saXNwL3RpbWUuZWwgYi9saXNwL3RpbWUuZWwKaW5kZXggNDRmZDFhN2UzMy4u YTVlNWI5YjRhNyAxMDA2NDQKLS0tIGEvbGlzcC90aW1lLmVsCisrKyBiL2xpc3AvdGltZS5lbApA QCAtNTA5LDYgKzUwOSwxMyBAQCBkaXNwbGF5LXRpbWUtbW9kZQogCQkgJ2Rpc3BsYXktdGltZS1l dmVudC1oYW5kbGVyKSkpCiAKIAorKGRlZnZhciBkaXNwbGF5LXRpbWUtd29ybGQtbW9kZS1tYXAK KyAgKGxldCAoKG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpCisgICAgKGRlZmluZS1rZXkgbWFw ICJnIiBuaWwpCisgICAgKGRlZmluZS1rZXkgbWFwICJxIiAnZGlzcGxheS10aW1lLXdvcmxkLWV4 aXQpCisgICAgbWFwKQorICAiS2V5bWFwIGZvciBgZGlzcGxheS10aW1lLXdvcmxkLW1vZGUnLiIp CisKIChkZWZpbmUtZGVyaXZlZC1tb2RlIGRpc3BsYXktdGltZS13b3JsZC1tb2RlIHNwZWNpYWwt bW9kZSAiV29ybGQgY2xvY2siCiAgICJNYWpvciBtb2RlIGZvciBidWZmZXIgdGhhdCBkaXNwbGF5 cyB0aW1lcyBpbiB2YXJpb3VzIHRpbWUgem9uZXMuCiBTZWUgYGRpc3BsYXktdGltZS13b3JsZCcu IgpAQCAtNTM3LDExICs1NDQsMTcgQEAgZGlzcGxheS10aW1lLXdvcmxkLWRpc3BsYXkKICAgICAo ZGVsZXRlLWNoYXIgLTEpKQogICAoZ290by1jaGFyIChwb2ludC1taW4pKSkKIAorKGRlZnVuIGRp c3BsYXktdGltZS13b3JsZC1leGl0ICgpCisgICJRdWl0IHRoZSB3b3JsZCB0aW1lIGJ1ZmZlci4i CisgIChpbnRlcmFjdGl2ZSkKKyAgKHF1aXQtd2luZG93IHQpKQorCiA7OzsjIyNhdXRvbG9hZAog KGRlZnVuIGRpc3BsYXktdGltZS13b3JsZCAoKQogICAiRW5hYmxlIHVwZGF0aW5nIGRpc3BsYXkg b2YgdGltZXMgaW4gdmFyaW91cyB0aW1lIHpvbmVzLgorXFw8ZGlzcGxheS10aW1lLXdvcmxkLW1v ZGUtbWFwPgogYGRpc3BsYXktdGltZS13b3JsZC1saXN0JyBzcGVjaWZpZXMgdGhlIHpvbmVzLgot VG8gdHVybiBvZmYgdGhlIHdvcmxkIHRpbWUgZGlzcGxheSwgZ28gdG8gdGhhdCB3aW5kb3cgYW5k IHR5cGUgYHEnLiIKK1RvIHR1cm4gb2ZmIHRoZSB3b3JsZCB0aW1lIGRpc3BsYXksIGdvIHRvIHRo YXQgd2luZG93IGFuZCB0eXBlIGBcXFtkaXNwbGF5LXRpbWUtd29ybGQtZXhpdF0nLiIKICAgKGlu dGVyYWN0aXZlKQogICAod2hlbiAoYW5kIGRpc3BsYXktdGltZS13b3JsZC10aW1lci1lbmFibGUK ICAgICAgICAgICAgICAobm90IChnZXQtYnVmZmVyIGRpc3BsYXktdGltZS13b3JsZC1idWZmZXIt bmFtZSkpKQotLSAKMi4yNi4yCgo= --000000000000792c9805a42dc57a Content-Type: text/x-patch; charset="US-ASCII"; name="0002-New-face-for-display-time-world-label.patch" Content-Disposition: attachment; filename="0002-New-face-for-display-time-world-label.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9gteowp1 RnJvbSA2NjgwNzA1ZjQ2NGRkNmU1ODJlNzBiZWFmNjRiMDI3YWM1N2QwZDQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDEwOjE2OjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSCAy LzRdIE5ldyBmYWNlIGZvciBkaXNwbGF5LXRpbWUtd29ybGQgbGFiZWwKCiogbGlzcC90aW1lLmVs IChkaXNwbGF5LXRpbWUtd29ybGQtbGFiZWwpOiBOZXcgZmFjZS4KKGRpc3BsYXktdGltZS13b3Js ZC1kaXNwbGF5KTogVXNlIHRoZSBuZXcgZmFjZS4KLS0tCiBsaXNwL3RpbWUuZWwgfCA5ICsrKysr KysrLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2xpc3AvdGltZS5lbCBiL2xpc3AvdGltZS5lbAppbmRleCBhNWU1YjliNGE3Li40 NDg4NWY3NGQxIDEwMDY0NAotLS0gYS9saXNwL3RpbWUuZWwKKysrIGIvbGlzcC90aW1lLmVsCkBA IC01MTYsNiArNTE2LDEwIEBAIGRpc3BsYXktdGltZS13b3JsZC1tb2RlLW1hcAogICAgIG1hcCkK ICAgIktleW1hcCBmb3IgYGRpc3BsYXktdGltZS13b3JsZC1tb2RlJy4iKQogCisoZGVmZmFjZSBk aXNwbGF5LXRpbWUtd29ybGQtbGFiZWwKKyAgJygodCA6aW5oZXJpdCBmb250LWxvY2stdmFyaWFi bGUtbmFtZS1mYWNlKSkKKyAgIkZhY2UgZm9yIHRpbWUgem9uZSBsYWJlbC4iKQorCiAoZGVmaW5l LWRlcml2ZWQtbW9kZSBkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSBzcGVjaWFsLW1vZGUgIldvcmxk IGNsb2NrIgogICAiTWFqb3IgbW9kZSBmb3IgYnVmZmVyIHRoYXQgZGlzcGxheXMgdGltZXMgaW4g dmFyaW91cyB0aW1lIHpvbmVzLgogU2VlIGBkaXNwbGF5LXRpbWUtd29ybGQnLiIKQEAgLTU0MCw3 ICs1NDQsMTAgQEAgZGlzcGxheS10aW1lLXdvcmxkLWRpc3BsYXkKIAkgIChzZXRxIG1heC13aWR0 aCB3aWR0aCkpKSkKICAgICAoc2V0cSBmbXQgKGNvbmNhdCAiJS0iIChpbnQtdG8tc3RyaW5nIG1h eC13aWR0aCkgInMgJXNcbiIpKQogICAgIChkb2xpc3QgKHRpbWVkYXRhIChucmV2ZXJzZSByZXN1 bHQpKQotICAgICAgKGluc2VydCAoZm9ybWF0IGZtdCAoY2FyIHRpbWVkYXRhKSAoY2RyIHRpbWVk YXRhKSkpKQorICAgICAgKGluc2VydCAoZm9ybWF0IGZtdAorICAgICAgICAgICAgICAgICAgICAg IChwcm9wZXJ0aXplIChjYXIgdGltZWRhdGEpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJ2ZhY2UgJ2Rpc3BsYXktdGltZS13b3JsZC1sYWJlbCkKKyAgICAgICAgICAgICAgICAg ICAgICAoY2RyIHRpbWVkYXRhKSkpKQogICAgIChkZWxldGUtY2hhciAtMSkpCiAgIChnb3RvLWNo YXIgKHBvaW50LW1pbikpKQogCi0tIAoyLjI2LjIKCg== --000000000000792c9805a42dc57a Content-Type: text/x-patch; charset="US-ASCII"; name="0003-Move-point-to-new-buffer-for-display-time-world.patch" Content-Disposition: attachment; filename="0003-Move-point-to-new-buffer-for-display-time-world.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9gtesd32 RnJvbSAwZjJjYTk1NGUwM2I4NTc1NTQwNzFhZTQ4YTk4ZDQ0YmE3MDMwZDY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDEwOjQ0OjAwICswMjAwClN1YmplY3Q6IFtQQVRDSCAz LzRdIE1vdmUgcG9pbnQgdG8gbmV3IGJ1ZmZlciBmb3IgZGlzcGxheS10aW1lLXdvcmxkCgoqIGxp c3AvdGltZS5lbCAoZGlzcGxheS10aW1lLXdvcmxkKTogTW92ZSBwb2ludCB0byBjcmVhdGVkIGJ1 ZmZlci4KLS0tCiBsaXNwL3RpbWUuZWwgfCAxMCArKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGltZS5l bCBiL2xpc3AvdGltZS5lbAppbmRleCA0NDg4NWY3NGQxLi44NGMwMDcxYjdkIDEwMDY0NAotLS0g YS9saXNwL3RpbWUuZWwKKysrIGIvbGlzcC90aW1lLmVsCkBAIC01NjYsMTEgKzU2NiwxMSBAQCBk aXNwbGF5LXRpbWUtd29ybGQKICAgKHdoZW4gKGFuZCBkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIt ZW5hYmxlCiAgICAgICAgICAgICAgKG5vdCAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQt YnVmZmVyLW5hbWUpKSkKICAgICAocnVuLWF0LXRpbWUgdCBkaXNwbGF5LXRpbWUtd29ybGQtdGlt ZXItc2Vjb25kICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIpKQotICAod2l0aC1jdXJyZW50LWJ1 ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1lKQot ICAgIChkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0 KSkKLSAgICAoZGlzcGxheS1idWZmZXIgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1lCi0J CSAgICAoY29ucyBuaWwgJygod2luZG93LWhlaWdodCAuIGZpdC13aW5kb3ctdG8tYnVmZmVyKSkp KQotICAgIChkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSkpKQorICAoc3dpdGNoLXRvLWJ1ZmZlci1v dGhlci13aW5kb3cgKGdldC1idWZmZXItY3JlYXRlIGRpc3BsYXktdGltZS13b3JsZC1idWZmZXIt bmFtZSkpCisgIChkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3Js ZC1saXN0KSkKKyAgKGRpc3BsYXktYnVmZmVyIGRpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFt ZQorCQkgIChjb25zIG5pbCAnKCh3aW5kb3ctaGVpZ2h0IC4gZml0LXdpbmRvdy10by1idWZmZXIp KSkpCisgIChkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSkpCiAKIChkZWZ1biBkaXNwbGF5LXRpbWUt d29ybGQtdGltZXIgKCkKICAgKGlmIChnZXQtYnVmZmVyIGRpc3BsYXktdGltZS13b3JsZC1idWZm ZXItbmFtZSkKLS0gCjIuMjYuMgoK --000000000000792c9805a42dc57a Content-Type: text/x-patch; charset="US-ASCII"; name="0004-Improve-the-display-time-world-UI.patch" Content-Disposition: attachment; filename="0004-Improve-the-display-time-world-UI.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9gtev3i3 RnJvbSA0NzQwMWExZTEwMjEzZDg5Y2JkYjZlYWEyYjY2YjQ0YzJiZTM3ZGZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDEwOjQ3OjE3ICswMjAwClN1YmplY3Q6IFtQQVRDSCA0 LzRdIEltcHJvdmUgdGhlIGRpc3BsYXktdGltZS13b3JsZCBVSQoKKiBsaXNwL3RpbWUuZWwgKGRp c3BsYXktdGltZS13b3JsZC1idWZmZXItbmFtZSk6IENoYW5nZSBkZWZhdWx0CmJ1ZmZlciBuYW1l LgooZGlzcGxheS10aW1lLXdvcmxkKTogQWRkIHVzYWdlIGluc3RydWN0aW9ucyB0byBtb2RlbGlu ZS4KKHdvcmxkLWNsb2NrKTogTmV3IGRlZmFsaWFzIGZvciAnZGlzcGxheS10aW1lLXdvcmxkJy4K LS0tCiBsaXNwL3RpbWUuZWwgfCAxMCArKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGltZS5lbCBiL2xp c3AvdGltZS5lbAppbmRleCA4NGMwMDcxYjdkLi4xOGRlMzk5MGMzIDEwMDY0NAotLS0gYS9saXNw L3RpbWUuZWwKKysrIGIvbGlzcC90aW1lLmVsCkBAIC0xOTUsMTEgKzE5NSwxMSBAQCBkaXNwbGF5 LXRpbWUtd29ybGQtdGltZS1mb3JtYXQKICAgOnR5cGUgJ3N0cmluZwogICA6dmVyc2lvbiAiMjMu MSIpCiAKLShkZWZjdXN0b20gZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1lICIqd2Nsb2Nr KiIKKyhkZWZjdXN0b20gZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1lICIqV29ybGQgQ2xv Y2sqIgogICAiTmFtZSBvZiB0aGUgd29ybGQgY2xvY2sgYnVmZmVyLiIKICAgOmdyb3VwICdkaXNw bGF5LXRpbWUKICAgOnR5cGUgJ3N0cmluZwotICA6dmVyc2lvbiAiMjMuMSIpCisgIDp2ZXJzaW9u ICIyOC4xIikKIAogKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtd29ybGQtdGltZXItZW5hYmxlIHQK ICAgIklmIG5vbi1uaWwsIGEgdGltZXIgd2lsbCB1cGRhdGUgdGhlIHdvcmxkIGNsb2NrLiIKQEAg LTU3MCw3ICs1NzAsMTEgQEAgZGlzcGxheS10aW1lLXdvcmxkCiAgIChkaXNwbGF5LXRpbWUtd29y bGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkKICAgKGRpc3BsYXktYnVmZmVy IGRpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFtZQogCQkgIChjb25zIG5pbCAnKCh3aW5kb3ct aGVpZ2h0IC4gZml0LXdpbmRvdy10by1idWZmZXIpKSkpCi0gIChkaXNwbGF5LXRpbWUtd29ybGQt bW9kZSkpCisgIChkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSkKKyAgKHNldHEgbW9kZS1saW5lLWZv cm1hdCAoZm9ybWF0ICIlMTVzICUxM3MiICJXb3JsZCBDbG9jayIgInEgdG8gcXVpdCIpKSkKKwor OzsgVGhpcyB3b3VsZCBiZSBhIG1vcmUgaW50dWl0aXZlIG5hbWUuCisoZGVmYWxpYXMgJ3dvcmxk LWNsb2NrICdkaXNwbGF5LXRpbWUtd29ybGQpCiAKIChkZWZ1biBkaXNwbGF5LXRpbWUtd29ybGQt dGltZXIgKCkKICAgKGlmIChnZXQtYnVmZmVyIGRpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFt ZSkKLS0gCjIuMjYuMgoK --000000000000792c9805a42dc57a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 10:08:46 2020 Received: (at 40863) by debbugs.gnu.org; 26 Apr 2020 14:08:46 +0000 Received: from localhost ([127.0.0.1]:33853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShxe-0006EH-Lw for submit@debbugs.gnu.org; Sun, 26 Apr 2020 10:08:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShxd-0006Dc-8K for 40863@debbugs.gnu.org; Sun, 26 Apr 2020 10:08:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43638) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jShxY-0002SH-2M; Sun, 26 Apr 2020 10:08:40 -0400 Received: from [176.228.60.248] (port=3884 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jShxX-0003hq-Hs; Sun, 26 Apr 2020 10:08:39 -0400 Date: Sun, 26 Apr 2020 17:08:33 +0300 Message-Id: <831roa731a.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Sun, 26 Apr 2020 10:56:03 +0200) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sun, 26 Apr 2020 10:56:03 +0200 > > -(defcustom display-time-world-buffer-name "*wclock*" > +(defcustom display-time-world-buffer-name "*World Clock*" Is this part really necessary? what if some application or user out there expects the old name? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 10:19:16 2020 Received: (at 40863) by debbugs.gnu.org; 26 Apr 2020 14:19:16 +0000 Received: from localhost ([127.0.0.1]:33860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSi7o-00079l-Hy for submit@debbugs.gnu.org; Sun, 26 Apr 2020 10:19:16 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:58152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSi7k-00079S-9Z for 40863@debbugs.gnu.org; Sun, 26 Apr 2020 10:19:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XcPCgYYa0ZOW6aRo7cdfdtP4iKsO9NoKOuRdSa2fiwA=; b=rNkjJrAkm6Nw9l7YKwqePrJL+E RLbx8R0rpsX10WwS2kSKPK+G+EpzO5YyqAgh0t9hSybhzoqP9RJhQiHyIIRdfKfzvlTfGdCExpudD lst3BcLZwLzhwJnDEAsQJfnfolqyoGjujA6jm26ROtd4jE4egXxIl2h9j3HdISBV8BPr27Xtbdib1 hdevK7CVd1oWkXtWI47kN6yLRqeoQHG9gDc6NIOEQK/1MYJWHJc7Ii7tDvfSEeLCYBBTBJMWlbuF0 cbOXfvI6hcPQlsagFjtNhKWHk10VBzH7+owrF8E21jcfVuaUL6LiJFw0GszDWtPbJDahk/vUoimaH 6W6w0zvQ==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:35964 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jSi7e-001ila-LP; Sun, 26 Apr 2020 10:19:06 -0400 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <831roa731a.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Apr 2020 17:08:33 +0300") References: <831roa731a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 26 Apr 2020 16:19:04 +0200 Message-ID: <87wo629von.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> -(defcustom display-time-world-buffer-name "*wclock*" >> +(defcustom display-time-world-buffer-name "*World Clock*" > > Is this part really necessary? what if some application or user out > there expects the old name? Good point, I'll leave that part out. Thanks for reviewing. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 13:20:51 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 17:20:51 +0000 Received: from localhost ([127.0.0.1]:38028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT7R5-0000lB-82 for submit@debbugs.gnu.org; Mon, 27 Apr 2020 13:20:51 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:42721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT7R3-0000kv-Bl for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 13:20:49 -0400 Received: by mail-qt1-f169.google.com with SMTP id x12so14388640qts.9 for <40863@debbugs.gnu.org>; Mon, 27 Apr 2020 10:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b9/CNPi/QrTB4S/AxMBLWF5Z5zLH126A8TAULRe5H4w=; b=set92pCyaSDOE8s5vfDQwBLs2MAc8t9pIH3XLEZR2kF0PgCBxDNjnxkEe6Huscly+t 9URFC35XHgn3QsRhLv9U1kTchbMRj+Ye3DnNuKrUtjXnuHtGAF9hJLqzknSKhnViLwMY zftz08SSKZiDhxV1hQ181gtvSeVmlAoUGZhsyna7c3ib7Ip/aOajcWqrXDcDUe4FQawh 42Cr2T4OPdzWV73G09BO0xZN8MPJhj2Iyewi1JdZS+krmqnXSDNKWrVkNkdBsNy1Qw5H evB157i1NML/phtUs7nuCr/sExBsudwCMvRsDetsMElYQiZDd3blaulQDpI12Uh+4IfU 0qAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=b9/CNPi/QrTB4S/AxMBLWF5Z5zLH126A8TAULRe5H4w=; b=hMz9vTFw0CqgjS06UtaT6q500fPkO3BdIOLNqclp84OBoyljEOqVuFryRQPOpVi2xA LFJ62LKDKIIGatsvPG/Mqe7lOzeRvIzUDQaU4XQAHKMjJ5Vx17iCKNegZr/O5Hp/aTt8 VxXgDLgI2lPeo944+1/zqHQ1jutEghyC/9dTNIWVXeT5inMojJ3BBqLhJVxbfctH6O1a wtHoBlftqNwBvWojy5ALq/mdTVz87AbP1D3Hq6BgXkQ/PjPm31KTOS5gwY7wCnXWhf57 66LOSrLBBOCGhmOoCSvVGCYa2KgqJ1Hvs0cyizKnjr9PDuRTR1p3nqyMJFKRzh4GmK/g JTlw== X-Gm-Message-State: AGi0PuZtluJnwFj60FWYsSuXi2uurzSvhzYxkvcWmQonifx1Go9idk3c 2bd3rBruEMiHKTe7EijiLULU9GP3 X-Google-Smtp-Source: APiQypIrZIjAHzHjxWqoy3zNGXZpXXlegGKjHhxo1xFMr3YHNpuhNxdEeEzmbJpAZZnBS6Au+A0/1A== X-Received: by 2002:aed:3bda:: with SMTP id s26mr24079207qte.261.1588008043583; Mon, 27 Apr 2020 10:20:43 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id k2sm11102819qte.16.2020.04.27.10.20.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Apr 2020 10:20:42 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> Date: Mon, 27 Apr 2020 13:20:40 -0400 In-Reply-To: <831roa731a.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Apr 2020 17:08:33 +0300") Message-ID: <85y2qg976f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Sun, 26 Apr 2020 10:56:03 +0200 >> >> -(defcustom display-time-world-buffer-name "*wclock*" >> +(defcustom display-time-world-buffer-name "*World Clock*" > > Is this part really necessary? what if some application or user out > there expects the old name? If an application expects a particular name, then it's already broken because the user can change the defcustom at any time, right? And if a user expects the old name, they can customize it back to the old value. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 13:22:20 2020 Received: (at control) by debbugs.gnu.org; 27 Apr 2020 17:22:20 +0000 Received: from localhost ([127.0.0.1]:38032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT7SW-0000oL-LA for submit@debbugs.gnu.org; Mon, 27 Apr 2020 13:22:20 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]:40240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT7SV-0000o7-9W for control@debbugs.gnu.org; Mon, 27 Apr 2020 13:22:19 -0400 Received: by mail-qk1-f179.google.com with SMTP id l78so18808346qke.7 for ; Mon, 27 Apr 2020 10:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=XACSTjH/dEfb1gTp96oz9sXC+w6p1JVsGdezS1bIXTA=; b=tgMobW3INCOKAF404X4KrlaDKTokw6YFlkFxEbrHpZALHQ/+3/+d4aeS9HFD2nku1u gKIYg0KoRk0so/6WFXXDUFdyhJtPq8PZgQ6z6/Zz3FFsY7CzeE9EuwMNXWvzgGimvv1A 2jYmoYmK6CgZ9opaUjJWWZAz3zMb55PWIjhApR4gnbPL/Md/GyPY4NZjkQsCdon5P+lI CeoZF44fiF3nkqLa5Ph3BEBmi5T+FqJVZg2D8tNNw0GJJL8VvEZ2MxXVvH3S6r9AagHr T7kfpZgAhZqnmtgZBPqbAw6vp+qOUtpTtNrciAHwUCCf/etFgkdbGyZK3/QegEYCoG9p UTYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=XACSTjH/dEfb1gTp96oz9sXC+w6p1JVsGdezS1bIXTA=; b=cb+SapHrtf6HDtS2F3upRlWSKCwyjHTC3+8ovFNneDc097lxA8gWoIW3H7Y1/Cz8kq 8o9gIYpSTJW6N26Ccntjy3b1+gTbDwWDlJecY8jmN/qRSYZQckx/ur5+qUJNw+sdNSdy cePAtRrRyyqWWdhawRXS+ePnaxWMXME0GfZflCNSrjMqQvVpcgSnDezaaXyX24PFatmb vtkYVUSUpQfZgxso+0FSwPr9eG3RFBKZs8RQp+4AjOYm95t2JdPr2Fpbu2EyOhtgXbua D4HU0k2VVtaD7JGf+mhF8zB+RMYiceLerCkgIYCW23h/qEMNRuiXd9xkJy6C4JNK9xU2 uQtw== X-Gm-Message-State: AGi0PuZkBaef/LIEToH/VL8OazO1nXuMfPteqTAiOpxYZ7cvFjOmB1K2 ATiOTjW+MVemI9k51C6WSkH6b/Ad X-Google-Smtp-Source: APiQypLniw/i8y1TLFx+3JFYNO1gl1TIEX8y0JAP9esaZnO/k2Rodjk5+yzG5r8rNAwhVn4w92wnog== X-Received: by 2002:a37:9e08:: with SMTP id h8mr23979690qke.369.1588008133681; Mon, 27 Apr 2020 10:22:13 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id j90sm11353819qte.20.2020.04.27.10.22.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Apr 2020 10:22:13 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #40877 Date: Mon, 27 Apr 2020 13:22:11 -0400 Message-ID: <85wo60973w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 40877 wishlist severity 40863 wishlist severity 40854 wishlist severity 40813 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 14:32:06 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 18:32:06 +0000 Received: from localhost ([127.0.0.1]:38143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT8Y2-0004rL-3p for submit@debbugs.gnu.org; Mon, 27 Apr 2020 14:32:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT8Y0-0004qf-NG for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 14:32:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41877) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT8Xv-0007tp-Az; Mon, 27 Apr 2020 14:31:59 -0400 Received: from [176.228.60.248] (port=4480 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jT8Xu-0003rf-Bg; Mon, 27 Apr 2020 14:31:58 -0400 Date: Mon, 27 Apr 2020 21:31:51 +0300 Message-Id: <83ees84w6g.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-Reply-To: <85y2qg976f.fsf@gmail.com> (message from Noam Postavsky on Mon, 27 Apr 2020 13:20:40 -0400) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Cc: Stefan Kangas , 40863@debbugs.gnu.org > Date: Mon, 27 Apr 2020 13:20:40 -0400 > > Eli Zaretskii writes: > > >> From: Stefan Kangas > >> Date: Sun, 26 Apr 2020 10:56:03 +0200 > >> > >> -(defcustom display-time-world-buffer-name "*wclock*" > >> +(defcustom display-time-world-buffer-name "*World Clock*" > > > > Is this part really necessary? what if some application or user out > > there expects the old name? > > If an application expects a particular name, then it's already broken > because the user can change the defcustom at any time, right? And if a > user expects the old name, they can customize it back to the old value. So you are saying that we should change these names from time to time just to make a point? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 15:00:47 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 19:00:47 +0000 Received: from localhost ([127.0.0.1]:38160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT8zm-0005aR-S4 for submit@debbugs.gnu.org; Mon, 27 Apr 2020 15:00:47 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:46075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT8zl-0005aD-H3 for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 15:00:45 -0400 Received: by mail-qk1-f173.google.com with SMTP id m67so19125431qke.12 for <40863@debbugs.gnu.org>; Mon, 27 Apr 2020 12:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OnQXeeAE9Q06ZwUZ8Vi1z0K+n/sQR++x5TrZcaNDZ2A=; b=QGholCENLoJkl4GAc1t5zzE1M9i8sktex6rhxLLYy7f5mibBwdMMyyHHooHHz4iXfW 7NhM24kbNohS/KqmuYoUeJIVlWHperIO8IAhcOBaQ2bagJrWpsd4WL5weeRI6uP7vdvv FijJ/Z17TTPa3180g88lI7PIyrMPhsXjGqI8t8YcZXOyNm+/zXH3pRq/n9fxSquE5bXe 24hisHCoFQ1IZFiLjMeIjOIxdRnTZL3zd/ziI6DBq9EPTDALIu+1BskqDeBl8Cw/Fn7g Osu1jV525MTn6JJJzx0S8JQubJw5BSY6l7DMDPXXyZp81hEDw9jfuqeWESacXMyqh4SO 4mTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OnQXeeAE9Q06ZwUZ8Vi1z0K+n/sQR++x5TrZcaNDZ2A=; b=XlDI2ppYWMNIjQE47F4rMV12cEuDenHN8+hPD3tTy5WypXy1SS9R6lI8b3uYecwYmD eTT8n1IBYTFhZa7l3zdOm8+QrZkm2WuFwPz0X6GZAO1TEdAXOrpdbofTiDzozPl9R2iD rfZDIBay9+atQbafPRBPMXFuO0Q6/lYXxFaj1yYRzGy6gjlxgE+qj+iT2O+ysSjZhDPV z4Z9nEUFhQxwoviwugJixse3/S3fW+VWcZ/B1+9ve2KG0SnHGuySdAtErXISSc9/8LiQ 9lBJwJQrsrdV54cUec3JLBpdlXv3g2jSI2iY8cwqviY6w4v95rtZ+n3+cPWVFJVrq9Q5 312w== X-Gm-Message-State: AGi0PubJu7EadcuP/vadvTNFnc/Ml/wR5nZbkNW41OimC2ju7GOm1/W2 WlKuVahCcfbywUMQOuapKow= X-Google-Smtp-Source: APiQypJ6BgawxyFe21azRGmmhbkLdF6XLj3hHNIrZcawG0+7VZ6lLQ5u9hCeQauvWdclO2d02vJRdQ== X-Received: by 2002:ae9:e606:: with SMTP id z6mr23276422qkf.320.1588014039830; Mon, 27 Apr 2020 12:00:39 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id 103sm11603076qte.82.2020.04.27.12.00.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Apr 2020 12:00:39 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> Date: Mon, 27 Apr 2020 15:00:37 -0400 In-Reply-To: <83ees84w6g.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Apr 2020 21:31:51 +0300") Message-ID: <85tv1492ju.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: Stefan Kangas , 40863@debbugs.gnu.org >> Date: Mon, 27 Apr 2020 13:20:40 -0400 >> >> Eli Zaretskii writes: >> >> >> From: Stefan Kangas >> >> Date: Sun, 26 Apr 2020 10:56:03 +0200 >> >> >> >> -(defcustom display-time-world-buffer-name "*wclock*" >> >> +(defcustom display-time-world-buffer-name "*World Clock*" >> > >> > Is this part really necessary? what if some application or user out >> > there expects the old name? >> >> If an application expects a particular name, then it's already broken >> because the user can change the defcustom at any time, right? And if a >> user expects the old name, they can customize it back to the old value. > > So you are saying that we should change these names from time to time > just to make a point? No, I think changing the name here makes it more readable (i.e., it's not a random change, it's an improvement). And I think this benefit outweighs the possible existence of broken applications, or users possibly preferring the current value (I will admit this weighting also somewhat depends on the probability of these hypotheticals actually turning out to be real, which I've no real basis for; you might judge them to be more likely than I do). From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 15:36:15 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 19:36:15 +0000 Received: from localhost ([127.0.0.1]:38182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT9Y7-0006UC-Gk for submit@debbugs.gnu.org; Mon, 27 Apr 2020 15:36:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT9Y5-0006Tz-Tm for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 15:36:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42784) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT9Y0-0004mQ-C7; Mon, 27 Apr 2020 15:36:08 -0400 Received: from [176.228.60.248] (port=4484 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jT9Xy-0002eh-RU; Mon, 27 Apr 2020 15:36:08 -0400 Date: Mon, 27 Apr 2020 22:35:58 +0300 Message-Id: <834kt44t7l.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-Reply-To: <85tv1492ju.fsf@gmail.com> (message from Noam Postavsky on Mon, 27 Apr 2020 15:00:37 -0400) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Noam Postavsky > Cc: 40863@debbugs.gnu.org, stefan@marxist.se > Date: Mon, 27 Apr 2020 15:00:37 -0400 > > No, I think changing the name here makes it more readable (i.e., it's > not a random change, it's an improvement). And I think this benefit > outweighs the possible existence of broken applications, or users > possibly preferring the current value (I will admit this weighting also > somewhat depends on the probability of these hypotheticals actually > turning out to be real, which I've no real basis for; you might judge > them to be more likely than I do). I guess it's a matter of personal preferences, then. E.g., we have *scratch* and *xref*. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 18:00:42 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 22:00:42 +0000 Received: from localhost ([127.0.0.1]:38336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTBnu-0004Bv-Ic for submit@debbugs.gnu.org; Mon, 27 Apr 2020 18:00:42 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTBns-0004Bf-Jt for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 18:00:41 -0400 Received: by mail-wr1-f43.google.com with SMTP id d15so20729096wrx.3 for <40863@debbugs.gnu.org>; Mon, 27 Apr 2020 15:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mKj0JbLJz/a3e4TeuPmv4lvARcMeiOTtpQ8QiVJwFAs=; b=QZRqri621dF113hcyCzZbZk0mKtGqwGBHGbrwlf8LTJeFVrfPtMfFjUr7aL5ddZgRI nalWbJgF43kCkeTvmzbecJqWRMmALWAITxmmEDA5AKviimbLOKJ9KM7z6wK7GhxBJhzp wD8c3q3DBaag56laYWyAE2LKBEyLC64ZMVeqT27hKMVDUkG6BFxUah4Gess3UJTM3xsR zY2HHwCb0foP4Bdq+uhpbU6iIuevoe9TZg1CK3UdNoYprwgNvDgtw9evDz6kARaf7NOt Gn+Oc4ZfBAOBLzcoqY8ksjwlSIb813ZpKk2w19jT9xX/n2t4Qpsp2hXXxVPHswNiE8vP I5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mKj0JbLJz/a3e4TeuPmv4lvARcMeiOTtpQ8QiVJwFAs=; b=pqjOKDtNCrdvLYP52d+eQaI7zB/9ju90UbCwF9M2VHb4qP1uYwFj0AllkwXfxmqi/7 fwFShentVuJ3nedcY2bQBskYCOlBVBUA6PrxKRD1s/4yvaJw3mxXOquFZHMt/9KrIHX3 EJChXv2y423yxScuWuLRz07kONd6HGiwIeEWvduXB9ur+raeg4Uasm3ef0ua0zzi9Ksf O6zI5/DvuVNL3+lZRUZSqF7UQtfjAIDb8UKeZTU+gY84Snv0Xxa6cEMnI9+VSuABTQhR pCDGvAxulUvXgE92Mt+2W4QcHnTfnWdNslmqIjFGPCJZ+6XITaVaz0YxZIQkJpVn+56D /ALw== X-Gm-Message-State: AGi0PuatqpaDPiEHVd8U5YRc31vWIYl/bmQVXBEnSeS+h7KY28VPSYwa KrdsFshYA8NhEt1/jLE8iFU= X-Google-Smtp-Source: APiQypIH5y0ojchhIvxyaDGo42p7hYxkfz6Np6iWcl2X2l7Uvc2g2PzUxqEcwibN7sVGyrAjogvnuw== X-Received: by 2002:adf:fad0:: with SMTP id a16mr32583031wrs.149.1588024834626; Mon, 27 Apr 2020 15:00:34 -0700 (PDT) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id h137sm2010456wme.0.2020.04.27.15.00.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 15:00:33 -0700 (PDT) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: Eli Zaretskii , Noam Postavsky References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <834kt44t7l.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Tue, 28 Apr 2020 01:00:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <834kt44t7l.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 27.04.2020 22:35, Eli Zaretskii wrote: > I guess it's a matter of personal preferences, then. E.g., we have > *scratch* and*xref*. Scratch is scratch. No longer name needed (I wouldn't know what to use). Regarding xref, someday we'll use longer names. E.g. ones including the search input. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 18:59:20 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 22:59:20 +0000 Received: from localhost ([127.0.0.1]:38386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTCie-0005hW-07 for submit@debbugs.gnu.org; Mon, 27 Apr 2020 18:59:20 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTCib-0005hF-HX for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 18:59:18 -0400 Received: by mail-wm1-f66.google.com with SMTP id v4so921304wme.1 for <40863@debbugs.gnu.org>; Mon, 27 Apr 2020 15:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N/mAw6NVf533SBypI4jbF4mpQn9jqlj5FbcRa06wFpw=; b=OYcWn7wGN4vMgz0NQMa2MKHMUQ3cP+G2YTX4t1Sr2R0aDQjzPB3P7IjehIXnTf8SYO Xx/hsFDbe59XetMM4mc3DhbqfHzFxqdMc3Ne72g2VIv1+J0Ly7L+7K+U0YUfCAGSQila y07K10enzn5O4dTFPoXfAZmRahp9wrniTyv/d9GqfZe8dDIRHL/XRft34izI3bIFKhWx qwe4ER2o9dab875M9o3W+E28PwnEKZbv6I+LHWsdx4Q62LsgLs1OaZ0YCfyWms16Ds1C XYOEZr63obAwotZF8/X9QR2L5MXWCmNh6S3GMkYOGvAC6q4Wzq2GYW+7UVSpiGe5S1f0 2AkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N/mAw6NVf533SBypI4jbF4mpQn9jqlj5FbcRa06wFpw=; b=gvpH+e/IT1OJ3+7n8wOmODooPP7USDVsB/8bdNvXqBlUeGlBKlvUA2/Td4hWL4sxEb i41Fd1SkYNnLcQVhYVU36UCXvQ9CJYyPszyhEKIxxalDC74EYVRJs+lF2h57iwhpDc1o 4dNPL3vaUmcOG0EdtQrhxZYcxaxktj9OsrONMNxuAMdIHT/EtHEHsLkJFWhv2kZIKxCC +PX4bJJjdnCXjLZsXe7fKgpYrJOrZHC168XjGxybW0QaexuSW9jyphGZD7gNxbwl4wJH wMLVzQk+f29+NlN5ngHAKsfgohgj6qIi9E8nrN4BlzMMftGLCsL1Sn08L+Sh5Cix6P7O cuKg== X-Gm-Message-State: AGi0PubbEr+X3HiJV/DY69dcJ6aIXJh4Sy6MGTnoQkjqCeaExiRH1vkV lARgKMER9aqQ40rw+defteXyv0HnQug= X-Google-Smtp-Source: APiQypIE2gj0kqEALkbiYh0MNfbMdrDYloBEw1mPgWOq9X2Af7W7pOYnDgi+f8ltrPaz7Zh8GTiweA== X-Received: by 2002:a1c:80c3:: with SMTP id b186mr1186944wmd.117.1588028321483; Mon, 27 Apr 2020 15:58:41 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id s9sm24325085wrg.27.2020.04.27.15.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 15:58:40 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: Date: Mon, 27 Apr 2020 23:58:31 +0100 In-Reply-To: (Stefan Kangas's message of "Sun, 26 Apr 2020 10:56:03 +0200") Message-ID: <874kt4y1rc.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I have made some improvements to the display-time-world UI. I divided > them up into four patches to ease review and merging of the individual > features. Please let me know what you think. Thanks for working on this, see my comments below. > (Of course I can squash the patches before pushing if that is preferable.) > > Patch 4 adds an alias 'world-clock'. Ideally, I would like to rename > the somewhat obscurely named 'display-world-time' to 'world-clock' and > make the old names into obsolete aliases. It would be good to hear > any opinions on that too. No strong feelings either way here. > I'm also not sure if any of this should go into NEWS, so I didn't do > that work for now. Let me know if that's desirable. A new entry-point command alias intended as a replacement for the current command should definitely be announced. Not sure about the rest. > Best regards, > Stefan Kangas > > From 3d8c091a03c25826755b3735eca9da4b342826ba Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 Apr 2020 09:38:03 +0200 > Subject: [PATCH 1/4] Kill display-time-world buffer on exit > > * lisp/time.el (display-time-world-mode-map): New defvar. > (display-time-world-exit): New defun to kill buffer on exit. > (display-time-world): Doc fix. > --- > lisp/time.el | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/lisp/time.el b/lisp/time.el > index 44fd1a7e33..a5e5b9b4a7 100644 > --- a/lisp/time.el > +++ b/lisp/time.el > @@ -509,6 +509,13 @@ display-time-mode > 'display-time-event-handler))) > > > +(defvar display-time-world-mode-map > + (let ((map (make-sparse-keymap))) > + (define-key map "g" nil) Rather than remove the revert-buffer binding inherited from special-mode-map, wouldn't it be better to implement a revert-buffer-function that updates the world clocks displayed? > + (define-key map "q" 'display-time-world-exit) [...] > +(defun display-time-world-exit () > + "Quit the world time buffer." > + (interactive) > + (quit-window t)) I don't think this is a change for the better. The existing binding of quit-window, inherited by and consistent across many special-mode derivatives, already takes a prefix argument for killing the corresponding buffer if a user prefers that to burying. The proposed change would make killing the only option by default. > ;;;###autoload > (defun display-time-world () > "Enable updating display of times in various time zones. > +\\ > `display-time-world-list' specifies the zones. > -To turn off the world time display, go to that window and type `q'." > +To turn off the world time display, go to that window and type `\\[display-time-world-exit]'." If you agree with me then this can be changed to \\[quit-window]. [...] > @@ -540,7 +544,10 @@ display-time-world-display > (setq max-width width)))) > (setq fmt (concat "%-" (int-to-string max-width) "s %s\n")) > (dolist (timedata (nreverse result)) > - (insert (format fmt (car timedata) (cdr timedata)))) > + (insert (format fmt > + (propertize (car timedata) > + 'face 'display-time-world-label) > + (cdr timedata)))) Just curious: when do we use 'face' and when 'font-lock-face'? > (delete-char -1)) > (goto-char (point-min))) > > -- > 2.26.2 > > > From 0f2ca954e03b857554071ae48a98d44ba7030d69 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 Apr 2020 10:44:00 +0200 > Subject: [PATCH 3/4] Move point to new buffer for display-time-world > > * lisp/time.el (display-time-world): Move point to created buffer. > --- > lisp/time.el | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lisp/time.el b/lisp/time.el > index 44885f74d1..84c0071b7d 100644 > --- a/lisp/time.el > +++ b/lisp/time.el > @@ -566,11 +566,11 @@ display-time-world > (when (and display-time-world-timer-enable > (not (get-buffer display-time-world-buffer-name))) > (run-at-time t display-time-world-timer-second 'display-time-world-timer)) > - (with-current-buffer (get-buffer-create display-time-world-buffer-name) > - (display-time-world-display (time--display-world-list)) > - (display-buffer display-time-world-buffer-name > - (cons nil '((window-height . fit-window-to-buffer)))) > - (display-time-world-mode))) > + (switch-to-buffer-other-window (get-buffer-create display-time-world-buffer-name)) > + (display-time-world-display (time--display-world-list)) > + (display-buffer display-time-world-buffer-name > + (cons nil '((window-height . fit-window-to-buffer)))) switch-to-buffer and friends have historically not played nicely with display-buffer-alist and switch-to-buffer-preserve-window-point when used in Elisp libraries, with adverse user-visible effects. Unless there's a specific reason to use switch-to-buffer, pop-to-buffer and friends should generally be preferred instead. Note that using pop-to-buffer or similar here could remove the need for calling both get-buffer-create and display-buffer, while remaining fully customisable by the user. > + (display-time-world-mode)) > > (defun display-time-world-timer () > (if (get-buffer display-time-world-buffer-name) > -- > 2.26.2 > > > From 47401a1e10213d89cbdb6eaa2b66b44c2be37dfe Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 Apr 2020 10:47:17 +0200 > Subject: [PATCH 4/4] Improve the display-time-world UI > > * lisp/time.el (display-time-world-buffer-name): Change default > buffer name. > (display-time-world): Add usage instructions to modeline. Are there many other modes that do this? Is it really that helpful to have a standard special-mode binding displayed prominently in the mode line by default, with no easy way to remove it? FWIW, on entry some modes display useful key bindings in the echo area, which I find far less intrusive than a more permanent addition to the mode line. [...] > @@ -570,7 +570,11 @@ display-time-world > (display-time-world-display (time--display-world-list)) > (display-buffer display-time-world-buffer-name > (cons nil '((window-height . fit-window-to-buffer)))) > - (display-time-world-mode)) > + (display-time-world-mode) > + (setq mode-line-format (format "%15s %13s" "World Clock" "q to quit"))) Doesn't this override the entire mode line, erasing all other default constructs? What's wrong with the status quo, which displays the mode name, "World clock", like every other mode does? > +;; This would be a more intuitive name. > +(defalias 'world-clock 'display-time-world) > > (defun display-time-world-timer () > (if (get-buffer display-time-world-buffer-name) > -- > 2.26.2 Otherwise LGTM. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 27 19:04:23 2020 Received: (at 40863) by debbugs.gnu.org; 27 Apr 2020 23:04:23 +0000 Received: from localhost ([127.0.0.1]:38394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTCnX-0005qv-5f for submit@debbugs.gnu.org; Mon, 27 Apr 2020 19:04:23 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:33389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTCnV-0005qj-S6 for 40863@debbugs.gnu.org; Mon, 27 Apr 2020 19:04:22 -0400 Received: by mail-qk1-f169.google.com with SMTP id 23so15115131qkf.0 for <40863@debbugs.gnu.org>; Mon, 27 Apr 2020 16:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5p4R3pMQd+juh8etMEx1xW9drgvKFIZyfEJeshqP7bo=; b=B4ZLKROapec5SMMbnWb8XPeoH7Ihor8dyUHm9ZZQyBsl21mGedrw+rYt6nAtmnkz7V A0MtppuLvmqBMztHh2nuB2/0WwjpH1jxszvODs8i9GvodNj3T9ZYOyEhjXimpPD5Qynj P6/LemMG4CYXGdEBgFMOyfQ9A6i3+ckRVV/Ix2javJotmhTr7Od8vevg3oLOriPlaSKJ HFPv/J1jp2QQWL/vbZVhsvUlGEtx8GiLiuLR8q/HnxqlfZqUR7ZA/0g9u9bL5RiKLdwf 9yyGAfHOw1OHtXAZtWT0+ENsVhKCo3t9kOv9SuudWnd3SCOls9x45UsydQp81Dyl6xPu r0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5p4R3pMQd+juh8etMEx1xW9drgvKFIZyfEJeshqP7bo=; b=HJ38f9/Jc4JQW9D9VCbuOjeYf548iJR5ZYpZLCIIngNvOPc3aSj4yk+sMMEA99JSXq 0zWD2n8z1FeuTYXRgvRQqfE63MPG4x+5Uk5PQqaI7PF0DEJysxusc+M2Yd7aJ7nTxw3j 4d9N07V30PVyYW0VfJX8edLDxBlQjlzLXKxVOoLYvR4idsD7xb/H09eEfiKZFD9JiN3O yKys9Lkd/42ndyLiYhy3xEPmmOFyZMTQDVSIQcpIo5HH88eGIA6qGpMe3/oiVjhscb9I 4u+kfWvzCMUOMYXKaInTHS5/QK5TeJSJ2l53LMqc/nmtWUlNcxnJDtwFuCXHiyX75RV8 W/yA== X-Gm-Message-State: AGi0PuZ5tV3WBOw1kp2cIH/LZHP3lpAirvSKPiGTOObharTAh4cSGRn4 Vfajtisu80+PY48ZpKzIG66D41eb X-Google-Smtp-Source: APiQypIRbQyRJA7roh2UZFKWq6RHzUl6yUwhM2mw6nevEOYdUJGgp3Paooz3jjlQHf5LUsDiX0BSvA== X-Received: by 2002:ae9:e217:: with SMTP id c23mr24385292qkc.398.1588028656407; Mon, 27 Apr 2020 16:04:16 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id u190sm12139704qkb.102.2020.04.27.16.04.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Apr 2020 16:04:15 -0700 (PDT) From: Noam Postavsky To: Dmitry Gutov Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <834kt44t7l.fsf@gnu.org> Date: Mon, 27 Apr 2020 19:04:10 -0400 In-Reply-To: (Dmitry Gutov's message of "Tue, 28 Apr 2020 01:00:32 +0300") Message-ID: <874kt4o7it.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: Eli Zaretskii , stefan@marxist.se, 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 27.04.2020 22:35, Eli Zaretskii wrote: >> I guess it's a matter of personal preferences, then. E.g., we have >> *scratch* and*xref*. > > Scratch is scratch. No longer name needed (I wouldn't know what to use). I guess "*Scratch*" vs "*scratch*", but I don't think that's a significant enough difference to even look at. > Regarding xref, someday we'll use longer names. E.g. ones including > the search input. Since the term "xref" is used all over in package name, command names, documentation, etc; users already need to be familiar with the short form. That's not the case for "wclock". Anyway, none of this is especially important. Leaving the name as it is won't do any harm. From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 11:03:20 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 15:03:20 +0000 Received: from localhost ([127.0.0.1]:50422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXCC-00021w-BM for submit@debbugs.gnu.org; Fri, 01 May 2020 11:03:20 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:58376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXCB-00021k-9S for 40863@debbugs.gnu.org; Fri, 01 May 2020 11:03:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tv8yXI560uwVmIxZ3U90bpptxyUInJfei+o9+EIE7xM=; b=q2Ihmd63RhdGxRv7/lDbAoeDxZ SdbAmGY2lzHxDNSViFBudldsXmt0WibYmQV5I5ke7NLAgQb/hTS1xAYNfafC7JvgWyjwj8COgfhWV a0sbFgvKHEzw8udm0XBQ9iTkbmKFvLh6xH5w5sr9LO2OZQnxIrfiQebcjIO5dqHshci0MmnpyTgIW NAWoZe7GKWKzHv0Dx98AO23elKagtoiQx9Ao4EQd7Ipzyd1o08j5shjmGqYU11tjszUZuKwLPzlkV Chjv5ck7JWkHdP5g1lauQ8cbta8Y3SnDKt9MUzlpKnDo++rICH5PQfrAL3cPAVfzXF6orde/h5aAa iD6BFKJA==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:41892 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUXC4-000fHv-Ji; Fri, 01 May 2020 11:03:12 -0400 From: Stefan Kangas To: Noam Postavsky Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <85tv1492ju.fsf@gmail.com> (Noam Postavsky's message of "Mon, 27 Apr 2020 15:00:37 -0400") References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Date: Fri, 01 May 2020 17:03:10 +0200 Message-ID: <871ro3g0k1.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: Eli Zaretskii , 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: >>> If an application expects a particular name, then it's already broken >>> because the user can change the defcustom at any time, right? And if a >>> user expects the old name, they can customize it back to the old value. >> >> So you are saying that we should change these names from time to time >> just to make a point? > > No, I think changing the name here makes it more readable (i.e., it's > not a random change, it's an improvement). And I think this benefit > outweighs the possible existence of broken applications, or users > possibly preferring the current value I think Noam presents a compelling argument here. It might be somewhat minor, and it might to some degree be a matter of preference. But even minor improvements can add up and contribute to the overall user experience. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 11:14:09 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 15:14:09 +0000 Received: from localhost ([127.0.0.1]:50426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXMf-0002Gz-BD for submit@debbugs.gnu.org; Fri, 01 May 2020 11:14:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXMe-0002Gm-2C for 40863@debbugs.gnu.org; Fri, 01 May 2020 11:14:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56907) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUXMY-00027U-Rx; Fri, 01 May 2020 11:14:02 -0400 Received: from [176.228.60.248] (port=3687 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUXMY-0003hM-5U; Fri, 01 May 2020 11:14:02 -0400 Date: Fri, 01 May 2020 18:13:50 +0300 Message-Id: <83wo5vvgb5.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: <871ro3g0k1.fsf@stefankangas.se> (message from Stefan Kangas on Fri, 01 May 2020 17:03:10 +0200) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <871ro3g0k1.fsf@stefankangas.se> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: Eli Zaretskii , 40863@debbugs.gnu.org > Date: Fri, 01 May 2020 17:03:10 +0200 > > > No, I think changing the name here makes it more readable (i.e., it's > > not a random change, it's an improvement). And I think this benefit > > outweighs the possible existence of broken applications, or users > > possibly preferring the current value > > I think Noam presents a compelling argument here. Noam said several things about this, not just what you cite above. From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 12:26:37 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 16:26:37 +0000 Received: from localhost ([127.0.0.1]:50510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUYUn-00069N-At for submit@debbugs.gnu.org; Fri, 01 May 2020 12:26:37 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:47970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUYUm-000698-LB for 40863@debbugs.gnu.org; Fri, 01 May 2020 12:26:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QB/CLrq4kGCHMBXZcFBID0VZA0O62A8QCD1Wz9JRc0c=; b=WUp0zKCJjaD6x011fRAfiSnP1u iPbHLYhQhcoz71bFcp2Z+GzKlrKU8bGRsYr9jnfah6oTB1puf4A13WqPyzBSAbGsooCSLocPvjvI4 jRmbvQCRroXRHGQNlAwe+b407u18XW9J6lb+fZI+mG7q0Y5ZwnZCPThyTdoHvtqHLXxhDSQrRdaiK OojfwC0AAYwl+NzcZIry86P6krOAEW+xVAb3uoHM/ajxLjg4Pvx8IxEM2VSM8Uypt5/8PNIZdBq0V 4ZOiwP+L8APTSL+h2VCCTBv9uYJYxwqVSBgxmXeadeAe+FEWyqHYibgnapwh5QuSw/OeUDT9MgH3i Tf+ZVhBg==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:54384 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUYUf-0011dd-RU; Fri, 01 May 2020 12:26:30 -0400 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <83wo5vvgb5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 01 May 2020 18:13:50 +0300") References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <871ro3g0k1.fsf@stefankangas.se> <83wo5vvgb5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Date: Fri, 01 May 2020 18:26:28 +0200 Message-ID: <87wo5vei4r.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> > No, I think changing the name here makes it more readable (i.e., it's >> > not a random change, it's an improvement). And I think this benefit >> > outweighs the possible existence of broken applications, or users >> > possibly preferring the current value >> >> I think Noam presents a compelling argument here. > > Noam said several things about this, not just what you cite above. Well, I quoted the part I agree with, and tried not to quote unfairly. Maybe I failed to include something important, but I'm not sure what that is. I take it that you aren't convinced? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 13:57:32 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 17:57:32 +0000 Received: from localhost ([127.0.0.1]:50605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZul-0008Tn-Us for submit@debbugs.gnu.org; Fri, 01 May 2020 13:57:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZuk-0008Ta-HA for 40863@debbugs.gnu.org; Fri, 01 May 2020 13:57:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60926) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUZue-0006fN-Ts; Fri, 01 May 2020 13:57:24 -0400 Received: from [176.228.60.248] (port=1689 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUZud-0003b2-Lw; Fri, 01 May 2020 13:57:24 -0400 Date: Fri, 01 May 2020 20:57:11 +0300 Message-Id: <83o8r7v8qw.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: <87wo5vei4r.fsf@stefankangas.se> (message from Stefan Kangas on Fri, 01 May 2020 18:26:28 +0200) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <871ro3g0k1.fsf@stefankangas.se> <83wo5vvgb5.fsf@gnu.org> <87wo5vei4r.fsf@stefankangas.se> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: 40863@debbugs.gnu.org, npostavs@gmail.com > Date: Fri, 01 May 2020 18:26:28 +0200 > > >> I think Noam presents a compelling argument here. > > > > Noam said several things about this, not just what you cite above. > > Well, I quoted the part I agree with, and tried not to quote unfairly. > Maybe I failed to include something important, but I'm not sure what > that is. > > I take it that you aren't convinced? My bias is towards not breaking backward compatibility unless necessary. Noam in effect said that he tends towards your proposal, but the issue is not important enough. Where does that leave us? From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 14:07:49 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 18:07:49 +0000 Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUa4i-0000LD-SY for submit@debbugs.gnu.org; Fri, 01 May 2020 14:07:49 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:52650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUa4g-0000Kz-Qi for 40863@debbugs.gnu.org; Fri, 01 May 2020 14:07:47 -0400 Received: by mail-wm1-f53.google.com with SMTP id 188so509311wmc.2 for <40863@debbugs.gnu.org>; Fri, 01 May 2020 11:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R/YtVN3Mjxim2E/GlpP0s0gQpSRNYfSWdfIrgl3NBYQ=; b=GlJ5jpigac1zIt8ceXMd7a5jfQwMVx8o3wJuDFkvZQHL9eK2BNHfNCzNAWQ4iC31fC IJFOzT9ehHDk0sZn1iMClRZS6qdDbwiyM2ozKsxndfu4PHbvO2coSOJXeIOVVk8o4U1G G3Ayzv2Tr2gpCiWcvAOBx2s4emPr5/FStLG7WkNfxVY2IEb/thDM0QGNGSyW/X2CbF2M owPj/sbhVu7oC9G7j+U+2ymoeGPx0b9BpgO3Kx0K2HGh6FQtruByE+pkVsRjpvgubM5S KQBjrZVv0m0FxQ7Jh4lhVVw2Q4uyucgSVNCBNUHhbuj40EDeqHqDyctW3pOsH6MMpAd2 hmEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R/YtVN3Mjxim2E/GlpP0s0gQpSRNYfSWdfIrgl3NBYQ=; b=WjcTs9HE3IpnZ4T+0poZP6one51sl5DN5P+oHYI/IAHmbydSri7E+8J3Y1CeMJD3sQ 5oDiwaxjVqWH+iurhQmRFaqqdzna9eZK+QDEb9frmJyZy5RKzLwmXPdvD2LK34EdAirg 5quKEXKzcSoRFhOdyCOOyGtMqmZDm9O9LqSaBYTqOHMP45BK+LvXU3HhhVSQFhTNqqCq EcZi4I2D8oyqbbkfKME58gq6NYthG9b7Dx08Go4M0hmooKDwGhcFVrXr0ewqh7k660J5 3HmVi/wEgzVvgR+lt4ikUnCw27lEIvdY9XGEY+ejiq8nOg29NxOtrLMdZQ/rIGt4sY5V ZYDQ== X-Gm-Message-State: AGi0PuZXGV3p/iu/iLiWa0KJDRm1wpjK9VdPh3rkXq/EM92xcI70AnS5 jPgqU3WNKKAuNuD1sHWw/t0= X-Google-Smtp-Source: APiQypIXEyYmIWv9OFgmW5p9903aa/oBRPpUpOfAGyE9rHnwTsw/TYH/6RFA5n40N5LPsEsQN9bwXw== X-Received: by 2002:a05:600c:441a:: with SMTP id u26mr737136wmn.154.1588356460910; Fri, 01 May 2020 11:07:40 -0700 (PDT) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id v7sm514356wmg.3.2020.05.01.11.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2020 11:07:40 -0700 (PDT) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: Eli Zaretskii , Stefan Kangas References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <871ro3g0k1.fsf@stefankangas.se> <83wo5vvgb5.fsf@gnu.org> <87wo5vei4r.fsf@stefankangas.se> <83o8r7v8qw.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 1 May 2020 21:07:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <83o8r7v8qw.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 01.05.2020 20:57, Eli Zaretskii wrote: > My bias is towards not breaking backward compatibility unless > necessary. Noam in effect said that he tends towards your proposal, > but the issue is not important enough. Where does that leave us? Do we vote? I like "World Clock". From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 14:18:45 2020 Received: (at 40863) by debbugs.gnu.org; 1 May 2020 18:18:45 +0000 Received: from localhost ([127.0.0.1]:50632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUaFG-0000dY-7l for submit@debbugs.gnu.org; Fri, 01 May 2020 14:18:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUaFF-0000dM-8O for 40863@debbugs.gnu.org; Fri, 01 May 2020 14:18:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33235) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUaF9-00050F-Lg; Fri, 01 May 2020 14:18:35 -0400 Received: from [176.228.60.248] (port=2977 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUaF9-0005KM-1u; Fri, 01 May 2020 14:18:35 -0400 Date: Fri, 01 May 2020 21:18:23 +0300 Message-Id: <83lfmbv7rk.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Fri, 1 May 2020 21:07:38 +0300) Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <831roa731a.fsf@gnu.org> <85y2qg976f.fsf@gmail.com> <83ees84w6g.fsf@gnu.org> <85tv1492ju.fsf@gmail.com> <871ro3g0k1.fsf@stefankangas.se> <83wo5vvgb5.fsf@gnu.org> <87wo5vei4r.fsf@stefankangas.se> <83o8r7v8qw.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org, stefan@marxist.se, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 40863@debbugs.gnu.org, npostavs@gmail.com > From: Dmitry Gutov > Date: Fri, 1 May 2020 21:07:38 +0300 > > On 01.05.2020 20:57, Eli Zaretskii wrote: > > My bias is towards not breaking backward compatibility unless > > necessary. Noam in effect said that he tends towards your proposal, > > but the issue is not important enough. Where does that leave us? > > Do we vote? Do we have to? From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 07:51:10 2020 Received: (at 40863) by debbugs.gnu.org; 2 May 2020 11:51:10 +0000 Received: from localhost ([127.0.0.1]:51460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUqfk-0000Dj-B5 for submit@debbugs.gnu.org; Sat, 02 May 2020 07:51:10 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:47974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUqff-0000D5-0D for 40863@debbugs.gnu.org; Sat, 02 May 2020 07:51:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xrDjT88v4AntxvRfvskNgpuC2BxuN1ipCH7rLqLt3qQ=; b=mpVVH9bHsfwLH6Xjrk1nyCxrO0 YWwhHkGtGvmW8gouY9Qv1oKHZhPmzfT8+i8zkjw6TqiWWu7luSRf1QeZksk+zNALqg/8OpIqqSJVE 14duvi3XVH2fVDRl85+3mp8xIyo+49glbpHoRQx7J5+7sGA4HzZO2S/aQ4Wzznmcru9HkOM9MzgYE ganlH4o3IBADt/FGcwZdjU7WqhD/l9Nwdoj490TxQioPxx2KT0SuJAdMX2fTWk6JE8r4qA1LjJgYd 6UIvN9pnoSWBKkGf4g47yIrtQygTaE6Hf7ksds3U0uMu7+XtZkHk4GigN4Vfme7yXBQMUCkvy1B4u dR8Sp/cA==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:42406 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUqfX-000j4s-Ax; Sat, 02 May 2020 07:50:55 -0400 From: Stefan Kangas To: "Basil L. Contovounesios" Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <874kt4y1rc.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 27 Apr 2020 23:58:31 +0100") References: <874kt4y1rc.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 02 May 2020 13:50:53 +0200 Message-ID: <87sggi4kte.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Thanks for working on this, see my comments below. Thank you for taking the time to make a thorough review. I agree with your suggestions and will send an updated set of patches. > Just curious: when do we use 'face' and when 'font-lock-face'? I think this is explained in (info "(elisp) Special Properties"). Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 12:10:32 2020 Received: (at 40863) by debbugs.gnu.org; 2 May 2020 16:10:33 +0000 Received: from localhost ([127.0.0.1]:53749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUuil-0005Am-GJ for submit@debbugs.gnu.org; Sat, 02 May 2020 12:10:32 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:55964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUuih-0005AT-Pg for 40863@debbugs.gnu.org; Sat, 02 May 2020 12:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ARMNaNfgDMmGrDx4mB1GstGlOxQrZKrAKHsbgCVR9Ek=; b=O5ayACCWaFSaISXLKaVZuxSEaf XtOGviIlLsTVT3LNDeaVGuU54vbNKhfpOH7d2y+KoNUQTK29/M29Yku2xzICLWlKNrU5PlEriI807 g1I5aHuzNEr+Qw+5cvKv0eRfFpe99FXJuZ+cC3xG8MF863g3jzYKbvzmzrkVrhuDF+mHPGpBWpWLU RU41j8Y/IKfdOtLI+Oot+GndhmY70eXtyVMWAKtkmj5UrsXuwRkp9KcjvMmTg04h1OFhOTY1V7UGx DoUOGmpUL4L9rJqtAdrNgx45invmIqJc6KIeS2Wu80GBNB6CzNpQ6jzmf2lXF3XsaNixvtFYXdN1+ vmBmd4/Q==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:46018 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUuia-001WlS-Oh; Sat, 02 May 2020 12:10:21 -0400 From: Stefan Kangas To: "Basil L. Contovounesios" Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <874kt4y1rc.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 27 Apr 2020 23:58:31 +0100") References: <874kt4y1rc.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 02 May 2020 18:10:19 +0200 Message-ID: <87k11u48t0.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Stefan Kangas writes: > >> I have made some improvements to the display-time-world UI. I divided >> them up into four patches to ease review and merging of the individual >> features. Please let me know what you think. > > Thanks for working on this, see my comments below. > >> (Of course I can squash the patches before pushing if that is preferable.) >> >> Patch 4 adds an alias 'world-clock'. Ideally, I would like to rename >> the somewhat obscurely named 'display-world-time' to 'world-clock' and >> make the old names into obsolete aliases. It would be good to hear >> any opinions on that too. > > No strong feelings either way here. So here's a revised set of patches: 1. Fix all Basil's comments, and remove the buffer rename that Eli didn't approve of. 2. Rename 'display-time-world' to 'world-clock', and add an alias for the old name. Then comes the more ambitious part: 3. Rename 'display-time-world-*' functions and variables into 'world-clock-*' equivalents and make the old names into obsolete aliases. Move the world-clock options from the defgroup display-time (sorting under the mode-line and mail), into a new defgroup world-clock (sorting under applications). 4. Rearrange the defcustoms time.el to clearly separate world-clock from display-time-mode. Cleanup of :group args. I have seen no to the proposals in patches 1-2 so far, and I hope that we can agree to make the changes also in patches 3-4. I think the result is much more logical from pretty much any point of view. Comments are obviously very welcome. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Improve-display-time-world-UI-Bug-40863.patch >From e4e5012abdece7ce334900fd45f7e5ba06185ecc Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sun, 26 Apr 2020 10:16:06 +0200 Subject: [PATCH 1/4] Improve display-time-world UI (Bug#40863) * lisp/time.el (display-time-world-label): New face. (display-time-world-display): Use the new face. Move point to new buffer on creation. (display-time-world-mode-map): New variable. Bind 'g' to update the display-time-world buffer. (display-time-world-timer): Add interactive spec. --- lisp/time.el | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/lisp/time.el b/lisp/time.el index 44fd1a7e33..7e26c131c9 100644 --- a/lisp/time.el +++ b/lisp/time.el @@ -509,6 +509,16 @@ display-time-mode 'display-time-event-handler))) +(defface display-time-world-label + '((t :inherit font-lock-variable-name-face)) + "Face for time zone label.") + +(defvar display-time-world-mode-map + (let ((map (make-sparse-keymap))) + (define-key map "g" #'display-time-world-timer) + map) + "Keymap for `display-time-world-mode'.") + (define-derived-mode display-time-world-mode special-mode "World clock" "Major mode for buffer that displays times in various time zones. See `display-time-world'." @@ -533,7 +543,10 @@ display-time-world-display (setq max-width width)))) (setq fmt (concat "%-" (int-to-string max-width) "s %s\n")) (dolist (timedata (nreverse result)) - (insert (format fmt (car timedata) (cdr timedata)))) + (insert (format fmt + (propertize (car timedata) + 'face 'display-time-world-label) + (cdr timedata)))) (delete-char -1)) (goto-char (point-min))) @@ -541,18 +554,17 @@ display-time-world-display (defun display-time-world () "Enable updating display of times in various time zones. `display-time-world-list' specifies the zones. -To turn off the world time display, go to that window and type `q'." +To turn off the world time display, go to that window and type `\\[quit-window]'." (interactive) (when (and display-time-world-timer-enable (not (get-buffer display-time-world-buffer-name))) (run-at-time t display-time-world-timer-second 'display-time-world-timer)) - (with-current-buffer (get-buffer-create display-time-world-buffer-name) - (display-time-world-display (time--display-world-list)) - (display-buffer display-time-world-buffer-name - (cons nil '((window-height . fit-window-to-buffer)))) - (display-time-world-mode))) + (pop-to-buffer display-time-world-buffer-name) + (display-time-world-display (time--display-world-list)) + (display-time-world-mode)) (defun display-time-world-timer () + (interactive) (if (get-buffer display-time-world-buffer-name) (with-current-buffer (get-buffer display-time-world-buffer-name) (display-time-world-display (time--display-world-list))) -- 2.26.2 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-Make-display-time-world-into-an-alias-for-world-cloc.patch >From cd4c79a5758f0b6b8f5cc8acde62f806a1452b64 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 2 May 2020 16:08:33 +0200 Subject: [PATCH 2/4] Make 'display-time-world' into an alias for 'world-clock' (Bug#40863) * lisp/time.el (world-clock): Rename from 'display-time-world'. (display-time-world): Redefine as alias for 'world-clock'. * etc/NEWS: Announce the above change. (top-level, zoneinfo-style-world-list, legacy-style-world-list) (display-time-world-list, display-time-world-time-format) (display-time-world-buffer-name) (display-time-world-timer-enable) (display-time-world-timer-second, display-time-world-label) (display-time-world-timer): Update documentation to match the above rename. --- etc/NEWS | 7 +++++++ lisp/time.el | 26 ++++++++++++++------------ 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 025d5c14a7..d2b745c579 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -288,6 +288,13 @@ prefix on the Subject line in various languages. These new navigation commands are bound to 'n' and 'p' in 'apropos-mode'. +** Time + +--- +*** 'display-time-world' is now an alias for 'world-clock'. +'world-clock' creates a buffer with an updating time display using +several time zones. The new name is hoped to be more discoverable. + * New Modes and Packages in Emacs 28.1 diff --git a/lisp/time.el b/lisp/time.el index 7e26c131c9..fe290ff71f 100644 --- a/lisp/time.el +++ b/lisp/time.el @@ -25,8 +25,7 @@ ;; Facilities to display current time/date and a new-mail indicator ;; in the Emacs mode line. The entry point is `display-time'. -;; Display time world in a buffer, the entry point is -;; `display-time-world'. +;; Use `world-clock' to display world clock in a buffer. ;;; Code: @@ -130,7 +129,7 @@ zoneinfo-style-world-list ("Europe/Paris" "Paris") ("Asia/Calcutta" "Bangalore") ("Asia/Tokyo" "Tokyo")) - "Alist of zoneinfo-style time zones and places for `display-time-world'. + "Alist of zoneinfo-style time zones and places for `world-clock'. Each element has the form (TIMEZONE LABEL). TIMEZONE should be a string of the form AREA/LOCATION, where AREA is the name of a region -- a continent or ocean, and LOCATION is the name @@ -147,7 +146,7 @@ legacy-style-world-list ("CET-1CDT" "Paris") ("IST-5:30" "Bangalore") ("JST-9" "Tokyo")) - "Alist of traditional-style time zones and places for `display-time-world'. + "Alist of traditional-style time zones and places for `world-clock'. Each element has the form (TIMEZONE LABEL). TIMEZONE should be a string of the form: @@ -161,7 +160,7 @@ legacy-style-world-list :version "23.1") (defcustom display-time-world-list t - "Alist of time zones and places for `display-time-world' to display. + "Alist of time zones and places for `world-clock' to display. Each element has the form (TIMEZONE LABEL). TIMEZONE should be in a format supported by your system. See the documentation of `zoneinfo-style-world-list' and @@ -190,25 +189,25 @@ time--display-world-list zoneinfo-style-world-list)))) (defcustom display-time-world-time-format "%A %d %B %R %Z" - "Format of the time displayed, see `format-time-string'." + "Time format for `world-clock', see `format-time-string'." :group 'display-time :type 'string :version "23.1") (defcustom display-time-world-buffer-name "*wclock*" - "Name of the world clock buffer." + "Name of the `world-clock' buffer." :group 'display-time :type 'string :version "23.1") (defcustom display-time-world-timer-enable t - "If non-nil, a timer will update the world clock." + "If non-nil, a timer will update the `world-clock' buffer." :group 'display-time :type 'boolean :version "23.1") (defcustom display-time-world-timer-second 60 - "Interval in seconds for updating the world clock." + "Interval in seconds for updating the `world-clock' buffer." :group 'display-time :type 'integer :version "23.1") @@ -511,7 +510,7 @@ display-time-mode (defface display-time-world-label '((t :inherit font-lock-variable-name-face)) - "Face for time zone label.") + "Face for time zone label in `world-clock' buffer.") (defvar display-time-world-mode-map (let ((map (make-sparse-keymap))) @@ -551,8 +550,8 @@ display-time-world-display (goto-char (point-min))) ;;;###autoload -(defun display-time-world () - "Enable updating display of times in various time zones. +(defun world-clock () + "Show world clock buffer with times in various time zones. `display-time-world-list' specifies the zones. To turn off the world time display, go to that window and type `\\[quit-window]'." (interactive) @@ -564,6 +563,7 @@ display-time-world (display-time-world-mode)) (defun display-time-world-timer () + "Update the `world-clock' buffer." (interactive) (if (get-buffer display-time-world-buffer-name) (with-current-buffer (get-buffer display-time-world-buffer-name) @@ -576,6 +576,8 @@ display-time-world-timer "display-time-world-timer") (cancel-timer elt))))))) +(defalias 'display-time-world #'world-clock) + ;;;###autoload (defun emacs-uptime (&optional format) "Return a string giving the uptime of this instance of Emacs. -- 2.26.2 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-Rename-display-time-world-to-world-clock-Bug-40863.patch >From 043650acccd2528c5459c3c854cbd886acae9642 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 2 May 2020 17:26:14 +0200 Subject: [PATCH 3/4] Rename 'display-time-world' to 'world-clock' (Bug#40863) * lisp/time.el (world-clock): New defgroup. (zoneinfo-style-world-list, legacy-style-world-list): Use :group 'world-clock'. (world-clock-list, world-clock-time-format) (world-clock-buffer-name, world-clock-timer-enable) (world-clock-timer-second): Rename from 'display-time-world-*'. Use :group 'world-clock'. (world-clock-label, world-clock-mode-map, world-clock-mode) (world-clock-display, world-clock): Rename from 'display-time-world-*'. Use the new names. (time--display-world-list): Use the above new names. (display-time-world-list, display-time-world-time-format) (display-time-world-buffer-name) (display-time-world-timer-enable) (display-time-world-timer-second): Redefine as obsolete variable aliases for the new 'world-clock-*' names. (display-time-world-mode, display-time-world-display) (display-time-world, display-time-world-timer): Redefine as obsolete function aliases for the new 'world-clock-*' names. * etc/NEWS: Announce the above changes. --- etc/NEWS | 21 +++++++++- lisp/time.el | 114 +++++++++++++++++++++++++++++++-------------------- 2 files changed, 89 insertions(+), 46 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index d2b745c579..d97b148cc8 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -291,9 +291,26 @@ These new navigation commands are bound to 'n' and 'p' in ** Time --- -*** 'display-time-world' is now an alias for 'world-clock'. +*** 'display-time-world' has been renamed to 'world-clock'. 'world-clock' creates a buffer with an updating time display using -several time zones. The new name is hoped to be more discoverable. +several time zones. + +The following functions have been renamed: + + 'display-time-world' to 'world-clock' + 'display-time-world-mode' to 'world-clock-mode' + 'display-time-world-display' to 'world-clock-display' + 'display-time-world-timer' to 'world-clock-update' + +The following options have been renamed: + + 'display-time-world-list' to 'world-clock-list' + 'display-time-world-time-format' to 'world-clock-time-format' + 'display-time-world-buffer-name' to 'world-clock-buffer-namt' + 'display-time-world-timer-enable' to 'world-clock-timer-enablt' + 'display-time-world-timer-second' to 'world-clock-timer-secont' + +The old names are now obsolete. * New Modes and Packages in Emacs 28.1 diff --git a/lisp/time.el b/lisp/time.el index fe290ff71f..3f1880b708 100644 --- a/lisp/time.el +++ b/lisp/time.el @@ -122,6 +122,10 @@ display-time-server-down-time "Time when mail file's file system was recorded to be down. If that file system seems to be up, the value is nil.") +(defgroup world-clock nil + "Show a world clock." + :group 'applications) + (defcustom zoneinfo-style-world-list '(("America/Los_Angeles" "Seattle") ("America/New_York" "New York") @@ -135,7 +139,7 @@ zoneinfo-style-world-list the name of a region -- a continent or ocean, and LOCATION is the name of a specific location, e.g., a city, within that region. LABEL is a string to display as the label of that TIMEZONE's time." - :group 'display-time + :group 'world-clock :type '(repeat (list string string)) :version "23.1") @@ -155,11 +159,11 @@ legacy-style-world-list See the documentation of the TZ environment variable on your system, for more details about the format of TIMEZONE. LABEL is a string to display as the label of that TIMEZONE's time." - :group 'display-time + :group 'world-clock :type '(repeat (list string string)) :version "23.1") -(defcustom display-time-world-list t +(defcustom world-clock-list t "Alist of time zones and places for `world-clock' to display. Each element has the form (TIMEZONE LABEL). TIMEZONE should be in a format supported by your system. See the @@ -170,16 +174,15 @@ display-time-world-list If the value is t instead of an alist, use the value of `zoneinfo-style-world-list' if it works on this platform, and of `legacy-style-world-list' otherwise." - - :group 'display-time + :group 'world-clock :type '(choice (const :tag "Default" t) (repeat :tag "List of zones and labels" (list (string :tag "Zone") (string :tag "Label")))) - :version "23.1") + :version "28.1") (defun time--display-world-list () - (if (listp display-time-world-list) - display-time-world-list + (if (listp world-clock-list) + world-clock-list ;; Determine if zoneinfo style timezones are supported by testing that ;; America/New York and Europe/London return different timezones. (let ((nyt (format-time-string "%z" nil "America/New_York")) @@ -188,29 +191,29 @@ time--display-world-list legacy-style-world-list zoneinfo-style-world-list)))) -(defcustom display-time-world-time-format "%A %d %B %R %Z" +(defcustom world-clock-time-format "%A %d %B %R %Z" "Time format for `world-clock', see `format-time-string'." - :group 'display-time + :group 'world-clock :type 'string - :version "23.1") + :version "28.1") -(defcustom display-time-world-buffer-name "*wclock*" +(defcustom world-clock-buffer-name "*wclock*" "Name of the `world-clock' buffer." - :group 'display-time + :group 'world-clock :type 'string - :version "23.1") + :version "28.1") -(defcustom display-time-world-timer-enable t +(defcustom world-clock-timer-enable t "If non-nil, a timer will update the `world-clock' buffer." - :group 'display-time + :group 'world-clock :type 'boolean - :version "23.1") + :version "28.1") -(defcustom display-time-world-timer-second 60 +(defcustom world-clock-timer-second 60 "Interval in seconds for updating the `world-clock' buffer." - :group 'display-time + :group 'world-clock :type 'integer - :version "23.1") + :version "28.1") ;;;###autoload (defun display-time () @@ -507,23 +510,48 @@ display-time-mode (remove-hook 'rmail-after-get-new-mail-hook 'display-time-event-handler))) - -(defface display-time-world-label + +;;; Obsolete names + +(define-obsolete-variable-alias 'display-time-world-list + 'world-clock-list "28.1") +(define-obsolete-variable-alias 'display-time-world-time-format + 'world-clock-time-format "28.1") +(define-obsolete-variable-alias 'display-time-world-buffer-name + 'world-clock-buffer-name "28.1") +(define-obsolete-variable-alias 'display-time-world-timer-enable + 'world-clock-timer-enable "28.1") +(define-obsolete-variable-alias 'display-time-world-timer-second + 'world-clock-timer-second "28.1") + +(define-obsolete-function-alias 'display-time-world-mode + #'world-clock-mode "28.1") +(define-obsolete-function-alias 'display-time-world-display + #'world-clock-display "28.1") +(define-obsolete-function-alias 'display-time-world + #'world-clock "28.1") +(define-obsolete-function-alias 'display-time-world-timer + #'world-clock-update "28.1") + + +;;; World clock + +(defface world-clock-label '((t :inherit font-lock-variable-name-face)) "Face for time zone label in `world-clock' buffer.") -(defvar display-time-world-mode-map +(defvar world-clock-mode-map (let ((map (make-sparse-keymap))) - (define-key map "g" #'display-time-world-timer) + (define-key map "g" #'world-clock-update) map) - "Keymap for `display-time-world-mode'.") + "Keymap for `world-clock-mode'.") -(define-derived-mode display-time-world-mode special-mode "World clock" +(define-derived-mode world-clock-mode special-mode "World clock" "Major mode for buffer that displays times in various time zones. See `display-time-world'." (setq show-trailing-whitespace nil)) -(defun display-time-world-display (alist) +(defun world-clock-display (alist) "Replace current buffer text with times in various zones, based on ALIST." (let ((inhibit-read-only t) (buffer-undo-list t) @@ -535,7 +563,7 @@ display-time-world-display (let* ((label (cadr zone)) (width (string-width label))) (push (cons label - (format-time-string display-time-world-time-format + (format-time-string world-clock-time-format now (car zone))) result) (when (> width max-width) @@ -544,7 +572,7 @@ display-time-world-display (dolist (timedata (nreverse result)) (insert (format fmt (propertize (car timedata) - 'face 'display-time-world-label) + 'face 'world-clock-label) (cdr timedata)))) (delete-char -1)) (goto-char (point-min))) @@ -552,32 +580,30 @@ display-time-world-display ;;;###autoload (defun world-clock () "Show world clock buffer with times in various time zones. -`display-time-world-list' specifies the zones. +`world-clock-list' specifies the zones. To turn off the world time display, go to that window and type `\\[quit-window]'." (interactive) - (when (and display-time-world-timer-enable - (not (get-buffer display-time-world-buffer-name))) - (run-at-time t display-time-world-timer-second 'display-time-world-timer)) - (pop-to-buffer display-time-world-buffer-name) - (display-time-world-display (time--display-world-list)) - (display-time-world-mode)) - -(defun display-time-world-timer () + (when (and world-clock-timer-enable + (not (get-buffer world-clock-buffer-name))) + (run-at-time t world-clock-timer-second 'world-clock-update)) + (pop-to-buffer world-clock-buffer-name) + (world-clock-display (time--display-world-list)) + (world-clock-mode)) + +(defun world-clock-update () "Update the `world-clock' buffer." (interactive) - (if (get-buffer display-time-world-buffer-name) - (with-current-buffer (get-buffer display-time-world-buffer-name) - (display-time-world-display (time--display-world-list))) + (if (get-buffer world-clock-buffer-name) + (with-current-buffer (get-buffer world-clock-buffer-name) + (world-clock-display (time--display-world-list))) ;; cancel timer (let ((list timer-list)) (while list (let ((elt (pop list))) (when (equal (symbol-name (timer--function elt)) - "display-time-world-timer") + "world-clock-update") (cancel-timer elt))))))) -(defalias 'display-time-world #'world-clock) - ;;;###autoload (defun emacs-uptime (&optional format) "Return a string giving the uptime of this instance of Emacs. -- 2.26.2 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0004-Rearrange-and-cleanup-code-in-time.el-Bug-40863.patch >From 137c920f5b1ab34120060af0d4e3adada0f3a8a3 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 2 May 2020 17:37:06 +0200 Subject: [PATCH 4/4] Rearrange and cleanup code in time.el (Bug#40863) * lisp/time.el (world-clock, zoneinfo-style-world-list) (legacy-style-world-list, world-clock-list) (time--display-world-list, world-clock-time-format) (world-clock-timer-enable, world-clock-timer-second): Move definitions closer to 'world-clock' code. Remove redundant :group args. (display-time-mail-file, display-time-mail-directory) (display-time-mail-function) (display-time-default-load-average) (display-time-load-average-threshold, display-time-day-and-date) (display-time-interval, display-time-24hr-format) (display-time-hook, display-time-mail-face) (display-time-use-mail-icon, display-time-mail-string) (display-time-format, display-time-string-forms): Remove redundant :group args. --- lisp/time.el | 216 +++++++++++++++++++++++---------------------------- 1 file changed, 97 insertions(+), 119 deletions(-) diff --git a/lisp/time.el b/lisp/time.el index 3f1880b708..e678254b54 100644 --- a/lisp/time.el +++ b/lisp/time.el @@ -34,23 +34,20 @@ display-time :group 'mode-line :group 'mail) - (defcustom display-time-mail-file nil "File name of mail inbox file, for indicating existence of new mail. Non-nil and not a string means don't check for mail; nil means use default, which is system-dependent, and is the same as used by Rmail." :type '(choice (const :tag "None" none) (const :tag "Default" nil) - (file :format "%v")) - :group 'display-time) + (file :format "%v"))) (defcustom display-time-mail-directory nil "Name of mail inbox directory, for indicating existence of new mail. Any nonempty regular file in the directory is regarded as newly arrived mail. If nil, do not check a directory for arriving mail." :type '(choice (const :tag "None" nil) - (directory :format "%v")) - :group 'display-time) + (directory :format "%v"))) (defcustom display-time-mail-function nil "Function to call, for indicating existence of new mail. @@ -58,8 +55,7 @@ display-time-mail-function specified by `display-time-mail-file' is nonempty or that the directory `display-time-mail-directory' contains nonempty files." :type '(choice (const :tag "Default" nil) - (function)) - :group 'display-time) + (function))) (defcustom display-time-default-load-average 0 "Which load average value will be shown in the mode line. @@ -74,8 +70,7 @@ display-time-default-load-average :type '(choice (const :tag "1 minute load" 0) (const :tag "5 minutes load" 1) (const :tag "15 minutes load" 2) - (const :tag "None" nil)) - :group 'display-time) + (const :tag "None" nil))) (defvar display-time-load-average nil "Value of the system's load average currently shown on the mode line. @@ -85,27 +80,23 @@ display-time-load-average (defcustom display-time-load-average-threshold 0.1 "Load-average values below this value won't be shown in the mode line." - :type 'number - :group 'display-time) + :type 'number) ;;;###autoload (defcustom display-time-day-and-date nil "\ Non-nil means \\[display-time] should display day and date as well as time." - :type 'boolean - :group 'display-time) + :type 'boolean) (defvar display-time-timer nil) (defcustom display-time-interval 60 "Seconds between updates of time in the mode line." - :type 'integer - :group 'display-time) + :type 'integer) (defcustom display-time-24hr-format nil "Non-nil indicates time should be displayed as hh:mm, 0 <= hh <= 23. A value of nil means 1 <= hh <= 12, and an AM/PM suffix is used." - :type 'boolean - :group 'display-time) + :type 'boolean) (defvar display-time-string nil "String used in mode lines to display a time string. @@ -115,106 +106,12 @@ display-time-string (defcustom display-time-hook nil "List of functions to be called when the time is updated on the mode line." - :type 'hook - :group 'display-time) + :type 'hook) (defvar display-time-server-down-time nil "Time when mail file's file system was recorded to be down. If that file system seems to be up, the value is nil.") -(defgroup world-clock nil - "Show a world clock." - :group 'applications) - -(defcustom zoneinfo-style-world-list - '(("America/Los_Angeles" "Seattle") - ("America/New_York" "New York") - ("Europe/London" "London") - ("Europe/Paris" "Paris") - ("Asia/Calcutta" "Bangalore") - ("Asia/Tokyo" "Tokyo")) - "Alist of zoneinfo-style time zones and places for `world-clock'. -Each element has the form (TIMEZONE LABEL). -TIMEZONE should be a string of the form AREA/LOCATION, where AREA is -the name of a region -- a continent or ocean, and LOCATION is the name -of a specific location, e.g., a city, within that region. -LABEL is a string to display as the label of that TIMEZONE's time." - :group 'world-clock - :type '(repeat (list string string)) - :version "23.1") - -(defcustom legacy-style-world-list - '(("PST8PDT" "Seattle") - ("EST5EDT" "New York") - ("GMT0BST" "London") - ("CET-1CDT" "Paris") - ("IST-5:30" "Bangalore") - ("JST-9" "Tokyo")) - "Alist of traditional-style time zones and places for `world-clock'. -Each element has the form (TIMEZONE LABEL). -TIMEZONE should be a string of the form: - - std[+|-]offset[dst[offset][,date[/time],date[/time]]] - -See the documentation of the TZ environment variable on your system, -for more details about the format of TIMEZONE. -LABEL is a string to display as the label of that TIMEZONE's time." - :group 'world-clock - :type '(repeat (list string string)) - :version "23.1") - -(defcustom world-clock-list t - "Alist of time zones and places for `world-clock' to display. -Each element has the form (TIMEZONE LABEL). -TIMEZONE should be in a format supported by your system. See the -documentation of `zoneinfo-style-world-list' and -`legacy-style-world-list' for two widely used formats. LABEL is -a string to display as the label of that TIMEZONE's time. - -If the value is t instead of an alist, use the value of -`zoneinfo-style-world-list' if it works on this platform, and of -`legacy-style-world-list' otherwise." - :group 'world-clock - :type '(choice (const :tag "Default" t) - (repeat :tag "List of zones and labels" - (list (string :tag "Zone") (string :tag "Label")))) - :version "28.1") - -(defun time--display-world-list () - (if (listp world-clock-list) - world-clock-list - ;; Determine if zoneinfo style timezones are supported by testing that - ;; America/New York and Europe/London return different timezones. - (let ((nyt (format-time-string "%z" nil "America/New_York")) - (gmt (format-time-string "%z" nil "Europe/London"))) - (if (string-equal nyt gmt) - legacy-style-world-list - zoneinfo-style-world-list)))) - -(defcustom world-clock-time-format "%A %d %B %R %Z" - "Time format for `world-clock', see `format-time-string'." - :group 'world-clock - :type 'string - :version "28.1") - -(defcustom world-clock-buffer-name "*wclock*" - "Name of the `world-clock' buffer." - :group 'world-clock - :type 'string - :version "28.1") - -(defcustom world-clock-timer-enable t - "If non-nil, a timer will update the `world-clock' buffer." - :group 'world-clock - :type 'boolean - :version "28.1") - -(defcustom world-clock-timer-second 60 - "Interval in seconds for updating the `world-clock' buffer." - :group 'world-clock - :type 'integer - :version "28.1") - ;;;###autoload (defun display-time () "Enable display of time, load level, and mail flag in mode lines. @@ -236,7 +133,6 @@ display-time-mail-face background color is the background of this face. Set this to make the mail indicator stand out on a color display." :group 'mode-line-faces - :group 'display-time :version "22.1" :type '(choice (const :tag "None" nil) face)) @@ -251,14 +147,12 @@ display-time-use-mail-icon "Non-nil means use an icon as mail indicator on a graphic display. Otherwise use `display-time-mail-string'. The icon may consume less of the mode line. It is specified by `display-time-mail-icon'." - :group 'display-time :type 'boolean) ;; Fixme: maybe default to the character if we can display Unicode. (defcustom display-time-mail-string "Mail" "String to use as the mail indicator in `display-time-string-forms'. This can use the Unicode letter character if you can display it." - :group 'display-time :version "22.1" :type '(choice (const "Mail") ;; Use :tag here because the Lucid menu won't display @@ -272,8 +166,7 @@ display-time-format how to write this string. If this is nil, the defaults depend on `display-time-day-and-date' and `display-time-24hr-format'." :type '(choice (const :tag "Default" nil) - string) - :group 'display-time) + string)) (defcustom display-time-string-forms '((if (and (not display-time-format) display-time-day-and-date) @@ -327,8 +220,7 @@ display-time-string-forms (if mail \" Mail\" \"\")) would give mode line times like `94/12/30 21:07:48 (UTC)'." - :type '(repeat sexp) - :group 'display-time) + :type '(repeat sexp)) (defun display-time-event-handler () (display-time-update) @@ -536,6 +428,92 @@ 'display-time-world-timer ;;; World clock +(defgroup world-clock nil + "Show a world clock." + :group 'applications) + +(defcustom zoneinfo-style-world-list + '(("America/Los_Angeles" "Seattle") + ("America/New_York" "New York") + ("Europe/London" "London") + ("Europe/Paris" "Paris") + ("Asia/Calcutta" "Bangalore") + ("Asia/Tokyo" "Tokyo")) + "Alist of zoneinfo-style time zones and places for `world-clock'. +Each element has the form (TIMEZONE LABEL). +TIMEZONE should be a string of the form AREA/LOCATION, where AREA is +the name of a region -- a continent or ocean, and LOCATION is the name +of a specific location, e.g., a city, within that region. +LABEL is a string to display as the label of that TIMEZONE's time." + :type '(repeat (list string string)) + :version "23.1") + +(defcustom legacy-style-world-list + '(("PST8PDT" "Seattle") + ("EST5EDT" "New York") + ("GMT0BST" "London") + ("CET-1CDT" "Paris") + ("IST-5:30" "Bangalore") + ("JST-9" "Tokyo")) + "Alist of traditional-style time zones and places for `world-clock'. +Each element has the form (TIMEZONE LABEL). +TIMEZONE should be a string of the form: + + std[+|-]offset[dst[offset][,date[/time],date[/time]]] + +See the documentation of the TZ environment variable on your system, +for more details about the format of TIMEZONE. +LABEL is a string to display as the label of that TIMEZONE's time." + :type '(repeat (list string string)) + :version "23.1") + +(defcustom world-clock-list t + "Alist of time zones and places for `world-clock' to display. +Each element has the form (TIMEZONE LABEL). +TIMEZONE should be in a format supported by your system. See the +documentation of `zoneinfo-style-world-list' and +`legacy-style-world-list' for two widely used formats. LABEL is +a string to display as the label of that TIMEZONE's time. + +If the value is t instead of an alist, use the value of +`zoneinfo-style-world-list' if it works on this platform, and of +`legacy-style-world-list' otherwise." + :type '(choice (const :tag "Default" t) + (repeat :tag "List of zones and labels" + (list (string :tag "Zone") (string :tag "Label")))) + :version "28.1") + +(defun time--display-world-list () + (if (listp world-clock-list) + world-clock-list + ;; Determine if zoneinfo style timezones are supported by testing that + ;; America/New York and Europe/London return different timezones. + (let ((nyt (format-time-string "%z" nil "America/New_York")) + (gmt (format-time-string "%z" nil "Europe/London"))) + (if (string-equal nyt gmt) + legacy-style-world-list + zoneinfo-style-world-list)))) + +(defcustom world-clock-time-format "%A %d %B %R %Z" + "Time format for `world-clock', see `format-time-string'." + :type 'string + :version "28.1") + +(defcustom world-clock-buffer-name "*wclock*" + "Name of the `world-clock' buffer." + :type 'string + :version "28.1") + +(defcustom world-clock-timer-enable t + "If non-nil, a timer will update the `world-clock' buffer." + :type 'boolean + :version "28.1") + +(defcustom world-clock-timer-second 60 + "Interval in seconds for updating the `world-clock' buffer." + :type 'integer + :version "28.1") + (defface world-clock-label '((t :inherit font-lock-variable-name-face)) "Face for time zone label in `world-clock' buffer.") -- 2.26.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 14:01:11 2020 Received: (at 40863) by debbugs.gnu.org; 2 May 2020 18:01:11 +0000 Received: from localhost ([127.0.0.1]:53891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUwRg-000880-Ce for submit@debbugs.gnu.org; Sat, 02 May 2020 14:01:11 -0400 Received: from ted.gofardesign.uk ([67.225.143.91]:42846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUwRe-00087i-CG for 40863@debbugs.gnu.org; Sat, 02 May 2020 14:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2KqJRfQwB0ncz0DK0gKn13E8brf8c2rrRV7vtlhm2Vs=; b=te4W0K8Q+B3qtvWJu2qOaZYnTF 4wKhszpquO839VqSsCmRyRJlNjDgmi5ChJAWS+jw3AjQsODLf50hz/CcDN/mx3w93VsZ0VRQp2nwS xR1aQbxrSeh/hHR3I8QVcwh4MJ82DD+4ICym4ADBv/Yd5uzObWomsovVwkY082YgjOECsCsIWZRY3 00Ikmk6f1bZVi/bxX8cmpnwD6PkImMYoZOF4LaqQRk5/LoZSZtT8QTCusAskvCjhr/BchHt+ZXxn7 23pVwr4iSiO8KXi0gtyW/3I0xA0qRa7EJZRidBJQRDP8/4KmSLpMwNYKNqtufwOBLNJ2PcRhtGmOU CmlXPKxg==; Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:35468 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jUwRW-001s8e-Vs; Sat, 02 May 2020 14:00:51 -0400 From: Stefan Kangas To: "Basil L. Contovounesios" Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI In-Reply-To: <87k11u48t0.fsf@stefankangas.se> (Stefan Kangas's message of "Sat, 02 May 2020 18:10:19 +0200") References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 02 May 2020 20:00:48 +0200 Message-ID: <87h7wy43ov.fsf@stefankangas.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > 4. Rearrange the defcustoms time.el to clearly separate world-clock ^ in > from display-time-mode. Cleanup of :group args. > > I have seen no to the proposals in patches 1-2 so far, and I hope that ^ objections > we can agree to make the changes also in patches 3-4. I think the > result is much more logical from pretty much any point of view. From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 01:26:51 2020 Received: (at 40863) by debbugs.gnu.org; 23 May 2020 05:26:51 +0000 Received: from localhost ([127.0.0.1]:33231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcMgN-0006zQ-4o for submit@debbugs.gnu.org; Sat, 23 May 2020 01:26:51 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:37865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcMgL-0006zE-Sa for 40863@debbugs.gnu.org; Sat, 23 May 2020 01:26:50 -0400 Received: by mail-yb1-f170.google.com with SMTP id l67so2071099ybl.4 for <40863@debbugs.gnu.org>; Fri, 22 May 2020 22:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=r2NJ9FKjIJ9Y175WkPvKtmmN2mYrUCinERXBR4rhzLA=; b=cbrQKenv94p+7EDANZtNQ29VhPqFbanex8DBPMoEgEyO/FQCbnkr7u85yRvNeAKvlB 9to5ZCbS27nCDC0xcP4UI0v7Byj77v0HDhi5ePEUqYsveCDRGyCA4nmGF0R5YREbH0km OtfuXKMGuKlfYGnwJIsiFWNYxwn9AccnFREnrEWP/kdtd42OjaUt1roJWT4qWSFxs2Im M2yQPRkmmNOZA8IbFsQk4AnFrcYc3pbi9b2WjmsW1yOLUriTIAMA0HvBAEdprR3aojfe uMJSV3kZ2aWJjsOqb40XQWDERNxfcg6bjFDPRCF/ecjnuv+i1L6OQri8fLrMUUo/Up5J q6GA== X-Gm-Message-State: AOAM532Khyq4aa8BcwJcZ1biJ1DUVWyZ/lOwiQa/z/jI5H45oA/FWZJy vF5Neu/r/HZfib4baYGeLfUBzMVpWN1Gk2HN7yU= X-Google-Smtp-Source: ABdhPJwSmt79kvNwGq9iwVWrGSMPTL5wGw7xLAlbS6I+ea/D6nw1KSbEW/AjQGgR8ES1bqEQbk+zPBGj8yIwmkLTKB8= X-Received: by 2002:a25:d64b:: with SMTP id n72mr13736825ybg.43.1590211603945; Fri, 22 May 2020 22:26:43 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 May 2020 22:26:43 -0700 From: Stefan Kangas In-Reply-To: <87k11u48t0.fsf@stefankangas.se> (Stefan Kangas's message of "Sat, 02 May 2020 18:10:19 +0200") References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 22 May 2020 22:26:43 -0700 Message-ID: Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Stefan Kangas writes: > So here's a revised set of patches: > > 1. Fix all Basil's comments, and remove the buffer rename that Eli > didn't approve of. > > 2. Rename 'display-time-world' to 'world-clock', and add an alias for > the old name. > > Then comes the more ambitious part: > > 3. Rename 'display-time-world-*' functions and variables into > 'world-clock-*' equivalents and make the old names into obsolete > aliases. > > Move the world-clock options from the defgroup display-time > (sorting under the mode-line and mail), into a new defgroup > world-clock (sorting under applications). > > 4. Rearrange the defcustoms time.el to clearly separate world-clock > from display-time-mode. Cleanup of :group args. > > I have seen no objections to the proposals in patches 1-2 so far, and > I hope that we can agree to make the changes also in patches 3-4. I > think the result is much more logical from pretty much any point of > view. > > Comments are obviously very welcome. No comments within 3 weeks. Can I therefore assume there are no objections to any of the above? Thanks. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 09:43:29 2020 Received: (at 40863) by debbugs.gnu.org; 23 May 2020 13:43:29 +0000 Received: from localhost ([127.0.0.1]:33734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUQy-0006nw-V2 for submit@debbugs.gnu.org; Sat, 23 May 2020 09:43:29 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:37201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUQx-0006nh-0o for 40863@debbugs.gnu.org; Sat, 23 May 2020 09:43:27 -0400 Received: by mail-wr1-f46.google.com with SMTP id l17so13019367wrr.4 for <40863@debbugs.gnu.org>; Sat, 23 May 2020 06:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5nHm8ih1nYbMDj24WKMvh/BPha9ohhAhvy0NEfhQ/qw=; b=1u5J837dcmmjUYU6oFd2GyGxjeN5t2yfWRiew3wUkjns21uucbmCQZufP793/VByu4 lyWfsqsOUQUM52mVD+MGGcT9zBHh+cwt7Mxjkf/vOnK3M4jJYK+hZm0eLc8Zptq6njrA TuR7iGHFxPOJEyhmqoeTpnpWybBGSJtM8b8meNixdHLs0yoHW2+Vi1M2rrto1YLqVowF Y5v5Muw5Swt+sXnGB34Q4UA3qPm6BTBHX83oMoBZ+hVSvy2A3CL7vfQnhBCGl9FqiynC i5N9jMBEH8PuDKZIDDgZOHCZQSLLn+Z9bmpOAqTY8+0Df73hsQEdl+xVkmubXfeUlXPv ho7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5nHm8ih1nYbMDj24WKMvh/BPha9ohhAhvy0NEfhQ/qw=; b=ANPiN0ByWW56xfoDae4+VUFKBxGslj4/AXGf64lD/t2GYkmAPKxEOL5W2lfY2RIXO4 JrR9/G9XhA7sPACaT1kly5rGpSKMsdt0/eL4zgG5bfiY4dZ0ygYspvRpvZvZplCCrjg0 tXD6vPNbXj7jPMZxqyKhTO9925Md+9wmVTdW9w70tHrJiHvaeNBrSOXbaVYuLR706hn8 a6ebZE7NYQjGkelu9KjEfmCAuMLyS2E1BAeFf1kRAn2kzg9vP3OKP2dm/0tHk2ah+wPj 0XwsHG7rEWalIzd50101GrZyBDvHT6aCZIO4HuZwZBhz/ynDN7xLMjwR3oc4gKW9vRqg cuPA== X-Gm-Message-State: AOAM530m4oe2qz/xqlRVD3j+q0w8Z2RuuRnzwWHNT0zZ2Eu59KHGjZX/ QjSLAswBIBZiTczXUV6UepQe5yc46U4= X-Google-Smtp-Source: ABdhPJykTLiN8zHGZV5X+BQ4sOAKcwGANbJNzDiOfT5dvdYk1onY0BhQFEX3f0qBmjsehALPy45Mjg== X-Received: by 2002:a5d:5585:: with SMTP id i5mr4314302wrv.112.1590241400821; Sat, 23 May 2020 06:43:20 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id z12sm1560800wrg.9.2020.05.23.06.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 06:43:19 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> Date: Sat, 23 May 2020 14:43:18 +0100 In-Reply-To: <87k11u48t0.fsf@stefankangas.se> (Stefan Kangas's message of "Sat, 02 May 2020 18:10:19 +0200") Message-ID: <87y2pircll.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the ping and sorry about not getting back sooner. I'm generally fine with the proposed changes, except for some comments below. > From e4e5012abdece7ce334900fd45f7e5ba06185ecc Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sun, 26 Apr 2020 10:16:06 +0200 > Subject: [PATCH 1/4] Improve display-time-world UI (Bug#40863) [...] > +(defvar display-time-world-mode-map > + (let ((map (make-sparse-keymap))) > + (define-key map "g" #'display-time-world-timer) I think it's better to keep the standard default binding of revert-buffer inherited from special-mode-map and set revert-buffer-function in display-time-world-mode instead, as I suggested in my last review. Then display-time-world-timer won't need an interactive spec, which doesn't sit too well with the function's current name and purpose. > + map) > + "Keymap for `display-time-world-mode'.") [...] > @@ -541,18 +554,17 @@ display-time-world-display > (defun display-time-world () > "Enable updating display of times in various time zones. > `display-time-world-list' specifies the zones. > -To turn off the world time display, go to that window and type `q'." > +To turn off the world time display, go to that window and type `\\[quit-window]'." > (interactive) > (when (and display-time-world-timer-enable > (not (get-buffer display-time-world-buffer-name))) > (run-at-time t display-time-world-timer-second 'display-time-world-timer)) > - (with-current-buffer (get-buffer-create display-time-world-buffer-name) > - (display-time-world-display (time--display-world-list)) > - (display-buffer display-time-world-buffer-name > - (cons nil '((window-height . fit-window-to-buffer)))) > - (display-time-world-mode))) > + (pop-to-buffer display-time-world-buffer-name) > + (display-time-world-display (time--display-world-list)) > + (display-time-world-mode)) You should call fit-window-to-buffer after populating the buffer to preserve the old display-buffer action semantics. (pop-to-buffer takes the same action argument, but buffer might still be empty then.) > (defun display-time-world-timer () > + (interactive) This shouldn't be necessary, as mentioned above. > (if (get-buffer display-time-world-buffer-name) > (with-current-buffer (get-buffer display-time-world-buffer-name) > (display-time-world-display (time--display-world-list))) > -- > 2.26.2 > > > From cd4c79a5758f0b6b8f5cc8acde62f806a1452b64 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sat, 2 May 2020 16:08:33 +0200 > Subject: [PATCH 2/4] Make 'display-time-world' into an alias for 'world-clock' > (Bug#40863) > > * lisp/time.el (world-clock): Rename from 'display-time-world'. > (display-time-world): Redefine as alias for 'world-clock'. > * etc/NEWS: Announce the above change. > > (top-level, zoneinfo-style-world-list, legacy-style-world-list) > (display-time-world-list, display-time-world-time-format) > (display-time-world-buffer-name) > (display-time-world-timer-enable) > (display-time-world-timer-second, display-time-world-label) > (display-time-world-timer): Update documentation to match the above > rename. These last entries should appear under lisp/time.el rather than etc/NEWS, and you can either leave out top-level (which is the name of an unrelated symbol) or write it as follows: * lisp/time.el: Lorem ipsum... (foo, bar): Curabitur pretium... Yet another way you could probably get away with (others may correct me), is: * lisp/time.el (world-clock): Rename from 'display-time-world'. Update all documentation to mention the new name. (display-time-world): Redefine as alias for 'world-clock'. * etc/NEWS: Announce the above change. [...] > From 043650acccd2528c5459c3c854cbd886acae9642 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sat, 2 May 2020 17:26:14 +0200 > Subject: [PATCH 3/4] Rename 'display-time-world' to 'world-clock' (Bug#40863) [...] > diff --git a/etc/NEWS b/etc/NEWS > index d2b745c579..d97b148cc8 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -291,9 +291,26 @@ These new navigation commands are bound to 'n' and 'p' in > ** Time > > --- > -*** 'display-time-world' is now an alias for 'world-clock'. > +*** 'display-time-world' has been renamed to 'world-clock'. > 'world-clock' creates a buffer with an updating time display using > -several time zones. The new name is hoped to be more discoverable. > +several time zones. I think you can keep "it is hoped that the new names are more discoverable" as a justification for this mass rename. > +The following functions have been renamed: > + > + 'display-time-world' to 'world-clock' > + 'display-time-world-mode' to 'world-clock-mode' > + 'display-time-world-display' to 'world-clock-display' > + 'display-time-world-timer' to 'world-clock-update' > + > +The following options have been renamed: > + > + 'display-time-world-list' to 'world-clock-list' > + 'display-time-world-time-format' to 'world-clock-time-format' > + 'display-time-world-buffer-name' to 'world-clock-buffer-namt' > + 'display-time-world-timer-enable' to 'world-clock-timer-enablt' > + 'display-time-world-timer-second' to 'world-clock-timer-secont' The last three world-clock-* vars are misspelt. > +The old names are now obsolete. > > > * New Modes and Packages in Emacs 28.1 > diff --git a/lisp/time.el b/lisp/time.el > index fe290ff71f..3f1880b708 100644 > --- a/lisp/time.el > +++ b/lisp/time.el > @@ -122,6 +122,10 @@ display-time-server-down-time > "Time when mail file's file system was recorded to be down. > If that file system seems to be up, the value is nil.") > > +(defgroup world-clock nil > + "Show a world clock." Nit: s/show/display/ Rings better in my ears and is consistent with the description of the display-time group. > + :group 'applications) It should continue to be under :group 'display-time as well. [...] > +;;; Obsolete names > + > +(define-obsolete-variable-alias 'display-time-world-list > + 'world-clock-list "28.1") > +(define-obsolete-variable-alias 'display-time-world-time-format > + 'world-clock-time-format "28.1") > +(define-obsolete-variable-alias 'display-time-world-buffer-name > + 'world-clock-buffer-name "28.1") > +(define-obsolete-variable-alias 'display-time-world-timer-enable > + 'world-clock-timer-enable "28.1") > +(define-obsolete-variable-alias 'display-time-world-timer-second > + 'world-clock-timer-second "28.1") These varaliases need to be declared before the variables they refer to. > +(define-obsolete-function-alias 'display-time-world-mode > + #'world-clock-mode "28.1") > +(define-obsolete-function-alias 'display-time-world-display > + #'world-clock-display "28.1") > +(define-obsolete-function-alias 'display-time-world > + #'world-clock "28.1") > +(define-obsolete-function-alias 'display-time-world-timer > + #'world-clock-update "28.1") > + > + > +;;; World clock > + > +(defface world-clock-label > '((t :inherit font-lock-variable-name-face)) > "Face for time zone label in `world-clock' buffer.") > > -(defvar display-time-world-mode-map > +(defvar world-clock-mode-map > (let ((map (make-sparse-keymap))) > - (define-key map "g" #'display-time-world-timer) > + (define-key map "g" #'world-clock-update) Ditto re: revert-buffer-function. > map) > - "Keymap for `display-time-world-mode'.") > + "Keymap for `world-clock-mode'.") [...] > @@ -552,32 +580,30 @@ display-time-world-display > ;;;###autoload > (defun world-clock () > "Show world clock buffer with times in various time zones. > -`display-time-world-list' specifies the zones. > +`world-clock-list' specifies the zones. > To turn off the world time display, go to that window and type `\\[quit-window]'." > (interactive) > - (when (and display-time-world-timer-enable > - (not (get-buffer display-time-world-buffer-name))) > - (run-at-time t display-time-world-timer-second 'display-time-world-timer)) > - (pop-to-buffer display-time-world-buffer-name) > - (display-time-world-display (time--display-world-list)) > - (display-time-world-mode)) > - > -(defun display-time-world-timer () > + (when (and world-clock-timer-enable > + (not (get-buffer world-clock-buffer-name))) > + (run-at-time t world-clock-timer-second 'world-clock-update)) ^ Nit: Quote with #'. > + (pop-to-buffer world-clock-buffer-name) > + (world-clock-display (time--display-world-list)) > + (world-clock-mode)) [...] > From 137c920f5b1ab34120060af0d4e3adada0f3a8a3 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Sat, 2 May 2020 17:37:06 +0200 > Subject: [PATCH 4/4] Rearrange and cleanup code in time.el (Bug#40863) Nit: The verb is to 'clean up'. > * lisp/time.el (world-clock, zoneinfo-style-world-list) > (legacy-style-world-list, world-clock-list) > (time--display-world-list, world-clock-time-format) > (world-clock-timer-enable, world-clock-timer-second): Move definitions > closer to 'world-clock' code. Remove redundant :group args. > > (display-time-mail-file, display-time-mail-directory) > (display-time-mail-function) > (display-time-default-load-average) > (display-time-load-average-threshold, display-time-day-and-date) > (display-time-interval, display-time-24hr-format) > (display-time-hook, display-time-mail-face) > (display-time-use-mail-icon, display-time-mail-string) > (display-time-format, display-time-string-forms): Remove redundant > :group args. [...] Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 09:44:09 2020 Received: (at 40863) by debbugs.gnu.org; 23 May 2020 13:44:09 +0000 Received: from localhost ([127.0.0.1]:33738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcURd-0006pM-I8 for submit@debbugs.gnu.org; Sat, 23 May 2020 09:44:09 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcURc-0006pA-4H for 40863@debbugs.gnu.org; Sat, 23 May 2020 09:44:08 -0400 Received: by mail-wr1-f53.google.com with SMTP id j16so568014wrb.7 for <40863@debbugs.gnu.org>; Sat, 23 May 2020 06:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OHvcBYx+KZPD7qq6YrXbFb45sTj3DLIKKZIMDAgJBcs=; b=IxwKQhwFilF+tddEWdayptXcafeFrwzxAmgL2/nR6ydsBexJIccm3l1OHUNxlSRnHm bhEfwpvs6WuwE8Eh8k+8ZRFBAeFwuKmx/WLB/IZUk+qnmwNeR4txKbi9dPTawb/4aZ/O JtXpTr8mKzgatcSMZbIjXgkpUthIsp2JzHLf/pH24KBsofThCp11QcaCkR8G1HBDK/sE +d5bL2bvhTmVPfpBsqdiYfED/Lzb++SO2n5dY6Cu8Mg4nP2K0Sf1hrsCtYJWXSBgwSDg CHxVjc5Fur96G6Zrn9kKjPHTebttQdHbHxaYfXWi8xQyaRqHeTuuFzr8U8WhlXM9q5eN ZonA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OHvcBYx+KZPD7qq6YrXbFb45sTj3DLIKKZIMDAgJBcs=; b=a24+gRpq5Zcs4wMh8e5tHhfDpy+XRkM5KXHxpT0rDsBbpj3QVpsZ7YhYVjidFIekU0 AJz+H4LMMfuk3Oxvlp7Z9rvXV4Ryn2WLSD+NHGZ5SfrtxB7jhbGQxEXrRb05sfvSBarX uARTy0CDLgxcPXikLP9sjTlZnpyNQhCH9p/WSeDZU8qWT9S1RUta3b5uwYYpITBxViug MKrSBXChpQNUzNu5Y/oodda/r5PAEVr/FDj6fbUgExCurcqfix406pSbzzR1ZCxDbWIt SgbjpDOAEB6PrwfhgqiPWgym40G3Bx+oQgZ+x4tYs6qKRFMMOwPL6nmgX4HFfhQ5ujmD kChQ== X-Gm-Message-State: AOAM532NJ61+j1YjF50It0ZFMJjFQdGSfB+eWQgTkMBc+kE1Z/ssQQa0 FAqo8pzU1TiJicPK1/2xB3MTv5UWVFE= X-Google-Smtp-Source: ABdhPJy/rkEw86QMqkDCRLAG7CwgwmW+1v0QZ3isnc3258RtQe4vCQKaMHXWiqzLNNWpqaqv/g1J/g== X-Received: by 2002:adf:91c2:: with SMTP id 60mr8012289wri.41.1590241442538; Sat, 23 May 2020 06:44:02 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id r14sm17070551wmb.2.2020.05.23.06.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 06:44:02 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <874kt4y1rc.fsf@tcd.ie> <87sggi4kte.fsf@stefankangas.se> Date: Sat, 23 May 2020 14:44:00 +0100 In-Reply-To: <87sggi4kte.fsf@stefankangas.se> (Stefan Kangas's message of "Sat, 02 May 2020 13:50:53 +0200") Message-ID: <87tv06rckf.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >> Just curious: when do we use 'face' and when 'font-lock-face'? > > I think this is explained in (info "(elisp) Special Properties"). I'm aware of the difference between the two properties. My question is, when do we prefer one or the other? My impression is that font-lock-face should be preferred wherever it makes sense, as its display can be toggled. Not that I'm arguing for switching to font-lock-face in this case; that could be done another time. I was just wondering out loud. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 07 13:23:11 2020 Received: (at 40863) by debbugs.gnu.org; 7 Aug 2020 17:23:11 +0000 Received: from localhost ([127.0.0.1]:57481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k465G-0002cY-E8 for submit@debbugs.gnu.org; Fri, 07 Aug 2020 13:23:11 -0400 Received: from mail-yb1-f174.google.com ([209.85.219.174]:42889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k465E-0002cK-7g for 40863@debbugs.gnu.org; Fri, 07 Aug 2020 13:23:09 -0400 Received: by mail-yb1-f174.google.com with SMTP id a34so1377585ybj.9 for <40863@debbugs.gnu.org>; Fri, 07 Aug 2020 10:23:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=7CUzBoeo5XdCXtyg3Mhku9NRp8nQNMhbu2V49YBP5B4=; b=hK1zKTGrJL4lp6WcBiOTvIOsIiaMeWq4FSMtNmCP8QggFnZWKDTzBLS3Nx1uRiFrAi nUPuabHJBs1YwMfnvTi7wDMqIzdDhMtVibrPbWjwWr5vudot1S4S4R373JwCnd982oIB JJFgUSpK1aaxDCvT4xDh10HIPHBNHEVkgtCU3tu5ySswT3D9N40Ll23oI2uyFw8WXja6 fIIVRERV2nTot43K+wiY1SKvoWUkt6Gluod7OQvJbN6S7B+ahd3uUGCE6HTrgTA/HTBx blD6sLSMkkQfsRnUQrp/2fhTnNbzVAAYpZ7YWP8aoC2SJuGrkzYJ18X4aD9sl6WMLmmH aKeg== X-Gm-Message-State: AOAM5317+ea4UZ4JEPx5dv2s6+GQJ5F7Tv3tkvyqnW4I6/xqloR4Ylqo iQ+GMHGrJ5yvCQ17nv0OiZzPHS6zfsa7snbagn0= X-Google-Smtp-Source: ABdhPJzycrdjDFBI6KLwa3EH2ZW/pMrSC1MzhLPAsCz9+FmxqvxJb8eVJEzUtXSAyd7HrA0ZRGdAWQjgns+Lp0G8nJE= X-Received: by 2002:a25:4609:: with SMTP id t9mr21010924yba.231.1596820982551; Fri, 07 Aug 2020 10:23:02 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Aug 2020 10:23:01 -0700 From: Stefan Kangas In-Reply-To: <87y2pircll.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 23 May 2020 14:43:18 +0100") References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 7 Aug 2020 10:23:01 -0700 Message-ID: Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: "Basil L. Contovounesios" Content-Type: multipart/mixed; boundary="0000000000006fa1cb05ac4cdb66" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000006fa1cb05ac4cdb66 Content-Type: text/plain; charset="UTF-8" "Basil L. Contovounesios" writes: > Thanks for the ping and sorry about not getting back sooner. Thank you for the detailed review! I believe I have fixed all your comments in the attached patches. (Note that I squashed patch 2 and 3 into one patch.) Please let me know if there are any further comments. Best regards, Stefan Kangas --0000000000006fa1cb05ac4cdb66 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Improve-display-time-world-UI-Bug-40863.patch" Content-Disposition: attachment; filename="0001-Improve-display-time-world-UI-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 8c077831b79281a6_0.1 RnJvbSA4NTNiOTM1OWE5MWVmZWMwYzEwYjIyZDQ5NjQ1ZjVkMGZmOTRiMTdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDEwOjE2OjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSCAx LzNdIEltcHJvdmUgZGlzcGxheS10aW1lLXdvcmxkIFVJIChCdWcjNDA4NjMpCgoqIGxpc3AvdGlt ZS5lbCAoZGlzcGxheS10aW1lLXdvcmxkLW1vZGUpOiBTZXQgJ3JldmVydC1idWZmZXItZnVuY3Rp b24nCnRvICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXInLgoKKGRpc3BsYXktdGltZS13b3JsZC1s YWJlbCk6IE5ldyBmYWNlLgooZGlzcGxheS10aW1lLXdvcmxkLWRpc3BsYXkpOiBVc2UgdGhlIG5l dyBmYWNlLiAgTW92ZSBwb2ludCB0byBuZXcKYnVmZmVyIG9uIGNyZWF0aW9uIGFuZCByZXNpemUu Ci0tLQogbGlzcC90aW1lLmVsIHwgMjEgKysrKysrKysrKysrKystLS0tLS0tCiAxIGZpbGUgY2hh bmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L3RpbWUuZWwgYi9saXNwL3RpbWUuZWwKaW5kZXggNDRmZDFhN2UzMy4uNzU1MjZhMjJlMCAxMDA2 NDQKLS0tIGEvbGlzcC90aW1lLmVsCisrKyBiL2xpc3AvdGltZS5lbApAQCAtNTA5LDkgKzUwOSwx NCBAQCBkaXNwbGF5LXRpbWUtbW9kZQogCQkgJ2Rpc3BsYXktdGltZS1ldmVudC1oYW5kbGVyKSkp CiAKIAorKGRlZmZhY2UgZGlzcGxheS10aW1lLXdvcmxkLWxhYmVsCisgICcoKHQgOmluaGVyaXQg Zm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkpCisgICJGYWNlIGZvciB0aW1lIHpvbmUgbGFi ZWwuIikKKwogKGRlZmluZS1kZXJpdmVkLW1vZGUgZGlzcGxheS10aW1lLXdvcmxkLW1vZGUgc3Bl Y2lhbC1tb2RlICJXb3JsZCBjbG9jayIKICAgIk1ham9yIG1vZGUgZm9yIGJ1ZmZlciB0aGF0IGRp c3BsYXlzIHRpbWVzIGluIHZhcmlvdXMgdGltZSB6b25lcy4KIFNlZSBgZGlzcGxheS10aW1lLXdv cmxkJy4iCisgIChzZXRxIHJldmVydC1idWZmZXItZnVuY3Rpb24gJ2Rpc3BsYXktdGltZS13b3Js ZC10aW1lcikKICAgKHNldHEgc2hvdy10cmFpbGluZy13aGl0ZXNwYWNlIG5pbCkpCiAKIChkZWZ1 biBkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAoYWxpc3QpCkBAIC01MzMsNyArNTM4LDEwIEBA IGRpc3BsYXktdGltZS13b3JsZC1kaXNwbGF5CiAJICAoc2V0cSBtYXgtd2lkdGggd2lkdGgpKSkp CiAgICAgKHNldHEgZm10IChjb25jYXQgIiUtIiAoaW50LXRvLXN0cmluZyBtYXgtd2lkdGgpICJz ICVzXG4iKSkKICAgICAoZG9saXN0ICh0aW1lZGF0YSAobnJldmVyc2UgcmVzdWx0KSkKLSAgICAg IChpbnNlcnQgKGZvcm1hdCBmbXQgKGNhciB0aW1lZGF0YSkgKGNkciB0aW1lZGF0YSkpKSkKKyAg ICAgIChpbnNlcnQgKGZvcm1hdCBmbXQKKyAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6 ZSAoY2FyIHRpbWVkYXRhKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdmYWNl ICdkaXNwbGF5LXRpbWUtd29ybGQtbGFiZWwpCisgICAgICAgICAgICAgICAgICAgICAgKGNkciB0 aW1lZGF0YSkpKSkKICAgICAoZGVsZXRlLWNoYXIgLTEpKQogICAoZ290by1jaGFyIChwb2ludC1t aW4pKSkKIApAQCAtNTQxLDE2ICs1NDksMTUgQEAgZGlzcGxheS10aW1lLXdvcmxkLWRpc3BsYXkK IChkZWZ1biBkaXNwbGF5LXRpbWUtd29ybGQgKCkKICAgIkVuYWJsZSB1cGRhdGluZyBkaXNwbGF5 IG9mIHRpbWVzIGluIHZhcmlvdXMgdGltZSB6b25lcy4KIGBkaXNwbGF5LXRpbWUtd29ybGQtbGlz dCcgc3BlY2lmaWVzIHRoZSB6b25lcy4KLVRvIHR1cm4gb2ZmIHRoZSB3b3JsZCB0aW1lIGRpc3Bs YXksIGdvIHRvIHRoYXQgd2luZG93IGFuZCB0eXBlIGBxJy4iCitUbyB0dXJuIG9mZiB0aGUgd29y bGQgdGltZSBkaXNwbGF5LCBnbyB0byB0aGF0IHdpbmRvdyBhbmQgdHlwZSBgXFxbcXVpdC13aW5k b3ddJy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKHdoZW4gKGFuZCBkaXNwbGF5LXRpbWUtd29ybGQt dGltZXItZW5hYmxlCiAgICAgICAgICAgICAgKG5vdCAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRpbWUt d29ybGQtYnVmZmVyLW5hbWUpKSkKICAgICAocnVuLWF0LXRpbWUgdCBkaXNwbGF5LXRpbWUtd29y bGQtdGltZXItc2Vjb25kICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIpKQotICAod2l0aC1jdXJy ZW50LWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1u YW1lKQotICAgIChkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3Js ZC1saXN0KSkKLSAgICAoZGlzcGxheS1idWZmZXIgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1u YW1lCi0JCSAgICAoY29ucyBuaWwgJygod2luZG93LWhlaWdodCAuIGZpdC13aW5kb3ctdG8tYnVm ZmVyKSkpKQotICAgIChkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSkpKQorICAocG9wLXRvLWJ1ZmZl ciBkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCisgIChkaXNwbGF5LXRpbWUtd29ybGQt ZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkKKyAgKGRpc3BsYXktdGltZS13b3Js ZC1tb2RlKQorICAoZml0LXdpbmRvdy10by1idWZmZXIpKQogCiAoZGVmdW4gZGlzcGxheS10aW1l LXdvcmxkLXRpbWVyICgpCiAgIChpZiAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQtYnVm ZmVyLW5hbWUpCi0tIAoyLjI3LjAKCg== --0000000000006fa1cb05ac4cdb66 Content-Type: text/x-diff; charset="US-ASCII"; name="0002-Rename-display-time-world-to-world-clock-Bug-40863.patch" Content-Disposition: attachment; filename="0002-Rename-display-time-world-to-world-clock-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 8c077831b79281a6_0.2 RnJvbSA2M2M5ODgyMTM5ZTQzMzM1OTgwNWRlYmVlZGMzNWZkOWJlNzVmNzA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDIgTWF5IDIwMjAgMTY6MDg6MzMgKzAyMDAKU3ViamVjdDogW1BBVENIIDIv M10gUmVuYW1lICdkaXNwbGF5LXRpbWUtd29ybGQnIHRvICd3b3JsZC1jbG9jaycgKEJ1ZyM0MDg2 MykKCiogbGlzcC90aW1lLmVsICh3b3JsZC1jbG9jay1saXN0LCB3b3JsZC1jbG9jay10aW1lLWZv cm1hdCkKKHdvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lLCB3b3JsZC1jbG9jay10aW1lci1lbmFibGUp Cih3b3JsZC1jbG9jay10aW1lci1zZWNvbmQsIHdvcmxkLWNsb2NrLWxhYmVsLCB3b3JsZC1jbG9j ay1tb2RlKQood29ybGQtY2xvY2stZGlzcGxheSwgd29ybGQtY2xvY2ssIHdvcmxkLWNsb2NrLXVw ZGF0ZSk6IFJlbmFtZQpmcm9tICdkaXNwbGF5LXRpbWUtd29ybGQtKicgYW5kIHVwZGF0ZSBhbGwg dXNlcy4KCih3b3JsZC1jbG9jayk6IE5ldyBkZWZncm91cC4KKHpvbmVpbmZvLXN0eWxlLXdvcmxk LWxpc3QsIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0KTogVXNlIDpncm91cAond29ybGQtY2xvY2sn LgoKKGRpc3BsYXktdGltZS13b3JsZC1saXN0LCBkaXNwbGF5LXRpbWUtd29ybGQtdGltZS1mb3Jt YXQpCihkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCihkaXNwbGF5LXRpbWUtd29ybGQt dGltZXItZW5hYmxlKQooZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyLXNlY29uZCk6IE1ha2UgaW50 byBvYnNvbGV0ZSB2YXJpYWJsZQphbGlhc2VzIGZvciB0aGUgbmV3IG5hbWVzLgoKKiBsaXNwL3Rp bWUuZWwgKGRpc3BsYXktdGltZS13b3JsZC1tb2RlKQooZGlzcGxheS10aW1lLXdvcmxkLWRpc3Bs YXksIGRpc3BsYXktdGltZS13b3JsZCkKKGRpc3BsYXktdGltZS13b3JsZC10aW1lcik6IE1ha2Ug aW50byBvYnNvbGV0ZSBmdW5jdGlvbiBhbGlhc2VzCmZvciB0aGUgbmV3IG5hbWVzLgoKKiBldGMv TkVXUzogQW5ub3VuY2UgdGhlIGFib3ZlIGNoYW5nZXMuCi0tLQogZXRjL05FV1MgICAgIHwgIDI1 ICsrKysrKysrKysKIGxpc3AvdGltZS5lbCB8IDEzMCArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTA0IGluc2VydGlv bnMoKyksIDUxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MK aW5kZXggODUwYjE2NjA2OS4uNjMwYjllY2YxOSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIv ZXRjL05FV1MKQEAgLTY5Nyw2ICs2OTcsMzEgQEAgY3VzdG9tIHJ1bGVzLCBzZWUgdGhlIHZhcmlh YmxlcyAnYnVnLXJlZmVyZW5jZS1zZXR1cC1mcm9tLXZjLWFsaXN0JywKIEl0J3MgYm91bmQgdG8g dGhlICdDLWMgQy1jIGYnIGtleXN0cm9rZSwgYW5kIHByb21wdHMgZm9yIGEgbG9jYWwgZmlsZQog bmFtZS4KIAorKiogVGltZQorCistLS0KKyoqKiAnZGlzcGxheS10aW1lLXdvcmxkJyBoYXMgYmVl biByZW5hbWVkIHRvICd3b3JsZC1jbG9jaycuCisnd29ybGQtY2xvY2snIGNyZWF0ZXMgYSBidWZm ZXIgd2l0aCBhbiB1cGRhdGluZyB0aW1lIGRpc3BsYXkgdXNpbmcKK3NldmVyYWwgdGltZSB6b25l cy4gIEl0IGlzIGhvcGVkIHRoYXQgdGhlIG5ldyBuYW1lcyBhcmUgbW9yZQorZGlzY292ZXJhYmxl LgorCitUaGUgZm9sbG93aW5nIGZ1bmN0aW9ucyBoYXZlIGJlZW4gcmVuYW1lZDoKKworICAnZGlz cGxheS10aW1lLXdvcmxkJyAgICAgICAgIHRvICd3b3JsZC1jbG9jaycKKyAgJ2Rpc3BsYXktdGlt ZS13b3JsZC1tb2RlJyAgICB0byAnd29ybGQtY2xvY2stbW9kZScKKyAgJ2Rpc3BsYXktdGltZS13 b3JsZC1kaXNwbGF5JyB0byAnd29ybGQtY2xvY2stZGlzcGxheScKKyAgJ2Rpc3BsYXktdGltZS13 b3JsZC10aW1lcicgICB0byAnd29ybGQtY2xvY2stdXBkYXRlJworCitUaGUgZm9sbG93aW5nIG9w dGlvbnMgaGF2ZSBiZWVuIHJlbmFtZWQ6CisKKyAgJ2Rpc3BsYXktdGltZS13b3JsZC1saXN0JyAg ICAgICAgIHRvICd3b3JsZC1jbG9jay1saXN0JworICAnZGlzcGxheS10aW1lLXdvcmxkLXRpbWUt Zm9ybWF0JyAgdG8gJ3dvcmxkLWNsb2NrLXRpbWUtZm9ybWF0JworICAnZGlzcGxheS10aW1lLXdv cmxkLWJ1ZmZlci1uYW1lJyAgdG8gJ3dvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lJworICAnZGlzcGxh eS10aW1lLXdvcmxkLXRpbWVyLWVuYWJsZScgdG8gJ3dvcmxkLWNsb2NrLXRpbWVyLWVuYWJsZScK KyAgJ2Rpc3BsYXktdGltZS13b3JsZC10aW1lci1zZWNvbmQnIHRvICd3b3JsZC1jbG9jay10aW1l ci1zZWNvbmQnCisKK1RoZSBvbGQgbmFtZXMgYXJlIG5vdyBvYnNvbGV0ZS4KKwogDAogKiBOZXcg TW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNzIDI4LjEKIApkaWZmIC0tZ2l0IGEvbGlzcC90aW1l LmVsIGIvbGlzcC90aW1lLmVsCmluZGV4IDc1NTI2YTIyZTAuLjdjZmYxZTZiNDUgMTAwNjQ0Ci0t LSBhL2xpc3AvdGltZS5lbAorKysgYi9saXNwL3RpbWUuZWwKQEAgLTI1LDggKzI1LDcgQEAKIDs7 IEZhY2lsaXRpZXMgdG8gZGlzcGxheSBjdXJyZW50IHRpbWUvZGF0ZSBhbmQgYSBuZXctbWFpbCBp bmRpY2F0b3IKIDs7IGluIHRoZSBFbWFjcyBtb2RlIGxpbmUuICBUaGUgZW50cnkgcG9pbnQgaXMg YGRpc3BsYXktdGltZScuCiAKLTs7IERpc3BsYXkgdGltZSB3b3JsZCBpbiBhIGJ1ZmZlciwgdGhl IGVudHJ5IHBvaW50IGlzCi07OyBgZGlzcGxheS10aW1lLXdvcmxkJy4KKzs7IFVzZSBgd29ybGQt Y2xvY2snIHRvIGRpc3BsYXkgd29ybGQgY2xvY2sgaW4gYSBidWZmZXIuCiAKIDs7OyBDb2RlOgog CkBAIC0xMjMsNiArMTIyLDEwIEBAIGRpc3BsYXktdGltZS1zZXJ2ZXItZG93bi10aW1lCiAgICAi VGltZSB3aGVuIG1haWwgZmlsZSdzIGZpbGUgc3lzdGVtIHdhcyByZWNvcmRlZCB0byBiZSBkb3du LgogSWYgdGhhdCBmaWxlIHN5c3RlbSBzZWVtcyB0byBiZSB1cCwgdGhlIHZhbHVlIGlzIG5pbC4i KQogCisoZGVmZ3JvdXAgd29ybGQtY2xvY2sgbmlsCisgICJEaXNwbGF5IGEgd29ybGQgY2xvY2su IgorICA6Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKwogKGRlZmN1c3RvbSB6b25laW5mby1zdHlsZS13 b3JsZC1saXN0CiAgICcoKCJBbWVyaWNhL0xvc19BbmdlbGVzIiAiU2VhdHRsZSIpCiAgICAgKCJB bWVyaWNhL05ld19Zb3JrIiAiTmV3IFlvcmsiKQpAQCAtMTMwLDEzICsxMzMsMTMgQEAgem9uZWlu Zm8tc3R5bGUtd29ybGQtbGlzdAogICAgICgiRXVyb3BlL1BhcmlzIiAiUGFyaXMiKQogICAgICgi QXNpYS9DYWxjdXR0YSIgIkJhbmdhbG9yZSIpCiAgICAgKCJBc2lhL1Rva3lvIiAiVG9reW8iKSkK LSAgIkFsaXN0IG9mIHpvbmVpbmZvLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYGRp c3BsYXktdGltZS13b3JsZCcuCisgICJBbGlzdCBvZiB6b25laW5mby1zdHlsZSB0aW1lIHpvbmVz IGFuZCBwbGFjZXMgZm9yIGB3b3JsZC1jbG9jaycuCiBFYWNoIGVsZW1lbnQgaGFzIHRoZSBmb3Jt IChUSU1FWk9ORSBMQUJFTCkuCiBUSU1FWk9ORSBzaG91bGQgYmUgYSBzdHJpbmcgb2YgdGhlIGZv cm0gQVJFQS9MT0NBVElPTiwgd2hlcmUgQVJFQSBpcwogdGhlIG5hbWUgb2YgYSByZWdpb24gLS0g YSBjb250aW5lbnQgb3Igb2NlYW4sIGFuZCBMT0NBVElPTiBpcyB0aGUgbmFtZQogb2YgYSBzcGVj aWZpYyBsb2NhdGlvbiwgZS5nLiwgYSBjaXR5LCB3aXRoaW4gdGhhdCByZWdpb24uCiBMQUJFTCBp cyBhIHN0cmluZyB0byBkaXNwbGF5IGFzIHRoZSBsYWJlbCBvZiB0aGF0IFRJTUVaT05FJ3MgdGlt ZS4iCi0gIDpncm91cCAnZGlzcGxheS10aW1lCisgIDpncm91cCAnd29ybGQtY2xvY2sKICAgOnR5 cGUgJyhyZXBlYXQgKGxpc3Qgc3RyaW5nIHN0cmluZykpCiAgIDp2ZXJzaW9uICIyMy4xIikKIApA QCAtMTQ3LDcgKzE1MCw3IEBAIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0CiAgICAgKCJDRVQtMUNE VCIgIlBhcmlzIikKICAgICAoIklTVC01OjMwIiAiQmFuZ2Fsb3JlIikKICAgICAoIkpTVC05IiAi VG9reW8iKSkKLSAgIkFsaXN0IG9mIHRyYWRpdGlvbmFsLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBs YWNlcyBmb3IgYGRpc3BsYXktdGltZS13b3JsZCcuCisgICJBbGlzdCBvZiB0cmFkaXRpb25hbC1z dHlsZSB0aW1lIHpvbmVzIGFuZCBwbGFjZXMgZm9yIGB3b3JsZC1jbG9jaycuCiBFYWNoIGVsZW1l bnQgaGFzIHRoZSBmb3JtIChUSU1FWk9ORSBMQUJFTCkuCiBUSU1FWk9ORSBzaG91bGQgYmUgYSBz dHJpbmcgb2YgdGhlIGZvcm06CiAKQEAgLTE1NiwxMiArMTU5LDEyIEBAIGxlZ2FjeS1zdHlsZS13 b3JsZC1saXN0CiBTZWUgdGhlIGRvY3VtZW50YXRpb24gb2YgdGhlIFRaIGVudmlyb25tZW50IHZh cmlhYmxlIG9uIHlvdXIgc3lzdGVtLAogZm9yIG1vcmUgZGV0YWlscyBhYm91dCB0aGUgZm9ybWF0 IG9mIFRJTUVaT05FLgogTEFCRUwgaXMgYSBzdHJpbmcgdG8gZGlzcGxheSBhcyB0aGUgbGFiZWwg b2YgdGhhdCBUSU1FWk9ORSdzIHRpbWUuIgotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZQorICA6Z3Jv dXAgJ3dvcmxkLWNsb2NrCiAgIDp0eXBlICcocmVwZWF0IChsaXN0IHN0cmluZyBzdHJpbmcpKQog ICA6dmVyc2lvbiAiMjMuMSIpCiAKLShkZWZjdXN0b20gZGlzcGxheS10aW1lLXdvcmxkLWxpc3Qg dAotICAiQWxpc3Qgb2YgdGltZSB6b25lcyBhbmQgcGxhY2VzIGZvciBgZGlzcGxheS10aW1lLXdv cmxkJyB0byBkaXNwbGF5LgorKGRlZmN1c3RvbSB3b3JsZC1jbG9jay1saXN0IHQKKyAgIkFsaXN0 IG9mIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYHdvcmxkLWNsb2NrJyB0byBkaXNwbGF5Lgog RWFjaCBlbGVtZW50IGhhcyB0aGUgZm9ybSAoVElNRVpPTkUgTEFCRUwpLgogVElNRVpPTkUgc2hv dWxkIGJlIGluIGEgZm9ybWF0IHN1cHBvcnRlZCBieSB5b3VyIHN5c3RlbS4gIFNlZSB0aGUKIGRv Y3VtZW50YXRpb24gb2YgYHpvbmVpbmZvLXN0eWxlLXdvcmxkLWxpc3QnIGFuZApAQCAtMTcxLDE2 ICsxNzQsMTUgQEAgZGlzcGxheS10aW1lLXdvcmxkLWxpc3QKIElmIHRoZSB2YWx1ZSBpcyB0IGlu c3RlYWQgb2YgYW4gYWxpc3QsIHVzZSB0aGUgdmFsdWUgb2YKIGB6b25laW5mby1zdHlsZS13b3Js ZC1saXN0JyBpZiBpdCB3b3JrcyBvbiB0aGlzIHBsYXRmb3JtLCBhbmQgb2YKIGBsZWdhY3ktc3R5 bGUtd29ybGQtbGlzdCcgb3RoZXJ3aXNlLiIKLQotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZQorICA6 Z3JvdXAgJ3dvcmxkLWNsb2NrCiAgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJEZWZhdWx0 IiB0KQogICAgICAgICAgICAgICAgICAocmVwZWF0IDp0YWcgIkxpc3Qgb2Ygem9uZXMgYW5kIGxh YmVscyIKICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCAoc3RyaW5nIDp0YWcgIlpvbmUi KSAoc3RyaW5nIDp0YWcgIkxhYmVsIikpKSkKLSAgOnZlcnNpb24gIjIzLjEiKQorICA6dmVyc2lv biAiMjguMSIpCiAKIChkZWZ1biB0aW1lLS1kaXNwbGF5LXdvcmxkLWxpc3QgKCkKLSAgKGlmIChs aXN0cCBkaXNwbGF5LXRpbWUtd29ybGQtbGlzdCkKLSAgICAgIGRpc3BsYXktdGltZS13b3JsZC1s aXN0CisgIChpZiAobGlzdHAgd29ybGQtY2xvY2stbGlzdCkKKyAgICAgIHdvcmxkLWNsb2NrLWxp c3QKICAgICA7OyBEZXRlcm1pbmUgaWYgem9uZWluZm8gc3R5bGUgdGltZXpvbmVzIGFyZSBzdXBw b3J0ZWQgYnkgdGVzdGluZyB0aGF0CiAgICAgOzsgQW1lcmljYS9OZXcgWW9yayBhbmQgRXVyb3Bl L0xvbmRvbiByZXR1cm4gZGlmZmVyZW50IHRpbWV6b25lcy4KICAgICAobGV0ICgobnl0IChmb3Jt YXQtdGltZS1zdHJpbmcgIiV6IiBuaWwgIkFtZXJpY2EvTmV3X1lvcmsiKSkKQEAgLTE4OSwyOSAr MTkxLDI5IEBAIHRpbWUtLWRpc3BsYXktd29ybGQtbGlzdAogCSAgbGVnYWN5LXN0eWxlLXdvcmxk LWxpc3QKIAl6b25laW5mby1zdHlsZS13b3JsZC1saXN0KSkpKQogCi0oZGVmY3VzdG9tIGRpc3Bs YXktdGltZS13b3JsZC10aW1lLWZvcm1hdCAiJUEgJWQgJUIgJVIgJVoiCi0gICJGb3JtYXQgb2Yg dGhlIHRpbWUgZGlzcGxheWVkLCBzZWUgYGZvcm1hdC10aW1lLXN0cmluZycuIgotICA6Z3JvdXAg J2Rpc3BsYXktdGltZQorKGRlZmN1c3RvbSB3b3JsZC1jbG9jay10aW1lLWZvcm1hdCAiJUEgJWQg JUIgJVIgJVoiCisgICJUaW1lIGZvcm1hdCBmb3IgYHdvcmxkLWNsb2NrJywgc2VlIGBmb3JtYXQt dGltZS1zdHJpbmcnLiIKKyAgOmdyb3VwICd3b3JsZC1jbG9jawogICA6dHlwZSAnc3RyaW5nCi0g IDp2ZXJzaW9uICIyMy4xIikKKyAgOnZlcnNpb24gIjI4LjEiKQogCi0oZGVmY3VzdG9tIGRpc3Bs YXktdGltZS13b3JsZC1idWZmZXItbmFtZSAiKndjbG9jayoiCi0gICJOYW1lIG9mIHRoZSB3b3Js ZCBjbG9jayBidWZmZXIuIgotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZQorKGRlZmN1c3RvbSB3b3Js ZC1jbG9jay1idWZmZXItbmFtZSAiKndjbG9jayoiCisgICJOYW1lIG9mIHRoZSBgd29ybGQtY2xv Y2snIGJ1ZmZlci4iCisgIDpncm91cCAnd29ybGQtY2xvY2sKICAgOnR5cGUgJ3N0cmluZwotICA6 dmVyc2lvbiAiMjMuMSIpCisgIDp2ZXJzaW9uICIyOC4xIikKIAotKGRlZmN1c3RvbSBkaXNwbGF5 LXRpbWUtd29ybGQtdGltZXItZW5hYmxlIHQKLSAgIklmIG5vbi1uaWwsIGEgdGltZXIgd2lsbCB1 cGRhdGUgdGhlIHdvcmxkIGNsb2NrLiIKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKKyhkZWZjdXN0 b20gd29ybGQtY2xvY2stdGltZXItZW5hYmxlIHQKKyAgIklmIG5vbi1uaWwsIGEgdGltZXIgd2ls bCB1cGRhdGUgdGhlIGB3b3JsZC1jbG9jaycgYnVmZmVyLiIKKyAgOmdyb3VwICd3b3JsZC1jbG9j awogICA6dHlwZSAnYm9vbGVhbgotICA6dmVyc2lvbiAiMjMuMSIpCisgIDp2ZXJzaW9uICIyOC4x IikKIAotKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtd29ybGQtdGltZXItc2Vjb25kIDYwCi0gICJJ bnRlcnZhbCBpbiBzZWNvbmRzIGZvciB1cGRhdGluZyB0aGUgd29ybGQgY2xvY2suIgotICA6Z3Jv dXAgJ2Rpc3BsYXktdGltZQorKGRlZmN1c3RvbSB3b3JsZC1jbG9jay10aW1lci1zZWNvbmQgNjAK KyAgIkludGVydmFsIGluIHNlY29uZHMgZm9yIHVwZGF0aW5nIHRoZSBgd29ybGQtY2xvY2snIGJ1 ZmZlci4iCisgIDpncm91cCAnd29ybGQtY2xvY2sKICAgOnR5cGUgJ2ludGVnZXIKLSAgOnZlcnNp b24gIjIzLjEiKQorICA6dmVyc2lvbiAiMjguMSIpCiAKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4g ZGlzcGxheS10aW1lICgpCkBAIC01MDgsMTggKzUxMCw0MyBAQCBkaXNwbGF5LXRpbWUtbW9kZQog ICAgIChyZW1vdmUtaG9vayAncm1haWwtYWZ0ZXItZ2V0LW5ldy1tYWlsLWhvb2sKIAkJICdkaXNw bGF5LXRpbWUtZXZlbnQtaGFuZGxlcikpKQogCi0KLShkZWZmYWNlIGRpc3BsYXktdGltZS13b3Js ZC1sYWJlbAorDAorOzs7IE9ic29sZXRlIG5hbWVzCisKKyhkZWZpbmUtb2Jzb2xldGUtdmFyaWFi bGUtYWxpYXMgJ2Rpc3BsYXktdGltZS13b3JsZC1saXN0CisgICd3b3JsZC1jbG9jay1saXN0ICIy OC4xIikKKyhkZWZpbmUtb2Jzb2xldGUtdmFyaWFibGUtYWxpYXMgJ2Rpc3BsYXktdGltZS13b3Js ZC10aW1lLWZvcm1hdAorICAnd29ybGQtY2xvY2stdGltZS1mb3JtYXQgIjI4LjEiKQorKGRlZmlu ZS1vYnNvbGV0ZS12YXJpYWJsZS1hbGlhcyAnZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1l CisgICd3b3JsZC1jbG9jay1idWZmZXItbmFtZSAiMjguMSIpCisoZGVmaW5lLW9ic29sZXRlLXZh cmlhYmxlLWFsaWFzICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXItZW5hYmxlCisgICd3b3JsZC1j bG9jay10aW1lci1lbmFibGUgIjI4LjEiKQorKGRlZmluZS1vYnNvbGV0ZS12YXJpYWJsZS1hbGlh cyAnZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyLXNlY29uZAorICAnd29ybGQtY2xvY2stdGltZXIt c2Vjb25kICIyOC4xIikKKworKGRlZmluZS1vYnNvbGV0ZS1mdW5jdGlvbi1hbGlhcyAnZGlzcGxh eS10aW1lLXdvcmxkLW1vZGUKKyAgIyd3b3JsZC1jbG9jay1tb2RlICIyOC4xIikKKyhkZWZpbmUt b2Jzb2xldGUtZnVuY3Rpb24tYWxpYXMgJ2Rpc3BsYXktdGltZS13b3JsZC1kaXNwbGF5CisgICMn d29ybGQtY2xvY2stZGlzcGxheSAiMjguMSIpCisoZGVmaW5lLW9ic29sZXRlLWZ1bmN0aW9uLWFs aWFzICdkaXNwbGF5LXRpbWUtd29ybGQKKyAgIyd3b3JsZC1jbG9jayAiMjguMSIpCisoZGVmaW5l LW9ic29sZXRlLWZ1bmN0aW9uLWFsaWFzICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIKKyAgIyd3 b3JsZC1jbG9jay11cGRhdGUgIjI4LjEiKQorCisMCis7OzsgV29ybGQgY2xvY2sKKworKGRlZmZh Y2Ugd29ybGQtY2xvY2stbGFiZWwKICAgJygodCA6aW5oZXJpdCBmb250LWxvY2stdmFyaWFibGUt bmFtZS1mYWNlKSkKLSAgIkZhY2UgZm9yIHRpbWUgem9uZSBsYWJlbC4iKQorICAiRmFjZSBmb3Ig dGltZSB6b25lIGxhYmVsIGluIGB3b3JsZC1jbG9jaycgYnVmZmVyLiIpCiAKLShkZWZpbmUtZGVy aXZlZC1tb2RlIGRpc3BsYXktdGltZS13b3JsZC1tb2RlIHNwZWNpYWwtbW9kZSAiV29ybGQgY2xv Y2siCisoZGVmaW5lLWRlcml2ZWQtbW9kZSB3b3JsZC1jbG9jay1tb2RlIHNwZWNpYWwtbW9kZSAi V29ybGQgY2xvY2siCiAgICJNYWpvciBtb2RlIGZvciBidWZmZXIgdGhhdCBkaXNwbGF5cyB0aW1l cyBpbiB2YXJpb3VzIHRpbWUgem9uZXMuCiBTZWUgYGRpc3BsYXktdGltZS13b3JsZCcuIgogICAo c2V0cSByZXZlcnQtYnVmZmVyLWZ1bmN0aW9uICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIpCiAg IChzZXRxIHNob3ctdHJhaWxpbmctd2hpdGVzcGFjZSBuaWwpKQogCi0oZGVmdW4gZGlzcGxheS10 aW1lLXdvcmxkLWRpc3BsYXkgKGFsaXN0KQorKGRlZnVuIHdvcmxkLWNsb2NrLWRpc3BsYXkgKGFs aXN0KQogICAiUmVwbGFjZSBjdXJyZW50IGJ1ZmZlciB0ZXh0IHdpdGggdGltZXMgaW4gdmFyaW91 cyB6b25lcywgYmFzZWQgb24gQUxJU1QuIgogICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkgdCkK IAkoYnVmZmVyLXVuZG8tbGlzdCB0KQpAQCAtNTMxLDcgKzU1OCw3IEBAIGRpc3BsYXktdGltZS13 b3JsZC1kaXNwbGF5CiAgICAgICAobGV0KiAoKGxhYmVsIChjYWRyIHpvbmUpKQogCSAgICAgKHdp ZHRoIChzdHJpbmctd2lkdGggbGFiZWwpKSkKIAkocHVzaCAoY29ucyBsYWJlbAotCQkgICAgKGZv cm1hdC10aW1lLXN0cmluZyBkaXNwbGF5LXRpbWUtd29ybGQtdGltZS1mb3JtYXQKKwkJICAgIChm b3JtYXQtdGltZS1zdHJpbmcgd29ybGQtY2xvY2stdGltZS1mb3JtYXQKIAkJCQkJbm93IChjYXIg em9uZSkpKQogCSAgICAgIHJlc3VsdCkKIAkod2hlbiAoPiB3aWR0aCBtYXgtd2lkdGgpCkBAIC01 NDAsMzUgKzU2NywzNiBAQCBkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheQogICAgIChkb2xpc3Qg KHRpbWVkYXRhIChucmV2ZXJzZSByZXN1bHQpKQogICAgICAgKGluc2VydCAoZm9ybWF0IGZtdAog ICAgICAgICAgICAgICAgICAgICAgIChwcm9wZXJ0aXplIChjYXIgdGltZWRhdGEpCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2ZhY2UgJ2Rpc3BsYXktdGltZS13b3JsZC1sYWJl bCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnZmFjZSAnd29ybGQtY2xvY2st bGFiZWwpCiAgICAgICAgICAgICAgICAgICAgICAgKGNkciB0aW1lZGF0YSkpKSkKICAgICAoZGVs ZXRlLWNoYXIgLTEpKQogICAoZ290by1jaGFyIChwb2ludC1taW4pKSkKIAogOzs7IyMjYXV0b2xv YWQKLShkZWZ1biBkaXNwbGF5LXRpbWUtd29ybGQgKCkKLSAgIkVuYWJsZSB1cGRhdGluZyBkaXNw bGF5IG9mIHRpbWVzIGluIHZhcmlvdXMgdGltZSB6b25lcy4KLWBkaXNwbGF5LXRpbWUtd29ybGQt bGlzdCcgc3BlY2lmaWVzIHRoZSB6b25lcy4KLVRvIHR1cm4gb2ZmIHRoZSB3b3JsZCB0aW1lIGRp c3BsYXksIGdvIHRvIHRoYXQgd2luZG93IGFuZCB0eXBlIGBcXFtxdWl0LXdpbmRvd10nLiIKKyhk ZWZ1biB3b3JsZC1jbG9jayAoKQorICAiRGlzcGxheSBhIHdvcmxkIGNsb2NrIGJ1ZmZlciB3aXRo IHRpbWVzIGluIHZhcmlvdXMgdGltZSB6b25lcy4KK1RoZSB2YXJpYWJsZSBgd29ybGQtY2xvY2st bGlzdCcgc3BlY2lmaWVzIHdoaWNoIHRpbWUgem9uZXMgdG8gdXNlLgorVG8gdHVybiBvZmYgdGhl IHdvcmxkIHRpbWUgZGlzcGxheSwgZ28gdG8gdGhlIHdpbmRvdyBhbmQgdHlwZSBgXFxbcXVpdC13 aW5kb3ddJy4iCiAgIChpbnRlcmFjdGl2ZSkKLSAgKHdoZW4gKGFuZCBkaXNwbGF5LXRpbWUtd29y bGQtdGltZXItZW5hYmxlCi0gICAgICAgICAgICAgKG5vdCAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRp bWUtd29ybGQtYnVmZmVyLW5hbWUpKSkKLSAgICAocnVuLWF0LXRpbWUgdCBkaXNwbGF5LXRpbWUt d29ybGQtdGltZXItc2Vjb25kICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIpKQotICAocG9wLXRv LWJ1ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCi0gIChkaXNwbGF5LXRpbWUt d29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkKLSAgKGRpc3BsYXktdGlt ZS13b3JsZC1tb2RlKQorICAod2hlbiAoYW5kIHdvcmxkLWNsb2NrLXRpbWVyLWVuYWJsZQorICAg ICAgICAgICAgIChub3QgKGdldC1idWZmZXIgd29ybGQtY2xvY2stYnVmZmVyLW5hbWUpKSkKKyAg ICAocnVuLWF0LXRpbWUgdCB3b3JsZC1jbG9jay10aW1lci1zZWNvbmQgIyd3b3JsZC1jbG9jay11 cGRhdGUpKQorICAocG9wLXRvLWJ1ZmZlciB3b3JsZC1jbG9jay1idWZmZXItbmFtZSkKKyAgKHdv cmxkLWNsb2NrLWRpc3BsYXkgKHRpbWUtLWRpc3BsYXktd29ybGQtbGlzdCkpCisgICh3b3JsZC1j bG9jay1tb2RlKQogICAoZml0LXdpbmRvdy10by1idWZmZXIpKQogCi0oZGVmdW4gZGlzcGxheS10 aW1lLXdvcmxkLXRpbWVyICgpCi0gIChpZiAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQt YnVmZmVyLW5hbWUpCi0gICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAoZ2V0LWJ1ZmZlciBkaXNw bGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCi0gICAgICAgIChkaXNwbGF5LXRpbWUtd29ybGQt ZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkpCisoZGVmdW4gd29ybGQtY2xvY2st dXBkYXRlICgpCisgICJVcGRhdGUgdGhlIGB3b3JsZC1jbG9jaycgYnVmZmVyLiIKKyAgKGlmIChn ZXQtYnVmZmVyIHdvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lKQorICAgICAgKHdpdGgtY3VycmVudC1i dWZmZXIgKGdldC1idWZmZXIgd29ybGQtY2xvY2stYnVmZmVyLW5hbWUpCisgICAgICAgICh3b3Js ZC1jbG9jay1kaXNwbGF5ICh0aW1lLS1kaXNwbGF5LXdvcmxkLWxpc3QpKSkKICAgICA7OyBjYW5j ZWwgdGltZXIKICAgICAobGV0ICgobGlzdCB0aW1lci1saXN0KSkKICAgICAgICh3aGlsZSBsaXN0 CiAgICAgICAgIChsZXQgKChlbHQgKHBvcCBsaXN0KSkpCiAgICAgICAgICAgKHdoZW4gKGVxdWFs IChzeW1ib2wtbmFtZSAodGltZXItLWZ1bmN0aW9uIGVsdCkpCi0JCSAgICAgICAiZGlzcGxheS10 aW1lLXdvcmxkLXRpbWVyIikKKwkJICAgICAgICJ3b3JsZC1jbG9jay11cGRhdGUiKQogICAgICAg ICAgICAgKGNhbmNlbC10aW1lciBlbHQpKSkpKSkpCiAKIDs7OyMjI2F1dG9sb2FkCi0tIAoyLjI3 LjAKCg== --0000000000006fa1cb05ac4cdb66 Content-Type: text/x-diff; charset="US-ASCII"; name="0003-Rearrange-and-clean-up-code-in-time.el-Bug-40863.patch" Content-Disposition: attachment; filename="0003-Rearrange-and-clean-up-code-in-time.el-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 8c077831b79281a6_0.3 RnJvbSBlMTk3MjVhMTdlYzQyYzRmYzg1YzBjMWJlZjgwZTUyN2NhZTBkZDkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDIgTWF5IDIwMjAgMTc6Mzc6MDYgKzAyMDAKU3ViamVjdDogW1BBVENIIDMv M10gUmVhcnJhbmdlIGFuZCBjbGVhbiB1cCBjb2RlIGluIHRpbWUuZWwgKEJ1ZyM0MDg2MykKCiog bGlzcC90aW1lLmVsICh3b3JsZC1jbG9jaywgem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCkKKGxl Z2FjeS1zdHlsZS13b3JsZC1saXN0LCB3b3JsZC1jbG9jay1saXN0KQoodGltZS0tZGlzcGxheS13 b3JsZC1saXN0LCB3b3JsZC1jbG9jay10aW1lLWZvcm1hdCkKKHdvcmxkLWNsb2NrLXRpbWVyLWVu YWJsZSwgd29ybGQtY2xvY2stdGltZXItc2Vjb25kKTogTW92ZSBkZWZpbml0aW9ucwpjbG9zZXIg dG8gJ3dvcmxkLWNsb2NrJyBjb2RlLiAgUmVtb3ZlIHJlZHVuZGFudCA6Z3JvdXAgYXJncy4KCihk aXNwbGF5LXRpbWUtbWFpbC1maWxlLCBkaXNwbGF5LXRpbWUtbWFpbC1kaXJlY3RvcnkpCihkaXNw bGF5LXRpbWUtbWFpbC1mdW5jdGlvbikKKGRpc3BsYXktdGltZS1kZWZhdWx0LWxvYWQtYXZlcmFn ZSkKKGRpc3BsYXktdGltZS1sb2FkLWF2ZXJhZ2UtdGhyZXNob2xkLCBkaXNwbGF5LXRpbWUtZGF5 LWFuZC1kYXRlKQooZGlzcGxheS10aW1lLWludGVydmFsLCBkaXNwbGF5LXRpbWUtMjRoci1mb3Jt YXQpCihkaXNwbGF5LXRpbWUtaG9vaywgZGlzcGxheS10aW1lLW1haWwtZmFjZSkKKGRpc3BsYXkt dGltZS11c2UtbWFpbC1pY29uLCBkaXNwbGF5LXRpbWUtbWFpbC1zdHJpbmcpCihkaXNwbGF5LXRp bWUtZm9ybWF0LCBkaXNwbGF5LXRpbWUtc3RyaW5nLWZvcm1zKTogUmVtb3ZlIHJlZHVuZGFudAo6 Z3JvdXAgYXJncy4KLS0tCiBsaXNwL3RpbWUuZWwgfCAxMjMgKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOTcgaW5zZXJ0 aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90aW1lLmVsIGIvbGlz cC90aW1lLmVsCmluZGV4IDdjZmYxZTZiNDUuLjdiZWRkMmFkOWEgMTAwNjQ0Ci0tLSBhL2xpc3Av dGltZS5lbAorKysgYi9saXNwL3RpbWUuZWwKQEAgLTM0LDIzICszNCwyMCBAQCBkaXNwbGF5LXRp bWUKICAgOmdyb3VwICdtb2RlLWxpbmUKICAgOmdyb3VwICdtYWlsKQogCi0KIChkZWZjdXN0b20g ZGlzcGxheS10aW1lLW1haWwtZmlsZSBuaWwKICAgIkZpbGUgbmFtZSBvZiBtYWlsIGluYm94IGZp bGUsIGZvciBpbmRpY2F0aW5nIGV4aXN0ZW5jZSBvZiBuZXcgbWFpbC4KIE5vbi1uaWwgYW5kIG5v dCBhIHN0cmluZyBtZWFucyBkb24ndCBjaGVjayBmb3IgbWFpbDsgbmlsIG1lYW5zIHVzZQogZGVm YXVsdCwgd2hpY2ggaXMgc3lzdGVtLWRlcGVuZGVudCwgYW5kIGlzIHRoZSBzYW1lIGFzIHVzZWQg YnkgUm1haWwuIgogICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiTm9uZSIgbm9uZSkKIAkJ IChjb25zdCA6dGFnICJEZWZhdWx0IiBuaWwpCi0JCSAoZmlsZSA6Zm9ybWF0ICIldiIpKQotICA6 Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKwkJIChmaWxlIDpmb3JtYXQgIiV2IikpKQogCiAoZGVmY3Vz dG9tIGRpc3BsYXktdGltZS1tYWlsLWRpcmVjdG9yeSBuaWwKICAgIk5hbWUgb2YgbWFpbCBpbmJv eCBkaXJlY3RvcnksIGZvciBpbmRpY2F0aW5nIGV4aXN0ZW5jZSBvZiBuZXcgbWFpbC4KIEFueSBu b25lbXB0eSByZWd1bGFyIGZpbGUgaW4gdGhlIGRpcmVjdG9yeSBpcyByZWdhcmRlZCBhcyBuZXds eSBhcnJpdmVkIG1haWwuCiBJZiBuaWwsIGRvIG5vdCBjaGVjayBhIGRpcmVjdG9yeSBmb3IgYXJy aXZpbmcgbWFpbC4iCiAgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJOb25lIiBuaWwpCi0J CSAoZGlyZWN0b3J5IDpmb3JtYXQgIiV2IikpCi0gIDpncm91cCAnZGlzcGxheS10aW1lKQorCQkg KGRpcmVjdG9yeSA6Zm9ybWF0ICIldiIpKSkKIAogKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtbWFp bC1mdW5jdGlvbiBuaWwKICAgIkZ1bmN0aW9uIHRvIGNhbGwsIGZvciBpbmRpY2F0aW5nIGV4aXN0 ZW5jZSBvZiBuZXcgbWFpbC4KQEAgLTU4LDggKzU1LDcgQEAgZGlzcGxheS10aW1lLW1haWwtZnVu Y3Rpb24KIHNwZWNpZmllZCBieSBgZGlzcGxheS10aW1lLW1haWwtZmlsZScgaXMgbm9uZW1wdHkg b3IgdGhhdCB0aGUKIGRpcmVjdG9yeSBgZGlzcGxheS10aW1lLW1haWwtZGlyZWN0b3J5JyBjb250 YWlucyBub25lbXB0eSBmaWxlcy4iCiAgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJEZWZh dWx0IiBuaWwpCi0JCSAoZnVuY3Rpb24pKQotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKwkJIChm dW5jdGlvbikpKQogCiAoZGVmY3VzdG9tIGRpc3BsYXktdGltZS1kZWZhdWx0LWxvYWQtYXZlcmFn ZSAwCiAgICJXaGljaCBsb2FkIGF2ZXJhZ2UgdmFsdWUgd2lsbCBiZSBzaG93biBpbiB0aGUgbW9k ZSBsaW5lLgpAQCAtNzQsOCArNzAsNyBAQCBkaXNwbGF5LXRpbWUtZGVmYXVsdC1sb2FkLWF2ZXJh Z2UKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIjEgbWludXRlIGxvYWQiIDApCiAJCSAo Y29uc3QgOnRhZyAiNSBtaW51dGVzIGxvYWQiIDEpCiAJCSAoY29uc3QgOnRhZyAiMTUgbWludXRl cyBsb2FkIiAyKQotCQkgKGNvbnN0IDp0YWcgIk5vbmUiIG5pbCkpCi0gIDpncm91cCAnZGlzcGxh eS10aW1lKQorCQkgKGNvbnN0IDp0YWcgIk5vbmUiIG5pbCkpKQogCiAoZGVmdmFyIGRpc3BsYXkt dGltZS1sb2FkLWF2ZXJhZ2UgbmlsCiAgICJWYWx1ZSBvZiB0aGUgc3lzdGVtJ3MgbG9hZCBhdmVy YWdlIGN1cnJlbnRseSBzaG93biBvbiB0aGUgbW9kZSBsaW5lLgpAQCAtODUsMjcgKzgwLDIzIEBA IGRpc3BsYXktdGltZS1sb2FkLWF2ZXJhZ2UKIAogKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtbG9h ZC1hdmVyYWdlLXRocmVzaG9sZCAwLjEKICAgIkxvYWQtYXZlcmFnZSB2YWx1ZXMgYmVsb3cgdGhp cyB2YWx1ZSB3b24ndCBiZSBzaG93biBpbiB0aGUgbW9kZSBsaW5lLiIKLSAgOnR5cGUgJ251bWJl cgotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKyAgOnR5cGUgJ251bWJlcikKIAogOzs7IyMjYXV0 b2xvYWQKIChkZWZjdXN0b20gZGlzcGxheS10aW1lLWRheS1hbmQtZGF0ZSBuaWwgIlwKIE5vbi1u aWwgbWVhbnMgXFxbZGlzcGxheS10aW1lXSBzaG91bGQgZGlzcGxheSBkYXkgYW5kIGRhdGUgYXMg d2VsbCBhcyB0aW1lLiIKLSAgOnR5cGUgJ2Jvb2xlYW4KLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUp CisgIDp0eXBlICdib29sZWFuKQogCiAoZGVmdmFyIGRpc3BsYXktdGltZS10aW1lciBuaWwpCiAK IChkZWZjdXN0b20gZGlzcGxheS10aW1lLWludGVydmFsIDYwCiAgICJTZWNvbmRzIGJldHdlZW4g dXBkYXRlcyBvZiB0aW1lIGluIHRoZSBtb2RlIGxpbmUuIgotICA6dHlwZSAnaW50ZWdlcgotICA6 Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKyAgOnR5cGUgJ2ludGVnZXIpCiAKIChkZWZjdXN0b20gZGlz cGxheS10aW1lLTI0aHItZm9ybWF0IG5pbAogICAiTm9uLW5pbCBpbmRpY2F0ZXMgdGltZSBzaG91 bGQgYmUgZGlzcGxheWVkIGFzIGhoOm1tLCAwIDw9IGhoIDw9IDIzLgogQSB2YWx1ZSBvZiBuaWwg bWVhbnMgMSA8PSBoaCA8PSAxMiwgYW5kIGFuIEFNL1BNIHN1ZmZpeCBpcyB1c2VkLiIKLSAgOnR5 cGUgJ2Jvb2xlYW4KLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCisgIDp0eXBlICdib29sZWFuKQog CiAoZGVmdmFyIGRpc3BsYXktdGltZS1zdHJpbmcgbmlsCiAgICJTdHJpbmcgdXNlZCBpbiBtb2Rl IGxpbmVzIHRvIGRpc3BsYXkgYSB0aW1lIHN0cmluZy4KQEAgLTExNSw4ICsxMDYsNyBAQCBkaXNw bGF5LXRpbWUtc3RyaW5nCiAKIChkZWZjdXN0b20gZGlzcGxheS10aW1lLWhvb2sgbmlsCiAgICJM aXN0IG9mIGZ1bmN0aW9ucyB0byBiZSBjYWxsZWQgd2hlbiB0aGUgdGltZSBpcyB1cGRhdGVkIG9u IHRoZSBtb2RlIGxpbmUuIgotICA6dHlwZSAnaG9vawotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZSkK KyAgOnR5cGUgJ2hvb2spCiAKIChkZWZ2YXIgZGlzcGxheS10aW1lLXNlcnZlci1kb3duLXRpbWUg bmlsCiAgICAiVGltZSB3aGVuIG1haWwgZmlsZSdzIGZpbGUgc3lzdGVtIHdhcyByZWNvcmRlZCB0 byBiZSBkb3duLgpAQCAtMjM2LDcgKzIyNiw2IEBAIGRpc3BsYXktdGltZS1tYWlsLWZhY2UKIGJh Y2tncm91bmQgY29sb3IgaXMgdGhlIGJhY2tncm91bmQgb2YgdGhpcyBmYWNlLiAgU2V0IHRoaXMg dG8KIG1ha2UgdGhlIG1haWwgaW5kaWNhdG9yIHN0YW5kIG91dCBvbiBhIGNvbG9yIGRpc3BsYXku IgogICA6Z3JvdXAgJ21vZGUtbGluZS1mYWNlcwotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZQogICA6 dmVyc2lvbiAiMjIuMSIKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIk5vbmUiIG5pbCkg ZmFjZSkpCiAKQEAgLTI1MSwxNCArMjQwLDEyIEBAIGRpc3BsYXktdGltZS11c2UtbWFpbC1pY29u CiAgICJOb24tbmlsIG1lYW5zIHVzZSBhbiBpY29uIGFzIG1haWwgaW5kaWNhdG9yIG9uIGEgZ3Jh cGhpYyBkaXNwbGF5LgogT3RoZXJ3aXNlIHVzZSBgZGlzcGxheS10aW1lLW1haWwtc3RyaW5nJy4g IFRoZSBpY29uIG1heSBjb25zdW1lIGxlc3MKIG9mIHRoZSBtb2RlIGxpbmUuICBJdCBpcyBzcGVj aWZpZWQgYnkgYGRpc3BsYXktdGltZS1tYWlsLWljb24nLiIKLSAgOmdyb3VwICdkaXNwbGF5LXRp bWUKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKIDs7IEZpeG1lOiBtYXliZSBkZWZhdWx0IHRvIHRoZSBj aGFyYWN0ZXIgaWYgd2UgY2FuIGRpc3BsYXkgVW5pY29kZS4KIChkZWZjdXN0b20gZGlzcGxheS10 aW1lLW1haWwtc3RyaW5nICJNYWlsIgogICAiU3RyaW5nIHRvIHVzZSBhcyB0aGUgbWFpbCBpbmRp Y2F0b3IgaW4gYGRpc3BsYXktdGltZS1zdHJpbmctZm9ybXMnLgogVGhpcyBjYW4gdXNlIHRoZSBV bmljb2RlIGxldHRlciBjaGFyYWN0ZXIgaWYgeW91IGNhbiBkaXNwbGF5IGl0LiIKLSAgOmdyb3Vw ICdkaXNwbGF5LXRpbWUKICAgOnZlcnNpb24gIjIyLjEiCiAgIDp0eXBlICcoY2hvaWNlIChjb25z dCAiTWFpbCIpCiAJCSA7OyBVc2UgOnRhZyBoZXJlIGJlY2F1c2UgdGhlIEx1Y2lkIG1lbnUgd29u J3QgZGlzcGxheQpAQCAtMjcyLDggKzI1OSw3IEBAIGRpc3BsYXktdGltZS1mb3JtYXQKIGhvdyB0 byB3cml0ZSB0aGlzIHN0cmluZy4gIElmIHRoaXMgaXMgbmlsLCB0aGUgZGVmYXVsdHMKIGRlcGVu ZCBvbiBgZGlzcGxheS10aW1lLWRheS1hbmQtZGF0ZScgYW5kIGBkaXNwbGF5LXRpbWUtMjRoci1m b3JtYXQnLiIKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRlZmF1bHQiIG5pbCkKLQkJ IHN0cmluZykKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCisJCSBzdHJpbmcpKQogCiAoZGVmY3Vz dG9tIGRpc3BsYXktdGltZS1zdHJpbmctZm9ybXMKICAgJygoaWYgKGFuZCAobm90IGRpc3BsYXkt dGltZS1mb3JtYXQpIGRpc3BsYXktdGltZS1kYXktYW5kLWRhdGUpCkBAIC0zMjcsOCArMzEzLDcg QEAgZGlzcGxheS10aW1lLXN0cmluZy1mb3JtcwogICAgIChpZiBtYWlsIFwiIE1haWxcIiBcIlwi KSkKIAogd291bGQgZ2l2ZSBtb2RlIGxpbmUgdGltZXMgbGlrZSBgOTQvMTIvMzAgMjE6MDc6NDgg KFVUQyknLiIKLSAgOnR5cGUgJyhyZXBlYXQgc2V4cCkKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUp CisgIDp0eXBlICcocmVwZWF0IHNleHApKQogCiAoZGVmdW4gZGlzcGxheS10aW1lLWV2ZW50LWhh bmRsZXIgKCkKICAgKGRpc3BsYXktdGltZS11cGRhdGUpCkBAIC01MzYsNiArNTIxLDkyIEBAICdk aXNwbGF5LXRpbWUtd29ybGQtdGltZXIKIAwKIDs7OyBXb3JsZCBjbG9jawogCisoZGVmZ3JvdXAg d29ybGQtY2xvY2sgbmlsCisgICJEaXNwbGF5IGEgd29ybGQgY2xvY2suIgorICA6Z3JvdXAgJ2Rp c3BsYXktdGltZSkKKworKGRlZmN1c3RvbSB6b25laW5mby1zdHlsZS13b3JsZC1saXN0CisgICco KCJBbWVyaWNhL0xvc19BbmdlbGVzIiAiU2VhdHRsZSIpCisgICAgKCJBbWVyaWNhL05ld19Zb3Jr IiAiTmV3IFlvcmsiKQorICAgICgiRXVyb3BlL0xvbmRvbiIgIkxvbmRvbiIpCisgICAgKCJFdXJv cGUvUGFyaXMiICJQYXJpcyIpCisgICAgKCJBc2lhL0NhbGN1dHRhIiAiQmFuZ2Fsb3JlIikKKyAg ICAoIkFzaWEvVG9reW8iICJUb2t5byIpKQorICAiQWxpc3Qgb2Ygem9uZWluZm8tc3R5bGUgdGlt ZSB6b25lcyBhbmQgcGxhY2VzIGZvciBgd29ybGQtY2xvY2snLgorRWFjaCBlbGVtZW50IGhhcyB0 aGUgZm9ybSAoVElNRVpPTkUgTEFCRUwpLgorVElNRVpPTkUgc2hvdWxkIGJlIGEgc3RyaW5nIG9m IHRoZSBmb3JtIEFSRUEvTE9DQVRJT04sIHdoZXJlIEFSRUEgaXMKK3RoZSBuYW1lIG9mIGEgcmVn aW9uIC0tIGEgY29udGluZW50IG9yIG9jZWFuLCBhbmQgTE9DQVRJT04gaXMgdGhlIG5hbWUKK29m IGEgc3BlY2lmaWMgbG9jYXRpb24sIGUuZy4sIGEgY2l0eSwgd2l0aGluIHRoYXQgcmVnaW9uLgor TEFCRUwgaXMgYSBzdHJpbmcgdG8gZGlzcGxheSBhcyB0aGUgbGFiZWwgb2YgdGhhdCBUSU1FWk9O RSdzIHRpbWUuIgorICA6dHlwZSAnKHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5nKSkKKyAgOnZl cnNpb24gIjIzLjEiKQorCisoZGVmY3VzdG9tIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0CisgICco KCJQU1Q4UERUIiAiU2VhdHRsZSIpCisgICAgKCJFU1Q1RURUIiAiTmV3IFlvcmsiKQorICAgICgi R01UMEJTVCIgIkxvbmRvbiIpCisgICAgKCJDRVQtMUNEVCIgIlBhcmlzIikKKyAgICAoIklTVC01 OjMwIiAiQmFuZ2Fsb3JlIikKKyAgICAoIkpTVC05IiAiVG9reW8iKSkKKyAgIkFsaXN0IG9mIHRy YWRpdGlvbmFsLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYHdvcmxkLWNsb2NrJy4K K0VhY2ggZWxlbWVudCBoYXMgdGhlIGZvcm0gKFRJTUVaT05FIExBQkVMKS4KK1RJTUVaT05FIHNo b3VsZCBiZSBhIHN0cmluZyBvZiB0aGUgZm9ybToKKworICAgICBzdGRbK3wtXW9mZnNldFtkc3Rb b2Zmc2V0XVssZGF0ZVsvdGltZV0sZGF0ZVsvdGltZV1dXQorCitTZWUgdGhlIGRvY3VtZW50YXRp b24gb2YgdGhlIFRaIGVudmlyb25tZW50IHZhcmlhYmxlIG9uIHlvdXIgc3lzdGVtLAorZm9yIG1v cmUgZGV0YWlscyBhYm91dCB0aGUgZm9ybWF0IG9mIFRJTUVaT05FLgorTEFCRUwgaXMgYSBzdHJp bmcgdG8gZGlzcGxheSBhcyB0aGUgbGFiZWwgb2YgdGhhdCBUSU1FWk9ORSdzIHRpbWUuIgorICA6 dHlwZSAnKHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5nKSkKKyAgOnZlcnNpb24gIjIzLjEiKQor CisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLWxpc3QgdAorICAiQWxpc3Qgb2YgdGltZSB6b25lcyBh bmQgcGxhY2VzIGZvciBgd29ybGQtY2xvY2snIHRvIGRpc3BsYXkuCitFYWNoIGVsZW1lbnQgaGFz IHRoZSBmb3JtIChUSU1FWk9ORSBMQUJFTCkuCitUSU1FWk9ORSBzaG91bGQgYmUgaW4gYSBmb3Jt YXQgc3VwcG9ydGVkIGJ5IHlvdXIgc3lzdGVtLiAgU2VlIHRoZQorZG9jdW1lbnRhdGlvbiBvZiBg em9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCcgYW5kCitgbGVnYWN5LXN0eWxlLXdvcmxkLWxpc3Qn IGZvciB0d28gd2lkZWx5IHVzZWQgZm9ybWF0cy4gIExBQkVMIGlzCithIHN0cmluZyB0byBkaXNw bGF5IGFzIHRoZSBsYWJlbCBvZiB0aGF0IFRJTUVaT05FJ3MgdGltZS4KKworSWYgdGhlIHZhbHVl IGlzIHQgaW5zdGVhZCBvZiBhbiBhbGlzdCwgdXNlIHRoZSB2YWx1ZSBvZgorYHpvbmVpbmZvLXN0 eWxlLXdvcmxkLWxpc3QnIGlmIGl0IHdvcmtzIG9uIHRoaXMgcGxhdGZvcm0sIGFuZCBvZgorYGxl Z2FjeS1zdHlsZS13b3JsZC1saXN0JyBvdGhlcndpc2UuIgorICA6dHlwZSAnKGNob2ljZSAoY29u c3QgOnRhZyAiRGVmYXVsdCIgdCkKKyAgICAgICAgICAgICAgICAgKHJlcGVhdCA6dGFnICJMaXN0 IG9mIHpvbmVzIGFuZCBsYWJlbHMiCisgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKHN0 cmluZyA6dGFnICJab25lIikgKHN0cmluZyA6dGFnICJMYWJlbCIpKSkpCisgIDp2ZXJzaW9uICIy OC4xIikKKworKGRlZnVuIHRpbWUtLWRpc3BsYXktd29ybGQtbGlzdCAoKQorICAoaWYgKGxpc3Rw IHdvcmxkLWNsb2NrLWxpc3QpCisgICAgICB3b3JsZC1jbG9jay1saXN0CisgICAgOzsgRGV0ZXJt aW5lIGlmIHpvbmVpbmZvIHN0eWxlIHRpbWV6b25lcyBhcmUgc3VwcG9ydGVkIGJ5IHRlc3Rpbmcg dGhhdAorICAgIDs7IEFtZXJpY2EvTmV3IFlvcmsgYW5kIEV1cm9wZS9Mb25kb24gcmV0dXJuIGRp ZmZlcmVudCB0aW1lem9uZXMuCisgICAgKGxldCAoKG55dCAoZm9ybWF0LXRpbWUtc3RyaW5nICIl eiIgbmlsICJBbWVyaWNhL05ld19Zb3JrIikpCisJICAoZ210IChmb3JtYXQtdGltZS1zdHJpbmcg IiV6IiBuaWwgIkV1cm9wZS9Mb25kb24iKSkpCisgICAgICAoaWYgKHN0cmluZy1lcXVhbCBueXQg Z210KQorCSAgbGVnYWN5LXN0eWxlLXdvcmxkLWxpc3QKKwl6b25laW5mby1zdHlsZS13b3JsZC1s aXN0KSkpKQorCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLXRpbWUtZm9ybWF0ICIlQSAlZCAlQiAl UiAlWiIKKyAgIlRpbWUgZm9ybWF0IGZvciBgd29ybGQtY2xvY2snLCBzZWUgYGZvcm1hdC10aW1l LXN0cmluZycuIgorICA6dHlwZSAnc3RyaW5nCisgIDp2ZXJzaW9uICIyOC4xIikKKworKGRlZmN1 c3RvbSB3b3JsZC1jbG9jay1idWZmZXItbmFtZSAiKndjbG9jayoiCisgICJOYW1lIG9mIHRoZSBg d29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIDp0eXBlICdzdHJpbmcKKyAgOnZlcnNpb24gIjI4LjEi KQorCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLXRpbWVyLWVuYWJsZSB0CisgICJJZiBub24tbmls LCBhIHRpbWVyIHdpbGwgdXBkYXRlIHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIDp0eXBl ICdib29sZWFuCisgIDp2ZXJzaW9uICIyOC4xIikKKworKGRlZmN1c3RvbSB3b3JsZC1jbG9jay10 aW1lci1zZWNvbmQgNjAKKyAgIkludGVydmFsIGluIHNlY29uZHMgZm9yIHVwZGF0aW5nIHRoZSBg d29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIDp0eXBlICdpbnRlZ2VyCisgIDp2ZXJzaW9uICIyOC4x IikKKwogKGRlZmZhY2Ugd29ybGQtY2xvY2stbGFiZWwKICAgJygodCA6aW5oZXJpdCBmb250LWxv Y2stdmFyaWFibGUtbmFtZS1mYWNlKSkKICAgIkZhY2UgZm9yIHRpbWUgem9uZSBsYWJlbCBpbiBg d29ybGQtY2xvY2snIGJ1ZmZlci4iKQotLSAKMi4yNy4wCgo= --0000000000006fa1cb05ac4cdb66-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 07 13:51:45 2020 Received: (at 40863) by debbugs.gnu.org; 7 Aug 2020 17:51:45 +0000 Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46Wv-0003Il-8u for submit@debbugs.gnu.org; Fri, 07 Aug 2020 13:51:45 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:37609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46Wt-0003IY-4W for 40863@debbugs.gnu.org; Fri, 07 Aug 2020 13:51:43 -0400 Received: by mail-wm1-f44.google.com with SMTP id k8so2642794wma.2 for <40863@debbugs.gnu.org>; Fri, 07 Aug 2020 10:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2Fz3sHzJXQANt84NNMVccB1AvK4rgt2P9hlSvImWFHw=; b=LZmITsRb5saAeR4QlzanWqlvVum/crHtT+zV+GmaXcB/sOS7Nf/j42wYDBZkzOqcul TZcXeVnRwz1D/dflabdFl0avdqpl2HZ5zq+6JZm18zMpCnCyHFBluQf2UC/zlBJlrJ+F 4tHthVxGVJ4dS29eD6TMYKo2KdKgG9vQbKndbG/T6c8VMJJsi3mrNh3OxCA/s1XcXFP9 L9R2Pn//5vrkc0Ove1GOwZrEGGOlzBpA6VAT+2+n9mNE+flzfITFattklbK7oCw5Jlt7 Plru37oqCdZXo9NpLIqCQAd3n+hYS7oUStxZ5K1lTXKZLujyOG1h/QLDTzzQ34BMgZlY /9Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2Fz3sHzJXQANt84NNMVccB1AvK4rgt2P9hlSvImWFHw=; b=qU14VHuJSMFXBLCNVPhZCdSHLdYtYEg91QmZAY0D9FhlPZpZXQcSR1tsYNOdd1ISoO MjvPtWXx2gxQXepOc3vYWQBr2D4IuX0e9IqNvVoHEpuPt2P/Tsx2tFqAwNhTSZCm+nwC kUmPBxheDbR/rJV+rutvh8A7kzoeK8VYrXSxDONe7qVsmEQiwhl3iB4ByqRwbMDV9TGi YhKDrv7ZWs3MPInE8990mJ6O6SB4rvvKhwEcGD3dUzeYn8gElNikaN4LuBzsBFr5ehoz 4W305OOUCgezEbQVBz72II0s0r/XHdhyfhyfouO16VJmv47LBqwPc9nH31wJerH1bD5y nzjA== X-Gm-Message-State: AOAM531ROrlCW6jERE61tvy0MTQZQFV7xcvorFFl4jo7Z5oapAyXvQEy N041nvShxW1NR7HqlP6KiuwbSFEmfCk= X-Google-Smtp-Source: ABdhPJxeszQoBeXamBAkoflD7toOG/HupRCHssGO9l+F6qkrE7k+lslmQpkU6XpeR2CqaNMHitbGhQ== X-Received: by 2002:a1c:4104:: with SMTP id o4mr13653861wma.101.1596822696972; Fri, 07 Aug 2020 10:51:36 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id 8sm11643983wrl.7.2020.08.07.10.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 10:51:36 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> Date: Fri, 07 Aug 2020 18:51:35 +0100 In-Reply-To: (Stefan Kangas's message of "Fri, 7 Aug 2020 10:23:01 -0700") Message-ID: <878seqgx94.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Thank you for the detailed review! I believe I have fixed all your > comments in the attached patches. (Note that I squashed patch 2 and 3 > into one patch.) > > Please let me know if there are any further comments. Thanks, we're close. ;) See below. > Subject: [PATCH 1/3] Improve display-time-world UI (Bug#40863) [...] > (define-derived-mode display-time-world-mode special-mode "World clock" > "Major mode for buffer that displays times in various time zones. > See `display-time-world'." > + (setq revert-buffer-function 'display-time-world-timer) ^ Nit: #' More importantly, doesn't revert-buffer-function need two parameters? [...] > Subject: [PATCH 3/3] Rearrange and clean up code in time.el (Bug#40863) > > * lisp/time.el (world-clock, zoneinfo-style-world-list) > (legacy-style-world-list, world-clock-list) > (time--display-world-list, world-clock-time-format) > (world-clock-timer-enable, world-clock-timer-second): Move definitions > closer to 'world-clock' code. Unless I'm misreading it, the patch you attached seems to be adding duplicate definitions rather than moving them. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 18:11:17 2020 Received: (at 40863) by debbugs.gnu.org; 9 Aug 2020 22:11:18 +0000 Received: from localhost ([127.0.0.1]:33648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4tXA-0006dZ-Nv for submit@debbugs.gnu.org; Sun, 09 Aug 2020 18:11:17 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:41975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4tX6-0006dE-Qk for 40863@debbugs.gnu.org; Sun, 09 Aug 2020 18:11:15 -0400 Received: by mail-yb1-f170.google.com with SMTP id s195so2734901ybc.8 for <40863@debbugs.gnu.org>; Sun, 09 Aug 2020 15:11:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=8VANmRNl+3iXPTVFwn/jUXvpmdEXpchAeNx90GCZNVU=; b=YxJ5tZnYuGwd9kIFOEfOkMUtm+6Gferj/mxbXt20IoEAFC/7j+YSjenE04xzxGb//F g2d1PtGotTh39UbiIT9cHPZVXRvKttds1B6lcwj1/0RXhb0HJCopWXjUFv6pKyH7065C 3ez52fyt6HcfC6JaD+NCeoOvhRh75eWY0u60eR/ZNs6msbS0QBnXe22uCmv1v8/fH4de x6pCXA528eoiiKrpZVvIo1j0nX4EFvr7+rNGZkR822DxfP59fHDuvzGG1hwim1XCyZkj C+KpKmnpdB4TVj1/dmt558QvtR8h8HSyn/dKUBWVm5ckSk56aAI/eFGd9yrbS5OfMY/D HIYw== X-Gm-Message-State: AOAM532/wxlSOi4msFqPDVhE526uD6pmmZPwuCAhH46Z/3EpTCqrCsA6 AFD2XyZC8Qc1WNj6GYh+AYOHcVUgRGfIVtcz6mo= X-Google-Smtp-Source: ABdhPJz5mka+1AaBxKodLmMXZ4SZCPXy2H7IkSISp/PFLTiSvmk8ALOJhCsE9hizGC4mo1k/Aw4P//188zuNYtR5Vk4= X-Received: by 2002:a25:880e:: with SMTP id c14mr36433829ybl.181.1597011067373; Sun, 09 Aug 2020 15:11:07 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Aug 2020 15:11:06 -0700 From: Stefan Kangas In-Reply-To: <878seqgx94.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 07 Aug 2020 18:51:35 +0100") References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> <878seqgx94.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 9 Aug 2020 15:11:06 -0700 Message-ID: Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: "Basil L. Contovounesios" Content-Type: multipart/mixed; boundary="0000000000005fdcb105ac791d15" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005fdcb105ac791d15 Content-Type: text/plain; charset="UTF-8" "Basil L. Contovounesios" writes: >> (define-derived-mode display-time-world-mode special-mode "World clock" >> "Major mode for buffer that displays times in various time zones. >> See `display-time-world'." >> + (setq revert-buffer-function 'display-time-world-timer) > ^ > Nit: #' > > More importantly, doesn't revert-buffer-function need two parameters? Fixed. >> Subject: [PATCH 3/3] Rearrange and clean up code in time.el (Bug#40863) >> >> * lisp/time.el (world-clock, zoneinfo-style-world-list) >> (legacy-style-world-list, world-clock-list) >> (time--display-world-list, world-clock-time-format) >> (world-clock-timer-enable, world-clock-timer-second): Move definitions >> closer to 'world-clock' code. > > Unless I'm misreading it, the patch you attached seems to be adding > duplicate definitions rather than moving them. Uhm, right... Fixed in the attached. Thanks again for the review. Best regards, Stefan Kangas --0000000000005fdcb105ac791d15 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Improve-display-time-world-UI-Bug-40863.patch" Content-Disposition: attachment; filename="0001-Improve-display-time-world-UI-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: b254273990da5c94_0.1 RnJvbSBjN2JiNjQ0OTk4YmVkNzI2MmQ0OTFkZDdjNzNhZjJlZDM0YjVjYTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDI2IEFwciAyMDIwIDEwOjE2OjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSCAx LzNdIEltcHJvdmUgZGlzcGxheS10aW1lLXdvcmxkIFVJIChCdWcjNDA4NjMpCgoqIGxpc3AvdGlt ZS5lbCAoZGlzcGxheS10aW1lLXdvcmxkLW1vZGUpOiBTZXQgJ3JldmVydC1idWZmZXItZnVuY3Rp b24nCnRvICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXInLgoKKGRpc3BsYXktdGltZS13b3JsZC1s YWJlbCk6IE5ldyBmYWNlLgooZGlzcGxheS10aW1lLXdvcmxkLWRpc3BsYXkpOiBVc2UgdGhlIG5l dyBmYWNlLiAgTW92ZSBwb2ludCB0byBuZXcKYnVmZmVyIG9uIGNyZWF0aW9uIGFuZCByZXNpemUu Ci0tLQogbGlzcC90aW1lLmVsIHwgMjMgKysrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvdGltZS5lbCBiL2xpc3AvdGltZS5lbAppbmRleCA0NGZkMWE3ZTMzLi4zNjI1OTQwMzM0IDEw MDY0NAotLS0gYS9saXNwL3RpbWUuZWwKKysrIGIvbGlzcC90aW1lLmVsCkBAIC01MDksOSArNTA5 LDE0IEBAIGRpc3BsYXktdGltZS1tb2RlCiAJCSAnZGlzcGxheS10aW1lLWV2ZW50LWhhbmRsZXIp KSkKIAogCisoZGVmZmFjZSBkaXNwbGF5LXRpbWUtd29ybGQtbGFiZWwKKyAgJygodCA6aW5oZXJp dCBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKKyAgIkZhY2UgZm9yIHRpbWUgem9uZSBs YWJlbC4iKQorCiAoZGVmaW5lLWRlcml2ZWQtbW9kZSBkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSBz cGVjaWFsLW1vZGUgIldvcmxkIGNsb2NrIgogICAiTWFqb3IgbW9kZSBmb3IgYnVmZmVyIHRoYXQg ZGlzcGxheXMgdGltZXMgaW4gdmFyaW91cyB0aW1lIHpvbmVzLgogU2VlIGBkaXNwbGF5LXRpbWUt d29ybGQnLiIKKyAgKHNldHEgcmV2ZXJ0LWJ1ZmZlci1mdW5jdGlvbiAjJ2Rpc3BsYXktdGltZS13 b3JsZC10aW1lcikKICAgKHNldHEgc2hvdy10cmFpbGluZy13aGl0ZXNwYWNlIG5pbCkpCiAKIChk ZWZ1biBkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAoYWxpc3QpCkBAIC01MzMsNyArNTM4LDEw IEBAIGRpc3BsYXktdGltZS13b3JsZC1kaXNwbGF5CiAJICAoc2V0cSBtYXgtd2lkdGggd2lkdGgp KSkpCiAgICAgKHNldHEgZm10IChjb25jYXQgIiUtIiAoaW50LXRvLXN0cmluZyBtYXgtd2lkdGgp ICJzICVzXG4iKSkKICAgICAoZG9saXN0ICh0aW1lZGF0YSAobnJldmVyc2UgcmVzdWx0KSkKLSAg ICAgIChpbnNlcnQgKGZvcm1hdCBmbXQgKGNhciB0aW1lZGF0YSkgKGNkciB0aW1lZGF0YSkpKSkK KyAgICAgIChpbnNlcnQgKGZvcm1hdCBmbXQKKyAgICAgICAgICAgICAgICAgICAgICAocHJvcGVy dGl6ZSAoY2FyIHRpbWVkYXRhKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdm YWNlICdkaXNwbGF5LXRpbWUtd29ybGQtbGFiZWwpCisgICAgICAgICAgICAgICAgICAgICAgKGNk ciB0aW1lZGF0YSkpKSkKICAgICAoZGVsZXRlLWNoYXIgLTEpKQogICAoZ290by1jaGFyIChwb2lu dC1taW4pKSkKIApAQCAtNTQxLDE4ICs1NDksMTcgQEAgZGlzcGxheS10aW1lLXdvcmxkLWRpc3Bs YXkKIChkZWZ1biBkaXNwbGF5LXRpbWUtd29ybGQgKCkKICAgIkVuYWJsZSB1cGRhdGluZyBkaXNw bGF5IG9mIHRpbWVzIGluIHZhcmlvdXMgdGltZSB6b25lcy4KIGBkaXNwbGF5LXRpbWUtd29ybGQt bGlzdCcgc3BlY2lmaWVzIHRoZSB6b25lcy4KLVRvIHR1cm4gb2ZmIHRoZSB3b3JsZCB0aW1lIGRp c3BsYXksIGdvIHRvIHRoYXQgd2luZG93IGFuZCB0eXBlIGBxJy4iCitUbyB0dXJuIG9mZiB0aGUg d29ybGQgdGltZSBkaXNwbGF5LCBnbyB0byB0aGF0IHdpbmRvdyBhbmQgdHlwZSBgXFxbcXVpdC13 aW5kb3ddJy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKHdoZW4gKGFuZCBkaXNwbGF5LXRpbWUtd29y bGQtdGltZXItZW5hYmxlCiAgICAgICAgICAgICAgKG5vdCAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRp bWUtd29ybGQtYnVmZmVyLW5hbWUpKSkKICAgICAocnVuLWF0LXRpbWUgdCBkaXNwbGF5LXRpbWUt d29ybGQtdGltZXItc2Vjb25kICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIpKQotICAod2l0aC1j dXJyZW50LWJ1ZmZlciAoZ2V0LWJ1ZmZlci1jcmVhdGUgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZl ci1uYW1lKQotICAgIChkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13 b3JsZC1saXN0KSkKLSAgICAoZGlzcGxheS1idWZmZXIgZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZl ci1uYW1lCi0JCSAgICAoY29ucyBuaWwgJygod2luZG93LWhlaWdodCAuIGZpdC13aW5kb3ctdG8t YnVmZmVyKSkpKQotICAgIChkaXNwbGF5LXRpbWUtd29ybGQtbW9kZSkpKQorICAocG9wLXRvLWJ1 ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCisgIChkaXNwbGF5LXRpbWUtd29y bGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkKKyAgKGRpc3BsYXktdGltZS13 b3JsZC1tb2RlKQorICAoZml0LXdpbmRvdy10by1idWZmZXIpKQogCi0oZGVmdW4gZGlzcGxheS10 aW1lLXdvcmxkLXRpbWVyICgpCisoZGVmdW4gZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyICgmb3B0 aW9uYWwgX2FyZyBfbm9jb25maXJtKQogICAoaWYgKGdldC1idWZmZXIgZGlzcGxheS10aW1lLXdv cmxkLWJ1ZmZlci1uYW1lKQogICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGdldC1idWZmZXIg ZGlzcGxheS10aW1lLXdvcmxkLWJ1ZmZlci1uYW1lKQogICAgICAgICAoZGlzcGxheS10aW1lLXdv cmxkLWRpc3BsYXkgKHRpbWUtLWRpc3BsYXktd29ybGQtbGlzdCkpKQotLSAKMi4yOC4wCgo= --0000000000005fdcb105ac791d15 Content-Type: text/x-diff; charset="US-ASCII"; name="0002-Rename-display-time-world-to-world-clock-Bug-40863.patch" Content-Disposition: attachment; filename="0002-Rename-display-time-world-to-world-clock-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: b254273990da5c94_0.2 RnJvbSA1MmEwMmU2ZDE1OWQ5M2Y5ZDcwN2VhOWU1ZDQwYTA1ZjI5MGFjMWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDIgTWF5IDIwMjAgMTY6MDg6MzMgKzAyMDAKU3ViamVjdDogW1BBVENIIDIv M10gUmVuYW1lICdkaXNwbGF5LXRpbWUtd29ybGQnIHRvICd3b3JsZC1jbG9jaycgKEJ1ZyM0MDg2 MykKCiogbGlzcC90aW1lLmVsICh3b3JsZC1jbG9jay1saXN0LCB3b3JsZC1jbG9jay10aW1lLWZv cm1hdCkKKHdvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lLCB3b3JsZC1jbG9jay10aW1lci1lbmFibGUp Cih3b3JsZC1jbG9jay10aW1lci1zZWNvbmQsIHdvcmxkLWNsb2NrLWxhYmVsLCB3b3JsZC1jbG9j ay1tb2RlKQood29ybGQtY2xvY2stZGlzcGxheSwgd29ybGQtY2xvY2ssIHdvcmxkLWNsb2NrLXVw ZGF0ZSk6IFJlbmFtZQpmcm9tICdkaXNwbGF5LXRpbWUtd29ybGQtKicgYW5kIHVwZGF0ZSBhbGwg dXNlcy4KCih3b3JsZC1jbG9jayk6IE5ldyBkZWZncm91cC4KKHpvbmVpbmZvLXN0eWxlLXdvcmxk LWxpc3QsIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0KTogVXNlIDpncm91cAond29ybGQtY2xvY2sn LgoKKGRpc3BsYXktdGltZS13b3JsZC1saXN0LCBkaXNwbGF5LXRpbWUtd29ybGQtdGltZS1mb3Jt YXQpCihkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCihkaXNwbGF5LXRpbWUtd29ybGQt dGltZXItZW5hYmxlKQooZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyLXNlY29uZCk6IE1ha2UgaW50 byBvYnNvbGV0ZSB2YXJpYWJsZQphbGlhc2VzIGZvciB0aGUgbmV3IG5hbWVzLgoKKiBsaXNwL3Rp bWUuZWwgKGRpc3BsYXktdGltZS13b3JsZC1tb2RlKQooZGlzcGxheS10aW1lLXdvcmxkLWRpc3Bs YXksIGRpc3BsYXktdGltZS13b3JsZCkKKGRpc3BsYXktdGltZS13b3JsZC10aW1lcik6IE1ha2Ug aW50byBvYnNvbGV0ZSBmdW5jdGlvbiBhbGlhc2VzCmZvciB0aGUgbmV3IG5hbWVzLgoKKiBldGMv TkVXUzogQW5ub3VuY2UgdGhlIGFib3ZlIGNoYW5nZXMuCi0tLQogZXRjL05FV1MgICAgIHwgIDI1 ICsrKysrKysrKysKIGxpc3AvdGltZS5lbCB8IDEzNCArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTA2IGluc2VydGlv bnMoKyksIDUzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MK aW5kZXggZTNkN2ZmMGJlZi4uOTA3OGNkM2E3YSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIv ZXRjL05FV1MKQEAgLTc1NCw2ICs3NTQsMzEgQEAgbmV2ZXIgYmUgbmFycm93ZXIgdGhhbiAxOSBj aGFyYWN0ZXJzLgogV2hlbiB0aGUgJ2Jvb2ttYXJrLmVsJyBsaWJyYXJ5IGlzIGxvYWRlZCwgYSBj dXN0b21pemUgY2hvaWNlIGlzIGFkZGVkCiB0byAndGFiLWJhci1uZXctdGFiLWNob2ljZScgZm9y IG5ldyB0YWJzIHRvIHNob3cgdGhlIGJvb2ttYXJrIGxpc3QuCiAKKyoqIFRpbWUKKworLS0tCisq KiogJ2Rpc3BsYXktdGltZS13b3JsZCcgaGFzIGJlZW4gcmVuYW1lZCB0byAnd29ybGQtY2xvY2sn LgorJ3dvcmxkLWNsb2NrJyBjcmVhdGVzIGEgYnVmZmVyIHdpdGggYW4gdXBkYXRpbmcgdGltZSBk aXNwbGF5IHVzaW5nCitzZXZlcmFsIHRpbWUgem9uZXMuICBJdCBpcyBob3BlZCB0aGF0IHRoZSBu ZXcgbmFtZXMgYXJlIG1vcmUKK2Rpc2NvdmVyYWJsZS4KKworVGhlIGZvbGxvd2luZyBmdW5jdGlv bnMgaGF2ZSBiZWVuIHJlbmFtZWQ6CisKKyAgJ2Rpc3BsYXktdGltZS13b3JsZCcgICAgICAgICB0 byAnd29ybGQtY2xvY2snCisgICdkaXNwbGF5LXRpbWUtd29ybGQtbW9kZScgICAgdG8gJ3dvcmxk LWNsb2NrLW1vZGUnCisgICdkaXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheScgdG8gJ3dvcmxkLWNs b2NrLWRpc3BsYXknCisgICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXInICAgdG8gJ3dvcmxkLWNs b2NrLXVwZGF0ZScKKworVGhlIGZvbGxvd2luZyBvcHRpb25zIGhhdmUgYmVlbiByZW5hbWVkOgor CisgICdkaXNwbGF5LXRpbWUtd29ybGQtbGlzdCcgICAgICAgICB0byAnd29ybGQtY2xvY2stbGlz dCcKKyAgJ2Rpc3BsYXktdGltZS13b3JsZC10aW1lLWZvcm1hdCcgIHRvICd3b3JsZC1jbG9jay10 aW1lLWZvcm1hdCcKKyAgJ2Rpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFtZScgIHRvICd3b3Js ZC1jbG9jay1idWZmZXItbmFtZScKKyAgJ2Rpc3BsYXktdGltZS13b3JsZC10aW1lci1lbmFibGUn IHRvICd3b3JsZC1jbG9jay10aW1lci1lbmFibGUnCisgICdkaXNwbGF5LXRpbWUtd29ybGQtdGlt ZXItc2Vjb25kJyB0byAnd29ybGQtY2xvY2stdGltZXItc2Vjb25kJworCitUaGUgb2xkIG5hbWVz IGFyZSBub3cgb2Jzb2xldGUuCisKIAwKICogTmV3IE1vZGVzIGFuZCBQYWNrYWdlcyBpbiBFbWFj cyAyOC4xCiAKZGlmZiAtLWdpdCBhL2xpc3AvdGltZS5lbCBiL2xpc3AvdGltZS5lbAppbmRleCAz NjI1OTQwMzM0Li5mZTkxOGM1NDAwIDEwMDY0NAotLS0gYS9saXNwL3RpbWUuZWwKKysrIGIvbGlz cC90aW1lLmVsCkBAIC0yNSw4ICsyNSw3IEBACiA7OyBGYWNpbGl0aWVzIHRvIGRpc3BsYXkgY3Vy cmVudCB0aW1lL2RhdGUgYW5kIGEgbmV3LW1haWwgaW5kaWNhdG9yCiA7OyBpbiB0aGUgRW1hY3Mg bW9kZSBsaW5lLiAgVGhlIGVudHJ5IHBvaW50IGlzIGBkaXNwbGF5LXRpbWUnLgogCi07OyBEaXNw bGF5IHRpbWUgd29ybGQgaW4gYSBidWZmZXIsIHRoZSBlbnRyeSBwb2ludCBpcwotOzsgYGRpc3Bs YXktdGltZS13b3JsZCcuCis7OyBVc2UgYHdvcmxkLWNsb2NrJyB0byBkaXNwbGF5IHdvcmxkIGNs b2NrIGluIGEgYnVmZmVyLgogCiA7OzsgQ29kZToKIApAQCAtMTIzLDYgKzEyMiwxMCBAQCBkaXNw bGF5LXRpbWUtc2VydmVyLWRvd24tdGltZQogICAgIlRpbWUgd2hlbiBtYWlsIGZpbGUncyBmaWxl IHN5c3RlbSB3YXMgcmVjb3JkZWQgdG8gYmUgZG93bi4KIElmIHRoYXQgZmlsZSBzeXN0ZW0gc2Vl bXMgdG8gYmUgdXAsIHRoZSB2YWx1ZSBpcyBuaWwuIikKIAorKGRlZmdyb3VwIHdvcmxkLWNsb2Nr IG5pbAorICAiRGlzcGxheSBhIHdvcmxkIGNsb2NrLiIKKyAgOmdyb3VwICdkaXNwbGF5LXRpbWUp CisKIChkZWZjdXN0b20gem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdAogICAnKCgiQW1lcmljYS9M b3NfQW5nZWxlcyIgIlNlYXR0bGUiKQogICAgICgiQW1lcmljYS9OZXdfWW9yayIgIk5ldyBZb3Jr IikKQEAgLTEzMCwxMyArMTMzLDEzIEBAIHpvbmVpbmZvLXN0eWxlLXdvcmxkLWxpc3QKICAgICAo IkV1cm9wZS9QYXJpcyIgIlBhcmlzIikKICAgICAoIkFzaWEvQ2FsY3V0dGEiICJCYW5nYWxvcmUi KQogICAgICgiQXNpYS9Ub2t5byIgIlRva3lvIikpCi0gICJBbGlzdCBvZiB6b25laW5mby1zdHls ZSB0aW1lIHpvbmVzIGFuZCBwbGFjZXMgZm9yIGBkaXNwbGF5LXRpbWUtd29ybGQnLgorICAiQWxp c3Qgb2Ygem9uZWluZm8tc3R5bGUgdGltZSB6b25lcyBhbmQgcGxhY2VzIGZvciBgd29ybGQtY2xv Y2snLgogRWFjaCBlbGVtZW50IGhhcyB0aGUgZm9ybSAoVElNRVpPTkUgTEFCRUwpLgogVElNRVpP TkUgc2hvdWxkIGJlIGEgc3RyaW5nIG9mIHRoZSBmb3JtIEFSRUEvTE9DQVRJT04sIHdoZXJlIEFS RUEgaXMKIHRoZSBuYW1lIG9mIGEgcmVnaW9uIC0tIGEgY29udGluZW50IG9yIG9jZWFuLCBhbmQg TE9DQVRJT04gaXMgdGhlIG5hbWUKIG9mIGEgc3BlY2lmaWMgbG9jYXRpb24sIGUuZy4sIGEgY2l0 eSwgd2l0aGluIHRoYXQgcmVnaW9uLgogTEFCRUwgaXMgYSBzdHJpbmcgdG8gZGlzcGxheSBhcyB0 aGUgbGFiZWwgb2YgdGhhdCBUSU1FWk9ORSdzIHRpbWUuIgotICA6Z3JvdXAgJ2Rpc3BsYXktdGlt ZQorICA6Z3JvdXAgJ3dvcmxkLWNsb2NrCiAgIDp0eXBlICcocmVwZWF0IChsaXN0IHN0cmluZyBz dHJpbmcpKQogICA6dmVyc2lvbiAiMjMuMSIpCiAKQEAgLTE0Nyw3ICsxNTAsNyBAQCBsZWdhY3kt c3R5bGUtd29ybGQtbGlzdAogICAgICgiQ0VULTFDRFQiICJQYXJpcyIpCiAgICAgKCJJU1QtNToz MCIgIkJhbmdhbG9yZSIpCiAgICAgKCJKU1QtOSIgIlRva3lvIikpCi0gICJBbGlzdCBvZiB0cmFk aXRpb25hbC1zdHlsZSB0aW1lIHpvbmVzIGFuZCBwbGFjZXMgZm9yIGBkaXNwbGF5LXRpbWUtd29y bGQnLgorICAiQWxpc3Qgb2YgdHJhZGl0aW9uYWwtc3R5bGUgdGltZSB6b25lcyBhbmQgcGxhY2Vz IGZvciBgd29ybGQtY2xvY2snLgogRWFjaCBlbGVtZW50IGhhcyB0aGUgZm9ybSAoVElNRVpPTkUg TEFCRUwpLgogVElNRVpPTkUgc2hvdWxkIGJlIGEgc3RyaW5nIG9mIHRoZSBmb3JtOgogCkBAIC0x NTYsMTIgKzE1OSwxMiBAQCBsZWdhY3ktc3R5bGUtd29ybGQtbGlzdAogU2VlIHRoZSBkb2N1bWVu dGF0aW9uIG9mIHRoZSBUWiBlbnZpcm9ubWVudCB2YXJpYWJsZSBvbiB5b3VyIHN5c3RlbSwKIGZv ciBtb3JlIGRldGFpbHMgYWJvdXQgdGhlIGZvcm1hdCBvZiBUSU1FWk9ORS4KIExBQkVMIGlzIGEg c3RyaW5nIHRvIGRpc3BsYXkgYXMgdGhlIGxhYmVsIG9mIHRoYXQgVElNRVpPTkUncyB0aW1lLiIK LSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKKyAgOmdyb3VwICd3b3JsZC1jbG9jawogICA6dHlwZSAn KHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5nKSkKICAgOnZlcnNpb24gIjIzLjEiKQogCi0oZGVm Y3VzdG9tIGRpc3BsYXktdGltZS13b3JsZC1saXN0IHQKLSAgIkFsaXN0IG9mIHRpbWUgem9uZXMg YW5kIHBsYWNlcyBmb3IgYGRpc3BsYXktdGltZS13b3JsZCcgdG8gZGlzcGxheS4KKyhkZWZjdXN0 b20gd29ybGQtY2xvY2stbGlzdCB0CisgICJBbGlzdCBvZiB0aW1lIHpvbmVzIGFuZCBwbGFjZXMg Zm9yIGB3b3JsZC1jbG9jaycgdG8gZGlzcGxheS4KIEVhY2ggZWxlbWVudCBoYXMgdGhlIGZvcm0g KFRJTUVaT05FIExBQkVMKS4KIFRJTUVaT05FIHNob3VsZCBiZSBpbiBhIGZvcm1hdCBzdXBwb3J0 ZWQgYnkgeW91ciBzeXN0ZW0uICBTZWUgdGhlCiBkb2N1bWVudGF0aW9uIG9mIGB6b25laW5mby1z dHlsZS13b3JsZC1saXN0JyBhbmQKQEAgLTE3MSwxNiArMTc0LDE1IEBAIGRpc3BsYXktdGltZS13 b3JsZC1saXN0CiBJZiB0aGUgdmFsdWUgaXMgdCBpbnN0ZWFkIG9mIGFuIGFsaXN0LCB1c2UgdGhl IHZhbHVlIG9mCiBgem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCcgaWYgaXQgd29ya3Mgb24gdGhp cyBwbGF0Zm9ybSwgYW5kIG9mCiBgbGVnYWN5LXN0eWxlLXdvcmxkLWxpc3QnIG90aGVyd2lzZS4i Ci0KLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKKyAgOmdyb3VwICd3b3JsZC1jbG9jawogICA6dHlw ZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiRGVmYXVsdCIgdCkKICAgICAgICAgICAgICAgICAgKHJl cGVhdCA6dGFnICJMaXN0IG9mIHpvbmVzIGFuZCBsYWJlbHMiCiAgICAgICAgICAgICAgICAgICAg ICAgICAgKGxpc3QgKHN0cmluZyA6dGFnICJab25lIikgKHN0cmluZyA6dGFnICJMYWJlbCIpKSkp Ci0gIDp2ZXJzaW9uICIyMy4xIikKKyAgOnZlcnNpb24gIjI4LjEiKQogCiAoZGVmdW4gdGltZS0t ZGlzcGxheS13b3JsZC1saXN0ICgpCi0gIChpZiAobGlzdHAgZGlzcGxheS10aW1lLXdvcmxkLWxp c3QpCi0gICAgICBkaXNwbGF5LXRpbWUtd29ybGQtbGlzdAorICAoaWYgKGxpc3RwIHdvcmxkLWNs b2NrLWxpc3QpCisgICAgICB3b3JsZC1jbG9jay1saXN0CiAgICAgOzsgRGV0ZXJtaW5lIGlmIHpv bmVpbmZvIHN0eWxlIHRpbWV6b25lcyBhcmUgc3VwcG9ydGVkIGJ5IHRlc3RpbmcgdGhhdAogICAg IDs7IEFtZXJpY2EvTmV3IFlvcmsgYW5kIEV1cm9wZS9Mb25kb24gcmV0dXJuIGRpZmZlcmVudCB0 aW1lem9uZXMuCiAgICAgKGxldCAoKG55dCAoZm9ybWF0LXRpbWUtc3RyaW5nICIleiIgbmlsICJB bWVyaWNhL05ld19Zb3JrIikpCkBAIC0xODksMjkgKzE5MSwyOSBAQCB0aW1lLS1kaXNwbGF5LXdv cmxkLWxpc3QKIAkgIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0CiAJem9uZWluZm8tc3R5bGUtd29y bGQtbGlzdCkpKSkKIAotKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtd29ybGQtdGltZS1mb3JtYXQg IiVBICVkICVCICVSICVaIgotICAiRm9ybWF0IG9mIHRoZSB0aW1lIGRpc3BsYXllZCwgc2VlIGBm b3JtYXQtdGltZS1zdHJpbmcnLiIKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKKyhkZWZjdXN0b20g d29ybGQtY2xvY2stdGltZS1mb3JtYXQgIiVBICVkICVCICVSICVaIgorICAiVGltZSBmb3JtYXQg Zm9yIGB3b3JsZC1jbG9jaycsIHNlZSBgZm9ybWF0LXRpbWUtc3RyaW5nJy4iCisgIDpncm91cCAn d29ybGQtY2xvY2sKICAgOnR5cGUgJ3N0cmluZwotICA6dmVyc2lvbiAiMjMuMSIpCisgIDp2ZXJz aW9uICIyOC4xIikKIAotKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUg Iip3Y2xvY2sqIgotICAiTmFtZSBvZiB0aGUgd29ybGQgY2xvY2sgYnVmZmVyLiIKLSAgOmdyb3Vw ICdkaXNwbGF5LXRpbWUKKyhkZWZjdXN0b20gd29ybGQtY2xvY2stYnVmZmVyLW5hbWUgIip3Y2xv Y2sqIgorICAiTmFtZSBvZiB0aGUgYHdvcmxkLWNsb2NrJyBidWZmZXIuIgorICA6Z3JvdXAgJ3dv cmxkLWNsb2NrCiAgIDp0eXBlICdzdHJpbmcKLSAgOnZlcnNpb24gIjIzLjEiKQorICA6dmVyc2lv biAiMjguMSIpCiAKLShkZWZjdXN0b20gZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyLWVuYWJsZSB0 Ci0gICJJZiBub24tbmlsLCBhIHRpbWVyIHdpbGwgdXBkYXRlIHRoZSB3b3JsZCBjbG9jay4iCi0g IDpncm91cCAnZGlzcGxheS10aW1lCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLXRpbWVyLWVuYWJs ZSB0CisgICJJZiBub24tbmlsLCBhIHRpbWVyIHdpbGwgdXBkYXRlIHRoZSBgd29ybGQtY2xvY2sn IGJ1ZmZlci4iCisgIDpncm91cCAnd29ybGQtY2xvY2sKICAgOnR5cGUgJ2Jvb2xlYW4KLSAgOnZl cnNpb24gIjIzLjEiKQorICA6dmVyc2lvbiAiMjguMSIpCiAKLShkZWZjdXN0b20gZGlzcGxheS10 aW1lLXdvcmxkLXRpbWVyLXNlY29uZCA2MAotICAiSW50ZXJ2YWwgaW4gc2Vjb25kcyBmb3IgdXBk YXRpbmcgdGhlIHdvcmxkIGNsb2NrLiIKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKKyhkZWZjdXN0 b20gd29ybGQtY2xvY2stdGltZXItc2Vjb25kIDYwCisgICJJbnRlcnZhbCBpbiBzZWNvbmRzIGZv ciB1cGRhdGluZyB0aGUgYHdvcmxkLWNsb2NrJyBidWZmZXIuIgorICA6Z3JvdXAgJ3dvcmxkLWNs b2NrCiAgIDp0eXBlICdpbnRlZ2VyCi0gIDp2ZXJzaW9uICIyMy4xIikKKyAgOnZlcnNpb24gIjI4 LjEiKQogCiA7OzsjIyNhdXRvbG9hZAogKGRlZnVuIGRpc3BsYXktdGltZSAoKQpAQCAtNTA4LDE4 ICs1MTAsNDMgQEAgZGlzcGxheS10aW1lLW1vZGUKICAgICAocmVtb3ZlLWhvb2sgJ3JtYWlsLWFm dGVyLWdldC1uZXctbWFpbC1ob29rCiAJCSAnZGlzcGxheS10aW1lLWV2ZW50LWhhbmRsZXIpKSkK IAotCi0oZGVmZmFjZSBkaXNwbGF5LXRpbWUtd29ybGQtbGFiZWwKKwwKKzs7OyBPYnNvbGV0ZSBu YW1lcworCisoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdkaXNwbGF5LXRpbWUtd29y bGQtbGlzdAorICAnd29ybGQtY2xvY2stbGlzdCAiMjguMSIpCisoZGVmaW5lLW9ic29sZXRlLXZh cmlhYmxlLWFsaWFzICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZS1mb3JtYXQKKyAgJ3dvcmxkLWNs b2NrLXRpbWUtZm9ybWF0ICIyOC4xIikKKyhkZWZpbmUtb2Jzb2xldGUtdmFyaWFibGUtYWxpYXMg J2Rpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFtZQorICAnd29ybGQtY2xvY2stYnVmZmVyLW5h bWUgIjI4LjEiKQorKGRlZmluZS1vYnNvbGV0ZS12YXJpYWJsZS1hbGlhcyAnZGlzcGxheS10aW1l LXdvcmxkLXRpbWVyLWVuYWJsZQorICAnd29ybGQtY2xvY2stdGltZXItZW5hYmxlICIyOC4xIikK KyhkZWZpbmUtb2Jzb2xldGUtdmFyaWFibGUtYWxpYXMgJ2Rpc3BsYXktdGltZS13b3JsZC10aW1l ci1zZWNvbmQKKyAgJ3dvcmxkLWNsb2NrLXRpbWVyLXNlY29uZCAiMjguMSIpCisKKyhkZWZpbmUt b2Jzb2xldGUtZnVuY3Rpb24tYWxpYXMgJ2Rpc3BsYXktdGltZS13b3JsZC1tb2RlCisgICMnd29y bGQtY2xvY2stbW9kZSAiMjguMSIpCisoZGVmaW5lLW9ic29sZXRlLWZ1bmN0aW9uLWFsaWFzICdk aXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheQorICAjJ3dvcmxkLWNsb2NrLWRpc3BsYXkgIjI4LjEi KQorKGRlZmluZS1vYnNvbGV0ZS1mdW5jdGlvbi1hbGlhcyAnZGlzcGxheS10aW1lLXdvcmxkCisg ICMnd29ybGQtY2xvY2sgIjI4LjEiKQorKGRlZmluZS1vYnNvbGV0ZS1mdW5jdGlvbi1hbGlhcyAn ZGlzcGxheS10aW1lLXdvcmxkLXRpbWVyCisgICMnd29ybGQtY2xvY2stdXBkYXRlICIyOC4xIikK KworDAorOzs7IFdvcmxkIGNsb2NrCisKKyhkZWZmYWNlIHdvcmxkLWNsb2NrLWxhYmVsCiAgICco KHQgOmluaGVyaXQgZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkpCi0gICJGYWNlIGZvciB0 aW1lIHpvbmUgbGFiZWwuIikKKyAgIkZhY2UgZm9yIHRpbWUgem9uZSBsYWJlbCBpbiBgd29ybGQt Y2xvY2snIGJ1ZmZlci4iKQogCi0oZGVmaW5lLWRlcml2ZWQtbW9kZSBkaXNwbGF5LXRpbWUtd29y bGQtbW9kZSBzcGVjaWFsLW1vZGUgIldvcmxkIGNsb2NrIgorKGRlZmluZS1kZXJpdmVkLW1vZGUg d29ybGQtY2xvY2stbW9kZSBzcGVjaWFsLW1vZGUgIldvcmxkIGNsb2NrIgogICAiTWFqb3IgbW9k ZSBmb3IgYnVmZmVyIHRoYXQgZGlzcGxheXMgdGltZXMgaW4gdmFyaW91cyB0aW1lIHpvbmVzLgot U2VlIGBkaXNwbGF5LXRpbWUtd29ybGQnLiIKLSAgKHNldHEgcmV2ZXJ0LWJ1ZmZlci1mdW5jdGlv biAjJ2Rpc3BsYXktdGltZS13b3JsZC10aW1lcikKK1NlZSBgd29ybGQtY2xvY2snLiIKKyAgKHNl dHEgcmV2ZXJ0LWJ1ZmZlci1mdW5jdGlvbiAjJ3dvcmxkLWNsb2NrLXVwZGF0ZSkKICAgKHNldHEg c2hvdy10cmFpbGluZy13aGl0ZXNwYWNlIG5pbCkpCiAKLShkZWZ1biBkaXNwbGF5LXRpbWUtd29y bGQtZGlzcGxheSAoYWxpc3QpCisoZGVmdW4gd29ybGQtY2xvY2stZGlzcGxheSAoYWxpc3QpCiAg ICJSZXBsYWNlIGN1cnJlbnQgYnVmZmVyIHRleHQgd2l0aCB0aW1lcyBpbiB2YXJpb3VzIHpvbmVz LCBiYXNlZCBvbiBBTElTVC4iCiAgIChsZXQgKChpbmhpYml0LXJlYWQtb25seSB0KQogCShidWZm ZXItdW5kby1saXN0IHQpCkBAIC01MzEsNyArNTU4LDcgQEAgZGlzcGxheS10aW1lLXdvcmxkLWRp c3BsYXkKICAgICAgIChsZXQqICgobGFiZWwgKGNhZHIgem9uZSkpCiAJICAgICAod2lkdGggKHN0 cmluZy13aWR0aCBsYWJlbCkpKQogCShwdXNoIChjb25zIGxhYmVsCi0JCSAgICAoZm9ybWF0LXRp bWUtc3RyaW5nIGRpc3BsYXktdGltZS13b3JsZC10aW1lLWZvcm1hdAorCQkgICAgKGZvcm1hdC10 aW1lLXN0cmluZyB3b3JsZC1jbG9jay10aW1lLWZvcm1hdAogCQkJCQlub3cgKGNhciB6b25lKSkp CiAJICAgICAgcmVzdWx0KQogCSh3aGVuICg+IHdpZHRoIG1heC13aWR0aCkKQEAgLTU0MCwzNSAr NTY3LDM2IEBAIGRpc3BsYXktdGltZS13b3JsZC1kaXNwbGF5CiAgICAgKGRvbGlzdCAodGltZWRh dGEgKG5yZXZlcnNlIHJlc3VsdCkpCiAgICAgICAoaW5zZXJ0IChmb3JtYXQgZm10CiAgICAgICAg ICAgICAgICAgICAgICAgKHByb3BlcnRpemUgKGNhciB0aW1lZGF0YSkKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnZmFjZSAnZGlzcGxheS10aW1lLXdvcmxkLWxhYmVsKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdmYWNlICd3b3JsZC1jbG9jay1sYWJlbCkK ICAgICAgICAgICAgICAgICAgICAgICAoY2RyIHRpbWVkYXRhKSkpKQogICAgIChkZWxldGUtY2hh ciAtMSkpCiAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpKQogCiA7OzsjIyNhdXRvbG9hZAotKGRl ZnVuIGRpc3BsYXktdGltZS13b3JsZCAoKQotICAiRW5hYmxlIHVwZGF0aW5nIGRpc3BsYXkgb2Yg dGltZXMgaW4gdmFyaW91cyB0aW1lIHpvbmVzLgotYGRpc3BsYXktdGltZS13b3JsZC1saXN0JyBz cGVjaWZpZXMgdGhlIHpvbmVzLgotVG8gdHVybiBvZmYgdGhlIHdvcmxkIHRpbWUgZGlzcGxheSwg Z28gdG8gdGhhdCB3aW5kb3cgYW5kIHR5cGUgYFxcW3F1aXQtd2luZG93XScuIgorKGRlZnVuIHdv cmxkLWNsb2NrICgpCisgICJEaXNwbGF5IGEgd29ybGQgY2xvY2sgYnVmZmVyIHdpdGggdGltZXMg aW4gdmFyaW91cyB0aW1lIHpvbmVzLgorVGhlIHZhcmlhYmxlIGB3b3JsZC1jbG9jay1saXN0JyBz cGVjaWZpZXMgd2hpY2ggdGltZSB6b25lcyB0byB1c2UuCitUbyB0dXJuIG9mZiB0aGUgd29ybGQg dGltZSBkaXNwbGF5LCBnbyB0byB0aGUgd2luZG93IGFuZCB0eXBlIGBcXFtxdWl0LXdpbmRvd10n LiIKICAgKGludGVyYWN0aXZlKQotICAod2hlbiAoYW5kIGRpc3BsYXktdGltZS13b3JsZC10aW1l ci1lbmFibGUKLSAgICAgICAgICAgICAobm90IChnZXQtYnVmZmVyIGRpc3BsYXktdGltZS13b3Js ZC1idWZmZXItbmFtZSkpKQotICAgIChydW4tYXQtdGltZSB0IGRpc3BsYXktdGltZS13b3JsZC10 aW1lci1zZWNvbmQgJ2Rpc3BsYXktdGltZS13b3JsZC10aW1lcikpCi0gIChwb3AtdG8tYnVmZmVy IGRpc3BsYXktdGltZS13b3JsZC1idWZmZXItbmFtZSkKLSAgKGRpc3BsYXktdGltZS13b3JsZC1k aXNwbGF5ICh0aW1lLS1kaXNwbGF5LXdvcmxkLWxpc3QpKQotICAoZGlzcGxheS10aW1lLXdvcmxk LW1vZGUpCisgICh3aGVuIChhbmQgd29ybGQtY2xvY2stdGltZXItZW5hYmxlCisgICAgICAgICAg ICAgKG5vdCAoZ2V0LWJ1ZmZlciB3b3JsZC1jbG9jay1idWZmZXItbmFtZSkpKQorICAgIChydW4t YXQtdGltZSB0IHdvcmxkLWNsb2NrLXRpbWVyLXNlY29uZCAjJ3dvcmxkLWNsb2NrLXVwZGF0ZSkp CisgIChwb3AtdG8tYnVmZmVyIHdvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lKQorICAod29ybGQtY2xv Y2stZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkKKyAgKHdvcmxkLWNsb2NrLW1v ZGUpCiAgIChmaXQtd2luZG93LXRvLWJ1ZmZlcikpCiAKLShkZWZ1biBkaXNwbGF5LXRpbWUtd29y bGQtdGltZXIgKCZvcHRpb25hbCBfYXJnIF9ub2NvbmZpcm0pCi0gIChpZiAoZ2V0LWJ1ZmZlciBk aXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCi0gICAgICAod2l0aC1jdXJyZW50LWJ1ZmZl ciAoZ2V0LWJ1ZmZlciBkaXNwbGF5LXRpbWUtd29ybGQtYnVmZmVyLW5hbWUpCi0gICAgICAgIChk aXNwbGF5LXRpbWUtd29ybGQtZGlzcGxheSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkpCiso ZGVmdW4gd29ybGQtY2xvY2stdXBkYXRlICgmb3B0aW9uYWwgX2FyZyBfbm9jb25maXJtKQorICAi VXBkYXRlIHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIChpZiAoZ2V0LWJ1ZmZlciB3b3Js ZC1jbG9jay1idWZmZXItbmFtZSkKKyAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChnZXQtYnVm ZmVyIHdvcmxkLWNsb2NrLWJ1ZmZlci1uYW1lKQorICAgICAgICAod29ybGQtY2xvY2stZGlzcGxh eSAodGltZS0tZGlzcGxheS13b3JsZC1saXN0KSkpCiAgICAgOzsgY2FuY2VsIHRpbWVyCiAgICAg KGxldCAoKGxpc3QgdGltZXItbGlzdCkpCiAgICAgICAod2hpbGUgbGlzdAogICAgICAgICAobGV0 ICgoZWx0IChwb3AgbGlzdCkpKQogICAgICAgICAgICh3aGVuIChlcXVhbCAoc3ltYm9sLW5hbWUg KHRpbWVyLS1mdW5jdGlvbiBlbHQpKQotCQkgICAgICAgImRpc3BsYXktdGltZS13b3JsZC10aW1l ciIpCisJCSAgICAgICAid29ybGQtY2xvY2stdXBkYXRlIikKICAgICAgICAgICAgIChjYW5jZWwt dGltZXIgZWx0KSkpKSkpKQogCiA7OzsjIyNhdXRvbG9hZAotLSAKMi4yOC4wCgo= --0000000000005fdcb105ac791d15 Content-Type: text/x-diff; charset="US-ASCII"; name="0003-Rearrange-and-clean-up-code-in-time.el-Bug-40863.patch" Content-Disposition: attachment; filename="0003-Rearrange-and-clean-up-code-in-time.el-Bug-40863.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: b254273990da5c94_0.3 RnJvbSBkZjFkOWIyNDcwYTRhMzljOTA5YmVhNjljOWI4ZGNjNjQyN2MxNTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDkgQXVnIDIwMjAgMjM6NDI6MDYgKzAyMDAKU3ViamVjdDogW1BBVENIIDMv M10gUmVhcnJhbmdlIGFuZCBjbGVhbiB1cCBjb2RlIGluIHRpbWUuZWwgKEJ1ZyM0MDg2MykKCiog bGlzcC90aW1lLmVsICh3b3JsZC1jbG9jaywgem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCkKKGxl Z2FjeS1zdHlsZS13b3JsZC1saXN0LCB3b3JsZC1jbG9jay1saXN0KQoodGltZS0tZGlzcGxheS13 b3JsZC1saXN0LCB3b3JsZC1jbG9jay10aW1lLWZvcm1hdCkKKHdvcmxkLWNsb2NrLXRpbWVyLWVu YWJsZSwgd29ybGQtY2xvY2stdGltZXItc2Vjb25kKTogTW92ZSBkZWZpbml0aW9ucwpjbG9zZXIg dG8gJ3dvcmxkLWNsb2NrJyBjb2RlLiAgUmVtb3ZlIHJlZHVuZGFudCA6Z3JvdXAgYXJncy4KCihk aXNwbGF5LXRpbWUtbWFpbC1maWxlLCBkaXNwbGF5LXRpbWUtbWFpbC1kaXJlY3RvcnkpCihkaXNw bGF5LXRpbWUtbWFpbC1mdW5jdGlvbikKKGRpc3BsYXktdGltZS1kZWZhdWx0LWxvYWQtYXZlcmFn ZSkKKGRpc3BsYXktdGltZS1sb2FkLWF2ZXJhZ2UtdGhyZXNob2xkLCBkaXNwbGF5LXRpbWUtZGF5 LWFuZC1kYXRlKQooZGlzcGxheS10aW1lLWludGVydmFsLCBkaXNwbGF5LXRpbWUtMjRoci1mb3Jt YXQpCihkaXNwbGF5LXRpbWUtaG9vaywgZGlzcGxheS10aW1lLW1haWwtZmFjZSkKKGRpc3BsYXkt dGltZS11c2UtbWFpbC1pY29uLCBkaXNwbGF5LXRpbWUtbWFpbC1zdHJpbmcpCihkaXNwbGF5LXRp bWUtZm9ybWF0LCBkaXNwbGF5LXRpbWUtc3RyaW5nLWZvcm1zKTogUmVtb3ZlIHJlZHVuZGFudAo6 Z3JvdXAgYXJncy4KLS0tCiBsaXNwL3RpbWUuZWwgfCAyMTUgKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOTcgaW5zZXJ0 aW9ucygrKSwgMTE4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGltZS5lbCBiL2xp c3AvdGltZS5lbAppbmRleCBmZTkxOGM1NDAwLi45NmI0OWRkYWJkIDEwMDY0NAotLS0gYS9saXNw L3RpbWUuZWwKKysrIGIvbGlzcC90aW1lLmVsCkBAIC0zNCwyMyArMzQsMjAgQEAgZGlzcGxheS10 aW1lCiAgIDpncm91cCAnbW9kZS1saW5lCiAgIDpncm91cCAnbWFpbCkKIAotCiAoZGVmY3VzdG9t IGRpc3BsYXktdGltZS1tYWlsLWZpbGUgbmlsCiAgICJGaWxlIG5hbWUgb2YgbWFpbCBpbmJveCBm aWxlLCBmb3IgaW5kaWNhdGluZyBleGlzdGVuY2Ugb2YgbmV3IG1haWwuCiBOb24tbmlsIGFuZCBu b3QgYSBzdHJpbmcgbWVhbnMgZG9uJ3QgY2hlY2sgZm9yIG1haWw7IG5pbCBtZWFucyB1c2UKIGRl ZmF1bHQsIHdoaWNoIGlzIHN5c3RlbS1kZXBlbmRlbnQsIGFuZCBpcyB0aGUgc2FtZSBhcyB1c2Vk IGJ5IFJtYWlsLiIKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIk5vbmUiIG5vbmUpCiAJ CSAoY29uc3QgOnRhZyAiRGVmYXVsdCIgbmlsKQotCQkgKGZpbGUgOmZvcm1hdCAiJXYiKSkKLSAg Omdyb3VwICdkaXNwbGF5LXRpbWUpCisJCSAoZmlsZSA6Zm9ybWF0ICIldiIpKSkKIAogKGRlZmN1 c3RvbSBkaXNwbGF5LXRpbWUtbWFpbC1kaXJlY3RvcnkgbmlsCiAgICJOYW1lIG9mIG1haWwgaW5i b3ggZGlyZWN0b3J5LCBmb3IgaW5kaWNhdGluZyBleGlzdGVuY2Ugb2YgbmV3IG1haWwuCiBBbnkg bm9uZW1wdHkgcmVndWxhciBmaWxlIGluIHRoZSBkaXJlY3RvcnkgaXMgcmVnYXJkZWQgYXMgbmV3 bHkgYXJyaXZlZCBtYWlsLgogSWYgbmlsLCBkbyBub3QgY2hlY2sgYSBkaXJlY3RvcnkgZm9yIGFy cml2aW5nIG1haWwuIgogICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiTm9uZSIgbmlsKQot CQkgKGRpcmVjdG9yeSA6Zm9ybWF0ICIldiIpKQotICA6Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKwkJ IChkaXJlY3RvcnkgOmZvcm1hdCAiJXYiKSkpCiAKIChkZWZjdXN0b20gZGlzcGxheS10aW1lLW1h aWwtZnVuY3Rpb24gbmlsCiAgICJGdW5jdGlvbiB0byBjYWxsLCBmb3IgaW5kaWNhdGluZyBleGlz dGVuY2Ugb2YgbmV3IG1haWwuCkBAIC01OCw4ICs1NSw3IEBAIGRpc3BsYXktdGltZS1tYWlsLWZ1 bmN0aW9uCiBzcGVjaWZpZWQgYnkgYGRpc3BsYXktdGltZS1tYWlsLWZpbGUnIGlzIG5vbmVtcHR5 IG9yIHRoYXQgdGhlCiBkaXJlY3RvcnkgYGRpc3BsYXktdGltZS1tYWlsLWRpcmVjdG9yeScgY29u dGFpbnMgbm9uZW1wdHkgZmlsZXMuIgogICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiRGVm YXVsdCIgbmlsKQotCQkgKGZ1bmN0aW9uKSkKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCisJCSAo ZnVuY3Rpb24pKSkKIAogKGRlZmN1c3RvbSBkaXNwbGF5LXRpbWUtZGVmYXVsdC1sb2FkLWF2ZXJh Z2UgMAogICAiV2hpY2ggbG9hZCBhdmVyYWdlIHZhbHVlIHdpbGwgYmUgc2hvd24gaW4gdGhlIG1v ZGUgbGluZS4KQEAgLTc0LDggKzcwLDcgQEAgZGlzcGxheS10aW1lLWRlZmF1bHQtbG9hZC1hdmVy YWdlCiAgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICIxIG1pbnV0ZSBsb2FkIiAwKQogCQkg KGNvbnN0IDp0YWcgIjUgbWludXRlcyBsb2FkIiAxKQogCQkgKGNvbnN0IDp0YWcgIjE1IG1pbnV0 ZXMgbG9hZCIgMikKLQkJIChjb25zdCA6dGFnICJOb25lIiBuaWwpKQotICA6Z3JvdXAgJ2Rpc3Bs YXktdGltZSkKKwkJIChjb25zdCA6dGFnICJOb25lIiBuaWwpKSkKIAogKGRlZnZhciBkaXNwbGF5 LXRpbWUtbG9hZC1hdmVyYWdlIG5pbAogICAiVmFsdWUgb2YgdGhlIHN5c3RlbSdzIGxvYWQgYXZl cmFnZSBjdXJyZW50bHkgc2hvd24gb24gdGhlIG1vZGUgbGluZS4KQEAgLTg1LDI3ICs4MCwyMyBA QCBkaXNwbGF5LXRpbWUtbG9hZC1hdmVyYWdlCiAKIChkZWZjdXN0b20gZGlzcGxheS10aW1lLWxv YWQtYXZlcmFnZS10aHJlc2hvbGQgMC4xCiAgICJMb2FkLWF2ZXJhZ2UgdmFsdWVzIGJlbG93IHRo aXMgdmFsdWUgd29uJ3QgYmUgc2hvd24gaW4gdGhlIG1vZGUgbGluZS4iCi0gIDp0eXBlICdudW1i ZXIKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCisgIDp0eXBlICdudW1iZXIpCiAKIDs7OyMjI2F1 dG9sb2FkCiAoZGVmY3VzdG9tIGRpc3BsYXktdGltZS1kYXktYW5kLWRhdGUgbmlsICJcCiBOb24t bmlsIG1lYW5zIFxcW2Rpc3BsYXktdGltZV0gc2hvdWxkIGRpc3BsYXkgZGF5IGFuZCBkYXRlIGFz IHdlbGwgYXMgdGltZS4iCi0gIDp0eXBlICdib29sZWFuCi0gIDpncm91cCAnZGlzcGxheS10aW1l KQorICA6dHlwZSAnYm9vbGVhbikKIAogKGRlZnZhciBkaXNwbGF5LXRpbWUtdGltZXIgbmlsKQog CiAoZGVmY3VzdG9tIGRpc3BsYXktdGltZS1pbnRlcnZhbCA2MAogICAiU2Vjb25kcyBiZXR3ZWVu IHVwZGF0ZXMgb2YgdGltZSBpbiB0aGUgbW9kZSBsaW5lLiIKLSAgOnR5cGUgJ2ludGVnZXIKLSAg Omdyb3VwICdkaXNwbGF5LXRpbWUpCisgIDp0eXBlICdpbnRlZ2VyKQogCiAoZGVmY3VzdG9tIGRp c3BsYXktdGltZS0yNGhyLWZvcm1hdCBuaWwKICAgIk5vbi1uaWwgaW5kaWNhdGVzIHRpbWUgc2hv dWxkIGJlIGRpc3BsYXllZCBhcyBoaDptbSwgMCA8PSBoaCA8PSAyMy4KIEEgdmFsdWUgb2Ygbmls IG1lYW5zIDEgPD0gaGggPD0gMTIsIGFuZCBhbiBBTS9QTSBzdWZmaXggaXMgdXNlZC4iCi0gIDp0 eXBlICdib29sZWFuCi0gIDpncm91cCAnZGlzcGxheS10aW1lKQorICA6dHlwZSAnYm9vbGVhbikK IAogKGRlZnZhciBkaXNwbGF5LXRpbWUtc3RyaW5nIG5pbAogICAiU3RyaW5nIHVzZWQgaW4gbW9k ZSBsaW5lcyB0byBkaXNwbGF5IGEgdGltZSBzdHJpbmcuCkBAIC0xMTUsMTA2ICsxMDYsMTIgQEAg ZGlzcGxheS10aW1lLXN0cmluZwogCiAoZGVmY3VzdG9tIGRpc3BsYXktdGltZS1ob29rIG5pbAog ICAiTGlzdCBvZiBmdW5jdGlvbnMgdG8gYmUgY2FsbGVkIHdoZW4gdGhlIHRpbWUgaXMgdXBkYXRl ZCBvbiB0aGUgbW9kZSBsaW5lLiIKLSAgOnR5cGUgJ2hvb2sKLSAgOmdyb3VwICdkaXNwbGF5LXRp bWUpCisgIDp0eXBlICdob29rKQogCiAoZGVmdmFyIGRpc3BsYXktdGltZS1zZXJ2ZXItZG93bi10 aW1lIG5pbAogICAgIlRpbWUgd2hlbiBtYWlsIGZpbGUncyBmaWxlIHN5c3RlbSB3YXMgcmVjb3Jk ZWQgdG8gYmUgZG93bi4KIElmIHRoYXQgZmlsZSBzeXN0ZW0gc2VlbXMgdG8gYmUgdXAsIHRoZSB2 YWx1ZSBpcyBuaWwuIikKIAotKGRlZmdyb3VwIHdvcmxkLWNsb2NrIG5pbAotICAiRGlzcGxheSBh IHdvcmxkIGNsb2NrLiIKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCi0KLShkZWZjdXN0b20gem9u ZWluZm8tc3R5bGUtd29ybGQtbGlzdAotICAnKCgiQW1lcmljYS9Mb3NfQW5nZWxlcyIgIlNlYXR0 bGUiKQotICAgICgiQW1lcmljYS9OZXdfWW9yayIgIk5ldyBZb3JrIikKLSAgICAoIkV1cm9wZS9M b25kb24iICJMb25kb24iKQotICAgICgiRXVyb3BlL1BhcmlzIiAiUGFyaXMiKQotICAgICgiQXNp YS9DYWxjdXR0YSIgIkJhbmdhbG9yZSIpCi0gICAgKCJBc2lhL1Rva3lvIiAiVG9reW8iKSkKLSAg IkFsaXN0IG9mIHpvbmVpbmZvLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYHdvcmxk LWNsb2NrJy4KLUVhY2ggZWxlbWVudCBoYXMgdGhlIGZvcm0gKFRJTUVaT05FIExBQkVMKS4KLVRJ TUVaT05FIHNob3VsZCBiZSBhIHN0cmluZyBvZiB0aGUgZm9ybSBBUkVBL0xPQ0FUSU9OLCB3aGVy ZSBBUkVBIGlzCi10aGUgbmFtZSBvZiBhIHJlZ2lvbiAtLSBhIGNvbnRpbmVudCBvciBvY2Vhbiwg YW5kIExPQ0FUSU9OIGlzIHRoZSBuYW1lCi1vZiBhIHNwZWNpZmljIGxvY2F0aW9uLCBlLmcuLCBh IGNpdHksIHdpdGhpbiB0aGF0IHJlZ2lvbi4KLUxBQkVMIGlzIGEgc3RyaW5nIHRvIGRpc3BsYXkg YXMgdGhlIGxhYmVsIG9mIHRoYXQgVElNRVpPTkUncyB0aW1lLiIKLSAgOmdyb3VwICd3b3JsZC1j bG9jawotICA6dHlwZSAnKHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5nKSkKLSAgOnZlcnNpb24g IjIzLjEiKQotCi0oZGVmY3VzdG9tIGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0Ci0gICcoKCJQU1Q4 UERUIiAiU2VhdHRsZSIpCi0gICAgKCJFU1Q1RURUIiAiTmV3IFlvcmsiKQotICAgICgiR01UMEJT VCIgIkxvbmRvbiIpCi0gICAgKCJDRVQtMUNEVCIgIlBhcmlzIikKLSAgICAoIklTVC01OjMwIiAi QmFuZ2Fsb3JlIikKLSAgICAoIkpTVC05IiAiVG9reW8iKSkKLSAgIkFsaXN0IG9mIHRyYWRpdGlv bmFsLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYHdvcmxkLWNsb2NrJy4KLUVhY2gg ZWxlbWVudCBoYXMgdGhlIGZvcm0gKFRJTUVaT05FIExBQkVMKS4KLVRJTUVaT05FIHNob3VsZCBi ZSBhIHN0cmluZyBvZiB0aGUgZm9ybToKLQotICAgICBzdGRbK3wtXW9mZnNldFtkc3Rbb2Zmc2V0 XVssZGF0ZVsvdGltZV0sZGF0ZVsvdGltZV1dXQotCi1TZWUgdGhlIGRvY3VtZW50YXRpb24gb2Yg dGhlIFRaIGVudmlyb25tZW50IHZhcmlhYmxlIG9uIHlvdXIgc3lzdGVtLAotZm9yIG1vcmUgZGV0 YWlscyBhYm91dCB0aGUgZm9ybWF0IG9mIFRJTUVaT05FLgotTEFCRUwgaXMgYSBzdHJpbmcgdG8g ZGlzcGxheSBhcyB0aGUgbGFiZWwgb2YgdGhhdCBUSU1FWk9ORSdzIHRpbWUuIgotICA6Z3JvdXAg J3dvcmxkLWNsb2NrCi0gIDp0eXBlICcocmVwZWF0IChsaXN0IHN0cmluZyBzdHJpbmcpKQotICA6 dmVyc2lvbiAiMjMuMSIpCi0KLShkZWZjdXN0b20gd29ybGQtY2xvY2stbGlzdCB0Ci0gICJBbGlz dCBvZiB0aW1lIHpvbmVzIGFuZCBwbGFjZXMgZm9yIGB3b3JsZC1jbG9jaycgdG8gZGlzcGxheS4K LUVhY2ggZWxlbWVudCBoYXMgdGhlIGZvcm0gKFRJTUVaT05FIExBQkVMKS4KLVRJTUVaT05FIHNo b3VsZCBiZSBpbiBhIGZvcm1hdCBzdXBwb3J0ZWQgYnkgeW91ciBzeXN0ZW0uICBTZWUgdGhlCi1k b2N1bWVudGF0aW9uIG9mIGB6b25laW5mby1zdHlsZS13b3JsZC1saXN0JyBhbmQKLWBsZWdhY3kt c3R5bGUtd29ybGQtbGlzdCcgZm9yIHR3byB3aWRlbHkgdXNlZCBmb3JtYXRzLiAgTEFCRUwgaXMK LWEgc3RyaW5nIHRvIGRpc3BsYXkgYXMgdGhlIGxhYmVsIG9mIHRoYXQgVElNRVpPTkUncyB0aW1l LgotCi1JZiB0aGUgdmFsdWUgaXMgdCBpbnN0ZWFkIG9mIGFuIGFsaXN0LCB1c2UgdGhlIHZhbHVl IG9mCi1gem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCcgaWYgaXQgd29ya3Mgb24gdGhpcyBwbGF0 Zm9ybSwgYW5kIG9mCi1gbGVnYWN5LXN0eWxlLXdvcmxkLWxpc3QnIG90aGVyd2lzZS4iCi0gIDpn cm91cCAnd29ybGQtY2xvY2sKLSAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRlZmF1bHQi IHQpCi0gICAgICAgICAgICAgICAgIChyZXBlYXQgOnRhZyAiTGlzdCBvZiB6b25lcyBhbmQgbGFi ZWxzIgotICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChzdHJpbmcgOnRhZyAiWm9uZSIp IChzdHJpbmcgOnRhZyAiTGFiZWwiKSkpKQotICA6dmVyc2lvbiAiMjguMSIpCi0KLShkZWZ1biB0 aW1lLS1kaXNwbGF5LXdvcmxkLWxpc3QgKCkKLSAgKGlmIChsaXN0cCB3b3JsZC1jbG9jay1saXN0 KQotICAgICAgd29ybGQtY2xvY2stbGlzdAotICAgIDs7IERldGVybWluZSBpZiB6b25laW5mbyBz dHlsZSB0aW1lem9uZXMgYXJlIHN1cHBvcnRlZCBieSB0ZXN0aW5nIHRoYXQKLSAgICA7OyBBbWVy aWNhL05ldyBZb3JrIGFuZCBFdXJvcGUvTG9uZG9uIHJldHVybiBkaWZmZXJlbnQgdGltZXpvbmVz LgotICAgIChsZXQgKChueXQgKGZvcm1hdC10aW1lLXN0cmluZyAiJXoiIG5pbCAiQW1lcmljYS9O ZXdfWW9yayIpKQotCSAgKGdtdCAoZm9ybWF0LXRpbWUtc3RyaW5nICIleiIgbmlsICJFdXJvcGUv TG9uZG9uIikpKQotICAgICAgKGlmIChzdHJpbmctZXF1YWwgbnl0IGdtdCkKLQkgIGxlZ2FjeS1z dHlsZS13b3JsZC1saXN0Ci0Jem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCkpKSkKLQotKGRlZmN1 c3RvbSB3b3JsZC1jbG9jay10aW1lLWZvcm1hdCAiJUEgJWQgJUIgJVIgJVoiCi0gICJUaW1lIGZv cm1hdCBmb3IgYHdvcmxkLWNsb2NrJywgc2VlIGBmb3JtYXQtdGltZS1zdHJpbmcnLiIKLSAgOmdy b3VwICd3b3JsZC1jbG9jawotICA6dHlwZSAnc3RyaW5nCi0gIDp2ZXJzaW9uICIyOC4xIikKLQot KGRlZmN1c3RvbSB3b3JsZC1jbG9jay1idWZmZXItbmFtZSAiKndjbG9jayoiCi0gICJOYW1lIG9m IHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4iCi0gIDpncm91cCAnd29ybGQtY2xvY2sKLSAgOnR5 cGUgJ3N0cmluZwotICA6dmVyc2lvbiAiMjguMSIpCi0KLShkZWZjdXN0b20gd29ybGQtY2xvY2st dGltZXItZW5hYmxlIHQKLSAgIklmIG5vbi1uaWwsIGEgdGltZXIgd2lsbCB1cGRhdGUgdGhlIGB3 b3JsZC1jbG9jaycgYnVmZmVyLiIKLSAgOmdyb3VwICd3b3JsZC1jbG9jawotICA6dHlwZSAnYm9v bGVhbgotICA6dmVyc2lvbiAiMjguMSIpCi0KLShkZWZjdXN0b20gd29ybGQtY2xvY2stdGltZXIt c2Vjb25kIDYwCi0gICJJbnRlcnZhbCBpbiBzZWNvbmRzIGZvciB1cGRhdGluZyB0aGUgYHdvcmxk LWNsb2NrJyBidWZmZXIuIgotICA6Z3JvdXAgJ3dvcmxkLWNsb2NrCi0gIDp0eXBlICdpbnRlZ2Vy Ci0gIDp2ZXJzaW9uICIyOC4xIikKLQogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBkaXNwbGF5LXRp bWUgKCkKICAgIkVuYWJsZSBkaXNwbGF5IG9mIHRpbWUsIGxvYWQgbGV2ZWwsIGFuZCBtYWlsIGZs YWcgaW4gbW9kZSBsaW5lcy4KQEAgLTI1MSwxNCArMTQ4LDEyIEBAIGRpc3BsYXktdGltZS11c2Ut bWFpbC1pY29uCiAgICJOb24tbmlsIG1lYW5zIHVzZSBhbiBpY29uIGFzIG1haWwgaW5kaWNhdG9y IG9uIGEgZ3JhcGhpYyBkaXNwbGF5LgogT3RoZXJ3aXNlIHVzZSBgZGlzcGxheS10aW1lLW1haWwt c3RyaW5nJy4gIFRoZSBpY29uIG1heSBjb25zdW1lIGxlc3MKIG9mIHRoZSBtb2RlIGxpbmUuICBJ dCBpcyBzcGVjaWZpZWQgYnkgYGRpc3BsYXktdGltZS1tYWlsLWljb24nLiIKLSAgOmdyb3VwICdk aXNwbGF5LXRpbWUKICAgOnR5cGUgJ2Jvb2xlYW4pCiAKIDs7IEZpeG1lOiBtYXliZSBkZWZhdWx0 IHRvIHRoZSBjaGFyYWN0ZXIgaWYgd2UgY2FuIGRpc3BsYXkgVW5pY29kZS4KIChkZWZjdXN0b20g ZGlzcGxheS10aW1lLW1haWwtc3RyaW5nICJNYWlsIgogICAiU3RyaW5nIHRvIHVzZSBhcyB0aGUg bWFpbCBpbmRpY2F0b3IgaW4gYGRpc3BsYXktdGltZS1zdHJpbmctZm9ybXMnLgogVGhpcyBjYW4g dXNlIHRoZSBVbmljb2RlIGxldHRlciBjaGFyYWN0ZXIgaWYgeW91IGNhbiBkaXNwbGF5IGl0LiIK LSAgOmdyb3VwICdkaXNwbGF5LXRpbWUKICAgOnZlcnNpb24gIjIyLjEiCiAgIDp0eXBlICcoY2hv aWNlIChjb25zdCAiTWFpbCIpCiAJCSA7OyBVc2UgOnRhZyBoZXJlIGJlY2F1c2UgdGhlIEx1Y2lk IG1lbnUgd29uJ3QgZGlzcGxheQpAQCAtMjcyLDggKzE2Nyw3IEBAIGRpc3BsYXktdGltZS1mb3Jt YXQKIGhvdyB0byB3cml0ZSB0aGlzIHN0cmluZy4gIElmIHRoaXMgaXMgbmlsLCB0aGUgZGVmYXVs dHMKIGRlcGVuZCBvbiBgZGlzcGxheS10aW1lLWRheS1hbmQtZGF0ZScgYW5kIGBkaXNwbGF5LXRp bWUtMjRoci1mb3JtYXQnLiIKICAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRlZmF1bHQi IG5pbCkKLQkJIHN0cmluZykKLSAgOmdyb3VwICdkaXNwbGF5LXRpbWUpCisJCSBzdHJpbmcpKQog CiAoZGVmY3VzdG9tIGRpc3BsYXktdGltZS1zdHJpbmctZm9ybXMKICAgJygoaWYgKGFuZCAobm90 IGRpc3BsYXktdGltZS1mb3JtYXQpIGRpc3BsYXktdGltZS1kYXktYW5kLWRhdGUpCkBAIC0zMjcs OCArMjIxLDcgQEAgZGlzcGxheS10aW1lLXN0cmluZy1mb3JtcwogICAgIChpZiBtYWlsIFwiIE1h aWxcIiBcIlwiKSkKIAogd291bGQgZ2l2ZSBtb2RlIGxpbmUgdGltZXMgbGlrZSBgOTQvMTIvMzAg MjE6MDc6NDggKFVUQyknLiIKLSAgOnR5cGUgJyhyZXBlYXQgc2V4cCkKLSAgOmdyb3VwICdkaXNw bGF5LXRpbWUpCisgIDp0eXBlICcocmVwZWF0IHNleHApKQogCiAoZGVmdW4gZGlzcGxheS10aW1l LWV2ZW50LWhhbmRsZXIgKCkKICAgKGRpc3BsYXktdGltZS11cGRhdGUpCkBAIC01MzYsNiArNDI5 LDkyIEBAICdkaXNwbGF5LXRpbWUtd29ybGQtdGltZXIKIAwKIDs7OyBXb3JsZCBjbG9jawogCiso ZGVmZ3JvdXAgd29ybGQtY2xvY2sgbmlsCisgICJEaXNwbGF5IGEgd29ybGQgY2xvY2suIgorICA6 Z3JvdXAgJ2Rpc3BsYXktdGltZSkKKworKGRlZmN1c3RvbSB6b25laW5mby1zdHlsZS13b3JsZC1s aXN0CisgICcoKCJBbWVyaWNhL0xvc19BbmdlbGVzIiAiU2VhdHRsZSIpCisgICAgKCJBbWVyaWNh L05ld19Zb3JrIiAiTmV3IFlvcmsiKQorICAgICgiRXVyb3BlL0xvbmRvbiIgIkxvbmRvbiIpCisg ICAgKCJFdXJvcGUvUGFyaXMiICJQYXJpcyIpCisgICAgKCJBc2lhL0NhbGN1dHRhIiAiQmFuZ2Fs b3JlIikKKyAgICAoIkFzaWEvVG9reW8iICJUb2t5byIpKQorICAiQWxpc3Qgb2Ygem9uZWluZm8t c3R5bGUgdGltZSB6b25lcyBhbmQgcGxhY2VzIGZvciBgd29ybGQtY2xvY2snLgorRWFjaCBlbGVt ZW50IGhhcyB0aGUgZm9ybSAoVElNRVpPTkUgTEFCRUwpLgorVElNRVpPTkUgc2hvdWxkIGJlIGEg c3RyaW5nIG9mIHRoZSBmb3JtIEFSRUEvTE9DQVRJT04sIHdoZXJlIEFSRUEgaXMKK3RoZSBuYW1l IG9mIGEgcmVnaW9uIC0tIGEgY29udGluZW50IG9yIG9jZWFuLCBhbmQgTE9DQVRJT04gaXMgdGhl IG5hbWUKK29mIGEgc3BlY2lmaWMgbG9jYXRpb24sIGUuZy4sIGEgY2l0eSwgd2l0aGluIHRoYXQg cmVnaW9uLgorTEFCRUwgaXMgYSBzdHJpbmcgdG8gZGlzcGxheSBhcyB0aGUgbGFiZWwgb2YgdGhh dCBUSU1FWk9ORSdzIHRpbWUuIgorICA6dHlwZSAnKHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5n KSkKKyAgOnZlcnNpb24gIjIzLjEiKQorCisoZGVmY3VzdG9tIGxlZ2FjeS1zdHlsZS13b3JsZC1s aXN0CisgICcoKCJQU1Q4UERUIiAiU2VhdHRsZSIpCisgICAgKCJFU1Q1RURUIiAiTmV3IFlvcmsi KQorICAgICgiR01UMEJTVCIgIkxvbmRvbiIpCisgICAgKCJDRVQtMUNEVCIgIlBhcmlzIikKKyAg ICAoIklTVC01OjMwIiAiQmFuZ2Fsb3JlIikKKyAgICAoIkpTVC05IiAiVG9reW8iKSkKKyAgIkFs aXN0IG9mIHRyYWRpdGlvbmFsLXN0eWxlIHRpbWUgem9uZXMgYW5kIHBsYWNlcyBmb3IgYHdvcmxk LWNsb2NrJy4KK0VhY2ggZWxlbWVudCBoYXMgdGhlIGZvcm0gKFRJTUVaT05FIExBQkVMKS4KK1RJ TUVaT05FIHNob3VsZCBiZSBhIHN0cmluZyBvZiB0aGUgZm9ybToKKworICAgICBzdGRbK3wtXW9m ZnNldFtkc3Rbb2Zmc2V0XVssZGF0ZVsvdGltZV0sZGF0ZVsvdGltZV1dXQorCitTZWUgdGhlIGRv Y3VtZW50YXRpb24gb2YgdGhlIFRaIGVudmlyb25tZW50IHZhcmlhYmxlIG9uIHlvdXIgc3lzdGVt LAorZm9yIG1vcmUgZGV0YWlscyBhYm91dCB0aGUgZm9ybWF0IG9mIFRJTUVaT05FLgorTEFCRUwg aXMgYSBzdHJpbmcgdG8gZGlzcGxheSBhcyB0aGUgbGFiZWwgb2YgdGhhdCBUSU1FWk9ORSdzIHRp bWUuIgorICA6dHlwZSAnKHJlcGVhdCAobGlzdCBzdHJpbmcgc3RyaW5nKSkKKyAgOnZlcnNpb24g IjIzLjEiKQorCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLWxpc3QgdAorICAiQWxpc3Qgb2YgdGlt ZSB6b25lcyBhbmQgcGxhY2VzIGZvciBgd29ybGQtY2xvY2snIHRvIGRpc3BsYXkuCitFYWNoIGVs ZW1lbnQgaGFzIHRoZSBmb3JtIChUSU1FWk9ORSBMQUJFTCkuCitUSU1FWk9ORSBzaG91bGQgYmUg aW4gYSBmb3JtYXQgc3VwcG9ydGVkIGJ5IHlvdXIgc3lzdGVtLiAgU2VlIHRoZQorZG9jdW1lbnRh dGlvbiBvZiBgem9uZWluZm8tc3R5bGUtd29ybGQtbGlzdCcgYW5kCitgbGVnYWN5LXN0eWxlLXdv cmxkLWxpc3QnIGZvciB0d28gd2lkZWx5IHVzZWQgZm9ybWF0cy4gIExBQkVMIGlzCithIHN0cmlu ZyB0byBkaXNwbGF5IGFzIHRoZSBsYWJlbCBvZiB0aGF0IFRJTUVaT05FJ3MgdGltZS4KKworSWYg dGhlIHZhbHVlIGlzIHQgaW5zdGVhZCBvZiBhbiBhbGlzdCwgdXNlIHRoZSB2YWx1ZSBvZgorYHpv bmVpbmZvLXN0eWxlLXdvcmxkLWxpc3QnIGlmIGl0IHdvcmtzIG9uIHRoaXMgcGxhdGZvcm0sIGFu ZCBvZgorYGxlZ2FjeS1zdHlsZS13b3JsZC1saXN0JyBvdGhlcndpc2UuIgorICA6dHlwZSAnKGNo b2ljZSAoY29uc3QgOnRhZyAiRGVmYXVsdCIgdCkKKyAgICAgICAgICAgICAgICAgKHJlcGVhdCA6 dGFnICJMaXN0IG9mIHpvbmVzIGFuZCBsYWJlbHMiCisgICAgICAgICAgICAgICAgICAgICAgICAg KGxpc3QgKHN0cmluZyA6dGFnICJab25lIikgKHN0cmluZyA6dGFnICJMYWJlbCIpKSkpCisgIDp2 ZXJzaW9uICIyOC4xIikKKworKGRlZnVuIHRpbWUtLWRpc3BsYXktd29ybGQtbGlzdCAoKQorICAo aWYgKGxpc3RwIHdvcmxkLWNsb2NrLWxpc3QpCisgICAgICB3b3JsZC1jbG9jay1saXN0CisgICAg OzsgRGV0ZXJtaW5lIGlmIHpvbmVpbmZvIHN0eWxlIHRpbWV6b25lcyBhcmUgc3VwcG9ydGVkIGJ5 IHRlc3RpbmcgdGhhdAorICAgIDs7IEFtZXJpY2EvTmV3IFlvcmsgYW5kIEV1cm9wZS9Mb25kb24g cmV0dXJuIGRpZmZlcmVudCB0aW1lem9uZXMuCisgICAgKGxldCAoKG55dCAoZm9ybWF0LXRpbWUt c3RyaW5nICIleiIgbmlsICJBbWVyaWNhL05ld19Zb3JrIikpCisJICAoZ210IChmb3JtYXQtdGlt ZS1zdHJpbmcgIiV6IiBuaWwgIkV1cm9wZS9Mb25kb24iKSkpCisgICAgICAoaWYgKHN0cmluZy1l cXVhbCBueXQgZ210KQorCSAgbGVnYWN5LXN0eWxlLXdvcmxkLWxpc3QKKwl6b25laW5mby1zdHls ZS13b3JsZC1saXN0KSkpKQorCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLXRpbWUtZm9ybWF0ICIl QSAlZCAlQiAlUiAlWiIKKyAgIlRpbWUgZm9ybWF0IGZvciBgd29ybGQtY2xvY2snLCBzZWUgYGZv cm1hdC10aW1lLXN0cmluZycuIgorICA6dHlwZSAnc3RyaW5nCisgIDp2ZXJzaW9uICIyOC4xIikK KworKGRlZmN1c3RvbSB3b3JsZC1jbG9jay1idWZmZXItbmFtZSAiKndjbG9jayoiCisgICJOYW1l IG9mIHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIDp0eXBlICdzdHJpbmcKKyAgOnZlcnNp b24gIjI4LjEiKQorCisoZGVmY3VzdG9tIHdvcmxkLWNsb2NrLXRpbWVyLWVuYWJsZSB0CisgICJJ ZiBub24tbmlsLCBhIHRpbWVyIHdpbGwgdXBkYXRlIHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4i CisgIDp0eXBlICdib29sZWFuCisgIDp2ZXJzaW9uICIyOC4xIikKKworKGRlZmN1c3RvbSB3b3Js ZC1jbG9jay10aW1lci1zZWNvbmQgNjAKKyAgIkludGVydmFsIGluIHNlY29uZHMgZm9yIHVwZGF0 aW5nIHRoZSBgd29ybGQtY2xvY2snIGJ1ZmZlci4iCisgIDp0eXBlICdpbnRlZ2VyCisgIDp2ZXJz aW9uICIyOC4xIikKKwogKGRlZmZhY2Ugd29ybGQtY2xvY2stbGFiZWwKICAgJygodCA6aW5oZXJp dCBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKICAgIkZhY2UgZm9yIHRpbWUgem9uZSBs YWJlbCBpbiBgd29ybGQtY2xvY2snIGJ1ZmZlci4iKQotLSAKMi4yOC4wCgo= --0000000000005fdcb105ac791d15-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 09:49:49 2020 Received: (at 40863) by debbugs.gnu.org; 18 Aug 2020 13:49:49 +0000 Received: from localhost ([127.0.0.1]:34568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k81zo-0007Bd-SH for submit@debbugs.gnu.org; Tue, 18 Aug 2020 09:49:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:32856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k81zm-0007BK-6z for 40863@debbugs.gnu.org; Tue, 18 Aug 2020 09:49:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EIBS4zENNSbTELbLTkOWdJvTzRAo01pp8dZOKCZSFKM=; b=jFjVFpmOkTLQSmglvS5nqchfNO qcfIXUQMVrhjFY6rOX1pi14Pt3JIuwys80hjGD3vToggh4jhcCqaaZ9lso3PV66gdxayJtUtvoT6y KiubWmIG0brC8F8SlzwshnQ442uehbj3jfVgWxNKjF+NBw4mLw6OEyLNgCKV1XTnhWqg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k81zd-0007XO-AB; Tue, 18 Aug 2020 15:49:39 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> <878seqgx94.fsf@tcd.ie> X-Now-Playing: Cocteau Twins's _Echoes in a Shallow Bay_: "Pale Clouded White" Date: Tue, 18 Aug 2020 15:49:35 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 9 Aug 2020 15:11:06 -0700") Message-ID: <87y2mckqs0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > +*** 'display-time-world' has been renamed to 'world-clock'. > +'world-clock' creates a buffer with an updating time display using > +several time zones. It is hoped that the new names are more > +d [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40863 Cc: "Basil L. Contovounesios" , 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > +*** 'display-time-world' has been renamed to 'world-clock'. > +'world-clock' creates a buffer with an updating time display using > +several time zones. It is hoped that the new names are more > +discoverable. Looks like this was supposed to be applied, but it doesn't look like it has been yet? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 10:37:56 2020 Received: (at 40863) by debbugs.gnu.org; 18 Aug 2020 14:37:56 +0000 Received: from localhost ([127.0.0.1]:36597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82kO-0004si-DW for submit@debbugs.gnu.org; Tue, 18 Aug 2020 10:37:56 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82kM-0004sW-NG for 40863@debbugs.gnu.org; Tue, 18 Aug 2020 10:37:55 -0400 Received: by mail-yb1-f182.google.com with SMTP id e187so11516350ybc.5 for <40863@debbugs.gnu.org>; Tue, 18 Aug 2020 07:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=yQt27+mQXQp5A1duIEK13RnXO3cBbDkRN85ujab7cB4=; b=S5nkwL5d6UNV3TyVQAOhXbKmH7lFtIbeck4RxM6VRX6xlRHhAerKoK0KAQ1UjI4Muu gu9wVaN9PE3Ni7WmplqLlHAwLa+YBz6Z/yhDKwnaVa7k3gF2WL5YHKo6aYyt5oiW7H6s sSiZlktQfGtT6v4UL7w1m1UW+Pi4lkDm1xFUZ4eIsyHfvV3fSZAM0VYyJnROu8PSgF9s LJ233ieu5xrdt1BEzPCUWGFwCnjWzQD54RFaCy23UX1E0CX2oKuzkM6aKL3syJ0YgThB +zeIPe3C/Vmpg46m+rin4mL7l8j0nps94JTLGZKPP1MJ6HnRJrRA5dYvcEpRGWrZhtDU l27Q== X-Gm-Message-State: AOAM532d0UZ7QgPXlEBcOI4MtPFIak1toIL8wKrXGySTWeGSN/Uvrrkt EGjq76u7l+pZhzX65QQjsDVeshpbFCqUyyxma3U= X-Google-Smtp-Source: ABdhPJwWeOMEIvlC9WDwYU5lIWNujkPiBxV/K6gPn4SEQ5n/ZVXFgilY8NpfRiCV3DSen+X1xSSSh0O70RVbDfKyaIQ= X-Received: by 2002:a25:7007:: with SMTP id l7mr27040076ybc.85.1597761469134; Tue, 18 Aug 2020 07:37:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Aug 2020 14:37:48 +0000 From: Stefan Kangas In-Reply-To: <87y2mckqs0.fsf@gnus.org> References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> <878seqgx94.fsf@tcd.ie> <87y2mckqs0.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 18 Aug 2020 14:37:48 +0000 Message-ID: Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 40863 Cc: "Basil L. Contovounesios" , 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Looks like this was supposed to be applied, but it doesn't look like it > has been yet? I wanted to give Basil some time to comment, since he had some feedback on the previous patches. But I guess 9 days is plenty in this case, so I'll look this all over one final time and push it when I find some time. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 14:23:31 2020 Received: (at 40863) by debbugs.gnu.org; 18 Aug 2020 18:23:31 +0000 Received: from localhost ([127.0.0.1]:36966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k86Gh-0000h5-LG for submit@debbugs.gnu.org; Tue, 18 Aug 2020 14:23:31 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:36569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k86Gg-0000gm-64 for 40863@debbugs.gnu.org; Tue, 18 Aug 2020 14:23:30 -0400 Received: by mail-yb1-f170.google.com with SMTP id g3so11898433ybc.3 for <40863@debbugs.gnu.org>; Tue, 18 Aug 2020 11:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=zwUWr/pq8LmPRxk/rRPI1a0uUDzl8wpXKsUlgWpjGGs=; b=czKsdh+ldlokWEOOBe0SheYLOUoeWT+QIoKkM4BIT8ChllRkK2mduHY1tfqnZL41+t ViDfNoU3rjiqZ6B7k8BoUOCXLXTc8QSyxtySVZDR1eiy4m8zCMSpZMwtaN5HUVLtF68q CRtXF9kUTzAOLbZvmL9Mrk2Yvcf8VoTmUXtBmJSOxVef1dGYLivNcYPCovzQpGDYxXyR ysVcEAfDxb5kc4hE9KVVzUwAwUM0MmctqofcO/g8ig3fVZlJz/XyiiFdry9yY/3TV65P 9+Yz19b1zdf6dt60RJqiyjoLz30er9WqQJ1OlDrzTLBko1PYqnEMJkHiRXZMw2McGRoL 8ozQ== X-Gm-Message-State: AOAM531vYmyha41eeWc+Zvnj5tEmiSdrFMbA78M6eJq63oEQErRElh5k nXe/1FKmYRXd3N5crfLXcu+39B889f5CkiRHh4w= X-Google-Smtp-Source: ABdhPJz+p2JxrnJd0/KUARa9bN504YVIndImh5Qd5LcMcXlYqr1o4wx93PbqeQQ+GfnTX49nojo4jJ0MkCjMv1afy/c= X-Received: by 2002:a25:b290:: with SMTP id k16mr28036359ybj.389.1597775004708; Tue, 18 Aug 2020 11:23:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 18 Aug 2020 18:23:24 +0000 From: Stefan Kangas In-Reply-To: References: <874kt4y1rc.fsf@tcd.ie> <87k11u48t0.fsf@stefankangas.se> <87y2pircll.fsf@tcd.ie> <878seqgx94.fsf@tcd.ie> <87y2mckqs0.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 18 Aug 2020 18:23:24 +0000 Message-ID: Subject: Re: bug#40863: [PATCH] Improve the display-time-world UI To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 40863 Cc: "Basil L. Contovounesios" , 40863@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 40863 28.1 thanks Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> Looks like this was supposed to be applied, but it doesn't look like it >> has been yet? > > I wanted to give Basil some time to comment, since he had some feedback > on the previous patches. But I guess 9 days is plenty in this case, so > I'll look this all over one final time and push it when I find some > time. Now pushed to master as commit c70b5e8ad0. Closing. Best regards, Stefan Kangas From unknown Tue Aug 19 14:23:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Sep 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator