GNU bug report logs - #40862
gnu: Add xarchiver.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40862 in the body.
You can then email your comments to 40862 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: Add xarchiver.
Date: Sun, 26 Apr 2020 04:51:29 -0400

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-xarchiver.patch (text/x-patch, attachment)]

Message #8 received at 40862 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40862 <at> debbugs.gnu.org
Subject: Re: [bug#40862] gnu: Add xarchiver.
Date: Sun, 26 Apr 2020 11:22:21 +0200

Hello Raghav,

Thanks for this patch. When running 'guix lint' on this patch, I have
the following warnings:

--8<---------------cut here---------------start------------->8---
/home/mathieu/guix-master/gnu/packages/compression.scm:87:5: xarchiver <at> 0.5.4.14: the source file name should contain the package name
/home/mathieu/guix-master/gnu/packages/compression.scm:87:5: xarchiver <at> 0.5.4.14: the source URI should not be an autogenerated tarball
fetching CVE database for 2020......
fetching CVE database for 2019...
fetching CVE database for 2018...
fetching CVE database for 2017...
/home/mathieu/guix-master/gnu/packages/compression.scm:85:13: xarchiver <at> 0.5.4.14: can be upgraded to 0.5b2
--8<---------------cut here---------------end--------------->8---

>  
> +(define-public xarchiver
> +  (package
> +    (name "xarchiver")
> +    (version "0.5.4.14")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "https://github.com/ib/" name "/archive/"
> +                       version ".tar.gz"))

You should use "git-fetch" method for github repositories (see linter
warning above).

> +       (list
> +        "--disable-plugin")))           ; Not required

Why is it not required?

> +    (synopsis "Graphical Front-end for Archive Operations")

No camel case notation.

> +    (description "Xarchiver is the ultimate solution for handling archives.  It
> +is a desktop-environment independent archiver front end.")

"Ultimate" is maybe exaggerated! Also you could elaborate a bit on the
functionalities of this tool.

Thanks,

Mathieu

Message #11 received at 40862 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 40862 <at> debbugs.gnu.org
Subject: Re: [bug#40862] gnu: Add xarchiver. (v2)
Date: Sun, 26 Apr 2020 05:53:05 -0400

[Message part 1 (text/plain, inline)]

Hello Mathieu!

> Thanks for this patch. When running 'guix lint' on this patch, I have
> the following warnings:
> 
> --8<---------------cut here---------------start------------->8---
> /home/mathieu/guix-master/gnu/packages/compression.scm:87:5:
> xarchiver <at> 0.5.4.14: the source file name should contain the package name
> /home/mathieu/guix-master/gnu/packages/compression.scm:87:5:
> xarchiver <at> 0.5.4.14: the source URI should not be an autogenerated tarball
> fetching CVE database for 2020...... fetching CVE database for 2019...
> fetching CVE database for 2018... fetching CVE database for 2017...
> /home/mathieu/guix-master/gnu/packages/compression.scm:85:13:
> xarchiver <at> 0.5.4.14: can be upgraded to 0.5b2 --8<---------------cut
> here---------------end--------------->8---
> 
> >  
> > +(define-public xarchiver
> > +  (package
> > +    (name "xarchiver")
> > +    (version "0.5.4.14")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri
> > +        (string-append "https://github.com/ib/" name "/archive/"
> > +                       version ".tar.gz"))  
> 
> You should use "git-fetch" method for github repositories (see linter
> warning above).
> 
> > +       (list
> > +        "--disable-plugin")))           ; Not required  
> 
> Why is it not required?
> 
> > +    (synopsis "Graphical Front-end for Archive Operations")  
> 
> No camel case notation.
> 
> > +    (description "Xarchiver is the ultimate solution for handling
> > archives.  It +is a desktop-environment independent archiver front end.")  
> 
> "Ultimate" is maybe exaggerated! Also you could elaborate a bit on the
> functionalities of this tool.

Please find the revised patch attached with this email.

Regards,
RG.

[0001-gnu-Add-xarchiver.patch (text/x-patch, attachment)]

Message #14 received at 40862 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40862 <at> debbugs.gnu.org
Subject: Re: [bug#40862] gnu: Add xarchiver. (v2)
Date: Sun, 26 Apr 2020 12:29:05 +0200

Hello Raghav,

I applied 'fill-region' over the description, moved it to the end of
the file and pushed.

Thanks,

Mathieu

Message #19 received at 40862-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40862-done <at> debbugs.gnu.org
Subject: Re: [bug#40862] gnu: Add xarchiver. (v2)
Date: Sun, 26 Apr 2020 12:29:22 +0200

Hello Raghav,

I applied 'fill-region' over the description, moved it to the end of
the file and pushed.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.