From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 23:40:46 2020 Received: (at submit) by debbugs.gnu.org; 26 Apr 2020 03:40:46 +0000 Received: from localhost ([127.0.0.1]:60682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSY9u-0002Xi-1z for submit@debbugs.gnu.org; Sat, 25 Apr 2020 23:40:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:38622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSY9r-0002Xa-V2 for submit@debbugs.gnu.org; Sat, 25 Apr 2020 23:40:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39992) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSY9r-00045n-9m for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 23:40:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSY9q-0004Ps-CS for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 23:40:43 -0400 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]:42238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSY9q-0004Pk-0W for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 23:40:42 -0400 Received: by mail-qt1-x834.google.com with SMTP id x12so10973303qts.9 for ; Sat, 25 Apr 2020 20:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=iXjNKobQq8okwy8XbQEZ84QH4jqEx9cftH2+7/1uBIc=; b=HK4LXwZ6CgzU9Jp2tvtRGbCVN3byovROhPijsseiB9Az3fQokI4PFgFcFchYyoET14 WbuMZsNEOTHybDs2D5Ll4L4/sGpaO2s81lCDRjzFmB3wD2lxun3ZDNg9DjlFdQhMS5Qm ZSMRuURvt4GpMkVtdAAffB9k4ZeVdQF/o+krDCT4DELw6DJwvV5wEO9CqmSo3ZNvMUtz VIjW59fLvQx8cEi4AwBRFyHse3Z1Q51mSLK6ELSdW65VRodhhnCIk7+SVErfG3qTq509 SlyQjPSzT1jt8U8B6iDqJMAsxcrLOhp/sj1LH2OsgMyK1TT2KnaJEbmMWPcjbv1SJYms 2avA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=iXjNKobQq8okwy8XbQEZ84QH4jqEx9cftH2+7/1uBIc=; b=uLotP4otEyvt+kYCYI8QzqRIrRj8jUIxThcUPmxNvUVuP9kQdIA3fcDxYGM2NlePIP 9E7j/8hKjna9iKLZWxeROODTJ8w7SwsChh6ONV+0ammtmQKh9Tpnko4tp9wyr07ZP558 qvWzcrd6eegusAAGwrwJjpD2T1EzzbjlZbWpPhLopoGP+N/m2+c1/LUZP6/WbLtlLnD1 YV/D40xSXPo1sHEYG8JfTDocEZSNJrL2ZEHx+vPeFeifKSKMZf9Xlhjdp1XKoeRjiNUL 3l7ShWt8GdQDNmdgIHEwOCZcVFEKXYmj+gbs/qswtDx9HS212h2bJJNZ88kpJ43RbO2W 9qeg== X-Gm-Message-State: AGi0PubXi7twEwKVzr6Inij8BC+T7GTJWtTFcvmRG0FPWTdxeIPb+Am3 tLQsVdW6tT1W+2+LUnGRzagM+sf5sk4= X-Google-Smtp-Source: APiQypLVQEnOhF8ZEI8gX3l0vDxPcAoSv+bsxDJokr8KTpPNYnkLB3NNg4F2G4hRC2Ty4C4cmDq75Q== X-Received: by 2002:aed:2ac4:: with SMTP id t62mr17660867qtd.381.1587872440618; Sat, 25 Apr 2020 20:40:40 -0700 (PDT) Received: from ?IPv6:2601:184:4180:66e7:54d6:bfeb:aa49:9d3b? ([2601:184:4180:66e7:54d6:bfeb:aa49:9d3b]) by smtp.googlemail.com with ESMTPSA id x22sm1592881qtr.57.2020.04.25.20.40.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Apr 2020 20:40:40 -0700 (PDT) To: bug-gnu-emacs From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Subject: Clicking the wrap-prefix string inside a button causes an error Message-ID: Date: Sat, 25 Apr 2020 23:40:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=cpitclaudel@gmail.com; helo=mail-qt1-x834.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::834 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi all, The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below. (with-current-buffer (get-buffer-create "*button*") (erase-buffer) (insert-text-button (let ((str "long long long long text ")) (concat str str str str str)) 'follow-link t 'action (lambda (&rest args) (print args)) 'wrap-prefix "this is the wrap prefix") (pop-to-buffer (current-buffer))) Debugger entered--Lisp error: (void-function nil) nil(("this is the wrap prefix" . 9)) button-activate(("this is the wrap prefix" . 9) t) push-button((mouse-2 (# 81 (76 . 29) 379842354 ("this is the wrap prefix" . 9) 81 (9 . 1) nil (4 . 12) (8 . 17)))) funcall-interactively(push-button (mouse-2 (# 81 (76 . 29) 379842354 ("this is the wrap prefix" . 9) 81 (9 . 1) nil (4 . 12) (8 . 17)))) call-interactively(push-button nil nil) command-execute(push-button) Cheers, Clément. In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-03-15 built on clem-w50-mint Repository revision: 9dccaf8a5cdb10dae597345ec3741475477a7d97 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Linux Mint 19.3 Recent messages: Mark set # button-activate: Symbol’s function definition is void: nil Debug on Error enabled globally Entering debugger... Mark set [2 times] Saved text until "nil nil) command-execute(push-button) " Mark set Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: en_DK.UTF-8 value of $LC_NUMERIC: en_DK.UTF-8 value of $LC_TIME: en_DK.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print debug backtrace help-mode easymenu find-func cus-start cus-load time-date subr-x cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 57304 5023) (symbols 48 7631 1) (strings 32 18904 1618) (string-bytes 1 584373) (vectors 16 10294) (vector-slots 8 143875 8980) (floats 8 30 160) (intervals 56 309 0) (buffers 1000 14)) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 09:44:09 2020 Received: (at 40859) by debbugs.gnu.org; 26 Apr 2020 13:44:09 +0000 Received: from localhost ([127.0.0.1]:32859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShZo-0005HJ-N2 for submit@debbugs.gnu.org; Sun, 26 Apr 2020 09:44:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jShZm-0005Gb-Je for 40859@debbugs.gnu.org; Sun, 26 Apr 2020 09:44:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43290) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jShZh-0008NQ-9D; Sun, 26 Apr 2020 09:44:01 -0400 Received: from [176.228.60.248] (port=2392 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jShZg-0003Ym-59; Sun, 26 Apr 2020 09:44:00 -0400 Date: Sun, 26 Apr 2020 16:43:53 +0300 Message-Id: <837dy2746e.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel In-Reply-To: (message from =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel on Sat, 25 Apr 2020 23:40:38 -0400) Subject: Re: bug#40859: Clicking the wrap-prefix string inside a button causes an error References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40859 Cc: 40859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Clément Pit-Claudel > Date: Sat, 25 Apr 2020 23:40:38 -0400 > > The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below. Isn't that a cockpit error? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 11:59:52 2020 Received: (at 40859) by debbugs.gnu.org; 26 Apr 2020 15:59:52 +0000 Received: from localhost ([127.0.0.1]:33978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSjhA-0003Fw-Ff for submit@debbugs.gnu.org; Sun, 26 Apr 2020 11:59:52 -0400 Received: from mail-qv1-f44.google.com ([209.85.219.44]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSjh9-0003Fk-3l for 40859@debbugs.gnu.org; Sun, 26 Apr 2020 11:59:51 -0400 Received: by mail-qv1-f44.google.com with SMTP id di6so7249201qvb.10 for <40859@debbugs.gnu.org>; Sun, 26 Apr 2020 08:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s+32UMFCSjny4KS366ohRNkBAeOwtxrANSDjpirY3D8=; b=I9Rovw33btqfM+Dh8MinkX+1uoNi6S+X9hWZZBz/yv0idPFAySVRaPPKj3GknKN01O FSPh6KlFFNYKeiHCfh2WnOgBq5CYHTwRilxHxQjgn+ycRZ09cNoGGvvqxvobWLDOYyrg nyaAupaygFdxJ+qGSVQuchFgQYOk+m9le32UuwfQe/PKwt3tZnwQfs4mtdMXXo2vc9c3 RHTbswgRVD/pcmzb0yXEV9fqxPFs1r9CiMIgo1aunGzERE+/VYrmD0bGQX7C/SVxPQ58 BVtLll3i5oPXXl1gvIMH9SUE/wAqdTrlcZl3C5kOwli30YqdrtYzntK8Y8atjD/wF8Vw +TEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s+32UMFCSjny4KS366ohRNkBAeOwtxrANSDjpirY3D8=; b=nZFHzZZm7XcLWs5NlGNKKYciyjBMnap86zmKMUVJPlmOA+3P7rUmRygwj/xTM2YWa2 tfQZcKeaoTbJ4D5r7FQfAU3cv8KN4mOkX2LmT/1zGfHk2Cfw+f/FsQIz2J54MCzsTKGF XJNKPkZ0ltkC5fBga8MItnL1Ln+MVhvlYSsOyG95h1wOV6rAFZanvagTGvcVuv2kj2vN 1+bpMrqQslL0ib88JYb+1WnthkySvBLT/nB58A6CsgRgNHHdXBQCEuafPzu9cyBS5fKr 8b7pfFouds/UladtqjxiPTP7RhvO0mejT9tLod72Ue6otCgivlXFweIgyqmPKgAnywJP 4Y6Q== X-Gm-Message-State: AGi0PuYttkEseBMmiUSeGAVACxY3Z3rBCDAb37QuPMXCkPwZPkcRiRle H4HDb8JySO5v0mpglDUDFzbSPIYn X-Google-Smtp-Source: APiQypKyDqQGVOZDEJfR48p19V4hJZH/dp/Ln0bySdHsR0sRYe4dpkoG2iAHzAtP1NBoxqjoYc65YA== X-Received: by 2002:a0c:f781:: with SMTP id s1mr18462432qvn.182.1587916785322; Sun, 26 Apr 2020 08:59:45 -0700 (PDT) Received: from ?IPv6:2601:184:4180:66e7:54d6:bfeb:aa49:9d3b? ([2601:184:4180:66e7:54d6:bfeb:aa49:9d3b]) by smtp.googlemail.com with ESMTPSA id 70sm8007995qkh.67.2020.04.26.08.59.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2020 08:59:44 -0700 (PDT) Subject: Re: bug#40859: Clicking the wrap-prefix string inside a button causes an error To: Eli Zaretskii References: <837dy2746e.fsf@gnu.org> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <124dc988-fd65-7bf2-de20-b8d5e8467089@gmail.com> Date: Sun, 26 Apr 2020 11:59:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <837dy2746e.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40859 Cc: 40859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 26/04/2020 09.43, Eli Zaretskii wrote: >> From: Clément Pit-Claudel >> Date: Sat, 25 Apr 2020 23:40:38 -0400 >> >> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below. > > Isn't that a cockpit error? Nope, I think not. It's button.el getting confused about where the click came from. And it's not fixable from the cockpit, I think, since wrap-prefixes and other replacing display specs can't have extra properties like an 'action that would make button.el happy. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 12:44:26 2020 Received: (at 40859) by debbugs.gnu.org; 26 Apr 2020 16:44:26 +0000 Received: from localhost ([127.0.0.1]:34012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSkOI-0004LY-1P for submit@debbugs.gnu.org; Sun, 26 Apr 2020 12:44:26 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:39482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSkOG-0004LL-7M for 40859@debbugs.gnu.org; Sun, 26 Apr 2020 12:44:25 -0400 Received: by mail-qk1-f173.google.com with SMTP id o135so3247176qke.6 for <40859@debbugs.gnu.org>; Sun, 26 Apr 2020 09:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=Yowa1GxGeTS3pVVKve/8/KnHNSNRmabgn2CAr5gYs8M=; b=o817L/mtfIz7Zcuq5ucDON/6UkLQsMT6lDF5e5oXwuXX/cvGhj0HIKXmt68AIJadz7 xsX344mNhN/bpBhjdvJ/vTCaJGUvan0U523kOXGVfnsH0KLdmU2BGePF0SAy5QxbgoUB ZuEIbGIvudEAnNS4EMerD7KUCs4DLbriO2JJvB+EZaPPlhiYV9pBuj5sm400T5jZSNVc nbBpiNxCVoE4Vzw42H0jtZ4xJ5TYhpsMwHT+6tOBVV/izEIJ6ew+1Czvtp6iFxWAgvsG bD020FcOa3wWQ/nt2lFYg2rfk/HgPOFPZp++nMsdbpFZibizFVl5//sZsRy3cQWIRbS+ 9uTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=Yowa1GxGeTS3pVVKve/8/KnHNSNRmabgn2CAr5gYs8M=; b=EUvRC3elW2LYNbJjHvFti8iYYUBXcwpYjf/YAJn2pIg0/NEyJmlyVcHfw3ZeqwS83G fSG6+VbUkUSBKqxcfUI/bMtrJuA/6BHXHx+GyRPjoOZC/N+rJ9OckDGdUzvPl+LxtGRJ YJltgweHnthQVjv77Pa2GQpGdBZH/llsS9XxB4W6q9L9F4/6CMqIxisdVAX/WWOluukF AJTt3+BpoUSCHEcXK3wMSmHgTZ5wtc539bAZJM0Gb/o2e2UBZCxts538yQX8SMPQnVaI dvS/8FyTwIu0mjvmLTRzc8B+8F+plxXRZD4OaUBdleiyftc0seb08f9Z5U1ERQFfuTqn WhFA== X-Gm-Message-State: AGi0PuaYsNhnl6ft8jrJcr05M0GdS1I54fxGKq1vpbl1dJzfhhLA/EBt Wq8ioGmP44jlTn1gyXPfKmGXfaMPaTA= X-Google-Smtp-Source: APiQypIus5f9V4iz7LbDU2BVxhluplCjnSe1VW3xGQR+FbJX7X3vqosY/UUDGGbUzV1ZQvuKSzOupQ== X-Received: by 2002:a37:af05:: with SMTP id y5mr19070898qke.471.1587919458347; Sun, 26 Apr 2020 09:44:18 -0700 (PDT) Received: from ?IPv6:2601:184:4180:66e7:54d6:bfeb:aa49:9d3b? ([2601:184:4180:66e7:54d6:bfeb:aa49:9d3b]) by smtp.googlemail.com with ESMTPSA id z26sm8084784qkg.39.2020.04.26.09.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2020 09:44:17 -0700 (PDT) Subject: Re: bug#40859: Clicking the wrap-prefix string inside a button causes an error To: Eli Zaretskii References: <837dy2746e.fsf@gnu.org> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <98b37654-1133-05b7-a7b1-3f32b9a74ad9@gmail.com> Date: Sun, 26 Apr 2020 12:44:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <837dy2746e.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------5252D7B6CF06BEA71BFB0D35" Content-Language: en-GB X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40859 Cc: 40859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------5252D7B6CF06BEA71BFB0D35 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 26/04/2020 09.43, Eli Zaretskii wrote: >> From: Clément Pit-Claudel >> Date: Sat, 25 Apr 2020 23:40:38 -0400 >> >> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below. > > Isn't that a cockpit error? Here's a tentative patch, but I can't claim to understand the button.el code well :/ --------------5252D7B6CF06BEA71BFB0D35 Content-Type: text/x-patch; charset=UTF-8; name="0001-Only-treat-display-strings-as-buttons-if-they-have-a.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Only-treat-display-strings-as-buttons-if-they-have-a.pa"; filename*1="tch" >From 11034798933a1e0c9498b0409cd463acb822f2d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= Date: Sun, 26 Apr 2020 12:41:42 -0400 Subject: [PATCH] Only treat display strings as buttons if they have a 'button property * lisp/button.el (push-button): Use posn-point instead of posn-string if the string doesn't have a 'button property (Bug#40859). --- lisp/button.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/button.el b/lisp/button.el index b3afc4eca2..c33a3e8ac2 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -469,10 +469,12 @@ push-button ;; POS is a mouse event; switch to the proper window/buffer (let ((posn (event-start pos))) (with-current-buffer (window-buffer (posn-window posn)) - (if (posn-string posn) - ;; mode-line, header-line, or display string event. - (button-activate (posn-string posn) t) - (push-button (posn-point posn) t)))) + (let* ((str (posn-string posn)) + (str-button (get-text-property (cdr str) 'button (car str)))) + (if (and str str-button) + ;; mode-line, header-line, or display string event. + (button-activate str t) + (push-button (posn-point posn) t))))) ;; POS is just normal position (let ((button (button-at (or pos (point))))) (when button -- 2.17.1 --------------5252D7B6CF06BEA71BFB0D35-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 14:27:57 2020 Received: (at 40859) by debbugs.gnu.org; 26 Apr 2020 18:27:57 +0000 Received: from localhost ([127.0.0.1]:34872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSm0T-0001Zy-IJ for submit@debbugs.gnu.org; Sun, 26 Apr 2020 14:27:57 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:37854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSm0S-0001Zl-Gp for 40859@debbugs.gnu.org; Sun, 26 Apr 2020 14:27:56 -0400 Received: by mail-qt1-f182.google.com with SMTP id k12so12532463qtm.4 for <40859@debbugs.gnu.org>; Sun, 26 Apr 2020 11:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=XDnBgOdvCn0bfNaFN0Yexb9L/q0anRO4k9pUMXMbBUw=; b=n1G8UFCfk8VNRFR/SZmDG7CDgp2xh1qzaI8yeSq1h+FUJ21UQ3X3qzonVxAGJH7B5X lfszLtE/3Wku/aR36wyp/KT0QfP7517ZKg1eVJTvQ34TFYUrU6aeFJ87zOR7FyNxOV7p 0QVrvRmA+erKfr2sgnwtmb/VrTub0D9oHYueT7P6+RWE5hDXlU76CKJj+k4Jnxh4oFqs W62mRjIpdy8rPAYFnH9WnIua7/IxcpAl9Fk2Fbajlkv5haW/U5dJFtVEBdiNuvneIOAN BOG63VgBxsngl0jXeZooCJ6cNuPbuepWp50UcpSKUafpKTGvxk6OSjralv9JNqb24S3r UmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=XDnBgOdvCn0bfNaFN0Yexb9L/q0anRO4k9pUMXMbBUw=; b=B4XkC/mcLr7ycwR2LQSBmiFlYC3K/9D6R2YJ8T6Tv9aWNijmuBm8SPjezo9Z6sHDuc ShWsjv3FMlLJc0E8ABeP5MTMJrsPH7H0uqy5alPvrT9KGuWnHdBecUR2xXxLRmDnsBiT jiLHLTkZZ0/l9w4edWDc3oVDXwgACJVwm300zvH6vAK9kK9cgLP6uNiPCqWlUndPLVr7 18zZXLrJ2QTsdmxa1xqTRCh5KuqT7LJt8vOP67aMvF4+MKcGl3CEVFEG3JU109+Dt+83 O0xrKoM8CRyAFkKszPahatBFzuzaWb00vZRicnBdpd6ygiLwZAxY+nhpYyRBPQ02DXiK 2feA== X-Gm-Message-State: AGi0PuYaV64iQ+TGdovciNQSsZnLuZJ6Us8UHdbXelgVFiCUs5OiH50a mWK2tjMRSAYNvz7xbIMftzOkqJLB X-Google-Smtp-Source: APiQypJboCQ8lPdbUcJQ2j6/tqtCGCsw+op9ENbG87W015vzkkgBBFqlA0moWKctvm4C4NFSEnik5w== X-Received: by 2002:aed:2142:: with SMTP id 60mr19842283qtc.177.1587925670927; Sun, 26 Apr 2020 11:27:50 -0700 (PDT) Received: from ?IPv6:2601:184:4180:66e7:54d6:bfeb:aa49:9d3b? ([2601:184:4180:66e7:54d6:bfeb:aa49:9d3b]) by smtp.googlemail.com with ESMTPSA id 67sm5146972qkm.68.2020.04.26.11.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2020 11:27:50 -0700 (PDT) Subject: Re: bug#40859: Clicking the wrap-prefix string inside a button causes an error From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= To: Eli Zaretskii References: <837dy2746e.fsf@gnu.org> <98b37654-1133-05b7-a7b1-3f32b9a74ad9@gmail.com> Message-ID: <5820e370-0933-be24-daae-0fb52f2d7ee8@gmail.com> Date: Sun, 26 Apr 2020 14:27:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <98b37654-1133-05b7-a7b1-3f32b9a74ad9@gmail.com> Content-Type: multipart/mixed; boundary="------------F9EA46CB5C3FA14913FB5723" Content-Language: en-GB X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40859 Cc: 40859@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------F9EA46CB5C3FA14913FB5723 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 26/04/2020 12.44, Clément Pit-Claudel wrote: > On 26/04/2020 09.43, Eli Zaretskii wrote: >>> From: Clément Pit-Claudel >>> Date: Sat, 25 Apr 2020 23:40:38 -0400 >>> >>> The following snippet inserts a button with a long label and a wrap-prefix. Clicking the prefix causes an error, whose backtrace is shown below. >> >> Isn't that a cockpit error? > > Here's a tentative patch, but I can't claim to understand the button.el code well :/ A slightly revised version. --------------F9EA46CB5C3FA14913FB5723 Content-Type: text/x-patch; charset=UTF-8; name="0001-Only-treat-display-strings-as-buttons-if-they-have-a.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Only-treat-display-strings-as-buttons-if-they-have-a.pa"; filename*1="tch" >From fd57a05b6598de77dbf9a7ba66a15dc1cd9568a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= Date: Sun, 26 Apr 2020 12:41:42 -0400 Subject: [PATCH] Only treat display strings as buttons if they have a 'button property * lisp/button.el (push-button): Use posn-point instead of posn-string if the string doesn't have a 'button property (Bug#40859). --- lisp/button.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/button.el b/lisp/button.el index b3afc4eca2..3a6a6de774 100644 --- a/lisp/button.el +++ b/lisp/button.el @@ -469,10 +469,12 @@ push-button ;; POS is a mouse event; switch to the proper window/buffer (let ((posn (event-start pos))) (with-current-buffer (window-buffer (posn-window posn)) - (if (posn-string posn) - ;; mode-line, header-line, or display string event. - (button-activate (posn-string posn) t) - (push-button (posn-point posn) t)))) + (let* ((str (posn-string posn)) + (str-button (and str (get-text-property (cdr str) 'button (car str))))) + (if str-button + ;; mode-line, header-line, or display string event. + (button-activate str t) + (push-button (posn-point posn) t))))) ;; POS is just normal position (let ((button (button-at (or pos (point))))) (when button -- 2.17.1 --------------F9EA46CB5C3FA14913FB5723-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 03:44:08 2020 Received: (at 40859-done) by debbugs.gnu.org; 9 May 2020 07:44:08 +0000 Received: from localhost ([127.0.0.1]:46757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXK9X-0000UV-PR for submit@debbugs.gnu.org; Sat, 09 May 2020 03:44:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXK9W-0000Ts-6j for 40859-done@debbugs.gnu.org; Sat, 09 May 2020 03:44:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46737) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXK9Q-00042H-UV; Sat, 09 May 2020 03:44:00 -0400 Received: from [176.228.60.248] (port=1080 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jXK9Q-0002bW-D2; Sat, 09 May 2020 03:44:00 -0400 Date: Sat, 09 May 2020 10:43:50 +0300 Message-Id: <83a72hh7t5.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel In-Reply-To: <5820e370-0933-be24-daae-0fb52f2d7ee8@gmail.com> (message from =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel on Sun, 26 Apr 2020 14:27:48 -0400) Subject: Re: bug#40859: Clicking the wrap-prefix string inside a button causes an error References: <837dy2746e.fsf@gnu.org> <98b37654-1133-05b7-a7b1-3f32b9a74ad9@gmail.com> <5820e370-0933-be24-daae-0fb52f2d7ee8@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40859-done Cc: 40859-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Clément Pit-Claudel > Cc: 40859@debbugs.gnu.org > Date: Sun, 26 Apr 2020 14:27:48 -0400 > > A slightly revised version. Thanks, pushed to the master branch. From unknown Sat Aug 16 21:23:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 06 Jun 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator