Subject: bug#40829: closed (Re: bug#40829: [core-updates] pdfpc-4.3.4 fails to build)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 24 Apr 2020 21:27:02 +0000

Your bug report

#40829: [core-updates] pdfpc-4.3.4 fails to build

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
40829: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40829
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#40829: [core-updates] pdfpc-4.3.4 fails to build
From: Marius Bakke <[email-masked]>
To: Jack Hill <[email-masked]>, [email-masked]
Date: Fri, 24 Apr 2020 23:26:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Jack Hill <[email-masked]> writes:

> Hi Guix,
>
> Currently, pdfpc on core-updates fails to build with:
>
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28: error: Creation method of abstract class cannot be public.
>          public ActionMapping() {
>          ^^^^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19: error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19: error: Creation method of abstract class cannot be public.
>          public Base(Metadata.Pdf metadata) {
>          ^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25: error: Creation method of abstract class cannot be public.
>          public TimerLabel(PresentationController controller, time_t start_time = 0) {
>          ^^^^^^^^^^^^^^^^^
> /tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19: error: Creation method of abstract class cannot be public.
>          public Base() {
>          ^^^^^^^^^^^
>
> Upgrading to the latest release, 4.4.0, solves the problem. I have 
> prepared the following patch against core-updates that does that.

Thanks!  I pushed the patch to the "master" branch: it will land on
"core-updates" shortly.

Subject: [core-updates] pdfpc-4.3.4 fails to build
From: Jack Hill <[email-masked]>
To: [email-masked]
Date: Fri, 24 Apr 2020 15:58:26 -0400 (EDT)
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Guix,

Currently, pdfpc on core-updates fails to build with:

/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/action/action_mapping.vala:51.9-51.28: error: Creation method of abstract class cannot be public.
         public ActionMapping() {
         ^^^^^^^^^^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/drawings/storage.vala:38.9-38.19: error: Creation method of abstract class cannot be public.
         public Base(Metadata.Pdf metadata) {
         ^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/renderer/cache/base.vala:40.9-40.19: error: Creation method of abstract class cannot be public.
         public Base(Metadata.Pdf metadata) {
         ^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/timer_label.vala:98.9-98.25: error: Creation method of abstract class cannot be public.
         public TimerLabel(PresentationController controller, time_t start_time = 0) {
         ^^^^^^^^^^^^^^^^^
/tmp/guix-build-pdfpc-4.3.4.drv-0/source/src/classes/view/behaviour/base.vala:44.9-44.19: error: Creation method of abstract class cannot be public.
         public Base() {
         ^^^^^^^^^^^

Upgrading to the latest release, 4.4.0, solves the problem. I have 
prepared the following patch against core-updates that does that.

Best,
Jack