GNU bug report logs - #40788
28.0.50; Error running timer ‘custom-magic-reset’

Previous Next

Full log

View this message in rfc822 format

From: David Ponce <da_vid <at> orange.fr>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 40788 <at> debbugs.gnu.org
Subject: bug#40788: 28.0.50; Error running timer ‘custom-magic-reset’
Date: Fri, 24 Apr 2020 17:56:42 +0200

On 24/04/2020 13:56, Robert Pluim wrote:
>>>>>> On Thu, 23 Apr 2020 19:39:26 +0200 (CEST), David PONCE <da_vid <at> orange.fr> said:
> 
>      David> Hello again,
>      David> Below is a possible patch that seems to have fixed the issue for me.
>      David> But I am not sure the approach is correct
> 
> Rather than defining a new function, you can add an argument to the
> existing one. Something like (untested)

Hi Robert,

Sure, your patch is better :-)
I tested it, and I confirm it fixes the issue :-)
I also tested the below variant, because it seems to me that it is not
necessary to set the buffer when magic is nil, as there is nothing to do.

Please feel free to apply which version looks better to you.
Thanks!

diff --git a/home/dponce/installs/emacs/lisp/cus-edit.el b/cus-edit.el
index d3d17fd..490d905 100644
--- a/home/dponce/installs/emacs/lisp/cus-edit.el
+++ b/cus-edit.el
@@ -2102,11 +2102,12 @@ and `face'."
 	(insert " "))
       (widget-put widget :children children))))
 
-(defun custom-magic-reset (widget)
+(defun custom-magic-reset (widget &optional buffer)
   "Redraw the :custom-magic property of WIDGET."
   (let ((magic (widget-get widget :custom-magic)))
     (when magic
-      (widget-value-set magic (widget-value magic)))))
+      (with-current-buffer (or buffer (current-buffer))
+        (widget-value-set magic (widget-value magic))))))
 
 ;;; The `custom' Widget.
 
@@ -2217,7 +2218,7 @@ and `face'."
       ;; commands like `M-u' (that work on a region in the buffer)
       ;; will upcase the wrong part of the buffer, since more text has
       ;; been inserted before point.
-      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget)
+      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget (current-buffer))
       (apply 'widget-default-notify widget args))))
 
 (defun custom-redraw (widget)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.